From nobody Mon Feb 9 17:25:14 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1769988632; cv=none; d=zohomail.com; s=zohoarc; b=EEecKWFfYOohLipeLOIDAbPkmYB1H6SZNqvAoerpeOGw0cQzIskq07vxFaSHy+N947ix4XCTg74vRt75WboudaSvZgDI+W8NBK1duQ6OEF4hhxfoM9HV9UjIO4HeZyofRgP/ao99XChoY5R0p1qavD6gmnlzSprU2C0rpCfAxPk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769988632; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=qLtJ/i/Ej2+3rrcoaflUWytYyH2WFju1TAatGa5vnlY=; b=I5nECNpF/b/RIN9UedMfAhkXNghHsoqbHYaRKL4tlV5OQYiLRvXI8b6r1L4qe+6P3ay/yuhs9aGTwQW9uL+Mm6CCTy/LnGAlxJ+31j+16ZIm3RVCNB902d/BtDbbUKSQ/aXD2Y25k/NKjPBPzdFwLPJiRFTfrOKs9pWDAyW5BPc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1769988632604616.6689750284119; Sun, 1 Feb 2026 15:30:32 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vmgtJ-0003iS-P4; Sun, 01 Feb 2026 18:30:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vmgtI-0003iB-OY for qemu-devel@nongnu.org; Sun, 01 Feb 2026 18:30:04 -0500 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vmgtH-0002t5-4M for qemu-devel@nongnu.org; Sun, 01 Feb 2026 18:30:04 -0500 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-432da746749so2148430f8f.0 for ; Sun, 01 Feb 2026 15:30:02 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e1353f8bsm37568608f8f.39.2026.02.01.15.29.58 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 01 Feb 2026 15:30:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769988601; x=1770593401; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qLtJ/i/Ej2+3rrcoaflUWytYyH2WFju1TAatGa5vnlY=; b=eYa9CD/6RKI1vS+byiaMOSY+QsSTUCyQDpr8R22oU8KB4now0dvzag0xL4eagghBU3 K3n9arAk72fcRSynQUWoPr4FSU/WNJQchZolkr3c0VfpFmFvemikDQjaKEM6m7/aoUnI dHiydfdf/WJWO3kSHmsNyHmdiNDR/RNfjGxJsUeOi3KZfLd3Q71Jwb1pvJcHjA8Ninwp lb+zHwTqio48Tlc6dkC4ytlQlsV/a6zwYaPpIrKpYDzWNNNvad23rD01RmBSTcsVUBoy /c7NC6o3imTfbSrDyccgxUYAKEpDIHRYf5rf99ZNQTZCygMdYjy+RCqWZ7dLlKo9Kd93 5qhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769988601; x=1770593401; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qLtJ/i/Ej2+3rrcoaflUWytYyH2WFju1TAatGa5vnlY=; b=E++LmCpeOnUyY7gZDBbH9UVtRXISlMMiCMZ6+SmUdmkbEq0yiIiOv+YuJdGyEgZ1Fp WxoU5xWQ05DURdWuX23Ow4Vu4CAp2Sioo18afI7UvHl7Bj2C24lyYSeeHYHUBx5vM/pF i65vX2HN1qWzT1atTWWIx3L65qW5tnKf9tl52FTRHGfpX2QnF8QQqN7SfNdh1fd+jRvZ OyR+imXvhVmoLj/3hzF0sis62JaNjboXLBpC+XjK5ZIr/yTj7DLm92uDMMVHN3tzTdkE h/3iQHblxgJEPx7bVPdl0ropCg0/8651Ew2l7ewig4OaSo2EbIb7JbhHMzpdwJytFjqP a+qQ== X-Gm-Message-State: AOJu0Yzt/Dhy+degMAOG7zDnlpiZ+FqcIccKqVfF0IcWzGA7dS9MEVdb Yrz1p7WyZeul5bKbTxod0iqoT/MJf/Y+tAek9PZJUh3q/uy03YbVPx31BRSBfjg9d3Cby+4qwys GUq0VGZQ= X-Gm-Gg: AZuq6aKC0urc1fjAruzenpbL7VZgjaxwecRYFQ9VguTfNtRBsGQxqQ+HdzT8GWzayYL e3p3l+Bb9L26pZ4dlP7/MPiSkOpYpYm8SvyAbl8F8p8zll7dSe2pBD/WAG4IMGvBnU8XeafY4T6 6jgnnsvZSvQj/SkfweQUKjUe9GtTXAbugIruTjPd7RnUL1RhVQYz7x/E5W5ssQ618aH7mA/1yrt Mcav2M+DJoUYN8pxNGGoAMAE6uBSxu9O6TbR47aSrVHkYvo7Hu65v7UsrDGrBBlqy1LBh195RYO FTh72Wu8o/GLq6qR184MCz5UfCZijuAPMSezTImE4iHlQ9CzIj3lWeSl2g41+Qd7csGHD+ek5Zg 1Ii6p6rq4h/NVm9DVCmcM4JdBfn24cpeBgbKgVPI0Ab3mk7mELqYELA8km6OuLcWlJjIPJaWN+m 5axoju5CQR/3IkuGj/cjGWh5QKwNVGP89PXGNu12654pKaZyKQemoPUcdAU5Ne X-Received: by 2002:a05:6000:400e:b0:435:8fd6:5949 with SMTP id ffacd0b85a97d-435f3abb1c5mr15681095f8f.46.1769988601357; Sun, 01 Feb 2026 15:30:01 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Harsh Prateek Bora , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Stefano Garzarella , "Michael S. Tsirkin" , Pierrick Bouvier , Nicholas Piggin , qemu-ppc@nongnu.org Subject: [PATCH v3 05/11] hw/virtio: Reduce virtio_access_is_big_endian() scope Date: Mon, 2 Feb 2026 00:29:17 +0100 Message-ID: <20260201232924.93399-6-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260201232924.93399-1-philmd@linaro.org> References: <20260201232924.93399-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=philmd@linaro.org; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1769988634011158500 virtio_access_is_big_endian() is only used once in virtio_reset(). Make the VirtIODevice argument const. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/virtio/virtio-access.h | 22 +--------------------- hw/virtio/virtio.c | 19 +++++++++++++++++++ 2 files changed, 20 insertions(+), 21 deletions(-) diff --git a/include/hw/virtio/virtio-access.h b/include/hw/virtio/virtio-a= ccess.h index f3b4d0075b5..c6b76979749 100644 --- a/include/hw/virtio/virtio-access.h +++ b/include/hw/virtio/virtio-access.h @@ -16,29 +16,9 @@ #ifndef QEMU_VIRTIO_ACCESS_H #define QEMU_VIRTIO_ACCESS_H =20 -#include "exec/hwaddr.h" +#include "qemu/bswap.h" #include "system/memory_cached.h" #include "hw/virtio/virtio.h" -#include "hw/virtio/virtio-bus.h" - -#if defined(TARGET_PPC64) || defined(TARGET_ARM) -#define LEGACY_VIRTIO_IS_BIENDIAN 1 -#endif - -static inline bool virtio_access_is_big_endian(VirtIODevice *vdev) -{ -#if defined(LEGACY_VIRTIO_IS_BIENDIAN) - return virtio_is_big_endian(vdev); -#elif TARGET_BIG_ENDIAN - if (virtio_vdev_has_feature(vdev, VIRTIO_F_VERSION_1)) { - /* Devices conforming to VIRTIO 1.0 or later are always LE. */ - return false; - } - return true; -#else - return false; -#endif -} =20 static inline void virtio_stw_p(VirtIODevice *vdev, void *ptr, uint16_t v) { diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 1dc60d37cb4..627a929b063 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -3233,6 +3233,25 @@ int virtio_set_features_ex(VirtIODevice *vdev, const= uint64_t *features) return ret; } =20 +#if defined(TARGET_PPC64) || defined(TARGET_ARM) +#define LEGACY_VIRTIO_IS_BIENDIAN 1 +#endif + +static bool virtio_access_is_big_endian(const VirtIODevice *vdev) +{ +#if defined(LEGACY_VIRTIO_IS_BIENDIAN) + return virtio_is_big_endian(vdev); +#elif TARGET_BIG_ENDIAN + if (virtio_vdev_has_feature(vdev, VIRTIO_F_VERSION_1)) { + /* Devices conforming to VIRTIO 1.0 or later are always LE. */ + return false; + } + return true; +#else + return false; +#endif +} + void virtio_reset(VirtIODevice *vdev) { VirtioDeviceClass *k =3D VIRTIO_DEVICE_GET_CLASS(vdev); --=20 2.52.0