From nobody Sat Feb 7 05:53:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1769988083; cv=none; d=zohomail.com; s=zohoarc; b=Ffyf9wdNpjYa9vY4upAYCtFDhVZMJITEwt3cgYBkY3oGmXNQl7mmDNmU3SvKzeDkOGmx/A9sBLZqm4isl51AZiAbMsDCJjOIC63dp8/LCr/j4D1put09iF/qBFFdc9dcf1kh/fISpuUP+8YDG8tAkcHg8KiWsTh4cFxQ/QoS1TM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769988083; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=qak0qGdqEv+ckuqbzm8qmTzP57U15an7kYIfscsbE3g=; b=mp3zDIyrCvsthCuEAvlyjJmk6lXRH9wklXuAh8/a0TVydIudzpVKdfBUGhQWp1B3nv74HXAMWlxWzj64lcLc+K0zXvgYYaF/29gPggOvrZFF8Bhve7TdL8bS9ABRT98fhDvsDve+HumuJt2uSWWRdM4abIcFpBANBloPT+wp2yM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17699880836390.18903240968847967; Sun, 1 Feb 2026 15:21:23 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vmgjm-00050M-SQ; Sun, 01 Feb 2026 18:20:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vmgjl-00050E-Ik for qemu-devel@nongnu.org; Sun, 01 Feb 2026 18:20:13 -0500 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vmgjj-0000DD-Ur for qemu-devel@nongnu.org; Sun, 01 Feb 2026 18:20:13 -0500 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-47ee76e8656so51103295e9.0 for ; Sun, 01 Feb 2026 15:20:11 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-482dbc7f580sm97990715e9.2.2026.02.01.15.20.07 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 01 Feb 2026 15:20:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769988010; x=1770592810; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qak0qGdqEv+ckuqbzm8qmTzP57U15an7kYIfscsbE3g=; b=MGJEtnnGRnh+S0RvieOVvptG2Pal6D7CAk5Ud37zBS4pTPvH/k8mzwkrJhi3t43Jda v9Ojl9lJB3LjJEVOg+e3HyWR6MtrARb6b0sBkytc+DnMD5FDLaR+aKXO1PVHDfzrshGe uK5o0Z/GDireFYfJ4ccpbsMBf+rWxNa55TAAkdZD9IhE2nYNXJnEI5juqFsx3LaLCUVC h80vOWYSVb7vQLKHx9ZGEJ45K3YRbYU9OhPx6eHOrvQYyPzHFrXk6qE8FJzhnRvewo92 afhbwUPHi5IPHAcBFSJ/9e9gIBhpFlOFP93mSQ84C4ErrsTDUZPXgPETaBMxroXzano8 Wk9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769988010; x=1770592810; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qak0qGdqEv+ckuqbzm8qmTzP57U15an7kYIfscsbE3g=; b=gwmk2Tp0ahYF4BRzVcuKCPjUb8uooMejVdcaRJIMZ+wV5nktE+toy/e4pCqDhVBWc7 EMhebVikO76HrNOSLhR/6uiIH6Uk19FR+MKNtSRqxg/pDs3KiQkU85Bc9CKUuhifOY6Q oX6FXWWklzXHv+LI640fGlIkr5gRjf9SNdA93YG7nhISXLmq8MDM2qSDga9c2v/En7fo jACA7LdIRw+IPqMXr7MjQ8/BJAjjLJmid06eiphnK8wJ41zUc+G+fwNkcSJSXUnOb74n 6szSiYemxmx9v3L+dft2YTiYHGiaI3LgRK/3rdZda24DmLiBrAsIhhcP6giu1FULVnBG 2c6w== X-Gm-Message-State: AOJu0YyzG9c7PAiB1XA1XiNpj1HEnePEQHniAl7Xsv7aSkri94GgDBQr q8vRlynZ3thIMA5nnUTxTuHMKJjw+Loc4+0qVNagtTfuyZtefjzKrAQS8puaxkakZNCIuJusyZ3 +RUbkTjk= X-Gm-Gg: AZuq6aKxLnXl05wconAeScQEkWgKqiLDv/qT38+8GvEnhFib18W8gu+6WoiyWE/X9eu cEtACdWOOKAzT5FITNbFaiWy+whuYW8muvm3DLA+WnuPXNsfgnufHr+ruf9VY7qgMJ8Y5YNx7cf huKVoEVqyP0cYMP/bepoEMvrttRocXACQbbQAQZDKGEJj8t9sgN2oI31VeaTYY0D5j+0tEyyRvI QUPlY6hkZ6763TsShJQwBXLF96CdG42XlIZuQURHujASMPuMpaUZ271pu32VowMOaZ3U1umUzQK TU6lVhhIGm3UwQMw201NNbYImV1fJ7gaK+fP+HQEvwdlQbWY+ql7D/X4etNHu9yVsJMO+xZE5+d a4+Q1zuMvUMVN+hGT6cRpNKs5TduNARJeMalDv0aKq5gW/Eh3YCghB9Bm3tVInGo3n0PdV949TC vjtGj4zeNHKZvHONsRRpq+LlhONn/BChNLdB3h4mUpbQrD0VpUL9G4KWoAfL4s X-Received: by 2002:a05:600c:34cb:b0:47e:e91d:73c0 with SMTP id 5b1f17b1804b1-482db4921bbmr123762465e9.19.1769988010156; Sun, 01 Feb 2026 15:20:10 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Stefano Garzarella Subject: [PATCH v2 01/10] target-info: add target_base_ppc, target_ppc and target_ppc64 Date: Mon, 2 Feb 2026 00:19:50 +0100 Message-ID: <20260201231959.88559-2-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260201231959.88559-1-philmd@linaro.org> References: <20260201231959.88559-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=philmd@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1769988086230158500 From: Pierrick Bouvier Signed-off-by: Pierrick Bouvier Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/qemu/target-info.h | 21 +++++++++++++++++++++ target-info.c | 21 +++++++++++++++++++++ 2 files changed, 42 insertions(+) diff --git a/include/qemu/target-info.h b/include/qemu/target-info.h index 62359622232..e3287334304 100644 --- a/include/qemu/target-info.h +++ b/include/qemu/target-info.h @@ -71,4 +71,25 @@ bool target_arm(void); */ bool target_aarch64(void); =20 +/** + * target_base_ppc: + * + * Returns whether the target architecture is PowerPC 32-bit or 64-bit. + */ +bool target_base_ppc(void); + +/** + * target_ppc: + * + * Returns whether the target architecture is PowerPC 32-bit. + */ +bool target_ppc(void); + +/** + * target_ppc64: + * + * Returns whether the target architecture is PowerPC 64-bit. + */ +bool target_ppc64(void); + #endif diff --git a/target-info.c b/target-info.c index 24696ff4111..5a6d7282524 100644 --- a/target-info.c +++ b/target-info.c @@ -73,3 +73,24 @@ bool target_aarch64(void) { return target_arch() =3D=3D SYS_EMU_TARGET_AARCH64; } + +bool target_base_ppc(void) +{ + switch (target_arch()) { + case SYS_EMU_TARGET_PPC: + case SYS_EMU_TARGET_PPC64: + return true; + default: + return false; + } +} + +bool target_ppc(void) +{ + return target_arch() =3D=3D SYS_EMU_TARGET_PPC; +} + +bool target_ppc64(void) +{ + return target_arch() =3D=3D SYS_EMU_TARGET_PPC64; +} --=20 2.52.0 From nobody Sat Feb 7 05:53:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1769988061; cv=none; d=zohomail.com; s=zohoarc; b=jKESCBRnuVqY5TuxWV6jIAwZe9ZqPOKuwsFs651C0KLd7d5hBbUL7NRX52wwBbzMUgHjgJTn4wsTh56kof95a3SmfZ6gdsWPYdtH3epcIVK8GlrXWx0RrNstttwJYWjXbbtpYui34IPnN0KAEHt+6bEDGJZBiYKlnQzuJkMbXok= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769988061; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=+h8fxES7OJzZ8FiNM/iLx0nwAq7x7TFBCRMWBp9kdf4=; b=M2RSv90Mg49z4vEHrv97NpaEMAaIU7jruuQTRZ6Lu4iJ83kcicYsK6q7L68krnBz8t/HHslE/rO8AymNF/cdVWksWzPP1LRT/CqMYXSAYco0pjitEhwYlNPa8HDaOPOZFDkFqGe+qcloaig8QcrlnZIpoRK7R9D+s/5JAaHo81I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1769988061024735.2136476043032; Sun, 1 Feb 2026 15:21:01 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vmgjv-000517-1N; Sun, 01 Feb 2026 18:20:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vmgjt-00050q-6V for qemu-devel@nongnu.org; Sun, 01 Feb 2026 18:20:21 -0500 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vmgjr-0000EH-LI for qemu-devel@nongnu.org; Sun, 01 Feb 2026 18:20:20 -0500 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-4805ef35864so31963345e9.0 for ; Sun, 01 Feb 2026 15:20:18 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-482e297119bsm74342285e9.17.2026.02.01.15.20.16 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 01 Feb 2026 15:20:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769988017; x=1770592817; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+h8fxES7OJzZ8FiNM/iLx0nwAq7x7TFBCRMWBp9kdf4=; b=wXtIok5UOllOIcM1giKU+P/NE0M/XRxCKwMu134s5mBiJJ5BJJllRg3n4GubaIkCYS PuhQ4oVUaDzxPggALIezhgRy0XYs1lWuHOIvnooCLr9jXMml48JrdMVxBw++ZAZE42K+ JQFud6Jx69kjXVTIwaZogomGhmv8BmE6lSektjMD20LD3FQt9GUj04DIEP3APANBYTgm KlQS5f1RjZSVVyBmJDCKTKeP3Ho9zLjQQmPEX+sWe9tH6NgXjndo7Zcv1sDZfRZojIXt D8Wdnz/jZp0Wvjh4Epbe2fv+IpHfUr2B/6OT0A53YQap3YqdsmyEEk3SdMcIzl8BSejM zPMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769988017; x=1770592817; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+h8fxES7OJzZ8FiNM/iLx0nwAq7x7TFBCRMWBp9kdf4=; b=KLjtq6Dk6MBt2RMCzH8+HYFFXckFS/r6j2kqFiViCWP8NyfE4opIvoprsga7pIgWe0 XmDI5pnFVIJmX3a1HkjQBu1oTGhvvuIHt7j5xhLX8j7asV8o2PTdhwUi04U2Ixoo5DMR OCzNU2bNEh2UZpCWg19a16mHTh9XHXghm2K6/WbMwMrpktxAGv/w05zYw+7PbPNgDqVp XS4pdLATPL1Z70RL8Q/ZKLTEZ+To1FeGxKWL0a/CQULPLH4Uppgh2NbLWlkEut403Dq/ iLXo88VlRtbZ2+HlSRDkfYLp+4KLhucd7mYxpZPRsIpdJGy78UFf4mFe02QCv6pNPAyc zBSA== X-Gm-Message-State: AOJu0YzukfKVZ4+FOiUEGfAmHteYu8zcIDSqVhSjLPkNQAo30QjA+g3u BgFCnXDd1dqmE/05SKs9MQJXwg+pX6hMEfYPR9A3j+coTLfiHGBOMEpJw6VoKCseTn3U8kgI+xZ 2JZUl/nE= X-Gm-Gg: AZuq6aLJTujVB189OiDoRIBMclvmyGbEixrDdtfQ6plyKFN3hcXJXOcSyNfkiiKmmV4 4htzsAKoL0QRQEvEJ1AlQuK1/NpSAuRuhWYCnDWqxO3powGlgHHq/JTLPTFuJ9IEGLNyo4Wx2DA AGXvjFrsoomF4mPQPgu4oE3vXrnUVQDZZ2uLqhGFFMV3CBjPd7P8bThk+Fr+JtVwwWoWDWJ1OMg pkiJACBbNSsVNJHo08XPeQ+Ml9vHTlKgxXDVoGuS74Jn4I7sfLb5/AjZXr5e/VMOFs9C2e/oGv+ zPGJINKgRZiADwnN83j2qcylgiN6niR2nraAyUkzxrhg4j4O9fCBAzU78rEm9my8tWFsjUtLXF7 liY6EEnHXsRFs0HSCNTAH/IIi7etj7997DkiZmi9VUZ76oVLD8sKqeFgErpBOJ4FVArcoh/iWVy JbtcBVD8A4CT3744hW9N0PDVNbDJRjDUuyjmKvEbL82+asqWGry6LWJLGvyLY0ypuxRvv/EKA= X-Received: by 2002:a05:600c:8b61:b0:477:b642:9dc9 with SMTP id 5b1f17b1804b1-482db4866d7mr112879385e9.28.1769988017065; Sun, 01 Feb 2026 15:20:17 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Stefano Garzarella Subject: [PATCH v2 02/10] hw/virtio: Constify virtio_is_big_endian() argument Date: Mon, 2 Feb 2026 00:19:51 +0100 Message-ID: <20260201231959.88559-3-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260201231959.88559-1-philmd@linaro.org> References: <20260201231959.88559-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=philmd@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1769988062345158500 VirtIODevice argument is accessed read-only, make it const. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/virtio/virtio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h index fcaa9b03b4a..17b105c146d 100644 --- a/include/hw/virtio/virtio.h +++ b/include/hw/virtio/virtio.h @@ -468,7 +468,7 @@ static inline bool virtio_host_has_feature(VirtIODevice= *vdev, return virtio_has_feature(vdev->host_features, fbit); } =20 -static inline bool virtio_is_big_endian(VirtIODevice *vdev) +static inline bool virtio_is_big_endian(const VirtIODevice *vdev) { if (!virtio_vdev_has_feature(vdev, VIRTIO_F_VERSION_1)) { assert(vdev->device_endian !=3D VIRTIO_DEVICE_ENDIAN_UNKNOWN); --=20 2.52.0 From nobody Sat Feb 7 05:53:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1769988069; cv=none; d=zohomail.com; s=zohoarc; b=VsFC3+3/d+kHYFjUddsn0CEOKCGr7ICvdRw3sgtYwAKYb+iv1xawUIJjQG6nRG1ZSRbUTcaRqST7DjSr4Um9iZTFCf+chB+f6fNDO41bDZoDNiQMbwtD2IpN9wggPn/6PO5/cePNG4lXNDMNrxit+kuzV9m+dFauOY7NAwx0y1o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769988069; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=EAuDEWjgtcjAI73PpDk9D1EoNYCz8v3TBHOpftqU/Uk=; b=BSRc/tnBS+3Sk9Qhc/iPG7+dCo46Ts0XabmecdQLcrMV7aIMPZRVkhOJQg/isJJ25KT9Y07SndCDIYT9jgdHdpLx5YadZl1z+5/I4uL2nU9udiUlm+zM6LlbliAVi44zF8naY5HF/AZB4PP3sBJ4jnVE1dXfcqM9u+v+6VEbEDA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1769988069056935.3154634342076; Sun, 1 Feb 2026 15:21:09 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vmgk0-000531-Qo; Sun, 01 Feb 2026 18:20:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vmgjz-00051V-Ve for qemu-devel@nongnu.org; Sun, 01 Feb 2026 18:20:28 -0500 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vmgjy-0000H8-Fg for qemu-devel@nongnu.org; Sun, 01 Feb 2026 18:20:27 -0500 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-48068127f00so32306715e9.3 for ; Sun, 01 Feb 2026 15:20:25 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4806cddffe9sm507872655e9.4.2026.02.01.15.20.23 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 01 Feb 2026 15:20:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769988024; x=1770592824; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EAuDEWjgtcjAI73PpDk9D1EoNYCz8v3TBHOpftqU/Uk=; b=FOuft4NweEY+IbSuazrUqK5s4F32jHW0m9TGPbtPjfN6HaD5wWMBTyB26CP1x7T01j hTn1/nEFHEyKM0DPlD0pv4xFDVHv7havIAWuUvEYVlHUnIMQiGeuBpMIoUXweXdLjivs q3Q+U8l2J4L+6GaJSRsV/Z1GAwen878+qjhRsOdbK51iX5Ui4qzMuQiYjz9HsXh5Ls9e OVKZdLoRCPp6em4gZpL8rbptyPU8AciRBo9BZuWvMZIGmKUI+7gUq2qiBPLFG24JuAwr X4h4plgxkvfjV0w+EHbFiaAuSAMuqvnZ9C67UYEOp8xZeL0fclwPSNNmKFwZy48G8jns NnBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769988024; x=1770592824; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=EAuDEWjgtcjAI73PpDk9D1EoNYCz8v3TBHOpftqU/Uk=; b=wtg18l9Ypw0KJ1zpYOvPCjC9G1KkFqGDK5KYqRkpRg4Nf5Dax8z4LwZSdMyNnK4UFU uz+abIvbv8Dv9GK/diHRAVf8xu6pXKoH44YfXv3Y5bza1pbxAwZ/xVwCwc7Sdvosd2jn H3MN0gIYjg5Zq11KKX1jBaPYE4gQldAAU7YqeEpyCqgRqcXTBFK1izGnNfIbpbYe9ahd MwL7KYimu9r+Hz9H3L0XoHNyReKf9VeiIcPp9/N9XCvNByj6C8WIM+e1wdi0MNV/mdBI ZBCp0b5Puf7KEp4FrkD57UKTLznbAHPR1FPd7+Ie+McW0WriW0Giur8j+dp/kKQNa2nC m88A== X-Gm-Message-State: AOJu0Yw8Mp8SvmBuuKb2GrtYPpvvhYyzytb4fTlhPHMO6LYN9js5gPQU ToMahJPhHy8DcfLEfpy3MXUVw7dAvLWflSCFDm/703vrawHT1YI1uf8FEpnJDQI1QJi8Dg7L6CU ceATXkgc= X-Gm-Gg: AZuq6aLToHsHrs3ErzggvPuVAASOh5zP3dOzN+CyETxL290t4/XhGbaUhwAEJ/gB9MJ zE+Od5bqZGZAVfQGmOWNNImLR00HKw9BC+iS7cpUFTi0jeWkjgvz3B2sJm2E5MsCf/JZQwfpxnX Hhaj+0yLQRfZPVAMjx5cnqxFUILOCtMQBIpXq3kezWlHEtbFAE274Ba5tzrSbmuhxrMB/X7Rp2q 4wKml86Am8nWLZ3hzl3pROlHTR9gonw0B2SLQzo/u255KqL6dG1XnuUquHnbdJZ8lr7e5M5D6dg 2vWWId3EXSaqe7Ji3yGuTduyC8/3r/GnKvNAr31fhAERs7VLnQR7bVsQH1ftoJcSSgWWyQmSDWb iTdJKhM9jiUR0QBzqhMz+pkgyZ/3R+bztQatCZlw1rqQXXW2cZnayV4rnUdbz+kEXP2BlwXjJQ3 GLidjuGZSmhL7QtDs7XFfLkj9Blkad3X2OJpXJOgHR24FWorJDzHoUQeWSpBJ5 X-Received: by 2002:a05:600c:358d:b0:480:f27c:6335 with SMTP id 5b1f17b1804b1-482db499704mr137519085e9.25.1769988024354; Sun, 01 Feb 2026 15:20:24 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Stefano Garzarella Subject: [PATCH v2 03/10] hw/virtio: Introduce VirtIODevice::access_is_big_endian boolean field Date: Mon, 2 Feb 2026 00:19:52 +0100 Message-ID: <20260201231959.88559-4-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260201231959.88559-1-philmd@linaro.org> References: <20260201231959.88559-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=philmd@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1769988070177158500 VirtIODevice::access_is_big_endian boolean field, initialized on device reset, represents whether load/store accesses are ordered using big endianness. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/virtio/virtio.h | 5 +++++ hw/virtio/virtio.c | 1 + 2 files changed, 6 insertions(+) diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h index 17b105c146d..7a4f7de7475 100644 --- a/include/hw/virtio/virtio.h +++ b/include/hw/virtio/virtio.h @@ -154,6 +154,11 @@ struct VirtIODevice VMChangeStateEntry *vmstate; char *bus_name; uint8_t device_endian; + /** + * @access_is_big_endian: whether load/store memory accesses are order= ed + * using big endianness. Might change during device resets. + */ + bool access_is_big_endian; /** * @user_guest_notifier_mask: gate usage of ->guest_notifier_mask() ca= llback. * This is used to suppress the masking of guest updates for diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 86fc0e262f7..242c207a591 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -3247,6 +3247,7 @@ void virtio_reset(VirtIODevice *vdev) /* System reset */ vdev->device_endian =3D virtio_default_endian(); } + vdev->access_is_big_endian =3D virtio_access_is_big_endian(vdev); =20 if (k->get_vhost) { struct vhost_dev *hdev =3D k->get_vhost(vdev); --=20 2.52.0 From nobody Sat Feb 7 05:53:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1769988102; cv=none; d=zohomail.com; s=zohoarc; b=PTnmVssmDstPyqOj/k9cHzIc6KhV3U/NTmT2qPRbwRRiakFaO/QmGIafbXi8pA/bDNMdd2Dk8UDN8fHiOxQfADedO03Zp1LaokVqkTa3gAxeGQToZ4Uv2cfz5oGLL9TUzRG6uYvCFDm5MNtIzrSqiXslU7+bKZFyfRyZZnEKZ+g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769988102; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/mFBINwlnbUzimo0bMmKTtdWLFjMVHtdrIxAzG6it5I=; b=TrC9s8JWFxrsCbBc3Cu5NuyvJ31e/ampFOXO5WpkDFH+vilm75s+YQ4nrCFZmiilxyLK73QTMpQXB8nO0xxIkPX0rIAxQkZI7gwY5o/QXaWuMeijr4PZvYd6ewhFQmzzWcS3BGGmy4tDrU0uP7JtpSCjpyUzuzW05qPnNlJ1Z/E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1769988102098462.31690195708654; Sun, 1 Feb 2026 15:21:42 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vmgkA-0005CW-D4; Sun, 01 Feb 2026 18:20:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vmgk8-0005C7-9F for qemu-devel@nongnu.org; Sun, 01 Feb 2026 18:20:36 -0500 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vmgk6-0000KK-Md for qemu-devel@nongnu.org; Sun, 01 Feb 2026 18:20:36 -0500 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-42fb6ce71c7so3177582f8f.1 for ; Sun, 01 Feb 2026 15:20:33 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e131ce64sm40883981f8f.26.2026.02.01.15.20.30 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 01 Feb 2026 15:20:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769988032; x=1770592832; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/mFBINwlnbUzimo0bMmKTtdWLFjMVHtdrIxAzG6it5I=; b=V25oD4Heiwy9BJTKIQV8ps+zVLIchM2dhTd9HketsyQJIaQr0MuoB4rwQTM0v+a+bl Ql3Q7aASIW8+180qXe4U0pgjGaGVTdBR4WqlsE0B427fmdP1a/IE2BZ//ReMX7obk4na qn76GUJ/fQalFOXBLyfOjrAwukWRp3L48Nqpe81heIOXnpYtjmUDo2I3ykATWi7FPgem a4av8P+5Rt/VLg7G8OxkX8wXPl6bVyg10KX5YqZAkOdZl0fTUvVY9ymVBd/hv4rwZtpj Y+bdno+vaYdDMlndlifzzX6PGxim3uzFv+zpRkz5zClc4y73EsAl7Xlcah4a+jpRigey P1cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769988032; x=1770592832; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/mFBINwlnbUzimo0bMmKTtdWLFjMVHtdrIxAzG6it5I=; b=aShuS3/oNh7+DQnncJQ4u75IqtBT3eVDR3zwJexMhMwgjuXen3DCfCFv84G+H7bIhR 4AT16vzvhwwYvp9wuo48TXoCCV9srRckTWr8QmEXPO4hr1W21Z1CV9HRSffj0gRBI02V EOGq9IPt5Y+elsVqgEAd6y4IbMI1hlgiS4Fwhbc98Z4dTHJhjePzkn0OZZkaEcRQTqWR eiuVd/U7n77wSwESrOUQOwzF5gNVqiu1PTxlWYhXe4OCFHq7a1shZO4hJEilnOmHD0tg qtgUwAtlesEmZTd8o9JJCu/KaaZXroF+RL5vHUA3MY/8aqYMLjQ7bzJzj3BpO1woK2D3 Tayw== X-Gm-Message-State: AOJu0YxqpauRMO43pVPjhEw3GHvOOrdAxwrd7r+T/2NtuPtDdY7FOypA bmmyPCJRYxYTaTPEptFBZrPXc2wJxsCjH5So26Ctli5qTShTFLmxeo+S8PE6bcry5xjScMD6zuK 6Sgk/oDQ= X-Gm-Gg: AZuq6aKIlJRG8sOxFHvThF/uczxlJHsh8mBY6Egg4cFgbSMhYAm/Ufnej3/41kyHxJQ H1mF5y/+Xn8m5yvgMqVyGXQDVEHfn/XtbKJyTNfzI/dA5XGicDCAjW+w9JgugbhnvQ7lj/vBN+T m+/dC5LNQZdSRWQCTUX5CCzLK1Mdg3tQbF7SpsM6BZvTfCiyXXMQON7gEaN8134tzrSx4pzsteD YgrnCSDqtJZfMMyhpF5SZOoaVyS+HhZ3JsQpLnsKafoNgTFPSGen3UHTLxqcutk8A5c0uwet2R2 YYhlt+2fgdqbYWS8qH1NKbskqeqh3XPxzoT6hWOlcfdeoigqNmDcrnJpIDnPMcLXaWJYImZ1lQc tbzaBs968ZAx7FDD5w29lYZob7YDiZwU1W8P4Gaykt13caqjeLnwLahvid3pgMa/ABDov004hmw 73CyCk4Gw7lGhJGKCoV9/qTU2YZ+JOvci9BW9xhjEq9xOGNYOd2SUhoNfLGNUN X-Received: by 2002:a05:6000:4205:b0:435:e3d5:cf7a with SMTP id ffacd0b85a97d-435f3aaf745mr13627492f8f.44.1769988032147; Sun, 01 Feb 2026 15:20:32 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Stefano Garzarella Subject: [PATCH v2 04/10] hw/virtio: Use VirtIODevice::access_is_big_endian field Date: Mon, 2 Feb 2026 00:19:53 +0100 Message-ID: <20260201231959.88559-5-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260201231959.88559-1-philmd@linaro.org> References: <20260201231959.88559-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=philmd@linaro.org; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1769988104316158500 Endianness access is constant between device resets. Use the field instead of calling the same function. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/virtio/virtio-access.h | 24 ++++++++++++------------ hw/virtio/virtio.c | 4 ++-- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/include/hw/virtio/virtio-access.h b/include/hw/virtio/virtio-a= ccess.h index cd17d0c87eb..f3b4d0075b5 100644 --- a/include/hw/virtio/virtio-access.h +++ b/include/hw/virtio/virtio-access.h @@ -42,7 +42,7 @@ static inline bool virtio_access_is_big_endian(VirtIODevi= ce *vdev) =20 static inline void virtio_stw_p(VirtIODevice *vdev, void *ptr, uint16_t v) { - if (virtio_access_is_big_endian(vdev)) { + if (vdev->access_is_big_endian) { stw_be_p(ptr, v); } else { stw_le_p(ptr, v); @@ -51,7 +51,7 @@ static inline void virtio_stw_p(VirtIODevice *vdev, void = *ptr, uint16_t v) =20 static inline void virtio_stl_p(VirtIODevice *vdev, void *ptr, uint32_t v) { - if (virtio_access_is_big_endian(vdev)) { + if (vdev->access_is_big_endian) { stl_be_p(ptr, v); } else { stl_le_p(ptr, v); @@ -60,7 +60,7 @@ static inline void virtio_stl_p(VirtIODevice *vdev, void = *ptr, uint32_t v) =20 static inline void virtio_stq_p(VirtIODevice *vdev, void *ptr, uint64_t v) { - if (virtio_access_is_big_endian(vdev)) { + if (vdev->access_is_big_endian) { stq_be_p(ptr, v); } else { stq_le_p(ptr, v); @@ -69,7 +69,7 @@ static inline void virtio_stq_p(VirtIODevice *vdev, void = *ptr, uint64_t v) =20 static inline int virtio_lduw_p(VirtIODevice *vdev, const void *ptr) { - if (virtio_access_is_big_endian(vdev)) { + if (vdev->access_is_big_endian) { return lduw_be_p(ptr); } else { return lduw_le_p(ptr); @@ -78,7 +78,7 @@ static inline int virtio_lduw_p(VirtIODevice *vdev, const= void *ptr) =20 static inline int virtio_ldl_p(VirtIODevice *vdev, const void *ptr) { - if (virtio_access_is_big_endian(vdev)) { + if (vdev->access_is_big_endian) { return ldl_be_p(ptr); } else { return ldl_le_p(ptr); @@ -87,7 +87,7 @@ static inline int virtio_ldl_p(VirtIODevice *vdev, const = void *ptr) =20 static inline uint64_t virtio_ldq_p(VirtIODevice *vdev, const void *ptr) { - if (virtio_access_is_big_endian(vdev)) { + if (vdev->access_is_big_endian) { return ldq_be_p(ptr); } else { return ldq_le_p(ptr); @@ -97,9 +97,9 @@ static inline uint64_t virtio_ldq_p(VirtIODevice *vdev, c= onst void *ptr) static inline uint16_t virtio_tswap16(VirtIODevice *vdev, uint16_t s) { #if HOST_BIG_ENDIAN - return virtio_access_is_big_endian(vdev) ? s : bswap16(s); + return vdev->access_is_big_endian ? s : bswap16(s); #else - return virtio_access_is_big_endian(vdev) ? bswap16(s) : s; + return vdev->access_is_big_endian ? bswap16(s) : s; #endif } =20 @@ -111,9 +111,9 @@ static inline void virtio_tswap16s(VirtIODevice *vdev, = uint16_t *s) static inline uint32_t virtio_tswap32(VirtIODevice *vdev, uint32_t s) { #if HOST_BIG_ENDIAN - return virtio_access_is_big_endian(vdev) ? s : bswap32(s); + return vdev->access_is_big_endian ? s : bswap32(s); #else - return virtio_access_is_big_endian(vdev) ? bswap32(s) : s; + return vdev->access_is_big_endian ? bswap32(s) : s; #endif } =20 @@ -125,9 +125,9 @@ static inline void virtio_tswap32s(VirtIODevice *vdev, = uint32_t *s) static inline uint64_t virtio_tswap64(VirtIODevice *vdev, uint64_t s) { #if HOST_BIG_ENDIAN - return virtio_access_is_big_endian(vdev) ? s : bswap64(s); + return vdev->access_is_big_endian ? s : bswap64(s); #else - return virtio_access_is_big_endian(vdev) ? bswap64(s) : s; + return vdev->access_is_big_endian ? bswap64(s) : s; #endif } =20 diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 242c207a591..1dc60d37cb4 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -220,7 +220,7 @@ static inline uint16_t virtio_lduw_phys_cached(VirtIODe= vice *vdev, MemoryRegionCache *cache, hwaddr pa) { - if (virtio_access_is_big_endian(vdev)) { + if (vdev->access_is_big_endian) { return lduw_be_phys_cached(cache, pa); } return lduw_le_phys_cached(cache, pa); @@ -230,7 +230,7 @@ static inline void virtio_stw_phys_cached(VirtIODevice = *vdev, MemoryRegionCache *cache, hwaddr pa, uint16_t value) { - if (virtio_access_is_big_endian(vdev)) { + if (vdev->access_is_big_endian) { stw_be_phys_cached(cache, pa, value); } else { stw_le_phys_cached(cache, pa, value); --=20 2.52.0 From nobody Sat Feb 7 05:53:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1769988068; cv=none; d=zohomail.com; s=zohoarc; b=MLgGXX15l1w7DYLhdjKVDn3FKN6+RIcV5lXdu8q4rDA6Zi1kn/HtHwljbIr42l/uoRsziVWOiyEJSj7H7UqKzhpcK5HRgTz4JwkY4TuKhXD3mEcB/q1ZYUOWVKvjbNGd2UgJPyIKL14p9ZaAO+2egizWryjfLh82OlAjYxxUTG8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769988068; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=qLtJ/i/Ej2+3rrcoaflUWytYyH2WFju1TAatGa5vnlY=; b=kZVSMZA4I2cLEAlb2ondnB4uDNgaL+kvfpiSkVvX5ecz5Yjl5JqqXJ7ht/vdewbUw5w4ob6dyU8XhDX6s3PYDqA8v7jyZCuw/PzhNSaKOHU7rG/QiEoqDfYRVOQNKKNIIX9qQ3DRW4EDCX4sM+zzpnkidWh8N4+5jop9GIATWn8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176998806889032.803936967506615; Sun, 1 Feb 2026 15:21:08 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vmgkG-0005QB-7W; Sun, 01 Feb 2026 18:20:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vmgkE-0005MQ-DN for qemu-devel@nongnu.org; Sun, 01 Feb 2026 18:20:42 -0500 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vmgkC-0000LL-QS for qemu-devel@nongnu.org; Sun, 01 Feb 2026 18:20:42 -0500 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-4805ef35864so31964235e9.0 for ; Sun, 01 Feb 2026 15:20:40 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48066c37420sm446531005e9.9.2026.02.01.15.20.38 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 01 Feb 2026 15:20:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769988039; x=1770592839; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qLtJ/i/Ej2+3rrcoaflUWytYyH2WFju1TAatGa5vnlY=; b=j26XsGQGiSZkq9UcLcDr7zDVzhAU/WvK76B/58sTxVBAYheh1d29dCJ7QdudqjX1K7 H4iCupHFaba3aH8IotWhgTuDMXWzlQanHuIf9A7Y5nO16fuN7XlnjwKV6nGazPP/TWIu EI/EMdGISIqhuTaJSf/6eAVNQZFKSYg+zwkFUja0s48F9TDTztnb4TsaTwqHc61IKud7 7yZPSbOnwd431Ig1YeWHim0kHclhYbsQhEfLV5crwWzKausn++8R7rlfpl/S1PcESXYi ii44Cr3LKVwsdSNZ7sSN5dTAY6VN9H3gDQxHtAADcwQmIVcplnrTbIgCHAAo3OhSoYLx vi9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769988039; x=1770592839; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qLtJ/i/Ej2+3rrcoaflUWytYyH2WFju1TAatGa5vnlY=; b=QP52NFMlEBs43GsuFPc+HfI9XRjvIgVBppWs94HcKtbXUjRtOpwBA6kfcxLcUOekHz t0PTEY+Jwl2XTTzaK/hBhdUS9y/1kl0CzboQkOcEimhiwWd2/g6U93ClWZMvfxWzUTu/ aXvoGCxE0Bqgt5Tucs6DSJNsdIxmZsEonCeexXi2c+okNDqE4Nd+q+FpOvZQ0krtszW0 j6Aj+ZW5Z3sGUlsajnBzj1dtbPaXq/0WT4PDdbvpl/AAf7RPWbCCa4GOw0SgFwiPiEUB a71MfQvlDtl7WrCuJRhG0oUCpSXzgaHrMjPHrohZnry7vNUdfaTE2+wd3Prewmw6/jnF IVVA== X-Gm-Message-State: AOJu0YyYiOMmuV8G8ZUecVBdMGQfhCAqj35OjeTOlH5TZWCTaXkFuWzc omXgwKZz3dCvWZiefmKSVaOJT4JDzsFmLWeGpIkHo4qFS5SO2VBso/WPkcMtUC7+bgPWilMY8o/ ur37KwMo= X-Gm-Gg: AZuq6aJpLq98JWSGn5UbRgSgCa9ZWseDw/xKD8aYqPSqhvLEePGIc5S4FZ4dIldP0ft s+PWQaX3jGnp3E9PiKgmOrBN3EFjcQaI4yuYe5IH/3kkl+s2G7zimiqhmlIk2InlLnvv2ru9aDA v+8fsfvn4mXEDYKDtTayaYsA8LO2yx9eESnqpUgn4dClahw9NyelmOyUwhxMNgLbkd5sfQR7uAt hI/wi0cTEp4xxlWH1OQ+9Z5B2CK8DedTIj/LOHZjjgxTI0TJ2uCAUVEZTGL+fKPx3BkaKBThqEx opsmdPMXs09VCKETF0AWFno52u8WndNkKpz/VJHH8klO6oCDIreVN+OWROXJ6CcK273PDQeSoqo 1zpc6YVGOkGT300XiuMPc4Ukulwa98CA1mPJj1C7B4g1+Ve74JAxurJQgWhJgHEReLoECo/kDUx CRNO9/LAtXTwfc95HxCPTLl275Y88qgYOt1NOTqZvj9a+dTkzIS33abs4VCc2e X-Received: by 2002:a05:600c:6214:b0:479:3a86:dc1f with SMTP id 5b1f17b1804b1-482db4973c7mr114254855e9.37.1769988039062; Sun, 01 Feb 2026 15:20:39 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Stefano Garzarella Subject: [PATCH v2 05/10] hw/virtio: Reduce virtio_access_is_big_endian() scope Date: Mon, 2 Feb 2026 00:19:54 +0100 Message-ID: <20260201231959.88559-6-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260201231959.88559-1-philmd@linaro.org> References: <20260201231959.88559-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=philmd@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1769988070203158501 virtio_access_is_big_endian() is only used once in virtio_reset(). Make the VirtIODevice argument const. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/virtio/virtio-access.h | 22 +--------------------- hw/virtio/virtio.c | 19 +++++++++++++++++++ 2 files changed, 20 insertions(+), 21 deletions(-) diff --git a/include/hw/virtio/virtio-access.h b/include/hw/virtio/virtio-a= ccess.h index f3b4d0075b5..c6b76979749 100644 --- a/include/hw/virtio/virtio-access.h +++ b/include/hw/virtio/virtio-access.h @@ -16,29 +16,9 @@ #ifndef QEMU_VIRTIO_ACCESS_H #define QEMU_VIRTIO_ACCESS_H =20 -#include "exec/hwaddr.h" +#include "qemu/bswap.h" #include "system/memory_cached.h" #include "hw/virtio/virtio.h" -#include "hw/virtio/virtio-bus.h" - -#if defined(TARGET_PPC64) || defined(TARGET_ARM) -#define LEGACY_VIRTIO_IS_BIENDIAN 1 -#endif - -static inline bool virtio_access_is_big_endian(VirtIODevice *vdev) -{ -#if defined(LEGACY_VIRTIO_IS_BIENDIAN) - return virtio_is_big_endian(vdev); -#elif TARGET_BIG_ENDIAN - if (virtio_vdev_has_feature(vdev, VIRTIO_F_VERSION_1)) { - /* Devices conforming to VIRTIO 1.0 or later are always LE. */ - return false; - } - return true; -#else - return false; -#endif -} =20 static inline void virtio_stw_p(VirtIODevice *vdev, void *ptr, uint16_t v) { diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 1dc60d37cb4..627a929b063 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -3233,6 +3233,25 @@ int virtio_set_features_ex(VirtIODevice *vdev, const= uint64_t *features) return ret; } =20 +#if defined(TARGET_PPC64) || defined(TARGET_ARM) +#define LEGACY_VIRTIO_IS_BIENDIAN 1 +#endif + +static bool virtio_access_is_big_endian(const VirtIODevice *vdev) +{ +#if defined(LEGACY_VIRTIO_IS_BIENDIAN) + return virtio_is_big_endian(vdev); +#elif TARGET_BIG_ENDIAN + if (virtio_vdev_has_feature(vdev, VIRTIO_F_VERSION_1)) { + /* Devices conforming to VIRTIO 1.0 or later are always LE. */ + return false; + } + return true; +#else + return false; +#endif +} + void virtio_reset(VirtIODevice *vdev) { VirtioDeviceClass *k =3D VIRTIO_DEVICE_GET_CLASS(vdev); --=20 2.52.0 From nobody Sat Feb 7 05:53:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1769988105; cv=none; d=zohomail.com; s=zohoarc; b=ZPpEmLpiJ0lmMzN6ly8XrFRH2JSIwBSJ10GBALH22F6Xbe5hsH8mO9f6pk4Lb2nwNU6N4k/4nvKchwR1vIgtgn56u6N7DDboOQHTVrgPzACuMZDBPE+RNxFpiC8v4vPRAUnrBwlRNixozBrezG16AUk6oyD6SBGIy/uNPrlD8Kw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769988105; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=7jNtMN+TApjyuOmbux0fVfOi0ZSmxtuwv6TQan6eaBM=; b=lx+xIOS7zMHnuny0cGvH5acYPERYwmIkHTIUtLABz0mK6c72jw3nowzXe4yUIXzec8BD0VpI9pakRf7lQVprDC+8wf2qUpRSd62n92xvwRbhRxUU0yw7Sz2l7bOBC3G+S34RQEgFEKxKdN25gSUVm0P+R/RWsuHWWtKccbdyixQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1769988105625653.0062007229002; Sun, 1 Feb 2026 15:21:45 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vmgkM-0005bU-HK; Sun, 01 Feb 2026 18:20:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vmgkL-0005b1-GW for qemu-devel@nongnu.org; Sun, 01 Feb 2026 18:20:49 -0500 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vmgkK-0000Lj-0f for qemu-devel@nongnu.org; Sun, 01 Feb 2026 18:20:49 -0500 Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-432d2c7dd52so4023030f8f.2 for ; Sun, 01 Feb 2026 15:20:47 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10ee04csm39845445f8f.12.2026.02.01.15.20.45 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 01 Feb 2026 15:20:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769988046; x=1770592846; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7jNtMN+TApjyuOmbux0fVfOi0ZSmxtuwv6TQan6eaBM=; b=Z76F5BBAecFWyTXAmgUrxkksB2n6hfrW7L5vtKVNtxSCOGFB0+6bSJY3+E/GQW0O7y R1MaSDv0XadnZl5UwsV1v/QMtsMo9uyaZx0Dt05uvSX+MnR9lFAcH2mG95HKY4FYrg1k KhbM18yWUfaolD7VCOqh+dNh4lPHgik/AhVPnzCvcTaBA5tTjA27ZeqthYreCSlrFrrR nTzl0+SvwA8GsMgDaX5lFGJQ7hmLmMApayt8DXIusD/wjMJDTtartDLbtlwNhFH4RBsU rN+2bBroDyhpBbUqoVtvmrr0G/Go2tsMmZFxjjkWltYRzy1UOYBKjhnwdiAM2xTjIaaj kPxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769988046; x=1770592846; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7jNtMN+TApjyuOmbux0fVfOi0ZSmxtuwv6TQan6eaBM=; b=qS1rswHaSATS5LDmTeL0xf8AxX6Hfm5baoQYgT+qkqvluP7QdaopH3W6M83vg9JqzJ 5g1sZoY49g9Q40/BiynL2XQ5d7Z0d2zR7Q0ALsbKTmZAo5YyVWzX4QYvFP4Bvq4hpG1C PfSTPebhoVa6nRjg3d8XdRssWeb8iA3zLXUFmsDK4Pa92urkeNVgj64dBYwYJLl54lks Mw1yJtl3fYjxfwbYES9m1U93aYKMm/SovKLcbF+brFAPd9/+ub8HEMhD6saoLUVSZQ5e Eq8bd7FL/b4241Ayvt64J7pfZjWykS8zPYjSPOyV5zlMP5gxBmU7MZhaobP2q4r9LYD5 2Dgg== X-Gm-Message-State: AOJu0YzvLtK1aeSQh4hMVFDFVNa3fBSiweKNLEt3IlIIZ/0BbE0FCeNX IDQut9i4syw8Y+2whO+uq2ZnqA5KC6PyYuacaRDghRFbMc6kBBjO88WsfqyBOgpfMJnlEiPz48D /sMowyt4= X-Gm-Gg: AZuq6aL+PmD63pmhJeJwKKkEc3xRY8/CxEzTjAqLn1mMLNDmJBQAsa6sZ6eDPDswqHW KNLju7oEfxflPOsm0MR1KPHtM19pReLuXQQelU3rH2WMBcW3IXWEKoryERlEGrlf+AGS5jfqby0 rrBggUyg8FbosBzvGPlLv6m0iqm4D+9yrM4gZVnBrJMPYvOY06qB9fmm7kcYTMe1Td3nFMs5w+K ZQ/WSc00I9i/IpqpJnK9uJY3YFyyK594+zYtRdGl5xhYW8O0v6Ziinjzn5LS1G0Gvf8wCiFcOf4 7+HqaMcwce4DVCJMvbGgmiO8g/JxCUi+J+jQDfXJGYaC78kknf/VkpqPyOiXZ4zyJE5urkNwsLE L2yMHDKMkFGU5cCnOJE2j9f3855AAhuYZoHgOTNPl49PQoeVsOocp+BNR1GJHj/WUn+pwd7dQtZ g7qeKZJBJanscvNNgABwDRnn9+kFOyRofn5nmcJnPlEyHSJn8Z57nVfgEP/8oR X-Received: by 2002:a05:6000:240f:b0:435:a9c9:159 with SMTP id ffacd0b85a97d-435f3a91f94mr14006534f8f.18.1769988046148; Sun, 01 Feb 2026 15:20:46 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Stefano Garzarella Subject: [PATCH v2 06/10] hw/virtio: Check target supports legacy bi-endianness at runtime Date: Mon, 2 Feb 2026 00:19:55 +0100 Message-ID: <20260201231959.88559-7-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260201231959.88559-1-philmd@linaro.org> References: <20260201231959.88559-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=philmd@linaro.org; helo=mail-wr1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1769988106273158500 Convert build-time check by a runtime one using the TargetInfo API. Inspired-by: Pierrick Bouvier Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/virtio/virtio.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 627a929b063..d64ecc29a89 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -3233,15 +3233,17 @@ int virtio_set_features_ex(VirtIODevice *vdev, cons= t uint64_t *features) return ret; } =20 -#if defined(TARGET_PPC64) || defined(TARGET_ARM) -#define LEGACY_VIRTIO_IS_BIENDIAN 1 -#endif +static bool target_is_legacy_virtio_biendian(void) +{ + return target_ppc64() || target_base_arm(); +} =20 static bool virtio_access_is_big_endian(const VirtIODevice *vdev) { -#if defined(LEGACY_VIRTIO_IS_BIENDIAN) - return virtio_is_big_endian(vdev); -#elif TARGET_BIG_ENDIAN + if (target_is_legacy_virtio_biendian()) { + return virtio_is_big_endian(vdev); + } +#if TARGET_BIG_ENDIAN if (virtio_vdev_has_feature(vdev, VIRTIO_F_VERSION_1)) { /* Devices conforming to VIRTIO 1.0 or later are always LE. */ return false; --=20 2.52.0 From nobody Sat Feb 7 05:53:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1769988086; cv=none; d=zohomail.com; s=zohoarc; b=gXouW+vus5ISbN6GmClgobgoGtJ7LomLcS0KweMCeNGtECibSv5QWoZ4ecPLmb9977FfZ5XJ9PX+O+pfrL6O2+Jz4Z9Ekqdpd6uk1hBVR+lapwTy6+mWWYO0SkJ4t7IJ883YpM2vxHGz/vD4pSllv1kxmreleKQpLYOST4gu4FQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769988086; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=lJ2uWCeP8pV22XPIuG+XMR/jSRA5vjFNUShUwB++kLM=; b=SLHXb0qtl2nfY2Pc+FgYEPmtdAn1tZI8FDz4Kd1GbTq+8J4yr6TRaWdKzCV+eqA1GxsrJJqEfHRcIVUdau1CKxO8PqWotaGLOAVqRtop5PlWpNz2gR1NLTMZGRTvv6CV/JObRmGuNvgQyJkdJZA931UPFdzj/qh9X/Y1+w4XY70= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176998808652545.63300900105253; Sun, 1 Feb 2026 15:21:26 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vmgkd-00067T-Uk; Sun, 01 Feb 2026 18:21:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vmgkT-0005oL-5e for qemu-devel@nongnu.org; Sun, 01 Feb 2026 18:21:00 -0500 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vmgkR-0000Mo-Hf for qemu-devel@nongnu.org; Sun, 01 Feb 2026 18:20:56 -0500 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-42fb0fc5aa9so2552321f8f.1 for ; Sun, 01 Feb 2026 15:20:55 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10e4762sm37559633f8f.6.2026.02.01.15.20.52 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 01 Feb 2026 15:20:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769988054; x=1770592854; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lJ2uWCeP8pV22XPIuG+XMR/jSRA5vjFNUShUwB++kLM=; b=er2DCJRB/Ua6iLzOdo2LsAKFi2BwJl+OkPbR5iZ/8ORrL7cawA3ikk2uyBGWp81+Mw uUwg+cWxeXTE7PKEeeIy8fJ1BavUmEkfXs5WMP5NlFTf/SnNJQ8ziPHKMGcwOIfUtz/9 xFouWDzGvfBM8XlHiJxb7LVMmCGMJLDlpow0mh+HvqGYyngXtxpzavsGu7m5ETnIVzAg tFd9TTYIhM8vGXOUxnOHjAtfrOYdNNgRuKDwjB5ytkQcEfpgSbG9uPMYjbK/4iJiBHf0 Ejo4VZR3ODANrI+1EMAL7ZSOQ+V1Qf2/almvhiIKuQfaej+xCxVJwNRCCf7yrkZ2UVfe ixMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769988054; x=1770592854; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lJ2uWCeP8pV22XPIuG+XMR/jSRA5vjFNUShUwB++kLM=; b=vcMDq2um3oyEqdeFX6/o+diLKZtRgP5nYRrQy0uZDq9/d7pcCFow5r8QpYUydxOdqe L/gEGoZ8Oeh6rn0wzwxsFVfmr607X7/xwZzG3+vSPlGh7uecwwqcb0KIdngUqsBcHOb2 UOjDn4Kkra4qcajAP8Hi4fejxr/1wpoMRI8mASoHTv1meOuWlTe4rsAkeLO45QIKyUfw 2R1Cr93NVA2D7d1aC6cdnuhSd+14sgzmaKu44BfZSAb22VxRC4xav7zdZhlkguKRzM+m 5SenAzr2tUxetzZjwRfYq1uoUmEUxiyNKyxrWveVIzHc8jFc3tSjLoeDkmkQ5BaA/sfi p/dQ== X-Gm-Message-State: AOJu0YxVWbE8H7Lnv1Z3PgEYBKW3ZVcmRhiWRj6mwhjZUV1l/Q3izG2a 2vcyAoQ2xgmOiRoh6fHlWRFXD/lGgsQoH5kZ4OYur0HFalVgH9/f4Sn5q7Wdeuu9yIIJdAhaHsl 54bPESaQ= X-Gm-Gg: AZuq6aKdD+nUXW2eltiAmsWOpzme/fQJUzci3nrXGMWuhu5tkAPuSHlA5dEQZtNj5bo +5vOsDx80Zgzg014g2uaP+yokSaOrDIGTJUP/47ym3FPy+D8ruSsdtAuraqQ5emfSTGIbRAnDW5 oJID4n3jqQCkHJ23Hjq2fSnrk1MFz7//AuMi1NPBCEETUAiXjlc2fnXEkR7IrY60by3GfVe9lHE i26HG3JpPzDYBGMuCFT5WPTLOxXHCwPVUyN9dt37McUzMC32o6d98LdE+n2d4wm5zKVeelwHgro 6Pi/ggNHk1XymYoLLde+0fR5lnZSBlditEsQYODGByn5uavg/ys2bBPOvJYTR/uZcdHQyHOkBN0 u220cjqJHo7OVfVi/SKErwk4UzUevume+7mfaiDgaGqDExxWQWNd+alN+Ln7QZpHvm1vSTH0pX9 pzUmKhsLKrI3PStK2Fd2dAKqEWxTyxEZcRhfBp4RtIgus+rsE4TZpo++0oaZc+ X-Received: by 2002:a05:6000:2910:b0:435:a673:bca1 with SMTP id ffacd0b85a97d-435f3a82586mr13923439f8f.27.1769988053694; Sun, 01 Feb 2026 15:20:53 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Stefano Garzarella Subject: [PATCH v2 07/10] hw/virtio: Replace TARGET_BIG_ENDIAN -> target_big_endian() Date: Mon, 2 Feb 2026 00:19:56 +0100 Message-ID: <20260201231959.88559-8-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260201231959.88559-1-philmd@linaro.org> References: <20260201231959.88559-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=philmd@linaro.org; helo=mail-wr1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1769988088156158500 Check endianness at runtime to remove the target-specific TARGET_BIG_ENDIAN definition. Inspired-by: Pierrick Bouvier Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/virtio/virtio.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index d64ecc29a89..9c5563f9bec 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -3243,15 +3243,14 @@ static bool virtio_access_is_big_endian(const VirtI= ODevice *vdev) if (target_is_legacy_virtio_biendian()) { return virtio_is_big_endian(vdev); } -#if TARGET_BIG_ENDIAN + if (!target_big_endian()) { + return false; + } if (virtio_vdev_has_feature(vdev, VIRTIO_F_VERSION_1)) { /* Devices conforming to VIRTIO 1.0 or later are always LE. */ return false; } return true; -#else - return false; -#endif } =20 void virtio_reset(VirtIODevice *vdev) --=20 2.52.0 From nobody Sat Feb 7 05:53:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1769988083; cv=none; d=zohomail.com; s=zohoarc; b=ArQ0GWlVNFbxQhDvK1GBGyGcYvglx1XlhkWL6WtKCLV4GkVJkD0Hd3+Hj1M5+sYL6qpaqNSTCMq0c6E1ZWrCDc/t2DbDOVfYwrBGRYuClwG6pwwKjtflBmd+H5sz4AK1XiionjySVtoBGR9p1V5ItFqsVGoo1gp/FuAeeqzRmXQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769988083; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=3y8sx2MjjH2xIWfAsCvCax2QQJrx+zY+UiIZh3tX/d0=; b=Z+QsdOLFUeKxDALTq/IsJPNTZ6hRBdRKZhBRKyU9jwTlMJIIdsUki5YNeuOtZ8B0Dt0bN0jKx1HgD8W47Z+w8QaSF2FeGrfYMf2LRqhF8lj5vn7iTYU5TyvHOpUZeZvtoabaGRkG1yuZGjbzY21UAlDI0GI0M8z8l5MPRC/zZJg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176998808374172.81658294467479; Sun, 1 Feb 2026 15:21:23 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vmgki-0006I7-7C; Sun, 01 Feb 2026 18:21:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vmgka-0005xL-F3 for qemu-devel@nongnu.org; Sun, 01 Feb 2026 18:21:04 -0500 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vmgkY-0000N2-Cn for qemu-devel@nongnu.org; Sun, 01 Feb 2026 18:21:03 -0500 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-47f5c2283b6so31490725e9.1 for ; Sun, 01 Feb 2026 15:21:02 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48066c40e04sm428898275e9.13.2026.02.01.15.20.59 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 01 Feb 2026 15:20:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769988061; x=1770592861; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3y8sx2MjjH2xIWfAsCvCax2QQJrx+zY+UiIZh3tX/d0=; b=ZxF3MvnMgolGAIMN0vKmPyDffY6bVXzI5YRw6FmoRUKdNQCBn/wiy9R4OweQ9ayRRh sh2gom2HfzB0WqwPmCRl4f5oafM9O4jcDamgLqNyBWHe+hmGiK5l2oSvIyDYJD925rmg Z11FKP2DWyitq82aIS7csRfWQ4hgn1ekuJtM1eATOEQxxafufPTHwshO1gycpYBCAvcF BRVzUoE7jyroh3V9x0jq8VPcC0c5WwCvqUYirM07OWV+GT5FZmV+ScWcEhBtUzzORTdN 8z+7Y1Iyx2a1wCbniOmDEAEbHNYpD8rARZGX7AQvRlWzloxJZsLEeKZ/REtXHPCfyT6v 2eIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769988061; x=1770592861; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3y8sx2MjjH2xIWfAsCvCax2QQJrx+zY+UiIZh3tX/d0=; b=mpXvBJmflS6ORx+cNh7CbsMCyXcVZUwmcuDMCrKfdL5ZdtZM0E56wHM3pIijU665zh gtjwKJxXkDBZeX7mI8n5GgK/lGihxSST4Ru8Pa3zYc4gSddSA7s78aHNpNSY0MQWi+SI 0oDrrEQQCVGwtPDJW3R/vL0g+Wgh4PGVZayMN+bwcJTJtC531UYzVuLaF8+LGUSwaaWE kbqPN/k9BgME/fdhk0LCR8gKw4p64WDsOVb1+3I9yhWMcBXIVZHIVNp2OUsuJUqOdRJu K/omt4vljoDwu97jy0/riL/SbOp7wE61J+5rfx/Kj1vfKFlUaaMoVae8Lax69YnNEZBm tqvA== X-Gm-Message-State: AOJu0Yxtgo44ags/jAFGNUL7YHvWcdPwaGjqBHxlktOTjXcqJzEBD0xI VGYjVtrtJWJ1xJLadR0H4TPVHaNs2ax/LCfNN5/ZXkXs6bkJh12Z0nEW4mkEEFGaRcsKC4pjfIX D+MX+bkQ= X-Gm-Gg: AZuq6aIiMBW27tcXRZ1Z4iiAf3pbywUsk/QYfqxSR1qblhIZvKfj2q1nxn49TlM2jBE jaARLFcTxNIE8aD94HaY0s5V/6Rr9tFy3chrcwX2EN/Bq1pYEznCiI8mrowB87i+AJmKATs027P UgIxrsdAl6IeHPdh+8yD8rvRXY9WkvWkYSGc5gStv1u+MBU5RK9jwOMSALqP3tKCj89pq77K+Rr kXzNIDDVUP3i1BnN5+E4XLc1edKDV7dzfvZS4Tijxc9zJqnrqDA6D87nABx4mh6gsDGpbgunHX4 tX6pAKREZhXaF5KNUK8eKKBkk0tWsxIzBbFy4tXuBSNVg81awL7Tl+X/6ylnfA/MtFiUjMe5bCB Ep1hYxd3Km+aZiE9sQIXcrk385JeL4t9N9YWLoNpexTPszy/rchT8TjSEf+PlKhVmbR1Slg45Po 70UxF4fSE0p+PCN34+Z/Anr98a+DgpTwaFrj9ZxF4TNjAJrpQan1EFxoP7WlWe X-Received: by 2002:a05:600c:4443:b0:477:79c7:8994 with SMTP id 5b1f17b1804b1-482db4a0fb8mr140679925e9.30.1769988060668; Sun, 01 Feb 2026 15:21:00 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Stefano Garzarella Subject: [PATCH v2 08/10] hw/virtio/vhost-user: make compilation unit common Date: Mon, 2 Feb 2026 00:19:57 +0100 Message-ID: <20260201231959.88559-9-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260201231959.88559-1-philmd@linaro.org> References: <20260201231959.88559-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=philmd@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1769988084173158500 From: Pierrick Bouvier PPC architectures use a custom value for VHOST_USER_MAX_RAM_SLOTS (32 instead of 512). vhost_user struct and several functions use VHOST_USER_MAX_RAM_SLOTS to define stack allocated buffers. To avoid changing all functions to use heap allocated buffers, we keep this max, and simply add a target_base_ppc() conditional for the single place where size really matters. Signed-off-by: Pierrick Bouvier Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/virtio/vhost-user.c | 11 ++++------- hw/virtio/meson.build | 3 +-- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index 63fa9a1b4b1..c8a004c6d2d 100644 --- a/hw/virtio/vhost-user.c +++ b/hw/virtio/vhost-user.c @@ -44,13 +44,8 @@ #define VHOST_USER_F_PROTOCOL_FEATURES 30 #define VHOST_USER_BACKEND_MAX_FDS 8 =20 -#if defined(TARGET_PPC) || defined(TARGET_PPC64) -#include "hw/ppc/spapr.h" -#define VHOST_USER_MAX_RAM_SLOTS SPAPR_MAX_RAM_SLOTS - -#else +#include "hw/ppc/spapr_common.h" #define VHOST_USER_MAX_RAM_SLOTS 512 -#endif =20 /* * Maximum size of virtio device config space @@ -2280,7 +2275,9 @@ static int vhost_user_backend_init(struct vhost_dev *= dev, void *opaque, return -EINVAL; } =20 - u->user->memory_slots =3D MIN(ram_slots, VHOST_USER_MAX_RAM_SL= OTS); + const uint64_t vhost_user_max_ram_slots =3D target_base_ppc() ? + SPAPR_MAX_RAM_SLOTS : VHOST_USER_MAX_RAM_SLOTS; + u->user->memory_slots =3D MIN(ram_slots, vhost_user_max_ram_sl= ots); } } =20 diff --git a/hw/virtio/meson.build b/hw/virtio/meson.build index affd66887db..ee397aaf196 100644 --- a/hw/virtio/meson.build +++ b/hw/virtio/meson.build @@ -17,8 +17,7 @@ if have_vhost system_virtio_ss.add(files('vhost.c')) system_virtio_ss.add(files('vhost-backend.c', 'vhost-iova-tree.c')) if have_vhost_user - # fixme - this really should be generic - specific_virtio_ss.add(files('vhost-user.c')) + system_virtio_ss.add(files('vhost-user.c')) system_virtio_ss.add(files('vhost-user-base.c')) =20 # MMIO Stubs --=20 2.52.0 From nobody Sat Feb 7 05:53:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1769988089; cv=none; d=zohomail.com; s=zohoarc; b=fUNMUlDiG9sHCURW3YoGlo7wJAfdrdRCeTdJ09NZMn7+hShjlJc5xU4n8jvNCyubRAtpd33/U9KWjjCACsbktc4fk3uSt9bZVVPVwUxjP8YwyNjHBCfosdNZXQMBj3E7jkqS5psoln991Msnwqa9xELdEImX69SPisj2j2ONZEk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769988089; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=XI4QauyUtUX66wtBIBxmVsjci7j411/fWovI3rGHj/g=; b=IuuBslUwnukdfhUenLI4edOfGC+FPnsTgCYcpyqe8xIPMoOJEnQLn2gTnYJawS10UqMpWJCXau+3W6dCqGDVwITcXnxBlP838i/XrJrzfTWBnjX0rhHg1Ep66QR+S3CaHcM6+j6VSsIUPNcKamnQz4s2NM8kr+APwkLgj/szu9g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1769988089505540.0428865125085; Sun, 1 Feb 2026 15:21:29 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vmgkn-0006jL-W4; Sun, 01 Feb 2026 18:21:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vmgkj-0006Pg-Sv for qemu-devel@nongnu.org; Sun, 01 Feb 2026 18:21:14 -0500 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vmgkh-0000OY-3G for qemu-devel@nongnu.org; Sun, 01 Feb 2026 18:21:13 -0500 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-48068ed1eccso34673745e9.2 for ; Sun, 01 Feb 2026 15:21:10 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-482da91a227sm98532615e9.2.2026.02.01.15.21.06 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 01 Feb 2026 15:21:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769988069; x=1770592869; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XI4QauyUtUX66wtBIBxmVsjci7j411/fWovI3rGHj/g=; b=z8o5JHlBf9hJBWs5+RiVAXIpTBNzFUQ5oT1Yf7No8zbFpQj8z2h1/3KCVOT0WFV8YN fQld19qcAvLegjic2j/iGlQJGw6e0VWpbOxJCHAukczO+jm3y3cAR8dlqv2/9Bdraftf 33027wEQpZnzdV6rzTRsF9MK1mo/wHbEgo1cm6xPb+eQ4VNJSi+/mySNeJ8ceWPdfVgy MBAfxR/on/2eMykIv4ANDlvQ0YLHzJO7ciubTwwD67ulrOE0t9gP4+YvmVPEsc5dPLtV UC61K8eXI0ydlJWt0M+DNHEF2nQ9MCLYHNLprTKoP+cmfDMUwKnmj4FHscLnhAGg98iQ 5QBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769988069; x=1770592869; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XI4QauyUtUX66wtBIBxmVsjci7j411/fWovI3rGHj/g=; b=ODo9lW28a3kgekuHGWZuyCGf5vgMajaaj+ZiGgoZrq2ecfcv1w2j9grdwpgNIA5Ji4 +XVfFzB+JskBG3yDYaNwlO30jcBl1J2ym3C8/4g0xHNy6j9YRhEsCl/+cg8dS1zFP0Bg /LcKCOclIutICoOUkM43ZR6bEjRpO5eS/mF9uBCRgfOXFFwjH6haAdAMzQ5EDo3ua4fP rLuzWZP+lbuuHIq6OldYQLyMz0eVKCUZ3wxsjgD0CsMslnPKTnwZaseW0WpDBpfuIznY bPnMw1zuvawZy01wWOFA61MUYQSuQtNGKzj21Ya7kQ3EQFJdcmf5IQSDyKBo5rvMtfV0 zTow== X-Gm-Message-State: AOJu0Yy85D/8bnPVSEbaSBHLlCA3oacyzeYLyyS2sYbwcm7gii7Xg0Ri 8qGbju8A5aF1dVusz8HlUQolXI6Kub8euFlo4ANWRH6hLzyRVlQsN6wHc/5+al468MlEv2zlKCL PeIO/8DI= X-Gm-Gg: AZuq6aJqhbQnyHes/xXSNDyAoJkFZG1zg3Yyx5O49sq1p0h0oRMtXm0Jy2xvIm46cWX 8O6QSP3u2tydfkHqnk+pMbOv3RodJwz7cn82CSDGsQIjhmshsNZRQsh+gvcm2/HDHykHtXkTdVz NH7mpezp5w1e/IHxbPqKm+U61KpnYDn/QHYkiQRLvo9L622YH2Pb1Yt4GnJclt6igQeKn+lWnHf lDYWlt96NVNiBAkKvoFpgFVv2+/kLWezaSUcoZp0wtpUNhoNsxCBO05Ia8xv4FG0ioRo5xmuLrf MNzrFHh8xjZQsgi/VE92nzHjn5nh8/C0ivUR9SjE7qYcLGWvWAb+iVo0Hah9iJ3vkCMnBX2YYOE 8eyEh0dPmtMx11L56siw652DWPl40irTw4HkOQHioYGSFN9Il/AgZHUaRk8YYjU1kBkZTLAKk3h YYkS3Fd3CEujx1+WFggkFqwW+Qt4V6BU1nu89uB0Q6ZoxgD5ve4Rt5dcdAh7vTM/h0XRHyGGk= X-Received: by 2002:a05:600c:6218:b0:477:7bca:8b2b with SMTP id 5b1f17b1804b1-482db45cd74mr122841765e9.15.1769988069017; Sun, 01 Feb 2026 15:21:09 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Stefano Garzarella Subject: [PATCH v2 09/10] hw/virtio/virtio-qmp: make compilation unit common Date: Mon, 2 Feb 2026 00:19:58 +0100 Message-ID: <20260201231959.88559-10-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260201231959.88559-1-philmd@linaro.org> References: <20260201231959.88559-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=philmd@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1769988090355158500 From: Pierrick Bouvier All compile time conditionals have no impact at runtime, since they are representing only possible features for devices present at runtime. In case they are not present, associated features table will never be used. In case they are present but some features are not, matching bits will never be enabled, so those entries will be unused. Thus, simply expose everything and call it a day. Signed-off-by: Pierrick Bouvier Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/virtio/virtio-qmp.c | 70 ------------------------------------------ hw/virtio/meson.build | 2 +- 2 files changed, 1 insertion(+), 71 deletions(-) diff --git a/hw/virtio/virtio-qmp.c b/hw/virtio/virtio-qmp.c index 968299fda0c..f9cdca50d99 100644 --- a/hw/virtio/virtio-qmp.c +++ b/hw/virtio/virtio-qmp.c @@ -33,21 +33,17 @@ #include "standard-headers/linux/virtio_vsock.h" #include "standard-headers/linux/virtio_gpio.h" =20 -#include CONFIG_DEVICES - #define FEATURE_ENTRY(name, desc) (qmp_virtio_feature_map_t) \ { .virtio_bit =3D name, .feature_desc =3D desc } =20 /* Virtio transport features mapping */ static const qmp_virtio_feature_map_t virtio_transport_map[] =3D { /* Virtio device transport features */ -#ifndef VIRTIO_CONFIG_NO_LEGACY FEATURE_ENTRY(VIRTIO_F_NOTIFY_ON_EMPTY, \ "VIRTIO_F_NOTIFY_ON_EMPTY: Notify when device runs out of avai= l. " "descs. on VQ"), FEATURE_ENTRY(VIRTIO_F_ANY_LAYOUT, \ "VIRTIO_F_ANY_LAYOUT: Device accepts arbitrary desc. layouts"), -#endif /* !VIRTIO_CONFIG_NO_LEGACY */ FEATURE_ENTRY(VIRTIO_F_VERSION_1, \ "VIRTIO_F_VERSION_1: Device compliant for v1 spec (legacy)"), FEATURE_ENTRY(VIRTIO_F_IOMMU_PLATFORM, \ @@ -149,7 +145,6 @@ static const qmp_virtio_feature_map_t virtio_config_sta= tus_map[] =3D { }; =20 /* virtio-blk features mapping */ -#ifdef CONFIG_VIRTIO_BLK static const qmp_virtio_feature_map_t virtio_blk_feature_map[] =3D { FEATURE_ENTRY(VIRTIO_BLK_F_SIZE_MAX, \ "VIRTIO_BLK_F_SIZE_MAX: Max segment size is size_max"), @@ -173,7 +168,6 @@ static const qmp_virtio_feature_map_t virtio_blk_featur= e_map[] =3D { "VIRTIO_BLK_F_SECURE_ERASE: Secure erase supported"), FEATURE_ENTRY(VIRTIO_BLK_F_ZONED, \ "VIRTIO_BLK_F_ZONED: Zoned block devices"), -#ifndef VIRTIO_BLK_NO_LEGACY FEATURE_ENTRY(VIRTIO_BLK_F_BARRIER, \ "VIRTIO_BLK_F_BARRIER: Request barriers supported"), FEATURE_ENTRY(VIRTIO_BLK_F_SCSI, \ @@ -183,7 +177,6 @@ static const qmp_virtio_feature_map_t virtio_blk_featur= e_map[] =3D { FEATURE_ENTRY(VIRTIO_BLK_F_CONFIG_WCE, \ "VIRTIO_BLK_F_CONFIG_WCE: Cache writeback and writethrough mod= es " "supported"), -#endif /* !VIRTIO_BLK_NO_LEGACY */ FEATURE_ENTRY(VHOST_F_LOG_ALL, \ "VHOST_F_LOG_ALL: Logging write descriptors supported"), FEATURE_ENTRY(VHOST_USER_F_PROTOCOL_FEATURES, \ @@ -191,10 +184,8 @@ static const qmp_virtio_feature_map_t virtio_blk_featu= re_map[] =3D { "negotiation supported"), { -1, "" } }; -#endif =20 /* virtio-serial features mapping */ -#ifdef CONFIG_VIRTIO_SERIAL static const qmp_virtio_feature_map_t virtio_serial_feature_map[] =3D { FEATURE_ENTRY(VIRTIO_CONSOLE_F_SIZE, \ "VIRTIO_CONSOLE_F_SIZE: Host providing console size"), @@ -204,10 +195,8 @@ static const qmp_virtio_feature_map_t virtio_serial_fe= ature_map[] =3D { "VIRTIO_CONSOLE_F_EMERG_WRITE: Emergency write supported"), { -1, "" } }; -#endif =20 /* virtio-gpu features mapping */ -#ifdef CONFIG_VIRTIO_GPU static const qmp_virtio_feature_map_t virtio_gpu_feature_map[] =3D { FEATURE_ENTRY(VIRTIO_GPU_F_VIRGL, \ "VIRTIO_GPU_F_VIRGL: Virgl 3D mode supported"), @@ -227,10 +216,8 @@ static const qmp_virtio_feature_map_t virtio_gpu_featu= re_map[] =3D { "negotiation supported"), { -1, "" } }; -#endif =20 /* virtio-input features mapping */ -#ifdef CONFIG_VIRTIO_INPUT static const qmp_virtio_feature_map_t virtio_input_feature_map[] =3D { FEATURE_ENTRY(VHOST_F_LOG_ALL, \ "VHOST_F_LOG_ALL: Logging write descriptors supported"), @@ -239,10 +226,8 @@ static const qmp_virtio_feature_map_t virtio_input_fea= ture_map[] =3D { "negotiation supported"), { -1, "" } }; -#endif =20 /* virtio-net features mapping */ -#ifdef CONFIG_VIRTIO_NET static const qmp_virtio_feature_map_t virtio_net_feature_map[] =3D { FEATURE_ENTRY(VIRTIO_NET_F_CSUM, \ "VIRTIO_NET_F_CSUM: Device handling packets with partial check= sum " @@ -313,10 +298,8 @@ static const qmp_virtio_feature_map_t virtio_net_featu= re_map[] =3D { "device with same MAC addr. supported"), FEATURE_ENTRY(VIRTIO_NET_F_SPEED_DUPLEX, \ "VIRTIO_NET_F_SPEED_DUPLEX: Device set linkspeed and duplex"), -#ifndef VIRTIO_NET_NO_LEGACY FEATURE_ENTRY(VIRTIO_NET_F_GSO, \ "VIRTIO_NET_F_GSO: Handling GSO-type packets supported"), -#endif /* !VIRTIO_NET_NO_LEGACY */ FEATURE_ENTRY(VHOST_NET_F_VIRTIO_NET_HDR, \ "VHOST_NET_F_VIRTIO_NET_HDR: Virtio-net headers for RX and TX " "packets supported"), @@ -341,10 +324,8 @@ static const qmp_virtio_feature_map_t virtio_net_featu= re_map[] =3D { "header"), { -1, "" } }; -#endif =20 /* virtio-scsi features mapping */ -#ifdef CONFIG_VIRTIO_SCSI static const qmp_virtio_feature_map_t virtio_scsi_feature_map[] =3D { FEATURE_ENTRY(VIRTIO_SCSI_F_INOUT, \ "VIRTIO_SCSI_F_INOUT: Requests including read and writable dat= a " @@ -364,10 +345,8 @@ static const qmp_virtio_feature_map_t virtio_scsi_feat= ure_map[] =3D { "negotiation supported"), { -1, "" } }; -#endif =20 /* virtio/vhost-user-fs features mapping */ -#ifdef CONFIG_VHOST_USER_FS static const qmp_virtio_feature_map_t virtio_fs_feature_map[] =3D { FEATURE_ENTRY(VHOST_F_LOG_ALL, \ "VHOST_F_LOG_ALL: Logging write descriptors supported"), @@ -376,10 +355,8 @@ static const qmp_virtio_feature_map_t virtio_fs_featur= e_map[] =3D { "negotiation supported"), { -1, "" } }; -#endif =20 /* virtio/vhost-user-i2c features mapping */ -#ifdef CONFIG_VIRTIO_I2C_ADAPTER static const qmp_virtio_feature_map_t virtio_i2c_feature_map[] =3D { FEATURE_ENTRY(VIRTIO_I2C_F_ZERO_LENGTH_REQUEST, \ "VIRTIO_I2C_F_ZERO_LEGNTH_REQUEST: Zero length requests suppor= ted"), @@ -390,10 +367,8 @@ static const qmp_virtio_feature_map_t virtio_i2c_featu= re_map[] =3D { "negotiation supported"), { -1, "" } }; -#endif =20 /* virtio/vhost-vsock features mapping */ -#ifdef CONFIG_VHOST_VSOCK static const qmp_virtio_feature_map_t virtio_vsock_feature_map[] =3D { FEATURE_ENTRY(VIRTIO_VSOCK_F_SEQPACKET, \ "VIRTIO_VSOCK_F_SEQPACKET: SOCK_SEQPACKET supported"), @@ -404,10 +379,8 @@ static const qmp_virtio_feature_map_t virtio_vsock_fea= ture_map[] =3D { "negotiation supported"), { -1, "" } }; -#endif =20 /* virtio-balloon features mapping */ -#ifdef CONFIG_VIRTIO_BALLOON static const qmp_virtio_feature_map_t virtio_balloon_feature_map[] =3D { FEATURE_ENTRY(VIRTIO_BALLOON_F_MUST_TELL_HOST, \ "VIRTIO_BALLOON_F_MUST_TELL_HOST: Tell host before reclaiming " @@ -424,19 +397,15 @@ static const qmp_virtio_feature_map_t virtio_balloon_= feature_map[] =3D { "VIRTIO_BALLOON_F_REPORTING: Page reporting VQ enabled"), { -1, "" } }; -#endif =20 /* virtio-crypto features mapping */ -#ifdef CONFIG_VIRTIO_CRYPTO static const qmp_virtio_feature_map_t virtio_crypto_feature_map[] =3D { FEATURE_ENTRY(VHOST_F_LOG_ALL, \ "VHOST_F_LOG_ALL: Logging write descriptors supported"), { -1, "" } }; -#endif =20 /* virtio-iommu features mapping */ -#ifdef CONFIG_VIRTIO_IOMMU static const qmp_virtio_feature_map_t virtio_iommu_feature_map[] =3D { FEATURE_ENTRY(VIRTIO_IOMMU_F_INPUT_RANGE, \ "VIRTIO_IOMMU_F_INPUT_RANGE: Range of available virtual addrs.= " @@ -458,15 +427,11 @@ static const qmp_virtio_feature_map_t virtio_iommu_fe= ature_map[] =3D { "available"), { -1, "" } }; -#endif =20 /* virtio-mem features mapping */ -#ifdef CONFIG_VIRTIO_MEM static const qmp_virtio_feature_map_t virtio_mem_feature_map[] =3D { -#ifndef CONFIG_ACPI FEATURE_ENTRY(VIRTIO_MEM_F_ACPI_PXM, \ "VIRTIO_MEM_F_ACPI_PXM: node_id is an ACPI PXM and is valid"), -#endif /* !CONFIG_ACPI */ FEATURE_ENTRY(VIRTIO_MEM_F_UNPLUGGED_INACCESSIBLE, \ "VIRTIO_MEM_F_UNPLUGGED_INACCESSIBLE: Unplugged memory cannot = be " "accessed"), @@ -475,10 +440,8 @@ static const qmp_virtio_feature_map_t virtio_mem_featu= re_map[] =3D { "plugged when suspending+resuming"), { -1, "" } }; -#endif =20 /* virtio-rng features mapping */ -#ifdef CONFIG_VIRTIO_RNG static const qmp_virtio_feature_map_t virtio_rng_feature_map[] =3D { FEATURE_ENTRY(VHOST_F_LOG_ALL, \ "VHOST_F_LOG_ALL: Logging write descriptors supported"), @@ -487,10 +450,8 @@ static const qmp_virtio_feature_map_t virtio_rng_featu= re_map[] =3D { "negotiation supported"), { -1, "" } }; -#endif =20 /* virtio/vhost-gpio features mapping */ -#ifdef CONFIG_VHOST_USER_GPIO static const qmp_virtio_feature_map_t virtio_gpio_feature_map[] =3D { FEATURE_ENTRY(VIRTIO_GPIO_F_IRQ, \ "VIRTIO_GPIO_F_IRQ: Device supports interrupts on GPIO lines"), @@ -499,7 +460,6 @@ static const qmp_virtio_feature_map_t virtio_gpio_featu= re_map[] =3D { "negotiation supported"), { -1, "" } }; -#endif =20 #define CONVERT_FEATURES(type, map, is_status, bitmap) \ ({ \ @@ -595,96 +555,66 @@ VirtioDeviceFeatures *qmp_decode_features(uint16_t de= vice_id, =20 /* device features */ switch (device_id) { -#ifdef CONFIG_VIRTIO_SERIAL case VIRTIO_ID_CONSOLE: features->dev_features =3D CONVERT_FEATURES_EX(strList, virtio_serial_feature_map, bitmap= ); break; -#endif -#ifdef CONFIG_VIRTIO_BLK case VIRTIO_ID_BLOCK: features->dev_features =3D CONVERT_FEATURES_EX(strList, virtio_blk_feature_map, bitmap); break; -#endif -#ifdef CONFIG_VIRTIO_GPU case VIRTIO_ID_GPU: features->dev_features =3D CONVERT_FEATURES_EX(strList, virtio_gpu_feature_map, bitmap); break; -#endif -#ifdef CONFIG_VIRTIO_NET case VIRTIO_ID_NET: features->dev_features =3D CONVERT_FEATURES_EX(strList, virtio_net_feature_map, bitmap); break; -#endif -#ifdef CONFIG_VIRTIO_SCSI case VIRTIO_ID_SCSI: features->dev_features =3D CONVERT_FEATURES_EX(strList, virtio_scsi_feature_map, bitmap); break; -#endif -#ifdef CONFIG_VIRTIO_BALLOON case VIRTIO_ID_BALLOON: features->dev_features =3D CONVERT_FEATURES_EX(strList, virtio_balloon_feature_map, bitma= p); break; -#endif -#ifdef CONFIG_VIRTIO_IOMMU case VIRTIO_ID_IOMMU: features->dev_features =3D CONVERT_FEATURES_EX(strList, virtio_iommu_feature_map, bitmap); break; -#endif -#ifdef CONFIG_VIRTIO_INPUT case VIRTIO_ID_INPUT: features->dev_features =3D CONVERT_FEATURES_EX(strList, virtio_input_feature_map, bitmap); break; -#endif -#ifdef CONFIG_VHOST_USER_FS case VIRTIO_ID_FS: features->dev_features =3D CONVERT_FEATURES_EX(strList, virtio_fs_feature_map, bitmap); break; -#endif -#ifdef CONFIG_VHOST_VSOCK case VIRTIO_ID_VSOCK: features->dev_features =3D CONVERT_FEATURES_EX(strList, virtio_vsock_feature_map, bitmap); break; -#endif -#ifdef CONFIG_VIRTIO_CRYPTO case VIRTIO_ID_CRYPTO: features->dev_features =3D CONVERT_FEATURES_EX(strList, virtio_crypto_feature_map, bitmap= ); break; -#endif -#ifdef CONFIG_VIRTIO_MEM case VIRTIO_ID_MEM: features->dev_features =3D CONVERT_FEATURES_EX(strList, virtio_mem_feature_map, bitmap); break; -#endif -#ifdef CONFIG_VIRTIO_I2C_ADAPTER case VIRTIO_ID_I2C_ADAPTER: features->dev_features =3D CONVERT_FEATURES_EX(strList, virtio_i2c_feature_map, bitmap); break; -#endif -#ifdef CONFIG_VIRTIO_RNG case VIRTIO_ID_RNG: features->dev_features =3D CONVERT_FEATURES_EX(strList, virtio_rng_feature_map, bitmap); break; -#endif -#ifdef CONFIG_VHOST_USER_GPIO case VIRTIO_ID_GPIO: features->dev_features =3D CONVERT_FEATURES_EX(strList, virtio_gpio_feature_map, bitmap); break; -#endif /* No features */ case VIRTIO_ID_9P: case VIRTIO_ID_PMEM: diff --git a/hw/virtio/meson.build b/hw/virtio/meson.build index ee397aaf196..d913b94e1ca 100644 --- a/hw/virtio/meson.build +++ b/hw/virtio/meson.build @@ -11,7 +11,7 @@ system_virtio_ss.add(when: 'CONFIG_VHOST_VDPA_DEV', if_tr= ue: files('vdpa-dev.c') =20 specific_virtio_ss =3D ss.source_set() specific_virtio_ss.add(files('virtio.c')) -specific_virtio_ss.add(files('virtio-qmp.c')) +system_virtio_ss.add(files('virtio-qmp.c')) =20 if have_vhost system_virtio_ss.add(files('vhost.c')) --=20 2.52.0 From nobody Sat Feb 7 05:53:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1769988093; cv=none; d=zohomail.com; s=zohoarc; b=GOEfEy7fiOEyazV6eWWk991xSSKgjxoZc7ZJT+ObNOSpaIqNDjlRRNOexmNth8WSyJVBCUVOBOPB4xAu68wq5Z3n1dT5d18Nvv7438V2LV9R+rcuuLeUBz/Hay3sDp0T9M/+3EaokrAWZCeBJChN3zYE5oyP1eQcRw+LTZCCpSI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769988093; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=FazXBSYedPJMCAc2qLR8vcJOR6e+azw1WcJZB+T60Vc=; b=esRp8g8tvrCeq9tVGC0N2EN5t19p5euyAorizLyIuuhIEvXgGt709R7TbdE5sO1Mxlh8hYrFIrSIeRb3/YroYPro5gpMoC4A4fmi+IrKhrEgbN4H8U1bvu7XxqsfRykZnKRYy3R/7YZ80z2YZkJhn9xjdIK+CC/mNEfXLFJpXhc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1769988093957684.2850707035568; Sun, 1 Feb 2026 15:21:33 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vmgkr-0007A7-Ph; Sun, 01 Feb 2026 18:21:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vmgkp-0006vE-HV for qemu-devel@nongnu.org; Sun, 01 Feb 2026 18:21:19 -0500 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vmgkn-0000PE-IZ for qemu-devel@nongnu.org; Sun, 01 Feb 2026 18:21:19 -0500 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-48069a48629so39820695e9.0 for ; Sun, 01 Feb 2026 15:21:17 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48066c37420sm446556255e9.9.2026.02.01.15.21.14 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 01 Feb 2026 15:21:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769988076; x=1770592876; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FazXBSYedPJMCAc2qLR8vcJOR6e+azw1WcJZB+T60Vc=; b=hhDi3vxClcfv1N5L30CyF7XQcsQmQKeuscubbR85XNkAhM8D/+N3xnmOxCqrbG6mZz KFzztZT6p0Y1OGl8uedLEMEk/wW/mROiKJELE5RdD6ZoNIOvvu6069Ygzb4mSY9Q2bfM JjfJx23vvypt4fkq29B2LUzYa53CFlnH+1EI+OzkJxjh5hrrp59QLtB5xIXtfSrQVMhh L1qSrKoTKSC5/6ufFxOjM+ujPYW3nhgxcLumrE7iwK8UP9l+COdgNnytKbvCIHY5hBX9 9WKDmFeu9uPSFZgce28Ij6ip6y1T1PXFBurwvbqmMlw7Eixxw3FFuumhXnq+7eO7Fxio sY6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769988076; x=1770592876; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FazXBSYedPJMCAc2qLR8vcJOR6e+azw1WcJZB+T60Vc=; b=FBvNmXrlldMrGXic3tvBpG7P8BxlWyA91IuTPojvTDysLDfRk9+bS4fZ6bhwsAbNu1 GZ9+wGicsf5JP6LaDrboJ++XHvNhP96wVxsBTQ4j7q2jp9lrKbQAyAmNpTpMgFWyG5dD rokg/aIxrChxzg6ndOTC5p4RCvMrnWMidy4nHPB07hywxepacqvhVu2FtyRJBaE1Gd/A ZArsX2/ECFhvC6jHnhvJC7A7ZdtL7R1UqD/y9//350JUHOEFtzCTdGwBd/jbRjDkfmEx EX1oo0MG0wRHNRUx1StDuhPmyET0Et7rAs15OMXEshTB7Deg1bKWbZFicw/HTH6MXDdV 4eHw== X-Gm-Message-State: AOJu0YyxO2LCM5YtRa8EeDjsoI+1Jy1wl3aYgAXf4flndSQkwJC0X8qx acsOARnX5XG3ZumliEXKBj61WMZC4JdvRJojJLPkZEqiGFy39k2t1FTahZOGd/+1LHDSGZm3Gss aNuwHWUo= X-Gm-Gg: AZuq6aKRHE8dkMTpcvjzr/8xILFFtL/++MpZVS80ueqE4R4GLlqtJOBFuIvSS6Uf09Q 56E3MvJdXeiq1VlD8xg1B1pebCqfx3aGp/RC2A7OQm78UeXEHUQvXrPbQXku10awHlcGa7p5DN8 2xIUnmmyuSEL7QCPMToiTObLQw9naGfn/oArTaW8AFXmtLTKSTTqodhg9y0b0BZmVie0xQQreZ3 VpmkZ29a+oCt9qpbibr9yjAud4eEsH5IpaSu+ywSIRFGU0qAvtGeBWhFjc1VKZofqDoNbf4ciUg VLZuF8JmD2AC4y4SZEqdYA3pgQ/ox8/NPmN/2feONkgdDcnMQhfC1It90NiPDqiVISd7DLX2KY9 7gaXHg4DqvFTpDyXfylfYEtYF8II0nmkdVi5GGughQtThWanI7KGtAVrsXfhPNPqfNtebWXzN1B n3d+nb4jqAH8wJSOeDjO/rbl0U3r0x1VFnAGLSVa8+IljRR7mxwQ/bvliGqaTh X-Received: by 2002:a05:600c:8289:b0:480:32da:f338 with SMTP id 5b1f17b1804b1-482db45cb90mr116343225e9.14.1769988075640; Sun, 01 Feb 2026 15:21:15 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Stefano Garzarella Subject: [PATCH v2 10/10] hw/virtio: make all compilation units common Date: Mon, 2 Feb 2026 00:19:59 +0100 Message-ID: <20260201231959.88559-11-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260201231959.88559-1-philmd@linaro.org> References: <20260201231959.88559-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1769988096240158500 From: Pierrick Bouvier Signed-off-by: Pierrick Bouvier Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/virtio/meson.build | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/hw/virtio/meson.build b/hw/virtio/meson.build index d913b94e1ca..4f308beb961 100644 --- a/hw/virtio/meson.build +++ b/hw/virtio/meson.build @@ -9,8 +9,7 @@ system_virtio_ss.add(when: 'CONFIG_VHOST_VSOCK_COMMON', if_= true: files('vhost-vs system_virtio_ss.add(when: 'CONFIG_VIRTIO_IOMMU', if_true: files('virtio-i= ommu.c')) system_virtio_ss.add(when: 'CONFIG_VHOST_VDPA_DEV', if_true: files('vdpa-d= ev.c')) =20 -specific_virtio_ss =3D ss.source_set() -specific_virtio_ss.add(files('virtio.c')) +system_virtio_ss.add(files('virtio.c')) system_virtio_ss.add(files('virtio-qmp.c')) =20 if have_vhost @@ -52,10 +51,10 @@ endif system_virtio_ss.add(when: 'CONFIG_VHOST_USER_VSOCK', if_true: files('vhos= t-user-vsock.c')) system_virtio_ss.add(when: 'CONFIG_VIRTIO_RNG', if_true: files('virtio-rng= .c')) =20 -specific_virtio_ss.add(when: 'CONFIG_VIRTIO_BALLOON', if_true: files('virt= io-balloon.c')) -specific_virtio_ss.add(when: 'CONFIG_VHOST_USER_FS', if_true: files('vhost= -user-fs.c')) -specific_virtio_ss.add(when: 'CONFIG_VIRTIO_PMEM', if_true: files('virtio-= pmem.c')) -specific_virtio_ss.add(when: 'CONFIG_VHOST_VSOCK', if_true: files('vhost-v= sock.c')) +system_virtio_ss.add(when: 'CONFIG_VIRTIO_BALLOON', if_true: files('virtio= -balloon.c')) +system_virtio_ss.add(when: 'CONFIG_VHOST_USER_FS', if_true: files('vhost-u= ser-fs.c')) +system_virtio_ss.add(when: 'CONFIG_VIRTIO_PMEM', if_true: files('virtio-pm= em.c')) +system_virtio_ss.add(when: 'CONFIG_VHOST_VSOCK', if_true: files('vhost-vso= ck.c')) system_virtio_ss.add(when: 'CONFIG_VIRTIO_MEM', if_true: files('virtio-mem= .c')) system_virtio_ss.add(when: 'CONFIG_VIRTIO_NSM', if_true: files('virtio-nsm= .c')) system_virtio_ss.add(when: 'CONFIG_VIRTIO_NSM', if_true: [files('cbor-help= ers.c'), libcbor]) @@ -97,5 +96,4 @@ system_ss.add(when: ['CONFIG_VIRTIO_MD', 'CONFIG_VIRTIO_P= CI'], =20 system_ss.add(files('virtio-hmp-cmds.c')) =20 -specific_ss.add_all(when: 'CONFIG_VIRTIO', if_true: specific_virtio_ss) system_ss.add(when: 'CONFIG_ACPI', if_true: files('virtio-acpi.c')) --=20 2.52.0