From nobody Mon Feb 9 11:44:33 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1769967449; cv=none; d=zohomail.com; s=zohoarc; b=ilBBhbbaEH2jjVXO4Tg5U/hDUkN9zSRZzWnXlhpGbs3hshCt/G+9McAd6bx8gKTf+eHcJDfnn3IwAgbSiv1nxVBEMFVAxAmTzZfXgq4CveMxBwEtPgX20PATEsnKFs7Z/Y/CpBQXVxwDbAM4WlxNF/S8qyGVK3Z/aWl89Vkte88= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769967449; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=LBZEDE4oMrNvlkBqDXOL06KsEgH+YdKtU7Cw3h8P8dE=; b=l2TRaTqdvvwOXhGuU2z483RcL0m9dlJd2y/1OCMbgBnJNoOVTSgstIlUChzg14h0KtV0Wash9z1xmYaSvRustPyiwZSy0TmxwOR+eIzPFR/3XkCw818whAZiPGMyD/TIRQFMKLVm3HRjqggG+FzuAaFybZMFSwClBapMRH7YIUQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1769967449043417.5476244168482; Sun, 1 Feb 2026 09:37:29 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vmbNN-0001o4-35; Sun, 01 Feb 2026 12:36:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vmbNJ-0001ma-K0 for qemu-devel@nongnu.org; Sun, 01 Feb 2026 12:36:41 -0500 Received: from forwardcorp1a.mail.yandex.net ([2a02:6b8:c0e:500:1:45:d181:df01]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vmbNH-000466-1h for qemu-devel@nongnu.org; Sun, 01 Feb 2026 12:36:41 -0500 Received: from mail-nwsmtp-smtp-corp-main-69.vla.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-69.vla.yp-c.yandex.net [IPv6:2a02:6b8:c1f:3a87:0:640:845c:0]) by forwardcorp1a.mail.yandex.net (Yandex) with ESMTPS id 566F5C0159; Sun, 01 Feb 2026 20:36:36 +0300 (MSK) Received: from vsementsov-lin (unknown [2a02:6bf:8080:765::1:3b]) by mail-nwsmtp-smtp-corp-main-69.vla.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id YaqAY06Af8c0-3i7WUPmN; Sun, 01 Feb 2026 20:36:35 +0300 Precedence: bulk X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1769967395; bh=LBZEDE4oMrNvlkBqDXOL06KsEgH+YdKtU7Cw3h8P8dE=; h=Cc:Message-ID:References:Date:In-Reply-To:Subject:To:From; b=AbKv6fY8xU7DROpli/MOHFn5gT19JMw1IUKfw53mwWReWcAV5fJ/Epu/lzRE2ZDAo EksQbkedt6wNkS3sUOCMPgCUo4mNHYIM49giDC421Mqy1Qez+lm9MeI71vKv7jn3+X 0okt0ShGg2XjtG2XBhfdmxDP+6UlpE54eMplEdaQ= Authentication-Results: mail-nwsmtp-smtp-corp-main-69.vla.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: marcandre.lureau@redhat.com Cc: pbonzini@redhat.com, armbru@redhat.com, eblake@redhat.com, berrange@redhat.com, vsementsov@yandex-team.ru, yc-core@yandex-team.ru, d-tatianin@yandex-team.ru, qemu-devel@nongnu.org, philmd@linaro.org Subject: [PATCH v3 1/3] char: qemu_chr_write_log() use qemu_write_full() Date: Sun, 1 Feb 2026 20:36:29 +0300 Message-ID: <20260201173633.413934-2-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260201173633.413934-1-vsementsov@yandex-team.ru> References: <20260201173633.413934-1-vsementsov@yandex-team.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a02:6b8:c0e:500:1:45:d181:df01; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1a.mail.yandex.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1769967451225158500 logfd is blocking, so we don't need to care about EAGAIN. Let's simply use qemu_write_full(). Signed-off-by: Vladimir Sementsov-Ogievskiy --- chardev/char.c | 22 +++++----------------- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git a/chardev/char.c b/chardev/char.c index 3e432195a5..64006a3119 100644 --- a/chardev/char.c +++ b/chardev/char.c @@ -82,29 +82,17 @@ void qemu_chr_be_event(Chardev *s, QEMUChrEvent event) CHARDEV_GET_CLASS(s)->chr_be_event(s, event); } =20 -/* Not reporting errors from writing to logfile, as logs are - * defined to be "best effort" only */ static void qemu_chr_write_log(Chardev *s, const uint8_t *buf, size_t len) { - size_t done =3D 0; - ssize_t ret; - if (s->logfd < 0) { return; } =20 - while (done < len) { - retry: - ret =3D write(s->logfd, buf + done, len - done); - if (ret =3D=3D -1 && errno =3D=3D EAGAIN) { - g_usleep(100); - goto retry; - } - - if (ret <=3D 0) { - return; - } - done +=3D ret; + if (qemu_write_full(s->logfd, buf, len) < len) { + /* + * qemu_write_full() is defined with G_GNUC_WARN_UNUSED_RESULT, + * but logging is best=E2=80=91effort, we do ignore errors. + */ } } =20 --=20 2.52.0 From nobody Mon Feb 9 11:44:33 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1769967469; cv=none; d=zohomail.com; s=zohoarc; b=JnF0EaQDvV12g5TKeN4CkIQgeyC5MVwo1GiKco1am+G2DPVJt3h1RvWvcFFXfYAPz4zjlK/oMALONn5BJe9suUhns7Yc8rismllMHDrXHURcQKLvraK+yupjOGb9SOvoZpCHIgYnWkpvaQey4JVIDrPkbgtt2uw2ZVOQp/mOXJ8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769967469; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=XOyJIzGRjf50TfoDj6Vn56zfWc90mqS1axOCc7NMXs4=; b=jkwQBMpby4iPdH+k38H8rDSfv/qa60ccHmsJ7Asg2a6vP6ptM16LldlSNpxcy+BV7U9PeejiwnQp3IbPVvMZQqdiK5Q9pOVeaNz7j+FyayL7IXotZ1VYUbpaDqSvwEzTQeX4dEB7A5muIGTaRcB2xj6cPd7yRjRH222RYZylN5w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1769967469459682.0398608861246; Sun, 1 Feb 2026 09:37:49 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vmbNM-0001o2-Im; Sun, 01 Feb 2026 12:36:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vmbNK-0001md-2U for qemu-devel@nongnu.org; Sun, 01 Feb 2026 12:36:42 -0500 Received: from forwardcorp1a.mail.yandex.net ([178.154.239.72]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vmbNH-000467-91 for qemu-devel@nongnu.org; Sun, 01 Feb 2026 12:36:41 -0500 Received: from mail-nwsmtp-smtp-corp-main-69.vla.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-69.vla.yp-c.yandex.net [IPv6:2a02:6b8:c1f:3a87:0:640:845c:0]) by forwardcorp1a.mail.yandex.net (Yandex) with ESMTPS id D95BEC015A; Sun, 01 Feb 2026 20:36:36 +0300 (MSK) Received: from vsementsov-lin (unknown [2a02:6bf:8080:765::1:3b]) by mail-nwsmtp-smtp-corp-main-69.vla.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id YaqAY06Af8c0-uWc9xgrU; Sun, 01 Feb 2026 20:36:36 +0300 Precedence: bulk X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1769967396; bh=XOyJIzGRjf50TfoDj6Vn56zfWc90mqS1axOCc7NMXs4=; h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From; b=q28wRno5lghMnDkJqR27Icckxsk7TdVnKGSxIeA0mwdSJnYMY0FnsmTsF0VW9UIJn oEJtzdlWMJzxuxs3Q/Z+KuGKpYBDrEaJ2r9mzcTCKQzsMFS8SlFg/ejzx+IwyUxP1s 3qikYeEE4VYZ3RBTYgJyp7NgefQvyOZPpLYdDbBw= Authentication-Results: mail-nwsmtp-smtp-corp-main-69.vla.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: marcandre.lureau@redhat.com Cc: pbonzini@redhat.com, armbru@redhat.com, eblake@redhat.com, berrange@redhat.com, vsementsov@yandex-team.ru, yc-core@yandex-team.ru, d-tatianin@yandex-team.ru, qemu-devel@nongnu.org, philmd@linaro.org Subject: [PATCH v3 2/3] error-report: make real_time_iso8601() public Date: Sun, 1 Feb 2026 20:36:30 +0300 Message-ID: <20260201173633.413934-3-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260201173633.413934-1-vsementsov@yandex-team.ru> References: <20260201173633.413934-1-vsementsov@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=178.154.239.72; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1a.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.01, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1769967471558158500 Content-Type: text/plain; charset="utf-8" To be reused in the following commit. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Markus Armbruster --- include/qemu/error-report.h | 6 ++++++ util/error-report.c | 3 +-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/include/qemu/error-report.h b/include/qemu/error-report.h index 3ae2357fda..dc423d3607 100644 --- a/include/qemu/error-report.h +++ b/include/qemu/error-report.h @@ -74,4 +74,10 @@ extern bool message_with_timestamp; extern bool error_with_guestname; extern const char *error_guest_name; =20 +/* + * Return current datetime in ISO 8601 format. + * Caller is responsible to g_free() the returned string. + */ +char *real_time_iso8601(void); + #endif diff --git a/util/error-report.c b/util/error-report.c index 1b17c11de1..d6b7448183 100644 --- a/util/error-report.c +++ b/util/error-report.c @@ -169,8 +169,7 @@ static void print_loc(void) } } =20 -static char * -real_time_iso8601(void) +char *real_time_iso8601(void) { g_autoptr(GDateTime) dt =3D g_date_time_new_now_utc(); return g_date_time_format_iso8601(dt); --=20 2.52.0 From nobody Mon Feb 9 11:44:33 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1769967471; cv=none; d=zohomail.com; s=zohoarc; b=XW54aONXJD5RLM32vCiRLc0g590jkUXXZ8KdkCRBEvmpfhDYDx+okl0oTnfRV9KGxvWttaYkkUNrQp2b3Bsv/llMqDK6ErDGyFIpNruRUbEkzURrhrrpXQmCkmWKUJP7E+jpQDGbv85/Q6Z/Z5aV8awSyJjApKSE9i6QJypLdjg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769967471; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=r4bqmI+DoIG6U1ssTLhnELzQXIa/537+DDiMXa59k7w=; b=UN+MxIWvQspICJJbxq+x4MHiukyoWbknZO7ufO+wchN57nD+VwyKcuWbX8jQvJ8MKjx2JSCTZvFb/os1prrnl0giLa8pX6PnaDmALSYaHFekbT00m/epK64JmuWxaeVmqYMZDFbbwCMTmSh1s/OT0XINhO5d8wby/7FQHN7RUaE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1769967471504137.14324110669907; Sun, 1 Feb 2026 09:37:51 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vmbNO-0001ps-5N; Sun, 01 Feb 2026 12:36:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vmbNL-0001nR-27 for qemu-devel@nongnu.org; Sun, 01 Feb 2026 12:36:43 -0500 Received: from forwardcorp1a.mail.yandex.net ([2a02:6b8:c0e:500:1:45:d181:df01]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vmbNH-00046C-Bf for qemu-devel@nongnu.org; Sun, 01 Feb 2026 12:36:42 -0500 Received: from mail-nwsmtp-smtp-corp-main-69.vla.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-69.vla.yp-c.yandex.net [IPv6:2a02:6b8:c1f:3a87:0:640:845c:0]) by forwardcorp1a.mail.yandex.net (Yandex) with ESMTPS id 81183C015B; Sun, 01 Feb 2026 20:36:37 +0300 (MSK) Received: from vsementsov-lin (unknown [2a02:6bf:8080:765::1:3b]) by mail-nwsmtp-smtp-corp-main-69.vla.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id YaqAY06Af8c0-5fX0648E; Sun, 01 Feb 2026 20:36:36 +0300 Precedence: bulk X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1769967397; bh=r4bqmI+DoIG6U1ssTLhnELzQXIa/537+DDiMXa59k7w=; h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From; b=bzUDjJupVwCjrMMZ1TbTNQvVC5mm2FzRRao54Yrkm38VzlnYmRptRqfrlK/vEP/RJ VFm2YjG3jgjgHjojTBd96Ky9By78FA1rPTcOQIMoQ+1yX8EF7ppnTK2VGVHRCvC3uY KV8l253rmfEXl7YfEwuFkwdto46EqdjIUcAnlvVk= Authentication-Results: mail-nwsmtp-smtp-corp-main-69.vla.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: marcandre.lureau@redhat.com Cc: pbonzini@redhat.com, armbru@redhat.com, eblake@redhat.com, berrange@redhat.com, vsementsov@yandex-team.ru, yc-core@yandex-team.ru, d-tatianin@yandex-team.ru, qemu-devel@nongnu.org, philmd@linaro.org Subject: [PATCH v3 3/3] chardev: add logtimestamp option Date: Sun, 1 Feb 2026 20:36:31 +0300 Message-ID: <20260201173633.413934-4-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260201173633.413934-1-vsementsov@yandex-team.ru> References: <20260201173633.413934-1-vsementsov@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a02:6b8:c0e:500:1:45:d181:df01; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1a.mail.yandex.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1769967473460158500 Content-Type: text/plain; charset="utf-8" Add an option to inject timestamps into serial log file. That simplifies debugging a lot, when you can simply compare QEMU logs with guest console logs. Signed-off-by: Vladimir Sementsov-Ogievskiy Acked-by: Markus Armbruster --- chardev/char.c | 63 ++++++++++++++++++++++++++++++++++++++---- include/chardev/char.h | 2 ++ qapi/char.json | 6 +++- 3 files changed, 65 insertions(+), 6 deletions(-) diff --git a/chardev/char.c b/chardev/char.c index 64006a3119..57c65544d0 100644 --- a/chardev/char.c +++ b/chardev/char.c @@ -82,12 +82,8 @@ void qemu_chr_be_event(Chardev *s, QEMUChrEvent event) CHARDEV_GET_CLASS(s)->chr_be_event(s, event); } =20 -static void qemu_chr_write_log(Chardev *s, const uint8_t *buf, size_t len) +static void do_write_log(Chardev *s, const uint8_t *buf, size_t len) { - if (s->logfd < 0) { - return; - } - if (qemu_write_full(s->logfd, buf, len) < len) { /* * qemu_write_full() is defined with G_GNUC_WARN_UNUSED_RESULT, @@ -96,6 +92,55 @@ static void qemu_chr_write_log(Chardev *s, const uint8_t= *buf, size_t len) } } =20 +static void do_write_log_timestamps(Chardev *s, const uint8_t *buf, size_t= len) +{ + g_autofree char *timestr =3D NULL; + + while (len) { + size_t i; + + if (s->log_line_start) { + if (!timestr) { + timestr =3D real_time_iso8601(); + } + do_write_log(s, (const uint8_t *)timestr, strlen(timestr)); + do_write_log(s, (const uint8_t *)" ", 1); + s->log_line_start =3D false; + } + + for (i =3D 0; i < len; i++) { + if (buf[i] =3D=3D '\n') { + break; + } + } + + if (i =3D=3D len) { + /* not found \n */ + do_write_log(s, buf, len); + return; + } + + i +=3D 1; + do_write_log(s, buf, i); + buf +=3D i; + len -=3D i; + s->log_line_start =3D true; + } +} + +static void qemu_chr_write_log(Chardev *s, const uint8_t *buf, size_t len) +{ + if (s->logfd < 0) { + return; + } + + if (s->logtimestamp) { + do_write_log_timestamps(s, buf, len); + } else { + do_write_log(s, buf, len); + } +} + static int qemu_chr_write_buffer(Chardev *s, const uint8_t *buf, int len, int *offset, bool write_all) @@ -249,6 +294,7 @@ static void qemu_char_open(Chardev *chr, ChardevBackend= *backend, } else { flags |=3D O_TRUNC; } + chr->logtimestamp =3D common->has_logtimestamp && common->logtimes= tamp; chr->logfd =3D qemu_create(common->logfile, flags, 0666, errp); if (chr->logfd < 0) { return; @@ -266,6 +312,7 @@ static void char_init(Object *obj) =20 chr->handover_yank_instance =3D false; chr->logfd =3D -1; + chr->log_line_start =3D true; qemu_mutex_init(&chr->chr_write_lock); =20 /* @@ -505,6 +552,9 @@ void qemu_chr_parse_common(QemuOpts *opts, ChardevCommo= n *backend) backend->logfile =3D g_strdup(logfile); backend->has_logappend =3D true; backend->logappend =3D qemu_opt_get_bool(opts, "logappend", false); + + backend->has_logtimestamp =3D true; + backend->logtimestamp =3D qemu_opt_get_bool(opts, "logtimestamp", fals= e); } =20 static const ChardevClass *char_get_class(const char *driver, Error **errp) @@ -956,6 +1006,9 @@ QemuOptsList qemu_chardev_opts =3D { },{ .name =3D "logappend", .type =3D QEMU_OPT_BOOL, + },{ + .name =3D "logtimestamp", + .type =3D QEMU_OPT_BOOL, },{ .name =3D "mouse", .type =3D QEMU_OPT_BOOL, diff --git a/include/chardev/char.h b/include/chardev/char.h index 192cad67d4..86636b4d09 100644 --- a/include/chardev/char.h +++ b/include/chardev/char.h @@ -64,6 +64,8 @@ struct Chardev { char *label; char *filename; int logfd; + bool logtimestamp; + bool log_line_start; int be_open; /* used to coordinate the chardev-change special-case: */ bool handover_yank_instance; diff --git a/qapi/char.json b/qapi/char.json index 140614f82c..a4abafa680 100644 --- a/qapi/char.json +++ b/qapi/char.json @@ -197,11 +197,15 @@ # @logappend: true to append instead of truncate (default to false to # truncate) # +# @logtimestamp: true to insert timestamps into logfile +# (default false) (since 11.0) +# # Since: 2.6 ## { 'struct': 'ChardevCommon', 'data': { '*logfile': 'str', - '*logappend': 'bool' } } + '*logappend': 'bool', + '*logtimestamp': 'bool' } } =20 ## # @ChardevFile: --=20 2.52.0