From nobody Mon Feb 9 12:14:30 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1769562485; cv=none; d=zohomail.com; s=zohoarc; b=e1Ts3t6/AVBxPQeY04L0vS6EZt7yzZrCpC+9HRUPWXuRLR8Q2E8TLq1FDBXs4oWmewMtfGxD+z8PkenVkCwxZDbCux1cAlgJIAP6h28ch7pIbVi3U+PvoSwUDwLmZgL6MT7p8vBqaUlxrFI0dfN5F+pBxKd9LSJaCJjPtLrCBOk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769562485; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ci4W1tTKlIqWO9VPthw/j0kWq/5WvkmB0VNMUaFTDc0=; b=ij6IQfLyyxEMoNT1YQy1y3NLkm8sBcGrpKKyEHQGExWqsLTL5XIxIYxGi55dybgkqjWQJq9zDkU0Tg88hzAVN1zCObF6O/t8yHKGPCdBXbxy0bkYsOVf1fj5+pdyQcZO5RTGmYiviqerAvTxyMjwqSd9tIP6w5HbF0SJLKtmNHI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1769562485013483.2045435674861; Tue, 27 Jan 2026 17:08:05 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vku23-0005cp-BD; Tue, 27 Jan 2026 20:07:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vku1o-0005PV-P2 for qemu-devel@nongnu.org; Tue, 27 Jan 2026 20:07:33 -0500 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vku1m-0004jV-Op for qemu-devel@nongnu.org; Tue, 27 Jan 2026 20:07:27 -0500 Received: by mail-pf1-x441.google.com with SMTP id d2e1a72fcca58-8230c33f477so2805578b3a.2 for ; Tue, 27 Jan 2026 17:07:25 -0800 (PST) Received: from stoup.. ([180.233.125.201]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82379c53f6bsm719407b3a.63.2026.01.27.17.07.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jan 2026 17:07:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769562444; x=1770167244; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ci4W1tTKlIqWO9VPthw/j0kWq/5WvkmB0VNMUaFTDc0=; b=JSpne0nGXq/r2YM18h7AwJtr++DHSdUVmYlHz/r9pizRy4jdiCXIfTJ2djwks9KCvw 9eSHBJVj3/Ykz4wRTrmerMbufyUrv/QVEqI3/3SqjXK1EV8S+4WR2pmcMjuhU7Xnh4+N ZFN9ilhUmt9541NQsC0gJcGsQh10fp1OyymUc/XzjCJUL7sS+CsbMHMJKmZxFrtjmu1R 8oOkZ3K9lu0kB04PvXdKBqASG4GA78ns6WOIXcDo7wwYPIuJvjOY49hhktFbYT7LgP9t dKywo67GK9xAILZsmCnMye57rNdJ0SdTMNNGJ1B1Nt5TXRpoa4DehY/YaNit0bd7W8rj ue8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769562444; x=1770167244; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ci4W1tTKlIqWO9VPthw/j0kWq/5WvkmB0VNMUaFTDc0=; b=oXGXJGtSPtT2UV2P27FPo69J83QftKPxuEzUuOEFlRAANLSn3XVD9Pw/s6Klv1q7cZ hGZR15j+6hS7ZT0fQ/Dr2v9uQJSS430f72AJFRDYQEnJGyMuxQ/sLvzZhPrv1ZrSCDoZ 8MVzaR2eU1uGF66//oRPIm3vjmzl2rCrcE8gktraEATG7YMZDq2vBPLPrOBKfd9Rhac7 IEzvKfoleHEgIdCcfcfoyQm33YGVMX8h/JXEiFfdKT+u1NwGHhZFlGZTiUmvL4eVnTBy oqVN2CMg8tnbm3D9kB3dy6RnShqN8tUfnpalOA3pdjt5DfDq5bY32Bb6X+yR3CgGrS+v ZAgg== X-Gm-Message-State: AOJu0YyK5ymdXmxUQaq53vS4V16/Reg/rmebXscD4dsFvrxMrWsilC0y hdWndS/IRQmbFtjQc0Os5qv5BWU/NFmdEuIjzswTSsX4WvS+z2tAQXkg914NdTxo4bSbX5TrTj8 /u2hslRrmaOyd X-Gm-Gg: AZuq6aJJn6Kt9JGlaTEkbmZ7ENxP217GlalPZVgZvN3PEIU0NbitOIaRC/C+bLQWYUB mfJ3OrvM/dCOWyF5a/HWBKo0nZOG8EpkTL3oEcaeVDxKEsV0vSQIPM7/aIb6c4kS7WzhR8ZdBoD L/EPDeVomBbnfJqNAKC6taXu5H/aQ6Tw1mLwCUclsljPdhEkzFAlzBQGTEnxVB8B/DMJLwBE9W5 Gw9/Y1O0BwDMo21pJ1KUGY/bYyn6in4CjfvGMHtPlBUHMeXSqeIQcea2l0C+C+R4FYrb7HBuGSC Aqp6ZOA8CISkFxauyDauF/Z08mOKYy41Zu2NHyigYdqUSBzdDEckXP/95iMplPzPozlQ8gd3GAu c62lzbvhyXie8sZKbYtpgavZUC5nUsledpMDnKwILiP0wOlx9PQG64WDyCVbWra25OaSGGXhqyx vrRu8ropbrvqUNQLWFoQ== X-Received: by 2002:a05:6a00:348c:b0:81f:4e0b:324d with SMTP id d2e1a72fcca58-82369311128mr3092303b3a.69.1769562444002; Tue, 27 Jan 2026 17:07:24 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: 3160104094@zju.edu.cn Subject: [PATCH 1/2] accel/tcg: Don't pass NULL to get_page_addr_code_hostp Date: Wed, 28 Jan 2026 12:07:14 +1100 Message-ID: <20260128010715.347776-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260128010715.347776-1-richard.henderson@linaro.org> References: <20260128010715.347776-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::441; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x441.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1769562487960154100 Content-Type: text/plain; charset="utf-8" Pass a dummy variable instead to let the value be discarded, in preparation for making the argument mandatory. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- accel/tcg/internal-common.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/accel/tcg/internal-common.h b/accel/tcg/internal-common.h index 6adfeefe13..0ca13750f9 100644 --- a/accel/tcg/internal-common.h +++ b/accel/tcg/internal-common.h @@ -105,7 +105,8 @@ tb_page_addr_t get_page_addr_code_hostp(CPUArchState *e= nv, vaddr addr, static inline tb_page_addr_t get_page_addr_code(CPUArchState *env, vaddr addr) { - return get_page_addr_code_hostp(env, addr, NULL); + void *discard; + return get_page_addr_code_hostp(env, addr, &discard); } =20 /* --=20 2.43.0 From nobody Mon Feb 9 12:14:30 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1769562514; cv=none; d=zohomail.com; s=zohoarc; b=lcp/D0hf5hsSkp6RyPgE/r4p0UvO5RrXtJ4coy7RTVeecH0oy6RelwEiBMXFbFPFlCvWt+b5K3tLMLjtQMxc+P+i7ju3igjiYOMiUHLuQZ7d65O5DEqTVIKxI5hfTTTVpYSbxiHSh6TnYUOPLgtgzvnDbVwEvqom1cN+kjnyNng= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769562514; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=QL0+W6HAC1hQGNc/ryikijGbESR+3UNG+gkzdL4k4+A=; b=YrIKM7FPG5lMckaTXCoZhsHUAzllUrvBR0tzLehI1byy7TxXTGYixF/j0Dm2xUcVu/Kafh7aW8biRGr+9z6Gc5euzNVnRtcUoWJnu1RqHwyCiUjuz3vTc2nHIwg5rpcu72cdslDfmvLmhoC0IMQYaxe8xGCewG5Hw0JIjmvkPPc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1769562514417493.40531377927164; Tue, 27 Jan 2026 17:08:34 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vku27-0005hZ-8E; Tue, 27 Jan 2026 20:07:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vku1q-0005Pj-1r for qemu-devel@nongnu.org; Tue, 27 Jan 2026 20:07:34 -0500 Received: from mail-pf1-x430.google.com ([2607:f8b0:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vku1o-0004jf-HV for qemu-devel@nongnu.org; Tue, 27 Jan 2026 20:07:29 -0500 Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-823075fed75so198194b3a.1 for ; Tue, 27 Jan 2026 17:07:27 -0800 (PST) Received: from stoup.. ([180.233.125.201]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82379c53f6bsm719407b3a.63.2026.01.27.17.07.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jan 2026 17:07:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769562446; x=1770167246; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QL0+W6HAC1hQGNc/ryikijGbESR+3UNG+gkzdL4k4+A=; b=Be70+g+A97H9SiqFpwg6EM1KEe5zk1R4lTaTgqEJAGGmJyStx58jpiA7ab9G87wbXo dsio2shDWIFoisAO90fiuqZIlbibntzlhwpfx+dBiUaruTJUyVxJJ+SZnsPemovYJTW9 De4xaJiXW1W0uCw8B7mlECXWC/ONowDv0d+aaYGnq7GZjPmBdwzSCd62Z6iZgzZnsR2v q6lyvs5SaeHqKeH3rrrUH+2grwg4Rssir8dq8VToawKbR0LRw9wgMA8IsVIXsYE81Ff4 9vwwa0HWWc7SO8nqZUxNpZaKUN9BOF3QGKy5Yg9I75SXntRMFkfxeP3kzR0HoQ7WARLk drUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769562446; x=1770167246; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=QL0+W6HAC1hQGNc/ryikijGbESR+3UNG+gkzdL4k4+A=; b=UbXdbrRlD/IeH9Uq7ZWNEX1pYS11jqTznO8XUZQyKB6LEMgwCRWU+aym3SmFWjKBhK dEO3wawxdc+rqzABK0eRbYTqEYMssRpMQknUrjrSM4nxYqwU8GyOSe32OXGV0ecuiQIk o7nMAa21alwGYphqEikYr4SdHni6y3JcojO7pq4qKU3Fmio8fm8IQWHN14Esujmew941 bV4Acqk6/iX9bnczlmKGjEbdz9bXQmu1DJ3gfSFzXVxe3SLrWvPa0CvhIy5BHUq36KoF 9nUmL5T9xv2sjHt4wdqMLzvHWGRs60RSB3CED0WI60384U0xSuNaIaj9+f0JHHrDwzlR A0pw== X-Gm-Message-State: AOJu0Yy4bhP60suLUN+DUFdfY6Qpj3pw8e5huwo/Xxm45D9UEupcje1w Ay2+T2TKRbMNqsc9ADkuvHPVTgXF40ILqcN1OAGnVxRRuNR6aLOGvKo5KGobE9TuWZdSS5D2L1c hYxS9azwgpA== X-Gm-Gg: AZuq6aK4BlkehoPqecrfOqJOWB8qjKJGIHrifE84GRJ5VNMN9YcApH+4l+HpGQqnjMc LmUuxdV89h5TUX/HamDt/Y8aFm92fmndCf9o65EuUIdXJ/JttkOGWtCi9axXZZkk5pxhxNzV/TD FcKAqfphrhyvTL6UWmORvQ6tuJnULScDDLZXSZ81HE5QA/id4xMyc0BWcoqK4YPAmJJJVr8rikw 17/DDU6oxfWXiT0jRbXhSLI7Bp2BOV+G/w2tuyiSRdJL4V2NqCnDjKYETO8bJX0UiYKvV+PkQIP Qzt01DIaXHAruxfOYwqIC+pM3mYnd1IiTixKw24LDWZGv6ozzUTQNxP5wjEea97LnBvBPQg15BD Te6EoqV/uBVEFP0VFGJq+cJS2AOG8aj7BhpD49w4IjUYQoFVcIOSYtH/0Hu4l851lTpSLomwVdQ lFW1Q9A95uaq53nCLeqpnrdFjHK3bP X-Received: by 2002:a05:6a00:1255:b0:81f:440b:4f61 with SMTP id d2e1a72fcca58-8236a460e7cmr3190761b3a.35.1769562446288; Tue, 27 Jan 2026 17:07:26 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: 3160104094@zju.edu.cn Subject: [PATCH 2/2] accel/tcg: Fix uninitialized hostp in get_page_addr_code_hostp Date: Wed, 28 Jan 2026 12:07:15 +1100 Message-ID: <20260128010715.347776-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260128010715.347776-1-richard.henderson@linaro.org> References: <20260128010715.347776-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::430; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1769562516691154100 Content-Type: text/plain; charset="utf-8" This uninitialized value violates the contract in the documentation comment, and may lead to a SEGV during translaton with -d in_asm. Change the documentation to disallow hostp NULL. Pass hostp to probe_access_internal directly. Reported-by: Panda Jiang <3160104094@zju.edu.cn> Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- accel/tcg/internal-common.h | 2 +- accel/tcg/cputlb.c | 7 +++---- accel/tcg/user-exec.c | 4 +--- 3 files changed, 5 insertions(+), 8 deletions(-) diff --git a/accel/tcg/internal-common.h b/accel/tcg/internal-common.h index 0ca13750f9..9e7be2d78d 100644 --- a/accel/tcg/internal-common.h +++ b/accel/tcg/internal-common.h @@ -82,7 +82,7 @@ void tb_check_watchpoint(CPUState *cpu, uintptr_t retaddr= ); * See get_page_addr_code() (full-system version) for documentation on the * return value. * - * Sets *@hostp (when @hostp is non-NULL) as follows. + * Sets *@hostp as follows. * If the return value is -1, sets *@hostp to NULL. Otherwise, sets *@hostp * to the host address where @addr's content is kept. * diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c index 6900a12682..f9d9697a5a 100644 --- a/accel/tcg/cputlb.c +++ b/accel/tcg/cputlb.c @@ -1545,7 +1545,9 @@ tb_page_addr_t get_page_addr_code_hostp(CPUArchState = *env, vaddr addr, =20 (void)probe_access_internal(env_cpu(env), addr, 1, MMU_INST_FETCH, cpu_mmu_index(env_cpu(env), true), false, - &p, &full, 0, false); + hostp, &full, 0, false); + + p =3D *hostp; if (p =3D=3D NULL) { return -1; } @@ -1554,9 +1556,6 @@ tb_page_addr_t get_page_addr_code_hostp(CPUArchState = *env, vaddr addr, return -1; } =20 - if (hostp) { - *hostp =3D p; - } return qemu_ram_addr_from_host_nofail(p); } =20 diff --git a/accel/tcg/user-exec.c b/accel/tcg/user-exec.c index ddbdc0432d..f8b4a26711 100644 --- a/accel/tcg/user-exec.c +++ b/accel/tcg/user-exec.c @@ -822,9 +822,7 @@ tb_page_addr_t get_page_addr_code_hostp(CPUArchState *e= nv, vaddr addr, flags =3D probe_access_internal(env, addr, 1, MMU_INST_FETCH, false, 0= ); g_assert(flags =3D=3D 0); =20 - if (hostp) { - *hostp =3D g2h_untagged(addr); - } + *hostp =3D g2h_untagged(addr); return addr; } =20 --=20 2.43.0