From nobody Sat Feb 7 08:07:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=eik.bme.hu Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1769535572105759.453948744164; Tue, 27 Jan 2026 09:39:32 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vkn1p-000811-Af; Tue, 27 Jan 2026 12:39:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vkn1n-000807-GG for qemu-devel@nongnu.org; Tue, 27 Jan 2026 12:38:59 -0500 Received: from zero.eik.bme.hu ([2001:738:2001:2001::2001]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vkn1l-0001vG-Em for qemu-devel@nongnu.org; Tue, 27 Jan 2026 12:38:59 -0500 Received: from localhost (localhost [127.0.0.1]) by zero.eik.bme.hu (Postfix) with ESMTP id BECE55969FA; Tue, 27 Jan 2026 18:38:51 +0100 (CET) Received: from zero.eik.bme.hu ([127.0.0.1]) by localhost (zero.eik.bme.hu [127.0.0.1]) (amavis, port 10028) with ESMTP id XcFfARyCfOYS; Tue, 27 Jan 2026 18:38:49 +0100 (CET) Received: by zero.eik.bme.hu (Postfix, from userid 432) id 588F25969F0; Tue, 27 Jan 2026 18:38:49 +0100 (CET) X-Virus-Scanned: amavis at eik.bme.hu From: BALATON Zoltan Subject: [PATCH] rtl8139: Remove ineffective parameter To: qemu-devel@nongnu.org Cc: Jason Wang , Peter Maydell Message-Id: <20260127173849.588F25969F0@zero.eik.bme.hu> Date: Tue, 27 Jan 2026 18:38:49 +0100 (CET) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:738:2001:2001::2001; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-Spam_score_int: 10 X-Spam_score: 1.0 X-Spam_bar: + X-Spam_report: (1.0 / 5.0 requ) BAYES_00=-1.9, HEXHASH_WORD=2.897, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1769535577916154100 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The do_interrupt parameter for rtl8139_do_receive was originally added in commit 6cadb320c7 to avoid generating interrupt when receiving in loopback mode. Later commit 5311fb805a changed this so that this parameter became ineffective and now this parameter is unused and always 1. If this turns out to be a problem maybe there's a better way to fix this so remove the do_interrupt parameter for now to simplify code. Signed-off-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/net/rtl8139.c | 24 ++++++++---------------- 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c index 9fd00574d2..2ad6338ebe 100644 --- a/hw/net/rtl8139.c +++ b/hw/net/rtl8139.c @@ -815,7 +815,8 @@ static bool rtl8139_can_receive(NetClientState *nc) return avail =3D=3D 0 || avail >=3D 1514 || (s->IntrMask & RxOverflow); } =20 -static ssize_t rtl8139_do_receive(NetClientState *nc, const uint8_t *buf, = size_t size_, int do_interrupt) +static ssize_t rtl8139_receive(NetClientState *nc, + const uint8_t *buf, size_t size_) { RTL8139State *s =3D qemu_get_nic_opaque(nc); PCIDevice *d =3D PCI_DEVICE(s); @@ -1173,20 +1174,11 @@ static ssize_t rtl8139_do_receive(NetClientState *n= c, const uint8_t *buf, size_t } =20 s->IntrStatus |=3D RxOK; - - if (do_interrupt) - { - rtl8139_update_irq(s); - } + rtl8139_update_irq(s); =20 return size_; } =20 -static ssize_t rtl8139_receive(NetClientState *nc, const uint8_t *buf, siz= e_t size) -{ - return rtl8139_do_receive(nc, buf, size, 1); -} - static void rtl8139_reset_rxring(RTL8139State *s, uint32_t bufferSize) { s->RxBufferSize =3D bufferSize; @@ -1745,7 +1737,7 @@ static uint32_t rtl8139_RxConfig_read(RTL8139State *s) } =20 static void rtl8139_transfer_frame(RTL8139State *s, uint8_t *buf, int size, - int do_interrupt, const uint8_t *dot1q_buf) + const uint8_t *dot1q_buf) { struct iovec *iov =3D NULL; struct iovec vlan_iov[3]; @@ -1828,7 +1820,7 @@ static int rtl8139_transmit_one(RTL8139State *s, int = descriptor) s->TxStatus[descriptor] |=3D TxHostOwns; s->TxStatus[descriptor] |=3D TxStatOK; =20 - rtl8139_transfer_frame(s, txbuffer, txsize, 0, NULL); + rtl8139_transfer_frame(s, txbuffer, txsize, NULL); =20 DPRINTF("+++ transmitted %d bytes from descriptor %d\n", txsize, descriptor); @@ -2246,7 +2238,7 @@ static int rtl8139_cplus_transmit_one(RTL8139State *s) DPRINTF("+++ C+ mode TSO transferring packet size " "%d\n", tso_send_size); rtl8139_transfer_frame(s, saved_buffer, tso_send_size, - 0, (uint8_t *) dot1q_buffer); + (uint8_t *)dot1q_buffer); =20 /* add transferred count to TCP sequence number */ stl_be_p(&p_tcp_hdr->th_seq, @@ -2323,8 +2315,8 @@ skip_offload: =20 DPRINTF("+++ C+ mode transmitting %d bytes packet\n", saved_size); =20 - rtl8139_transfer_frame(s, saved_buffer, saved_size, 1, - (uint8_t *) dot1q_buffer); + rtl8139_transfer_frame(s, saved_buffer, saved_size, + (uint8_t *)dot1q_buffer); =20 /* restore card space if there was no recursion and reset offset */ if (!s->cplus_txbuffer) --=20 2.41.3