From nobody Sat Feb 7 07:11:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1769524112; cv=none; d=zohomail.com; s=zohoarc; b=CahpMA5adGNMNKfBselma2fMMygaf/VRo1PLFbHfe5UCirsaa21FzeEszQfNIV8ncXM7HsS7ae3k/xOTDYnOzNPRcVJSe22JlcQTyic5Rfhzsn3THGzaGd+CJI4ORjS04AANDaQPNMOSKO2smpLG29erM4RcuW0Bp/xfGzEDlAM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769524112; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=46Z3aYCwOkKhlvtkaL8asS4eqySRO8FYDHF3vG+bbWg=; b=jg0Wt1XqfjlMONf1VUAyU/NRUjra14/U3NvglthYIm/fn2snGJ87d1K/sJkp6P6l04HrvriRbU8r5PzI/yrFyovP3K4sN4f8VgYm1MwXqi3DhspvAbW7ikOFm4wqbfFyBzmFm5bSBr+A0Q1U9z90DezACkrKJOhE+rzYqs6Jwh4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1769524112346245.842201100363; Tue, 27 Jan 2026 06:28:32 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vkk2i-0006Jq-U5; Tue, 27 Jan 2026 09:27:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vkk2W-0006Ce-PW for qemu-devel@nongnu.org; Tue, 27 Jan 2026 09:27:32 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vkk2U-0003bf-8b for qemu-devel@nongnu.org; Tue, 27 Jan 2026 09:27:32 -0500 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-212-7MrgcSBdNvGqnoZJcucARA-1; Tue, 27 Jan 2026 09:27:25 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8CFF31955F2C; Tue, 27 Jan 2026 14:27:24 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.224.209]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id EC8DB18001D5; Tue, 27 Jan 2026 14:27:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769524049; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=46Z3aYCwOkKhlvtkaL8asS4eqySRO8FYDHF3vG+bbWg=; b=En3brGyAg1Mk9XI2vczaI++ksN+7WRVl3WBa7ffxEQ96B1LT0KHxHl/aj0d/h3m27Q9M1t /w9ikQfk4RFLpkIIhrA5z88HcymSj4TILZMnvUKwOlj0GRGWyPKaCE8P5iPHxBgJK9nhqw 4dWY0cueBSLcGOdxBXS5jOU3GVePTMs= X-MC-Unique: 7MrgcSBdNvGqnoZJcucARA-1 X-Mimecast-MFC-AGG-ID: 7MrgcSBdNvGqnoZJcucARA_1769524044 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Fabiano Rosas Subject: [PULL 4/9] tests/functional/x86_64: Use the right Python interpreter & fix format string Date: Tue, 27 Jan 2026 15:27:05 +0100 Message-ID: <20260127142710.131904-5-thuth@redhat.com> In-Reply-To: <20260127142710.131904-1-thuth@redhat.com> References: <20260127142710.131904-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1769524113800158500 From: Thomas Huth The bad_vmstate test currently fails if the host does not have a "python3" binary in $PATH because the vmstate-static-checker.py script is executed directly, so that it gets run via its shebang line. Use the right Python interpreter from sys.executable to fix this problem. Additionally, there was another bug with the formatting of the error message in case of failures: The "+" operator can only concatenate strings, but not strings with integers. Use a proper format string here instead. Reviewed-by: Daniel P. Berrang=C3=A9 Acked-by: Fabiano Rosas Signed-off-by: Thomas Huth Message-ID: <20260114101101.36225-1-thuth@redhat.com> --- tests/functional/x86_64/test_bad_vmstate.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/functional/x86_64/test_bad_vmstate.py b/tests/functional= /x86_64/test_bad_vmstate.py index 40098a8490b..71a1c0cf638 100755 --- a/tests/functional/x86_64/test_bad_vmstate.py +++ b/tests/functional/x86_64/test_bad_vmstate.py @@ -5,6 +5,7 @@ '''Test whether the vmstate-static-checker script detects problems correct= ly''' =20 import subprocess +import sys =20 from qemu_test import QemuBaseTest =20 @@ -41,12 +42,13 @@ def test_checker(self): 'vmstate-static-checker.py') =20 self.log.info('Comparing %s with %s', src_json, dst_json) - cp =3D subprocess.run([checkerscript, '-s', src_json, '-d', dst_js= on], + cp =3D subprocess.run([sys.executable, checkerscript, + '-s', src_json, '-d', dst_json], stdout=3Dsubprocess.PIPE, stderr=3Dsubprocess.STDOUT, text=3DTrue, check=3DFalse) if cp.returncode !=3D 13: - self.fail('Unexpected return code of vmstate-static-checker: '= + + self.fail('Unexpected return code of vmstate-static-checker: %= d' % cp.returncode) if cp.stdout !=3D EXPECTED_OUTPUT: self.log.info('vmstate-static-checker output:\n%s', cp.stdout) --=20 2.52.0