From nobody Mon Feb 9 21:21:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1769508214; cv=none; d=zohomail.com; s=zohoarc; b=MwLO4LPdmpYH/pmkW34hgV1izD68XUe1WGYygUKIurPXtqP9rO9SciyeJb1NpUDs6GC9S0uVHFOFQHBMS8Opv3pskd+ZCiVmC/XauJYTgKBRNdtwXNi/JxsggwW2Ll949n5T+w6TjjHbT+sZi7YdTPX7dn6Op9CWrM12f2ZYNXA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769508214; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=WBzv/EEHOLl1lvpY0Tolfh3wVeN8GBPJIxvAOWVtvEE=; b=P9b1bTumH3/T9PnEquZkgHdR7UU9y7lT17GKbYoRZCLgnasz1V2YOuNYPrK8IQVRNEmSiEAEDLoY3CWaLMOSoVwqCq+VnFrC26flTpXJZ7Q8Hbw4SEt1A2KL3WS15SoZI7LUiZprDWHjM9UG6YKOKYXDHDfnQpPCa+8FWilOGcM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176950821473379.99811622805578; Tue, 27 Jan 2026 02:03:34 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vkfuw-0003mO-95; Tue, 27 Jan 2026 05:03:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vkfup-0003YO-Ld for qemu-devel@nongnu.org; Tue, 27 Jan 2026 05:03:19 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vkful-0005Ay-7S for qemu-devel@nongnu.org; Tue, 27 Jan 2026 05:03:18 -0500 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-416-tnIzJSu7MLS8Vs75LPlsJQ-1; Tue, 27 Jan 2026 05:03:11 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1C8CF19775E0; Tue, 27 Jan 2026 10:03:10 +0000 (UTC) Received: from osteffen-thinkpadx1carbongen12.rmtde.csb (unknown [10.44.34.174]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2B84A180066A; Tue, 27 Jan 2026 10:03:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769508194; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WBzv/EEHOLl1lvpY0Tolfh3wVeN8GBPJIxvAOWVtvEE=; b=OdzPWYf6Emrf64EitnP0GjTmxppkjA56hfhXkDBxvROUrfhTNKm1f1/x7HmOi3O3ODD+sv AHJ8lvTQsrxMopBJVy410kyC0OZonJRDgNLLKvyRW72doLazG8+Z6laMK/XCvGK3JjEljo GiDRZMKlCalgiwm+hyolkCAQycmumEE= X-MC-Unique: tnIzJSu7MLS8Vs75LPlsJQ-1 X-Mimecast-MFC-AGG-ID: tnIzJSu7MLS8Vs75LPlsJQ_1769508190 From: Oliver Steffen To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Eduardo Habkost , Gerd Hoffmann , Stefano Garzarella , Zhao Liu , Marcel Apfelbaum , Igor Mammedov , Marcelo Tosatti , Richard Henderson , Ani Sinha , kvm@vger.kernel.org, "Michael S. Tsirkin" , Luigi Leonardi , Joerg Roedel , Oliver Steffen Subject: [PATCH v5 1/6] hw/acpi: Make BIOS linker optional Date: Tue, 27 Jan 2026 11:02:52 +0100 Message-ID: <20260127100257.1074104-2-osteffen@redhat.com> In-Reply-To: <20260127100257.1074104-1-osteffen@redhat.com> References: <20260127100257.1074104-1-osteffen@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=osteffen@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1769508216191154100 Content-Type: text/plain; charset="utf-8" Make the BIOS linker optional in acpi_table_end() and calculate the ACPI table checksum directly if no linker is provided. This makes it possible to call for example acpi_build_madt() from outside the ACPI table builder context. Signed-off-by: Oliver Steffen --- hw/acpi/aml-build.c | 29 +++++++++++++++++++++++++++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index dad4cfcc7d..6a3650076f 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -1730,6 +1730,25 @@ void acpi_table_begin(AcpiTable *desc, GArray *array) build_append_int_noprefix(array, 1, 4); /* Creator Revision */ } =20 +static uint8_t calculate_acpi_checksum(const gchar *data, size_t len) +{ + size_t i; + uint8_t sum =3D 0; + + for (i =3D 0; i < len; ++i) { + sum +=3D (uint8_t)data[i]; + } + + return sum; +} + +static void update_acpi_checksum(gchar *data, size_t start_offset, + size_t table_len, size_t checksum_offset) +{ + uint8_t sum =3D calculate_acpi_checksum(&data[start_offset], table_len= ); + data[checksum_offset] =3D 0xff - sum + 1; +} + void acpi_table_end(BIOSLinker *linker, AcpiTable *desc) { /* @@ -1748,8 +1767,14 @@ void acpi_table_end(BIOSLinker *linker, AcpiTable *d= esc) */ memcpy(len_ptr, &table_len_le, sizeof table_len_le); =20 - bios_linker_loader_add_checksum(linker, ACPI_BUILD_TABLE_FILE, - desc->table_offset, table_len, desc->table_offset + checksum_offse= t); + if (linker !=3D NULL) { + bios_linker_loader_add_checksum(linker, ACPI_BUILD_TABLE_FILE, + desc->table_offset, table_len, + desc->table_offset + checksum_offs= et); + } else { + update_acpi_checksum(desc->array->data, desc->table_offset, + table_len, desc->table_offset + checksum_offs= et); + } } =20 void *acpi_data_push(GArray *table_data, unsigned size) --=20 2.52.0