From nobody Sun Jan 25 12:11:28 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1769279453; cv=none; d=zohomail.com; s=zohoarc; b=fTPDm6zh9jMLMNlNiNz2FmBi0yA1ACqAi4USgizOVCI1RruUvI0XMC2Bz28Yd9ZWwWxyHc60kfBe+V5TNkeoL0BGa+2KUWc9kcMuZtcYdKnI6ja+It+C1ZfQ1+IzWOL+Z8w0RT6If5vzu0HHWfgXhPdGUUplhStHeG0F6A9fmvQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769279453; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=BAwgkxcCnnqe9jCM08ttRZ7hAqumVGJ7T0ER05F6LwQ=; b=RMy+LX0/HDZ9lY9qwh8atTZVXdi4KLEX3VZqnhpFwKxg++b5UcRSud62XgpFblRRFVCtMj7LZeddp6eR77ibq4bIE2PczsLRWdl045IPj/z0WkjnSCe7m84jECUR6Ft+SKONKYcPCvwDX0NQKczrCpriIiD5+nJMGqWpRdEQUcA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1769279453090874.8656266757578; Sat, 24 Jan 2026 10:30:53 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vjiOF-0004Q9-Bu; Sat, 24 Jan 2026 13:29:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vjiOC-0004OU-Ih for qemu-devel@nongnu.org; Sat, 24 Jan 2026 13:29:40 -0500 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vjiOB-0003it-2H for qemu-devel@nongnu.org; Sat, 24 Jan 2026 13:29:40 -0500 Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-8230c2d3128so1252883b3a.0 for ; Sat, 24 Jan 2026 10:29:38 -0800 (PST) Received: from pc.taild8403c.ts.net (216-71-219-44.dyn.novuscom.net. [216.71.219.44]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8231871d432sm5296485b3a.42.2026.01.24.10.29.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Jan 2026 10:29:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769279378; x=1769884178; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BAwgkxcCnnqe9jCM08ttRZ7hAqumVGJ7T0ER05F6LwQ=; b=O956HxEZfSPx8GCvnPSsJwJxxHSVmLD/iYV6cRktl32P2eBBI44CVs89BAqeLF49tc sA7gaUCFXz4+/wwHZ711hJfnsFztrvh9A8PjhwtLLkx9a7fHmV5B8gBcHh8t51p+lTKu uODrRjGauh2T27X5Cn0V+qrNA3HBfXFUyi/Us2ymOPVNFYlT5s4S30qp+aCdMzC9D+Os SWBAI0d8xfXWORgQ4dSr8b4T3kf4tjtjCjptwY3oHR1bYYAObK6/lS6JgY19QSohyN88 WJHPurmA9RcFIJwyazqDNH4iAmCn2eCQU1WpZ6Y/nYNJ+Db7sx2gvVdrLgfHey477aQ/ +hVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769279378; x=1769884178; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BAwgkxcCnnqe9jCM08ttRZ7hAqumVGJ7T0ER05F6LwQ=; b=imhLPWWodiXLW8VaWGhEQ9okPpER7OvRG2SeMbiTISuQvnXE8j4X4Fu+3FuuFwATiM C7Fcpum9eP5fJZo8XkgUn7YRUFd83+3HGg9KQVOsbWVwe1F07wRBPqTlOdUfruKmXshp IhWvrevmOIi/boCpTzRE5SJGKyJGQlGccVrJv1I/EiiAGX4MnrqkMc5V6R6XiW8Vsz5Q j24oTUmIh0N7vV9mApdT3YMNECGQxjZiwL/pubyWIrEFSmLkLuZMbM8D/ctRUFPSm9iF XGtaux9tsGnMEKuSI01nZEZb+tj545ZD+p4Ro+B9LPJ3DNg2AnuWJoedwyanmOE6BMGE pnrw== X-Gm-Message-State: AOJu0Yyy5nnfMdEgLyDTTtl4EPChmDZAD/9ZStr813Xr3decBo4ObyEk LP73WZd9uHx6BAgexh5a2kKaedTmS1AjLQ6LB/R0VymUTlov/e02/H4xwYPwNiTa6w0mR+fmgbY isnpAygc= X-Gm-Gg: AZuq6aLVzxM7eKCwYXd9OZtUG0NkNpzXIykwA8JYmAzuCywSZzRxqwhsNuj4AyCNazN uKQR7JeBc9xZP1SY+OMkZSC5Qoi7KMRpoMh/z/P5/tffHt7AvwwZmmjVh7oREWNYlDa99nf95T4 KyD/kRQn4BneLAgdhfUTYWfc/IjEHaD4LD+/FzcHcGPwTa91UcdDJRi+8gesiOaWZq13cfhnL1F QXduy56Ev+WJ8CNVswgt/5QT5VgaegHZAJ+EvkSc6brXLdSmzN4wB3+uySEBeOeOR1JY4JMJEdA qWQ0fpY90guKnWy6rOEfZ9mEdcquUKIZ+QdcZ43znT5F8gyexLXNP80qG3AaTQMNePlVKLObtYb oBNAh5z57bbJjbqi01ZQsKqxKtOTJC37aRspb3oZ8EyGXY36tOqkIHfg/Zqr7/RwBkM2HyslWin +kjsK4TsGankiBVkRMBqgf6U20N2ctuiBh9wyq1bA8ZKrHJgS7fSH0ZyBEvawuXE7/ X-Received: by 2002:a05:6a00:800e:b0:81f:7db2:89cf with SMTP id d2e1a72fcca58-82317ea4fafmr5626890b3a.39.1769279377703; Sat, 24 Jan 2026 10:29:37 -0800 (PST) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Mahmoud Mandour , Kostiantyn Kostiuk , Pierrick Bouvier , =?UTF-8?q?Phil=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Manos Pitsidianakis , Gustavo Bueno Romero , Michael Roth , Richard Henderson , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Alexandre Iooss Subject: [PATCH v4 09/11] qga/vss-win32: fix clang warning with C++20 Date: Sat, 24 Jan 2026 10:29:19 -0800 Message-ID: <20260124182921.531562-10-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260124182921.531562-1-pierrick.bouvier@linaro.org> References: <20260124182921.531562-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::432; envelope-from=pierrick.bouvier@linaro.org; helo=mail-pf1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1769279455504154100 Content-Type: text/plain; charset="utf-8" C++20 deprecated such constructs. ../qga/vss-win32/requester.cpp:380:32: error: bitwise operation between dif= ferent enumeration types ('_VSS_SNAPSHOT_CONTEXT' and '_VSS_VOLUME_SNAPSHOT= _ATTRIBUTES') is deprecated [-Werror,-Wdeprecated-enum-enum-conversion] 380 | ctx =3D VSS_CTX_APP_ROLLBACK | VSS_VOLSNAP_ATTR_TRANSPORTABLE | This is a false positive, since VSS_CTX_APP_ROLLBACK is not a value defined in _VSS_VOLUME_SNAPSHOT_ATTRIBUTES enum. Reviewed-by: Manos Pitsidianakis Signed-off-by: Pierrick Bouvier --- qga/vss-win32/requester.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp index 5615955b6f3..74489fcd0ae 100644 --- a/qga/vss-win32/requester.cpp +++ b/qga/vss-win32/requester.cpp @@ -377,8 +377,10 @@ void requester_freeze(int *num_vols, void *mountpoints= , ErrorSet *errset) * To prevent the final commit (which requires to write to snapshots), * ATTR_NO_AUTORECOVERY and ATTR_TRANSPORTABLE are specified here. */ - ctx =3D VSS_CTX_APP_ROLLBACK | VSS_VOLSNAP_ATTR_TRANSPORTABLE | - VSS_VOLSNAP_ATTR_NO_AUTORECOVERY | VSS_VOLSNAP_ATTR_TXF_RECOVERY; + ctx =3D VSS_CTX_APP_ROLLBACK; + ctx |=3D VSS_VOLSNAP_ATTR_TRANSPORTABLE | + VSS_VOLSNAP_ATTR_NO_AUTORECOVERY | + VSS_VOLSNAP_ATTR_TXF_RECOVERY; hr =3D vss_ctx.pVssbc->SetContext(ctx); if (hr =3D=3D (HRESULT)VSS_E_UNSUPPORTED_CONTEXT) { /* Non-server version of Windows doesn't support ATTR_TRANSPORTABL= E */ --=20 2.47.3