From nobody Sun Jan 25 11:58:22 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1769198149; cv=none; d=zohomail.com; s=zohoarc; b=e7NODNTuCLwf3/ikkbvCImdHPDksTzWKRVHFCj5khRaxfCcZhpPt/nx3V0EWMN2ogbOu2NIeDV+JnGF3mDiEs/rjjO+1FRU5DzlrjMNkyRo5qVIVPreM+UzkwZV1wTD7Z0Zzy39Ma9oWb6AB+R2rI7JWK3aU+7Mao1I8jya0sJk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769198149; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=mg05fAJm3+UU6nlxzOt6lsvc93K7OVfV8QxdqW6GyEo=; b=LEyuVrqzQcOQCrVcWK3tZMPASAmFZ7EmdAIHDFNlI3aYBYE6t4L5VlXqXrkkL2AyyMXSsxnsYgxUYO49dWqojMhl4VG9M6s4AQDYN0cRr/746De4ZzYGtPQozfL8V+3R1Lo1frFoSxqSQEEgllNVx/F69u/SGshlyhq9zviqLOc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1769198149825771.7894660134491; Fri, 23 Jan 2026 11:55:49 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vjNEX-0001xB-1T; Fri, 23 Jan 2026 14:54:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vjNEU-0001wW-UB for qemu-devel@nongnu.org; Fri, 23 Jan 2026 14:54:14 -0500 Received: from smtp-out2.suse.de ([2a07:de40:b251:101:10:150:64:2]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vjNET-0003T9-C5 for qemu-devel@nongnu.org; Fri, 23 Jan 2026 14:54:14 -0500 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E51B95BCCC; Fri, 23 Jan 2026 19:54:06 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 914E01395E; Fri, 23 Jan 2026 19:54:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 0BtVFN3Rc2lFZQAAD6G6ig (envelope-from ); Fri, 23 Jan 2026 19:54:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1769198047; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mg05fAJm3+UU6nlxzOt6lsvc93K7OVfV8QxdqW6GyEo=; b=YEWhYgmuSdvWD+KUPmJu2zJEsUufGUaQUQEZR7DARFRktY4aQxADG/H4ctG4ArbtBCJZXy YxVmQtdn9w1ad58SGGv5573oDALXi117BfKbAkfbp76edU71R8nkhP1aaQqSOQos3VUaW+ uMvNwEHD6VJlGyeStd0FkjhOl99bapo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1769198047; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mg05fAJm3+UU6nlxzOt6lsvc93K7OVfV8QxdqW6GyEo=; b=xmgyuHg73ltoBjVtw00JBFDnHFbF64+2SPumVCn8zKX7sjWpVD9rcWphN1JyeT7+SVZ81e Lc6soYq8LTz8oUDg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=RhptAFj+; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=D+hV2lGH DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1769198046; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mg05fAJm3+UU6nlxzOt6lsvc93K7OVfV8QxdqW6GyEo=; b=RhptAFj+6SZaeWHj3H64bwMDRO3mPACYcONoEgAvd8INgqIHTQ8E5LNasEZfWcs9ULvrSP Tc5TxEHusfILo/CoyptLRisAoWbDe6YZej3LpEU5MT5XPbP2OY14nkDBjSE2UrJmLkwrSW KFtVfQsZSfKsqlong2wNHkzmTkbHXAE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1769198046; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mg05fAJm3+UU6nlxzOt6lsvc93K7OVfV8QxdqW6GyEo=; b=D+hV2lGHYlVDL/qyr4muwtpmP5/JAznJrWymqANBlRLQMikX7Ni2Ydh3mDs0b8O+6cx5hR ESG/dWgPW6X5/uAw== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Peter Xu , Vladimir Sementsov-Ogievskiy Subject: [PULL 06/36] qemu-file: qemu_file_get_fd(): check service byte itself Date: Fri, 23 Jan 2026 16:53:21 -0300 Message-ID: <20260123195352.12850-7-farosas@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260123195352.12850-1-farosas@suse.de> References: <20260123195352.12850-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.01 X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-Rspamd-Queue-Id: E51B95BCCC X-Rspamd-Server: rspamd1.dmz-prg2.suse.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a07:de40:b251:101:10:150:64:2; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) (identity @suse.de) X-ZM-MESSAGEID: 1769198152059154100 Content-Type: text/plain; charset="utf-8" From: Vladimir Sementsov-Ogievskiy We can check it, so, why not. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Fabiano Rosas Link: https://lore.kernel.org/qemu-devel/20260114064710.176268-5-vsementsov= @yandex-team.ru Signed-off-by: Fabiano Rosas --- migration/qemu-file.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/migration/qemu-file.c b/migration/qemu-file.c index 847694e2cf..8fdb6c87ea 100644 --- a/migration/qemu-file.c +++ b/migration/qemu-file.c @@ -390,13 +390,19 @@ int qemu_file_get_fd(QEMUFile *f) int fd =3D -1; FdEntry *fde; Error *err =3D NULL; + int service_byte; =20 if (!f->can_pass_fd) { error_setg(&err, "%s does not support fd passing", f->ioc->name); goto fail; } =20 - qemu_get_byte(f); + service_byte =3D qemu_get_byte(f); + if (service_byte !=3D ' ') { + error_setg(&err, "%s unexpected service byte: %d(%c)", f->ioc->nam= e, + service_byte, service_byte); + goto fail; + } =20 fde =3D QTAILQ_FIRST(&f->fds); if (!fde) { --=20 2.51.0