From nobody Sun Jan 25 11:58:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1769198111; cv=none; d=zohomail.com; s=zohoarc; b=goXvcC1VhGX76rVLqJVsHaqLeSaHFTMgWEh9XlZ3MSM3qD7Q01mbqZFcKWGnSnor/EuPGHq1jC/tY208guW3iQW5q6xUqtGit/UfmVVoWNU1HZQLo+w5QSzz0QKD3VFUsHe0oPrNGr716/GGZGCOHSvdm1gIvzKku1zGb1EZiSA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769198111; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=83nviFH4YNOWNJqbgEjodftmqLoMi6VChFdSyuzvm9A=; b=HVYr5vdA5bmrJyYkjpnMNxyJx/a+8UIh1exfADrWQM3JlayYpSR3Yz4Qd4QaJiAs4cvFiPO+vM9SxxtNa2p7U3AfEnXV4equ+tf7SKuLBEPMFs+ka6fNBVyhsV8aOLaucOlrjsIB5y9nsD4amnFh7maYagi3sS4vjmrZdqYcnyI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1769198111171203.7920479649713; Fri, 23 Jan 2026 11:55:11 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vjNEY-0001xH-8s; Fri, 23 Jan 2026 14:54:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vjNEW-0001ww-JC for qemu-devel@nongnu.org; Fri, 23 Jan 2026 14:54:16 -0500 Received: from smtp-out1.suse.de ([2a07:de40:b251:101:10:150:64:1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vjNEV-0003TT-6Q for qemu-devel@nongnu.org; Fri, 23 Jan 2026 14:54:16 -0500 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8ABE43385F; Fri, 23 Jan 2026 19:54:01 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 376C11395E; Fri, 23 Jan 2026 19:53:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id aGYVOtfRc2lFZQAAD6G6ig (envelope-from ); Fri, 23 Jan 2026 19:53:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1769198041; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=83nviFH4YNOWNJqbgEjodftmqLoMi6VChFdSyuzvm9A=; b=lqyPlAOola87FWQ9ffQtSxkq6mARCyTLVM5vlFs4p5OqoDIARw0iOzzA6duFMV/ggBhAhm fsxHzFfZBu+tdKpW4zuFoLPiSgIV61KEJu026GmIBCSq4CCef0/1jgOf5J+sNlxp9raYcq 6b/OqT7U2N2+pJ1Zxx9qbkO3rTiLi5c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1769198041; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=83nviFH4YNOWNJqbgEjodftmqLoMi6VChFdSyuzvm9A=; b=StXQHSW0rtTe8zXZoOUDLR+ZoarJGzOXpEqMWKRug4h+NROAQvi3aBTWD7kPSdyYBP8zOx 9dfAyBwe+qtMzKCg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1769198041; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=83nviFH4YNOWNJqbgEjodftmqLoMi6VChFdSyuzvm9A=; b=lqyPlAOola87FWQ9ffQtSxkq6mARCyTLVM5vlFs4p5OqoDIARw0iOzzA6duFMV/ggBhAhm fsxHzFfZBu+tdKpW4zuFoLPiSgIV61KEJu026GmIBCSq4CCef0/1jgOf5J+sNlxp9raYcq 6b/OqT7U2N2+pJ1Zxx9qbkO3rTiLi5c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1769198041; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=83nviFH4YNOWNJqbgEjodftmqLoMi6VChFdSyuzvm9A=; b=StXQHSW0rtTe8zXZoOUDLR+ZoarJGzOXpEqMWKRug4h+NROAQvi3aBTWD7kPSdyYBP8zOx 9dfAyBwe+qtMzKCg== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Peter Xu , Vladimir Sementsov-Ogievskiy Subject: [PULL 03/36] vmstate-types: get_fd(): handle qemu_file_get_fd() failure Date: Fri, 23 Jan 2026 16:53:18 -0300 Message-ID: <20260123195352.12850-4-farosas@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260123195352.12850-1-farosas@suse.de> References: <20260123195352.12850-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-Spam-Score: -2.80 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a07:de40:b251:101:10:150:64:1; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1769198112499158500 Content-Type: text/plain; charset="utf-8" From: Vladimir Sementsov-Ogievskiy qemu_file_get_fd() may fail, and return -1 in this case. We don't support passing "invalid" file descriptors (like -1), so we should not interpret error here like invalid descriptor. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Fabiano Rosas Link: https://lore.kernel.org/qemu-devel/20260114064710.176268-2-vsementsov= @yandex-team.ru Signed-off-by: Fabiano Rosas --- migration/vmstate-types.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/migration/vmstate-types.c b/migration/vmstate-types.c index 4b01dc19c2..e34bf4486e 100644 --- a/migration/vmstate-types.c +++ b/migration/vmstate-types.c @@ -321,12 +321,21 @@ const VMStateInfo vmstate_info_uint64 =3D { static int get_fd(QEMUFile *f, void *pv, size_t size, const VMStateField *field) { + int fd; int32_t *v =3D pv; + if (migrate_mode() =3D=3D MIG_MODE_CPR_EXEC) { qemu_get_sbe32s(f, v); return 0; } - *v =3D qemu_file_get_fd(f); + + fd =3D qemu_file_get_fd(f); + if (fd < 0) { + return -1; + } + + *v =3D fd; + return 0; } =20 --=20 2.51.0