From nobody Sun Jan 25 12:00:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1769181253; cv=none; d=zohomail.com; s=zohoarc; b=CNqf0JyP/6Z/y8qC3PozG6ycpEUGiVjawQw4qIuMd4cpJGiKDcbEQvs4aGyVkiKQlig9wncHtBBVj0yLrNMShHLVsfz6pUnwr5sf8hZm4xxHKaWJW5bbwjiENJDqWB5JC4R6aNASVowHZqc8dRJh6VhbjqEvq71uromyS9ELu4c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769181253; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=VYPv2joWEy7NQbj1wDZIlmJyo9qqTDgvEnE16RTvAgs=; b=P9G65DhWJA+xKsen4yYBwO0nqH+6Trzv0xsB8GxoNVUrFrFw7LuOemv+e9La5x2D5dBrgPVvdDGE0sXDkEGO8UpcWtVEUJnlXujr591l3QcEAx+C/iz5y1OP2M6l98CeehZIp33AmVBgbz+8ZtjV4ksK8NaJrL+cnzrwn2KRfXg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1769181253621163.7378662605339; Fri, 23 Jan 2026 07:14:13 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vjIpD-0001SZ-W7; Fri, 23 Jan 2026 10:11:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vjInT-000781-7f for qemu-devel@nongnu.org; Fri, 23 Jan 2026 10:10:09 -0500 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vjInR-00036i-4z for qemu-devel@nongnu.org; Fri, 23 Jan 2026 10:10:02 -0500 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-42fbbc3df8fso1509609f8f.2 for ; Fri, 23 Jan 2026 07:10:00 -0800 (PST) Received: from mnementh.archaic.org.uk (mnementh.archaic.org.uk. [81.2.115.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435b1e71503sm8255641f8f.25.2026.01.23.07.09.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jan 2026 07:09:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769180999; x=1769785799; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=VYPv2joWEy7NQbj1wDZIlmJyo9qqTDgvEnE16RTvAgs=; b=w620DCyzyR6e0krcDkUKmOg5jNCsoszq6Vep0ZM06tWPzdLteeZpi+upLmoBYYd3n6 GlQ4IGBrluozhl7wDrYnizNgtJjyIoG/OHPGHuFAxWDNP3YsBDxBXbhAhbdvTWJC3yqk tEecHwXotBPh0bS0VrgiCEQ5YYXh0UBUdpdG0PsuFcxZR1R+uNtKo6nH/GX4sCjyYVvL L8Yneio+yIbvQxthDAYUSYFTMibKdni6dzNg1D9TiHyDGm6fgcAv+eMqEIJPI0L+KiBb 5d/Iknw4LgQGy4OTxNOHbSzcFNPX9gAOy/iGS2Vl0N/w4iQyzAsyz7oPnYbZX/krrR91 FSkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769181000; x=1769785800; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=VYPv2joWEy7NQbj1wDZIlmJyo9qqTDgvEnE16RTvAgs=; b=ZiTjIX51ggErosIEHRbY6PAkXUxZQZkyQHfCERIFcf/hZ4TSdmmw1tPx/mU1XQ4tsg M9dMvbvKexrhFZIXiVzsiyMpRN41mHwFPqb8t1c7isBUZM+RHyTIr9aOqrofPoFkugWq rRRdk9xv4G4tGtg7bMPPoWJynRXV7VY5SRgIipaClXyhbfm72nY2SP0cwPzNf3F1nzCa R8BzlVaqtneKg1MIrsER2MvTejLWA7jOe1b2k+Q1dJ9BxG93AdcAm05RD79tM/XoIU4J cgJpEhGSjiSlSoVqfIG4aqYsTXUai8AT4CEjKFHpPfy0bRuuqFWu/1RB0OB43NTupeRa JI8A== X-Gm-Message-State: AOJu0YyB0YR3XYNegSsKZNjS8BeoUQf/T+QzqTk7x0H87v4rbk10oD5n K77/XSQwr43KOrE8hGJzU0Qzm9gm1XCj82vqW37xJSBWWqv70FQFwdxt/LBm4sKTLtU3LVPHvN7 UyMOkS5g= X-Gm-Gg: AZuq6aJCaWD2OQTJe5Zug4BB6lmlDxyqoWcA5Qr16RSGXvE9CmkwWkB+OdNxv1tFIPG MrESrBc+TkJJGoJStoKjJ8+hYnCBdBScKUH4I3QxYxZ221APb6basDPkTftNd7htpEeIWjgBQ4t +gGHGJI1qGKKohbyvSbjLJN/wPErLZIct917ceK4i44piBLFrSIo78rQK7nenYo2DT5CqtfVE35 dlGp49Kjp7Lj218MnWlArTuV4UBJ2ltJQA3LPvU7hFk0AoZPJsJGSCzSALF9BnqZwcJfjoKZYjK huzxcQo80wAcbXJhIxxbF0VN6rfYP0dTnLFJJiOo7B12cJ0EqJwjVLOJoKAiekaz9+aST7fTG+c W9PSTSDypI/0pOXEkaXVhOL9PbmaJKM2MHQq8+IuqsCkAq04Dm21rwp++bmP+Blmr5vm8g35xlw V7q2sgPuBgDDP3v+CXBLMF4zUk6gQEtce2MMjirY8i1K0qtYQYQDy9hFbpnJuv4Ls= X-Received: by 2002:a5d:5d0d:0:b0:435:a2f8:150d with SMTP id ffacd0b85a97d-435b1750380mr4795804f8f.59.1769180999399; Fri, 23 Jan 2026 07:09:59 -0800 (PST) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 18/22] hw/intc: avoid byte swap fiddling in gicv3 its path Date: Fri, 23 Jan 2026 15:09:36 +0000 Message-ID: <20260123150941.1877768-19-peter.maydell@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260123150941.1877768-1-peter.maydell@linaro.org> References: <20260123150941.1877768-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1769181255577154100 From: Alex Benn=C3=A9e This allows us to keep the MSI data in plain host order all the way from the MemoryRegionOps write method to the final KVM_SIGNAL_MSI ioctl. This fixes a theoretical bug on big-endian hosts because we were using different size byte swaps which would have truncated the data. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Peter Maydell Message-id: 20260121105932.135676-5-alex.bennee@linaro.org Cc: qemu-stable@nongnu.org Signed-off-by: Peter Maydell --- hw/intc/arm_gicv3_its_common.c | 2 +- hw/intc/arm_gicv3_its_kvm.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/intc/arm_gicv3_its_common.c b/hw/intc/arm_gicv3_its_common.c index 9fc51ad1e0..60a5abd8d3 100644 --- a/hw/intc/arm_gicv3_its_common.c +++ b/hw/intc/arm_gicv3_its_common.c @@ -81,7 +81,7 @@ static MemTxResult gicv3_its_trans_write(void *opaque, hw= addr offset, if (offset =3D=3D 0x0040 && ((size =3D=3D 2) || (size =3D=3D 4))) { GICv3ITSState *s =3D ARM_GICV3_ITS_COMMON(opaque); GICv3ITSCommonClass *c =3D ARM_GICV3_ITS_COMMON_GET_CLASS(s); - int ret =3D c->send_msi(s, le64_to_cpu(value), attrs.requester_id); + int ret =3D c->send_msi(s, value, attrs.requester_id); =20 if (ret <=3D 0) { qemu_log_mask(LOG_GUEST_ERROR, diff --git a/hw/intc/arm_gicv3_its_kvm.c b/hw/intc/arm_gicv3_its_kvm.c index ae12d41eee..a8d6d4fb54 100644 --- a/hw/intc/arm_gicv3_its_kvm.c +++ b/hw/intc/arm_gicv3_its_kvm.c @@ -58,7 +58,7 @@ static int kvm_its_send_msi(GICv3ITSState *s, uint32_t va= lue, uint16_t devid) =20 msi.address_lo =3D extract64(s->gits_translater_gpa, 0, 32); msi.address_hi =3D extract64(s->gits_translater_gpa, 32, 32); - msi.data =3D le32_to_cpu(value); + msi.data =3D value; msi.flags =3D KVM_MSI_VALID_DEVID; msi.devid =3D devid; memset(msi.pad, 0, sizeof(msi.pad)); --=20 2.47.3