From nobody Sun Jan 25 11:57:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1769170999; cv=none; d=zohomail.com; s=zohoarc; b=kvat9KD996sfe1mt1WW+ggodcBmSAs9VdJkpD/30DyeyiRdeXaq9hk63vUXcGTBCnm9hupyXXoHkycQHjQfr760Vv9eTwoqHzTQB29vYcWkFgCxcN8KH+xuDD/mAlhl3C88EgJMM5ff9W6vlpMVpNC5hD8nUfyRUJerMmvxFtQY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769170999; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=zmQ4kVlin0c8KBX0FvJaXZrddy4do6mTePX6ZqOzRJw=; b=MxLZXL0gaVc5X54WUvEnMkfbDmCBpMHH2dCGVPSZF82J3HeqCA4NKZWsqtDWiAGO2HadWqg2j3kWxaEm2XqIHi5PQ1yAx17CntQ1FUA0tZWwC0biNgQCw4q9w1I8zyr9dxygVSVQx+d1Q+Hfwzwg84y1dXAIMN54WLgeLaK6Qj8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1769170999627130.77350439542988; Fri, 23 Jan 2026 04:23:19 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vjGAC-0004wi-C6; Fri, 23 Jan 2026 07:21:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vjGA7-0004rf-B6 for qemu-devel@nongnu.org; Fri, 23 Jan 2026 07:21:15 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vjGA5-0004zx-TI for qemu-devel@nongnu.org; Fri, 23 Jan 2026 07:21:15 -0500 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-279-SVcLalIYOtuC5Vq_RBN9ZQ-1; Fri, 23 Jan 2026 07:21:11 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 812B719775AB for ; Fri, 23 Jan 2026 12:21:10 +0000 (UTC) Received: from localhost.localdomain (unknown [10.72.112.7]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6276230002D1; Fri, 23 Jan 2026 12:21:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769170873; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zmQ4kVlin0c8KBX0FvJaXZrddy4do6mTePX6ZqOzRJw=; b=f0uwKJ/07uu3F0HHdiGzsheV5Wpv+5/BSCJRIyT/ROpzMpw9VzKN3Lq4J2s+8IZFvBm/r+ jwcc06L9wzokrGwo5Ter/+Xmx3MBdR/i4ePEFoNKG2MkIk8vbDGm5ts+Lo/kvhVUBl61WP RH4Qz+I61oPsi6zKuBGDdX+ISkSP+xI= X-MC-Unique: SVcLalIYOtuC5Vq_RBN9ZQ-1 X-Mimecast-MFC-AGG-ID: SVcLalIYOtuC5Vq_RBN9ZQ_1769170870 From: Jason Wang To: qemu-devel@nongnu.org Cc: "Houqi (Nick) Zuo" , Jason Wang Subject: [PULL 01/13] net/tap-linux.c: avoid abort when setting invalid fd Date: Fri, 23 Jan 2026 20:20:50 +0800 Message-ID: <20260123122102.51422-2-jasowang@redhat.com> In-Reply-To: <20260123122102.51422-1-jasowang@redhat.com> References: <20260123122102.51422-1-jasowang@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.079, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1769171003388154100 Content-Type: text/plain; charset="utf-8" From: "Houqi (Nick) Zuo" This patch removes abort() call in the tap_fd_set_vnet_hdr_len() function. If the fd is found to be in a bad state (e.g., EBADFD or ENODEV), the function will print an error message. When QEMU creates a tap device automatically and the tap device is manually removed from the host while the guest is running, the tap device file descriptor becomes invalid. Later, when the guest executes shutdown, the tap_fd_set_vnet_hdr_len() function may be called and abort QEMU with a core dump when attempting to use the invalid fd. The expected behavior for this negative test case is that QEMU should report an error but continue running rather than aborting. Testing: - Start QEMU with automatically created tap device - Manually remove the tap device on the host - Execute shutdown in the guest - Verify QEMU reports an error but does not abort Fixes: 0caed25cd171 ("virtio: Call set_features during reset") Signed-off-by: Houqi (Nick) Zuo Signed-off-by: Jason Wang --- net/tap-linux.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/net/tap-linux.c b/net/tap-linux.c index 909c4f1fcf..54de3cd06b 100644 --- a/net/tap-linux.c +++ b/net/tap-linux.c @@ -214,10 +214,11 @@ bool tap_probe_has_tunnel(int fd) =20 void tap_fd_set_vnet_hdr_len(int fd, int len) { - if (ioctl(fd, TUNSETVNETHDRSZ, &len) =3D=3D -1) { - fprintf(stderr, "TUNSETVNETHDRSZ ioctl() failed: %s. Exiting.\n", - strerror(errno)); - abort(); + int ret; + + ret =3D ioctl(fd, TUNSETVNETHDRSZ, &len); + if (ret !=3D 0) { + error_report("TUNSETVNETHDRSZ ioctl() failed: %s.", strerror(errno= )); } } =20 --=20 2.42.0