From nobody Sun Jan 25 12:00:06 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1769120012; cv=none; d=zohomail.com; s=zohoarc; b=mLMan5HtR7Jq8OYZ/L49y/+LEbnz2x34VNzd9J5FJn929Tae2mJUJ51GelzSoktwk+O3xvyu+OghxBiHbGN6TB1JP5f/hCN4YIkZDK/HbtdHLk/npHPBBnxkH2oT/rGNI2nlnUK8P5/J0MsGD+S+0FltWLejv4RHesgI6nVYrFw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769120012; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=kyIWXld1FWQ8hHXOqbk/6iIga1BTq5Gc5Yz2aOFOv/8=; b=lRHU8LfyyqfjlYJmu1RIp5U7rNefxe3xx10BtRihDX1uKaluN23TErNGlztiUxJVQIIMvEk375Lzgc8s1gdwkuoUdJutAduLJgF9FVplS7w/lLA8hy/limI3p3MBNi+msRb0rWVvLn3jeqZvEIe4BE8m7sChPYeJpULC24QgNx4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1769120012492735.3264033455021; Thu, 22 Jan 2026 14:13:32 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vj2u6-0006WM-Vx; Thu, 22 Jan 2026 17:11:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vj2u3-0006Ug-5u for qemu-devel@nongnu.org; Thu, 22 Jan 2026 17:11:47 -0500 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vj2u1-0003MC-FN for qemu-devel@nongnu.org; Thu, 22 Jan 2026 17:11:46 -0500 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-47d63594f7eso13511225e9.0 for ; Thu, 22 Jan 2026 14:11:45 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4804d84ebb9sm9777315e9.4.2026.01.22.14.11.42 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 22 Jan 2026 14:11:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769119903; x=1769724703; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kyIWXld1FWQ8hHXOqbk/6iIga1BTq5Gc5Yz2aOFOv/8=; b=LapB3KYP56rCbNxMHUaaPeQKvVsYZZrUNZffNtcF8GOaAZotSUDmNBd5NAI6mqUCr1 oT8yCsduZQs3mXGwYrArf1Yi4YwuzyQ3cSt0nidn3iZ3/3aPNipVeZzkSqvL0yFCm3ex KHKgvBqUTQrur4D/mJM/xuTAe0nndJsd5HjX0jguLJ3WmRAAFKCQdHrnWDFzRQts7ryJ PaDn/m8yIYjcv1N/OnjiJnvmgMaHsFxKHl7HK2FShosj/1+2OmyzVWPAEErtJ+oM9pTx t0pjEdFwSigZPdMdLrpAsKRDIDfPutW9MFTjdKjQLq9dQnj+DHAqGUPMEUYxLs75B4O5 Xokw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769119903; x=1769724703; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kyIWXld1FWQ8hHXOqbk/6iIga1BTq5Gc5Yz2aOFOv/8=; b=Wi2r6nmEseiF8CIkmQqyaBHnx8lM3kLwuq+s6HHyCZMClLdHOrG2i3yZtDtuP5FJO5 3K88LW/1ch/h9DLLBaW7V+ApJrFqRBY9+GLpsk1Ymc9VbyFgt2PP0zUjpl/3CSKGmM2+ 7zw+4wRFXvyraMU6mGDvCEeUGK9LmCyc82m5KNBE5UA0Cft+vh4ay57CNSMSmMpevk8m N3DbpIH7lsghyJN0pbPIzqISB/Szs29MtEqPjEY35+guyWMX33nu4ZsAnoHtHZqqM9vI lQKbBUms+O6wP5wdT/OjGTwbkCKJdDagnxGPZRNRJvtGc3yNwAnwJlQne/MuUeTwl4rW T4Qg== X-Gm-Message-State: AOJu0YzC/15mp/fFDiRmleCa4CGz7K8rucj4kYGfGqYd3uSoaLCOtXoS rx11anMA0dSJ+zY8BzCR6WlOFh2xYf/lIsf3zR6Xrb2fhF+vGwrF/qQMy7MtMFz4KIGC2a2Kjck dhtHm2bU= X-Gm-Gg: AZuq6aLweI1+abvgfE6bt4faqrPYPXBwnjP45G/1Hy65dSL2KrgJv41FQ+MgIIYLNVy mwEQWFQ3Cq81eLKJDsTEqpQ+H5Mxuw4sghzYV1Gb6R+QFcGlCPLKyrhSsR21U+d5U1AScbGn6RN tUKpFN1tAvTUz8ATZL3zQokoWjshzQA2/0W/416sBXKxvWJvKOv6+1aHRvnxto+8LBjke3IV+IC EMbodaHehJYcbNHicGXD6G/hP5YE6bU28/I72u174DjjgNlVLQlKNTxcJMKhn7PIem6W1Qda+Ca bN2ugJXY9/VCAbocTJwovqcPhIAQzqWaz1sSZaXp1W0tGtzARfxQeor8Zf6L51z1oA3JnHaI2qw 3YpN/NIvrgpdTqo+7jwqmFgv/eSquib17pCYyuIuN9ANH1Z62LJxAL1u9kKNwW7PQ81T6Rz/pvo F4sAfDz6uC+fbzGNLVVfDLVRFD6xlEowq2O2n/RP88Yr6riqchbYAqPSk2q28megx204RCw3A= X-Received: by 2002:a05:600c:3b0d:b0:477:76cb:4812 with SMTP id 5b1f17b1804b1-4804c8e9508mr16430795e9.0.1769119903562; Thu, 22 Jan 2026 14:11:43 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , Chinmay Rath , Nicholas Piggin , Anton Johansson , Richard Henderson , qemu-ppc@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v5 05/11] target/ppc: Introduce the mo_endian_env() helper Date: Thu, 22 Jan 2026 23:10:59 +0100 Message-ID: <20260122221106.57184-6-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260122221106.57184-1-philmd@linaro.org> References: <20260122221106.57184-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1769120013766158500 Introduce mo_endian_env() which returns the endian MemOp from the vCPU env pointer. Keep it hardcoded as MO_TE. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/ppc/internal.h | 6 ++++++ target/ppc/mem_helper.c | 18 +++++++++--------- target/ppc/tcg-excp_helper.c | 2 +- 3 files changed, 16 insertions(+), 10 deletions(-) diff --git a/target/ppc/internal.h b/target/ppc/internal.h index 58f315ffcf5..09333bed342 100644 --- a/target/ppc/internal.h +++ b/target/ppc/internal.h @@ -19,10 +19,16 @@ #define PPC_INTERNAL_H =20 #include "exec/breakpoint.h" +#include "exec/memop.h" #include "hw/core/registerfields.h" #include "exec/page-protection.h" #include "accel/tcg/tb-cpu-state.h" =20 +static inline MemOp mo_endian_env(const CPUPPCState *env) +{ + return MO_TE; +} + /* PM instructions */ typedef enum { PPC_PM_DOZE, diff --git a/target/ppc/mem_helper.c b/target/ppc/mem_helper.c index 90546967593..89718441310 100644 --- a/target/ppc/mem_helper.c +++ b/target/ppc/mem_helper.c @@ -88,7 +88,7 @@ void helper_lmw(CPUPPCState *env, target_ulong addr, uint= 32_t reg) } } else { /* Slow path -- at least some of the operation requires i/o. */ - MemOp op =3D MO_TE | MO_UL | MO_UNALN; + MemOp op =3D mo_endian_env(env) | MO_UL | MO_UNALN; MemOpIdx oi =3D make_memop_idx(op, mmu_idx); =20 for (; reg < 32; reg++) { @@ -114,7 +114,7 @@ void helper_stmw(CPUPPCState *env, target_ulong addr, u= int32_t reg) } else { /* Slow path -- at least some of the operation requires i/o. */ for (; reg < 32; reg++) { - MemOp op =3D MO_TE | MO_UL | MO_UNALN; + MemOp op =3D mo_endian_env(env) | MO_UL | MO_UNALN; MemOpIdx oi =3D make_memop_idx(op, mmu_idx); =20 cpu_stl_mmu(env, addr, env->gpr[reg], oi, raddr); @@ -158,7 +158,7 @@ static void do_lsw(CPUPPCState *env, target_ulong addr,= uint32_t nb, break; } } else { - MemOp op =3D MO_TE | MO_UL | MO_UNALN; + MemOp op =3D mo_endian_env(env) | MO_UL | MO_UNALN; MemOpIdx oi =3D make_memop_idx(op, mmu_idx); =20 /* Slow path -- at least some of the operation requires i/o. */ @@ -174,12 +174,12 @@ static void do_lsw(CPUPPCState *env, target_ulong add= r, uint32_t nb, val =3D cpu_ldub_mmuidx_ra(env, addr, mmu_idx, raddr) << 24; break; case 2: - op =3D MO_TE | MO_UW | MO_UNALN; + op =3D mo_endian_env(env) | MO_UW | MO_UNALN; oi =3D make_memop_idx(op, mmu_idx); val =3D cpu_ldw_mmu(env, addr, oi, raddr) << 16; break; case 3: - op =3D MO_TE | MO_UW | MO_UNALN; + op =3D mo_endian_env(env) | MO_UW | MO_UNALN; oi =3D make_memop_idx(op, mmu_idx); val =3D cpu_ldw_mmu(env, addr, oi, raddr) << 16; addr =3D addr_add(env, addr, 2); @@ -254,7 +254,7 @@ void helper_stsw(CPUPPCState *env, target_ulong addr, u= int32_t nb, break; } } else { - MemOp op =3D MO_TE | MO_UL | MO_UNALN; + MemOp op =3D mo_endian_env(env) | MO_UL | MO_UNALN; MemOpIdx oi =3D make_memop_idx(op, mmu_idx); =20 for (; nb > 3; nb -=3D 4) { @@ -268,12 +268,12 @@ void helper_stsw(CPUPPCState *env, target_ulong addr,= uint32_t nb, cpu_stb_mmuidx_ra(env, addr, val >> 24, mmu_idx, raddr); break; case 2: - op =3D MO_TE | MO_UW | MO_UNALN; + op =3D mo_endian_env(env) | MO_UW | MO_UNALN; oi =3D make_memop_idx(op, mmu_idx); cpu_stw_mmu(env, addr, val >> 16, oi, raddr); break; case 3: - op =3D MO_TE | MO_UW | MO_UNALN; + op =3D mo_endian_env(env) | MO_UW | MO_UNALN; oi =3D make_memop_idx(op, mmu_idx); cpu_stw_mmu(env, addr, val >> 16, oi, raddr); addr =3D addr_add(env, addr, 2); @@ -304,7 +304,7 @@ static void dcbz_common(CPUPPCState *env, target_ulong = addr, haddr =3D probe_write(env, addr, dcbz_size, mmu_idx, retaddr); if (unlikely(!haddr)) { /* Slow path */ - MemOp op =3D MO_TE | MO_UQ | MO_UNALN; + MemOp op =3D mo_endian_env(env) | MO_UQ | MO_UNALN; MemOpIdx oi =3D make_memop_idx(op, mmu_idx); =20 for (int i =3D 0; i < dcbz_size; i +=3D 8) { diff --git a/target/ppc/tcg-excp_helper.c b/target/ppc/tcg-excp_helper.c index a8c67364669..77d21523a5b 100644 --- a/target/ppc/tcg-excp_helper.c +++ b/target/ppc/tcg-excp_helper.c @@ -161,7 +161,7 @@ static void do_hash(CPUPPCState *env, target_ulong ea, = target_ulong ra, { uint64_t calculated_hash =3D hash_digest(ra, rb, key), loaded_hash; unsigned mmu_idx =3D cpu_mmu_index(env_cpu(env), false); - MemOp op =3D MO_TE | MO_UQ; + MemOp op =3D mo_endian_env(env) | MO_UQ; MemOpIdx oi =3D make_memop_idx(op, mmu_idx); uintptr_t retaddr =3D GETPC(); =20 --=20 2.52.0