From nobody Sun Jan 25 10:15:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1769115737; cv=none; d=zohomail.com; s=zohoarc; b=ehEyw6UC9O3Ild5lxXHj+LBU46Dq3pRWlVyZNGD0v6p7FXyyj+eal8GI/8AvolTkmk0uTGgsBkSD05JmvpWPXhiheOZj8s42wrLdOd+PoaSYkL3OI4JM+aWKOoBklca7IuvwETlszgX2KBGZrh9BjaIGuJC0NB1ltvjo/+9pO1A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769115737; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=f+A1Qhq14Gtk+x2zfD9l4IW7BZOqF5jDpsZKQLHwfu4=; b=OHu2MbEkznhf1cEqtu4J3zmdRK4ete36FR7ui5hHwPAx0iIqG5Gl4LXLxIpPjVgIoEyGTHBaJPPLGrCLejjUUKkX1ZPzavsRAXI5QyDABL9DoVZbn5GowrbnCOzUlC3uOhRLtBSoLjArvfXbjRogE8/ZZIeXWHgSWAbqejuYZfU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17691157374601013.8377424924131; Thu, 22 Jan 2026 13:02:17 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vj1o0-0002o2-6A; Thu, 22 Jan 2026 16:01:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vj1nn-0002aY-7C for qemu-devel@nongnu.org; Thu, 22 Jan 2026 16:01:16 -0500 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vj1nl-0005Dg-75 for qemu-devel@nongnu.org; Thu, 22 Jan 2026 16:01:14 -0500 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-4801bbbdb4aso18232585e9.1 for ; Thu, 22 Jan 2026 13:01:12 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-480470472f1sm101319265e9.7.2026.01.22.13.01.10 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 22 Jan 2026 13:01:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769115671; x=1769720471; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=f+A1Qhq14Gtk+x2zfD9l4IW7BZOqF5jDpsZKQLHwfu4=; b=Ej55rBeVthNWMYmQtH3bdjEU18LqyZXMxJd8X98v4y9VjRQABJG2/B2i3UadYQm/NS Lc3UVf/BWOFBayEuKZsAI9jswYK+i7qeztUCH2+GT2Dq1NGqteTmrYIYZiHmSc7+xReB gs1JkclilK/tgvX2ipLIjKXuqx4ZKTRaScUA6RtO/aounDmT0QpSX3g+0Ggox4BFY/LW O8u/gP3jhk2xfpppFtmSSS1Utzkc0iTYwoANWQ6op8PzphcTVx1VUBQjbXXAHvvw56Fd i//cbMPXjPNlRq7ezAl55FHUjHklc51H3LNS/FBRtpnb5sMOyE02tPli0Xg+qdZUMSUX rhnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769115671; x=1769720471; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=f+A1Qhq14Gtk+x2zfD9l4IW7BZOqF5jDpsZKQLHwfu4=; b=IrnaGmlGAzASA2885IkB2w3UpisV5hMEqrqXa/exxIIr0+pL22cep5PQZ/kWTferAu HnA80rMy13SrIn0qM29Ht23Dpq/cXcB2peKaUK+cf8VQvjcF8En1jrro6gcyfHy315Ew maB0IaYevcJPetFtK+XXR8tBmhQHhgZjnp14XunqilRwRjEb4CMLJ/9jrF64kP9uoGYn 5uBzMzvzII7wouJSXj/wOVjTHV0wYmSC/fNAjt1twqP+PFZDJibET1gmDd5Guc1WgKPW arh7Ty8ShTJvWEBaMzG2wylsLx6t/n6VTP8H62BLoqUhpCnL+NO2MHmBKr9Jyu6TVKcZ r8vA== X-Gm-Message-State: AOJu0Yx6DXywkYKbrWZBD28S0CjkTUQfVE4cO8kVwGgueUXoq6y+qnmS 02hz1BrC0VLkkVkgfLYpCH11DXZg/C7TiPX3R057ONvpeZl30y94dKST9nhOvoj3YJUvm5rf5Aa W+G4aIhQ= X-Gm-Gg: AZuq6aL0BNbO2q4TXRNdfy2ZLI4Kp6pPbwFsesRoOFUhhyxKgQkoIVsIcGkHDiAFJQD MDduo9cfOrsjUP0372aoTNlLZDIatisEbd1n5bdNoStQeWQu3OokafLhBqF0Ffz0IjNksYMD+Zs 5aK3SYiQN6CXv+DWooUfuy+ML/kQtYUcoYkqa8NJJ4CHqzF7GpFJnB3P8HFNbzEObzupqUd8P6B dSiJ98LxGHh2RuH+i7V7nKw6h58c9mDPl3M9OdpHAEuW8LD+TusBeOEDhY0Sq/Tdv16IFgsqT4c Mjp1s6l6UOdM2yofX3EEQnVHgUQxm+I3SHuoiPWIv08EG8c0LnNHo5D/TeM3GA5ZjAJC5fnHE2B PMSzT3EUKmlV5EX8GgsXnQnrakvnKd3pJyq7kQbQcqOeQAJlCdWIrm8vse1ABGCw4w0kaNvz/3l aIHIykWy5mXpGxuoz6Gc+cyeheC64mtqN6hEUmlXX7Tr0AonRchIMS8qqHw7JT X-Received: by 2002:a05:600c:3f12:b0:47e:e981:78b4 with SMTP id 5b1f17b1804b1-4804d2ed089mr11775195e9.12.1769115671182; Thu, 22 Jan 2026 13:01:11 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , Chinmay Rath , Anton Johansson , qemu-ppc@nongnu.org, Nicholas Piggin , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v4 01/11] target/ppc: Inline cpu_ldl_data_ra() calls in ICBI helpers Date: Thu, 22 Jan 2026 22:00:51 +0100 Message-ID: <20260122210101.55358-2-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260122210101.55358-1-philmd@linaro.org> References: <20260122210101.55358-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=philmd@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1769115740220158500 Inline the cpu_ldl_data_ra() call in preparation of removing it. Since the returned value is discarded, don't bother to set the access endianness. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/ppc/mem_helper.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/target/ppc/mem_helper.c b/target/ppc/mem_helper.c index 7318b02c46a..636ad769a93 100644 --- a/target/ppc/mem_helper.c +++ b/target/ppc/mem_helper.c @@ -320,22 +320,27 @@ void helper_dcbzl(CPUPPCState *env, target_ulong addr) =20 void helper_icbi(CPUPPCState *env, target_ulong addr) { + unsigned mmu_idx =3D cpu_mmu_index(env_cpu(env), false); + MemOpIdx oi =3D make_memop_idx(MO_UL | MO_UNALN, mmu_idx); + addr &=3D ~(env->dcache_line_size - 1); /* * Invalidate one cache line : * PowerPC specification says this is to be treated like a load * (not a fetch) by the MMU. To be sure it will be so, - * do the load "by hand". + * do the load "by hand". As the returned data is not consumed, + * endianness is irrelevant. */ - cpu_ldl_data_ra(env, addr, GETPC()); + cpu_ldl_mmu(env, addr, oi, GETPC()); } =20 void helper_icbiep(CPUPPCState *env, target_ulong addr) { #if !defined(CONFIG_USER_ONLY) + MemOpIdx oi =3D make_memop_idx(MO_UL | MO_UNALN, PPC_TLB_EPID_LOAD); /* See comments above */ addr &=3D ~(env->dcache_line_size - 1); - cpu_ldl_mmuidx_ra(env, addr, PPC_TLB_EPID_LOAD, GETPC()); + cpu_ldl_mmu(env, addr, oi, GETPC()); #endif } =20 --=20 2.52.0 From nobody Sun Jan 25 10:15:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1769115866; cv=none; d=zohomail.com; s=zohoarc; b=CTcVznrlDxkv8KZ4eLmgvOW23HFR6F+SZ03/rCqHU5DWLCDmAkYNicPIdZDOEDRLKsdf/+EHNFIcPuIDaeRDuQlySSHS4/WHX4Tg65+ETk5uX0aJ1Gby6XCO3EU/4omChkKcsKrnYr9BOt6vu1ax8y8BiVDH3sIv52V17nyt/+o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769115866; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=+NA0YVCTxMATHJDcDmNQHeNseHnB0KbGS01BN89MceE=; b=M8e+4/sqPvYDUnBwG0WKQkOpfBX0AphmIVhAv6Vt5OdJXpoepAtc+jG+0cEqpSWqnL2q0zibVIWMjWm78dfSuZPBcJlqFi4v/Vs8hfqIssDE2gPidh1kaLmPBV52Bd8wsX5If3/4KirPSXbDk5UYXnBcpek5d5CVfKtl63E4FWo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1769115866565809.7886529039737; Thu, 22 Jan 2026 13:04:26 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vj1oC-0002xg-Nn; Thu, 22 Jan 2026 16:01:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vj1nu-0002hH-2k for qemu-devel@nongnu.org; Thu, 22 Jan 2026 16:01:22 -0500 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vj1nr-0005El-Qz for qemu-devel@nongnu.org; Thu, 22 Jan 2026 16:01:21 -0500 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-480142406b3so10787955e9.1 for ; Thu, 22 Jan 2026 13:01:19 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4804d8c0aebsm7011765e9.15.2026.01.22.13.01.17 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 22 Jan 2026 13:01:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769115678; x=1769720478; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+NA0YVCTxMATHJDcDmNQHeNseHnB0KbGS01BN89MceE=; b=ZwKbwLd2oXQn6zTLewYTXgO07aEIdfFGvXkf8gLq+4kyfrtDI+LFeztCcuQ1tWI0/S 1vfBdYRXQQObLkPAGA4xs218x9DSULEMmg5ITYY+W0vxynPm29oRyeFMj0GpRZZ1jsqZ uwW3yguQxtS1pE4x9q9086qLtOkAQHj7K0tNzqKVEt3DRRVBcnY3AmPic1WIFWXi+9dA bE1jN6UrAjBu0KxJ6TljCMnBpP0ugZ2+N2JLsW2BhLC7LXXMeSynIVXhmJuGNwTGmlZc 4W6kbbZBtmd3lLvg5HcWXIapr75ahQlzPYhICVR7BPQVlnvCjnZLk2HD5QzFYJpuVnYd wBTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769115678; x=1769720478; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+NA0YVCTxMATHJDcDmNQHeNseHnB0KbGS01BN89MceE=; b=BEmwslHQLJ5uz79X8ZcUufBuqGqLbaC8V/y5WuOGiU3tzrFzyjIAFknEENVcfsj4vE s09zsOR+cSm+VuHpK4dQJlq4sqiGhVBeYPcOxwKtDMEjQPzuR9SIAriwk7et1vJyu0dR csYNBkEoDnZWXQZUHa45y/pDflDc7wNtoJXZdF4mgb/7djajyFlNEAVdW+BYdvo7xXEw xfG3tqs3gH+e1CjsSpHfeCdRUMZPZ9nGahDjJZIslqirmszxkOAGhsydHPIMMwM5xWvC ranXvZffQIpztVwiCPoEWtgQCYUKVEAUjZvR9cV93gY4sM9BUyvrY9ZPecIuiyhHD/V1 pCGg== X-Gm-Message-State: AOJu0YwL9euXjbEZtvD6uLAFEayHxK8ypGoNt8V6tqk6F8kBgeLIACY1 kwv7aRU/qpjxDyg9LiNMwhB/kkZRLw22f3nM4ku0G0iltoAShc6fK++6+tOsPIqVkr3Som1xakV 5HL6VNiQ= X-Gm-Gg: AZuq6aI6GNqJ6PoAH1ote9MctQ1BAtas1o7J3ilcaQu7WB0MqdEUq/+0P2UQKmBGlbe 0aKdrborZrd2mp1LgHhHwk8IYZZoBAoKVU7I8xl5brb0tPiUslRZxlnxJPaE8tprfH+AKQj38+F J4vKT/VxNplvF2uhEr35W6TFLZI2GSQjb4OZaO+wlfuWbvP++ZPIin1ki6DEt0zgA5BhpaYff3G BlFJHWI2oIQZpr0BZC2PPt+U83TZJwxZDVWKuaRi7ZBxiYlhl3sOIQ9nvzaeAfAnsHkABGitU9N 1VgP8a/BYqX9w6u1md14ZOSRdXK8HVVS6X1HZIChasvTkdC4qnxs7HQ5BiIPPNGc+50yi+vZu/L prELdOjWpWWs2h7DlCrIm2YHpZQyofC5LX90SUR/HBs1DqkPtvl4Rdv2KoP1cWNP+f1jTu25xcq u6c2BAjV64jDHs7wMpGYMtOPSQilofJFwlhYcPyFCRnqUhp3krJkQAz95c1FsT X-Received: by 2002:a05:600c:c08c:b0:480:4d37:e742 with SMTP id 5b1f17b1804b1-4804d37e85bmr7805665e9.10.1769115678045; Thu, 22 Jan 2026 13:01:18 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , Chinmay Rath , Anton Johansson , qemu-ppc@nongnu.org, Nicholas Piggin , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v4 02/11] target/ppc: Inline cpu_ld/st_mmuidx_ra() calls in memory helpers Date: Thu, 22 Jan 2026 22:00:52 +0100 Message-ID: <20260122210101.55358-3-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260122210101.55358-1-philmd@linaro.org> References: <20260122210101.55358-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1769115868298158500 In preparation of removing the cpu_ld*_mmuidx_ra() and cpu_st*_mmuidx_ra() calls, inline them. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/ppc/mem_helper.c | 37 ++++++++++++++++++++++++++++--------- 1 file changed, 28 insertions(+), 9 deletions(-) diff --git a/target/ppc/mem_helper.c b/target/ppc/mem_helper.c index 636ad769a93..cf8f1fa9c1e 100644 --- a/target/ppc/mem_helper.c +++ b/target/ppc/mem_helper.c @@ -88,8 +88,11 @@ void helper_lmw(CPUPPCState *env, target_ulong addr, uin= t32_t reg) } } else { /* Slow path -- at least some of the operation requires i/o. */ + MemOp op =3D MO_TE | MO_UL | MO_UNALN; + MemOpIdx oi =3D make_memop_idx(op, mmu_idx); + for (; reg < 32; reg++) { - env->gpr[reg] =3D cpu_ldl_mmuidx_ra(env, addr, mmu_idx, raddr); + env->gpr[reg] =3D cpu_ldl_mmu(env, addr, oi, raddr); addr =3D addr_add(env, addr, 4); } } @@ -111,7 +114,10 @@ void helper_stmw(CPUPPCState *env, target_ulong addr, = uint32_t reg) } else { /* Slow path -- at least some of the operation requires i/o. */ for (; reg < 32; reg++) { - cpu_stl_mmuidx_ra(env, addr, env->gpr[reg], mmu_idx, raddr); + MemOp op =3D MO_TE | MO_UL | MO_UNALN; + MemOpIdx oi =3D make_memop_idx(op, mmu_idx); + + cpu_stl_mmu(env, addr, env->gpr[reg], oi, raddr); addr =3D addr_add(env, addr, 4); } } @@ -152,9 +158,12 @@ static void do_lsw(CPUPPCState *env, target_ulong addr= , uint32_t nb, break; } } else { + MemOp op =3D MO_TE | MO_UL | MO_UNALN; + MemOpIdx oi =3D make_memop_idx(op, mmu_idx); + /* Slow path -- at least some of the operation requires i/o. */ for (; nb > 3; nb -=3D 4) { - env->gpr[reg] =3D cpu_ldl_mmuidx_ra(env, addr, mmu_idx, raddr); + env->gpr[reg] =3D cpu_ldl_mmu(env, addr, oi, raddr); reg =3D (reg + 1) % 32; addr =3D addr_add(env, addr, 4); } @@ -165,10 +174,12 @@ static void do_lsw(CPUPPCState *env, target_ulong add= r, uint32_t nb, val =3D cpu_ldub_mmuidx_ra(env, addr, mmu_idx, raddr) << 24; break; case 2: - val =3D cpu_lduw_mmuidx_ra(env, addr, mmu_idx, raddr) << 16; + oi =3D make_memop_idx(MO_TE | MO_UW | MO_UNALN, mmu_idx); + val =3D cpu_ldw_mmu(env, addr, oi, raddr) << 16; break; case 3: - val =3D cpu_lduw_mmuidx_ra(env, addr, mmu_idx, raddr) << 16; + oi =3D make_memop_idx(MO_TE | MO_UW | MO_UNALN, mmu_idx); + val =3D cpu_ldw_mmu(env, addr, oi, raddr) << 16; addr =3D addr_add(env, addr, 2); val |=3D cpu_ldub_mmuidx_ra(env, addr, mmu_idx, raddr) << 8; break; @@ -241,8 +252,11 @@ void helper_stsw(CPUPPCState *env, target_ulong addr, = uint32_t nb, break; } } else { + MemOp op =3D MO_TE | MO_UL | MO_UNALN; + MemOpIdx oi =3D make_memop_idx(op, mmu_idx); + for (; nb > 3; nb -=3D 4) { - cpu_stl_mmuidx_ra(env, addr, env->gpr[reg], mmu_idx, raddr); + cpu_stl_mmu(env, addr, env->gpr[reg], oi, raddr); reg =3D (reg + 1) % 32; addr =3D addr_add(env, addr, 4); } @@ -252,10 +266,12 @@ void helper_stsw(CPUPPCState *env, target_ulong addr,= uint32_t nb, cpu_stb_mmuidx_ra(env, addr, val >> 24, mmu_idx, raddr); break; case 2: - cpu_stw_mmuidx_ra(env, addr, val >> 16, mmu_idx, raddr); + oi =3D make_memop_idx(MO_TE | MO_UW | MO_UNALN, mmu_idx); + cpu_stw_mmu(env, addr, val >> 16, oi, raddr); break; case 3: - cpu_stw_mmuidx_ra(env, addr, val >> 16, mmu_idx, raddr); + oi =3D make_memop_idx(MO_TE | MO_UW | MO_UNALN, mmu_idx); + cpu_stw_mmu(env, addr, val >> 16, oi, raddr); addr =3D addr_add(env, addr, 2); cpu_stb_mmuidx_ra(env, addr, val >> 8, mmu_idx, raddr); break; @@ -284,8 +300,11 @@ static void dcbz_common(CPUPPCState *env, target_ulong= addr, haddr =3D probe_write(env, addr, dcbz_size, mmu_idx, retaddr); if (unlikely(!haddr)) { /* Slow path */ + MemOp op =3D MO_TE | MO_UQ | MO_UNALN; + MemOpIdx oi =3D make_memop_idx(op, mmu_idx); + for (int i =3D 0; i < dcbz_size; i +=3D 8) { - cpu_stq_mmuidx_ra(env, addr + i, 0, mmu_idx, retaddr); + cpu_stq_mmu(env, addr + i, 0, oi, retaddr); } return; } --=20 2.52.0 From nobody Sun Jan 25 10:15:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1769115751; cv=none; d=zohomail.com; s=zohoarc; b=Cx50CvddSJjtUJhFzbWM2YoXOqJj2LZCnmE78diqE3DxIpyUI/OJ6Wh+kmvkEFx1rKorhoeiqznPzC95Edel/zwDTTYG7QqVgssGFIKgMRs3JAVIZMpJsD8noZ5B1iENCVRDlJQ+FQg1FbHytz1Fnt2MKql4kVHrRJsAQkKiM4c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769115751; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=tJ5PETmEZLmm3Y1gSNdqj1xhiHNr34HOHNL2IBd92JM=; b=DTBOPy3Ll5JgjUHD3YNd7hBpS+9vm8wR5pYqSA9Gxe+R7FfIxx/+CzzQMc51Br+EzGj6mBI8xbXBNEd48mm+/9nEYccX01jWYzhZeo9HgUFxzjpiDNX+Kyd3NxvtYihcuFsvidq8ww16Ej4WlpqbzkNbuULGmdmh5N1ussJ8vSE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1769115751297276.3305461032935; Thu, 22 Jan 2026 13:02:31 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vj1oD-0002yf-95; Thu, 22 Jan 2026 16:01:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vj1o0-0002pb-KY for qemu-devel@nongnu.org; Thu, 22 Jan 2026 16:01:39 -0500 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vj1nz-0005Fb-6R for qemu-devel@nongnu.org; Thu, 22 Jan 2026 16:01:28 -0500 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-47ee937ecf2so13195565e9.0 for ; Thu, 22 Jan 2026 13:01:26 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-480470bfe42sm89260495e9.9.2026.01.22.13.01.23 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 22 Jan 2026 13:01:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769115685; x=1769720485; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tJ5PETmEZLmm3Y1gSNdqj1xhiHNr34HOHNL2IBd92JM=; b=HO60b6GKvPmzaQ41ZGd1kqVBytquOsuRUlkM6FSenK8KGHzuacLWl00tYNW+VVRWlB h4h5eEAtrJJlnJP/0V5HmLPJm1chsIL344ApI96LzU4XLAR3OjPp3OY/Fc3XVbCKGM6J NaO+eUKnfZOLv65Zlo+FsOY6CZXXx/+kZY+Qy10r8B8ySLbBaddgcKa6FqTw0Mp54521 opoBrhLVk4cgJeJlRML9kP1+sK0auIrHSwRziz1GdLEkBHD/GR79i4L+vkjseu2rGolY 9bX3p5k5Qu6xX8nFnfbdNCK51F6tsgS3KgfyCiYy7t30qzmuzPRS1DgBEVvuuiKdUWAd +DAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769115685; x=1769720485; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=tJ5PETmEZLmm3Y1gSNdqj1xhiHNr34HOHNL2IBd92JM=; b=GoLluTHsbWeXG1gRWxkTly1L0aGG6R0ZnjkKFpG4TkBFIFXJkIsxX4nEAZKNifw/92 rKuJPcwuSIaXTkS5GBztgoM49JPy/IWgQmiCDsVUEyVtjdjhQFIbeoLBbUfzbGLcc1RB CBWAKU/8ux26TYiwuAGWqxEw36N0v0tumvKBQOvc8KJ33Vr6GY49wYlTalRfHNNUH3I7 4zP8JxlwmG6CCM+SuBp2uhcCTsEyeo32v9FnmARrYl7TrUHX0lCznjfbfq4WZeudWkbL Z6Aoqqi41L5bRNymAd7n1lIwgfvMWFJCacmKBXPXWDGzgWUtgga7Xvwm8sR+MgzaiITx 5m5A== X-Gm-Message-State: AOJu0YwiRERalE9wfUmQkwskN3cHf4WEtX5+sQdIuJYiGjmRCbSjPLPf lUwF7hKqQ87f/0a5UgNJpi5ArFzw7zWSg8R3oJSFG0Wdseax9y0z4GzPF01gGZZLvH5lFDwYH5A esA/yEWA= X-Gm-Gg: AZuq6aLJ4qH9I4DGuK7a1KAwkasm7kUZfDw5BwtOapeM0CDgBMzCGOQLXEmIl2qy26Z m7MQ/AYqk+fRict8AMmY45+2hyPqzO9QmLxVbANAe5j0RNK29t3mcAnYvAdtzeS9slxzQnNxkl7 hn/ox+aqKtS5yHyav2EcR56v/MerFMM+G3guokg+FDnyT64lenhQwt1/YV3DPbfdR0m2NM9GSzV wIShPKUvKnSb3P7BSXOsOYPI85iJEnbF/mn2QVmfKHmP3DVQCBYXhDW+YnEttlxrdVyJwL/EfWR S4DEY1jQBybyqML7k7Edvh3JuBaa9eYZslA3jtqWsTxwreypz89aCaZg7K/2DiglGHT8foINDaU dDNSCwWo75u00y/Tvc6rTe9TyGLjf04wWFAjVsrOTjnY67uajtKwnXtHAdj8tRrrvxVZQwvPHmf FU8ue4HDW+3qfKALCIAYFTjxVWM4UpUKB8fHsZnBQBbZO6fD6vLm2nXAsexGH0 X-Received: by 2002:a05:600c:3e0e:b0:46f:a2ba:581f with SMTP id 5b1f17b1804b1-4804d307b0cmr11534505e9.16.1769115684917; Thu, 22 Jan 2026 13:01:24 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , Chinmay Rath , Anton Johansson , qemu-ppc@nongnu.org, Nicholas Piggin , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v4 03/11] target/ppc: Inline cpu_ld/st_data_ra() calls in do_hash() Date: Thu, 22 Jan 2026 22:00:53 +0100 Message-ID: <20260122210101.55358-4-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260122210101.55358-1-philmd@linaro.org> References: <20260122210101.55358-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1769115754229154100 In preparation of removing the cpu_ld*_data_ra() and cpu_st*_data_ra() calls, inline them. No logical change intended. We note the page translation hash address is expected to be aligned, so the MO_UNALN flag is misleading. Next commit will remove it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/ppc/tcg-excp_helper.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/target/ppc/tcg-excp_helper.c b/target/ppc/tcg-excp_helper.c index edecfb85725..6f5d82af636 100644 --- a/target/ppc/tcg-excp_helper.c +++ b/target/ppc/tcg-excp_helper.c @@ -160,14 +160,18 @@ static void do_hash(CPUPPCState *env, target_ulong ea= , target_ulong ra, target_ulong rb, uint64_t key, bool store) { uint64_t calculated_hash =3D hash_digest(ra, rb, key), loaded_hash; + unsigned mmu_idx =3D cpu_mmu_index(env_cpu(env), false); + MemOp op =3D MO_TE | MO_UQ | MO_UNALN; + MemOpIdx oi =3D make_memop_idx(op, mmu_idx); + uintptr_t retaddr =3D GETPC(); =20 if (store) { - cpu_stq_data_ra(env, ea, calculated_hash, GETPC()); + cpu_stq_mmu(env, ea, calculated_hash, oi, retaddr); } else { - loaded_hash =3D cpu_ldq_data_ra(env, ea, GETPC()); + loaded_hash =3D cpu_ldq_mmu(env, ea, oi, retaddr); if (loaded_hash !=3D calculated_hash) { raise_exception_err_ra(env, POWERPC_EXCP_PROGRAM, - POWERPC_EXCP_TRAP, GETPC()); + POWERPC_EXCP_TRAP, retaddr); } } } --=20 2.52.0 From nobody Sun Jan 25 10:15:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1769115869; cv=none; d=zohomail.com; s=zohoarc; b=dSVrR1CNiNOlIQhOpMGZZ0dNA88wi99ou3Mp/o/nAMj/qd/LyIP2gOaBkEha2qupt9H8qGFksLi32HnPv6VFXyoCEgMgzpNCeePROz/XP95PViI6Agf2HxyirhtFbMvizgi7Wa85prwaNLPfp9sloiEK1TvlS2ddBUJugtgfY6E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769115869; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=xwyaty6/9Dku7w0or7x9Z1FwEL5g3XwXIWEi/fxrfjo=; b=cEkwuXjnTJBQi+aez78WfwB3dJAApa72ud6AlyT3xXxXjgmzPPvNHRByctBcpTOvIRkrTf0jim9bqI7+ijplmuWysLsRzKgYtLfv/jWa0UuV08CZg762yUv8R7nqUOQlJU2teDyBmh91teMcCpoIDkOKNiGCiU4USV0xIr+yLOk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17691158693051017.7996020631714; Thu, 22 Jan 2026 13:04:29 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vj1oE-0002zK-8q; Thu, 22 Jan 2026 16:01:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vj1o8-0002st-4F for qemu-devel@nongnu.org; Thu, 22 Jan 2026 16:01:39 -0500 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vj1o5-0005GY-LE for qemu-devel@nongnu.org; Thu, 22 Jan 2026 16:01:34 -0500 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-4801bc32725so11780795e9.0 for ; Thu, 22 Jan 2026 13:01:33 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4804d85cff5sm8596855e9.7.2026.01.22.13.01.30 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 22 Jan 2026 13:01:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769115692; x=1769720492; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xwyaty6/9Dku7w0or7x9Z1FwEL5g3XwXIWEi/fxrfjo=; b=YiH8u4lwZL1Ho+ELvZ0F+z/P1AgxsBez4WWBx+0pBiK2kj3UCjyKO0OAEMJ9AJUZHl 6fvBJkJj+hbR5h++2Xn86bGD+Ed6cFvHFM7mEjf2PtcojNpCjWJBOtSMv9+6y4cM8ZTW 9K8YcUOtIDu+PWx/mWQ8IlT2gICsCMZAKEPqRHFF73gfhbjvd0M+X7V2rH5SNtcgWfF7 9EKFO2WoafmkGyxfPxMdZNHRRzH4PK5lq/DUkztpPfWZtXmnNeR43SX72YRXiz0AQI+7 Fj0pSWUyh+KLwYWCdLQBlXUijQsgV5Eok5JATJEyp+j6Y1NpxgsWmz3bxtmOMMNGO416 TNxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769115692; x=1769720492; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xwyaty6/9Dku7w0or7x9Z1FwEL5g3XwXIWEi/fxrfjo=; b=XttjSUgYkOsFGUpgrtOmCpmgR7SGcjDcwrMVV6uHGTr+ozqigT+yENW9VbQRT9qS6+ U4YWU/Sa86OdavnyyqyFfltwBdFZ4yipAGLbiGMcklHY1i1tXWseA8kYmyj2SmveWVqt PoW7vhlypZnuf7M1vEK8utGcmDXB8aiPYU6M9D5CrnaR9RxX6QQVR5CHAX164P6msemP UMk91nH49X0X9DEewP8enMZ1d6QzRWGPNhkG2ShufVHiekF0SBZi2aMWxPZCdMnR1URr l3ZLQlFlhNj+RGtEV/pra9Fwd0LQk+WBiwx/wLCT1rB8axLnWpu3okXZ+0YPTVtiMCXw aTZg== X-Gm-Message-State: AOJu0YwfmfWIGBRRF8T6WvX2bsK6KuS7+5D1wD0/gGqRLBfu16gkDm0r cUDbEJIQnMMhnYX5qb4PjMuvPIkoGuRIUJCHcmGcZQFTHxp+P2zRpgNAVVX8q/NWHBMc5sNUQAY q6Y5ifNQ= X-Gm-Gg: AZuq6aLTrWN2Cn1mDHBJzFPWvGCtVSZp4J1ZPHHZYAXBZKsnysFeUaCMs0w6m8hQ9li lXtshAdmw3NVQlmNg2ZyKtgT+Mr3ro0AhiW46kBZ78PXbl8Jr106jhWAoRjTb3ggB+w4Kg4n3M3 IVsxzuO4rLXd9V6BoPOBew9F+mVO4aDfiT155Y8angOhFIWbchUIZh+yGWU9pfUWlu+xtrjqDCx Y2YzesUbxkTd2W87pLttwwvgv/MuToDuvAdPWqVnbQ01ue7DjlgvmXRdA3xt4IMLIPJy3emtuxs PvsJIEdTCHegKaBTxXEY0Sbktm+Va2qftTV0aAKbyMnyCJFA64GlrNmXsJleAsqexzMupKEuXzf F36KmNplj6282vf30g20NzhE/7ioIT1bdpycPZ57hdoDqs02obmqI8Kf9ynMYQCKQLmLxT5hKAe E2OA7MXZq74peaR8SaTg4shSaN5RB25qmMmAMaT3lVgjSv89ULVax3bsqLX9b6Dhqkt8CoZ/c= X-Received: by 2002:a05:600c:37c8:b0:47e:e20e:bbb7 with SMTP id 5b1f17b1804b1-4804c9bbfc1mr16297905e9.25.1769115691744; Thu, 22 Jan 2026 13:01:31 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , Chinmay Rath , Anton Johansson , qemu-ppc@nongnu.org, Nicholas Piggin , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v4 04/11] target/ppc: Expect page translation hash addresses to be aligned Date: Thu, 22 Jan 2026 22:00:54 +0100 Message-ID: <20260122210101.55358-5-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260122210101.55358-1-philmd@linaro.org> References: <20260122210101.55358-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=philmd@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1769115871771154100 The page translation hash addresses are aligned: remove the misleading MO_UNALN flag. Reported-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/ppc/tcg-excp_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/ppc/tcg-excp_helper.c b/target/ppc/tcg-excp_helper.c index 6f5d82af636..a8c67364669 100644 --- a/target/ppc/tcg-excp_helper.c +++ b/target/ppc/tcg-excp_helper.c @@ -161,7 +161,7 @@ static void do_hash(CPUPPCState *env, target_ulong ea, = target_ulong ra, { uint64_t calculated_hash =3D hash_digest(ra, rb, key), loaded_hash; unsigned mmu_idx =3D cpu_mmu_index(env_cpu(env), false); - MemOp op =3D MO_TE | MO_UQ | MO_UNALN; + MemOp op =3D MO_TE | MO_UQ; MemOpIdx oi =3D make_memop_idx(op, mmu_idx); uintptr_t retaddr =3D GETPC(); =20 --=20 2.52.0 From nobody Sun Jan 25 10:15:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1769115735; cv=none; d=zohomail.com; s=zohoarc; b=TcRLEh3FyTaT3FWxh69gQDcbt4Gm915T8ZD9hjTjizmIDRtJ2nFVTlgHM7sH6sLsJulTmDGyTrwpGbHuA5KdHoakOpe8PUZfOKp6uM5UIv0KZEJcVWHg/FU4N22ZB0nMcw5KAgIdIJAMCLh/mS4yZGqL8R9edTu+DBfQJhl11mw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769115735; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=43ixM+aKuIksflZPIqnhd7zfLTeR5wkYWXfnKtaWNkY=; b=P+p0/G01smAxx02coc1BoRfCnJQ2jGi9hpc5kLZZHJot8RHQf9R7nLV0cs6Zd753BI6t/xtW4Qfb/u+GFHqdnBHBHCkPcSNKFIrQ2blxiDNCN2DlDP+6EQWcPkpDaZBrvbxh2EdLLlGdS8Mhv4HAtG2iTaCBAylMZt8urlIhbWo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1769115735718906.7696840273577; Thu, 22 Jan 2026 13:02:15 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vj1oH-00034R-6E; Thu, 22 Jan 2026 16:01:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vj1oE-0002zV-3A for qemu-devel@nongnu.org; Thu, 22 Jan 2026 16:01:42 -0500 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vj1oC-0005HP-EV for qemu-devel@nongnu.org; Thu, 22 Jan 2026 16:01:41 -0500 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-42fb2314eb0so1361919f8f.2 for ; Thu, 22 Jan 2026 13:01:40 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435b1c24ac1sm1324206f8f.14.2026.01.22.13.01.37 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 22 Jan 2026 13:01:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769115699; x=1769720499; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=43ixM+aKuIksflZPIqnhd7zfLTeR5wkYWXfnKtaWNkY=; b=ButbmFvg8kFhkaA+51zMW8AkExRqUmVzLvMoxermfzMa6WvmLzSPp5cKihtPbkK3Gb iBrJh5lL05u5PgnBHDaAU9aiCn6Wy7Pm/rdNO+RSn0m9Dcmuzfoona0xhvZ5aMV6IM5R ChUgvmQbVwTM43Wm6FeM6PbDQZgSq1vTadcgYe0BbUuV/CpJA1zpAA/PnLsJU/OAZ3kK 9vHEyLxI7x8jCIIh24bq01dTMe2o7u+v18I551kN+1md/LvifK1xSMOEv4IEdpcpXlZq hKpRGKUIXUNIU40M7tthQQ9lBosGNj/OYdEMCfh1USD2Ee1TYJEn1FvxhcvNfUUJyGjh 7wBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769115699; x=1769720499; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=43ixM+aKuIksflZPIqnhd7zfLTeR5wkYWXfnKtaWNkY=; b=NLjcPWlCMrx2UMJBW/3MPSz8Ma3l2vM0mC2Au+RRYO3YXuaoAV9Y5rhgABrjhZEj6O 5fAavsoXPDO1WOuac4Qf3JUppQzfielXvlO/YQ48Oc6/3zWOroCjTc3IS080YQjO/WMw D4vCHef9DlYLxjMxzaOIC4rEeFutO7DihUKyp3tJD6SX4WU46QqcmkQEh1nBzWZEwl6k zjEV9v9+WQw16SsAmhAUU5OJLY1zCMffcSanhewKzWb8EM12MQTwyK0MEblPCUQCdvyy 9KbHKEee5Hjtkju/U0eT8V1K0YsBIsfvG1R+9N3jSPR5RfDWRXnQhsZIja13tbm0XQIN mPDQ== X-Gm-Message-State: AOJu0YxtTxtKpyYVtuEY4DGP/VfkEoMdaCVyxOU2q45Lki49TS+vafwr A03RJWb/yQ9AWrqOOdoxrSEIyfe7OewmvDaBD/yBvNaPL3kCcdB8nSQjCwZJZjHmzgk5jeNvNXN YtIVmaq4= X-Gm-Gg: AZuq6aJ+8EeCWdNEwcUP+oWVRq1y0arhKhIzVfFqSNJk0YFS+I9N2au3zEDeFKln4Vn 28yB1AvhwkD3v4gI6aXbr7PsleJQ4BN9uTNKtkI6k+ULOUOQFTmykiQJG82ZyOr+PSLGiztnxY/ 1zczS29o40kT3xIL8DXMo32vc9yPe2JrEsoEBBqBp90IMliqbAT8x/0NmqZjj0b1Q+alEnOc20y dYsRhBACkAn1NnXKdxV9rEOvHJxNqCZnAOCi0XeeOYluMNmLikDM2bmO8yZ/WntBIdHjjxaj/0o 61v/fGBz7YC3bPlyMv223+ZWmmSJrQpEXzTIXzMk5immfcnxBYF+U9rk4Hy+KDoZO4MHZXYb4xq zMMv6bi3ClrmAq4ZPtGPfEeCNqVw+ZIKmkTbYi4xT1qDiSm2/tyy10ZWab053E3rHCZDNRTefBD JOwjRh1JyEmCseczcw5HfZalfqiQFcRMkqjJrK6JwlU6cz/8jlH/oJ631JTs85 X-Received: by 2002:a05:6000:2c01:b0:430:f454:84ae with SMTP id ffacd0b85a97d-435b161d1famr1333446f8f.63.1769115698541; Thu, 22 Jan 2026 13:01:38 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , Chinmay Rath , Anton Johansson , qemu-ppc@nongnu.org, Nicholas Piggin , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v4 05/11] target/ppc: Introduce the mo_endian_env() helper Date: Thu, 22 Jan 2026 22:00:55 +0100 Message-ID: <20260122210101.55358-6-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260122210101.55358-1-philmd@linaro.org> References: <20260122210101.55358-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=philmd@linaro.org; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1769115738484154100 Introduce mo_endian_env() which returns the endian MemOp from the vCPU env pointer. Keep it hardcoded as MO_TE. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/ppc/internal.h | 6 ++++++ target/ppc/mem_helper.c | 10 +++++----- target/ppc/tcg-excp_helper.c | 2 +- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/target/ppc/internal.h b/target/ppc/internal.h index 58f315ffcf5..09333bed342 100644 --- a/target/ppc/internal.h +++ b/target/ppc/internal.h @@ -19,10 +19,16 @@ #define PPC_INTERNAL_H =20 #include "exec/breakpoint.h" +#include "exec/memop.h" #include "hw/core/registerfields.h" #include "exec/page-protection.h" #include "accel/tcg/tb-cpu-state.h" =20 +static inline MemOp mo_endian_env(const CPUPPCState *env) +{ + return MO_TE; +} + /* PM instructions */ typedef enum { PPC_PM_DOZE, diff --git a/target/ppc/mem_helper.c b/target/ppc/mem_helper.c index cf8f1fa9c1e..3c91d641f9a 100644 --- a/target/ppc/mem_helper.c +++ b/target/ppc/mem_helper.c @@ -88,7 +88,7 @@ void helper_lmw(CPUPPCState *env, target_ulong addr, uint= 32_t reg) } } else { /* Slow path -- at least some of the operation requires i/o. */ - MemOp op =3D MO_TE | MO_UL | MO_UNALN; + MemOp op =3D mo_endian_env(env) | MO_UL | MO_UNALN; MemOpIdx oi =3D make_memop_idx(op, mmu_idx); =20 for (; reg < 32; reg++) { @@ -114,7 +114,7 @@ void helper_stmw(CPUPPCState *env, target_ulong addr, u= int32_t reg) } else { /* Slow path -- at least some of the operation requires i/o. */ for (; reg < 32; reg++) { - MemOp op =3D MO_TE | MO_UL | MO_UNALN; + MemOp op =3D mo_endian_env(env) | MO_UL | MO_UNALN; MemOpIdx oi =3D make_memop_idx(op, mmu_idx); =20 cpu_stl_mmu(env, addr, env->gpr[reg], oi, raddr); @@ -158,7 +158,7 @@ static void do_lsw(CPUPPCState *env, target_ulong addr,= uint32_t nb, break; } } else { - MemOp op =3D MO_TE | MO_UL | MO_UNALN; + MemOp op =3D mo_endian_env(env) | MO_UL | MO_UNALN; MemOpIdx oi =3D make_memop_idx(op, mmu_idx); =20 /* Slow path -- at least some of the operation requires i/o. */ @@ -252,7 +252,7 @@ void helper_stsw(CPUPPCState *env, target_ulong addr, u= int32_t nb, break; } } else { - MemOp op =3D MO_TE | MO_UL | MO_UNALN; + MemOp op =3D mo_endian_env(env) | MO_UL | MO_UNALN; MemOpIdx oi =3D make_memop_idx(op, mmu_idx); =20 for (; nb > 3; nb -=3D 4) { @@ -300,7 +300,7 @@ static void dcbz_common(CPUPPCState *env, target_ulong = addr, haddr =3D probe_write(env, addr, dcbz_size, mmu_idx, retaddr); if (unlikely(!haddr)) { /* Slow path */ - MemOp op =3D MO_TE | MO_UQ | MO_UNALN; + MemOp op =3D mo_endian_env(env) | MO_UQ | MO_UNALN; MemOpIdx oi =3D make_memop_idx(op, mmu_idx); =20 for (int i =3D 0; i < dcbz_size; i +=3D 8) { diff --git a/target/ppc/tcg-excp_helper.c b/target/ppc/tcg-excp_helper.c index a8c67364669..77d21523a5b 100644 --- a/target/ppc/tcg-excp_helper.c +++ b/target/ppc/tcg-excp_helper.c @@ -161,7 +161,7 @@ static void do_hash(CPUPPCState *env, target_ulong ea, = target_ulong ra, { uint64_t calculated_hash =3D hash_digest(ra, rb, key), loaded_hash; unsigned mmu_idx =3D cpu_mmu_index(env_cpu(env), false); - MemOp op =3D MO_TE | MO_UQ; + MemOp op =3D mo_endian_env(env) | MO_UQ; MemOpIdx oi =3D make_memop_idx(op, mmu_idx); uintptr_t retaddr =3D GETPC(); =20 --=20 2.52.0 From nobody Sun Jan 25 10:15:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1769115735; cv=none; d=zohomail.com; s=zohoarc; b=TnGDzg9yS+kuT5zMHb+RV/YiOMFTKFCRdI0oONNiPnj4vKWtCWomGV6R8Ea20LZXM7+8ibF0DZx9Ihs9q2CPJegwav2mWiUyBJ0sxRbcKtQYnnHzVpMhcVA5N+Zc+KXne6D6a1BOv3Fy5d6Hi1vK6Ekicznobge4k5cDIEmJqjs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769115735; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=RP/MTK8KNSVzyu6zuIe3MwXkpcWMuvGz5r3wnr6DkDY=; b=ZGSzlCro8nj9FXgmlpVZqDzlD1LOPNDebBpwBAz+w5b4cHDN7rAy2N7Ct0EKpE1vCujeCczzFe2JkZDoTf1jPvmKEHPuedPKmSfayt7LJLezzZ/i0lbAq67xd/9BY3NBJ8dCCfbhtrS+1Arvve+Tw/QKXRYKktUfJqI5Yh9Kgsw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1769115735674122.06071773848146; Thu, 22 Jan 2026 13:02:15 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vj1oN-0003Ag-4N; Thu, 22 Jan 2026 16:01:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vj1oK-00037v-FZ for qemu-devel@nongnu.org; Thu, 22 Jan 2026 16:01:49 -0500 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vj1oJ-0005I8-5c for qemu-devel@nongnu.org; Thu, 22 Jan 2026 16:01:48 -0500 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-47f5c2283b6so10650165e9.1 for ; Thu, 22 Jan 2026 13:01:46 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435b1f7c9cesm1309415f8f.41.2026.01.22.13.01.44 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 22 Jan 2026 13:01:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769115705; x=1769720505; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RP/MTK8KNSVzyu6zuIe3MwXkpcWMuvGz5r3wnr6DkDY=; b=y9ydfgaKkNuku19Qf7HxyC0fAnVrRKnV/VMZos1WX9lJvJtfwwxdaf/ioa43q4UWvg yCuuAGIoS3YgQzo/Nv28m4cRlYXkZMeCiE935jUrOqTxlh0eMA16ANmZaZSdSGvb2zrz JbxYcijbVDH5L34fI43msstlPSEC/QCF/cTAWPq47/Pa3zQljZSP1Gpe3KK6h0yLw/oP p2im03CMOA3FAOEvAqbL//ASpPLtzZ7W1+SUmVc7oX88uZCna07w39JQgEBFPF7Dp6AO aVzJR0ADQuHw/OKsy4FXoBTqV3YwV+D2tFLBW/0ztlBw1oM7t9WQOA1Ep8HeI6zDDHjw 9eJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769115705; x=1769720505; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=RP/MTK8KNSVzyu6zuIe3MwXkpcWMuvGz5r3wnr6DkDY=; b=JZSHpgZ34WCcdoJ3NFuuDhYc33fFC7iLLxbygj0hc6GEhuOpVqQvgjeXGvWMJjMEok KbnbTF+vBhzwWgrp3xvtsr2y/n8Srf7zpvWLCwNvAk68uJPppEbix2BwzeTmP7TtLUAq HG8k/zRemG0zrYDaaT0eiYA0cvTbJAK5LS3mthJogyPIMhKHaJeabJO2yliQC9xQvlNa 3qtiJ72rc9NFBvhhFnLO/VCSo2Bhbz8iL6UqZcz4fieXmq4HdwA0HsVaOCqTgW+uA8b6 jMYyNqe91pIvLWcSGSwi84Aim0bp741h3aUy9i4MCYG0wUC4u1NbFNxVbuu3NLG2ojiO KsCQ== X-Gm-Message-State: AOJu0Yy4Po5KLDZrWkuZkEf3mC0pXSok3Vkxq6aFLsyiHalCpbmSqbFb HZKVSk40lKmEe3z+OWUB6GYPWWhqHSvp0uu2pmcqN4KxFX20aIymdVx4dIhQerSf/GzbDwl+Xp8 325m1wiM= X-Gm-Gg: AZuq6aIqgtl+JYAc4wZLsYBPcsAitM+ky7zL9ulM3PNucM3d1tIv1HdHAXA0mGEr/aV rekrw1cPl0zmlBS9Jq7mDYK3jGZoNMA8h4ikSwssbQ4cHOGZGgnIFSTXVkAqYWxNvfjvoGjWPJk TrPe5p9lF/UQnmgAByVQqbN0ZgvpJZJRlx0QAMnZia9Eh0ihYXq9fOQX8hdeh6o/qzCpu0x5G6o RbUJTJ2h/t8dBO9S62KYoWDvSD7IIGQLmVMFn4Fui6QfN6WfHuEXKn5MADth28/sDfagylJLK/s lq0xvopy+Orwo6eu17GTpwrT5YyD9N87u2g0JgQNSNqj9+9IMUhgBTLqkV1nX+6rl30An9XYeyz vwjpFMKcFIUnY8pVhC0U75Re+NUYVoCOIERBfTvQ76oYrQBlkU6AH9qK30kEHrBcQuQ52++P8oR qXGTYUbAueGhKVtX+0n1B7eq/sRjHN7Sn2bJH7W5aiOMTQpY0+LTKc4uYBjlK7 X-Received: by 2002:a05:600c:8b77:b0:477:9986:5e6b with SMTP id 5b1f17b1804b1-4804c9c1352mr14543145e9.28.1769115705382; Thu, 22 Jan 2026 13:01:45 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , Chinmay Rath , Anton Johansson , qemu-ppc@nongnu.org, Nicholas Piggin , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v4 06/11] target/ppc: Introduce ppc_code_endian() helper Date: Thu, 22 Jan 2026 22:00:56 +0100 Message-ID: <20260122210101.55358-7-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260122210101.55358-1-philmd@linaro.org> References: <20260122210101.55358-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=philmd@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1769115738483154100 Introduce the ppc_code_endian() helper which returns the MemOp endianness for the CODE path. Use it in need_byteswap(), removing one TARGET_BIG_ENDIAN. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/ppc/translate.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 17e6d07c8c2..4a9199a4473 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -214,14 +214,15 @@ static inline bool is_ppe(const DisasContext *ctx) return !!(ctx->flags & POWERPC_FLAG_PPE42); } =20 +static inline MemOp ppc_code_endian(const DisasContext *ctx) +{ + return MO_BE ^ (ctx->le_mode * MO_BSWAP); +} + /* Return true iff byteswap is needed in a scalar memop */ static inline bool need_byteswap(const DisasContext *ctx) { -#if TARGET_BIG_ENDIAN - return ctx->le_mode; -#else - return !ctx->le_mode; -#endif + return ppc_code_endian(ctx) !=3D MO_TE; } =20 /* True when active word size < size of target_long. */ --=20 2.52.0 From nobody Sun Jan 25 10:15:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1769115791; cv=none; d=zohomail.com; s=zohoarc; b=VGC6HfUJpDVBXL40MALVVtfbsTk7CRRzny9cLDJ2Uwr9tr2naJ+06o/ef+JUEomdDOwxTrQW24ptccPL2D56yRTFqyvQos+9ForkHARVr4XyXIW22G11W/AEKBlDGHhw8CM7U2ZIgFUzCccjg+di4sFq5pwjQKb8Q0w2zkmUvnw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769115791; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=RkPs1FcFNxMJ8Y8uZWUMxNftxsmN7tKxj2I2BegJ4Gs=; b=d9T7R6Lq4fxkRSPKhlXdnw2APT2df3eWYRdBuCsG3SYHAIIbfrKGIuLwCigESd4yNY9UnhmbPlEMuff5vo95U8aRPFXw2YKpI6S9w6Xtr2TV8eu0iZ2vVoAyvuYP7SHPE8x6OK1ZIiPFEWcGLwRyGgbMLehBgG9z24XleNehC0I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1769115791059337.6675409607917; Thu, 22 Jan 2026 13:03:11 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vj1od-0003Lu-Pg; Thu, 22 Jan 2026 16:02:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vj1oS-0003Fc-S9 for qemu-devel@nongnu.org; Thu, 22 Jan 2026 16:01:56 -0500 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vj1oQ-0005Iu-Uy for qemu-devel@nongnu.org; Thu, 22 Jan 2026 16:01:56 -0500 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-432d2c96215so1203868f8f.3 for ; Thu, 22 Jan 2026 13:01:54 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435b1b6e2besm1446963f8f.0.2026.01.22.13.01.51 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 22 Jan 2026 13:01:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769115712; x=1769720512; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RkPs1FcFNxMJ8Y8uZWUMxNftxsmN7tKxj2I2BegJ4Gs=; b=RGQ0ukp64rv4gDyOkD66gzcBd0RKOGE/ESHYJN8Gx3BmJiR6Dfu6Lp9jiI6Nib3aja l6bvAzg+0ftif/ht8atycUPN0R/FCISzOQk4hUWjVrfkKV6T/g4JKRH25x78rm2fmEGb 4XBKcKCPas2yIySdi34csNDjENz2gkJZen/N7+3C52iCqFtFQdI0npsR+DxYnYkegf5t lCZnQpDnA9s3hfKRpqQRyNQcQ4Nlkv96ZI40iQ5EvHsGBEUsUANG1qHwFNGunyKnW4op CUqfTEAlRLk8kZUZgH21+F5UA6Pxd9s/ZWYcuSiGMtFyuwnZIqLIILpdBmOdEIZ+cRno 2LWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769115712; x=1769720512; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=RkPs1FcFNxMJ8Y8uZWUMxNftxsmN7tKxj2I2BegJ4Gs=; b=HweJt4Gu2EW9R5WxySOsP86waBkbIDIec4AjkX8YA0KLqkWgNs1ADYWOB3XIb0iaMS 9jL5dFp36Dw7P1wF4V9pi/yC8eO7gH4Xqb4sgqYw1D4agwwXRMjE26PPhbz1IRvXf/l0 Mmlf65cLG3kdHbwxukR4gI41JcnD1lq9L3cFYdkXzjLYL9ZzF9uRZe7BdJwP46kPnkiw QxYy9Znz+GafRCbWvXLXsC5y1jMOk5OCgsnu3CduKMbTv9i4kobpVHSg9fXhAVX4AXxN AMqWJBe5BbjZV4MHx2UaepD+cpR/jw8oRM2BzJ2O4OHXFTQe/1AclW4gsi3iXXND4RLW umdw== X-Gm-Message-State: AOJu0YxRBL7BKPKyquKPd5MFHWLCArk/5uaPfHfktooQlOAAmYZqQouB uh/1UZKxwCDE2GJ3qhRwDqjxHMJQ4ThxzXTFoFzyaAPmcXgUlGYNjHZ+954fVCKP8EtB84XdEPv oLYO6O24= X-Gm-Gg: AZuq6aKVln6Lv3BYbNYDFqYLXs4rrqi1vu5HOLdgEfpBCODJyW9Xk6qFSwwE5bfMVST M+0d+O3Pwihwbdysfl8G+a/Rx4RN2i2JgL7wUpVNV/ulRBSMi0iwygjHpk6m93+UnyQ/gX5Sm7P D4gdOhzZ1WmcD4VTAUD8k+bgaUI3C13J2jKQT6MXRV3r7Ezb59mPEXsBI2WmDiZ1bobXj8OBAS7 T3rEL2vRhoqUuxUAZIzH3rBj5SPWK6Nml7mSjGd7Y/sZ1Nu9W1IdgrIs153mI0MoKI2t/Z4Ug0a tKL2a/DtM83QLBayXETQBWlG3yXKP7STypY7mGN+ka4U/MnY9ZqNLu3PmfKCLakr1Cgg6yetdjw bnE9L+Wjyjwr+0q0T5GjtSwCqCRFNUoNex6pQkl4ClDjolkBRZrY/8nQeoZlAe5AQ8XfIJ0sWtF /9XD1aNzuUdjOlg+YJxnKHnSjxCgstmaFariUFctjdQd+7PWH7LKdGflQ6vIFK X-Received: by 2002:a05:6000:268a:b0:430:f9c2:8500 with SMTP id ffacd0b85a97d-435b1606292mr1582805f8f.43.1769115712207; Thu, 22 Jan 2026 13:01:52 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , Chinmay Rath , Anton Johansson , qemu-ppc@nongnu.org, Nicholas Piggin , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v4 07/11] target/ppc: Inline need_byteswap() and replace translator_ldl_swap() Date: Thu, 22 Jan 2026 22:00:57 +0100 Message-ID: <20260122210101.55358-8-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260122210101.55358-1-philmd@linaro.org> References: <20260122210101.55358-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=philmd@linaro.org; helo=mail-wr1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1769115792963154100 Rather than using a boolean with translator_ldl_swap(), get the MemOp endianness with ppc_code_endian() and pass it to translator_ldl_end(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/ppc/translate.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 4a9199a4473..2ea18e7981c 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -219,12 +219,6 @@ static inline MemOp ppc_code_endian(const DisasContext= *ctx) return MO_BE ^ (ctx->le_mode * MO_BSWAP); } =20 -/* Return true iff byteswap is needed in a scalar memop */ -static inline bool need_byteswap(const DisasContext *ctx) -{ - return ppc_code_endian(ctx) !=3D MO_TE; -} - /* True when active word size < size of target_long. */ #ifdef TARGET_PPC64 # define NARROW_MODE(C) (!(C)->sf_mode) @@ -6589,6 +6583,7 @@ static void ppc_tr_translate_insn(DisasContextBase *d= cbase, CPUState *cs) DisasContext *ctx =3D container_of(dcbase, DisasContext, base); PowerPCCPU *cpu =3D POWERPC_CPU(cs); CPUPPCState *env =3D cpu_env(cs); + MemOp mo_endian =3D ppc_code_endian(ctx); target_ulong pc; uint32_t insn; bool ok; @@ -6598,7 +6593,7 @@ static void ppc_tr_translate_insn(DisasContextBase *d= cbase, CPUState *cs) ctx->base.pc_next, ctx->mem_idx, (int)msr_ir); =20 ctx->cia =3D pc =3D ctx->base.pc_next; - insn =3D translator_ldl_swap(env, dcbase, pc, need_byteswap(ctx)); + insn =3D translator_ldl_end(env, dcbase, pc, mo_endian); ctx->base.pc_next =3D pc +=3D 4; =20 if (!is_prefix_insn(ctx, insn)) { @@ -6614,8 +6609,7 @@ static void ppc_tr_translate_insn(DisasContextBase *d= cbase, CPUState *cs) gen_exception_err(ctx, POWERPC_EXCP_ALIGN, POWERPC_EXCP_ALIGN_INSN= ); ok =3D true; } else { - uint32_t insn2 =3D translator_ldl_swap(env, dcbase, pc, - need_byteswap(ctx)); + uint32_t insn2 =3D translator_ldl_end(env, dcbase, pc, mo_endian); ctx->base.pc_next =3D pc +=3D 4; ok =3D decode_insn64(ctx, deposit64(insn2, 32, 32, insn)); } --=20 2.52.0 From nobody Sun Jan 25 10:15:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1769115751; cv=none; d=zohomail.com; s=zohoarc; b=NO6hoBREChycnCZC8v1DAShORzBIXbIbrXvwsye408oD275o4ugPiVNRtZHkMTZD1wP36FfW6o2g2DT4+BMH6HNE0zuE4w6Xi0rHEVY++T/VI6UNARKUD1NIO5ihGNYD2iG3hNugo5ZbBd2Dp95+yfTgLF5s2CyjoJaUv8mSSEQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769115751; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=pZixBBXw9pW9Lb2/N+W+Mo89Bf4jJ5ucu9PIzWSFCxg=; b=FSIhJazZCJVHjI6OKIZHaGu5Wsqzuc1K2NG8BjWnN+6+7nm72CXPCnHdDjMo4uTnlgkrYD5XNASOGpDp+OCTTL9p/dYmx5R71MVzJgIsf6DdAERbvIKhuvlN1I1LuqP9KMKTbmtjEqCxIADzY1v1MOC76Ny/W7j4wh77lMzFlKw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1769115751281822.479246794106; Thu, 22 Jan 2026 13:02:31 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vj1oi-0003Re-VF; Thu, 22 Jan 2026 16:02:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vj1oY-0003Ld-KD for qemu-devel@nongnu.org; Thu, 22 Jan 2026 16:02:06 -0500 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vj1oW-0005JD-U0 for qemu-devel@nongnu.org; Thu, 22 Jan 2026 16:02:02 -0500 Received: by mail-wm1-x343.google.com with SMTP id 5b1f17b1804b1-47ee3a63300so16448305e9.2 for ; Thu, 22 Jan 2026 13:02:00 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4804d8a5b2dsm8310935e9.9.2026.01.22.13.01.58 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 22 Jan 2026 13:01:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769115719; x=1769720519; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pZixBBXw9pW9Lb2/N+W+Mo89Bf4jJ5ucu9PIzWSFCxg=; b=uKWlzzYOaOONYCGfOyy9FabVkzqH35t8G1khL1j0MrGOJCiLkKc9d9AT2B9eyqiB2f XnoLvosYP2Wylr+ztx3WacEADRJTrxyyxrr28knRd6VeKxOqcC7qDv9nrKGyspQsC0EG zO90yfaqUyLo39MccOQ7g4Iz2rPVpRcSDavpvMR+HPsNmMNKiyVGrAvAHwNzoSO7qKkH lN3wxTFMtsYGbsupOcPlvG4PvLdKgEDotheMCAsMnkuQEnWlPF0JF39zg7pXD2nnk10Q 8DepJu51yuf37Pb7gvIbzqGU/fhiT4Vp2bxE3MFif7+wUvx96wXV1wjo0C6A+/f2/uUs HhSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769115719; x=1769720519; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pZixBBXw9pW9Lb2/N+W+Mo89Bf4jJ5ucu9PIzWSFCxg=; b=wp5cECxXXptVfMO7wiMWOtWkAafx1J/V09Wo3P2JiKBSFxibNGUMJs+a1QhGTb2zKM xJTSsOwPtwWuLCNyx7HrhWW4GIve4heBy50X5rs+Uvmp4zU8OvdYu7rCzb8ljMSRgxZo OBwKXyieDNVSSTcHxgnkqUjcJyxaKPn2xYEU8NL6TGMj/BlvpYgCbfjGSCEIsBHgz8h7 sLTcFV9fWDQRK0wxY9rLQIOLgI2wAbJQgLpmRw8s7ONouhcsQSS9bTJcJaptUWohI7rw Ih9lsifvJCwNiS+qlc0XYry7X6odLiUoEBsK62QgdAgUXxa+up13x2fD7K5N8phJAtKu Yvmg== X-Gm-Message-State: AOJu0YyyNbLIUFDqHkABUFu3xXh73zztfayPYrfTdYJdZSPoqzORgE5Q u7rihCe5T1jNn/LJya/hByc0w5UfJv93/WiMX5vyx9zXC9U2M56DBFs9vk8lWtlMYIQd232C9fw 0ExkmbmuWZw== X-Gm-Gg: AZuq6aIWbTLDt6ZFcR0gaVW8peKzobBiOmXZGhtCtrAX5/V0FIl8wBKezgl8vMAVSbG j/8e1aAcoe2C3qTvEMyrn3vFhAjv9N04UxvypRh+oVp4qLpy6eos95bwKImE//yeYV8Gqzpx22+ guD8XMOmVEv/0phkfW6N/dCSwvUbmRk+FbUP0gKpOYDj1h64KyKkfqPQn6IBAslW0UxKCH9pl1n I2YYkJ36RzORYZudgocymy6zXtlEOl/EpnaB1DAM0KgaT87pZNz8lgXqaXGrfPLwJ5HUtMm7124 /LEWQpz3FD0o5s55bXt0PYTi3Y8t5X5lhc26E4k/9QfE2J1U6fCWKCkHAzHtZ+PZI3/+dYWOXG0 oRtSHFw9RSzuJCyQefrSSiNlNLLk8J4OkLXMbFFdaBqMgRQuKMjPb0qD/5lbknuwbkPMwMkhEst yasNEB12TWtovk19EsLv4AZlbhbk0Cvit9DO3dvH33+hLHvEtXWpQvUf08TLv9 X-Received: by 2002:a05:600c:6217:b0:477:9fcf:3fe3 with SMTP id 5b1f17b1804b1-4804d664990mr8920045e9.0.1769115719013; Thu, 22 Jan 2026 13:01:59 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , Chinmay Rath , Anton Johansson , qemu-ppc@nongnu.org, Nicholas Piggin , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v4 08/11] target/ppc: Check endianness via env in ppc_disas_set_info() Date: Thu, 22 Jan 2026 22:00:58 +0100 Message-ID: <20260122210101.55358-9-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260122210101.55358-1-philmd@linaro.org> References: <20260122210101.55358-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::343; envelope-from=philmd@linaro.org; helo=mail-wm1-x343.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1769115751734158500 disas_set_info() shouldn't bother with env->hflags, access env->msr directly. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/ppc/cpu_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c index 58816c51a74..0808284b722 100644 --- a/target/ppc/cpu_init.c +++ b/target/ppc/cpu_init.c @@ -7456,7 +7456,7 @@ static void ppc_disas_set_info(CPUState *cs, disassem= ble_info *info) { CPUPPCState *env =3D cpu_env(cs); =20 - if ((env->hflags >> MSR_LE) & 1) { + if ((env->msr >> MSR_LE) & 1) { info->endian =3D BFD_ENDIAN_LITTLE; } else { info->endian =3D BFD_ENDIAN_BIG; --=20 2.52.0 From nobody Sun Jan 25 10:15:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1769115880; cv=none; d=zohomail.com; s=zohoarc; b=ACGF64xIRK6ObLuJGFFhgM6VhI2i1erVxyZEMHzYfojYpoTi6dOeYFpJu8d93UhjRtvxlo7PnQx1/mnk7c+LvlusRIUOU5DW+DEj6DYjd+C2ri78YJlJJrR69EzVjHhQaGHM5PTb7e09Y+CfHhuZaqNK8oUki5r+uV5e+lco9V8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769115880; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=XDHngiUwEbIgiBsmhSfkRWTOLuQP8i2N7EL07ewZgHk=; b=GYEx7BVa7Zeg7c7iDvx5hRJJBdVe2GQC612iK/mBE2DCsfax+AF8BUl00xl0MAfxINq0QtQGPZTrlw7oUBuUV+3pD33HDt7u6xPydj8GetLq/jDpRNQykR1N9C5MFdqI3whGb8NchBmxADasONJlYuxQQavWY2PuM0ICRT/vhxI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1769115880964941.491322875853; Thu, 22 Jan 2026 13:04:40 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vj1pU-0004Eq-RP; Thu, 22 Jan 2026 16:03:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vj1oh-0003Rw-5u for qemu-devel@nongnu.org; Thu, 22 Jan 2026 16:02:11 -0500 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vj1oe-0005KB-7X for qemu-devel@nongnu.org; Thu, 22 Jan 2026 16:02:10 -0500 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-4327555464cso951301f8f.1 for ; Thu, 22 Jan 2026 13:02:07 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435b1f73855sm1284107f8f.29.2026.01.22.13.02.04 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 22 Jan 2026 13:02:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769115726; x=1769720526; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XDHngiUwEbIgiBsmhSfkRWTOLuQP8i2N7EL07ewZgHk=; b=R+FOONq6MhxFCNVNIsSj53slscQUQB5VZ0azKtfBBbb3VrD8NtA7rLp04Kfl/UO5jI Yu8SV2gPL8x7GMyMBjfW5whtl7yq/Ur2Z5EJG8ammz0HbRJBCEDaGr1zHtivi/tLwW1N 6FteHf2GVOYawnZgJC+WqjeuHGOQjtF7s8reej+2cr1b4FNVmAgIyH8UIfLcbxzee+CC J1Cke74ZRs2OshNsjN/akm4aKTtG7ElmPN8b4xHUrTLrxZ7e/slr/Pl89sbPGyia0UUk L/iHPJ6oLl/2/uUz2U97bTeP0ZpIX4Fxe6tIx66IBRstdcDOOjqV7VFOiz6NzSlS65uP Vw5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769115726; x=1769720526; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XDHngiUwEbIgiBsmhSfkRWTOLuQP8i2N7EL07ewZgHk=; b=eojNNzQajYCRvzSzGaP3IeSnb0bTq/ePdBJAh78EJt6zLHb4viZaTs0S5lnaf3RZqX TI3jmcUrrjZCMHYEGLdkgFBqe8F0H1RGbD2M4SJwHMRyqNVrKARlkbur8n0c2TXOXhmo 3jyS0Xgij4/zH6If4E5k11aXvi47WLcENVc/toMCWosgZcSDq68izvhxsmevZ3WeIvzS 5/y0h+aphe3FkgWR8PNUpOhEHyi/PIGll2IFsBkFhJj8gZ6L7vSRrIkPpve5VZAM/Yu7 8l51lN/3rRqGQLhgIoFC7BPPuVFSMjj2G1ooF6OhDybajoNZqabyahcGlyAhvokms328 ZuGQ== X-Gm-Message-State: AOJu0YwOu/C++B/91tblmlRaQ+tLFTRbl0Twg3G6FfSPkJ3JnjpIL9am cWHm+Q+GmRXyYaheiasq/esRsuPA2bLl6ciCMPj3NmPQ3FNkLJR3k5zVAdF1Hw9W1Hj9SAeqoyv Klfjrm6o= X-Gm-Gg: AZuq6aLjH/6GPonUD2Jn7pvZbT6tTRgvi9LORVSHDodin2whj2bUmjbCgLhz7ZKWzBG 5r5SzRRpR04vctSiedopcfR3LZ9ktKwpOZzSH4Gj1nipOZXg9m0mZ27687FwWwo4KW3psEQG3pO w0tOaRxY3S30jvuiQnTjJk6yH8ONQQUrbfzBT60jCF4lX/E6tHUUmFYbiCFtkCdCBQnnllBSsif SrJDtWNGYWeq/JFA5ZZe2XqRAk9l04yP46AWeqCc63Lq1xbXlNpogO7IvzTv9bNL+umpeTouoPS /XlDrRMB6fG5zMOJmJTrysev/B3uHO8NuPd3AyXYPBo0+upIh4yL9un1SExGU5lp2gr7b0qql8N Nalt60ngZqImp8Aau1VdzloUOFCcQV9PlHWvUJaQccWNE6xo+6zwG1IsBiPM69RRKwrxi0jkiZY DVmqcBYhL23skJfNk88mr3exazkONol7KcINHt1+h5d8M6JH3P0YZKmMcVxVlL X-Received: by 2002:a05:6000:23c1:b0:435:9d3f:92ee with SMTP id ffacd0b85a97d-435b17501f3mr1135404f8f.57.1769115725925; Thu, 22 Jan 2026 13:02:05 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , Chinmay Rath , Anton Johansson , qemu-ppc@nongnu.org, Nicholas Piggin , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v4 09/11] target/ppc: Introduce ppc_env_is_little_endian() helper Date: Thu, 22 Jan 2026 22:00:59 +0100 Message-ID: <20260122210101.55358-10-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260122210101.55358-1-philmd@linaro.org> References: <20260122210101.55358-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=philmd@linaro.org; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1769115883964154100 Centralize endianness check on MSR via a common helper. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/ppc/internal.h | 5 +++++ target/ppc/cpu_init.c | 9 +++------ target/ppc/gdbstub.c | 2 +- target/ppc/mem_helper.c | 8 ++++---- 4 files changed, 13 insertions(+), 11 deletions(-) diff --git a/target/ppc/internal.h b/target/ppc/internal.h index 09333bed342..714629079b5 100644 --- a/target/ppc/internal.h +++ b/target/ppc/internal.h @@ -24,6 +24,11 @@ #include "exec/page-protection.h" #include "accel/tcg/tb-cpu-state.h" =20 +static inline bool ppc_env_is_little_endian(const CPUPPCState *env) +{ + return FIELD_EX64(env->msr, MSR, LE); +} + static inline MemOp mo_endian_env(const CPUPPCState *env) { return MO_TE; diff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c index 0808284b722..c5cec7c2ed9 100644 --- a/target/ppc/cpu_init.c +++ b/target/ppc/cpu_init.c @@ -7364,7 +7364,7 @@ static bool ppc_cpu_is_big_endian(CPUState *cs) { cpu_synchronize_state(cs); =20 - return !FIELD_EX64(cpu_env(cs)->msr, MSR, LE); + return !ppc_env_is_little_endian(cpu_env(cs)); } =20 static bool ppc_get_irq_stats(InterruptStatsProvider *obj, @@ -7456,11 +7456,8 @@ static void ppc_disas_set_info(CPUState *cs, disasse= mble_info *info) { CPUPPCState *env =3D cpu_env(cs); =20 - if ((env->msr >> MSR_LE) & 1) { - info->endian =3D BFD_ENDIAN_LITTLE; - } else { - info->endian =3D BFD_ENDIAN_BIG; - } + info->endian =3D ppc_env_is_little_endian(env) ? BFD_ENDIAN_LITTLE + : BFD_ENDIAN_BIG; info->mach =3D env->bfd_mach; if (!env->bfd_mach) { #ifdef TARGET_PPC64 diff --git a/target/ppc/gdbstub.c b/target/ppc/gdbstub.c index 3b28d4e21c7..b19c0f1ea9c 100644 --- a/target/ppc/gdbstub.c +++ b/target/ppc/gdbstub.c @@ -84,7 +84,7 @@ static int ppc_gdb_register_len(int n) void ppc_maybe_bswap_register(CPUPPCState *env, uint8_t *mem_buf, int len) { #ifndef CONFIG_USER_ONLY - if (!FIELD_EX64(env->msr, MSR, LE)) { + if (!ppc_env_is_little_endian(env)) { /* do nothing */ } else if (len =3D=3D 4) { bswap32s((uint32_t *)mem_buf); diff --git a/target/ppc/mem_helper.c b/target/ppc/mem_helper.c index 3c91d641f9a..c483b60c9d0 100644 --- a/target/ppc/mem_helper.c +++ b/target/ppc/mem_helper.c @@ -416,7 +416,7 @@ target_ulong helper_lscbx(CPUPPCState *env, target_ulon= g addr, uint32_t reg, int adjust =3D HI_IDX * (n_elems - 1); \ int sh =3D sizeof(r->element[0]) >> 1; \ int index =3D (addr & 0xf) >> sh; \ - bool byteswap =3D FIELD_EX64(env->msr, MSR, LE); \ + bool byteswap =3D ppc_env_is_little_endian(env); \ \ if (byteswap) { \ index =3D n_elems - index - 1; \ @@ -442,7 +442,7 @@ LVE(LVEWX, cpu_ldl_be_data_ra, bswap32, u32) int adjust =3D HI_IDX * (n_elems - 1); \ int sh =3D sizeof(r->element[0]) >> 1; \ int index =3D (addr & 0xf) >> sh; \ - bool byteswap =3D FIELD_EX64(env->msr, MSR, LE); \ + bool byteswap =3D ppc_env_is_little_endian(env); \ \ if (byteswap) { \ index =3D n_elems - index - 1; \ @@ -475,7 +475,7 @@ void helper_##name(CPUPPCState *env, target_ulong addr,= \ t.s128 =3D int128_zero(); \ if (nb) { \ nb =3D (nb >=3D 16) ? 16 : nb; = \ - if (FIELD_EX64(env->msr, MSR, LE) && !lj) { \ + if (ppc_env_is_little_endian(env) && !lj) { \ for (i =3D 16; i > 16 - nb; i--) { \ t.VsrB(i - 1) =3D cpu_ldub_data_ra(env, addr, GETPC()); \ addr =3D addr_add(env, addr, 1); \ @@ -506,7 +506,7 @@ void helper_##name(CPUPPCState *env, target_ulong addr,= \ } \ \ nb =3D (nb >=3D 16) ? 16 : nb; \ - if (FIELD_EX64(env->msr, MSR, LE) && !lj) { \ + if (ppc_env_is_little_endian(env) && !lj) { \ for (i =3D 16; i > 16 - nb; i--) { \ cpu_stb_data_ra(env, addr, xt->VsrB(i - 1), GETPC()); \ addr =3D addr_add(env, addr, 1); \ --=20 2.52.0 From nobody Sun Jan 25 10:15:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1769115868; cv=none; d=zohomail.com; s=zohoarc; b=Vur4yIknKIYRBfY3NAad5eu7c037DqM4xYXOOocPCL8l3b5wRu3xACFFQsme9+2u6US1cxK3X9ai/RyefmHU8sjf/iq+Nl3uvKxm/1iDRCbGuk+w/FUo8q+kpm2dMSfdq7Q6tK1DNQ9IuwQjnt6ePX54XR/GcNnkBbqwC+TAyuE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769115868; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/ODkndRwX/R09xiWds3ROCMF/P61RrewKW7dQu09WfU=; b=EXLXVa2v8sS166FhGZUIFBw7rjwYwgCihoCOtig3omy6s0v4uHDJhgHG11ykpmn8fawLi6ppxLQjrgLk5LChoeNgYixbsVqn+OkGQscIfPYmFCcL/SfyojFzdaXLdI2IlBo1mgt04jnypXzrXg24PnZ59WtVLvE1KdR2WWopWJk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1769115868159453.2909582194802; Thu, 22 Jan 2026 13:04:28 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vj1qG-00053u-6W; Thu, 22 Jan 2026 16:03:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vj1om-0003b0-3v for qemu-devel@nongnu.org; Thu, 22 Jan 2026 16:02:19 -0500 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vj1ok-0005L8-Jl for qemu-devel@nongnu.org; Thu, 22 Jan 2026 16:02:15 -0500 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-4801d7c72a5so11260385e9.0 for ; Thu, 22 Jan 2026 13:02:14 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-480470cf1acsm93638615e9.14.2026.01.22.13.02.11 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 22 Jan 2026 13:02:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769115733; x=1769720533; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/ODkndRwX/R09xiWds3ROCMF/P61RrewKW7dQu09WfU=; b=QrbgSKyD2Cs62osWaoXa2rjgBytip0xUV/7Nwqfn3T9iNDMYAIUjKOe3pPbxgAS0fO 7e0QHOQ9X1+2AASyQB87z3vmffLZQW4c7QT/LD+iYEfrMHEFxxrsVA+Sb1KFVR4LhoKT TXn29OCZ5F4uUwmoWxcMW/llkyp0uvIvVcfAyN01yPzsLTbAeRZPYqVPpK1p55+pfHYT E3CgQz+lc1C0LGz8RD+PIOZKc1dCoQL3xBQIE0E1kSQSBHlCdtdhVjIZiKMTGF1QP7OR 0/FVMB+fklLnsxWNNtOuKzBZLmJbDOuZyw4QI51nCdS72hAIBrr+UaHZjfpaAyKiOK46 3R1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769115733; x=1769720533; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/ODkndRwX/R09xiWds3ROCMF/P61RrewKW7dQu09WfU=; b=wMyWJPfZUPahOdh55sGAZ5lnGDw04e/8y2cH4kSV34CltHO3HQOR66jSmVZCK2VIru Cdy/nFJhoYe8n2Ac6LfD9d4jKqVXe68ccz1fdxcd6xBF1MUmxI7GY8IM7afOlQkXSsB9 8ydrJFhnv51CkRwCJVCk+5zvP/mn5h/oMq9B9ZmzodCfB4/cR9uQX4af4Hb1c8Sm0PNa w7nzbVjoJDrO7odFc89tU9EKePY6dZHj6bUbpEpHv7CvdOeJQ60IL5+GGNuZqwsRP8QE To6pC3gGhYTMa5XkrYvS1f0FnFoooCY8rU8gJFLBwO2ck5bEq3wEhplkxRpeDuNGhV9E nJ9g== X-Gm-Message-State: AOJu0Yxmv+CWfcfpYwG570+2n2aJkMTMuwYOCd6BcybtdoC87V/N3zQV 6zY/ahYOcnrrX+p4QaIBbJq+gWtU67XHC257YB5VfWOADSbaG+AW9N5twNUxCc88kHJLwFp/43f 5Itos/TI= X-Gm-Gg: AZuq6aJZbG+fct+KGbK1DmmgV8Zwxk8saW5QPfx95adgvIFDIO3tezw8fw6UpCFL1BN IwJzH1MqpWxPLUdvwb3WSCBBhUgyxIhcboJpHyCo3YXJ3fxEPzfx7smVyGyLTB/6+fH/HRgdwHK NVn+B4Fmkz7coI3x9bUgYFb7e0EdWT5xfzOTBIckgAsV0zHBfsoMl01zIJDRHspOkzhW0W1+mUF zBMbkyX6RWkGK2HD6rQfFxY4iKyzrAHUr8BESXnG3ksNrmAKlSsr5yOpLpdQVokc+nrBvhsv/Q6 83TS2U7oMyex0MkmWxEItdDK1uPXvZbo1UmWrSOQScOB+B5pF7lJ2EMJSPiiEzkmx8TpBImqFwF bHUx+kzP4Vfu/PnuF5dOBkLl3l3PmByNar5lKVCIGiwMTdFIISRNdkXHOG8UGzsFYYEYSIijdsp oQJFzABY6zZAcx0RZ9AHgwByRn6qwF9CBdtAuMpWqRtaDKyZ7/z5PiVmolO0Dm X-Received: by 2002:a05:600c:524d:b0:480:3a72:5c10 with SMTP id 5b1f17b1804b1-4804c95c6e0mr17096355e9.16.1769115732773; Thu, 22 Jan 2026 13:02:12 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , Chinmay Rath , Anton Johansson , qemu-ppc@nongnu.org, Nicholas Piggin , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v4 10/11] target/ppc: Check endianness at runtime in mo_endian_env() Date: Thu, 22 Jan 2026 22:01:00 +0100 Message-ID: <20260122210101.55358-11-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260122210101.55358-1-philmd@linaro.org> References: <20260122210101.55358-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1769115870126158500 Rather a runtime endianness check via env MSR over a build-time one. Now CPU can change endianness at runtime. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/ppc/internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/ppc/internal.h b/target/ppc/internal.h index 714629079b5..7dfca0b41a3 100644 --- a/target/ppc/internal.h +++ b/target/ppc/internal.h @@ -31,7 +31,7 @@ static inline bool ppc_env_is_little_endian(const CPUPPCS= tate *env) =20 static inline MemOp mo_endian_env(const CPUPPCState *env) { - return MO_TE; + return ppc_env_is_little_endian(env) ? MO_LE : MO_BE; } =20 /* PM instructions */ --=20 2.52.0 From nobody Sun Jan 25 10:15:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1769115881; cv=none; d=zohomail.com; s=zohoarc; b=daDZfl7nnHpUQIXKYgKKs6FJIYY+5rFqKulfm/bvCrhNci8c1pCGGmJTozA97OHDzqRlZxrNEHtBsLVdyQB+x2VIZ0v6Yr1k/HaBO0TNidQJfBjSqM4wPB0fq6snnAA+GJVlQQZnBRrrGQPkL7Jcl37tS/Hk1w6EHUj/+6khaxw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769115881; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=dsgN08xwFykkgI55V8CeZLzuXOe+HEtSRM2XAs4O99o=; b=jal0NglCwbFUhk2yqVHUicDEVoGGd4oxKuCiYi45I+1fyFLrnpYragASuEcLN0c9HaigtggT4HXZFLSiI53gBLJMeEr7p7mLtRvpSRZyqB5fSFz0GjjxRn8gOnO+YRI7zBCbJSMV54j4XSlXtbgoSFl3sFz/3UP1/TrbEv7NQ14= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1769115881351749.1633231852935; Thu, 22 Jan 2026 13:04:41 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vj1qU-0005WT-1X; Thu, 22 Jan 2026 16:04:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vj1p1-0003rp-FI for qemu-devel@nongnu.org; Thu, 22 Jan 2026 16:02:35 -0500 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vj1oz-0005M3-Oj for qemu-devel@nongnu.org; Thu, 22 Jan 2026 16:02:31 -0500 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-47ee3da7447so11479155e9.0 for ; Thu, 22 Jan 2026 13:02:21 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435b1c24b54sm1358257f8f.15.2026.01.22.13.02.18 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 22 Jan 2026 13:02:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769115740; x=1769720540; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dsgN08xwFykkgI55V8CeZLzuXOe+HEtSRM2XAs4O99o=; b=if0F7Pdy431YKIgbei9TW3i5BCrZbe1F/7MUC0E/T6FsgQjsp8PQ6iZ3jtrJMJgYDl A8e6BQBmxru+277FXVU4H/b+5B4tMgr9qzDu589Jt12aYxHMyTH1q1fcZXfDMAgVfbp7 hEdFI0DpSSJj2tTQ9MIz7qqiz1pADU9X9s2I6r/AI/Jid22/0T41MyIqYU1mQU2eKftq 6+UXN6qOV1qCKCCDJ8B4Uem71VrCXw8MhaHIcJzUIh65yXyVjvSGL3BmxAsejcHTy/nQ HoMohS3vLFrlr+QejhqPSaghV9M7vNaVaFj0xM+Z2ysz8S53R341rULFJc0W50m1+0nh Y9SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769115740; x=1769720540; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=dsgN08xwFykkgI55V8CeZLzuXOe+HEtSRM2XAs4O99o=; b=NtRDXUfw3kMH/GSq8PCoy4bk7/ctJmbLq32IY1/tR4cw36Mh/qlBXhFj7/6I/EX6AE xdSKnuPQHQjl2cuqFADQNGPaVSdDgC5bSyEdU27AKZT043OfW98O98HYAv2HIg94ian9 cFYLQcEcd9sHqd+Nl5vydZAo0e479DcijTEM/MdlTQzGT1hxgGsgkQRR+RKmbNNTba5K YV9QkZU6vMSua3N3DwKhRHuMzay+iC7ckoi3oGq4mMi+mHUOK30UENN27RkvF6vZWxuM W2pjdh5dRxeFxCX4NoU3lbrzoSGGFXKuBEKocsp22mL6Zlhtf6xf0rQIH2eoVRxsx5/O iV8A== X-Gm-Message-State: AOJu0YyNwWWbm/lF3brmTBxDTzWSgDRsFdpujBw0Fhgpz1Y0CnbT10oY N8P1ZCWWTsgZPRklt7WaZKdaLrSqW5f/Vq5ppArgTS7IarZdXXebDzV8uVoh2K2d9cn3pUqaCDl wgjU6ICU= X-Gm-Gg: AZuq6aKd1CsAQ+jy51GtULG1h224wfULRPmvw352jYq8zpcES3p8IXIF99mPoEDWbry jvYygcPGy9b6684IXp61oe/EiJ3tealmrFrfMRG5MnLuD/5qnmOXb7Auea6eFUYrxwsdnHq5oj4 oHh7F/4TneUsw5nyoBVzMF8TZo4Dr2fbmgAmO1iP3WOy93fyKMHdsWUkfybsEl6OV9KiUFAUv/y QdhBn0t0aC0Pna+FfcPMQJ2oHt04pnYr6QMSQ46KiCukU9qwgdD2/QOTsWtou8LoMvkt7vW74xT FhgFO1J0pI8sPXFAPBHZsRNEEoV1TGR7Iv7bL4KwEwO5uMN8MhPrbUdkFd+Ci2P9Sq/YZOyEROw CiSrV/8Dh5kQWAPZ2VKbDOysI+HVq/Kw32j7E1gHAJf5oxCKH6IZ9T8uy4Mg4SeESQvtApZ9G+X WhieM7kavd5PN17k7FRTViVwh0rrkitcwlqQjqAAr9IuhLMy3o+A6DpZjMR71q X-Received: by 2002:a05:6000:184f:b0:42f:bbc6:edc1 with SMTP id ffacd0b85a97d-435b1587d81mr1222762f8f.1.1769115739882; Thu, 22 Jan 2026 13:02:19 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , Chinmay Rath , Anton Johansson , qemu-ppc@nongnu.org, Nicholas Piggin , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v4 11/11] target/ppc: Inline cpu_ldl_code() call in ppc_ldl_code() Date: Thu, 22 Jan 2026 22:01:01 +0100 Message-ID: <20260122210101.55358-12-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260122210101.55358-1-philmd@linaro.org> References: <20260122210101.55358-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1769115883985154100 In preparation of removing the cpu_ldl_code wrapper, inline it. Get the runtime endianness with mo_endian_env(), passing it to cpu_ldl_code_mmu(). No need to swap versus qemu-system binary anymore. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/ppc/tcg-excp_helper.c | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/target/ppc/tcg-excp_helper.c b/target/ppc/tcg-excp_helper.c index 77d21523a5b..955afc40a83 100644 --- a/target/ppc/tcg-excp_helper.c +++ b/target/ppc/tcg-excp_helper.c @@ -428,22 +428,13 @@ G_NORETURN void powerpc_checkstop(CPUPPCState *env, c= onst char *reason) cpu_loop_exit_noexc(cs); } =20 -/* Return true iff byteswap is needed to load instruction */ -static inline bool insn_need_byteswap(CPUArchState *env) -{ - /* SYSTEM builds TARGET_BIG_ENDIAN. Need to swap when MSR[LE] is set */ - return !!(env->msr & ((target_ulong)1 << MSR_LE)); -} - uint32_t ppc_ldl_code(CPUArchState *env, target_ulong addr) { - uint32_t insn =3D cpu_ldl_code(env, addr); + CPUState *cs =3D env_cpu(env); + MemOp op_end =3D mo_endian_env(env); + MemOpIdx oi =3D make_memop_idx(MO_UL | op_end, cpu_mmu_index(cs, true)= ); =20 - if (insn_need_byteswap(env)) { - insn =3D bswap32(insn); - } - - return insn; + return cpu_ldl_code_mmu(env, addr, oi, 0); } =20 #if defined(TARGET_PPC64) --=20 2.52.0