From nobody Sun Jan 25 12:10:37 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1769081575; cv=none; d=zohomail.com; s=zohoarc; b=GWn2ZAyRRKqK9PXi+YAEANCEMV2jZhSJiMFgc5GDeZJ8PT6cqjrPQut+W5xrBY2Sn8ZbbwKDYAq2/j+YlK/XS9W2LyIr6EtWsn3kTg/I4bXL2KPjsd90d+IzCFgXLIcEl24hONQNnkER3r+9z9CBjOZBPa8egoSDGeM25wjQBqM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769081575; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=V1407Wz3mEKZXo8P5fsNSHuVxicWoIpB76YxaaIDnwI=; b=fbVWfjjTjAsbO0asN4/irtC1IGRzE49aq+4DosUlWLFFotXdWx8NCBGoqyQzV36cGsTiK8iZpnsYRGYO6e6mdKeanlLOfVed0EhT8ZkDu4fSML6GhFYSC1DbpCDVIxt8WHytQwJcTnI7uGc++BTOXuPZxlRmMbwKZcNLJNY72gM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1769081575624657.4661865641992; Thu, 22 Jan 2026 03:32:55 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1visvJ-0004eC-Rh; Thu, 22 Jan 2026 06:32:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1visv2-0004bf-Lv for qemu-devel@nongnu.org; Thu, 22 Jan 2026 06:32:12 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1visv0-0007YT-Eh for qemu-devel@nongnu.org; Thu, 22 Jan 2026 06:32:08 -0500 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-682-K2WoyBpVNrqh2xTuXPJF0w-1; Thu, 22 Jan 2026 06:32:02 -0500 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 15D361800350; Thu, 22 Jan 2026 11:32:01 +0000 (UTC) Received: from localhost (unknown [10.45.242.5]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id CAD2F1958DC1; Thu, 22 Jan 2026 11:31:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769081525; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V1407Wz3mEKZXo8P5fsNSHuVxicWoIpB76YxaaIDnwI=; b=HQyarxUPi0bZlCv0ZNG0XSHgPLaqt7TASFji2/ArxMOzmIVM+4rc0c+CnejqtwXCGhtFfH SGWFOd3g5L0vdHBYAGasCrROc9eN57t+aQl/nl2lNC0e4TdO7s9ePaEvIiPgoebnJM0sou YLz6Oa2Wcla+bh5TmHwWRfqVeht8plc= X-MC-Unique: K2WoyBpVNrqh2xTuXPJF0w-1 X-Mimecast-MFC-AGG-ID: K2WoyBpVNrqh2xTuXPJF0w_1769081521 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: Fabiano Rosas , Laurent Vivier , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , richard.henderson@linaro.org Subject: [PATCH 2/4] ui/dbus: fix leak regression Date: Thu, 22 Jan 2026 15:31:41 +0400 Message-ID: <20260122113144.2046899-3-marcandre.lureau@redhat.com> In-Reply-To: <20260122113144.2046899-1-marcandre.lureau@redhat.com> References: <20260122113144.2046899-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.069, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1769081577644154100 From: Marc-Andr=C3=A9 Lureau For some reason, during refactoring, an extra reference leak was introduced. Fixes: commit 7945576cf2 ("ui/dbus: factor out sending a scanout") Signed-off-by: Marc-Andr=C3=A9 Lureau --- ui/dbus-listener.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ui/dbus-listener.c b/ui/dbus-listener.c index 52e041edb0f..407719fc1e0 100644 --- a/ui/dbus-listener.c +++ b/ui/dbus-listener.c @@ -815,8 +815,7 @@ static void ddl_scanout(DBusDisplayListener *ddl) qemu_dbus_display1_listener_call_scanout( ddl->proxy, surface_width(ddl->ds), surface_height(ddl->ds), surface_stride(ddl->ds), surface_format(ddl->ds), v_data, - G_DBUS_CALL_FLAGS_NONE, DBUS_DEFAULT_TIMEOUT, NULL, NULL, - g_object_ref(ddl)); + G_DBUS_CALL_FLAGS_NONE, DBUS_DEFAULT_TIMEOUT, NULL, NULL, NULL); } =20 static void dbus_gfx_update(DisplayChangeListener *dcl, --=20 2.52.0