From nobody Sun Jan 25 10:17:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1769081566; cv=none; d=zohomail.com; s=zohoarc; b=gLZlLaMTGkaGQyqaIlmLdg6LR3w7qmWcD43D0PGkoOMGRbHtsugmQQLaj7CDX9c9dIsV1fzoxdIvcdD3nOdKoFdk/BJlYacpCIx2ut4/EwPHdoB+mQU4+52H8zqs6p03W4+c7FxF0c6Ed9qse4NJe+7588qDTysdPsT9wbP4WRk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769081566; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Ii4cQD0ST+MxMEinFEnmcuZUQXF8DcPut1AVOJNRDAI=; b=AbOrg9aXOCIG95VWyecICNj4GYKDOuB5BXh64veyFAZvvA2GkwpBqLmvxmmojAlDcfXDl3MLCG6PEB4TXVpKa2r2QW7J8m1+XAhNrhShyHTRPNeMXaUzV+XjoBClQN1rDaaqYIHWDXUcbIk3kuuZJnT0izeVXrGAf4zZ5mSsIZQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176908156634771.19544883585218; Thu, 22 Jan 2026 03:32:46 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1visvH-0004do-5U; Thu, 22 Jan 2026 06:32:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1visuy-0004b1-RG for qemu-devel@nongnu.org; Thu, 22 Jan 2026 06:32:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1visus-0007Xj-Di for qemu-devel@nongnu.org; Thu, 22 Jan 2026 06:31:59 -0500 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-369-3n9ltSLmOlaL32dcCHjHHw-1; Thu, 22 Jan 2026 06:31:56 -0500 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 325E6180034F; Thu, 22 Jan 2026 11:31:55 +0000 (UTC) Received: from localhost (unknown [10.45.242.5]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C14031958DC0; Thu, 22 Jan 2026 11:31:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769081517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ii4cQD0ST+MxMEinFEnmcuZUQXF8DcPut1AVOJNRDAI=; b=FPxJXb0UcR1ft1D1lIhYc3ED5+q+9uECTT3p/wfMvs/u4Yri1YqRpgKmFLFZQW/yG1BEQw K8kOrXVo2335yKBrzOz5jFNz0eX3AzZkSjGDzVRkUCJx0aI2xvVv10Xh0yjXXYMhGhfXEW mLxB3AFdcNncm6zXfeATBRDSgAf0BDg= X-MC-Unique: 3n9ltSLmOlaL32dcCHjHHw-1 X-Mimecast-MFC-AGG-ID: 3n9ltSLmOlaL32dcCHjHHw_1769081515 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: Fabiano Rosas , Laurent Vivier , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , richard.henderson@linaro.org Subject: [PATCH 1/4] tests: fix leaks in dbus-display-test Date: Thu, 22 Jan 2026 15:31:40 +0400 Message-ID: <20260122113144.2046899-2-marcandre.lureau@redhat.com> In-Reply-To: <20260122113144.2046899-1-marcandre.lureau@redhat.com> References: <20260122113144.2046899-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.069, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1769081568848158500 From: Marc-Andr=C3=A9 Lureau Close the connections and complete the method invocations. Thanks ASAN for the report. Signed-off-by: Marc-Andr=C3=A9 Lureau Acked-by: Fabiano Rosas --- tests/qtest/dbus-display-test.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/tests/qtest/dbus-display-test.c b/tests/qtest/dbus-display-tes= t.c index 1d5951b7117..5773776cad5 100644 --- a/tests/qtest/dbus-display-test.c +++ b/tests/qtest/dbus-display-test.c @@ -76,6 +76,7 @@ test_dbus_display_vm(void) qemu_dbus_display1_vm_get_name(QEMU_DBUS_DISPLAY1_VM(vm)), =3D=3D, "dbus-test"); + g_clear_object(&conn); qtest_quit(qts); } =20 @@ -97,6 +98,8 @@ static gboolean listener_handle_scanout( GVariant *arg_data, TestDBusConsoleRegister *test) { + qemu_dbus_display1_listener_complete_scanout(object, invocation); + if (!test->with_map) { g_main_loop_quit(test->loop); } @@ -131,6 +134,9 @@ static gboolean listener_handle_scanout_map( g_assert_no_errno(addr =3D=3D MAP_FAILED ? -1 : 0); g_assert_no_errno(munmap(addr, len)); =20 + qemu_dbus_display1_listener_unix_map_complete_scanout_map(object, invo= cation, + NULL); + g_main_loop_quit(test->loop); =20 close(fd); @@ -287,6 +293,7 @@ test_dbus_display_console(const void* data) =20 g_clear_object(&test.server); g_clear_object(&test.listener_conn); + g_clear_object(&conn); qtest_quit(qts); } =20 @@ -322,6 +329,7 @@ test_dbus_display_keyboard(void) &err); if (g_error_matches(err, G_DBUS_ERROR, G_DBUS_ERROR_UNKNOWN_METHOD)) { g_test_skip("The VM doesn't have a console!"); + g_clear_object(&conn); qtest_quit(qts); return; } @@ -348,6 +356,7 @@ test_dbus_display_keyboard(void) g_assert_cmpint(qemu_dbus_display1_keyboard_get_modifiers( QEMU_DBUS_DISPLAY1_KEYBOARD(keyboard)), =3D=3D, 0); =20 + g_clear_object(&conn); qtest_quit(qts); } =20 --=20 2.52.0 From nobody Sun Jan 25 10:17:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1769081575; cv=none; d=zohomail.com; s=zohoarc; b=GWn2ZAyRRKqK9PXi+YAEANCEMV2jZhSJiMFgc5GDeZJ8PT6cqjrPQut+W5xrBY2Sn8ZbbwKDYAq2/j+YlK/XS9W2LyIr6EtWsn3kTg/I4bXL2KPjsd90d+IzCFgXLIcEl24hONQNnkER3r+9z9CBjOZBPa8egoSDGeM25wjQBqM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769081575; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=V1407Wz3mEKZXo8P5fsNSHuVxicWoIpB76YxaaIDnwI=; b=fbVWfjjTjAsbO0asN4/irtC1IGRzE49aq+4DosUlWLFFotXdWx8NCBGoqyQzV36cGsTiK8iZpnsYRGYO6e6mdKeanlLOfVed0EhT8ZkDu4fSML6GhFYSC1DbpCDVIxt8WHytQwJcTnI7uGc++BTOXuPZxlRmMbwKZcNLJNY72gM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1769081575624657.4661865641992; Thu, 22 Jan 2026 03:32:55 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1visvJ-0004eC-Rh; Thu, 22 Jan 2026 06:32:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1visv2-0004bf-Lv for qemu-devel@nongnu.org; Thu, 22 Jan 2026 06:32:12 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1visv0-0007YT-Eh for qemu-devel@nongnu.org; Thu, 22 Jan 2026 06:32:08 -0500 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-682-K2WoyBpVNrqh2xTuXPJF0w-1; Thu, 22 Jan 2026 06:32:02 -0500 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 15D361800350; Thu, 22 Jan 2026 11:32:01 +0000 (UTC) Received: from localhost (unknown [10.45.242.5]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id CAD2F1958DC1; Thu, 22 Jan 2026 11:31:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769081525; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V1407Wz3mEKZXo8P5fsNSHuVxicWoIpB76YxaaIDnwI=; b=HQyarxUPi0bZlCv0ZNG0XSHgPLaqt7TASFji2/ArxMOzmIVM+4rc0c+CnejqtwXCGhtFfH SGWFOd3g5L0vdHBYAGasCrROc9eN57t+aQl/nl2lNC0e4TdO7s9ePaEvIiPgoebnJM0sou YLz6Oa2Wcla+bh5TmHwWRfqVeht8plc= X-MC-Unique: K2WoyBpVNrqh2xTuXPJF0w-1 X-Mimecast-MFC-AGG-ID: K2WoyBpVNrqh2xTuXPJF0w_1769081521 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: Fabiano Rosas , Laurent Vivier , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , richard.henderson@linaro.org Subject: [PATCH 2/4] ui/dbus: fix leak regression Date: Thu, 22 Jan 2026 15:31:41 +0400 Message-ID: <20260122113144.2046899-3-marcandre.lureau@redhat.com> In-Reply-To: <20260122113144.2046899-1-marcandre.lureau@redhat.com> References: <20260122113144.2046899-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.069, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1769081577644154100 From: Marc-Andr=C3=A9 Lureau For some reason, during refactoring, an extra reference leak was introduced. Fixes: commit 7945576cf2 ("ui/dbus: factor out sending a scanout") Signed-off-by: Marc-Andr=C3=A9 Lureau --- ui/dbus-listener.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ui/dbus-listener.c b/ui/dbus-listener.c index 52e041edb0f..407719fc1e0 100644 --- a/ui/dbus-listener.c +++ b/ui/dbus-listener.c @@ -815,8 +815,7 @@ static void ddl_scanout(DBusDisplayListener *ddl) qemu_dbus_display1_listener_call_scanout( ddl->proxy, surface_width(ddl->ds), surface_height(ddl->ds), surface_stride(ddl->ds), surface_format(ddl->ds), v_data, - G_DBUS_CALL_FLAGS_NONE, DBUS_DEFAULT_TIMEOUT, NULL, NULL, - g_object_ref(ddl)); + G_DBUS_CALL_FLAGS_NONE, DBUS_DEFAULT_TIMEOUT, NULL, NULL, NULL); } =20 static void dbus_gfx_update(DisplayChangeListener *dcl, --=20 2.52.0 From nobody Sun Jan 25 10:17:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1769081600; cv=none; d=zohomail.com; s=zohoarc; b=PfCvZdINs8+1w91SrbptlgIhUSx14g5CQZHqcycIAp64RJq4w4ej0YMz3hLk2kIn4OZpPkL2AxWn+3ugZMJTDNeSZqmxQMy2UjQktTjp+PXXUQbqhzTW7YH3xLXViV3PN35eiobz8uJDq+L5ax+LFx6478E7YfpGlftb2PO5etQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769081600; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=djthdnav+88HYBrzPOQFPUMPX/KCmxP41g/8I8VobCs=; b=nGtFfshwVggoqQqkGzbUwxAbqdYGjaa/M6eM0JhromK0r2tuQZi0Es+lpDX/kX+xKUzwyVH64vOxwMZ0mT3JKU+cDvq1jVTVKbOkVS1ug0ypv+hY6kgY7tmJ9Fg+hcUee6z5w6Y02+Df/Esi2Mxrot9nhInD5e6UNsgAfBI2dwA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1769081600232425.62812063401554; Thu, 22 Jan 2026 03:33:20 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1visvL-0004ex-9e; Thu, 22 Jan 2026 06:32:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1visvA-0004cK-W3 for qemu-devel@nongnu.org; Thu, 22 Jan 2026 06:32:18 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1visv5-0007Yz-Pf for qemu-devel@nongnu.org; Thu, 22 Jan 2026 06:32:13 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-602-2fWNiqSPMw-EDoErB8-MBw-1; Thu, 22 Jan 2026 06:32:07 -0500 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EC8B31955D84; Thu, 22 Jan 2026 11:32:06 +0000 (UTC) Received: from localhost (unknown [10.45.242.5]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id AF06B1956095; Thu, 22 Jan 2026 11:32:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769081531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=djthdnav+88HYBrzPOQFPUMPX/KCmxP41g/8I8VobCs=; b=NOQX+8fWYA5TGC+B2icDDBSaV3CsKGOSTCGkW8ZLGySQXRutyJ9S2YuV5+MIsBMp6NQiVC yTZmemT2vuUUW8xjsSvpfuvRicwOBEiYBb1nHuekwcfzkWTZ4N+mfnFVQYrBvRrD7BLalI JBWUiDq7hGxpwUNsYeWcith6DOwC7qw= X-MC-Unique: 2fWNiqSPMw-EDoErB8-MBw-1 X-Mimecast-MFC-AGG-ID: 2fWNiqSPMw-EDoErB8-MBw_1769081527 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: Fabiano Rosas , Laurent Vivier , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , richard.henderson@linaro.org Subject: [PATCH 3/4] ui/dbus: fix Unix.Map proxy leak Date: Thu, 22 Jan 2026 15:31:42 +0400 Message-ID: <20260122113144.2046899-4-marcandre.lureau@redhat.com> In-Reply-To: <20260122113144.2046899-1-marcandre.lureau@redhat.com> References: <20260122113144.2046899-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.069, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1769081602770158500 From: Marc-Andr=C3=A9 Lureau Fixes: commit 48b7ef0f0 ("ui/dbus: implement Unix.Map") Signed-off-by: Marc-Andr=C3=A9 Lureau --- ui/dbus-listener.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/dbus-listener.c b/ui/dbus-listener.c index 407719fc1e0..46264839d86 100644 --- a/ui/dbus-listener.c +++ b/ui/dbus-listener.c @@ -960,8 +960,8 @@ dbus_display_listener_dispose(GObject *object) g_clear_object(&ddl->conn); g_clear_pointer(&ddl->bus_name, g_free); g_clear_object(&ddl->proxy); -#ifdef WIN32 g_clear_object(&ddl->map_proxy); +#ifdef WIN32 g_clear_object(&ddl->d3d11_proxy); g_clear_pointer(&ddl->peer_process, CloseHandle); #ifdef CONFIG_PIXMAN --=20 2.52.0 From nobody Sun Jan 25 10:17:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1769081604; cv=none; d=zohomail.com; s=zohoarc; b=Oyat1bfp8arMKy90+Bi9rk7B9ZtUY/gWxqhxb5R2u+4fsAPY+r96fVDRaBNN4AT80YPPZiSbnJyAm3pDsM7t6nkeaaLELabejyFhkBznYt8zxbiNWF2vEY4E6plTi7UXR7KLLcv5J8FOmGFUhogLyUN1XUV+qhc7pqP2ZMep/ac= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769081604; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=lT0pSWUKJYeo6Hwxve6QTw6oHsq182bkkFgYYbGD+O0=; b=nDYGa0cGLwN6kPsMyKTXxlxm27pY6MbU/V07URiqaVtaQhKkNQ26Q8JLLrgSB9XF8p/hIgtBndN0/x4NLk+otwnrpmN7QZzRXd8dYVcOQpW4jgJYLHGcEJrr7TNJ/H+8jUC3yfd3OkDEvOq9kUIZ7TYB/iedfnLEkBTIqVNqfGk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1769081604413180.85501216569946; Thu, 22 Jan 2026 03:33:24 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1visvM-0004fO-9T; Thu, 22 Jan 2026 06:32:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1visvC-0004co-8g for qemu-devel@nongnu.org; Thu, 22 Jan 2026 06:32:18 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1visv9-0007ZM-LN for qemu-devel@nongnu.org; Thu, 22 Jan 2026 06:32:17 -0500 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-224-8TzF0bhBNUynPRRro2ZlYQ-1; Thu, 22 Jan 2026 06:32:13 -0500 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A879C19775A5; Thu, 22 Jan 2026 11:32:12 +0000 (UTC) Received: from localhost (unknown [10.45.242.5]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5CA451958DC1; Thu, 22 Jan 2026 11:32:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769081535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lT0pSWUKJYeo6Hwxve6QTw6oHsq182bkkFgYYbGD+O0=; b=aTbZaIZE10J7MeqLCDRn0bBzuqdaxl25Vlx0HCmmFSBCce3GdSnesytWvmJBv2SDwbsHXz OgVtRUgwsiuKz+edfY3rDfAVSG4L+PZE6Klxsu79c6jVIB4ManVi7g0p8jdKQsamEw0oJN ipMMSzfPBl0m1DqX34L5XDK+8tkeutM= X-MC-Unique: 8TzF0bhBNUynPRRro2ZlYQ-1 X-Mimecast-MFC-AGG-ID: 8TzF0bhBNUynPRRro2ZlYQ_1769081532 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: Fabiano Rosas , Laurent Vivier , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , richard.henderson@linaro.org Subject: [PATCH 4/4] ui/dbus: fix pixman cleanup Date: Thu, 22 Jan 2026 15:31:43 +0400 Message-ID: <20260122113144.2046899-5-marcandre.lureau@redhat.com> In-Reply-To: <20260122113144.2046899-1-marcandre.lureau@redhat.com> References: <20260122113144.2046899-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.069, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1769081606664158500 From: Marc-Andr=C3=A9 Lureau Moved pixman_region32_fini() outside the WIN32 block so it's called on all platforms. Fixes: commit 7007e98c ("ui/dbus: implement damage regions for GL") Signed-off-by: Marc-Andr=C3=A9 Lureau --- ui/dbus-listener.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ui/dbus-listener.c b/ui/dbus-listener.c index 46264839d86..3e2b4adf41f 100644 --- a/ui/dbus-listener.c +++ b/ui/dbus-listener.c @@ -964,15 +964,15 @@ dbus_display_listener_dispose(GObject *object) #ifdef WIN32 g_clear_object(&ddl->d3d11_proxy); g_clear_pointer(&ddl->peer_process, CloseHandle); -#ifdef CONFIG_PIXMAN - pixman_region32_fini(&ddl->gl_damage); -#endif #ifdef CONFIG_OPENGL egl_fb_destroy(&ddl->fb); #endif #else /* !WIN32 */ g_clear_object(&ddl->scanout_dmabuf_v2_proxy); #endif +#ifdef CONFIG_PIXMAN + pixman_region32_fini(&ddl->gl_damage); +#endif =20 G_OBJECT_CLASS(dbus_display_listener_parent_class)->dispose(object); } --=20 2.52.0