From nobody Mon Feb 9 18:19:32 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1768858172; cv=none; d=zohomail.com; s=zohoarc; b=WJkgZf3GN2BjoWlOIryVzMkdsWdIuLa+hywqQHDWx/J/Y1sFnBNHX6OMDfrt9BuGOLQ4sN3bdcTJ6cBAiwIHBi82xJV/kGiwhQos3mLMX+YkW6BWlDeHVNnRuDIs1GsixpsjcDhtB+pWjLgmBpwwreCDHRyp9WIeDnp0nyRFlfg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768858172; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=cR1bx12OXu3nStDdkuzRGnrZ6iRvLEcTJdsI9jTbcY0=; b=cDCoODjx6C8KN8Qa0gBeabvdxtx8F+W/Ks/e2VtdYeTh8gm2d2xz178/20Ch3wsibPP3717g82C+ckN4dSK0MneOwl74j+mdl5ODg513ogYrkR4lYIhYNUjObttdsKY+2Fz10CimlV2iweSFVNj4Hp9ZJIE5dTLsuidQA6mTgTE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768858172120141.29345488145668; Mon, 19 Jan 2026 13:29:32 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vhwoS-0003UD-PB; Mon, 19 Jan 2026 16:29:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vhwo0-0002oG-BZ for qemu-devel@nongnu.org; Mon, 19 Jan 2026 16:29:01 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vhwny-0008HL-QA for qemu-devel@nongnu.org; Mon, 19 Jan 2026 16:29:00 -0500 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-664-9OGVseYoO72200ClRHASxA-1; Mon, 19 Jan 2026 16:28:55 -0500 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E5E361954B0C; Mon, 19 Jan 2026 21:28:52 +0000 (UTC) Received: from jsnow-thinkpadp16vgen1.westford.csb (unknown [10.22.64.170]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 96D4A19560AB; Mon, 19 Jan 2026 21:28:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768858138; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cR1bx12OXu3nStDdkuzRGnrZ6iRvLEcTJdsI9jTbcY0=; b=KMdwQ/kaqpGRbOJDPwxHncySbNujMN23VqPiXN0avxHx2/yVlVTxYEVvFxZdXC0iIqiz2H D6Ye1jYJs2p6RNVoPg87s+KPb9JG8v4ycsMwQhZk9uM3rSB6/rC0HIOxyhXRLCe026+4DQ suCZPSaItxIjLL9RdWWjPRT1fMCRGKY= X-MC-Unique: 9OGVseYoO72200ClRHASxA-1 X-Mimecast-MFC-AGG-ID: 9OGVseYoO72200ClRHASxA_1768858133 From: John Snow To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Vladimir Sementsov-Ogievskiy , Kevin Wolf , Maksim Davydov , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Li-Wen Hsu , Markus Armbruster , Thomas Huth , John Snow , Mauro Carvalho Chehab , Hanna Reitz , Cleber Rosa , Michael Roth , Yonggang Luo , Ed Maste , Peter Xu , Fabiano Rosas , Paolo Bonzini , qemu-block@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [PATCH v4 12/17] configure: unconditionally install "tooling" group Date: Mon, 19 Jan 2026 16:27:38 -0500 Message-ID: <20260119212744.1275455-13-jsnow@redhat.com> In-Reply-To: <20260119212744.1275455-1-jsnow@redhat.com> References: <20260119212744.1275455-1-jsnow@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.016, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1768858174268154100 Content-Type: text/plain; charset="utf-8" Alongside meson, always ensure our in-tree tooling group and its out-of-tree dependency, qemu.qmp, is always installed. As a result, several "check-venv" invocations can be removed from various testing scripts. Signed-off-by: John Snow Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Thomas Huth --- configure | 2 +- .gitlab-ci.d/buildtest.yml | 2 -- scripts/device-crash-test | 3 +-- 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/configure b/configure index e69b3e474ee..d4321dd5cce 100755 --- a/configure +++ b/configure @@ -966,7 +966,7 @@ mkvenv=3D"$python ${source_path}/python/scripts/mkvenv.= py" # Finish preparing the virtual environment using vendored .whl files =20 $mkvenv ensuregroup --dir "${source_path}/python/wheels" \ - ${source_path}/pythondeps.toml meson || exit 1 + ${source_path}/pythondeps.toml meson tooling || exit 1 =20 # At this point, we expect Meson to be installed and available. # We expect mkvenv or pip to have created pyvenv/bin/meson for us. diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index b2db70ff904..1b656b9eb08 100644 --- a/.gitlab-ci.d/buildtest.yml +++ b/.gitlab-ci.d/buildtest.yml @@ -101,7 +101,6 @@ crash-test-debian: IMAGE: debian script: - cd build - - make NINJA=3D":" check-venv - ./run scripts/device-crash-test -q --tcg-only ./qemu-system-i386 =20 build-system-fedora: @@ -158,7 +157,6 @@ crash-test-fedora: IMAGE: fedora script: - cd build - - make NINJA=3D":" check-venv - ./run scripts/device-crash-test -q ./qemu-system-ppc - ./run scripts/device-crash-test -q ./qemu-system-riscv32 =20 diff --git a/scripts/device-crash-test b/scripts/device-crash-test index 8a91dcaee31..fc86babdf43 100755 --- a/scripts/device-crash-test +++ b/scripts/device-crash-test @@ -40,8 +40,7 @@ try: except ModuleNotFoundError as exc: path =3D Path(__file__).resolve() print(f"Module '{exc.name}' not found.") - print(" Try 'make check-venv' from your build directory,") - print(" and then one way to run this script is like so:") + print(" Try running this script like so:") print(f' > $builddir/run "{path}"') sys.exit(1) =20 --=20 2.52.0