From nobody Tue Feb 10 10:03:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1768849978; cv=none; d=zohomail.com; s=zohoarc; b=WHZkPRfegHezhMUT404ORq9lqDKLpPUME7qBNfa1msHzsePw7RKvGF0w3/9CzbyRym1Zuixwbyr9xLBnYVekU4pk4SicGMw+tEn5ImhBq4RGb9DuFH3Joprsqz3xtR/Obv6luMMN0ASEkpK60ppn2th0pClk6ow3w38JQsBh2yg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768849978; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=BAwgkxcCnnqe9jCM08ttRZ7hAqumVGJ7T0ER05F6LwQ=; b=gJyhnDaG55mRsO8Z0Apv6lIeId99Yt10G45xzc/f0VhteGtIdKlj/aSjC++I4qTeVY2eqSMZIizXgDAfMO5IZFT/p0tKRSJyWMyh8gewBK/9VvU9gGlv14km7geaLUwA0i//PmNpsVr8aDiHGHykAYpWxOdFzaQgAbIymi3ZC94= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768849978563259.18473464380975; Mon, 19 Jan 2026 11:12:58 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vhufQ-0006rK-1Z; Mon, 19 Jan 2026 14:12:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vhufN-0006pK-1o for qemu-devel@nongnu.org; Mon, 19 Jan 2026 14:11:57 -0500 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vhufL-0001Uh-2s for qemu-devel@nongnu.org; Mon, 19 Jan 2026 14:11:56 -0500 Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-2a0bae9aca3so30439535ad.3 for ; Mon, 19 Jan 2026 11:11:54 -0800 (PST) Received: from pc.taild8403c.ts.net (216-71-219-44.dyn.novuscom.net. [216.71.219.44]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a719415f0asm47011795ad.89.2026.01.19.11.11.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 11:11:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768849913; x=1769454713; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BAwgkxcCnnqe9jCM08ttRZ7hAqumVGJ7T0ER05F6LwQ=; b=f5f1N0879vdmzEt8fX7HzriwVfPEhS8dbll++v6qOS5CD8VIE5tE5pOrS50cWirEfU rpKhO4KvnKwtVl4I/AsTX3yvotR5KSyTFbfiwanY1yVGwcUbEpg2sGBhAgkRJYZoqJjq WD4hCJiwadl4VLfpujHoyIdfOGrZ8HI51lTxe2jnaYovCViyPva1dgbrO5qLwu3Xv+yi Tnn40upEyDkBmRRR3O1N7kt/B2sc5xqv7lzEuxuxSQOj3l7yJ2/MIaU3H80H9IYBgusu zqO78dt1KZotAPWABHlOEyRf9cDwP/S3vjHSCCmAgiM7XEsS7npX4A6AMqFKw4nViQgQ ynjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768849913; x=1769454713; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BAwgkxcCnnqe9jCM08ttRZ7hAqumVGJ7T0ER05F6LwQ=; b=Ab0k89rkXTt7b7k4JfkWBGsq1sdgv4L8XLl8HkNR7ty6AumjC0Mq0MdifJvNP1x7Q1 08GWwnd3bwD+UnT87GwSzfBiBdehhGBhr3bXwN1w2wfy3xEmDuK3k3sYb+NOwE4mZDNG H93jpI7Ww3hVgxr8E7AzxPJu4xYOX9xa6D0R0qyl4wa1w9CC594YaETxeDjdFY7ALpOB aD5sy0QvsyfgEKvuID8OnSEBGCQUubQt76vkJAHoj7GpvoD1YgJAfVr52geB3zvmhWjM BDEZOvxCeNrElU1loBf61bDWHZHplCjZDUTJl3hbPGN1mANEmN2kKhQr586QvGiWaCuL wBjQ== X-Gm-Message-State: AOJu0YxnYrw7LO8B+GnzzE2tFKICajCPRo2YfsQPO/EhMlMKf49YPRHm iHPUJpDIwHX/a98HSMFuCmoFAWo5zBD2tucdo6vR9p4aWTgYHpj+qcoFkoiy6xJeXrYncLNNKab P6fwA X-Gm-Gg: AZuq6aKmkhSmkBnVHW/yPa+fpRb+eGAwc8hPSvobDQTVgLpZc9hyxtdA7MJzQ+UdHAE oRHBgENr8rHTA2cSf3xAjVfTdv5haNwBtEWREpF4lG9XYRMJbx7YfRKIqFpRs3Qi92vyiNeLw7p h2g78I/Fp72es7pDqJ4y8supFkXs5r2Vk+2AgSIzUp9jn29yLd73sJ4yz1UNq81en16sGsaLvts VDreMIsdLKBOw1NUhv7lNls0srFNerUxc+K0/lh6h7rTxNFHvP4kTfVbIGKlBqHepW4ygxpuPYg Z7zXv/b/+zDeAHSxCIo4JVdCd49LCPBUkCNPRMq4Fx33z7pjLa+qOMCNvvGLYe5e7RLNReTyNjc 2N0tFl3UusQoIeFJoHVhVIp8eBDWoLz0ymLBCVYstXWMAqs2GvlnIIhI6oWb+N2mXPjTtu+BCqD OjRLBd6/mqsMa1uYUlgW51Vd85d8JqSiR/B4DuqcG724JGjUSRR4vnw68iLFO+MZ+kOYiYH724e 4M= X-Received: by 2002:a17:903:11cc:b0:298:2616:c8e2 with SMTP id d9443c01a7336-2a7177d6fbbmr110460095ad.53.1768849913395; Mon, 19 Jan 2026 11:11:53 -0800 (PST) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Mahmoud Mandour , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Manos Pitsidianakis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson , Paolo Bonzini , Alexandre Iooss , Kostiantyn Kostiuk , Michael Roth , Gustavo Bueno Romero , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Pierrick Bouvier Subject: [PATCH v3 09/11] qga/vss-win32: fix clang warning with C++20 Date: Mon, 19 Jan 2026 11:11:35 -0800 Message-ID: <20260119191138.811069-10-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260119191138.811069-1-pierrick.bouvier@linaro.org> References: <20260119191138.811069-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::634; envelope-from=pierrick.bouvier@linaro.org; helo=mail-pl1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1768849979642158500 Content-Type: text/plain; charset="utf-8" C++20 deprecated such constructs. ../qga/vss-win32/requester.cpp:380:32: error: bitwise operation between dif= ferent enumeration types ('_VSS_SNAPSHOT_CONTEXT' and '_VSS_VOLUME_SNAPSHOT= _ATTRIBUTES') is deprecated [-Werror,-Wdeprecated-enum-enum-conversion] 380 | ctx =3D VSS_CTX_APP_ROLLBACK | VSS_VOLSNAP_ATTR_TRANSPORTABLE | This is a false positive, since VSS_CTX_APP_ROLLBACK is not a value defined in _VSS_VOLUME_SNAPSHOT_ATTRIBUTES enum. Reviewed-by: Manos Pitsidianakis Signed-off-by: Pierrick Bouvier --- qga/vss-win32/requester.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp index 5615955b6f3..74489fcd0ae 100644 --- a/qga/vss-win32/requester.cpp +++ b/qga/vss-win32/requester.cpp @@ -377,8 +377,10 @@ void requester_freeze(int *num_vols, void *mountpoints= , ErrorSet *errset) * To prevent the final commit (which requires to write to snapshots), * ATTR_NO_AUTORECOVERY and ATTR_TRANSPORTABLE are specified here. */ - ctx =3D VSS_CTX_APP_ROLLBACK | VSS_VOLSNAP_ATTR_TRANSPORTABLE | - VSS_VOLSNAP_ATTR_NO_AUTORECOVERY | VSS_VOLSNAP_ATTR_TXF_RECOVERY; + ctx =3D VSS_CTX_APP_ROLLBACK; + ctx |=3D VSS_VOLSNAP_ATTR_TRANSPORTABLE | + VSS_VOLSNAP_ATTR_NO_AUTORECOVERY | + VSS_VOLSNAP_ATTR_TXF_RECOVERY; hr =3D vss_ctx.pVssbc->SetContext(ctx); if (hr =3D=3D (HRESULT)VSS_E_UNSUPPORTED_CONTEXT) { /* Non-server version of Windows doesn't support ATTR_TRANSPORTABL= E */ --=20 2.47.3