From nobody Mon Feb 9 08:20:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1768543430; cv=none; d=zohomail.com; s=zohoarc; b=cgpVCc+VTXig+ZsJnarexvqCu/bPuYbVKpLQr2orgTi98YEtBFbNH0RddKZG+sLt3U4Ny9Rkono3e2yW/lMFb1y4/L8dyF7x8DUorMIYNoPT/yrigTelje1OhjMgj7JwWFU1lDb+NHQBhwVaTZ4jV2UYayVERWi4tQFFAw0tjCw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768543430; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=OYfGzhztzSmTeVuhj2Y/nOy/JesEf8eTmqMCp9bZFvM=; b=d4gr1e5Kkzx+UXdFqC4dgk3POMvom5rvDb4CQ/sC4b+bMQIjHCZXJ7wJ94PBPEq0U7l4AYshdVk+5DIgLjqoMZRtpWNrEu+HnqUVxWv4c4GJF65JHeOtkAI2LMMCMP27L9EtV+O2WAFH3FakQJ9HbL0L8rQB60YVX7cW8ttz1Og= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17685434305835.283726422373775; Thu, 15 Jan 2026 22:03:50 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vgcvr-0007IX-NN; Fri, 16 Jan 2026 01:03:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vgcvp-0007Fx-6O for qemu-devel@nongnu.org; Fri, 16 Jan 2026 01:03:37 -0500 Received: from mgamail.intel.com ([192.198.163.10]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vgcvn-0008Pp-0G for qemu-devel@nongnu.org; Fri, 16 Jan 2026 01:03:36 -0500 Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jan 2026 22:03:31 -0800 Received: from unknown (HELO gnr-sp-2s-612.sh.intel.com) ([10.112.230.229]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jan 2026 22:03:29 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1768543415; x=1800079415; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=qfzWsW5hcNYwh342rAtckBYgSg+g62JfKIiycmKaqmU=; b=heXC4mF0/gAQSb+Lul7nJI9uo9OAT2mJK87CN4VeuuQ5nGVv5LsA4J6T lAw8FpPNoTir7+PnhX3TxEHwEyo1LEXBn3lZTu5ejAmRGuT98qrkCi6oH ZhjQ2QRUTs2fgAYEzNRS5MADSJKXt4cWqzWLaEEEhY57yE5QNoAjpI8pw jpkNUOIzzbmfmvoBm7m4jQNaqEMiYzU33+blJu7CCnlY8pgJtVHXHcvJa EW5khAELvm7fsWexsbCYBwY0GJL6YvWmPNMvT04YF7zAke7YVkJI5wKQ4 BUagkQckG2ksNaQXRwnSios/VveY/s9x9tAYqpMnr7vx9A2YWxbcSWWWb A==; X-CSE-ConnectionGUID: lIGVKRzeQy+8Q62c58Kfhw== X-CSE-MsgGUID: TEhhjMQhRp+Zz1WsZw5FDg== X-IronPort-AV: E=McAfee;i="6800,10657,11672"; a="81223333" X-IronPort-AV: E=Sophos;i="6.21,230,1763452800"; d="scan'208";a="81223333" X-CSE-ConnectionGUID: XDsNYSEhTe+vaeOttPoB3A== X-CSE-MsgGUID: Fb1IaSFsSH20YA4oaOMGMQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,230,1763452800"; d="scan'208";a="204361397" From: Zhenzhong Duan To: qemu-devel@nongnu.org Cc: alex@shazbot.org, clg@redhat.com, Zhenzhong Duan Subject: [PATCH] vfio/migration: Fix page size calculation Date: Fri, 16 Jan 2026 01:03:15 -0500 Message-ID: <20260116060315.65723-1-zhenzhong.duan@intel.com> X-Mailer: git-send-email 2.47.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=192.198.163.10; envelope-from=zhenzhong.duan@intel.com; helo=mgamail.intel.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1768543433236158500 Coverity detected an issue of left shifting int by more than 31 bits leading to undefined behavior. In practice bcontainer->dirty_pgsizes always have some common page sizes when dirty tracking is supported. Resolves: Coverity CID 1644186 Resolves: Coverity CID 1644187 Resolves: Coverity CID 1644188 Fixes: 46c763311419 ("vfio/migration: Add migration blocker if VM memory is= too large to cause unmap_bitmap failure"). Suggested-by: C=C3=A9dric Le Goater Signed-off-by: Zhenzhong Duan Reviewed-by: C=C3=A9dric Le Goater --- hw/vfio/migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c index f857dc25ed..b4695030c7 100644 --- a/hw/vfio/migration.c +++ b/hw/vfio/migration.c @@ -1173,7 +1173,7 @@ static bool vfio_dirty_tracking_exceed_limit(VFIODevi= ce *vbasedev) * can also switch to use IOMMUFD backend if there is a need to migrate * large VM. */ - page_size =3D 1 << ctz64(bcontainer->dirty_pgsizes); + page_size =3D 1ULL << ctz64(bcontainer->dirty_pgsizes); max_size =3D bcontainer->max_dirty_bitmap_size * BITS_PER_BYTE * page_= size; =20 return current_machine->ram_size > max_size; --=20 2.47.1