From nobody Tue Feb 10 09:58:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1768488469; cv=none; d=zohomail.com; s=zohoarc; b=PYP1oiGkvNJkt3rdUOKuGyJx4PpN14AI9RVrNXvtlV5qlQcb6ve1eQKOLMsGSQnpUj4/vkG9dUwAtQ6a55i0AU+J61B5n1018GvCTo1h9uQ69JqJA0SGblk6xcS+8u+1LtCbJ8I/hzJdhiXJ7Zi/nP9VBb2rZqwmXeRvO9X+bG4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768488469; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=H/bX/Anw/6rlKINMAotFT7jwt9W/yiN609ztiVY5So0=; b=jhAFAnAcZT49MwBb9OyUUpxljf6fwRH3iahz7LuNGyQnghZPwFuYi/mOOPluaz7IHSVbP9ytnewkRStyfir88JIF1Wv2Zq7yoWbJBYupr2IEasfdX46PNdfr4vEhCnv7dCMUXw6g19G35mG7nvTg+dm/NWfzxqSE7pJSM4jYTzY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768488468949715.5153971063613; Thu, 15 Jan 2026 06:47:48 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vgOcq-0005aG-E1; Thu, 15 Jan 2026 09:47:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vgOcH-0004kF-Rf for qemu-devel@nongnu.org; Thu, 15 Jan 2026 09:46:43 -0500 Received: from forwardcorp1a.mail.yandex.net ([178.154.239.72]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vgOcC-0002rc-On for qemu-devel@nongnu.org; Thu, 15 Jan 2026 09:46:28 -0500 Received: from mail-nwsmtp-smtp-corp-main-66.iva.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-66.iva.yp-c.yandex.net [IPv6:2a02:6b8:c0c:bca6:0:640:3d05:0]) by forwardcorp1a.mail.yandex.net (Yandex) with ESMTPS id 54D4EC0209; Thu, 15 Jan 2026 17:46:21 +0300 (MSK) Received: from vsementsov-lin (unknown [2a02:6bf:8080:b8d::1:8]) by mail-nwsmtp-smtp-corp-main-66.iva.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id 8kWwj30BHuQ0-7J5TUSWO; Thu, 15 Jan 2026 17:46:20 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1768488380; bh=H/bX/Anw/6rlKINMAotFT7jwt9W/yiN609ztiVY5So0=; h=Cc:Message-ID:References:Date:In-Reply-To:Subject:To:From; b=P3g4qcF8Xf+23YP2Pfee4p+CWC25kcw5+HMDhl4Bnex7exHTKkgUDeno9eqnxXssJ i9+XJjFgFQbD83QLU/Pnb39zW1mJNtY3/Mb0n4XF7RiG++3vBThhedK+90N8+tMAaA 4ttB/bWQMba68lcbEI/OjCdJIhwB2utL4armwJ2c= Authentication-Results: mail-nwsmtp-smtp-corp-main-66.iva.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: marcandre.lureau@redhat.com Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, vsementsov@yandex-team.ru, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 10/10] chardev/char: qemu_char_open(): add return value Date: Thu, 15 Jan 2026 17:46:04 +0300 Message-ID: <20260115144606.233252-11-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260115144606.233252-1-vsementsov@yandex-team.ru> References: <20260115144606.233252-1-vsementsov@yandex-team.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=178.154.239.72; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1a.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1768488470957158500 Accordingly with recommendations in include/qapi/error.h accompany errp by boolean return value and get rid of error propagation. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau --- chardev/char.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/chardev/char.c b/chardev/char.c index ef0cdffd3f..5bda43c6e7 100644 --- a/chardev/char.c +++ b/chardev/char.c @@ -246,7 +246,7 @@ int qemu_chr_add_client(Chardev *s, int fd) CHARDEV_GET_CLASS(s)->chr_add_client(s, fd) : -1; } =20 -static void qemu_char_open(Chardev *chr, ChardevBackend *backend, Error **= errp) +static bool qemu_char_open(Chardev *chr, ChardevBackend *backend, Error **= errp) { ChardevClass *cc =3D CHARDEV_GET_CLASS(chr); /* Any ChardevCommon member would work */ @@ -262,13 +262,15 @@ static void qemu_char_open(Chardev *chr, ChardevBacke= nd *backend, Error **errp) } chr->logfd =3D qemu_create(common->logfile, flags, 0666, errp); if (chr->logfd < 0) { - return; + return false; } } =20 - if (cc->chr_open) { - cc->chr_open(chr, backend, errp); + if (!cc->chr_open) { + return true; } + + return cc->chr_open(chr, backend, errp); } =20 static void char_init(Object *obj) @@ -1006,7 +1008,6 @@ static Chardev *chardev_new(const char *id, const cha= r *typename, { Object *obj; Chardev *chr =3D NULL; - Error *local_err =3D NULL; =20 assert(g_str_has_prefix(typename, "chardev-")); assert(id); @@ -1017,9 +1018,7 @@ static Chardev *chardev_new(const char *id, const cha= r *typename, chr->label =3D g_strdup(id); chr->gcontext =3D gcontext; =20 - qemu_char_open(chr, backend, &local_err); - if (local_err) { - error_propagate(errp, local_err); + if (!qemu_char_open(chr, backend, errp)) { object_unref(obj); return NULL; } --=20 2.52.0