From nobody Mon Feb 9 09:21:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1768476906; cv=none; d=zohomail.com; s=zohoarc; b=lZZsGCYoIPeITpPEF6MoBqd2FTJrZrpP4yDLhVSgIpHyp/EcvWu2OOdq1pDwvTEfbGjJ5GKF0/zXVuaMUvU///pEQ5bksYnhWxXZhESKE2qPuuHhS7558/GLBXCfILlip+7SD7/OTfK/o/TynuuNXLYIsdXAHuYLeiQrpQJ3Zzw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768476906; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=WtT97AhDNUhLb3iJdTChN/XGeNrYbFEBZVOX0BIlrhk=; b=erJdrK4zRcAyGrToPR3hAZUGLUPIr4ZYNCK9RcsyfHbCwAlbJzAgBkFuAY4kXSp3iPSjLuuxieoNJVxA+swODUq4fY1tFmI6aqkVwo9TO3XQSi+4SHtzm69hx9FdGsx0kxuNuFTuF0TI111hB82Ee5NLv4qhLbsC6GjaJHG9gJA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768476906500181.74997751462; Thu, 15 Jan 2026 03:35:06 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vgLbg-0002i8-VK; Thu, 15 Jan 2026 06:33:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vgLbT-0001rD-Oi for qemu-devel@nongnu.org; Thu, 15 Jan 2026 06:33:31 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vgLbS-0003yy-9e for qemu-devel@nongnu.org; Thu, 15 Jan 2026 06:33:27 -0500 Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-246-LTd4-1GdOper9F1NIk3pHQ-1; Thu, 15 Jan 2026 06:33:16 -0500 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-430fdc1fff8so480728f8f.3 for ; Thu, 15 Jan 2026 03:33:16 -0800 (PST) Received: from [192.168.10.48] ([151.61.26.160]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-434af6d9039sm5479938f8f.30.2026.01.15.03.33.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 03:33:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768476801; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WtT97AhDNUhLb3iJdTChN/XGeNrYbFEBZVOX0BIlrhk=; b=TBfxLzcEEgiCAlSNSt9ygS9n5FeaVIpUzhWvV7zkvTZQERRKRa0yaKamgAv5lnYdhjTygE mSOGD5B2Zt9Gq1x/bNaLsqfPdtOHjsd5fW3a4g+4Q88Ct5xF4dpk3SX7lvN8Hl2wFhDpFY 9szBTDGTCYCOeC7VztL00lmOjQyIJ34= X-MC-Unique: LTd4-1GdOper9F1NIk3pHQ-1 X-Mimecast-MFC-AGG-ID: LTd4-1GdOper9F1NIk3pHQ_1768476792 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768476791; x=1769081591; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WtT97AhDNUhLb3iJdTChN/XGeNrYbFEBZVOX0BIlrhk=; b=oQiDNGkRomdXsomp6WoBhg177qHPRg4KVntpUDkA/HOVgFrMAzpGaPzVS8TvqbBnJz a+qjaRFIS/MYdJ7RtcU+x7N4SJjY03OHw9pQVSEsI88CYXih+H0+6QPHmPtgE2dX5Kfq sjcnF1ebK+NvVh+QQ6HVE+Sbyg1jn6qxSbeyNJV/SArBz5dwp+np6PN6DM3Cxe5r4b5R uoDk5po/Sp+Tr2PhrwhZL58M0fpfJCnRhX5aQDYZT5PAWU/z63dyIAPaVGz/ZA20w9g4 QP5pwvu1hv0wE44MCYjVX6wlQ0lymJtIECp37jxCaOHrWl60gOH2monePJE2K/B1cn7e 2Z9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768476791; x=1769081591; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WtT97AhDNUhLb3iJdTChN/XGeNrYbFEBZVOX0BIlrhk=; b=VXEg9zuXgcjzz0VlZHrC1ZVturcLDogqvNUUB/871wniXv1Rw9+wwxSCrCcBi5XStY Ty/LHnZQSS27DndEPNCGghFGUzApnwfHPJHJRBdTVRSL1i6gxTz4HTfZDtCmPpawyMv2 zOC+kuqQ+8IDThS3vn5aqVOlhVy5zZH8TysMtrQ+CZQIQKqBk10HYuY1Wbu6WOvGBCE6 7bxe4k86io52G/JihZJG20fs/TMraHaAwDVcZuxhiO8a3+/IO/OIcyxGVC8xOO7nKVLF 3IhwzjirA+F/tI2Mz8Pp3nrjGPiW61GMsfoxA2ghRu1qehdwdzvlrUyvSbK7rACX2937 GW9w== X-Gm-Message-State: AOJu0Yz2BnJ6Ghn21qtLKOhVj51wZhIAuvkW+KjvkpGQcj/V/pzT/UJ1 ZzNcvzY7UCiFcJzvoVVXPYMapkXNqnS+EOeHMjag4XHeRfE2RiXUG+mjc3yai5IVsjHiUpktDqZ zc7YaI530y8PcJ5BgxTk0sdVIoOmvks3SaLW+J4zwGvPesVJeeRqASzfUzNscJdZgT5SnRCUiSo MskFeB5SivTi/XuF/qVfl5mon5Q6iKxPg+ZNWNtODX X-Gm-Gg: AY/fxX4cc/5jxzypTs6G0VDGhw1QbQImFBEP8gIq3tZhn406J9jmA/O5gqm67gGXvHg Wtlj4xW86vSdyzdnDHEp0fW9oraCug7bka5/lxFoItTWptNxIs0+mloaBDo3YSwe6f3ICJeKwjr pGQbBK+flAzuHFZocmr1gDgcKjqT6ypqyDROO4kVNwj1+CQg7uld/1MlLYf1+2IDVDie1Xlucwi gZpycBS6cn+YZaca5X8/ed7Bd3I41WIL2nDfyMhhepg14jJ9lp0Nv0WoMSD4ZJaIV6yeBgZFY0y Xvu3jIlivu32iIxvYs1TxoM0vLgMHPVHjCEtwaDaFAqoYujPoS7b2E+iXvCCganyIW6ndAxv2Jt lGtY6jIi9OqpNB/FdDid1htvEZewN5e8c9UYwzT0WoDtMr4WmAbWFN53bh//btdFL8RwdWMwoZT I+7HuE2JeDIOx0Pw== X-Received: by 2002:a05:6000:3106:b0:42f:bab5:9533 with SMTP id ffacd0b85a97d-4342c4f9c46mr6929830f8f.17.1768476790693; Thu, 15 Jan 2026 03:33:10 -0800 (PST) X-Received: by 2002:a05:6000:3106:b0:42f:bab5:9533 with SMTP id ffacd0b85a97d-4342c4f9c46mr6929790f8f.17.1768476790193; Thu, 15 Jan 2026 03:33:10 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: richard.henderson@linaro.org, qemu-stable@nongnu.org Subject: [PATCH 1/6] target/i386/tcg: fix a few instructions that do not support VEX.L=1 Date: Thu, 15 Jan 2026 12:33:01 +0100 Message-ID: <20260115113306.126905-2-pbonzini@redhat.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260115113306.126905-1-pbonzini@redhat.com> References: <20260115113306.126905-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1768476907645158500 Content-Type: text/plain; charset="utf-8" Match the contents of table 2-17 ("#UD Exception and VEX.L Field Encoding") in the SDM, for instruction in exception class 5. They were incorrectly accepting 256-bit versions that do not exist. Cc: qemu-stable@nongnu.org Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson --- target/i386/tcg/decode-new.c.inc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/i386/tcg/decode-new.c.inc b/target/i386/tcg/decode-new.= c.inc index 09e3d8884cf..e44b92710cf 100644 --- a/target/i386/tcg/decode-new.c.inc +++ b/target/i386/tcg/decode-new.c.inc @@ -628,7 +628,7 @@ static void decode_0F7E(DisasContext *s, CPUX86State *e= nv, X86OpEntry *entry, ui static const X86OpEntry opcodes_0F7E[4] =3D { X86_OP_ENTRY3(MOVD_from, E,y, None,None, P,y, vex5 mmx), X86_OP_ENTRY3(MOVD_from, E,y, None,None, V,y, vex5), - X86_OP_ENTRY3(MOVQ, V,x, None,None, W,q, vex5), /* wrong de= st Vy on SDM! */ + X86_OP_ENTRY3(MOVQ, V,dq,None,None, W,q, vex5), /* wrong de= st Vq on SDM! */ {}, }; *entry =3D *decode_by_prefix(s, opcodes_0F7E); @@ -693,7 +693,7 @@ static void decode_0FD6(DisasContext *s, CPUX86State *e= nv, X86OpEntry *entry, ui { static const X86OpEntry movq[4] =3D { {}, - X86_OP_ENTRY3(MOVQ, W,x, None, None, V,q, vex5), + X86_OP_ENTRY3(MOVQ, W,dq, None, None, V,q, vex5), X86_OP_ENTRY3(MOVq_dq, V,dq, None, None, N,q), X86_OP_ENTRY3(MOVq_dq, P,q, None, None, U,q), }; @@ -1102,7 +1102,7 @@ static void decode_0F12(DisasContext *s, CPUX86State = *env, X86OpEntry *entry, ui }; static const X86OpEntry opcodes_0F12_reg[4] =3D { X86_OP_ENTRY3(VMOVHLPS, V,dq, H,dq, U,dq, vex7), - X86_OP_ENTRY3(VMOVLPx, W,x, H,x, U,q, vex5), /* MOVLPD = */ + X86_OP_ENTRY3(VMOVLPx, W,dq, H,dq, U,q, vex5), /* MOVLPD = */ X86_OP_ENTRY3(VMOVSLDUP, V,x, None,None, U,x, vex4 cpuid(SSE3)), X86_OP_ENTRY3(VMOVDDUP, V,x, None,None, U,x, vex5 cpuid(SSE3)), }; @@ -1465,7 +1465,7 @@ static const X86OpEntry opcodes_0F[256] =3D { [0x6b] =3D X86_OP_ENTRY3(PACKSSDW, V,x, H,x, W,x, vex4 mmx avx2_256= p_00_66), [0x6c] =3D X86_OP_ENTRY3(PUNPCKLQDQ, V,x, H,x, W,x, vex4 p_66 avx2_25= 6), [0x6d] =3D X86_OP_ENTRY3(PUNPCKHQDQ, V,x, H,x, W,x, vex4 p_66 avx2_25= 6), - [0x6e] =3D X86_OP_ENTRY3(MOVD_to, V,x, None,None, E,y, vex5 mmx p_0= 0_66), /* wrong dest Vy on SDM! */ + [0x6e] =3D X86_OP_ENTRY3(MOVD_to, V,dq,None,None, E,y, vex5 mmx p_0= 0_66), /* wrong dest Vy on SDM! */ [0x6f] =3D X86_OP_GROUP0(0F6F), =20 [0x78] =3D X86_OP_GROUP0(0F78), --=20 2.52.0 From nobody Mon Feb 9 09:21:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1768476845; cv=none; d=zohomail.com; s=zohoarc; b=elRbenfOhwxhnyT6wzQgm5KDy1CAIzNvNcVT7fec+2MuLnwdx5p37k9Sy/4TONMl5jGAC9fx/YT2RjPBsVc3B7A4pJiSbrtlTBI2YWsXMdJNuujNFlo5KgC7jzp9tYvHtpS0Jtq9vL+IE0262JJyZhVeIZ7J0vsDeMILcQuWnms= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768476845; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=giKSKVqcCxHJXVRjF7LdnzruvLYzc/gtOi+ALaTIzgQ=; b=hebjObuyUpTcU9SmXyphkOHwEeCZKypnGkG5cfGGvqgu8DmnonN45bYek7O55+CIqG4LvL9GJ3Bzsrgz+t/UttnME3CAbwO0AcL/KQMtAlYAd+N86vF0VM6hEbQ9mhUCIyhcvK2ioNERbYy+4DAEJ3FgQvXx5r71wT9wd6lRHP0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768476845669508.53264322917903; Thu, 15 Jan 2026 03:34:05 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vgLbf-0002HL-44; Thu, 15 Jan 2026 06:33:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vgLbJ-0001eJ-Mo for qemu-devel@nongnu.org; Thu, 15 Jan 2026 06:33:20 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vgLbI-0003xH-BY for qemu-devel@nongnu.org; Thu, 15 Jan 2026 06:33:17 -0500 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-403-IV_uDt_hP0akAY574tsMxA-1; Thu, 15 Jan 2026 06:33:14 -0500 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-47ee1fe7b24so6972935e9.1 for ; Thu, 15 Jan 2026 03:33:14 -0800 (PST) Received: from [192.168.10.48] ([151.61.26.160]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-434af64a778sm5373995f8f.3.2026.01.15.03.33.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 03:33:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768476795; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=giKSKVqcCxHJXVRjF7LdnzruvLYzc/gtOi+ALaTIzgQ=; b=GXzX4jFR5JiHlkAgWMxrgI/rf4WFYQmEjN9s2nSFXeNHRGPpItsz6cLjUdPeEh3A4wvTHH DMip2li/l79hETVvqwZosvzOGsEXco9AdqPjeLINfyiwMGQ5Bqe5R+MztZOGcztTl556Ip sXzsbAev/nQHqkBaqc4UY40DzdDPy3w= X-MC-Unique: IV_uDt_hP0akAY574tsMxA-1 X-Mimecast-MFC-AGG-ID: IV_uDt_hP0akAY574tsMxA_1768476793 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768476792; x=1769081592; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=giKSKVqcCxHJXVRjF7LdnzruvLYzc/gtOi+ALaTIzgQ=; b=pW/PxRXqvEwr6Al+FQKfC3+56094z25qxSzdhq244UXJI/OU3TczlQ2ONO31JuYulF I7i1zpxjakQdBDkrizWA43fabXBXea1simw8GRzJ769Uc5VUELFqx0sea9Mr2Z0GJuTM GQUXuifyHh3Sp5Zna0++hs4itBbJjSjd8WARVUtMHHB+6dJLAubfSocPLMPhzWWWa2Eu +TARiYPtc7XZqqELoaVPKA9pailhkGTaP+v5ChK0a5mOalkeY7PoR3tZcg01wB3zqvr8 /Xv5aIT2zmtY1T+ey2c6UIB9A1p3MfigwzlBdUYpM9hPP0sLN7j3qHr0NVgSvg14uQ7y bRyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768476792; x=1769081592; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=giKSKVqcCxHJXVRjF7LdnzruvLYzc/gtOi+ALaTIzgQ=; b=kfKxc3mdNPP/uvExA3GXkoYZmt4P+2iUFjm4bg57n5LYGE6LjFQAnWke2EioEU77j+ vCE4GpfHgfDGY3Xf11+QBGzb+J4hNhp5aLiffH73fcNzjK4Tcn4eLW1uo3fmcCSokEaF IOjaDgpMd52pMxyvOYKCWHDOEQDo7PexrsN6Cks5DcwbX+5NPEepEUP4tpqdQdJYpOk1 mxyG73JQnvuhTQv3mTuwF5p7gbHioqPEHDpZ/JixNoAT+kL8BnQ06kBwgf+jycOQKvqn 3dEMXs22RSGOL/sLjPf4lYabYjNaxL1jcyIfmOl/Et6fa9TCISDcc5t4DhLhXNkxBqTS 00dg== X-Gm-Message-State: AOJu0YzQ5ibuBhBjfGXv/K4Pv+bO3EtFsoBM0PYMFC3eaqwrK0d9WMG1 pbAnzQsli57PrUBdW0DCdq7slYKuIGNm1Woa/Bs8cKmSRBCc+b02lN5yHifLlm7jocXbOmSoFrI e0DKeJxa4aSICDNnA9w+bDMMHl4lOloChnUjtxqKD8TjrcVG2o5TcDEb3hufWL8dY9yN6oBu55z bpwkPek/FI9TdkBgk2VjVqt7oJYTKN1svqON8VHM9w X-Gm-Gg: AY/fxX4bup9Ekb+U4Xl7AlYFSCkm820m1OjaxN50MzLFsFzr+9D86isIR/dUdrWNBIl abPH3fH659tRduiH+gUwuLnV7rUspwNo7QL0J8vI4zwxhS9hrexISkPMBE01320t0wMZy9JW/0q LHjUiwHZD+pvRPXaP91F7G93EHoGxSMLFLh24qFkU03tnUrPiyG51w8ekuGD5sDz5GFzYrcEglB 6/euKQbi7k3lBEPY/0tgSQ35EoFdjlokuVkKNTZOGuhQRmWsgN9UmUEttoeNKNiaZ0nG8cuuu+u /KdHV3eVQc9Zk3etw0RSKd+OaZwNzXq1RzOYFStsQF2mE8fGcmhqbmSwKQWup0SxlIv/lLcbpTH 88ePBJk9MIy+8cDkni4SrbTg2OxH5I+UFmyqlgRvSHJaMP5yVL3Tot05Jq0NRNnSYQfiwd3QNPP YXvE7puSPx2uAzpg== X-Received: by 2002:a05:600c:450d:b0:477:c71:1fc1 with SMTP id 5b1f17b1804b1-4801d7a4ab8mr1080055e9.19.1768476792638; Thu, 15 Jan 2026 03:33:12 -0800 (PST) X-Received: by 2002:a05:600c:450d:b0:477:c71:1fc1 with SMTP id 5b1f17b1804b1-4801d7a4ab8mr1079575e9.19.1768476792248; Thu, 15 Jan 2026 03:33:12 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: richard.henderson@linaro.org Subject: [PATCH 2/6] target/i386/tcg: fix typo in dpps/dppd instructions Date: Thu, 15 Jan 2026 12:33:02 +0100 Message-ID: <20260115113306.126905-3-pbonzini@redhat.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260115113306.126905-1-pbonzini@redhat.com> References: <20260115113306.126905-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1768476847343158500 Content-Type: text/plain; charset="utf-8" Their gen_* functions were incorrectly named gen_VDDPS and gen_VDDPD. Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson --- target/i386/tcg/decode-new.c.inc | 4 ++-- target/i386/tcg/emit.c.inc | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/target/i386/tcg/decode-new.c.inc b/target/i386/tcg/decode-new.= c.inc index e44b92710cf..b00ea3e86e8 100644 --- a/target/i386/tcg/decode-new.c.inc +++ b/target/i386/tcg/decode-new.c.inc @@ -977,8 +977,8 @@ static const X86OpEntry opcodes_0F3A[256] =3D { [0x21] =3D X86_OP_GROUP0(VINSERTPS), [0x22] =3D X86_OP_ENTRY4(PINSR, V,dq, H,dq, E,y, vex5 cpuid(SSE4= 1) p_66), =20 - [0x40] =3D X86_OP_ENTRY4(VDDPS, V,x, H,x, W,x, vex2 cpuid(SSE4= 1) p_66), - [0x41] =3D X86_OP_ENTRY4(VDDPD, V,dq, H,dq, W,dq, vex2 cpuid(SSE4= 1) p_66), + [0x40] =3D X86_OP_ENTRY4(VDPPS, V,x, H,x, W,x, vex2 cpuid(SSE4= 1) p_66), + [0x41] =3D X86_OP_ENTRY4(VDPPD, V,dq, H,dq, W,dq, vex2 cpuid(SSE4= 1) p_66), [0x42] =3D X86_OP_ENTRY4(VMPSADBW, V,x, H,x, W,x, vex2 cpuid(SSE4= 1) avx2_256 p_66), [0x44] =3D X86_OP_ENTRY4(PCLMULQDQ, V,dq, H,dq, W,dq, vex4 cpuid(PCLM= ULQDQ) p_66), [0x46] =3D X86_OP_ENTRY4(VPERM2x128, V,qq, H,qq, W,qq, vex6 chk(W0) cp= uid(AVX2) p_66), diff --git a/target/i386/tcg/emit.c.inc b/target/i386/tcg/emit.c.inc index bc3a07f972c..f5f12e48b77 100644 --- a/target/i386/tcg/emit.c.inc +++ b/target/i386/tcg/emit.c.inc @@ -788,9 +788,9 @@ static void gen_##uname(DisasContext *s, X86DecodedInsn= *decode) BINARY_IMM_SSE(VBLENDPD, blendpd) BINARY_IMM_SSE(VBLENDPS, blendps) BINARY_IMM_SSE(VPBLENDW, pblendw) -BINARY_IMM_SSE(VDDPS, dpps) +BINARY_IMM_SSE(VDPPS, dpps) #define gen_helper_dppd_ymm NULL -BINARY_IMM_SSE(VDDPD, dppd) +BINARY_IMM_SSE(VDPPD, dppd) BINARY_IMM_SSE(VMPSADBW, mpsadbw) BINARY_IMM_SSE(PCLMULQDQ, pclmulqdq) =20 --=20 2.52.0 From nobody Mon Feb 9 09:21:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1768476893; cv=none; d=zohomail.com; s=zohoarc; b=b9x7Ify/8WkxsvtuYs4r1pYVmjpNCgAOus1sONYh4TUX4cvnlht+o6ZFFj4OHku3F9KXo62VRez51tdKCBIJl9QbZh2nWA0xPrZvV5vLzcN60FtoOwX/MCB8YDK+IsXzUaMdAPw0X85QDjJXChUTBuGwFMIJWSZBUVcH6dqZyMs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768476893; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=SmbYcV3xCktb3nD7uOxXTtNY5+oBGTXUObgEPKOEJgI=; b=OLti1s4lCGXnS8Tn2ynfX1rE6JfX2tHAdSEo8IQQoevFXSM6bdPvBpNvPHV4m3CIlAN/LulLdA8fCZSrebVTB82IUrlKn5sXeM+KWWEV/Z4WzmdStqVjYGcXDsZRvX+99D7QV04MvGULEqHsSNukCYA6O0Npx2mAOxbxQEYQjks= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17684768931141019.2328508539265; Thu, 15 Jan 2026 03:34:53 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vgLbj-0003UA-DZ; Thu, 15 Jan 2026 06:33:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vgLbN-0001fX-7D for qemu-devel@nongnu.org; Thu, 15 Jan 2026 06:33:31 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vgLbL-0003y4-Pk for qemu-devel@nongnu.org; Thu, 15 Jan 2026 06:33:20 -0500 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-437-LvfkmLDkPcyMSnlzOn6aIQ-1; Thu, 15 Jan 2026 06:33:16 -0500 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-4310062d97bso534245f8f.0 for ; Thu, 15 Jan 2026 03:33:16 -0800 (PST) Received: from [192.168.10.48] ([151.61.26.160]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-434af653560sm5539562f8f.10.2026.01.15.03.33.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 03:33:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768476798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SmbYcV3xCktb3nD7uOxXTtNY5+oBGTXUObgEPKOEJgI=; b=B5Wh4XhApzuRHdiZCcWUrRSNyjbvVorizHJqj1NDJWfkLvKkAHeRcytL5OG0sYZnm7ELFb DqRa3S1cbsidtT0miyNIf6PUuZADRbCwJ4d75agm2L416BoKJ0/7N9qS7RCnwEz2C+ohgR NP8ASXIAZsmTTAad/6+SiAo/Z7IsEW8= X-MC-Unique: LvfkmLDkPcyMSnlzOn6aIQ-1 X-Mimecast-MFC-AGG-ID: LvfkmLDkPcyMSnlzOn6aIQ_1768476796 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768476795; x=1769081595; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SmbYcV3xCktb3nD7uOxXTtNY5+oBGTXUObgEPKOEJgI=; b=i22EwQeNY3EjOL4xXs3p7EtZH1WC2IzAAEVcj3Gxt8AuJ7Hek0M9TF7XiajfFos87Q 3TrCeWAVmmqLRsb9nLluh1HzYyPQYCQJBkJd4coPROi5mvnQkp3SGgxek8rkaTUzkXam 2W4vXr0+sd2ZLLIUzweX8VZ3QwiHEnY9mW/d+KbwLl/OOE+OwGFf4JbfC28PzmnbjqEq sQ6HOWOu1Z8ZBgK6PXH0LKTX2uNlD4uSkSw1oupL6SyCd8JJe/uKdZNJmjWAGNzNv/+w ic7Xdaqc0T2skhzvLvogpGKLH7oqwzhu/m3I9MzYAu8xb9tiB8Oh5ZcPXdXRdWs0QwlC cUbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768476795; x=1769081595; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=SmbYcV3xCktb3nD7uOxXTtNY5+oBGTXUObgEPKOEJgI=; b=RluIucHPuiIGocoU6Yq7i5C3SL50u83UFNdF4wZ6xZuq7TDwk/8vyvdn5keT9CO80n AihLyyUlrv+NdNM+3Ct+O8hQtdYjP7QeXTcNhvdooMTJmRW0cSNLwrB+rIjUXF3rL3oI ULgt22jl7IAxD4BsW5EeYEuaoYiwhCQIn1DnauMcqtfvGHE+Ryt8w7fklk3Q3z2GwyWz ldSFk9NIjiAt4EHQMXpgWDEYNesy8SMQ9UpHpNKLmv5gq8yG+ye3CScTE/xUHZWTvuBO Z7hQ6FBJLwqA/Vp8pYZED+Q6GOUjSXhPr3ZrbAECI+aHJJPjauiksOiWRuau7aKsAuaf pLZA== X-Gm-Message-State: AOJu0YxzYSsejmYIbY6VHj67VgaQQOC3Y0vsOfH2jQSmjAN+GZTC5yIh xdpslx0oP8cm8UxkXTz/7JZevGssmvZYds8iZT7BIz4QMHm63APnBXGhhPRn9Sfam9FOk8c0loA 6yOtHUE5RiERF1NmtAGUixx4EtXTIFDcR5pQDIlvio1AoYZ0mtDXW+kWIbMp1dIVlwZNwCftUV8 P5IAWRNutPddWZueC+fr9K3CBRUWjuUj9+Ipti+HAK X-Gm-Gg: AY/fxX6sxjTdY8YCZzj3c/kZCKOLFZLYE7PZ0+9wW1sO6c4jID/xNg0luZ1a/Cdfk5q TrxzbI4SL0Nlq9CvS3IM3q9d7M4DpSmw3+D3QhDuuSq/5K5/RDQNQjDR1/JlaUsHmISRaDYVBnX sv7FddDofGixJdVBWXqsU+xyl/UYGF0/OswZvkS7BfEuaO6NS+BLmuS3Pg8XWSyaY2kkwGyO2Rc YRAUr44XQe/3jt8R5NSGAGB7uLUEOvE77HxDZdS7b2Z1SpqVVBhO7ec4C3ZrbjoMStTwh2gWa7/ L8ZUHqnQ0LEZlMfXcomt4ybLLhfkNFaEL8ChxTQBxIQmfMuxjUIJoXRXPfurHanSVjzDb2zTT3P mL30OcmbLNLR4r9msW8QNy9+WYYju1Fkh54PNhdQJ4Tk3ThR/o2ISdJUuULdFCwRhPr1LOedXum q4K4tJlt32vDzThQ== X-Received: by 2002:a5d:64c5:0:b0:431:488:b9bc with SMTP id ffacd0b85a97d-4342c4f3982mr7524713f8f.10.1768476794845; Thu, 15 Jan 2026 03:33:14 -0800 (PST) X-Received: by 2002:a5d:64c5:0:b0:431:488:b9bc with SMTP id ffacd0b85a97d-4342c4f3982mr7524665f8f.10.1768476794306; Thu, 15 Jan 2026 03:33:14 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: richard.henderson@linaro.org Subject: [PATCH 3/6] target/i386/tcg: remove dead constants Date: Thu, 15 Jan 2026 12:33:03 +0100 Message-ID: <20260115113306.126905-4-pbonzini@redhat.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260115113306.126905-1-pbonzini@redhat.com> References: <20260115113306.126905-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1768476895636158500 Content-Type: text/plain; charset="utf-8" NB_OP_SIZES has been dead since the conversion to TCG, REG_L_OFFSET since 2015, the others somewhere in the middle. Signed-off-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/i386/tcg/translate.c | 24 ------------------------ 1 file changed, 24 deletions(-) diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index 460848e4223..20aa94347b0 100644 --- a/target/i386/tcg/translate.c +++ b/target/i386/tcg/translate.c @@ -374,30 +374,6 @@ static void gen_update_cc_op(DisasContext *s) } } =20 -#ifdef TARGET_X86_64 - -#define NB_OP_SIZES 4 - -#else /* !TARGET_X86_64 */ - -#define NB_OP_SIZES 3 - -#endif /* !TARGET_X86_64 */ - -#if HOST_BIG_ENDIAN -#define REG_B_OFFSET (sizeof(target_ulong) - 1) -#define REG_H_OFFSET (sizeof(target_ulong) - 2) -#define REG_W_OFFSET (sizeof(target_ulong) - 2) -#define REG_L_OFFSET (sizeof(target_ulong) - 4) -#define REG_LH_OFFSET (sizeof(target_ulong) - 8) -#else -#define REG_B_OFFSET 0 -#define REG_H_OFFSET 1 -#define REG_W_OFFSET 0 -#define REG_L_OFFSET 0 -#define REG_LH_OFFSET 4 -#endif - /* In instruction encodings for byte register accesses the * register number usually indicates "low 8 bits of register N"; * however there are some special cases where N 4..7 indicates --=20 2.52.0 From nobody Mon Feb 9 09:21:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1768476893; cv=none; d=zohomail.com; s=zohoarc; b=hdrL1vBOtrDj1NN8HpMqouiRgmCxpXG33Hs2bMl2XWrpJXxla23t3i5FD2iDIIGidpWs9vHxfmFJWMSBqx0uLBhVoAVaFnyGnyByEAcYDdkUvWv0GfWdTF6Z2gpWcoGWflLv629sahD+hCiYE0afuQsN5z0onDWyPVdRxyIUbVA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768476893; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=s4ZP0M6LSe18tj6821SMJeDGGJkxkekrXzs8Be7PL+A=; b=JCOMFEYdzpDZmQ/ke/ujFjFFM8QUo0RddEoB53T6Swwski6iyVJ6xyrGV01qlbiD9JY/vqz/qPpFH39fxCl9Wt0pcuN4Rdq86CH/cxnWDRmYSGLmxxKeSVshDKdTtMRrIGaWhk4HN1q5KDwUpV1YQ+gARih4j3cr/BgIKqDBjyw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768476893069875.1560939928643; Thu, 15 Jan 2026 03:34:53 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vgLbi-00034F-2k; Thu, 15 Jan 2026 06:33:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vgLbO-0001qf-7s for qemu-devel@nongnu.org; Thu, 15 Jan 2026 06:33:31 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vgLbM-0003yT-Mj for qemu-devel@nongnu.org; Thu, 15 Jan 2026 06:33:22 -0500 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-584-xoWcVTJpMLWn61_Aq4qtyA-1; Thu, 15 Jan 2026 06:33:18 -0500 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-430f527f5easo971880f8f.1 for ; Thu, 15 Jan 2026 03:33:18 -0800 (PST) Received: from [192.168.10.48] ([151.61.26.160]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-434af64a666sm5332763f8f.6.2026.01.15.03.33.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 03:33:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768476800; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s4ZP0M6LSe18tj6821SMJeDGGJkxkekrXzs8Be7PL+A=; b=KweCFEJ41TYUdr9AAQsh6kMAuyCgA7rGZ7myiywWnEhuVlWanJGwQ+ULSkXr1Ywlt65/lY ZHNY1H6XztIxpneDR7saSslvS2tv9zKjU47NDWyG95Tq0syO+rQNVUtXWVeQt8BkHk++xL 3+BewVy8vFHvj92/hReajYjVghxNbs8= X-MC-Unique: xoWcVTJpMLWn61_Aq4qtyA-1 X-Mimecast-MFC-AGG-ID: xoWcVTJpMLWn61_Aq4qtyA_1768476797 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768476797; x=1769081597; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=s4ZP0M6LSe18tj6821SMJeDGGJkxkekrXzs8Be7PL+A=; b=nFUCLW1PWHOeEvLftWb+JrGPVKLQWNx65knQo/+N4SrBqn6stdwg4IATBSZRZrgys8 8hmBgnXzov8iRnuemsbPD6eW22ovhGdmTafttggz/vABf73vGFYyK114jjeAkaC8GsS5 8rhbRusd2wLRkx5g+xET5rxEmWvk+r925UDM95gIVEKBRsRBVyCXYXUe7fUb6WY7J6Jl yPif7+MnWQUJbtA8t7UbWoJq2mUI+ghrv8OYS/1lnesTZrC4TxyywgZYJhg0NsBfBkjx cV+j+CDs8sSx/3IUBZzn7d3wcbCqyu1X7XFQ6sIgIM8kXr8Lu5323F9cZFAU8pyNwhSs AcIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768476797; x=1769081597; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=s4ZP0M6LSe18tj6821SMJeDGGJkxkekrXzs8Be7PL+A=; b=mmAjmoenoARlomedMXAw2+HOi4unptwR0MvJZqMYIclT5dXeplJA1ClvyktFOO34+2 Hbkj+8/5CNaEaZBt+zu9/pxjOoXgStfMKJuHFGn+CPm/nek6MuqQ0tE3BrdVX3vNj17J a8BmkPTWR8FhWKx2N4XtNbHiLhtyUu9AC0dWfjcHncT79pqjMgFXX7uV12se0ndi9ziF WxQVR9c9efnXgEIsQ7zH2WRyBBBjJrp2iJqcflc8EesQuOrYlvYKh4ynVsHKjRY46H5l bPme6xy8lLmdMf60uwT/Aec1JsDs0VdZyi3hQkqa4GYs3dtUw0eKou/Mhyj764M4qbNF tmHw== X-Gm-Message-State: AOJu0YwoAzgMLaQnOKT49lWirQA4x/XEXjNv3Ib+whm67gSyLndZbPtI QTdvfDS0jRourJF0fYfneKLuFqZW+CPF5kWTZAxyc0WsWN+FdDKJOl5cK0ClRLLGqCQTCaSwMi7 TAMYV3gXXeQa/8OSdMDqgZIcZqx4zNAG7m6dRVzif3bzN0IVnjg0J40OP+MAMWb3lgot7s3Mr8o tVC8BQbqicha7CuK56nTitJVrEayaLNyqQTlelhuhA X-Gm-Gg: AY/fxX6igUmMrLJ/w54S/oDFSyLjjgroVzCEduBwRoEXPeLFPlnqg5Ct9E1/NBvF3QV dysNDh+vfkkfNFjQmHOTpYzX2pL2wr3lMAeJYSCAsbeKLYTlJ88tIoHsZQymHECDofwaT4tYtpc nY38xWq3Qjf76ao553pwpZpdH1aP7Y6WsJXy5l3Vozb+LGWdO/IcT8OfRw/+FqMS4/kniFsKtsJ D71wjJ/KcCjJTwhuMz6KxbIAJLYMEVrYPhYNEqoT/OQ18NTdreRZBMba7k96AqfbYiVmivZDLjV Py14xi00EEj6fRmuVbKhyM0Cs401lXS6g0wH5A/W1SmakSTuzx5BU3J53lb3PJbxMEo1facMggY CuIVhMtRqtynQRj8pHp04dhbjINUyBMglAOg685zjd0ZMGwQrKf8jhgL4KBbGDWT451RQ4JPFlu xdahtWBMJ6aptXig== X-Received: by 2002:a5d:64c5:0:b0:431:2ff:128f with SMTP id ffacd0b85a97d-434ce63e092mr3481059f8f.6.1768476796998; Thu, 15 Jan 2026 03:33:16 -0800 (PST) X-Received: by 2002:a5d:64c5:0:b0:431:2ff:128f with SMTP id ffacd0b85a97d-434ce63e092mr3481017f8f.6.1768476796532; Thu, 15 Jan 2026 03:33:16 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: richard.henderson@linaro.org Subject: [PATCH 4/6] target/i386/tcg: merge decode_modrm and decode_modrm_address split Date: Thu, 15 Jan 2026 12:33:04 +0100 Message-ID: <20260115113306.126905-5-pbonzini@redhat.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260115113306.126905-1-pbonzini@redhat.com> References: <20260115113306.126905-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1768476893444158500 Content-Type: text/plain; charset="utf-8" Unlike the older code in translate.c, mod=3D11b *is* filtered out earlier by decode_modrm, and it would have returned bogus code. Since the register case is so simple, just inline decode_modrm_address into its caller instead of removing the "if". Suggested-by: Richard Henderson Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson --- target/i386/tcg/decode-new.c.inc | 64 ++++++++++++-------------------- 1 file changed, 24 insertions(+), 40 deletions(-) diff --git a/target/i386/tcg/decode-new.c.inc b/target/i386/tcg/decode-new.= c.inc index b00ea3e86e8..662d1d707d0 100644 --- a/target/i386/tcg/decode-new.c.inc +++ b/target/i386/tcg/decode-new.c.inc @@ -2007,33 +2007,34 @@ static void decode_root(DisasContext *s, CPUX86Stat= e *env, X86OpEntry *entry, ui *entry =3D opcodes_root[*b]; } =20 -/* Decompose an address. */ -static AddressParts decode_modrm_address(CPUX86State *env, DisasContext *s, - int modrm, bool is_vsib) +/* Decode the MODRM and SIB bytes into a register or memory operand. */ +static void decode_modrm(DisasContext *s, CPUX86State *env, + X86DecodedInsn *decode, X86DecodedOp *op) { - int def_seg, base, index, scale, mod, rm; - target_long disp; - bool havesib; - - def_seg =3D R_DS; - index =3D -1; - scale =3D 0; - disp =3D 0; - - mod =3D (modrm >> 6) & 3; - rm =3D modrm & 7; - base =3D rm | REX_B(s); + int modrm =3D get_modrm(s, env); + int mod =3D (modrm >> 6) & 3; + int rm =3D modrm & 7; + bool is_vsib =3D decode->e.vex_class =3D=3D 12; + bool havesib =3D false; =20 if (mod =3D=3D 3) { - /* Normally filtered out earlier, but including this path - simplifies multi-byte nop, as well as bndcl, bndcu, bndcn. */ - goto done; + op->n =3D rm; + if (op->unit !=3D X86_OP_MMX) { + op->n |=3D REX_B(s); + } + return; } =20 + /* Decompose an address. */ + int def_seg =3D R_DS; + int base =3D rm | REX_B(s); + int index =3D -1; + int scale =3D 0; + target_ulong disp =3D 0; + switch (s->aflag) { case MO_64: case MO_32: - havesib =3D 0; if (rm =3D=3D 4) { int code =3D x86_ldub_code(env, s); scale =3D (code >> 6) & 3; @@ -2042,7 +2043,7 @@ static AddressParts decode_modrm_address(CPUX86State = *env, DisasContext *s, index =3D -1; /* no index */ } base =3D (code & 7) | REX_B(s); - havesib =3D 1; + havesib =3D true; } =20 switch (mod) { @@ -2127,26 +2128,9 @@ static AddressParts decode_modrm_address(CPUX86State= *env, DisasContext *s, g_assert_not_reached(); } =20 - done: - return (AddressParts){ def_seg, base, index, scale, disp }; -} - -static int decode_modrm(DisasContext *s, CPUX86State *env, - X86DecodedInsn *decode, X86DecodedOp *op) -{ - int modrm =3D get_modrm(s, env); - if ((modrm >> 6) =3D=3D 3) { - op->n =3D (modrm & 7); - if (op->unit !=3D X86_OP_MMX) { - op->n |=3D REX_B(s); - } - } else { - op->has_ea =3D true; - op->n =3D -1; - decode->mem =3D decode_modrm_address(env, s, get_modrm(s, env), - decode->e.vex_class =3D=3D 12); - } - return modrm; + op->has_ea =3D true; + op->n =3D -1; + decode->mem =3D (AddressParts){ def_seg, base, index, scale, disp }; } =20 static bool decode_op_size(DisasContext *s, X86OpEntry *e, X86OpSize size,= MemOp *ot) --=20 2.52.0 From nobody Mon Feb 9 09:21:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1768476846; cv=none; d=zohomail.com; s=zohoarc; b=C098n7EgJpiaeNlAosFrpsKhB2Fqpr7ho6ldytVT5y8Sc70o7TdlORVCJm+OlOKfQBnCk2mJVviUKu+ylNyAVc/Wat4nZhOeAgORBqRt0U8dSucjSPeDVaW+ZFiJKvKkFjyHxinlL21AnquyvQNbMDHkbVmhkSOGPpgZ3jBrKk8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768476846; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=6Q2xDs6voA4t4GN+7fEry4HocsUdTgpQdX9oMo6deBg=; b=hsc1nk8lBywFRZ0v/vSNvnIAoPYGPTKojyB3qyHLW4/MU4eZoQNqt7jy2Q10bfQB5H7VMg2ic9y2UEJ7US5XsNDbnG7mcennbAYw/ZGAGmDmDvnhn4NTK5nImeRUyFx5G9iguMRDy9Lujm9JVV7RwYJN8b7BC7byi538vVT7DZk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768476846410157.15556679060228; Thu, 15 Jan 2026 03:34:06 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vgLbi-0003Fr-J3; Thu, 15 Jan 2026 06:33:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vgLbR-0001qy-5F for qemu-devel@nongnu.org; Thu, 15 Jan 2026 06:33:31 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vgLbP-0003z8-0u for qemu-devel@nongnu.org; Thu, 15 Jan 2026 06:33:24 -0500 Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-287-11ujmQdaP6quNWRFIPHmvQ-1; Thu, 15 Jan 2026 06:33:21 -0500 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-43284f60a8aso682611f8f.3 for ; Thu, 15 Jan 2026 03:33:20 -0800 (PST) Received: from [192.168.10.48] ([151.61.26.160]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-434af64a643sm5374229f8f.1.2026.01.15.03.33.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 03:33:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768476802; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6Q2xDs6voA4t4GN+7fEry4HocsUdTgpQdX9oMo6deBg=; b=NTmw4YJIyhz7HberK8szEWq+QehMFJF3JWZMxzmVA7v4Yy+y84B04RwOV6GBSwxk1ySurg KyK9B16XqiME030UPPxG/YLr4hXY+mbhevmmiozSuzB+tEgbrQ5QcBe6gi6sj9pejJ5p1a X6/L+SY6AvwzFtICtmDLsJFajtVTtCs= X-MC-Unique: 11ujmQdaP6quNWRFIPHmvQ-1 X-Mimecast-MFC-AGG-ID: 11ujmQdaP6quNWRFIPHmvQ_1768476800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768476799; x=1769081599; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6Q2xDs6voA4t4GN+7fEry4HocsUdTgpQdX9oMo6deBg=; b=TiZl5FBpByeRJ+XGytmDukXN4DScDBUHYeq4khDk/3dV7GRStFj3kQAKqXHwoyWzYX DBm1Ru4uG+k02ysNfyyV8H5VaUmXFn29Y5yeMs6cURjxzdmdntLCPFjz2KAkfJfYarrz X1SY2iDXKQ6LVXhxQJ9twA9PDpctYV6OAnQ3Fhv/FoaKZhN5nmLvJZQQud92hHOdJlvv zZTRZgo/VvENi0I1X7tmqEO6Mg0YL/Ieout7pr6dT/lHEV4Z3PAb1DLlePu/IGXDcSIe 03Zwc1p6YccLUoyMWhUuTjj80rSpR0/GL1vfMcmZISHIMED4VCOU2Z8NPumpBZzdwFeC mKlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768476799; x=1769081599; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6Q2xDs6voA4t4GN+7fEry4HocsUdTgpQdX9oMo6deBg=; b=dtgDs89IKxVQ54+in1LbyciY+H+MbnHnpq3DP7zDN1sBQ+uuhQkhnHb0Tpbfj8croL cVdbBu5qsOZ/X5hWwDW7btWptUfu/hJQpBYWylI2FJUrOK3snnYn0LiFmydnYckYeEq6 +PPHp63NQc35O9sJuNwC/kQMZWwAbYNqumWuE2Izmye0p1d1Q1ESUY9tP7b15Y/O7ztU WiDMk47i6RH6hSZLfS57yhT4CZEtQuKAdPTlEw+mx9dD9CF9EKw2pMDDhgoMDB809em2 NPErlqYfhd0WIYTBB2ZcotHFbz/CMIYlehi1qvB6bYKK2Z7xWlScCcQAbEOqACfo6DBi /PUA== X-Gm-Message-State: AOJu0YwRmcNkUDjhc2b/KgqSzJ88GzG7Ew4Ie8bBIpJkUaar6YIk/zIk eHIwx8wwZKUC1+UcAOnSyRHCm857T6wNACB98e/S+Bb+qkTr8I87cp38JAD3URLXPKCJr1uwg1y DWoJOBHCpVieQOXI0W9PhSzHCXxGHDIq5jY23prWdfsKVRQ7ZN5eBdMM2/17oSAjj4h2Asmxb15 4rYbEY3Ljs5fy62gniNGWfNdZ9XfFpzXmY+RzXDi32 X-Gm-Gg: AY/fxX6F/7xVwy2BEqUYeEJ7Jfnz/Y3qXWbHViI6lV14zdc2uD8UlHKSeZ9Go1Xvxoo QKKSkxN9DflFhJI7ybIyQsE2SU2mE1gNNWjTpFeieIF7Bvsl2xNRa7vWozGKnFgieHlc26UW37Z /tcmSk+vR0ilXYbaFEjm5YsbHWtgPip9mP2dqWEgTTKJ2zw6DPKxlwqeImpyFQVYNOFftazFNfb 4FLQH5fRytr2W3sR8vk2N5qA3sTWQ+WFKx49l40m32ftlCObgdVFP0WLCF7iOIL4r0qJBW7tGEm IBAOOwiMIUgZRxK5GzTJOqiEVDHeTeZS2jm1lYCoEZCPtK6CVQ+sziupgYKxOitmHdq+nDpcUo+ 1ncLxG/TgJCJOBYKOAzgsI1VReJLXdSkuCPUwS79kC5GHScquIvub6MyBjjz2xYc5giuWIZ5l1C xSCvxWWpfYdY3AUw== X-Received: by 2002:a05:6000:1842:b0:431:266:d138 with SMTP id ffacd0b85a97d-4342d5b2a4cmr7233853f8f.25.1768476799088; Thu, 15 Jan 2026 03:33:19 -0800 (PST) X-Received: by 2002:a05:6000:1842:b0:431:266:d138 with SMTP id ffacd0b85a97d-4342d5b2a4cmr7233806f8f.25.1768476798678; Thu, 15 Jan 2026 03:33:18 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: richard.henderson@linaro.org Subject: [PATCH 5/6] target/i386/tcg: replace havesib variable with the SIB byte itself Date: Thu, 15 Jan 2026 12:33:05 +0100 Message-ID: <20260115113306.126905-6-pbonzini@redhat.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260115113306.126905-1-pbonzini@redhat.com> References: <20260115113306.126905-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1768476847341158500 Content-Type: text/plain; charset="utf-8" Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson --- target/i386/tcg/decode-new.c.inc | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/target/i386/tcg/decode-new.c.inc b/target/i386/tcg/decode-new.= c.inc index 662d1d707d0..086a3bcec18 100644 --- a/target/i386/tcg/decode-new.c.inc +++ b/target/i386/tcg/decode-new.c.inc @@ -2015,7 +2015,7 @@ static void decode_modrm(DisasContext *s, CPUX86State= *env, int mod =3D (modrm >> 6) & 3; int rm =3D modrm & 7; bool is_vsib =3D decode->e.vex_class =3D=3D 12; - bool havesib =3D false; + int sib =3D -1; =20 if (mod =3D=3D 3) { op->n =3D rm; @@ -2036,14 +2036,13 @@ static void decode_modrm(DisasContext *s, CPUX86Sta= te *env, case MO_64: case MO_32: if (rm =3D=3D 4) { - int code =3D x86_ldub_code(env, s); - scale =3D (code >> 6) & 3; - index =3D ((code >> 3) & 7) | REX_X(s); + sib =3D x86_ldub_code(env, s); + scale =3D (sib >> 6) & 3; + index =3D ((sib >> 3) & 7) | REX_X(s); if (index =3D=3D 4 && !is_vsib) { index =3D -1; /* no index */ } - base =3D (code & 7) | REX_B(s); - havesib =3D true; + base =3D (sib & 7) | REX_B(s); } =20 switch (mod) { @@ -2051,7 +2050,7 @@ static void decode_modrm(DisasContext *s, CPUX86State= *env, if ((base & 7) =3D=3D 5) { base =3D -1; disp =3D (int32_t)x86_ldl_code(env, s); - if (CODE64(s) && !havesib) { + if (CODE64(s) && sib =3D=3D -1) { base =3D -2; disp +=3D s->pc + s->rip_offset; } --=20 2.52.0 From nobody Mon Feb 9 09:21:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1768476851; cv=none; d=zohomail.com; s=zohoarc; b=cXSCju1AdPwMgZiLrSgycitnemPeiVFyVYd/54+Wf9ArnQonyWjxqWM3x5Ryq33tPn23N27CkAgKTaltyGASHtZlEo2Nz8mdJJmhyP9OY+mgEdZAZMnnYuTeyqYk12Iy4PQYmQQyaL8QDx7xehNV3mRhyWbg1clQKNroZ3WgRIA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768476851; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=3GIEIKKsDu75oTOgKWohyN3yLE0yP/Hdhh/xZUygdU8=; b=dmP92l2QO1WmMpdplIwSoJBKLsjTN/B6KVwtL0I3y4GxlHc0Ln+6I+NWgm/W9pXgarzZhNCSqmOPTv1Rugbhz9QQ33Vu09PE71bSF5RBVG948hATGi63NQP4nAyyXTitzGzEOaR4g/jAMGizagA8VsTV+4sGy2beqAI94AsJsO4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768476851221543.0473667194566; Thu, 15 Jan 2026 03:34:11 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vgLbj-0003VI-DU; Thu, 15 Jan 2026 06:33:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vgLbT-0001rA-0y for qemu-devel@nongnu.org; Thu, 15 Jan 2026 06:33:31 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vgLbR-0003zY-09 for qemu-devel@nongnu.org; Thu, 15 Jan 2026 06:33:26 -0500 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-512-cNzW7x17OVOJ6TQHXRkXMg-1; Thu, 15 Jan 2026 06:33:23 -0500 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-47ee71f0244so8581545e9.0 for ; Thu, 15 Jan 2026 03:33:22 -0800 (PST) Received: from [192.168.10.48] ([151.61.26.160]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47f428afd9csm42300215e9.6.2026.01.15.03.33.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 03:33:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768476804; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3GIEIKKsDu75oTOgKWohyN3yLE0yP/Hdhh/xZUygdU8=; b=TIqNPubm5JD59nWq7ioNplWFZLAUt/isWPfd3K/30SicI+HGCYubKi24QfrF1Tm1vIEFBp 83M0jAVpWXPrPrXDTTVDtW6LeQUmRFgw/O13OSoTQC8VP5/UsN+2g62mvwGr1OCtaWsnTw KYY1MdTqQEt1xT2qcPn1CS++lriXOWI= X-MC-Unique: cNzW7x17OVOJ6TQHXRkXMg-1 X-Mimecast-MFC-AGG-ID: cNzW7x17OVOJ6TQHXRkXMg_1768476802 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768476801; x=1769081601; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3GIEIKKsDu75oTOgKWohyN3yLE0yP/Hdhh/xZUygdU8=; b=KBj8PQDFG6da8Jx9tu2U1Zogc25NjLAWHDlnBmRnGxGuREgJhk7JuuYOCS0fxhpA8A ip12PNZXwdx4JEV0f1WlbNKwNzmMADdi1pONaZa4dlA5ZIbCFWG0cTidFYzODZj/hN1U G3AlAoKNSNSYGQw23MIBuIi6JpaFP8yfiGBdE+noYchdf/rhUmGXttJHItDmt+4rGfyX oEKrKlP0ClkBVWZPs43GARpxnMfgaXP6jfmDDinPh9Q626Dvu0GZT8xOpc+KcTYdLBan qImyUC7TWJAh66OFRajA8n+r+YX/RotU6kWIFT5VZIvC9aeydVpRbK1MFsrlII9LUleH aO4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768476801; x=1769081601; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3GIEIKKsDu75oTOgKWohyN3yLE0yP/Hdhh/xZUygdU8=; b=CSETk9uaw5vgYeahTmYSZVHzAe3r8TcDDzM3Jo9AT7zJu2PqZgWBHEdjREpqJ8/hIn twn4Eq12WlwZd7t0DPIGZ9facMW3qlmyIYu9o7p4rHVYe/7LFfDso3ylSK2wjQsMYJya OlvU7Phi/NQrjPY+rk7uWkF/giQYtJq9q5CuIr2nl1mBkrrdbT4td7+sp1TZu3LCER8Q tIAfR+0FDamxNsE+FkJHlFjdAC5G/thJSbWQjIynazmalQJevQ6t+725YbUsb2ry5p+C kKFvxn4fSM53SOC1PwCIw7/ARmjMOwcDbMln7qwyc+qum+1CCRIxQxMXW8EryKh7mXys zlbA== X-Gm-Message-State: AOJu0Yx+bGJotu/kfVOzhj31iNrh2c4aIltoaDStX9vjThVz/OvnaiTt I16zJ64lCaMdZhIoxAs4iRu8/8BNQFghJwUUH3m1Rf+ZSWNpKRArrymbqoWWcHX3E1oqe7Vxx6k bOsN+tjxKDqauAykVpXu8KAoHpFxA26Dl45VQamQehPogSkOrlHFtx1VZHk3ftBgGRZohCAJNQy PrbvESrS377cy5RKUZR6olO+0w+ysJR0jcK0Ju2ZYk X-Gm-Gg: AY/fxX6vkWQV3pKNJg2B71LNjty66JSRwfX5SiJu6GZOjGKGfkQeTV2fVfWmbSgBhW/ xKLfM8rlsMv5GTlozT6kHxESX55LiJcv6Y4UB57I879E7WN9FQZ402LL3khGsqhlGzJO+1puKni uFM7KVv4b7Q+8K2Ll3ZeiE4aDJrWjXY9ZXQ9iF9Zy43Nqoka/WVp7Va6JttuL+uIuqmXVL2AefB mx14NiCZCOzY9DTGHrfSzOg+2uaXOedNXKXttL6jazSxyxDWHqzjW2EwnFQnqLxhzX1xuFCmGe6 4KIla85JMjyfbjMEthJr45ycSRv1+yLPNF6qzAmuX7TAlGO6zWmU7x4ahu0G2bmWTg8O9gPMfLJ V9fbA0+1/DsU7+HFboU9WreWOyfL0wZ/cwzWajym+QI0OA5CHyvUw+iYsFuuCIaaXrRt1ZyAb3G d4y8oy+VlwJE2XFg== X-Received: by 2002:a05:600c:3487:b0:477:9f34:17b8 with SMTP id 5b1f17b1804b1-47ee47bbe36mr68749875e9.1.1768476801321; Thu, 15 Jan 2026 03:33:21 -0800 (PST) X-Received: by 2002:a05:600c:3487:b0:477:9f34:17b8 with SMTP id 5b1f17b1804b1-47ee47bbe36mr68749335e9.1.1768476800740; Thu, 15 Jan 2026 03:33:20 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: richard.henderson@linaro.org Subject: [PATCH 6/6] target/i386/tcg: cleanup #ifdef TARGET_X86_64 Date: Thu, 15 Jan 2026 12:33:06 +0100 Message-ID: <20260115113306.126905-7-pbonzini@redhat.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260115113306.126905-1-pbonzini@redhat.com> References: <20260115113306.126905-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1768476853255158500 Content-Type: text/plain; charset="utf-8" 32-bit TCG opcodes produced for the i386 target usually looks the same as 64-bit TCG opcodes produced for the x86_64. The special one that needs extensions is 32-bit TCG opcodes produced for the x86_64 target. Make all #ifdefs look the same, like this: case MO_32: #ifdef TARGET_X86_64 /* code using 32-bit opcodes */ case MO_64: #endif /* code using target_long opcodes */ default: g_assert_not_reached(); Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson --- target/i386/tcg/translate.c | 11 ++++++----- target/i386/tcg/emit.c.inc | 18 ++++++++++++------ 2 files changed, 18 insertions(+), 11 deletions(-) diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index 20aa94347b0..7186517239c 100644 --- a/target/i386/tcg/translate.c +++ b/target/i386/tcg/translate.c @@ -430,17 +430,15 @@ static TCGv gen_op_deposit_reg_v(DisasContext *s, Mem= Op ot, int reg, TCGv dest, tcg_gen_deposit_tl(dest, cpu_regs[reg], t0, 0, 16); break; case MO_32: - /* For x86_64, this sets the higher half of register to zero. - For i386, this is equivalent to a mov. */ +#ifdef TARGET_X86_64 dest =3D dest ? dest : cpu_regs[reg]; tcg_gen_ext32u_tl(dest, t0); break; -#ifdef TARGET_X86_64 case MO_64: +#endif dest =3D dest ? dest : cpu_regs[reg]; tcg_gen_mov_tl(dest, t0); break; -#endif default: g_assert_not_reached(); } @@ -1585,8 +1583,8 @@ static TCGv gen_shiftd_rm_T1(DisasContext *s, MemOp o= t, tcg_gen_shri_i64(s->T0, s->T0, 32); } break; + case MO_64: #endif - default: hishift =3D tcg_temp_new(); tcg_gen_subi_tl(tmp, count, 1); if (is_right) { @@ -1615,6 +1613,9 @@ static TCGv gen_shiftd_rm_T1(DisasContext *s, MemOp o= t, tcg_constant_tl(0), s->T1); tcg_gen_or_tl(s->T0, s->T0, s->T1); break; + + default: + g_assert_not_reached(); } =20 return cc_src; diff --git a/target/i386/tcg/emit.c.inc b/target/i386/tcg/emit.c.inc index f5f12e48b77..ca0ee4d630d 100644 --- a/target/i386/tcg/emit.c.inc +++ b/target/i386/tcg/emit.c.inc @@ -1236,8 +1236,8 @@ static void gen_ADCOX(DisasContext *s, X86DecodedInsn= *decode, int cc_op) } =20 switch (ot) { -#ifdef TARGET_X86_64 case MO_32: +#ifdef TARGET_X86_64 /* If TL is 64-bit just do everything in 64-bit arithmetic. */ tcg_gen_ext32u_tl(s->T0, s->T0); tcg_gen_ext32u_tl(s->T1, s->T1); @@ -1245,12 +1245,16 @@ static void gen_ADCOX(DisasContext *s, X86DecodedIn= sn *decode, int cc_op) tcg_gen_add_i64(s->T0, s->T0, carry_in); tcg_gen_shri_i64(*carry_out, s->T0, 32); break; + + case MO_64: #endif - default: zero =3D tcg_constant_tl(0); tcg_gen_add2_tl(s->T0, *carry_out, s->T0, zero, carry_in, zero); tcg_gen_add2_tl(s->T0, *carry_out, s->T0, *carry_out, s->T1, zero); break; + + default: + g_assert_not_reached(); } } =20 @@ -1991,7 +1995,6 @@ static void gen_DIV(DisasContext *s, X86DecodedInsn *= decode) case MO_16: gen_helper_divw_AX(tcg_env, s->T0); break; - default: case MO_32: gen_helper_divl_EAX(tcg_env, s->T0); break; @@ -2000,6 +2003,8 @@ static void gen_DIV(DisasContext *s, X86DecodedInsn *= decode) gen_helper_divq_EAX(tcg_env, s->T0); break; #endif + default: + g_assert_not_reached(); } } =20 @@ -2065,7 +2070,6 @@ static void gen_IDIV(DisasContext *s, X86DecodedInsn = *decode) case MO_16: gen_helper_idivw_AX(tcg_env, s->T0); break; - default: case MO_32: gen_helper_idivl_EAX(tcg_env, s->T0); break; @@ -2074,6 +2078,8 @@ static void gen_IDIV(DisasContext *s, X86DecodedInsn = *decode) gen_helper_idivq_EAX(tcg_env, s->T0); break; #endif + default: + g_assert_not_reached(); } } =20 @@ -2895,7 +2901,7 @@ static inline void gen_pextr(DisasContext *s, X86Deco= dedInsn *decode, MemOp ot) tcg_gen_ld_tl(s->T0, tcg_env, vector_elem_offset(&decode->op[1], o= t, val)); break; default: - abort(); + g_assert_not_reached(); } } =20 @@ -2942,7 +2948,7 @@ static inline void gen_pinsr(DisasContext *s, X86Deco= dedInsn *decode, MemOp ot) tcg_gen_st_tl(s->T1, tcg_env, vector_elem_offset(&decode->op[0], o= t, val)); break; default: - abort(); + g_assert_not_reached(); } } =20 --=20 2.52.0