From nobody Mon Feb 9 10:33:14 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1768420695; cv=none; d=zohomail.com; s=zohoarc; b=m99LwSOvndEEatz1ephi+AxZWWLVO+hdQF9uzcKFdyi0NmEelw4qsp2dMi2c8zSseAHGH9pPFEPZspKFkyCjNJpT/eg9Le7rfgq2cbrDvs4OWKy87LdyMwYxiKZBERCGAL9obuiTzpwPUADCc09EJ4xKX6ndGT7Vk5r5qjrl+Tw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768420695; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ookbNDOLagx2JfHgzSX/g339CgGoZ3zgHlF0JmqVAA8=; b=aNb8uX5oawI/vVJo14fYtZm7dQPM80CeXUIOwxZRPcgWJ1qIi1UtjZu/SoUsMJad++W2qRrsHFHsyOwECYhphuvX7HyhulBwNNUohnZ5HHeiXPgum+hrAwojlewlTBVqQhqpcnkSzQE8NlikPuPSMBsdqyW4q9kSsBikVHKuApA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768420695972465.17255173083163; Wed, 14 Jan 2026 11:58:15 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vg701-0001UW-CV; Wed, 14 Jan 2026 14:57:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vg6zY-0001LM-DY for qemu-devel@nongnu.org; Wed, 14 Jan 2026 14:57:23 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vg6zW-00022f-Mk for qemu-devel@nongnu.org; Wed, 14 Jan 2026 14:57:20 -0500 Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-60-1IFgXt6DNryR4Hou7DujXQ-1; Wed, 14 Jan 2026 14:57:16 -0500 Received: by mail-vs1-f70.google.com with SMTP id ada2fe7eead31-5ec87b2b4ddso165948137.3 for ; Wed, 14 Jan 2026 11:57:16 -0800 (PST) Received: from x1.com ([142.188.210.156]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-944122d3040sm23024832241.4.2026.01.14.11.57.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 11:57:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768420637; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ookbNDOLagx2JfHgzSX/g339CgGoZ3zgHlF0JmqVAA8=; b=Fp9YyoEIvQFiq9NOzRtwO/CONnIW2t2yVePhsMWqVthsJSPeO8BCeL2fVD0BY85Vzs4+eX +zygKGDsD5Jhp/K0XOdsRReTWRevMUH5EXax4JaJonvZA3vLS3ROVWn7ZEb8ePzU08fYOc 8IKGYuLTwNnVwsfz8xxFhMfFfDJTLVg= X-MC-Unique: 1IFgXt6DNryR4Hou7DujXQ-1 X-Mimecast-MFC-AGG-ID: 1IFgXt6DNryR4Hou7DujXQ_1768420636 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768420636; x=1769025436; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ookbNDOLagx2JfHgzSX/g339CgGoZ3zgHlF0JmqVAA8=; b=YQymFiU0epO2zOadjjKXAXirOvPWQuKM2x1awLY61DxVq1kEAXEGDCHIsh6pLGeuDW zUjedKtrj+0qHN+C7aT8Dfsq59UMpdv9+RxPeaG+5rD6aH2UTrSDYfxWYEVOssm1d9CQ DRj5H5Gd3IsyOKLA6KTkXcm57KRuAT42+8m/sgHydbTs7JLczqvxluAc9YPJ9hlcnnoR oYYyHEosmHmyqWyWPcgKCv299ffDRgAqa5NpcpkojU9LkvmeT8xZ3qu+rOhhVFe7GB2O qCtx+BvdZALYpxhzEPGvaet7h9v1hwpGP8wEhGfc98X1XqXgncsWJr122FxgVaYKO9qw MNjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768420636; x=1769025436; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ookbNDOLagx2JfHgzSX/g339CgGoZ3zgHlF0JmqVAA8=; b=shs69OAuC0zpW3rlOmI6ViOnWrmR/vBo6luZo/ic0dm7+wxIuk4Ba2wltU+qSmQyNq twJaSSRoS1YUOjJLsd5bMqMPaLJaON4oe+XMKCLPwmoc722KstKID/1Ah63j0Y3Qj/dW 5TsWYPlfyF/LEfDVcDe0ZsqW39sKS7WyK9YXOMn39x31WLsqWuXNyoKWmwqy8e1NnFDP dl7qgLnX3vCw1L8iNmu/dslDBn42hdrVaoGr/19W0Jr0+pLHGJtq5NUrhdFNarOLfe00 jyhA8Q/JZUQBMCRwYF88KSotdbBlvecs5FTW8BXYXsoir39u6/VKdXBkhDZ1GlSGGZP8 xWpA== X-Gm-Message-State: AOJu0YxI4vJt8QMKQPQiZleJwxkagRM1F2+dLgBvSGQIBsAGn0cJhvy8 lDzzFExuynZSbM0728mhB/f5l37PSf0nHPHo33CLP/5O07j8UQnz0zJOoRQY5B8cvW1xNbveUrn UG1J0Q0Hg1iUfjLtzfdbeVIQU+cV7G9cwI/v1VYM9pmcEmCEv0fU8WHfcz1qioO3mHq9JXA+9xd apRgjhNEizbEkfaamlG9P63IC9lT54SvjebUyF/A== X-Gm-Gg: AY/fxX6Qa3ktHIKnnYO5kNw/3BYSyLl+Qx9UnxOg4qJWkl4etQyYUV6+knEZZfIu3Ct qcqVIvtXX3ZfOKbq+AIom2rZ0CqqvmRNtLE7IcDdwAMyPl47XkoFCppkPX1/M9p5U59GzuDog4J rMFbJAJmxSkOxMqVcnBVxRBKsC0ktazTFtsoXPkvHx4XCnFAQ/UR92ZKuBhTuO3+K3jkBdPQPiM k28gsgfPgLoRbqyMc/HFQldI+TEcn6PUoRPKbMlHVllHtMYCilx+ngbVIDy6GsRC1d52SFQ3GTg nvDl03lih1KB5VSMRa6Ctqh6zZHk8ts45jsOX04zaP4hWcUpN0t3PQtL50ZOEtgHj32ysjwWVOU 9 X-Received: by 2002:a05:6102:94e:b0:5ef:24aa:986f with SMTP id ada2fe7eead31-5f1838967f1mr1527227137.2.1768420635725; Wed, 14 Jan 2026 11:57:15 -0800 (PST) X-Received: by 2002:a05:6102:94e:b0:5ef:24aa:986f with SMTP id ada2fe7eead31-5f1838967f1mr1527201137.2.1768420635106; Wed, 14 Jan 2026 11:57:15 -0800 (PST) From: Peter Xu To: qemu-devel@nongnu.org Cc: Juraj Marcin , Fabiano Rosas , Markus Armbruster , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , peterx@redhat.com, =?UTF-8?q?Luk=C3=A1=C5=A1=20Doktor?= , Juan Quintela , "Dr. David Alan Gilbert" , Zhang Chen , zhanghailiang@xfusion.com, Li Zhijian , Jason Wang Subject: [PATCH 1/3] migration/colo: Deprecate COLO migration framework Date: Wed, 14 Jan 2026 14:56:57 -0500 Message-ID: <20260114195659.2543649-2-peterx@redhat.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260114195659.2543649-1-peterx@redhat.com> References: <20260114195659.2543649-1-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1768420697729158500 COLO was broken for QEMU release 10.0/10.1 without anyone noticed. One reason might be that we don't have an unit test for COLO (which we explicitly require now for any new migration feature). The other reason should be that there are just no more active COLO users, at least based on the latest development of QEMU. I don't remember seeing anything really active in the past few years in COLO development. Meanwhile, COLO migration framework maintainer (Hailiang Zhang)'s last email to qemu-devel is in Dec 2021 where the patch proposed an email change (<20211214075424.6920-1-zhanghailiang@xfusion.com>). We've discussed this for a while, see latest discussions here (our thoughts of deprecating COLO framework might be earlier than that, but still): https://lore.kernel.org/r/aQu6bDAA7hnIPg-y@x1.local/ https://lore.kernel.org/r/20251230-colo_unit_test_multifd-v1-0-f9734bc74c71= @web.de Let's make it partly official and put COLO into deprecation list. If anyone cares about COLO and is deploying it, please send an email to qemu-devel to discuss. Otherwise, let's try to save some energy for either maintainers or developers who is looking after QEMU. Let's save the work if we don't even know what the work is for. Cc: Luk=C3=A1=C5=A1 Doktor Cc: Juan Quintela Cc: Dr. David Alan Gilbert Cc: Zhang Chen Cc: zhanghailiang@xfusion.com Cc: Li Zhijian Cc: Jason Wang Signed-off-by: Peter Xu Reviewed-by: Fabiano Rosas --- docs/about/deprecated.rst | 6 ++++++ qapi/migration.json | 5 ++--- migration/options.c | 4 ++++ 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 7abb3dab59..b499b2acb0 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -580,3 +580,9 @@ command documentation for details on the ``fdset`` usag= e. =20 The ``zero-blocks`` capability was part of the block migration which doesn't exist anymore since it was removed in QEMU v9.1. + +COLO migration framework (since 11.0) +''''''''''''''''''''''''''''''''''''' + +To be removed with no replacement, as the COLO migration framework doesn't +seem to have any active user for a while. diff --git a/qapi/migration.json b/qapi/migration.json index 201dedd982..3c868efe38 100644 --- a/qapi/migration.json +++ b/qapi/migration.json @@ -531,8 +531,7 @@ # # @unstable: Members @x-colo and @x-ignore-shared are experimental. # -# @deprecated: Member @zero-blocks is deprecated as being part of -# block migration which was already removed. +# @deprecated: Member @zero-blocks and @x-colo are deprecated. # # Since: 1.2 ## @@ -540,7 +539,7 @@ 'data': ['xbzrle', 'rdma-pin-all', 'auto-converge', { 'name': 'zero-blocks', 'features': [ 'deprecated' ] }, 'events', 'postcopy-ram', - { 'name': 'x-colo', 'features': [ 'unstable' ] }, + { 'name': 'x-colo', 'features': [ 'unstable', 'deprecated' ] }, 'release-ram', 'return-path', 'pause-before-switchover', 'multifd', 'dirty-bitmaps', 'postcopy-blocktime', 'late-block-activate', diff --git a/migration/options.c b/migration/options.c index 9a5a39c886..318850ba94 100644 --- a/migration/options.c +++ b/migration/options.c @@ -580,6 +580,10 @@ bool migrate_caps_check(bool *old_caps, bool *new_caps= , Error **errp) warn_report("zero-blocks capability is deprecated"); } =20 + if (new_caps[MIGRATION_CAPABILITY_X_COLO]) { + warn_report("COLO migration framework is deprecated"); + } + #ifndef CONFIG_REPLICATION if (new_caps[MIGRATION_CAPABILITY_X_COLO]) { error_setg(errp, "QEMU compiled without replication module" --=20 2.50.1 From nobody Mon Feb 9 10:33:14 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1768420696; cv=none; d=zohomail.com; s=zohoarc; b=WLYR+Y2xXsO0owSk8wEdK15eLa/EIIOtBCECwl8TwIRTxZWGn+hD/h5RvrkGnEjpl0lX1BD8WJfjpLtA1mnWYa2qRv55w1aCrfQhHMOCfmPYLAR0TMHXZG1n4R7Xamh9Rd4KboVV+RFC9IUJfV+BqLE0irjsvNArkgtCbzqH1NQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768420696; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=2bYt2DfDycuBHru+tnnZlfBQjJPIyfZZW47KxB1sqtI=; b=RYzLlSjFftxIOCgMI0KYFjaHUsq/P6mRqi/bcoJG3dJDQQgr5ONUQPXPYMF1c72VBthFBjPwXeOVv8jyCWpmy3Mu/Srv6bhp9LIXiNvB+8y967676SU+oxBIgKdLmYqWB0l43ITCN8jK8f1z8F9Shti8KaUQBY4PtcLCzG7/+M4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768420696008437.43724687485746; Wed, 14 Jan 2026 11:58:16 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vg702-0001Xs-2B; Wed, 14 Jan 2026 14:57:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vg6ze-0001NN-NT for qemu-devel@nongnu.org; Wed, 14 Jan 2026 14:57:29 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vg6zc-00023I-Vy for qemu-devel@nongnu.org; Wed, 14 Jan 2026 14:57:26 -0500 Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-541-UbSbG3KHM2CDNbtFonziBA-1; Wed, 14 Jan 2026 14:57:22 -0500 Received: by mail-ua1-f70.google.com with SMTP id a1e0cc1a2514c-93f4ff789c5so593006241.3 for ; Wed, 14 Jan 2026 11:57:22 -0800 (PST) Received: from x1.com ([142.188.210.156]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-944122d3040sm23024832241.4.2026.01.14.11.57.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 11:57:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768420643; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2bYt2DfDycuBHru+tnnZlfBQjJPIyfZZW47KxB1sqtI=; b=RzBMZt7Izzo3Xvh+FzQrQ3p6r3qLOkccw80qFx9g6UNtxyYcSvTI1dhcn/zliyexKlm1je 8yTxdygJaz2Ppp6yiDFVeNPW0YIWFmDw6n2bNN7ERAwVoduRTqnMlypSx3WmsGFlPjDh3s LqYjdf0dlSYI3xdIan6gqDc8VqrCiR4= X-MC-Unique: UbSbG3KHM2CDNbtFonziBA-1 X-Mimecast-MFC-AGG-ID: UbSbG3KHM2CDNbtFonziBA_1768420642 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768420641; x=1769025441; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2bYt2DfDycuBHru+tnnZlfBQjJPIyfZZW47KxB1sqtI=; b=pCoALMP9Km76CYPgl6Cz/7fmhFyUkmXCs13LSUFJlwaF5sPDW2ykFqClFRxSPZ1tq4 A5rcWsIQh6pL4eLQ0iiLiAGoeKEUy5AZ31656Nenkj7AuhqohBhW+L2Z+KVHfEnCTJ5y XUr2vh+6UwTALONW1GJBZso5FL45WojmsFy+Y9Jz/yQzxvrmUqs6lDIIoCe5sOOfE409 ASW08RSlOvxRTg0WKKVa5iUtrXRpZNvElYYbftiZwt8AWO8ZQkXG978iusUQEluKXXC0 i9ueNmAwY1a5u24jW6NMz5PJN3VWgrtmU/DC6YRiYDJ7SQ9cPIkEZ6+Hcf+ZGKsX78l9 BX2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768420641; x=1769025441; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2bYt2DfDycuBHru+tnnZlfBQjJPIyfZZW47KxB1sqtI=; b=vCt8AyLBIpj3P7TSC4HqzE7yF3WVROSYIpoveX1lSjyYGEvNdWnPHBcH0fxJN+0BCy aZUo6LSUWCWU0TaOwwaQaHnD6fR3DA1yaXuj/5hrCSiPxfpwT3tC6E8HPL0bUyDuF0J8 IkwwwxNiueidldMuWXFvQtlkpgq+3HAN5JhAuhbF4PImuFa49MSDJtpNicjXOOfKcr+s AXIamr/GbUPK1df8oIP2z7qvdXI2vzbC7Gv+86SaGkoHtWUYE6IL8vqqpcj+wd/KX9ui /YN9met+Vpxok0JRJ2AoSDLfh/f7zTd8GLFlk6rxveTAyQJdVCIwfRr4MX+ZlFhTMbn/ xk3w== X-Gm-Message-State: AOJu0YxOsofjBken+H/RAbLJitOGnyh9pigxg7kaf6jDUnCgMvZ5SQXY OKIJAKhzmwe1tX4/WKiNmV7PBn7nlB4Mciavu09WFh6K7n9nODQQjPoy36t+YsF/KylvZ3O4nJ5 Wqe5493gc+ojBbIlvYZXnPQp4bUeClkgiGSlovtH+G9B677Sr5nzkF+u1DBBoIfNNMxf2j+7PId JXl/7pZoa2/E/dt253zKCCU0/RutrtoBgyJVzWOw== X-Gm-Gg: AY/fxX5hfSkqtBbzGwk/mrXTxDQmi7+4RVpCD4uJAt73eci8lIMjhKX+Z2Bey0SILTQ 3pDrwD9Yv7HzRXbjq4JQ3upwkKWImfW9dwrA4+FRxt2iD0igYNMQR/3H7DtI64EB5z1ROXSYe/F Rx2HAqDgHIRPdNEb2DC6H33FacQsARJqsUcT9V1sb4gjMgsto9Ar2eOAzBALhFIxERc7amf9h8K 7v2D65jlPis7abppNAFR2qkdmC8GJSqzqs2tLGr5Ff+oHD4YhntbbhU1l8VNIKEPjWPA/0MChfU d8ibKOrVGLPY8OC2ZV8+8OrMVWonvLgMsBiDT5SWGlMazLNqMACfyXq7XkNDeZnGgxGaU+fY6I+ M X-Received: by 2002:a05:6102:f8c:b0:5ef:a67d:e957 with SMTP id ada2fe7eead31-5f1838c36edmr1567580137.17.1768420639927; Wed, 14 Jan 2026 11:57:19 -0800 (PST) X-Received: by 2002:a05:6102:f8c:b0:5ef:a67d:e957 with SMTP id ada2fe7eead31-5f1838c36edmr1567561137.17.1768420639358; Wed, 14 Jan 2026 11:57:19 -0800 (PST) From: Peter Xu To: qemu-devel@nongnu.org Cc: Juraj Marcin , Fabiano Rosas , Markus Armbruster , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , peterx@redhat.com Subject: [PATCH 2/3] migration: Remove zero-blocks capability Date: Wed, 14 Jan 2026 14:56:58 -0500 Message-ID: <20260114195659.2543649-3-peterx@redhat.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260114195659.2543649-1-peterx@redhat.com> References: <20260114195659.2543649-1-peterx@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1768420697514158500 Content-Type: text/plain; charset="utf-8" It was declared deprecated since 9.2. Signed-off-by: Peter Xu Reviewed-by: Fabiano Rosas --- docs/about/deprecated.rst | 6 ------ docs/about/removed-features.rst | 6 ++++++ qapi/migration.json | 11 +---------- migration/options.c | 5 ----- 4 files changed, 7 insertions(+), 21 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index b499b2acb0..6e4e2e4833 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -575,12 +575,6 @@ deprecated in favor of explicitly using the ``file:`` = URI with the file descriptor being passed as an ``fdset``. Refer to the ``add-fd`` command documentation for details on the ``fdset`` usage. =20 -``zero-blocks`` capability (since 9.2) -'''''''''''''''''''''''''''''''''''''' - -The ``zero-blocks`` capability was part of the block migration which -doesn't exist anymore since it was removed in QEMU v9.1. - COLO migration framework (since 11.0) ''''''''''''''''''''''''''''''''''''' =20 diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.= rst index e81d79da47..8a9d21068a 100644 --- a/docs/about/removed-features.rst +++ b/docs/about/removed-features.rst @@ -717,6 +717,12 @@ Block migration has been removed. For a replacement, s= ee "QMP invocation for live storage migration with ``blockdev-mirror`` + NBD" in docs/interop/live-block-operations.rst. =20 +``migrate-set-capabilities`` ``zero-blocks`` option (removed in 11.0) +''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' + +The ``zero-blocks`` capability was part of the block migration capability +that got removed. Removed with no replacement. + ``migrate-set-parameter`` ``compress-level`` option (removed in 9.1) '''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' =20 diff --git a/qapi/migration.json b/qapi/migration.json index 3c868efe38..490f72090e 100644 --- a/qapi/migration.json +++ b/qapi/migration.json @@ -440,13 +440,6 @@ # footprint is mlock()'d on demand or all at once. Refer to # docs/rdma.txt for usage. Disabled by default. (since 2.0) # -# @zero-blocks: During storage migration encode blocks of zeroes -# efficiently. This essentially saves 1MB of zeroes per block on -# the wire. Enabling requires source and target VM to support -# this feature. To enable it is sufficient to enable the -# capability on the source VM. The feature is disabled by -# default. (since 1.6) -# # @events: generate events for each migration state change (since 2.4) # # @auto-converge: If enabled, QEMU will automatically throttle down @@ -531,13 +524,12 @@ # # @unstable: Members @x-colo and @x-ignore-shared are experimental. # -# @deprecated: Member @zero-blocks and @x-colo are deprecated. +# @deprecated: Member @x-colo is deprecated. # # Since: 1.2 ## { 'enum': 'MigrationCapability', 'data': ['xbzrle', 'rdma-pin-all', 'auto-converge', - { 'name': 'zero-blocks', 'features': [ 'deprecated' ] }, 'events', 'postcopy-ram', { 'name': 'x-colo', 'features': [ 'unstable', 'deprecated' ] }, 'release-ram', @@ -594,7 +586,6 @@ # {"state": false, "capability": "xbzrle"}, # {"state": false, "capability": "rdma-pin-all"}, # {"state": false, "capability": "auto-converge"}, -# {"state": false, "capability": "zero-blocks"}, # {"state": true, "capability": "events"}, # {"state": false, "capability": "postcopy-ram"}, # {"state": false, "capability": "x-colo"} diff --git a/migration/options.c b/migration/options.c index 318850ba94..edb16ad9fa 100644 --- a/migration/options.c +++ b/migration/options.c @@ -188,7 +188,6 @@ const Property migration_properties[] =3D { DEFINE_PROP_MIG_CAP("x-xbzrle", MIGRATION_CAPABILITY_XBZRLE), DEFINE_PROP_MIG_CAP("x-rdma-pin-all", MIGRATION_CAPABILITY_RDMA_PIN_AL= L), DEFINE_PROP_MIG_CAP("x-auto-converge", MIGRATION_CAPABILITY_AUTO_CONVE= RGE), - DEFINE_PROP_MIG_CAP("x-zero-blocks", MIGRATION_CAPABILITY_ZERO_BLOCKS), DEFINE_PROP_MIG_CAP("x-events", MIGRATION_CAPABILITY_EVENTS), DEFINE_PROP_MIG_CAP("x-postcopy-ram", MIGRATION_CAPABILITY_POSTCOPY_RA= M), DEFINE_PROP_MIG_CAP("x-postcopy-preempt", @@ -576,10 +575,6 @@ bool migrate_caps_check(bool *old_caps, bool *new_caps= , Error **errp) ERRP_GUARD(); MigrationIncomingState *mis =3D migration_incoming_get_current(); =20 - if (new_caps[MIGRATION_CAPABILITY_ZERO_BLOCKS]) { - warn_report("zero-blocks capability is deprecated"); - } - if (new_caps[MIGRATION_CAPABILITY_X_COLO]) { warn_report("COLO migration framework is deprecated"); } --=20 2.50.1 From nobody Mon Feb 9 10:33:14 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1768420704; cv=none; d=zohomail.com; s=zohoarc; b=MVqjLHcuZ3QFucd1lr9RkCADfKP1mUMGVDWcaFFICMTxMq4GdMIiueS6V5ZCFbmmbAiMAYHTOiEmkfgovzGEiCfpkZczAdR3xFGxowPS0fk7hiZZdhgtYy1h03Y96Q/FpZem/kpBkscd+dzJbDFci/wDMuPlWV9bYYYoDxrm4Ak= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768420704; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Sao1wRkhL19NI6f8FC0xP3/0GVRrrC/sElfaU9Azbvw=; b=ZS2yeGckDgT9vdYA7dF/Q3xRvkkLzxZbCEvUQxXnux+MxpaJ3pDwC+zS0xzhRbp2Cah+t/7PdacEI0d7v7mVe5jFYYP3ebxLdXRRW4a0b9X+Rc7fNFKewzcsp0nx50gA75VbMczq/SwcG4Jiwcqgx8GLt8cBc68HQX3UQanwVmE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768420704917543.4325135458398; Wed, 14 Jan 2026 11:58:24 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vg702-0001bm-Qy; Wed, 14 Jan 2026 14:57:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vg6zh-0001Nx-Ae for qemu-devel@nongnu.org; Wed, 14 Jan 2026 14:57:35 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vg6zf-00023U-GV for qemu-devel@nongnu.org; Wed, 14 Jan 2026 14:57:29 -0500 Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-361-Zp13_39WPLmLNNwHeqdsxg-1; Wed, 14 Jan 2026 14:57:25 -0500 Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-5ed0a71c0beso162778137.2 for ; Wed, 14 Jan 2026 11:57:25 -0800 (PST) Received: from x1.com ([142.188.210.156]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-944122d3040sm23024832241.4.2026.01.14.11.57.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 11:57:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768420646; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Sao1wRkhL19NI6f8FC0xP3/0GVRrrC/sElfaU9Azbvw=; b=fDHxKhtjjMqkV3tWmiy5+u8q02A+O4T0ypzaCf7S/eab8xLqJ+LXERHNknI0yl4z8wg3Dw +4BiX31UYK/moAlr/QoYssmXGRoxhHHClmOP6udMbyruL6GEHoVWPKk69wRJTy8UhXjxgc sY0rsT/hPv4ZvMw29w4eR13tyfjXuLY= X-MC-Unique: Zp13_39WPLmLNNwHeqdsxg-1 X-Mimecast-MFC-AGG-ID: Zp13_39WPLmLNNwHeqdsxg_1768420644 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768420644; x=1769025444; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Sao1wRkhL19NI6f8FC0xP3/0GVRrrC/sElfaU9Azbvw=; b=guW4VtDEIgm3Zf1lW5DWg9HTQjNYdwhiG2BqmloUg+JcvlQ0UZIMVPJ+K+AjCNDmLz 1sjjZONPh2jQbe6XO08sLTiuJfelKeinEcyXvhSY0jVG0anQsXQ/8zVdlWolxvs5jkzi MhL6fLSp8ZBiN9ZZB29ggbvDDs7zpYxLw/s3MLPnubOUZCwOIRNda4iccXQLa3S3k2Jj 7DlurymPMzBSF9zSLTVCljy6sLtYbhIdrN7j5XodRTnEsOCjOJ0uXViemQ6BKz6oPwI+ OTPD+rXskZ/RYKSAS60Oodw1S4pkLfTBKBApKHm350IAa42Slfu8A5PNWPKmWGuDAH1Q Whfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768420644; x=1769025444; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Sao1wRkhL19NI6f8FC0xP3/0GVRrrC/sElfaU9Azbvw=; b=IKjhCxD/2pbpV1b9Fv3QPd6yG2kmJEESOT0dwjVpFcyGiGN6sdvltzHXj+SgMrNJZ3 FeIe+Tsv1au6JTHQEzyx1H1A/WhJyqFklhR793Y3igyNhaFvSv8/3Jln5Z57KmdRJLVI JOekxbWFcWPU84/ofXvy3ddAwCPZTZa6RHQrNNaJPVG9so581vD22AGZ2SMWw3cwgZzs TdljVaV5TGjqxfbsyFcq1hspRKIjKC073itmTPxY8Ser5ZBpPWOhDyOiyG16+gvRAJQv 29eBkpXoi1PQs43rkD+JA1FVwyjgAUlPWu2l0HZ1gj5ZNHKfWbGM6Yjpeex5V6JTh10a yIjg== X-Gm-Message-State: AOJu0Yye77kVE11nAZvb4INZS97wALlycdH9cfW5i51tdXysWvYcyY9C YIU4xNPNI78qoiZX77+vA4Juwz056KJgbe8HZYNoURDUAmj6wU8CCDRHwxW+h2+r/oXCQb46h2B UBfBk84DCm+2cU+SOA+nxtko/INrToEFVe3nKKeapfHubFEnfhHHnkG17VdQqpYioNhQxqAD7xU yDiMLfvj+lnW1ppk3+3nMgeALanGwZq9jVu+bePQ== X-Gm-Gg: AY/fxX5jZYHet0ZNG6i8SR+dT60iIlesW5TzfRqqqanwClGzCpdsJoOWAbc4xdMeTS7 lc8eFHnE+2gAnXDyxrzsmKhNcZRxrTeKGFBJAez8oQLBVtyhFA8MakbJH5WNIUrS2HgQPY4pkdG B7lqBmGB8qtd8mr3vUy7EQJDDhNFyKUnaP+Mu8USORA0vwtGZNnVNviUBsmsvXrQ7BBFB3xXUey 5MGN3bLs/fzuDt0rYPyY2xjYlWnHZpte2CJTxZeP9cwPIZpt3mOWThaQJQJobf8jGL6G/z/YXs+ X894xTUJPy1P8RNoLkd7FN1F6BiYRnBCLg2ywXpequdvWjdV3hasyKz+mx57CsMru85s929qmvF V X-Received: by 2002:a05:6102:94e:b0:5ef:24aa:986f with SMTP id ada2fe7eead31-5f1838967f1mr1527372137.2.1768420644146; Wed, 14 Jan 2026 11:57:24 -0800 (PST) X-Received: by 2002:a05:6102:94e:b0:5ef:24aa:986f with SMTP id ada2fe7eead31-5f1838967f1mr1527359137.2.1768420643550; Wed, 14 Jan 2026 11:57:23 -0800 (PST) From: Peter Xu To: qemu-devel@nongnu.org Cc: Juraj Marcin , Fabiano Rosas , Markus Armbruster , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , peterx@redhat.com Subject: [PATCH 3/3] migration: Remove fd: support on files Date: Wed, 14 Jan 2026 14:56:59 -0500 Message-ID: <20260114195659.2543649-4-peterx@redhat.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260114195659.2543649-1-peterx@redhat.com> References: <20260114195659.2543649-1-peterx@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1768420705244158501 Content-Type: text/plain; charset="utf-8" This feature was deprecated in 9.1. Remove it in this release (11.0). Signed-off-by: Peter Xu Reviewed-by: Fabiano Rosas Reviewed-by: Prasad Pandit --- docs/about/deprecated.rst | 11 ----------- docs/about/removed-features.rst | 9 +++++++++ migration/fd.c | 11 +++++++---- 3 files changed, 16 insertions(+), 15 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 6e4e2e4833..76ac735315 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -564,17 +564,6 @@ be rejected. Migration --------- =20 -``fd:`` URI when used for file migration (since 9.1) -'''''''''''''''''''''''''''''''''''''''''''''''''''' - -The ``fd:`` URI can currently provide a file descriptor that -references either a socket or a plain file. These are two different -types of migration. In order to reduce ambiguity, the ``fd:`` URI -usage of providing a file descriptor to a plain file has been -deprecated in favor of explicitly using the ``file:`` URI with the -file descriptor being passed as an ``fdset``. Refer to the ``add-fd`` -command documentation for details on the ``fdset`` usage. - COLO migration framework (since 11.0) ''''''''''''''''''''''''''''''''''''' =20 diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.= rst index 8a9d21068a..538914ef00 100644 --- a/docs/about/removed-features.rst +++ b/docs/about/removed-features.rst @@ -710,6 +710,15 @@ Use blockdev-mirror with NBD instead. See "QMP invocat= ion for live storage migration with ``blockdev-mirror`` + NBD" in docs/interop/live-block-operations.rst for a detailed explanation. =20 +``migrate`` command with file-based ``fd:`` URI (removed in 11.0) +''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' + +In order to reduce ambiguity, the ``fd:`` URI usage of providing a +file descriptor to a plain file has been removed in favor of +explicitly using the ``file:`` URI with the file descriptor being +passed as an ``fdset``. Refer to the ``add-fd`` command documentation +for details on the ``fdset`` usage. + ``migrate-set-capabilities`` ``block`` option (removed in 9.1) '''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' =20 diff --git a/migration/fd.c b/migration/fd.c index 9bf9be6acb..fdeece2101 100644 --- a/migration/fd.c +++ b/migration/fd.c @@ -24,6 +24,7 @@ #include "qemu/sockets.h" #include "io/channel-util.h" #include "trace.h" +#include "qapi/error.h" =20 static bool fd_is_pipe(int fd) { @@ -58,8 +59,9 @@ void fd_start_outgoing_migration(MigrationState *s, const= char *fdname, Error ** } =20 if (!migration_fd_valid(fd)) { - warn_report("fd: migration to a file is deprecated." - " Use file: instead."); + error_setg(errp, "fd: migration to a file is not supported." + " Use file: instead."); + return; } =20 trace_migration_fd_outgoing(fd); @@ -92,8 +94,9 @@ void fd_start_incoming_migration(const char *fdname, Erro= r **errp) } =20 if (!migration_fd_valid(fd)) { - warn_report("fd: migration to a file is deprecated." - " Use file: instead."); + error_setg(errp, "fd: migration to a file is not supported." + " Use file: instead."); + return; } =20 trace_migration_fd_incoming(fd); --=20 2.50.1