From nobody Tue Feb 10 00:39:56 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1768394894; cv=none; d=zohomail.com; s=zohoarc; b=d/qkNblBpqGrjlkIvVpFzNGBG6fea1OdBCwC+Gtw1KUmpN01nytadeM7fl2bEjYCpAcVx//35vq/4jIPSp29z54zGRRwbxCk0m5gxq/G66kybg5ZPHt/2rkvSqFthKrBye6A4NzET0qYUZDQWo3yb8+ZpQtqFJFpciNYNKkZIOE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768394894; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=PntajisC8njaCy71Ybp4/FdRN4ipfhaZSgrGYuu0XY4=; b=PhhLnMvkuc5GR2qB2fBNcLz44+7ZXA89DfnqXKggH6T1RD8a7D3yTgRRXlPFRrBlSfwy048x2MgessdmBCo5QNFhvZ3Ucz1LbKrBykk+daHhe5Pe7vFpHCm8n4sCglmluxbTE6p3pB1rmwvyyu0jBYF8LhcJZfluDJhGpTysxO4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176839489404743.5325104359805; Wed, 14 Jan 2026 04:48:14 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vg0Ht-00062J-7S; Wed, 14 Jan 2026 07:47:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vg0HZ-0005tB-MV for qemu-devel@nongnu.org; Wed, 14 Jan 2026 07:47:35 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vg0HV-0002DP-C5 for qemu-devel@nongnu.org; Wed, 14 Jan 2026 07:47:28 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-348-sx913RTCOQyrarFz6Cj08w-1; Wed, 14 Jan 2026 07:47:17 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8380818005A7; Wed, 14 Jan 2026 12:47:16 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.32]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2D5C11800240; Wed, 14 Jan 2026 12:47:16 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id A036121E6932; Wed, 14 Jan 2026 13:47:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768394840; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PntajisC8njaCy71Ybp4/FdRN4ipfhaZSgrGYuu0XY4=; b=JWfOo2DtogNiGQLe6Gs4zAcvqyLwkNqdLKURM+KyY6f9StvR/anEluBk+TPAObcbWZ83Yb bGwblWKUXFQE03ng5g6ovBvUuhgWHLEV0RjfBXiI1aQHzv/o0Mj6OKbbMf/D7B2J0sgg5z lm8VJCgoSzs26bJlubAzRf3xLHH0TwA= X-MC-Unique: sx913RTCOQyrarFz6Cj08w-1 X-Mimecast-MFC-AGG-ID: sx913RTCOQyrarFz6Cj08w_1768394836 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: berrange@redhat.com, dave@treblig.org Subject: [PATCH 2/3] error: Restore error_printf()'s function comment Date: Wed, 14 Jan 2026 13:47:12 +0100 Message-ID: <20260114124713.3308719-3-armbru@redhat.com> In-Reply-To: <20260114124713.3308719-1-armbru@redhat.com> References: <20260114124713.3308719-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1768394896524158500 Content-Type: text/plain; charset="utf-8" Lost in commit 397d30e9401 (qemu-error: remove dependency of stubs on monitor) many moons ago. Signed-off-by: Markus Armbruster Reviewed-by: Daniel P. Berrang=C3=A9 --- util/error-report.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/util/error-report.c b/util/error-report.c index f051f29b2d..0b1c214dc7 100644 --- a/util/error-report.c +++ b/util/error-report.c @@ -29,6 +29,9 @@ bool message_with_timestamp; bool error_with_guestname; const char *error_guest_name; =20 +/* + * Print to current HMP monitor if we have one, else to stderr. + */ int error_printf(const char *fmt, ...) { va_list ap; --=20 2.52.0