From nobody Mon Feb 9 02:38:20 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1768387692; cv=none; d=zohomail.com; s=zohoarc; b=Gsb5VrnmVu2h2tfZW5QKxB1MwrlSeveaWRmAerKVkLo5zXVd3fZqgnG7BeDjrKwhRN9pP1ZfUMWxRFkrzrzNoIu6UlTgzg4ZLOktCG/nP+7K6x3lImYAeFg4I05g5XmFTvbrJgDGA2ev8ZHIllUfC6WHnJ1N8xFmcBi5j5UT/q4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768387692; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=6EmAQR4EZx7SMVTmNx04klkeA/JCucQ3GsUeVLPeDj4=; b=b/RiJL0eNHwPXBTfPI3i8dELMapakLEuFcDCUJdD/QYX108HnGt0JpP2wdtCNvwm0LOm6aqKNFsOua2MFj+3gwlOTN4jQ0bsoKzHJ0fDEtxei1Cvg19QaA12lK5JlUpE0VoLH32hvbGKkwkYOMVTCxu+XDLfs/pGQIBMT3XxhFk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768387692290523.547117915758; Wed, 14 Jan 2026 02:48:12 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vfyPr-0005xz-PX; Wed, 14 Jan 2026 05:47:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfyPp-0005wF-GP for qemu-devel@nongnu.org; Wed, 14 Jan 2026 05:47:53 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfyPo-0005dj-2G for qemu-devel@nongnu.org; Wed, 14 Jan 2026 05:47:53 -0500 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-516-UOjtHp__M_SANgbp32uaqA-1; Wed, 14 Jan 2026 05:47:49 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BBA72195422D for ; Wed, 14 Jan 2026 10:47:48 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.45.224.56]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 332B5180009E; Wed, 14 Jan 2026 10:47:48 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 9914A1800081; Wed, 14 Jan 2026 11:47:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768387670; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=6EmAQR4EZx7SMVTmNx04klkeA/JCucQ3GsUeVLPeDj4=; b=PYI7mktgebaShSO50b167WQbKZACa9w8Ox+y/hadJ7rZWhKVrDUgNzhrz47KJ4cFnLp+0A og90ZEpTfOH6yfCYFlVcFHEIU9wXndbXhST97H/EFW+mAnrGGavH8vgkXoaafgmjNiZ0cb +TwCzYHWRzI5//G3HDyIxa/ct6n3LS0= X-MC-Unique: UOjtHp__M_SANgbp32uaqA-1 X-Mimecast-MFC-AGG-ID: UOjtHp__M_SANgbp32uaqA_1768387668 From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: Gerd Hoffmann Subject: [PATCH] hw/uefi: fix size negotiation Date: Wed, 14 Jan 2026 11:47:45 +0100 Message-ID: <20260114104745.3465860-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1768387701820158500 Content-Type: text/plain; charset="utf-8" Payload size is the variable request size, not the total buffer size. Take that into account and subtract header sizes. Fixes: db1ecfb473ac ("hw/uefi: add var-service-vars.c") Signed-off-by: Gerd Hoffmann --- hw/uefi/var-service-vars.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/uefi/var-service-vars.c b/hw/uefi/var-service-vars.c index 8533533ea5c8..5607763525b3 100644 --- a/hw/uefi/var-service-vars.c +++ b/hw/uefi/var-service-vars.c @@ -592,7 +592,7 @@ uefi_vars_mm_get_payload_size(uefi_vars_state *uv, mm_h= eader *mhdr, return uefi_vars_mm_error(mhdr, mvar, EFI_BAD_BUFFER_SIZE); } =20 - ps->payload_size =3D uv->buf_size; + ps->payload_size =3D uv->buf_size - sizeof(*mhdr) - sizeof(*mvar); mvar->status =3D EFI_SUCCESS; return length; } --=20 2.52.0