From nobody Mon Feb 9 04:28:14 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768327666546469.7824505008957; Tue, 13 Jan 2026 10:07:46 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vfin6-0001J4-V0; Tue, 13 Jan 2026 13:07:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfiUC-0005OB-7H for qemu-devel@nongnu.org; Tue, 13 Jan 2026 12:47:24 -0500 Received: from omta038.useast.a.cloudfilter.net ([44.202.169.37]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfiUA-0004OZ-GH for qemu-devel@nongnu.org; Tue, 13 Jan 2026 12:47:19 -0500 Received: from eig-obgw-5002b.ext.cloudfilter.net ([10.0.29.226]) by cmsmtp with ESMTPS id fhg2vVh66SkcffiU6vo0mx; Tue, 13 Jan 2026 17:47:14 +0000 Received: from gator4203.hostgator.com ([108.167.189.28]) by cmsmtp with ESMTPS id fiU6vBtciN3K1fiU6vwIXZ; Tue, 13 Jan 2026 17:47:14 +0000 Received: from fctnnbsc51w-159-2-155-244.dhcp-dynamic.fibreop.nb.bellaliant.net ([159.2.155.244]:43750 helo=localhost.localdomain) by gator4203.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.99.1) (envelope-from ) id 1vfiU6-00000000Zbm-0Xgr; Tue, 13 Jan 2026 11:47:14 -0600 X-Authority-Analysis: v=2.4 cv=UdRRSLSN c=1 sm=1 tr=0 ts=69668522 a=fpD4kzfX7W8RbeKAuMGPiQ==:117 a=fpD4kzfX7W8RbeKAuMGPiQ==:17 a=vUbySO9Y5rIA:10 a=HaeQS5oA3WMA:10 a=no2vxl2JlCt9nLFxYVgA:9 a=tGAC0SnQRR4URLD-nMig:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=aktech.ai; s=default; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=CPxz7M4/BVwHD3ZLJ9NFqVxD/zKWNuDnQ0zKbpPa1/o=; b=L31tVzP27wibor6SlFMIi180rq BpSxNJIewkD7k9jw55cAhqTbBetndY6dS2oI1RhnJwcI69PEDOAEM7HythmBfW3SNmUEqYTDzhxAu bXhfaTwcZlcyZy44uF+hCLoJGZg9OCLgdAo41X7kOovZfeip2MM0Y+SjGjYrzebuDjX8AFBvEp1kh +Ee7BfNYMgAGDrxvrXSHPKDPDgI/DQe814NZHFO8kUj2CfVWfhf8fxR695FLmNnbkpetr3ftTXpfb sbCSo5MAb9L75z1Cqxm/DGtfTSV9N/vgpN7lPCj34aaSFhj2I0OiDQLQj1D/mdexhcHlEUYtkVvZY 6hD3habA==; From: Aidan Khoury To: qemu-devel@nongnu.org Cc: aidan@revers.engineering, Aidan Khoury Subject: [PATCH] i386/cpu: Fix unexpected initializer override in Diamond Rapids CPU model definition Date: Tue, 13 Jan 2026 13:46:42 -0400 Message-ID: <20260113174642.1636356-1-aidan@aktech.ai> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4203.hostgator.com X-AntiAbuse: Original Domain - nongnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - aktech.ai X-BWhitelist: no X-Source-IP: 159.2.155.244 X-Source-L: No X-Exim-ID: 1vfiU6-00000000Zbm-0Xgr X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: fctnnbsc51w-159-2-155-244.dhcp-dynamic.fibreop.nb.bellaliant.net (localhost.localdomain) [159.2.155.244]:43750 X-Source-Auth: aidan@aktech.ai X-Email-Count: 2 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: YWt0ZWNoYWk7YWt0ZWNoYWk7Z2F0b3I0MjAzLmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfMldb9+HoIuXmFbY4gHvc57Xb00axmjTa7n/w04T5HYybmMCkPEYsRn93ygIHwnwUrz+pUawSgYuAeiCu3R57uW0bnBAgfLCErNXBcN+ny+iJikAwmk0 2vVqzk3SuBU7GKE2+gRNZ2R2nlvkE2cYkR/8Urgj5Ly0W4+qNb5GERvcwnZH/WrlvXnCr7VMhBrnBdklkuU4hWOx8dSq9aZtrUk= Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=44.202.169.37; envelope-from=aidan@aktech.ai; helo=omta038.useast.a.cloudfilter.net X-Spam_score_int: -7 X-Spam_score: -0.8 X-Spam_bar: / X-Spam_report: (-0.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_BL_SPAMCOP_NET=1.347, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 13 Jan 2026 13:05:55 -0500 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1768327670311158500 Content-Type: text/plain; charset="utf-8" The new Diamond Rapids x86 cpu model definition that was added in 7a6dd8bde= 159 has an unexpected comma in the `.features[FEAT_VMX_EXIT_CTLS]` subobjec= t initializer causing the prior initialization to be overridden, meaning th= at `VMX_VM_EXIT_SAVE_DEBUG_CONTROLS | VMX_VM_EXIT_HOST_ADDR_SPACE_SIZE` is = not included. Fix this by replacing the comma with the missing bitwise OR to properly com= bine all the flags into a single bitmask value. Fixes: 7a6dd8bde159 ("i386/cpu: Add CPU model for Diamond Rapids") Signed-off-by: Aidan Khoury --- target/i386/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 37803cd724..917b37d128 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -5589,7 +5589,7 @@ static const X86CPUDefinition builtin_x86_defs[] =3D { MSR_VMX_EPT_INVVPID_ALL_CONTEXT | MSR_VMX_EPT_INVVPID_SINGLE_CONTEXT_NOGLOBALS, .features[FEAT_VMX_EXIT_CTLS] =3D - VMX_VM_EXIT_SAVE_DEBUG_CONTROLS | VMX_VM_EXIT_HOST_ADDR_SPACE_= SIZE, + VMX_VM_EXIT_SAVE_DEBUG_CONTROLS | VMX_VM_EXIT_HOST_ADDR_SPACE_= SIZE | VMX_VM_EXIT_LOAD_IA32_PERF_GLOBAL_CTRL | VMX_VM_EXIT_ACK_INTR_ON_EXIT | VMX_VM_EXIT_SAVE_IA32_PAT | VMX_VM_EXIT_LOAD_IA32_PAT | VMX_VM_EXIT_SAVE_IA32_EFER | --=20 2.43.0