From nobody Mon Feb 9 09:46:06 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1768302858; cv=none; d=zohomail.com; s=zohoarc; b=hTEx9/8xQcNbYBwqrCnwT586sw8RqLkBjy08Gs6ewxChZ3hXRPs/SY3F9J3Iruswj6GRjr6bapKJnacCuM6vO1LKC69I7+e0TTntf+Hyzi0BNk3I0+POuLt/URW+9fQrEm1XE0yvtDlF29mNxZvnl++YNVayZzr6EF1xgwYV2GU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768302858; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=JWfkiUEs3L3eRoPpvKnE7WI6HuZbSNuFySWoG+pF2vQ=; b=h6ziajWtL+2IKbAg1hP7Hxcnn4t0aLlUrujl/RUPjuB5sQkzAEsV7RAcOQy52S2DBfGqfDmfh/YQIMOxEy0Y+RyJZoK5mbulbCr/+ZAnG3OFAR3LPElFYuuJhiPdZnpnB2z9TmbFQYlEfaV8FCZpPF3SXTJ6s4/oZSxj+9SUZsY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768302858524899.8557898440048; Tue, 13 Jan 2026 03:14:18 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vfcLP-00034g-SH; Tue, 13 Jan 2026 06:13:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfcLI-00031g-4Z for qemu-devel@nongnu.org; Tue, 13 Jan 2026 06:13:45 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfcLG-0008Pe-Jw for qemu-devel@nongnu.org; Tue, 13 Jan 2026 06:13:43 -0500 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-255-G6j2cbXKPPuIrhMloB2kBg-1; Tue, 13 Jan 2026 06:13:40 -0500 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4776079ada3so74284495e9.1 for ; Tue, 13 Jan 2026 03:13:39 -0800 (PST) Received: from [192.168.10.48] ([151.61.26.160]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47ed9eb6fbesm12480785e9.4.2026.01.13.03.13.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 03:13:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768302821; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JWfkiUEs3L3eRoPpvKnE7WI6HuZbSNuFySWoG+pF2vQ=; b=AZ0CSl54v2TyfSfVRPJnzaPrBQeIn98uXW93ZnxepI9pzjc472Ee8UFgD3lOj8tg/4ZtrL vAJGpsFJSTmjvAmvFc5g/+4pN3bTeqoLRtuMTkTqXq+EkcaoMGTbkrtr15Zy+kihEIgGIV awisN71Tvcj0OM8gBRyzp6EkHu7YXQE= X-MC-Unique: G6j2cbXKPPuIrhMloB2kBg-1 X-Mimecast-MFC-AGG-ID: G6j2cbXKPPuIrhMloB2kBg_1768302819 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768302817; x=1768907617; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JWfkiUEs3L3eRoPpvKnE7WI6HuZbSNuFySWoG+pF2vQ=; b=Z3njKmGBV4/MWm1Q0ybkhca640X5e1k2YrTCNmkdzW7cxOPlQ95AoVS2MskDzYyFC2 jv5A2c61PmNrA4l7rd/CloRtrU/RwyuS+PMhZc/YaCTwUKBKWFHTf3h8XM9lWMACfyi8 LzoqMrOtku1IwxXrBCDt/zI6D5MGbHdGnclmvo/0INr1waX8Vwn0r4jcE1MT1Bi4a1Lw MKov/DoL2F8zg0mnaH6WZg+/OSs5SDuwOLVDYztStgDNZ+ZoY9W25Lr0csrkmVuvjkP3 Pw5rGOE8EyLEb2o3siWe8qZ3c9tf0k+r/PiKa4X8Dyc2cIuYrIhMTPNij7ScCrk2L6F/ 1jnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768302817; x=1768907617; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=JWfkiUEs3L3eRoPpvKnE7WI6HuZbSNuFySWoG+pF2vQ=; b=O+aph7en54uOyhpTpp94wFmDRKxCSGoNuSd+uGtQofFSKr9GCeOZrzc1vB5zrmV1DN BEHk7Mq+Xe0Gd4g498YtMQQSynZkgFW3Hd8X2st/RN6EoAiYDve+UyyJnpHAPm6gVIMa XUGLPObAYSL6gXcW3CvdlN3HxUrAtVLnHmD2V/QeQVONhpZmkTXBvAZEoMCh4QimkTLU iFBxLaV6/Tct8j8+6pgc5Rhmx1ZFrwgzFngKid/NXahUr1HJx1n5hr0W+/rMscrqennE UsPOYG3LYSc6zIbhZiFsYXlE02xx+4nk4i1w/wlKRAL1Sel74iDAUmHJOVvR/C9OPPHZ Ja2g== X-Gm-Message-State: AOJu0Yw3IA8lEdBA/Gh6iMRehThRjY8hZaesWqOgTOtLm7EivJYTg7m1 eYLKcBXBGaEs3SgO4GrTWc6XAKn2eczgM/8ukDHAR2XQe/1RdcNn7hPFha/+cd/KrXe0uV+gh8k 7xnge++aj+Sy4/ZYyk+Qdkfnhz5T56Lw7viKQHYIui+1hSzQ7xrcIpnF6lAO9IcdnXs7FvVNp55 S3h3O0RhCm3+nBX7fSnr/zmC0dUjO5vyIIDKc1pbbw X-Gm-Gg: AY/fxX699viOQAD5/Hvr8FrOuW+5Ijz1aB4JYjqUzXBbx+bQDGee/tanSoMc0wFcM03 gJLjdcebVu3TvvsL6SXDiLDoj5mC06P3YWT01crIbV5ad8AmP7BbpH/Nq7P2a+u7ypxyNXkCis1 EsyaCnQnJB4YIzRC8i/q4mIzHewD95pmtfStOMaAosu3/1Xc5P6IorD3k3/ix9A+rkJMebHfSdM 9vZ3hc2uFOzHrKHcq+vdt7v6eu5TBQUe8vOwSM2ou2CezG7qo8nDQN0NQhGPkPNTK7q9bV5lzuJ gwFvvsjaBglbDFKEiEzT8BS15AYLBJh1set9Fkjn4j8WyxrFBw+2aywHx5KH1dmNv2iS6KbHmwn wungQaA8GV56FJu0Z0F1rDHkuvKUNh2PUmfpWHdApR+7r5QxCnoM4CSQt/EsmRb6PDB8qwwihyY sfXFu/yWiPpTLFyQ== X-Received: by 2002:a05:600c:4709:b0:479:1348:c614 with SMTP id 5b1f17b1804b1-47d84b41b2dmr239582135e9.26.1768302817260; Tue, 13 Jan 2026 03:13:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IEUMjJGSzu6dH3RfX76RI7SrZkwz7AfoomAvaX5nUo5a9MlTT1hS9J6k7xFWoIwpNtR9tIKhw== X-Received: by 2002:a05:600c:4709:b0:479:1348:c614 with SMTP id 5b1f17b1804b1-47d84b41b2dmr239581825e9.26.1768302816820; Tue, 13 Jan 2026 03:13:36 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Mark Cave-Ayland Subject: [PULL 1/7] target/i386/tcg: do not leave non-arithmetic flags in CC_SRC after PUSHF Date: Tue, 13 Jan 2026 12:13:27 +0100 Message-ID: <20260113111333.1138160-2-pbonzini@redhat.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260113111333.1138160-1-pbonzini@redhat.com> References: <20260113111333.1138160-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1768302859849158500 Content-Type: text/plain; charset="utf-8" The value that is pushed by PUSHF is the full EFLAGS, while CC_OP_EFLAGS only wants arithmetic flags in CC_SRC. To avoid this, follow what other helpers do and set CC_SRC/CC_OP directly in helper_read_eflags. This is basically free and fixes an issue booting Windows 3.11. Reported-by: Mark Cave-Ayland Fixes: e661e2d7a37 ("target/i386/tcg: update cc_op after PUSHF", 2025-12-27) Signed-off-by: Paolo Bonzini --- target/i386/tcg/cc_helper.c | 4 +++- target/i386/tcg/emit.c.inc | 3 +-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/target/i386/tcg/cc_helper.c b/target/i386/tcg/cc_helper.c index 91e492196af..6ddd64fcb07 100644 --- a/target/i386/tcg/cc_helper.c +++ b/target/i386/tcg/cc_helper.c @@ -414,7 +414,9 @@ target_ulong helper_read_eflags(CPUX86State *env) { uint32_t eflags; =20 - eflags =3D cpu_cc_compute_all(env); + CC_SRC =3D eflags =3D cpu_cc_compute_all(env); + CC_OP =3D CC_OP_EFLAGS; + eflags |=3D (env->df & DF_MASK); eflags |=3D env->eflags & ~(VM_MASK | RF_MASK); return eflags; diff --git a/target/i386/tcg/emit.c.inc b/target/i386/tcg/emit.c.inc index 0fde3d669d9..e55b65176fc 100644 --- a/target/i386/tcg/emit.c.inc +++ b/target/i386/tcg/emit.c.inc @@ -3253,8 +3253,7 @@ static void gen_PUSHF(DisasContext *s, X86DecodedInsn= *decode) gen_update_cc_op(s); gen_helper_read_eflags(s->T0, tcg_env); gen_push_v(s, s->T0); - decode->cc_src =3D s->T0; - decode->cc_op =3D CC_OP_EFLAGS; + assume_cc_op(s, CC_OP_EFLAGS); } =20 static MemOp gen_shift_count(DisasContext *s, X86DecodedInsn *decode, --=20 2.52.0 From nobody Mon Feb 9 09:46:06 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1768302892; cv=none; d=zohomail.com; s=zohoarc; b=DOQSgg5dgnktXGYfB39eu8b9pN/SRoBkl9QDtnEIee1Y9CAZDgjobZSRhdb2cTILaYlOXhAqzygJanwdEpeJQ1s4GygXYOylru8oDCDzCtGz+WzzFdoduoRa6hvR8tuBCslueLmSEUM+EXvKDEHrp2ZmytOxZGC3jGZ9Aziz5+8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768302892; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=5yk+7lehNHXmaDyA6TRaDnfLrvG1v0qyhVBj2t/x3e0=; b=Wje/kgWkpCffxBQx0DRJELXQO6O15RDD0MgVQCnxjbhi8HTmlfbMnWSxjQaQLybXq05UJAWZACIsvwCCwzBtsBzgRJvW89z/iLORG1UlK8a1J7pSSRXSorbyZ0knzqxKUU9/k88CLb3KQroTlfLm2PGNNjk5ZIxCsnsvDP60/Cc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768302892024702.6781591723177; Tue, 13 Jan 2026 03:14:52 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vfcLS-00035n-O0; Tue, 13 Jan 2026 06:13:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfcLM-00032e-3L for qemu-devel@nongnu.org; Tue, 13 Jan 2026 06:13:48 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfcLI-0008Pn-DF for qemu-devel@nongnu.org; Tue, 13 Jan 2026 06:13:47 -0500 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-413-9kbbLA5xMt6LfuUR5NGc_w-1; Tue, 13 Jan 2026 06:13:42 -0500 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4792bd2c290so86164365e9.1 for ; Tue, 13 Jan 2026 03:13:41 -0800 (PST) Received: from [192.168.10.48] ([151.61.26.160]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f4184cbsm419522695e9.6.2026.01.13.03.13.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 03:13:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768302823; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5yk+7lehNHXmaDyA6TRaDnfLrvG1v0qyhVBj2t/x3e0=; b=FnM1mc4/Z3DG1FrIGBOGLWpNywT+Ke1bfXu6fu6Cm1P4GGqcZ9GGH5d4WRy0TbVGeuPGQW gwsR1lOmTUQbCU6iTEcj8D1afZv0o9ZGGvi5BZIUzs8kSnksbW47Cyk1Hy/yRienc4PnKW +zww93HW96TJJl+DRVr1hIPcXujWnL0= X-MC-Unique: 9kbbLA5xMt6LfuUR5NGc_w-1 X-Mimecast-MFC-AGG-ID: 9kbbLA5xMt6LfuUR5NGc_w_1768302821 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768302820; x=1768907620; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5yk+7lehNHXmaDyA6TRaDnfLrvG1v0qyhVBj2t/x3e0=; b=kaMCr/OrftyUrypUsPIa3FOsLrqrdTCexA//FDffm0XPm+ZGt1EKP+DpacJOE2NyG4 KIOshh5xI1mu1v9Brx2PUMJWovDzEX5HG5feLosYXDgep5F29rBYiknC4KZJtCX3zGYl 8ASCTr7nsm7+inhASTdHX7FtqLOrDJ5OsaiDCBhjYHNBLr2GMPYVAktmL0dzFjl7FCRr IjgIoPS3/YVlmVshCUuicUvc0s+IYA90VyXsK65VK+8T1ZEGM18cst/Jb4PoL34GDYwj LVU6ENAA7EKYsMQKWKrc7ncttzvQmI72OjSNJFkTz0D+XoMc+1NUJyGuLUuOZV5k92iL ZgcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768302820; x=1768907620; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5yk+7lehNHXmaDyA6TRaDnfLrvG1v0qyhVBj2t/x3e0=; b=dGJwDsOGkkctFRCPsk2d4OHaAJqhl1hS51Y4mBkyi5wZ1w96CBUXsUi8c2jO65LR/e kgRVhdADbQPF7ULYd1FiiGGijbrelNO8Uc8Cj6SsmetbGo3lbX0/dptKmKxw74TMclkA dqWa5VZLIM+KpRzwbUpZRxOqun/Xvf9PMdPmHc5BHk23f9Bx6A6hNcMwGv+tjRf0kQuW QOOOhFfo8UX2RDgTitzOib/F0f/wNXu5Se+O86M1DUIzU7IlBiy26RXt0nvGuofzWrkq tTOKGZOcyd/VyVJVGw5Tt/kvhoFRnRJFRCLRMltlCwvMShC8DLlqwuBsWfBqMKhLIxqW IZcg== X-Gm-Message-State: AOJu0Yw58JkSuZ3++/6Z0w08alopbw53mdPI63QKHq3a5GandTDj+mUL yAM5+HFIQikHe2BYyhsnwOiVl942TmjmnHJTGxQEVNEUWFl1jHzclGGlb6AZRWYKa1zUqNCr6Ht KzPjVNEiAiXdN7mimJuBuBIH6oejzqSyMu00eHsH8LgQ5odD3rLj2X08yg+5tsqn7V/x0XD92WS Jpq5VoyyBIi2icV+Kca16Suf1caaKjypXE2ryf7Cu/ X-Gm-Gg: AY/fxX4EHztVZuqWURk50WsEsHJXGmWJc0PlHOxs3xKIUR2ttl71cjSCxQiRZYRf2qK zG06DJLlpVPpHq5xW4PirwKSpUnl3l4l3+KZ9Plrnm/J8LEjkuxzD69vt9MvGfqsujFPWiqqe/H JVQJ8XeG7j7uiJTQHtC9M8pwEED2uVsrR4+g4V787NqBixhZQWukAO/lRsLK31zEsjdcJ0aQRPO f+SrpuEi+Z9tioC3B5Gg8Tc9nINk032kPbui3goMXduxvdQC6LCComLE0CWl7B2zJaY1ddz9hd1 tPgAxpfIvyINBTYyZBrHI2IasQmpT0XjyEXgBgMPDvBViJN7L4IvXEbMhuXSIOJ938Xw9JgNTlY wCaQoI/SzWh5BFtCi/mGfvv0D1p06OGo5lQh8YL5G2qUIHmG+vuiD79/0L+aYSuFV/RSnTLk/x+ WX20MbRiwSJtf59A== X-Received: by 2002:a05:600c:8506:b0:477:9ce2:a0d8 with SMTP id 5b1f17b1804b1-47d849bd201mr204796705e9.0.1768302820542; Tue, 13 Jan 2026 03:13:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IHLCkwWY3sJY8VOKcBhBFJ7w8ldtb+BhmulQsxRbsWWK2uK+lOMFUMLH2fUudDP8qBSA7HJjA== X-Received: by 2002:a05:600c:8506:b0:477:9ce2:a0d8 with SMTP id 5b1f17b1804b1-47d849bd201mr204796385e9.0.1768302820156; Tue, 13 Jan 2026 03:13:40 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Richard Henderson Subject: [PULL 2/7] target/i386/tcg: remove dead code Date: Tue, 13 Jan 2026 12:13:28 +0100 Message-ID: <20260113111333.1138160-3-pbonzini@redhat.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260113111333.1138160-1-pbonzini@redhat.com> References: <20260113111333.1138160-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1768302893559158500 Content-Type: text/plain; charset="utf-8" Remove dead code; it arose when I noticed that, because 0x3? opcodes do have a pop, case 0x32 works just fine as fcomp (even though 0x?2 is fcom): there is no need to hack the op to 0x03. Reported by Coverity as CID 1643922. Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- target/i386/tcg/translate.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index 7c444d5006d..460848e4223 100644 --- a/target/i386/tcg/translate.c +++ b/target/i386/tcg/translate.c @@ -2543,9 +2543,6 @@ static void gen_x87(DisasContext *s, X86DecodedInsn *= decode) break; } break; - /* map to fcomp; op & 7 =3D=3D 2 would not pop */ - op =3D 0x03; - /* fallthrough */ case 0x00 ... 0x07: /* fxxx st, sti */ case 0x22 ... 0x23: /* fcom2 and fcomp3, undocumented ops */ case 0x32: /* fcomp5, undocumented op */ --=20 2.52.0 From nobody Mon Feb 9 09:46:06 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1768302888; cv=none; d=zohomail.com; s=zohoarc; b=aG1CTH7f/9IEaxR7AEC3hIFfIvWdzRvzU51mgBwzmTVHdlEWEaCYAp0wB6eY+3hXE128jY0dl3m5HrpdBckM8Ij9TQ01ui1snhKr1TkkPzInnsU9m/vK7BwhCdiwexk+z5Uu8P3jeye5JahuUamyOzjEMj3MFywadvdXFAlgc7U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768302888; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Qb23EgjldeXXapw9SozidlWY2AOWRUGUm7lYmmpRkOQ=; b=JCBijodL6xrdKsFwzg5tD1n5/gbHJGLT9ptJUks4qIW2sC0bRPi2dmkbpKP/o/VGis67FhEYj5a1Y85E5lxoxUrgw45/QPl+8ggoHFPC11rhaH/zl6FZ+yEH7bCXhjXHOHLmyhDvAws5+R/64IJFHuYImp6m+9YrJcwBylZudhk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768302888515358.33593908018713; Tue, 13 Jan 2026 03:14:48 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vfcLS-00035a-My; Tue, 13 Jan 2026 06:13:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfcLM-00032f-44 for qemu-devel@nongnu.org; Tue, 13 Jan 2026 06:13:48 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfcLK-0008QB-Iz for qemu-devel@nongnu.org; Tue, 13 Jan 2026 06:13:47 -0500 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-414-FptF3foFOB2wR6I9Dg47vQ-1; Tue, 13 Jan 2026 06:13:44 -0500 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-4325b81081aso5974801f8f.3 for ; Tue, 13 Jan 2026 03:13:44 -0800 (PST) Received: from [192.168.10.48] ([151.61.26.160]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432d286cdecsm29960138f8f.7.2026.01.13.03.13.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 03:13:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768302826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qb23EgjldeXXapw9SozidlWY2AOWRUGUm7lYmmpRkOQ=; b=EIs9h6AMZ/XXjeD4aHRi2EgiVQ2RiXugsLpejaObIicueAi8tchEnB/QyeBdKIrR/CGyN5 uNPCN6HQNPg2xXW1WErQjlXclIzleRQxbrNlg6vNmMnuC6Rbb1U8V8TpowCTQqUDSpzKY8 Hh3M2gNMDYovhwcnUoZ6O2KNPmQC6tM= X-MC-Unique: FptF3foFOB2wR6I9Dg47vQ-1 X-Mimecast-MFC-AGG-ID: FptF3foFOB2wR6I9Dg47vQ_1768302823 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768302823; x=1768907623; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Qb23EgjldeXXapw9SozidlWY2AOWRUGUm7lYmmpRkOQ=; b=ZftsRuuuZDd8k/+lfvPiWxt6JuR0+2aukKpmYcFoaf/beCP0lVmIgjdrbrTTTtrI+p Af2OM4P1ckrqOvR0e2LJOFEFIC7A1GUwZy25H0uYUMb5NBrsNH8QPRqrk91TiKBZB0oE OQt+2/tymn2yvAGdRZ38896V5AddLhSss27KgirUPRp5lcdbFOksIF74sg+kx2BTsntH r69K4P+vyjbF5jGAbd5gJ17r+3664At4DouT2lZQ8UjfSFktSiuHAWYh0ztqmsa130ZH d27f7+q78BPZGRYnS1dojSH6mc2to6c7q89jN7jTijFmAWRietcpBIZtaJ+mztAT/d5o g+HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768302823; x=1768907623; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Qb23EgjldeXXapw9SozidlWY2AOWRUGUm7lYmmpRkOQ=; b=HprBlESCloVo7UzTDw9HiHrnxib8ZvUAvju2dr9fKX+qduOxPcs1kzJ3EDie0qqvJj kiA7Lm+qYhZheSjwCkpbq/AKkHDv5HFJAd+ZADKuHPei5to2LdQeykZhfR/zx2ibAskB mgFBd6JjDG+8IXuzsm9neJwkYIgQStceaJMcb8J0yEfcc9bQ5Nk3QPUTygxwVqZqQozZ S+D1Zooi1Gq/csENuHv/WrpdRRCAt78/1wit3hIugGdYQ6QKLUu/8Uh/Iv+DMkW1esUM 9YVfpbMy5BvprttEEoy/OYOHl4BH7TQUTAFXMZAzclDuXnOz/2tyXa4SbDTCFxBxMrqt sk0Q== X-Gm-Message-State: AOJu0Yx0kiFjAEckdAIBpjW4F7k9doJNICq2Vp0ZLNt3+zhi15MU7GyL 8t0HzzE3vECK3m3Nh8r11q+kugD7a97WUO096WgeAnFq2+/mErimB4Qu90hYWQTJR8fZczPgVkF kJFPVEuHhDhWQZg7A3dCsmDqfMj2IxPJwYZt6rBYNrCNCYobWTHcn2cT0X8mN4UabI+VXGs4ajE LYFlK9tTAA/iCm8B5O4MvOXuzGd97ogmZ+78GjaDSc X-Gm-Gg: AY/fxX6Dnh5OhEBUVNKPwLWJ95+LFMD7ECv3IKpdZyCdZt5KmLea2RXShcgoR4+rlAP wzpVeWAEVk2Y5/5c6j4Qr0BFg2+vJJjyHYpEQHToDrybx89T8DaFu/aW77cEDwvnHBGkRxpl0kQ OyokPauc30elpyMrnjC9tLTMx7hpakhQ3M7orlos61EVENkXRGS1Gv0+ph7LyiSH5V4/qlybNR9 BSp6z+CziU9d0LJzYaIve4ezvGpJ/RGxW0MgWAE7iYx1HL2HQOLw6tWiqGKjwlVjY7wVyxfyd8O Z3EbWfs+bcpYN3/hQqJfTuociIhQQh5r7dTaFacfeT+g/kQTVTJ8BKDAVQ+ZqUi11QCRiTiKNuM ta9AyxAx04kFrU9vT5O39tOlOV1ZtGdGI/85QdVIrY0NBSZ1CBRGEw/HAS4+xZotfniPUVzCbxt 5xqPGx7tfMqy1jWw== X-Received: by 2002:a05:6000:18a6:b0:42f:f627:3aa3 with SMTP id ffacd0b85a97d-432c37a752bmr25807457f8f.56.1768302823083; Tue, 13 Jan 2026 03:13:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IE8Jf2FAuIq3elFQsjFEMmOq3UMXTL7D0/wN+J0uQ2wkxC5cXwMa9BfxSyzu5etwFiZyzUr1Q== X-Received: by 2002:a05:6000:18a6:b0:42f:f627:3aa3 with SMTP id ffacd0b85a97d-432c37a752bmr25807423f8f.56.1768302822598; Tue, 13 Jan 2026 03:13:42 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, Richard Henderson Subject: [PULL 3/7] target/i386/tcg: do not mark all SSE instructions as unaligned Date: Tue, 13 Jan 2026 12:13:29 +0100 Message-ID: <20260113111333.1138160-4-pbonzini@redhat.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260113111333.1138160-1-pbonzini@redhat.com> References: <20260113111333.1138160-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1768302889597158500 Content-Type: text/plain; charset="utf-8" If the vex_special field was not initialized, it was considered to be X86_VEX_SSEUnaligned (whose value was zero). Add a new value to fix that. Cc: qemu-stable@nongnu.org Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- target/i386/tcg/decode-new.h | 2 ++ target/i386/tcg/decode-new.c.inc | 11 +++++++---- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/target/i386/tcg/decode-new.h b/target/i386/tcg/decode-new.h index 7f23d373ea7..92822969003 100644 --- a/target/i386/tcg/decode-new.h +++ b/target/i386/tcg/decode-new.h @@ -242,6 +242,8 @@ typedef enum X86InsnSpecial { * section of the manual. */ typedef enum X86VEXSpecial { + X86_VEX_None, + /* Legacy SSE instructions that allow unaligned operands */ X86_VEX_SSEUnaligned, =20 diff --git a/target/i386/tcg/decode-new.c.inc b/target/i386/tcg/decode-new.= c.inc index 9d3a7c0d426..f662364c600 100644 --- a/target/i386/tcg/decode-new.c.inc +++ b/target/i386/tcg/decode-new.c.inc @@ -1068,15 +1068,15 @@ static void decode_0F10(DisasContext *s, CPUX86Stat= e *env, X86OpEntry *entry, ui static void decode_0F11(DisasContext *s, CPUX86State *env, X86OpEntry *ent= ry, uint8_t *b) { static const X86OpEntry opcodes_0F11_reg[4] =3D { - X86_OP_ENTRY3(MOVDQ, W,x, None,None, V,x, vex4), /* MOVUPS */ - X86_OP_ENTRY3(MOVDQ, W,x, None,None, V,x, vex4), /* MOVUPD */ + X86_OP_ENTRY3(MOVDQ, W,x, None,None, V,x, vex4_unal), /* MOVUPS= */ + X86_OP_ENTRY3(MOVDQ, W,x, None,None, V,x, vex4_unal), /* MOVUPD= */ X86_OP_ENTRY3(VMOVSS, W,x, H,x, V,x, vex5), X86_OP_ENTRY3(VMOVLPx, W,x, H,x, V,q, vex5), /* MOVSD */ }; =20 static const X86OpEntry opcodes_0F11_mem[4] =3D { - X86_OP_ENTRY3(MOVDQ, W,x, None,None, V,x, vex4), /* MOVUPS */ - X86_OP_ENTRY3(MOVDQ, W,x, None,None, V,x, vex4), /* MOVUPD */ + X86_OP_ENTRY3(MOVDQ, W,x, None,None, V,x, vex4_unal), /* MOV= UPS */ + X86_OP_ENTRY3(MOVDQ, W,x, None,None, V,x, vex4_unal), /* MOV= UPD */ X86_OP_ENTRY3(VMOVSS_st, M,ss, None,None, V,x, vex5), X86_OP_ENTRY3(VMOVLPx_st, M,sd, None,None, V,x, vex5), /* MOVSD */ }; @@ -2624,6 +2624,9 @@ static bool validate_vex(DisasContext *s, X86DecodedI= nsn *decode) X86OpEntry *e =3D &decode->e; =20 switch (e->vex_special) { + case X86_VEX_None: + break; + case X86_VEX_REPScalar: /* * Instructions which differ between 00/66 and F2/F3 in the --=20 2.52.0 From nobody Mon Feb 9 09:46:06 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1768302888; cv=none; d=zohomail.com; s=zohoarc; b=n5Zib5pXywpA1O/lxkkGa061BXKfCwXV0lc/peaPxjfip7WG3sGwNhY/R1X67drgY8T/xMhttsJ6t+4v1IzIucxEACnp3NF9cz3czKeA/Ro98cwZ//71dBAbkmuC0Bx0ShTXO5nHOCb3RL8PtE3HPsRNz945wUfaHsbewbPB7f4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768302888; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ZAGJdZeq72e7lqjI+nG9SVEULVr7dvOgvkxQoZpywUo=; b=L9bpWPr64Q0Q/ffmXwHOnuZ3LZO8L4WwM3U4YscoHVtRdQf41quTJW9pzW2szoG7bWtFQGlzewmSbauvGu1KvKJZ0BdzV5YC1kbWtp8xb/cNHGHeJbeN8dhzWe25Slds1CYy0Xz8QshZ1EYlbtCtcPBVRFwNtx0UvAPfTOs2wg0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768302888731824.4698755498425; Tue, 13 Jan 2026 03:14:48 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vfcLW-00039s-E9; Tue, 13 Jan 2026 06:13:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfcLP-00034a-5J for qemu-devel@nongnu.org; Tue, 13 Jan 2026 06:13:51 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfcLN-0008Qo-EY for qemu-devel@nongnu.org; Tue, 13 Jan 2026 06:13:50 -0500 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-73-hEvwZ2fGPduJ-aeVb14YPw-1; Tue, 13 Jan 2026 06:13:47 -0500 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4775e00b16fso58011305e9.2 for ; Tue, 13 Jan 2026 03:13:46 -0800 (PST) Received: from [192.168.10.48] ([151.61.26.160]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432dfa6dc4esm21790413f8f.23.2026.01.13.03.13.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 03:13:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768302828; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZAGJdZeq72e7lqjI+nG9SVEULVr7dvOgvkxQoZpywUo=; b=RVEjzhFI5Mi58nBzilWXzMrwl/wX0IiZVekDhKiP7oGj16fvIH2FvKK1Zfb46inU+TQrNe 9EAMlu6QU1Y7FGfIL/vI9EKqTFxeFOqkGc3FvjAy9kvwZm5j72eTbGBt0/rAChn5WpmcXC ock9+06nSfx/mM1FGYGvcgfFmZGPwqY= X-MC-Unique: hEvwZ2fGPduJ-aeVb14YPw-1 X-Mimecast-MFC-AGG-ID: hEvwZ2fGPduJ-aeVb14YPw_1768302826 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768302825; x=1768907625; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZAGJdZeq72e7lqjI+nG9SVEULVr7dvOgvkxQoZpywUo=; b=kLGXRvZ759VYqGHOLPXZLYDGcZLqH0We4zl6kvFEB/2r6zqRB+gSkzduzqaZblfcPh SWqk5T3xZB4IbhoFHVhnjFHWeJ+lMmLJRzKxBqD9uMANvg6JwBk8nVMMkcviPZRx5QWg hpUhx75CbrplJN2eeXj5T/UXSu2Va2xS5XxptOP+OdJPynLX2D5sZ/yvLwn7L0LPKSW8 CO1RW9e/y8Xi5bFrbTI2S6zfh12iDBvTxhmGTQwWKfOR4kEX/aeowlz+2Ld3MpaqBrwO g0kBKt72DzVcy+lqD2l/Na7bRBVgsx4qqTBObHNnY7Qd2dByT5vfL2P/jczkHfiBRE2A Aesg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768302825; x=1768907625; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ZAGJdZeq72e7lqjI+nG9SVEULVr7dvOgvkxQoZpywUo=; b=sUhgdOClRlxcl6UvICLc81rNuaG7LGyyzOJWbLb0SL9yApxMRl1llReguTlVTd7IRP nvuNhl92oHOc1f1Ke2GCI9LgZuHuVn0SppdEDaZM51qoCtOV2eH+OAwbKmfBr+JAkgyb W0n4kXoTlY5NFgCrDVLfs4t2DPmoPvh7oC4Hx7X0xl86OCDpvUBg9hmrZmJWdq6xEmjN ZX0yUlgsaNP9EXAGgxppKIJs96c4i8pecQKjVUusVv0xVZwN1CsjxpMW0VLDHKJ8JdxP 92bWiTux6KS2njwvK0LBz+/j2R2JwzcV0H4wNtRPpIAL9tFhAOcGh7OIRDt+MvukQCP4 jGWA== X-Gm-Message-State: AOJu0YzKmT9W2KFcDcZPkkx+wNaKZNGWB84czzQpFJDKesVrng90z7Co Lf3PgAcdzQthZA/0+wAhKY7ZXI6pxsLxGRCsqz9c3+8yAfX5CrbDBODt4L8ux0/X74VN9EUyXB+ vaOUPJvaZWxijw/RkelPCwb3uajSBYoZcIFceZdkeJqQYCr7HLqcKDhrdRdSuohVO+e/1Ronj4t ws1htnTyWOcJUE27dscviL9dVKWDM4JBxFkSdamwrQ X-Gm-Gg: AY/fxX5eif8rNtZG/3gEbeM6LLxsnOYn6QMsJjUeNN1YzbCSLO9TmAyo00P+No5bQA7 8dqNL4mL4jdETv+5t3RXmCLgooqNysFf5HRCOPxmH2NByZD7kCkEE13+nEvJoYuYlovFWRDBZJv sPtTQif05tC/CRa0byW2+mEybBk98PuhnUvwLKmJhkVBj0MwNWGPDsrWrdGjNgfF/9kJeFrju8p FOWVa+lfJ/WjjljvVg4vyD5TFVEbSrX7Dpq2m/gOYFKdRNRG1m46Y+iYp4DPsjDuZUr6KTA792u u1ACFX4yM5stJ5SggKCTiOr5bpD2fNleSWrYbwVT0nTzxWC1rOm+zayGnxY6+YTVIXF1wYwTe3G B0fPSaFFlpwrJzrjVGCRWniD0lw3KlvWYlx0BOVa6KrS6bkptRBoBKfdVd+IOLENZzHPblXlKtV rNi5KF8CgWkqRAHg== X-Received: by 2002:a05:600c:630d:b0:477:73cc:82c2 with SMTP id 5b1f17b1804b1-47d84b1fea3mr282725615e9.9.1768302824862; Tue, 13 Jan 2026 03:13:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IH0vu7l+29lBBF5GQXB2a7VgpynFCRmINiKpzuZKLbgoF77PKUp47VonpZ7ssytXaEORzSZGA== X-Received: by 2002:a05:600c:630d:b0:477:73cc:82c2 with SMTP id 5b1f17b1804b1-47d84b1fea3mr282725135e9.9.1768302824392; Tue, 13 Jan 2026 03:13:44 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, Richard Henderson Subject: [PULL 4/7] target/i386/tcg: mask addresses for VSIB Date: Tue, 13 Jan 2026 12:13:30 +0100 Message-ID: <20260113111333.1138160-5-pbonzini@redhat.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260113111333.1138160-1-pbonzini@redhat.com> References: <20260113111333.1138160-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1768302889560158502 Content-Type: text/plain; charset="utf-8" VSIB can have either 32-bit or 64-bit addresses, pass a constant mask to the helper and apply it before the load. Cc: qemu-stable@nongnu.org Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- target/i386/ops_sse.h | 16 ++++++++-------- target/i386/tcg/ops_sse_header.h.inc | 8 ++++---- target/i386/tcg/emit.c.inc | 17 +++++++++-------- 3 files changed, 21 insertions(+), 20 deletions(-) diff --git a/target/i386/ops_sse.h b/target/i386/ops_sse.h index a2e4d480399..853196b2bbd 100644 --- a/target/i386/ops_sse.h +++ b/target/i386/ops_sse.h @@ -2362,42 +2362,42 @@ void glue(helper_vpmaskmovq, SUFFIX)(CPUX86State *e= nv, Reg *d, Reg *v, Reg *s) } =20 void glue(helper_vpgatherdd, SUFFIX)(CPUX86State *env, - Reg *d, Reg *v, Reg *s, target_ulong a0, unsigned scale) + Reg *d, Reg *v, Reg *s, target_ulong a0, unsigned scale, target_ul= ong amask) { int i; for (i =3D 0; i < (2 << SHIFT); i++) { if (v->L(i) >> 31) { target_ulong addr =3D a0 + ((target_ulong)(int32_t)s->L(i) << scale); - d->L(i) =3D cpu_ldl_data_ra(env, addr, GETPC()); + d->L(i) =3D cpu_ldl_data_ra(env, addr & amask, GETPC()); } v->L(i) =3D 0; } } =20 void glue(helper_vpgatherdq, SUFFIX)(CPUX86State *env, - Reg *d, Reg *v, Reg *s, target_ulong a0, unsigned scale) + Reg *d, Reg *v, Reg *s, target_ulong a0, unsigned scale, target_ul= ong amask) { int i; for (i =3D 0; i < (1 << SHIFT); i++) { if (v->Q(i) >> 63) { target_ulong addr =3D a0 + ((target_ulong)(int32_t)s->L(i) << scale); - d->Q(i) =3D cpu_ldq_data_ra(env, addr, GETPC()); + d->Q(i) =3D cpu_ldq_data_ra(env, addr & amask, GETPC()); } v->Q(i) =3D 0; } } =20 void glue(helper_vpgatherqd, SUFFIX)(CPUX86State *env, - Reg *d, Reg *v, Reg *s, target_ulong a0, unsigned scale) + Reg *d, Reg *v, Reg *s, target_ulong a0, unsigned scale, target_ul= ong amask) { int i; for (i =3D 0; i < (1 << SHIFT); i++) { if (v->L(i) >> 31) { target_ulong addr =3D a0 + ((target_ulong)(int64_t)s->Q(i) << scale); - d->L(i) =3D cpu_ldl_data_ra(env, addr, GETPC()); + d->L(i) =3D cpu_ldl_data_ra(env, addr & amask, GETPC()); } v->L(i) =3D 0; } @@ -2408,14 +2408,14 @@ void glue(helper_vpgatherqd, SUFFIX)(CPUX86State *e= nv, } =20 void glue(helper_vpgatherqq, SUFFIX)(CPUX86State *env, - Reg *d, Reg *v, Reg *s, target_ulong a0, unsigned scale) + Reg *d, Reg *v, Reg *s, target_ulong a0, unsigned scale, target_ul= ong amask) { int i; for (i =3D 0; i < (1 << SHIFT); i++) { if (v->Q(i) >> 63) { target_ulong addr =3D a0 + ((target_ulong)(int64_t)s->Q(i) << scale); - d->Q(i) =3D cpu_ldq_data_ra(env, addr, GETPC()); + d->Q(i) =3D cpu_ldq_data_ra(env, addr & amask, GETPC()); } v->Q(i) =3D 0; } diff --git a/target/i386/tcg/ops_sse_header.h.inc b/target/i386/tcg/ops_sse= _header.h.inc index d92c6faf6d6..bbeb7301c33 100644 --- a/target/i386/tcg/ops_sse_header.h.inc +++ b/target/i386/tcg/ops_sse_header.h.inc @@ -388,10 +388,10 @@ DEF_HELPER_4(glue(vpmaskmovd_st, SUFFIX), void, env, = Reg, Reg, tl) DEF_HELPER_4(glue(vpmaskmovq_st, SUFFIX), void, env, Reg, Reg, tl) DEF_HELPER_4(glue(vpmaskmovd, SUFFIX), void, env, Reg, Reg, Reg) DEF_HELPER_4(glue(vpmaskmovq, SUFFIX), void, env, Reg, Reg, Reg) -DEF_HELPER_6(glue(vpgatherdd, SUFFIX), void, env, Reg, Reg, Reg, tl, i32) -DEF_HELPER_6(glue(vpgatherdq, SUFFIX), void, env, Reg, Reg, Reg, tl, i32) -DEF_HELPER_6(glue(vpgatherqd, SUFFIX), void, env, Reg, Reg, Reg, tl, i32) -DEF_HELPER_6(glue(vpgatherqq, SUFFIX), void, env, Reg, Reg, Reg, tl, i32) +DEF_HELPER_7(glue(vpgatherdd, SUFFIX), void, env, Reg, Reg, Reg, tl, i32, = tl) +DEF_HELPER_7(glue(vpgatherdq, SUFFIX), void, env, Reg, Reg, Reg, tl, i32, = tl) +DEF_HELPER_7(glue(vpgatherqd, SUFFIX), void, env, Reg, Reg, Reg, tl, i32, = tl) +DEF_HELPER_7(glue(vpgatherqq, SUFFIX), void, env, Reg, Reg, Reg, tl, i32, = tl) #if SHIFT =3D=3D 2 DEF_HELPER_3(vpermd_ymm, void, Reg, Reg, Reg) DEF_HELPER_4(vpermdq_ymm, void, Reg, Reg, Reg, i32) diff --git a/target/i386/tcg/emit.c.inc b/target/i386/tcg/emit.c.inc index e55b65176fc..bc3a07f972c 100644 --- a/target/i386/tcg/emit.c.inc +++ b/target/i386/tcg/emit.c.inc @@ -43,8 +43,8 @@ typedef void (*SSEFunc_0_pppi)(TCGv_ptr reg_a, TCGv_ptr r= eg_b, TCGv_ptr reg_c, TCGv_i32 val); typedef void (*SSEFunc_0_eppt)(TCGv_ptr env, TCGv_ptr reg_a, TCGv_ptr reg_= b, TCGv val); -typedef void (*SSEFunc_0_epppti)(TCGv_ptr env, TCGv_ptr reg_a, TCGv_ptr re= g_b, - TCGv_ptr reg_c, TCGv a0, TCGv_i32 scale); +typedef void (*SSEFunc_0_eppptit)(TCGv_ptr env, TCGv_ptr reg_a, TCGv_ptr r= eg_b, + TCGv_ptr reg_c, TCGv a0, TCGv_i32 scale, = TCGv amask); typedef void (*SSEFunc_0_eppppi)(TCGv_ptr env, TCGv_ptr reg_a, TCGv_ptr re= g_b, TCGv_ptr reg_c, TCGv_ptr reg_d, TCGv_i32= flags); typedef void (*SSEFunc_0_eppppii)(TCGv_ptr env, TCGv_ptr reg_a, TCGv_ptr r= eg_b, @@ -1100,18 +1100,19 @@ VEXW_AVX(VPMASKMOV, vpmaskmov) =20 /* Same as above, but with extra arguments to the helper. */ static inline void gen_vsib_avx(DisasContext *s, X86DecodedInsn *decode, - SSEFunc_0_epppti d_xmm, SSEFunc_0_epppti q= _xmm, - SSEFunc_0_epppti d_ymm, SSEFunc_0_epppti q= _ymm) + SSEFunc_0_eppptit d_xmm, SSEFunc_0_eppptit= q_xmm, + SSEFunc_0_eppptit d_ymm, SSEFunc_0_eppptit= q_ymm) { - SSEFunc_0_epppti d =3D s->vex_l ? d_ymm : d_xmm; - SSEFunc_0_epppti q =3D s->vex_l ? q_ymm : q_xmm; - SSEFunc_0_epppti fn =3D s->vex_w ? q : d; + SSEFunc_0_eppptit d =3D s->vex_l ? d_ymm : d_xmm; + SSEFunc_0_eppptit q =3D s->vex_l ? q_ymm : q_xmm; + SSEFunc_0_eppptit fn =3D s->vex_w ? q : d; TCGv_i32 scale =3D tcg_constant_i32(decode->mem.scale); TCGv_ptr index =3D tcg_temp_new_ptr(); + TCGv mask =3D tcg_constant_tl(MAKE_64BIT_MASK(0, 8 << s->aflag)); =20 /* Pass third input as (index, base, scale) */ tcg_gen_addi_ptr(index, tcg_env, ZMM_OFFSET(decode->mem.index)); - fn(tcg_env, OP_PTR0, OP_PTR1, index, s->A0, scale); + fn(tcg_env, OP_PTR0, OP_PTR1, index, s->A0, scale, mask); =20 /* * There are two output operands, so zero OP1's high 128 bits --=20 2.52.0 From nobody Mon Feb 9 09:46:06 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1768302951; cv=none; d=zohomail.com; s=zohoarc; b=SwFK9nBxrQ518KZuSOHiCkDy0rFro1C6Dg6H8l7JikYmmm0VshTFpQArTjPmtLqqwBuvbdoJMOioo9T9IUZz5CZE01H/M9/q683KHyD1y1nD0BWg4BPA3ZsZUzchFMcZ2xrLoKlFW6t8Ff3p/GA7YeQnwG2sy0HWOEq3AWpIDQo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768302951; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=vmMNXghpYjqYvVVn4RIngVHI8PwCV+JhYK/3vY9LTWA=; b=aH66DpIOXwK+w2DYIE0N8hBYuAH8huFkWCAg2NvzBl+FEbJZZZEDn170af1sSJKQnG+4QnyS094yynk21Et31WiPTTWtRP8P+mz6k25UDuiNcW1miEQxKW+/5/LetrNLiaUh8kAIODjihfHp0D4XWGpUqKk3dnF2JSnGJCYThjY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768302951651702.8763777977986; Tue, 13 Jan 2026 03:15:51 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vfcLW-0003AD-NB; Tue, 13 Jan 2026 06:13:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfcLQ-000351-D7 for qemu-devel@nongnu.org; Tue, 13 Jan 2026 06:13:52 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfcLP-0008RE-0E for qemu-devel@nongnu.org; Tue, 13 Jan 2026 06:13:52 -0500 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-528-N2GuKGwsOJ2-AW0mNoDpdQ-1; Tue, 13 Jan 2026 06:13:49 -0500 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4779edba8f3so58389375e9.3 for ; Tue, 13 Jan 2026 03:13:49 -0800 (PST) Received: from [192.168.10.48] ([151.61.26.160]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd0e6784sm44653855f8f.19.2026.01.13.03.13.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 03:13:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768302830; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vmMNXghpYjqYvVVn4RIngVHI8PwCV+JhYK/3vY9LTWA=; b=WuZZgZhW3qLeHITJYZyBCjAPZXU6z+XViEqeiFPXMDqq2BRmX0eafvzylPQzK9bGEgmUrL aszS/4v7qMTbW148ZgLAvXo54t2uNfdZ9LdaoZLtyW+KBSJzThWbvOj2kDr6Jn2F+OHLLU 7FlnI/KfXgShEatvhDNyRfiZqDUNvUU= X-MC-Unique: N2GuKGwsOJ2-AW0mNoDpdQ-1 X-Mimecast-MFC-AGG-ID: N2GuKGwsOJ2-AW0mNoDpdQ_1768302828 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768302827; x=1768907627; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vmMNXghpYjqYvVVn4RIngVHI8PwCV+JhYK/3vY9LTWA=; b=JaDY5g4XCNr7ct3dZVrmZu9l5H3WMxy782XpU8cKVl8h/ITR95z28NQoaYt7Ekj4Br CppFTgrZheXl83T65KAE0eut8u3+tMFzbxZBYRamEuaL9RkIjS3jp/FTFftzuv3dvlDQ VNoxW7VMcbtkDYX8W0wNJfZvz+yMCk+FQrZRuj3hwKHTxGw7meZx4oYI6JK2TwUURzhg 6qVXLcPN4h777R5LRKY08rFhRp1CrP8PleYOrTMQCE3ca+X1lv0vRSOUANFWd7v3LWZa Dn5PUV9zzZdaaeH7PlOMKqPTvU1JXfj0Uyf5rs1pw4MZsMjV4+vgUcigVmznt+7VmZpv 8/vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768302827; x=1768907627; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=vmMNXghpYjqYvVVn4RIngVHI8PwCV+JhYK/3vY9LTWA=; b=MWuOqpex1We5/Y0NZuMq9gAvX/W8TYsk+nJCFD5SF8c8TQO3MZxoi+PHS6WSuHy0q7 m3D8rzz1IRmvNOLQZtRx+04AmQMWjXpKE/FgHLuuZovynW1Fy8u0Knduq5WIC7rC8idD 22yvMdkB5aM7DbP3hFyVkqS64CuryXwyckUM7wgzN59AszG5npd8hpbM8i73ZMHUIHFV 1nqKxT9KYMlmPWPxxCdFdRcuWaUoTXAavrmU+WN64IH4ZqGlfVO25T1W1zCH1hxtKrYd cVlv6uW+l52kbB3MzRZ7+ChmKexatC/xkYwcfZ6qF9j+JqhBCHZH1jOObCgGSFKtzWvU Gvpw== X-Gm-Message-State: AOJu0Yy3gCCUi6VUqmMB44zI2KZVJ9WqWdUQ5cUYY9k02ZFAD/Pnpxby IFS4Iqa1TnpVIzpWhc39IpLVibNhf/uaB830TT7GKXhsHDa3La9WhFCxXvAJqjHCHQfYaATbtjW 51qot8FAP4CckNZoTm2oWc/E/OVWFs1bxqAoYuP1eHuQaa4sUzAv0YkkC4Voq+9fqXhhK2XqM6m ON5T8soQAAshpiiSEf+WLuyIu4ehSO/isGeXf1T37y X-Gm-Gg: AY/fxX5gY0xNuozxDF3VVPuHUJooks7i/QYfDqrhg4JRRhXIGJ7ne2QDW3ShxzEbdqm T7F4sybgMDsR8QnmhoF0rg2YWsIXCqkbE6dfGVPVrpOGnSq+7t1ISMkE/vtUFY4qx6gcaj7AWgX wOH+IcewpUf5ejyyGKb/iFLbsz8aoVEx00/fPdPS9aeQ9AZEosOPQnclXjzfbh3ykreZgKkOVzb DdnPxhRzRaBQcSEZsgbAK6TNWWfqcO/ZxiY6ur0EwdqDrQbGvxqnamwqVZQpdXPy/8JY9ybsojg C9cU6LZCrGhtxp5mETq2zR3HD0lirXH+XM9KXaXZ4ynZkjNiNPebRBvfMjO2VI9esdmlnD7EV8o y64w9WJep+gZAZRAs//JmcWqfwygYOevhO5z0DiIc3VM8EK6A4r3+w9Orw0TK9KqJvdvA86HP/I i1XEEz/4emtNwl1g== X-Received: by 2002:a05:600c:4ed3:b0:477:afc5:fb02 with SMTP id 5b1f17b1804b1-47d84b34785mr268164855e9.21.1768302827596; Tue, 13 Jan 2026 03:13:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IE98/Vf9L73LmoijCXaRYMp8bvFyGDCDWE+ZddB4q6YYSA+8+ym98si70TLUzt49V+93fMjHg== X-Received: by 2002:a05:600c:4ed3:b0:477:afc5:fb02 with SMTP id 5b1f17b1804b1-47d84b34785mr268164525e9.21.1768302827188; Tue, 13 Jan 2026 03:13:47 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, Richard Henderson Subject: [PULL 5/7] target/i386/tcg: allow VEX in 16-bit protected mode Date: Tue, 13 Jan 2026 12:13:31 +0100 Message-ID: <20260113111333.1138160-6-pbonzini@redhat.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260113111333.1138160-1-pbonzini@redhat.com> References: <20260113111333.1138160-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1768302953842158500 Content-Type: text/plain; charset="utf-8" VEX is only forbidden in real and vm86 mode; 16-bit protected mode supports it for some unfathomable reason. Cc: qemu-stable@nongnu.org Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- target/i386/tcg/decode-new.c.inc | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/target/i386/tcg/decode-new.c.inc b/target/i386/tcg/decode-new.= c.inc index f662364c600..09e3d8884cf 100644 --- a/target/i386/tcg/decode-new.c.inc +++ b/target/i386/tcg/decode-new.c.inc @@ -2872,20 +2872,16 @@ static void disas_insn(DisasContext *s, CPUState *c= pu) case 0xc5: /* 2-byte VEX */ case 0xc4: /* 3-byte VEX */ /* - * VEX prefixes cannot be used except in 32-bit mode. - * Otherwise the instruction is LES or LDS. + * Bits 6-7 of the first byte must be set except in 64-bit mode. + * Otherwise the instruction is LES or LDS. Not allowed in real m= ode. */ - if (CODE32(s) && !VM86(s)) { + if (PE(s) && !VM86(s)) { static const int pp_prefix[4] =3D { 0, PREFIX_DATA, PREFIX_REPZ, PREFIX_REPNZ }; int vex3, vex2 =3D x86_ldub_code(env, s); =20 if (!CODE64(s) && (vex2 & 0xc0) !=3D 0xc0) { - /* - * 4.1.4.6: In 32-bit mode, bits [7:6] must be 11b, - * otherwise the instruction is LES or LDS. - */ s->pc--; /* rewind the advance_pc() x86_ldub_code() did */ break; } --=20 2.52.0 From nobody Mon Feb 9 09:46:06 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1768302967; cv=none; d=zohomail.com; s=zohoarc; b=NO+6LZD1WAum7VEOgOZ0Mr36xBI+cUw+6C4hqVf08ALTxyvrBSeFUObyg6ZqpBwJH+VnfVrIx0YQT8Te2Juz4LQ42J6ahfqd40s19RGk0pvWsLl7Md2aZPr4LPciMLzycPpSaMGM/oOQmjUHg3hjmQrRlANIKhJ3jzfbi/L3x5o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768302967; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=WoHmlff5qVInNJa0c5xb24mKFyNRNi6bvJSwoHs/ngM=; b=IuNEMWoeBpTV6X89b/LsMK4fAX8lMUGF0wbDRzjD6cXKSDPhfuBFY/Es1pPC3ALGwmN3Rk6XZvhicn3p/AZTLoB5rLAsi9ncILFbGNF3OQHrWHA8YD0gvFT7dtnLR9O4QZmBjbKfZXBycIJOSQk3e7vHq9lxJEGGU9VH0lwDsGk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768302967696959.4724493087305; Tue, 13 Jan 2026 03:16:07 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vfcLg-0003HB-KJ; Tue, 13 Jan 2026 06:14:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfcLe-0003GF-6V for qemu-devel@nongnu.org; Tue, 13 Jan 2026 06:14:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfcLc-0008Sz-Kr for qemu-devel@nongnu.org; Tue, 13 Jan 2026 06:14:05 -0500 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-571-wV9oZq2HOaSTer5JWVmslw-1; Tue, 13 Jan 2026 06:13:52 -0500 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4776079ada3so74286945e9.1 for ; Tue, 13 Jan 2026 03:13:51 -0800 (PST) Received: from [192.168.10.48] ([151.61.26.160]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f695956sm410025415e9.6.2026.01.13.03.13.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 03:13:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768302843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WoHmlff5qVInNJa0c5xb24mKFyNRNi6bvJSwoHs/ngM=; b=bF9CDDNE50POj7ptI62RC8E4pBcLq9ZJ+mIfUtgnhI1z79xCMQjvDRINOUU5M4zLn3H6lV FYaHWFg63gAElvPUBta2+TOgW4stG66+gdIQOT34aj0SdklMpsbV+6F1yPO3TqwPeFGL9V 4Nq/a4XyLjkRczlir68Myv599MPvJqs= X-MC-Unique: wV9oZq2HOaSTer5JWVmslw-1 X-Mimecast-MFC-AGG-ID: wV9oZq2HOaSTer5JWVmslw_1768302831 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768302830; x=1768907630; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WoHmlff5qVInNJa0c5xb24mKFyNRNi6bvJSwoHs/ngM=; b=kpFhmyTKSe/TedFYsRVW/YYf/jIDXJWRzLSXdSviDhUe554QdbpBaNLp1keTFt2iQO WB9ViAXC1pdvedw10ZCNUz49dTSN/FYj3KjVZZ2gkGc9UvSin2KMD36eBl/KievJDtI0 8S27ZEo5Z1yYjxQjU8zeN8/6oZ8LGOpta5Q9x68vWUWgz2YafVN7a2umspQt5rbWf0a0 7rD1HqNn90Ww3AUSeTybVok6vT4yAH3Ypdr6Ywj5yMrJlCq0eFBjfhsSeDDHt7W60Vew QyWvR0Kz/hCr1kgimpIkigCw0auW9CrfCn86nGxbMYttVU9gI1JFIOf/GtPiTCIhElXL h6aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768302830; x=1768907630; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WoHmlff5qVInNJa0c5xb24mKFyNRNi6bvJSwoHs/ngM=; b=JlFmzmqWuJc8iNw5FraH0/A7cCogwHpog3IMBp2+ntETYAKui3Fk0juknj2Jabiyrj P/swOJfyu4SlFTHoPTYavrYvUTcHhWDj+/GPVubpX6K5moXexzI2FKL7KCUQWRcEzlEA mE9EsR8VNFYjaYn3rqkmMwaWbbpUad272STAfiKbp1Yqu6TFy7l1TkvxBiwK4pKatyJR BLqX3agrLiErgNkKRlmpjVjj/LloLm9fxYAnCdcTEwZJh2hp26deqfIbQr1mIYJZ+zSx 6irYgXIRtKeAdKVU8LfeWFX4f3DwF23nHGJic/CrCV2Jt8Wk974e/JddJSyPe8WfOzGz hvsA== X-Gm-Message-State: AOJu0Yz+91wOmGaoGC1Co3iepyhk3ojr/b6oAXQqA6sgKmeO+24jq+gZ aLBBEnBY5cOYtF9oEHniDrEbLWEpMN6HuEPRvIf9XNIBLJXwLuWt3gYvMc9R/max4ywREacHxWB CFupNuguBjs2riB7YcRxwwo+Q8M9PgQx63GBN9G+zv3W2H9LGb2ZlZJTK4K8ydMrCMGcRoTp5MJ V8LZghMKotGt2Am8g6CCApS0ZnJ9n97OEpjjbqBH1T X-Gm-Gg: AY/fxX5oBzkfhCsf4mOARlowuMsT2aJhODgYqMZP3ynR3/HWD3YjWQ89ou7h2VWqtj7 zpDsiefuKvtCc4CNR6yOELwh5KBNxFfafb/hPvTBKplxggN0yjAfIaxUJ+V3WZs3CWrfFK7+mRO qR6HCNObVfrWCq3+KG7zbKAYxeas7Ak4O6i4gRjBqXZLBvwEuErarE3f9mQ3Cotd3FXU6MLUtlR 95h0BvrKtrNNpsMx897F5lur1njU1fXFoPGYDBWVD4rrdQj2/g/iHIfB98eDypY+KremIBj8jE6 VfaWQ7AG8cQvAL2/dyFEkwsIMBWLcmyOqEQtJkjIZrxXV+zwaP45U7gsl0BEYRCdGy89NIbDg54 xXii2WCQcX2/9z6XUvy1b719em8J1OiXRMf8BPf2BNmJ3TjYrn+JJTEuzJIPQSbko9Bjf/xqYBE 3kESsaG2efu2A8VQ== X-Received: by 2002:a05:600c:1393:b0:477:55ce:f3bc with SMTP id 5b1f17b1804b1-47d84b3bad4mr235285325e9.19.1768302830322; Tue, 13 Jan 2026 03:13:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IGdULqhZlXJ5a1TLOpcM++a0MpEZu6Cb9nKZW9GtBzFwE298R1Iky4D+vNkH5XdKludUKnvpw== X-Received: by 2002:a05:600c:1393:b0:477:55ce:f3bc with SMTP id 5b1f17b1804b1-47d84b3bad4mr235285025e9.19.1768302829546; Tue, 13 Jan 2026 03:13:49 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Vulnerability Report , David Woodhouse Subject: [PULL 6/7] hw/i386/kvm: fix PIRQ bounds check in xen_physdev_map_pirq() Date: Tue, 13 Jan 2026 12:13:32 +0100 Message-ID: <20260113111333.1138160-7-pbonzini@redhat.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260113111333.1138160-1-pbonzini@redhat.com> References: <20260113111333.1138160-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1768302970141158500 Content-Type: text/plain; charset="utf-8" From: Vulnerability Report Reject pirq =3D=3D s->nr_pirqs in xen_physdev_map_pirq(). Fixes: aa98ee38a5 ("hw/xen: Implement emulated PIRQ hypercall support") Fixes: CVE-2026-0665 Reported-by: DARKNAVY (@DarkNavyOrg) Reviewed-by: David Woodhouse Signed-off-by: Vulnerability Report Link: https://lore.kernel.org/r/13FE03BE60EA78D6+20260109023548.4047-1-vr@d= arknavy.com Signed-off-by: Paolo Bonzini --- hw/i386/kvm/xen_evtchn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/kvm/xen_evtchn.c b/hw/i386/kvm/xen_evtchn.c index b65871f3542..8b243984e41 100644 --- a/hw/i386/kvm/xen_evtchn.c +++ b/hw/i386/kvm/xen_evtchn.c @@ -1877,7 +1877,7 @@ int xen_physdev_map_pirq(struct physdev_map_pirq *map) return pirq; } map->pirq =3D pirq; - } else if (pirq > s->nr_pirqs) { + } else if (pirq >=3D s->nr_pirqs) { return -EINVAL; } else { /* --=20 2.52.0 From nobody Mon Feb 9 09:46:06 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1768302888; cv=none; d=zohomail.com; s=zohoarc; b=HLh/u3w4Gg0hg+HzJWy0mFzDsh2bRsHoUICPGUjT/tN+Z0jc/lwmwN/MzKJokPsa9Jty/td0NsWoS6iLX3A5F2BVAfTeMuXmFgIV4LWIsj/WjLEmyG/SiofnOv5kfuo5nXUdD1ivJbE/vuApIeaUBuBCVSNhgSg06prkH+dI9sc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768302888; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=aI8nc+0Y3FBtb3DTLUVxBO8sB/nyzLVfQTim1m8lj6Q=; b=dPFG+ZamZ5VzAqmUsGP7I2n1WndRixBB8TnH8iLhz0hRu+IHVyIxWfKTmJ+CZLJYZ4YIGaH9JKNEunkMHxjDwZkUlk1ow1Nb64F65/Pn4q952Br+cYmOuQBpeHoeNkdfkmcQ6rLTLVLZxzKfyZfVjH9k1DDiSVzzm+PYVfjgrig= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768302888750843.3373868936861; Tue, 13 Jan 2026 03:14:48 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vfcLY-0003BU-IV; Tue, 13 Jan 2026 06:14:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfcLV-000396-Oj for qemu-devel@nongnu.org; Tue, 13 Jan 2026 06:13:57 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfcLT-0008Rr-5O for qemu-devel@nongnu.org; Tue, 13 Jan 2026 06:13:57 -0500 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-226-N2L907QvMpe450S9irQXGA-1; Tue, 13 Jan 2026 06:13:53 -0500 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4779ecc3cc8so51666945e9.3 for ; Tue, 13 Jan 2026 03:13:53 -0800 (PST) Received: from [192.168.10.48] ([151.61.26.160]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47edc05b267sm24167105e9.15.2026.01.13.03.13.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 03:13:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768302834; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aI8nc+0Y3FBtb3DTLUVxBO8sB/nyzLVfQTim1m8lj6Q=; b=PAazTwZ5twRyPGMWIGqPdLE0bncw4lK/XfKkU+B8emZ9NsK7M/5p1wR7rnW1zu16oOTUnX /UfkQuI2E1dd4TBPKBOvNQcZI9Bp296nzVpOazrtEdv5VO/2P11EGHSaCpzv/XJTgWLQeF qhTy4GsCzQYbx2/exsgsABPEriIAqlY= X-MC-Unique: N2L907QvMpe450S9irQXGA-1 X-Mimecast-MFC-AGG-ID: N2L907QvMpe450S9irQXGA_1768302832 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768302831; x=1768907631; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aI8nc+0Y3FBtb3DTLUVxBO8sB/nyzLVfQTim1m8lj6Q=; b=UOj2opeAbWOU06rU/AuFEjWUVqsD6Zrm0YopozBEfkon/GaVaIdb8c3o7F8QEqp5Ax 9JkR41NRv9w4SW3OHz5AIdHfFkIlo0IaMNFFnjWy0Ws71Ut73hCky27XDiL6a6kuW9ys iaen6kitPDctnn35z/li/cF6yiiQQyEZtEIz21UheGFmCZO87LZsP7t5f0Mmc0L+3+oN wpUfc3ZhA8MDMBhL5cKYBz8irnZL+I+wXSvzSC7Jp0qX6jKQWxA5lQZ+NcdtjGFVFT1Z 6KVEDIRiHjXAO/WHc1wWZp3S3/iNcSXbVamDnc7pTNFrRf0UBN1HYVQbRuKz/jjy+Zp/ 3PVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768302831; x=1768907631; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=aI8nc+0Y3FBtb3DTLUVxBO8sB/nyzLVfQTim1m8lj6Q=; b=k091/LbsJhKAqvn7Os9Z1rXtsemJnkyvqdMJ4RaekPF30ydazbURn1rsrLlHE5JIdq 0UCUwzqP/VtciUnYxx49areNDovS5LPcuLsn2ecZ+VBFSvXxVq+WOOL9fPn1mePC8V3O iGbR9vSpMXvw/HMujexXwWbu87ppP1cgjFCmbSONpTWYZpftFoEVNwze3xVNoiqpeJcz 7dA8XyVfGH5QFZoXnojBrSlvMFQbveLJsVGefSTRKjd6JCWmyFH2GV5jq7LEC4Gkvx8C xHPL8lUtAm4BeBDtQLVcP0A8VLR3v0NtMKbIHX4SUPtNCm/gSBxawCdRY8mcsoHBdW9h ABIA== X-Gm-Message-State: AOJu0YwIetngCKVx3GFnf6r+WyXmk3tBIagvAuZuUoyGyF6hBRMRY+w+ q2GL8A63MwUQROpa9RHey+3JvvXiEMbwJjILVEpc1qDC5hNMkgKZN+BflxTjwGdD/LM7qeqM/G1 kZz7P3NKrrY7XvPJ8PzYz8EF0M2iW11XHFMNoaYeGrPvQRLMarXY+B86ONN5GoQMVSppCQoTgAq bxqK4+41SeipK3+fHKVClZr/UjZ1XplAfM/n2LGrBs X-Gm-Gg: AY/fxX7k6dwwNZCrlGHSgUCrqLt6agaOLg1py1ddeIp0GjjwQjnSoeB3fMulgrL/Vzo KwKwJ4o5CUZRSbxuZV5Z4Q72VoXGruzZVyNR9n+EUf7Ly+T/Vaaoh2qYu+tV5oDvvqZx0b2IFTs kHaXOPN+CLuvTUrcn5hI4vRrUDmZH+RX/o+n6/rVkNHHh6HM5hvJOmfX54N+lRaqz9M09EBbTGA kJWETxMnfTbQmtBVEOm8DwS1OVNbTwLhLI4pCaiIkwzOhYyMD5i3CSzSlh+Vg1O6gpZ9Nmuguwd PA9yK7IdqYcIamtr50gOZvBc7PAOX5XYJlydtoR5lukZ/w1pvQswMh+fzoGD1vp/B3nRVRhkTBX Yu3S8miGYdi6G26ZKDXbnBklHim+zFnEJMLWSTnr8vsZWsnXtE76Q7uYU2rN0th0hySUlxoU/Uc 3vaBLDKt7a/7UA8A== X-Received: by 2002:a05:600c:8b2c:b0:477:6d96:b3e5 with SMTP id 5b1f17b1804b1-47d84b186b4mr221323515e9.7.1768302831448; Tue, 13 Jan 2026 03:13:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IEZK4ASfgxJhFFBIyVhu10frPcEyB1FSdZ9Qxo/SeOq9jj5yGf4hBk6TUt9JssekFUITQ2/Ug== X-Received: by 2002:a05:600c:8b2c:b0:477:6d96:b3e5 with SMTP id 5b1f17b1804b1-47d84b186b4mr221323135e9.7.1768302830902; Tue, 13 Jan 2026 03:13:50 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Zhao Liu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 7/7] rust: Update Cargo.lock Date: Tue, 13 Jan 2026 12:13:33 +0100 Message-ID: <20260113111333.1138160-8-pbonzini@redhat.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260113111333.1138160-1-pbonzini@redhat.com> References: <20260113111333.1138160-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_FILL_THIS_FORM_SHORT=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1768302889577158500 From: Zhao Liu `cargo +nightly build` updates Cargo.lock file. Reported-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Zhao Liu Link: https://lore.kernel.org/r/20260112090900.880621-1-zhao1.liu@intel.com Signed-off-by: Paolo Bonzini --- rust/Cargo.lock | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/rust/Cargo.lock b/rust/Cargo.lock index 42ae857fe53..78452c3db9b 100644 --- a/rust/Cargo.lock +++ b/rust/Cargo.lock @@ -1,6 +1,6 @@ # This file is automatically @generated by Cargo. # It is not intended for manual editing. -version =3D 3 +version =3D 4 =20 [[package]] name =3D "anyhow" @@ -233,6 +233,8 @@ dependencies =3D [ [[package]] name =3D "probe" version =3D "0.5.2" +source =3D "registry+https://github.com/rust-lang/crates.io-index" +checksum =3D "136558b6e1ebaecc92755d0ffaf9421f519531bed30cc2ad23b22cb00965= cc5e" =20 [[package]] name =3D "proc-macro-error" @@ -392,7 +394,6 @@ dependencies =3D [ "migration", "qom", "system", - "trace", "util", ] =20 --=20 2.52.0