From nobody Tue Feb 10 07:43:02 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=laurent@vivier.eu; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=vivier.eu ARC-Seal: i=1; a=rsa-sha256; t=1768298663; cv=none; d=zohomail.com; s=zohoarc; b=Eo2l6hc/NgiRA5qFMYjPrAjeWQJ92RaJhsULGMfwcWlDP1fFoXSvIRhD8DlIthdjW1Qe5gUxzkAZq1J9U6bfluCLEQTADnPuKqvKtCFrP8jfs1HZQVEkg/HGbvhN+O6IVa8V6z4RI1RTZJ+t3M2TE9pHv5oVPhfQmFwhFtrHY+U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768298663; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=HSbgJ/1VS+TqTvkTZnifrLNWcol7TXzwMJEBDNjkg/8=; b=kt7d2KMQ8rya+qo5ipDLkZWm49OBhcCddV28iuuLkbje8N0ipULP95ZV8J133E6xfXHPL+iyWNXyPfPPhL6Qe2uvAJv+D0I3Tp4xGw4XQ38JEzZHB3vNA7an1O7D8puOkHrshVgBgWoFTHt673X52C8gz7emGxcMtBiYAHqchpg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=laurent@vivier.eu; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768298663591318.1032444318862; Tue, 13 Jan 2026 02:04:23 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vfbFV-0000qn-Uj; Tue, 13 Jan 2026 05:03:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfbFJ-0000ou-2o for qemu-devel@nongnu.org; Tue, 13 Jan 2026 05:03:32 -0500 Received: from mout.kundenserver.de ([212.227.126.130]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfbFG-0006qY-2k for qemu-devel@nongnu.org; Tue, 13 Jan 2026 05:03:28 -0500 Received: from quad ([82.64.211.94]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.167]) with ESMTPSA (Nemesis) id 1N7Qkv-1vuOV20MJB-00zjlG; Tue, 13 Jan 2026 11:03:21 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivier.eu; s=s1-ionos; t=1768298601; x=1768903401; i=laurent@vivier.eu; bh=HSbgJ/1VS+TqTvkTZnifrLNWcol7TXzwMJEBDNjkg/8=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-ID:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=nkfPXF3MJ2shkXoNL0wBJ5TJnQuGzlN/4F73GX16T2McW7o4sjIotja60OPhlKfB voxrsl8plPvBemnAwvMFOkFF7SfhyjmmedbBeNevuGXJLWamkinzWHj1HvWLSgZkQ 70+olc6tgz9XZlUzaywdoecsL4GE7lKwMzBy7fymebx6GuQUWakfKAg/UR85Iv0Fi DaQzOysggcHtiimKdRZcQbKjf/egC7J5lvjsHG0JrUT6Zf2jaYmG6s6DHAT1VTrH+ uplt5kW8pLcq9+Ppph9Tg8oxE0FbgapiHZKwlXGOzCxblJB+LjsPD6JFrdO0hrOpn qP0qLSsASKhVcnF8dw== X-UI-Sender-Class: 55c96926-9e95-11ee-ae09-1f7a4046a0f6 From: Laurent Vivier To: qemu-devel@nongnu.org Cc: Laurent Vivier , Richard Henderson Subject: [PULL 1/3] m68k: fix CAS2 writeback when Dc1==Dc2 Date: Tue, 13 Jan 2026 11:03:18 +0100 Message-ID: <20260113100320.1009608-2-laurent@vivier.eu> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260113100320.1009608-1-laurent@vivier.eu> References: <20260113100320.1009608-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:mLQJucg1R8OfkwrTVD4IsH3WLcRtmDjD49oeDnz3000c9+/e9O/ fKmlC2CehyX2nwTYweWjVpWuNL/VdUzUJzVuMjQzWetHexaMgmLsEfsIYzfec9xS0V73c99 zDWPhLxtw1UDxXH5TAfRbkLgx9eYD8P3f3/zZaXZn0cUWpKh2cQc+v1TkqboClsJ00c6w0b 6OpTPvo4dOaYP+MEhMvbA== UI-OutboundReport: notjunk:1;M01:P0:sTCnfeH6X9c=;vrQEfCflQVIU8ZdXwNhCpbMt4PJ SmPpgu0+bztKTje1AGu/ahk7LVwIULLChthsAfhgYGvvhc2ztv1vd1loZRwZRWCmTrIZz4Nvc 5XwTtdTJLc97Ei5yYDx9MQA9QuClvJ0TwYz8gHbVe2xxMVNDwl7hEhTYWxA0RXAQzbJ60DvlD NTNucCS+kVeHnW9wuajDtSSGYvBhqvSzbMe3BGQ3YGiKmPj3XFeiJM9EMcXUDZ8/rRpRiET9g wQDfKclrRGg2MpwcEa55VODn5tOc8NrIeKsHQtsIyD8nUnC1ytocVQwKhRVJjUQIfCCudwvLj +KWnQjncfgBDFX3Oz62o4vLjGHJMGruFQ3vzWJfbmMQcHbA6jywE73Y96M8ZHky1gcCVAsJlf 7kibNCzyZsVd+m8HDf0jrW3tvzLmMpljS0ukz2c0vF5Lvq81ludn+LcAuGzjbeQVOwwKnGy0z bnYupNWwYPuDo02gDfQMkrzb6wUcKz49tum/6Fdu5efk1msDxOf/aUZgUDhirI7QGsmVdJkX1 +qGii89pj8FpTXE2pT8Mc/F7zoW40b17iIinXagEsn6ciAO+c4Hb20TD1KXDfpg9XFgZ5QsCy ex0IU0de+TOzaAt847V0s8VelZCdp7qHL7rBLGGGJ+NMh4/+pTQVEsqTTSKG23y4pqUeJjAL0 SizGPYNwJwKwmbYqP4eELwPzbkyd3W11pjE5Az5I8RIsiSiF/mTbMrfpJFleNZJh5kXMAdOXk Xrvce2qr9A1rNd0FuwlaFqqpNmFNi0XFIfHL2gF3tVs1lz/7yNNjarKndhuTDPjXYMZUtrhdf Nu+CaJpXN2ejv4t1TRmZVcyNkIKGaAVgcOC235O2HJ4SCdqqXvRODTS3YygothKr9cQtsy7fM A6Y9l4VQs9MdzwBNvT0eM706QwnrdUZeXZYAFoCWoKzxD8PdEiC7z4QWV4muUHgHD8BdEl4QM nRoJebJ64oW8j+t7UVZqCwOQl4c4nmyj2wyHj7gpLecyzI3xBEc+y6key21ZwchA4LJ5C3x+2 1NMptqiIZ1Ddyy6uKW+/vVs3DkbgR6ukIxTDx+/r6kdxs08bQeM5FBTh2koi/DVq61298DodG 0XXTdhfsQk7YYcKRxbrKwMSO0wy9Dvtpd1r9Vu39wP/NBYlwfLFVEaKDE2WfbHnEV/2uocUoy xAlyjhRj0Aq979GwFjP/4omN5Qw17ti9fkXRf/MUSeyS1wtIqZtxk3f3TlWFI8uU+/ETOmroP zHJqK7tx/PwSnMstc8sQddhIdnupeNOGz9nFaAgylSHKmX0BMhLsaH+QZci1NLwDh/9hxlqIx dlnfqwqNXIRQLrN2NuC8Ud+kheMAqFl8xSOCUofv/Ns5pAE3gJsqHupa8aEB+5oYLi37PNoR/ YIC4iRL7IytQMl8uDCzSO3YcBZ8mY2dEecshD0RFR8bkOXQw9SoG+p8TO6dXrqBmJO3GAJExF 4liL/YuNn4pr4Z/2TKu5knAD66sAJJMnnhkMbm9qY8RJXaD6FYqNNP9TGe+uIcM0GlMXzCV46 ME7LBmGmRWRxSDS07Unkm348fqsCFJduvezR26GU2DguxLP8VkQxaQWRXgcmjV08xQbH532U+ WoiIbsBE3mDGM+I0TxKZsdYFDRAVHR7pFtr/jwkrMYGPIMpnxgh1FEeRkGFVvgMZlRI1jUYYb n8pBzGQPByYAmTjRbOsh/aLuGVj0LeA+3W9ac40KC+Tgp8b/GGmy6RAwf+e9D+MXxArYI1lqn oj6ISMgglUgRqr7p2Gz3hGIpr6ycttYbjgoMIc+2VOJP2MNbF6fLWFv0= Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=212.227.126.130; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity laurent@vivier.eu) X-ZM-MESSAGEID: 1768298981268154100 Content-Type: text/plain; charset="utf-8" According to Programmer's Reference Manual, if Dc1 and Dc2 specify the same data register and the comparison fails, memory operand 1 is stored in the data register. The current helpers wrote Dc1 then Dc2, leaving operand 2 in the shared register. Swap the writeback order for cas2w/cas2l so memory operand 1 wins. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Message-ID: <20251226213707.331741-1-laurent@vivier.eu> --- target/m68k/op_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/m68k/op_helper.c b/target/m68k/op_helper.c index e9c20a8e0322..10266b1e0e8b 100644 --- a/target/m68k/op_helper.c +++ b/target/m68k/op_helper.c @@ -799,8 +799,8 @@ void HELPER(cas2w)(CPUM68KState *env, uint32_t regs, ui= nt32_t a1, uint32_t a2) env->cc_v =3D c2; } env->cc_op =3D CC_OP_CMPW; - env->dregs[Dc1] =3D deposit32(env->dregs[Dc1], 0, 16, l1); env->dregs[Dc2] =3D deposit32(env->dregs[Dc2], 0, 16, l2); + env->dregs[Dc1] =3D deposit32(env->dregs[Dc1], 0, 16, l1); } =20 static void do_cas2l(CPUM68KState *env, uint32_t regs, uint32_t a1, uint32= _t a2, @@ -861,8 +861,8 @@ static void do_cas2l(CPUM68KState *env, uint32_t regs, = uint32_t a1, uint32_t a2, env->cc_v =3D c2; } env->cc_op =3D CC_OP_CMPL; - env->dregs[Dc1] =3D l1; env->dregs[Dc2] =3D l2; + env->dregs[Dc1] =3D l1; } =20 void HELPER(cas2l)(CPUM68KState *env, uint32_t regs, uint32_t a1, uint32_t= a2) --=20 2.52.0