From nobody Sat Feb 7 07:30:33 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1768269201; cv=pass; d=zohomail.com; s=zohoarc; b=W0srU5hPSZ2rX91LwzM6CI7dyOEROsolMlauClfQCnHB00xI33aLbgR8d7ZIshXtcfd2QGp33poyrOqowJl8OsqIX7kQiztKKmGGvcrjCjTEKHqu1HaQ7cJtQtGQmoYcU2iLv/UaFPpWc0P9+ngiT4qm3/H/S2gK1JbyJObJxxA= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768269201; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=nNzMb23wBE/ZHkHfJlNU+2YMtq0NAVu9e75wTx3nMwo=; b=jvBP8/3VIOlqOF56X7tH39sVeEgYhU5neMl8pkSKzWAlkjvzvUXbZNfp6f2m/HfwvV6sS1rxcSYjOAbpX1lMoHNh4zDnZmUReKsifbxy3ZumDN1A3BsWAQXPDPuo92ozk+E/Ajc0i1vwTw/f1ZLVLR9FtOlnqGmukb1I+jwhJZI= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768269201910722.9136147764349; Mon, 12 Jan 2026 17:53:21 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vfTaO-0006br-2t; Mon, 12 Jan 2026 20:52:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfTaM-0006bY-M9 for qemu-devel@nongnu.org; Mon, 12 Jan 2026 20:52:42 -0500 Received: from mail-westusazlp170120002.outbound.protection.outlook.com ([2a01:111:f403:c001::2] helo=SJ2PR03CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfTaK-0006G6-Ik for qemu-devel@nongnu.org; Mon, 12 Jan 2026 20:52:42 -0500 Received: from SJ0PR13CA0187.namprd13.prod.outlook.com (2603:10b6:a03:2c3::12) by CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9499.7; Tue, 13 Jan 2026 01:52:32 +0000 Received: from CO1PEPF000075F4.namprd03.prod.outlook.com (2603:10b6:a03:2c3:cafe::16) by SJ0PR13CA0187.outlook.office365.com (2603:10b6:a03:2c3::12) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9520.4 via Frontend Transport; Tue, 13 Jan 2026 01:52:31 +0000 Received: from satlexmb07.amd.com (165.204.84.17) by CO1PEPF000075F4.mail.protection.outlook.com (10.167.249.43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9520.1 via Frontend Transport; Tue, 13 Jan 2026 01:52:31 +0000 Received: from honglei-remote.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 12 Jan 2026 19:52:28 -0600 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=es0mNUGBdPuYGE/twLpbJSTaYFPxoKvLRX5k4KKovYiFFkMuTR1O622T+iWoe55ncL1OD5UU0FMdtMAmiBpuRTIhjlkdylyZqw7geykaUoDZJ37N69SCxZfyr/AmySe3C/R5Lcl7tUWKEiNbLrMNacS20bztOBVgqDkoRREup0jG8/08naBJFBVQ85ljO0mPnJSqJnguBqH6hiiohqgIQlbaErPmCS7DVZVndZL7295SuLGZJpXqWkJZHZ19ld1cwLcGU+AXZ0j8DovgI7UrfBNmXAwGEGq8atYaLjPBumyRvMEZge4te3q+rFFNvY1UunrNHXQvaziFaexKnfd3TQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nNzMb23wBE/ZHkHfJlNU+2YMtq0NAVu9e75wTx3nMwo=; b=Uu9kk9uPTVcp/vxQ7IBfAyhkQzwRhyDD2OBEgzb0a52eWGdACC33fL56Er6N2JxdzU4x/FMk6Ak/QLfZmc7d10EsdZynZSohLx2jaxcRIqGdUrlueomA++CUDRS0tDtkHmR2z4N17CINpIAdKrlsgBghkLeSP1a3ArrE6Q7d12pFn1HUgw7/5PLkUleO2qzLJ4jfVbw9xBGScs7ki+mpTbBawW2lj+lzAN6uwZwbSQ3CGLlAthKxoGjw34wclwv9MiGrjyDebUYyKaGQ1c3iNtMgHpMaa8HWf0iH/7OABqD1Zwqi53I6vl9hu8UOJtTdk62QidIz/zhVvbpE+CdPig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linaro.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nNzMb23wBE/ZHkHfJlNU+2YMtq0NAVu9e75wTx3nMwo=; b=aXuJIzxJPetAGtFqXepTN6KrGxkGeiCOmn2dLSJxn0CBto04hxmkOe/XcqByTLAzdJAw4+kTARkCPw77Q9L/nfeEBsZ/n3WafLJ8Ta3krEVltW4sXCnSIQAdl6qiN7qfvvjQQeT8AH+gnufTKXITjadSPabjlSHsSnhsyPSnUt0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C From: Honglei Huang To: , , , CC: , , , , , Honglei Huang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [v6 1/2] virtio-gpu: fix error handling in virgl_cmd_resource_create_blob Date: Tue, 13 Jan 2026 09:52:02 +0800 Message-ID: <20260113015203.3643608-2-honghuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260113015203.3643608-1-honghuan@amd.com> References: <20260113015203.3643608-1-honghuan@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000075F4:EE_|CH3PR12MB9079:EE_ X-MS-Office365-Filtering-Correlation-Id: f560f504-5c52-47b8-bd2b-08de52466a5d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|82310400026|36860700013|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?NzNtM1pYY1JOVTlROFV4c2VOamlVZFp5TmRQVlArbVZrM3BHdFNBNk12aGVI?= =?utf-8?B?eFFtVU45Y1EyQVg4dG4xaDdsQll5azZrQThiRVVvdnIyY3JCNmVTb3RmaTR5?= =?utf-8?B?dnd6OWI3RDRXbmN3NW5yTklZR0lqYTQxNlVzWjZ1VjZYTWNZTEpJRWVNRFFw?= =?utf-8?B?YkNvUXNSQ1VBZ0dVY0ZZMUdhUUZQeDRJY2lqS2h4aEVMM29DY09EbTBhNThC?= =?utf-8?B?UmgwS2t6SDRlc0h2bGRlSDNxWndJZURjK0JHME5tUFFxRndSN2RxSGw4bTVH?= =?utf-8?B?UWN5VXlLM1JGa3EwWWJNUkRHYnBxL3RVZDlFQ1dGQVNveTZwYmtZV3pzYjlL?= =?utf-8?B?OXJtVGk4MVlrTnJOaGdJWW1GKzR1dkdlRktDdXY5NFFaV0VmTXl3aFprTkJK?= =?utf-8?B?Zmh0Y3M2aEhzVWIvWlJPSk5rN0tpQjNHUVhjWGM5Z2pESS9rcjhINVIzQXp2?= =?utf-8?B?TzdtRUFvMWRMV0RGN25PV0ZneTgrWGxDWHByZS9qNDdXMG1jVnozelA2UVo1?= =?utf-8?B?dFZhcEJ2L1JwK1hTRU52ZDlybkdyaDVQSUN5MlFTQjFGdnBQM2RXSklxWllp?= =?utf-8?B?YlJhRUhDcjU3MEJMSzF6azVUSGNoTTBFa2Y3Y2Q0RFZiRit1OGtkcnY2VFlO?= =?utf-8?B?Zkh4MC9uNnFrUGV5SkR1YVM4RXJ0RG1PU21LSWFSV2dac3JFSU5Zamt6TWg2?= =?utf-8?B?MkU3eFpNUnkwaDl4aE55TG1tdUVoQzVNL1djeCtkSXROUlZNUENFUWRVM2tG?= =?utf-8?B?eHB6Qi9EdzFOempLQjNON0dwTjkzVy9GNUliWGl5eXFVcUxwMmE2eEtUSG8w?= =?utf-8?B?OVpYMkptVTY4a1ljeC9KaHlDV00veDBkODJVcFJxZGRLVjJDS0ZaMG02a3BO?= =?utf-8?B?UUc4U0dHZFNVbHU3dUVsYyttZ3Fac1dZWlA0bEFwWk1mQ1p2ekM1SENuRHJq?= =?utf-8?B?NGRvckdDaXhMREdEZ0xlczZIL1FpVHltU1cwemJ6aVRDaXRodjNJVzJ5NDhp?= =?utf-8?B?K0Q3dHJhN25xQU1uVndVUlJmeW9Xb0hhTmsxY2RlT1NOY1gva0E2YlYyckpZ?= =?utf-8?B?akwxZWoySmhiTytNdUgzU2c5ZTZSdWo3WmRia2ppNm5WU0RrcEVnankvSkF3?= =?utf-8?B?d0M3Rm5RK3drQTc5L2ZKaU5yTFlScEowdnRGQzF5b1doYi9EODZXS2kyQUt4?= =?utf-8?B?R3RHVTlWcGpFWEFHREphZ0IveHpzaXR4QWszNHdOSDVyaS82UlF6ZmZmWWV2?= =?utf-8?B?NVNGQnZCS3lLWUdVaUhsa0lxY1c1OTBsY2l1eVZYemdsTkZxWGt6QU5zVVRm?= =?utf-8?B?S1NqNTV2ZUtLdEFuai90ckU3eHRpd2JlR0JDako4ZHRZb3d2OHEzVm56M0pU?= =?utf-8?B?MEpDT3J3UFhTUXFKa3kwUjJ4dG51cHZwMHJxUk1TUVRTS2wwZjJnT1hsZHNa?= =?utf-8?B?QkdERjI1Y0E4dkRVVTd4M1ZVMEpmSmR0ampKcUkvREJQTGx4OUo3NktMQmNw?= =?utf-8?B?UUdMRDdrZzkySWtzZ3dtU1c0MjY0MDlWRHZSTWRsS1RTRlZGaFYvdkJrWWdy?= =?utf-8?B?NElsUjlsMCtpbnNRYmtkVVZjZjFQRnI4bkNzVXoybUkwYXVGN3JHaTNoNzQr?= =?utf-8?B?MUFJdXQzSG5EcFdFM25qQU9iWkhDYy9SVGtNRVNzdm5LdTg1V1NaTENsOXBE?= =?utf-8?B?M2s0YUdVVjBwdkVMYjNzNXF0OXN0NTRiU2s2QXRRYXkyVDkzdFA0eXBhL0Fr?= =?utf-8?B?d3V3UWVidGRiTC9rZk9zWEd4OXRldzJiME43T2htb2M0a3psS01YYXJyTEhy?= =?utf-8?B?L2ozOTJGUTZSRDNkSDdJOEY0VVJlQ0Vuc3pyRHZyRUZiVEpRbmFZdFBqYmRX?= =?utf-8?B?ejNKS25jKzg4M3I2Q0tLUUVVaU43eEx0dHRJMEFNNCtFUm5ZT2w2MzVZTzlh?= =?utf-8?B?OVdFeCttRFdMemtMbXR4d0hvV0hMT3N5S2JRcFRKa1RJZ1k1c2MrcWlBV1pR?= =?utf-8?B?RWQ0cXJYM2poQUp0cWdpcGdEbGhyckxBTEFKb1BZbDZOMFd0WU56RlF3K3NU?= =?utf-8?B?aXN1b1hqWXh5OFhtcjhKcCs1d0t3U1NhcU5iNkprdXlkbXlaenhIZm9aYm9Y?= =?utf-8?Q?3QDo=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:satlexmb07.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(1800799024)(82310400026)(36860700013)(376014); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2026 01:52:31.7570 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f560f504-5c52-47b8-bd2b-08de52466a5d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000075F4.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB9079 Received-SPF: permerror client-ip=2a01:111:f403:c001::2; envelope-from=Honglei1.Huang@amd.com; helo=SJ2PR03CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1768269202539158500 Fix inverted error check in virgl_cmd_resource_create_blob() that causes the function to return error when virtio_gpu_create_mapping_iov() succeeds. virtio_gpu_create_mapping_iov() returns 0 on success and negative values on error. The check 'if (!ret)' incorrectly treats success (ret=3D0) as an error condition, causing the function to fail when it should succeed. Change the condition to 'if (ret !=3D 0)' to properly detect errors. Fixes: 7c092f17ccee ("virtio-gpu: Handle resource blob commands") Signed-off-by: Honglei Huang Reviewed-by: Akihiko Odaki Reviewed-by: Dmitry Osipenko Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/display/virtio-gpu-virgl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c index 94ddc01f91..e60e1059df 100644 --- a/hw/display/virtio-gpu-virgl.c +++ b/hw/display/virtio-gpu-virgl.c @@ -701,7 +701,7 @@ static void virgl_cmd_resource_create_blob(VirtIOGPU *g, ret =3D virtio_gpu_create_mapping_iov(g, cblob.nr_entries, sizeof(= cblob), cmd, &res->base.addrs, &res->base.iov, &res->base.iov= _cnt); - if (!ret) { + if (ret !=3D 0) { cmd->error =3D VIRTIO_GPU_RESP_ERR_UNSPEC; return; } --=20 2.34.1 From nobody Sat Feb 7 07:30:33 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1768269185; cv=pass; d=zohomail.com; s=zohoarc; b=Sepc6edePTxFbMYJfRionnZiZSkApvNGhg5mbC8TEBjEeVx8VDZC8fYE2mBmIzsnG2CWKI4h5ljfIUaoEcg8A+hycb8YPYBlM6bYVpLbB/++zhcmAB4p2vOqr3Qmij7LmPFFtGRcxvrLDY6SvnhO69KiFs8JPbDl2NItnGIBoyA= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768269185; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=jEX8m8fGGshdR7ZHUegkKnaKfi8rXuueZp+LhgZ89+o=; b=mtxJa5gtnTKRXlEXw4gKYgWYXFgEW6PCVgp43nnGn6uuVhqBb7Z4aZf9BVBPe6rbpmiCqbpFO/xG/oQi11QcP8G2/xW5T5S/ORCtExj7ZCfKjoSRLcNwt16J3EB95fjblX7ZkXaTWwsWkJu6XoKDUKzALqS5aY3h/qMj+g0o7mA= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768269185112535.6304499944962; Mon, 12 Jan 2026 17:53:05 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vfTaS-0006cZ-MZ; Mon, 12 Jan 2026 20:52:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfTaP-0006cC-7e for qemu-devel@nongnu.org; Mon, 12 Jan 2026 20:52:45 -0500 Received: from mail-southcentralusazlp170130001.outbound.protection.outlook.com ([2a01:111:f403:c10c::1] helo=SA9PR02CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfTaL-0006GH-9J for qemu-devel@nongnu.org; Mon, 12 Jan 2026 20:52:43 -0500 Received: from SJ0PR13CA0195.namprd13.prod.outlook.com (2603:10b6:a03:2c3::20) by CH1PR12MB9695.namprd12.prod.outlook.com (2603:10b6:610:2af::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9499.7; Tue, 13 Jan 2026 01:52:35 +0000 Received: from CO1PEPF000075F4.namprd03.prod.outlook.com (2603:10b6:a03:2c3:cafe::c3) by SJ0PR13CA0195.outlook.office365.com (2603:10b6:a03:2c3::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9520.4 via Frontend Transport; Tue, 13 Jan 2026 01:52:35 +0000 Received: from satlexmb07.amd.com (165.204.84.17) by CO1PEPF000075F4.mail.protection.outlook.com (10.167.249.43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9520.1 via Frontend Transport; Tue, 13 Jan 2026 01:52:34 +0000 Received: from honglei-remote.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 12 Jan 2026 19:52:31 -0600 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rF045M9R2q+5kafdRtrjgE9HLtyepsZ1uUlzwhYKRf0kWmWXHsh4r55xBzlpbowYSrbbREwZn80fqYmygpSEEAmwULHfmTTi9BVyWPW23kdYobjLfNM9VWjVgbuXcy/ZeyuaB4GdL55Rlww2a6Vqb9uBhxlXk4RuZfatDvHDLKT7Hzfl3YKlYGlvyJ6zmXenflVWPR6hO6qfIVxIcSmOmHFjdaDGuvX9d/Ji9QWx3Z6mmj02NbRUrgpovCtkMkVLgAk0vYwYqbVBQG4Yww4NVNAPFpQzT+JtsVci7xMdrbRpj9REX+tKxDho2e+YJqSUhBMGOJ7Ed5fxurIXCpwk+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jEX8m8fGGshdR7ZHUegkKnaKfi8rXuueZp+LhgZ89+o=; b=f8OFV0Bu1RF4DYC9gHbdwM//SiBVPBM1Pi3/Yp7afnJwpvbC/jcnJKJtpsEcoJmLVgm54OPlJlZhiBszaRyMZ0cOGmIVGsOAhQ9pbN9zzHxlpNTm438Hk0frEWgKGyuxePR5GE+yQjnQdMjwzxbB/mG7D0WD6yO3lPSGEu7y3d7NKO33ZzPRF6TdLH53SNAZVm48xmxZjYIckl9KAIzioJV40SoSaBWShp7c2NmQjLNeqZ3dKVvWAexUgk8wS8GhGoCnkq7fbXXNI4hghB7yS7mYnbfGHn7dj3EV7f3bYt6bta+DBl/EilY7zCEveKpwB4cJGMW7XKPC/N10SJ9LNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linaro.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jEX8m8fGGshdR7ZHUegkKnaKfi8rXuueZp+LhgZ89+o=; b=2gSEhrV/87nj1A7WKnaRZEbphAqDnBb1KtNQ/2h1Mku19Pb9+vSk3KUM67voIaLRC5itH/IPiu9ZN0KpJZe/5i1bapRKM9VYcU4EyiSKoc7gSaTtgu5E+9tYPyNdcXoJIt/+THZ20uz8kt20qy9JmOaOuAC5r3NAqOYHo6iP3eA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C From: Honglei Huang To: , , , CC: , , , , , Honglei Huang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [v6 2/2] virtio-gpu: use consistent error checking for virtio_gpu_create_mapping_iov Date: Tue, 13 Jan 2026 09:52:03 +0800 Message-ID: <20260113015203.3643608-3-honghuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260113015203.3643608-1-honghuan@amd.com> References: <20260113015203.3643608-1-honghuan@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000075F4:EE_|CH1PR12MB9695:EE_ X-MS-Office365-Filtering-Correlation-Id: 1683a47e-279c-4c8b-4654-08de52466c34 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|36860700013|1800799024|82310400026; X-Microsoft-Antispam-Message-Info: =?utf-8?B?QU41THkxVWwxV2hxT3RsMWxEY0s1YlA3YTZwNlY0aDBwcktRSUFQMHptNHh0?= =?utf-8?B?K1BNZ1dlcE8vL3poamdnbnZXam5KbXJHSHRZL29kNVpWaDlzbktFdXVnUTNw?= =?utf-8?B?WWszSTBRbVE0aGVYUVNJdDZicXJqbjIvcGU0R2tybm5HTUEvbitBajZicHgy?= =?utf-8?B?bEJ4THdVOXIzZnRxeXJxZjlYVjVESmlDVjR6NHgwYWFxTFNQNHI5YWR2RS8y?= =?utf-8?B?SGVyUjloZWdnT0JaS1Y3S0huTHdCZFl0V2hacDFqMld0MFZOU3FhbFlNS3Yw?= =?utf-8?B?dUxPZldxVGZEUTVoMkRBNUVPSkREYkhCampwcE40Tk1VMktlKzNwaFl4eXdT?= =?utf-8?B?b1ZiLytwMGd6cW4wc0paT0dFdzRudFlLYlR4azVNNUd4S2ZQUEhDK0l2Uk1q?= =?utf-8?B?Zmg5Q1FtQUNvV1hNTjhVTzQ5K0wzM0FaQWRPME12cmIwVFMyaWxaSi9wbTZw?= =?utf-8?B?R1RQdUFGMHFIR2h5VjVyMmUwVnEyeDl4SjRTbS9NckdWU1lBdHZWa2Z2eW5q?= =?utf-8?B?dWdpL1Q4ZlJxTVNzRUVBZ3Y0cmROa2d4a00rV2hTWHJ1WndFV3NLUmFaaUZY?= =?utf-8?B?a0RFUTBqbC8vbi8yL1oxOFNrTWoyVWlPUWxWNjA3V2Jscng5SmpUdXU5VHp1?= =?utf-8?B?TytQcjRsODEzQzI1UVdsK0l3RklTeEJ6S3dEV002MHlGSWl6TXZPZzI1TU12?= =?utf-8?B?V3drYWpnYXJBRkxoczFpQng0UHRXcllTK0J0SlFydmFMbyt3Um1FVzFVNWFa?= =?utf-8?B?NkZIN1F3QngrdFowckhxSzJlMEZvV0xqTjNVVzNNdHBDMjhPZ3VNdS9NbVZG?= =?utf-8?B?aHlSUG1PK2FjYWZ4OVNFTzFKWjJnOUsva1o0Q0xwbVk2YXpvNTN6bEl2cDFJ?= =?utf-8?B?TE14UUdndjl3Z0g5Ky91RW9FMlpPL3dJekxWT283STB6Y09vTWtrQ3gxMGw5?= =?utf-8?B?N2NJVDkzWXplZ0gvT1c3NEtYeksyOU5XQTlzTVpnNUlIUjF5ZUVTWXNUcXdr?= =?utf-8?B?RVNuaHRaSSszVEdZSm8zckt0anZVVm1udnpwZ3dFWURTdi91ZmtvdTVPRkNt?= =?utf-8?B?UGlqQmFjVUlmejJqVGw2Q1RYSXdyNVdEalVrODlZUndDdGRUNzFqNnBMUEx5?= =?utf-8?B?SnFvWmgvWW1iQ3AwaU94ZGNLUGpPTnVBbDRXWXIzcXhYZ3pFaEsyZHEyMktX?= =?utf-8?B?VzhOM2x4WUx2eml5Sk9XNEpQa3kvM1dlYnRGclh1cXlqdlpRVkhUWE9CWWhs?= =?utf-8?B?aythcWVpWGFrdjkyNDJ4VWRKK1ZvMXpoTk1wS1F3RGt2NDRIdjZsNEpuSStK?= =?utf-8?B?bFhWaWdRT2VyYmlJVTR2R2dJWHdUckZKZHU5dW4zUWxtM3doWDRXSzZubDk0?= =?utf-8?B?VWhQNkZRbjcwOUVQVDUwSzMyZHlmK0NMU0c0ZmQrNml0cTh1a1NyOFJPcGJF?= =?utf-8?B?ZHdkcG9uTE1HdGxhTnpRZzVPd0pmNzc0RVlkNmY3RGpETEdRclZZWkpsclRy?= =?utf-8?B?Y2NiSjZic0JoNlg5eXV3dWJCY29DY0dTVTRUZlI3MC9LSTlxTGpZWCtWUkE5?= =?utf-8?B?MDBVbnFUbkRaR0wrNzdIdzMvczNySW1pWlpJbFFGQWs3Z1RhU1h3ekxQVXBi?= =?utf-8?B?bjBNWlJyWmtQdVRnV3lRRGhMWXVzZGtzN0NES1VVQ1M4WlVqSkgzK0tIOUQ5?= =?utf-8?B?WFdTVGtMSEdxc2VLVkZORzRQQVRiS1pIclVTM0ZvRFBIQmt5RDdPWm0yV3o3?= =?utf-8?B?ODBKbXp3eGpOMmJLUmQ4eWxGUkZsK0xySkNuem1GM0lOdXk5YTR2OUxFa09l?= =?utf-8?B?UG5lNmZBM2U0aVZ0aGJrUmVqbnJMNXpKYTBOdFU2eXhvVkVPTDBSTzhOekFs?= =?utf-8?B?OTRDTFNDNWRVdHNKMWF4R000WWVucjlrWHI4amtnV2tvWlFhKzBvWS8wOGZN?= =?utf-8?B?aUxYbG1QMmxhQ3o2N2xsdEVzVVlqaUFEZ1E4dkd0VndGdHNlVCtkSTF2aUhh?= =?utf-8?B?bVJKSnNQQzlITlhMeG5NNWxHZkpmRjlrR3JmQXhqK1ljVFVFd3p2VFFqR2Fi?= =?utf-8?B?YmFWTDI1QWtYUTd5bThndHVhZDNzcDRUUVovU0ZUNkwvS2xNTEFuYmwyU3p5?= =?utf-8?Q?m6Q0=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:satlexmb07.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(376014)(36860700013)(1800799024)(82310400026); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2026 01:52:34.8413 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1683a47e-279c-4c8b-4654-08de52466c34 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000075F4.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH1PR12MB9695 Received-SPF: permerror client-ip=2a01:111:f403:c10c::1; envelope-from=Honglei1.Huang@amd.com; helo=SA9PR02CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1768269186844158500 Unify error checking style for virtio_gpu_create_mapping_iov() across the codebase to improve consistency and readability. virtio_gpu_create_mapping_iov() returns 0 on success and negative values on error. The original code used inconsistent patterns for checking errors: - Some used 'if (ret !=3D 0)' in virtio-gpu-virgl.c and virtio-gpu.c - Some used 'CHECK(!ret, cmd)' in virtio-gpu-rutabaga.c For if-statement checks, change to 'if (ret < 0)' which is the preferred QEMU coding convention for functions that return 0 on success and negative on error. This makes the return value convention immediately clear to code readers. For CHECK macro usage in virtio-gpu-rutabaga.c, keep the original 'CHECK(!ret, cmd)' pattern as it is more concise and consistent with other error checks in the same file. Updated locations: - hw/display/virtio-gpu-virgl.c: virgl_resource_attach_backing() - hw/display/virtio-gpu-virgl.c: virgl_cmd_resource_create_blob() - hw/display/virtio-gpu.c: virtio_gpu_resource_create_blob() - hw/display/virtio-gpu.c: virtio_gpu_resource_attach_backing() Signed-off-by: Honglei Huang Reviewed-by: Markus Armbruster Reviewed-by: Akihiko Odaki Reviewed-by: Dmitry Osipenko Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/display/virtio-gpu-virgl.c | 4 ++-- hw/display/virtio-gpu.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c index e60e1059df..6ebd9293e5 100644 --- a/hw/display/virtio-gpu-virgl.c +++ b/hw/display/virtio-gpu-virgl.c @@ -557,7 +557,7 @@ static void virgl_resource_attach_backing(VirtIOGPU *g, =20 ret =3D virtio_gpu_create_mapping_iov(g, att_rb.nr_entries, sizeof(att= _rb), cmd, NULL, &res_iovs, &res_niov); - if (ret !=3D 0) { + if (ret < 0) { cmd->error =3D VIRTIO_GPU_RESP_ERR_UNSPEC; return; } @@ -701,7 +701,7 @@ static void virgl_cmd_resource_create_blob(VirtIOGPU *g, ret =3D virtio_gpu_create_mapping_iov(g, cblob.nr_entries, sizeof(= cblob), cmd, &res->base.addrs, &res->base.iov, &res->base.iov= _cnt); - if (ret !=3D 0) { + if (ret < 0) { cmd->error =3D VIRTIO_GPU_RESP_ERR_UNSPEC; return; } diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c index 0a1a625b0e..1038c6a49f 100644 --- a/hw/display/virtio-gpu.c +++ b/hw/display/virtio-gpu.c @@ -352,7 +352,7 @@ static void virtio_gpu_resource_create_blob(VirtIOGPU *= g, ret =3D virtio_gpu_create_mapping_iov(g, cblob.nr_entries, sizeof(cblo= b), cmd, &res->addrs, &res->iov, &res->iov_cnt); - if (ret !=3D 0) { + if (ret < 0) { cmd->error =3D VIRTIO_GPU_RESP_ERR_UNSPEC; g_free(res); return; @@ -931,7 +931,7 @@ virtio_gpu_resource_attach_backing(VirtIOGPU *g, =20 ret =3D virtio_gpu_create_mapping_iov(g, ab.nr_entries, sizeof(ab), cm= d, &res->addrs, &res->iov, &res->iov_= cnt); - if (ret !=3D 0) { + if (ret < 0) { cmd->error =3D VIRTIO_GPU_RESP_ERR_UNSPEC; return; } --=20 2.34.1