From nobody Tue Feb 10 11:14:52 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1768258539; cv=none; d=zohomail.com; s=zohoarc; b=JqJJ+oaP0aGTSESRcVLZu5T3G7EmDIEyAKR0ZMM2AhuAuWXZ6JyFWy7BLvP4O2qRZ+APV+7jUvSQ/V3eq9dlEyEHvLbVfXE9+8WWGnKgIE1vfNSky50m03gX0woHhrCg0AQ/9lvMO7OwdBbVFirVWhCKshozQTeB7ioRv3HzFNk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768258539; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=Ah9BF/VcfsLL8VVVNiMpTcrCPmkwaYSoypo2iXLHxLA=; b=YrV0F5FgOmefCoVBrnHeIN7paMN1BWxJt+obhc4KMxk8QhCsbkjxeVrezk/2b/0gUieuTl1aR3Irn1yd9VNjOufgIes0aJdP2ESB/XVmZTvMwZUk6L7ceaLCvglRjr4vMZlRv5hIwMw1zfBCUkU1rtCQAkKoVv+uMUeY6RF28ZA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768258539657444.3750149304959; Mon, 12 Jan 2026 14:55:39 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vfQoK-0001it-KK; Mon, 12 Jan 2026 17:54:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfQoI-0001K7-8f for qemu-devel@nongnu.org; Mon, 12 Jan 2026 17:54:54 -0500 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vfQoG-0003q3-EU for qemu-devel@nongnu.org; Mon, 12 Jan 2026 17:54:53 -0500 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-430fbb6012bso5601482f8f.1 for ; Mon, 12 Jan 2026 14:54:52 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5df90dsm41009150f8f.20.2026.01.12.14.54.49 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 12 Jan 2026 14:54:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768258491; x=1768863291; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Ah9BF/VcfsLL8VVVNiMpTcrCPmkwaYSoypo2iXLHxLA=; b=kPlVasWP8jULiANbGyWoD0ZSy5b84WeTsS43U/rEyAhnHQ+g+jwXdmMK/T7pG/0CpG MCF+bsCi7cMkVmx0zINt/IGQH5B/o9Cqi5N/xMoYgTZbcQh5c58scFNFcPUjNiI4MiBm ILEh8jnPGs0ebd0SP5/aeOX1iDkplPU+qwy6aWS5oBNm2m7xoyp7AAYk8wwEn8rg/1hI 7perrz2Fr69wquFzUrI8TnajYTAsoCDj5Gmlv/hjJvomZzFMuukT9LAJLtBan5ICAByh 8rsq8AK+Brao6TG5o5S/nh6AABM2GNjg8t/BnimHq8RlRPDzcdFXMBeb7BjKRTKuRAFS nEZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768258491; x=1768863291; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Ah9BF/VcfsLL8VVVNiMpTcrCPmkwaYSoypo2iXLHxLA=; b=AAOGVJ3wU1FOXBemS/ho/XZXvioa/bx+UNvk3ZLcXE/aD0IK4dq9YBRm/TThFSpEXX dr7Gpl7NieILr0r9vxZqL487m7cEe+swf0xA4MxHizNvyog5mb6FOSKsXduhYqOowom1 Rc11UFjkQzcGa9tMPmJjYeqvqxNfPAzDm04NCtIAH5y+yzQh1zqeXf1VnpGo7HExdpZN Zwa1Fhg2rM9KIReRhxqBxxnY9EgJiyfjnQuC3hd6nqK+mBUwgetlF0P2rW4FO5leJjOM YHg82aZuCuGjxq+NhT8/JvYkB7ZJuM+bhNo4x9783LuopWgjhsFZO8FMwHvBYnN219HL WzVg== X-Gm-Message-State: AOJu0YwWZb9v3g2zBRmQIBav8kTbfOQQrexLGYezYpCEyOJJ2zbgPk/D ehcNjW54s/F/rh1mSuMzxbWUKtVndsYfEzmagC0PxvWmfXCoS+KQ+c6h4Tp6nURWrJB8aYspWkY W7jrnixc= X-Gm-Gg: AY/fxX7H/oC0Tdlm30/teBHhfhBHjOngcXv9BHcaw7bmrVfIVNqLGcQdj6+P0K32wN5 Qz/lUM9qHucSUP5zNYkqMlXL5BoEc3gMg3oKEO7U1c69bPmtXJtazr/rAzNqlOHIBMDKoJvPntY zGarg9kDK2D78hoe0G4/jaiQq1ZhN2qdJMHM/T8ZUsZt9USWQ6pEp+n9S9vK4/l5FnG/cTNUsIw xbPuzGCr4SkSXA2avoH2n2IdwBs7l5VoEy05ioYDtJdgAIQrwW23psfNPhmq8UpNjN7ukoDUpnb uejSSg/U9SNzHuUMK8yyIBILSV1J1ITjEThvPfFiyiLXuZoG26oh9vWlRyAmP4MsQpF9MqnWFcw ILQ1/iiBrLwd6+H0tWvbcdp5u7xHGQBd01ChuUmSmhmBNpXX6Xouq5wPi2TbugqUrVvLUcLrqNc DFS6hMRA6gOWVAAZXjredTfYU5BFjnSfHn4PAZKKqcVRTFBzVy9Cqz2orFPLoX X-Google-Smtp-Source: AGHT+IFwMLobgUCMmCWmKpuqKGjIPqcsikTS/fNCPS1TbUiuW2qE+fGsnMHYJfEoTvK5BD4bbQECrA== X-Received: by 2002:a05:6000:1449:b0:430:feb3:f5ae with SMTP id ffacd0b85a97d-432c37a721dmr19382355f8f.55.1768258490557; Mon, 12 Jan 2026 14:54:50 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 51/61] hw/sparc: Use explicit big-endian LD/ST API Date: Mon, 12 Jan 2026 23:48:46 +0100 Message-ID: <20260112224857.42068-52-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260112224857.42068-1-philmd@linaro.org> References: <20260112224857.42068-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=philmd@linaro.org; helo=mail-wr1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1768258541193158500 The SPARC architecture uses big endianness. Directly use the big-endian LD/ST API. Mechanical change running: $ for a in uw w l q; do \ sed -i -e "s/ld${a}_p(/ld${a}_be_p(/" \ $(git grep -wlE '(ld|st)u?[wlq]_p' hw/sparc*/); done Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Mark Cave-Ayland Reviewed-by: Chigot Cl=C3=A9ment Reviewed-by: Manos Pitsidianakis Message-ID: <20251218221457.73341-2-philmd@linaro.org> --- hw/sparc/leon3.c | 42 +++++++++++++++++++++--------------------- hw/sparc/sun4m.c | 6 +++--- hw/sparc64/sun4u.c | 6 +++--- 3 files changed, 27 insertions(+), 27 deletions(-) diff --git a/hw/sparc/leon3.c b/hw/sparc/leon3.c index d4e25f761a6..9147d56bd4e 100644 --- a/hw/sparc/leon3.c +++ b/hw/sparc/leon3.c @@ -79,21 +79,21 @@ typedef struct ResetData { =20 static uint32_t *gen_store_u32(uint32_t *code, hwaddr addr, uint32_t val) { - stl_p(code++, 0x82100000); /* mov %g0, %g1 */ - stl_p(code++, 0x84100000); /* mov %g0, %g2 */ - stl_p(code++, 0x03000000 + + stl_be_p(code++, 0x82100000); /* mov %g0, %g1 */ + stl_be_p(code++, 0x84100000); /* mov %g0, %g2 */ + stl_be_p(code++, 0x03000000 + extract32(addr, 10, 22)); /* sethi %hi(addr), %g1 */ - stl_p(code++, 0x82106000 + + stl_be_p(code++, 0x82106000 + extract32(addr, 0, 10)); /* or %g1, addr, %g1 */ - stl_p(code++, 0x05000000 + + stl_be_p(code++, 0x05000000 + extract32(val, 10, 22)); /* sethi %hi(val), %g2 */ - stl_p(code++, 0x8410a000 + + stl_be_p(code++, 0x8410a000 + extract32(val, 0, 10)); /* or %g2, val, %g2 */ - stl_p(code++, 0xc4204000); /* st %g2, [ %g1 ] */ + stl_be_p(code++, 0xc4204000); /* st %g2, [ %g1 ] */ =20 return code; } @@ -113,13 +113,13 @@ static void write_bootloader(void *ptr, hwaddr kernel= _addr) =20 /* If we are running on a secondary CPU, jump directly to the kernel. = */ =20 - stl_p(p++, 0x85444000); /* rd %asr17, %g2 */ - stl_p(p++, 0x8530a01c); /* srl %g2, 0x1c, %g2 */ - stl_p(p++, 0x80908000); /* tst %g2 */ + stl_be_p(p++, 0x85444000); /* rd %asr17, %g2 */ + stl_be_p(p++, 0x8530a01c); /* srl %g2, 0x1c, %g2 */ + stl_be_p(p++, 0x80908000); /* tst %g2 */ /* Filled below. */ sec_cpu_branch_p =3D p; - stl_p(p++, 0x0BADC0DE); /* bne xxx */ - stl_p(p++, 0x01000000); /* nop */ + stl_be_p(p++, 0x0BADC0DE); /* bne xxx */ + stl_be_p(p++, 0x01000000); /* nop */ =20 /* Initialize the UARTs */ /* *UART_CONTROL =3D UART_RECEIVE_ENABLE | UART_TRANSMIT_ENABLE; */ @@ -134,17 +134,17 @@ static void write_bootloader(void *ptr, hwaddr kernel= _addr) p =3D gen_store_u32(p, 0x80000318, 3); =20 /* Now, the relative branch above can be computed. */ - stl_p(sec_cpu_branch_p, 0x12800000 - + (p - sec_cpu_branch_p)); + stl_be_p(sec_cpu_branch_p, 0x12800000 + + (p - sec_cpu_branch_p)); =20 /* JUMP to the entry point */ - stl_p(p++, 0x82100000); /* mov %g0, %g1 */ - stl_p(p++, 0x03000000 + extract32(kernel_addr, 10, 22)); - /* sethi %hi(kernel_addr), %g1 */ - stl_p(p++, 0x82106000 + extract32(kernel_addr, 0, 10)); - /* or kernel_addr, %g1 */ - stl_p(p++, 0x81c04000); /* jmp %g1 */ - stl_p(p++, 0x01000000); /* nop */ + stl_be_p(p++, 0x82100000); /* mov %g0, %g1 */ + stl_be_p(p++, 0x03000000 + extract32(kernel_addr, 10, 22)); + /* sethi %hi(kernel_addr), %g1 */ + stl_be_p(p++, 0x82106000 + extract32(kernel_addr, 0, 10)); + /* or kernel_addr, %g1 */ + stl_be_p(p++, 0x81c04000); /* jmp %g1 */ + stl_be_p(p++, 0x01000000); /* nop */ } =20 static void leon3_cpu_reset(void *opaque) diff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4m.c index 8ad4eb46bbe..0c0d658d301 100644 --- a/hw/sparc/sun4m.c +++ b/hw/sparc/sun4m.c @@ -268,9 +268,9 @@ static unsigned long sun4m_load_kernel(const char *kern= el_filename, if (*initrd_size > 0) { for (i =3D 0; i < 64 * TARGET_PAGE_SIZE; i +=3D TARGET_PAGE_SI= ZE) { ptr =3D rom_ptr(KERNEL_LOAD_ADDR + i, 24); - if (ptr && ldl_p(ptr) =3D=3D 0x48647253) { /* HdrS */ - stl_p(ptr + 16, INITRD_LOAD_ADDR); - stl_p(ptr + 20, *initrd_size); + if (ptr && ldl_be_p(ptr) =3D=3D 0x48647253) { /* HdrS */ + stl_be_p(ptr + 16, INITRD_LOAD_ADDR); + stl_be_p(ptr + 20, *initrd_size); break; } } diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c index d3ce32b6b09..5d7787fc1a5 100644 --- a/hw/sparc64/sun4u.c +++ b/hw/sparc64/sun4u.c @@ -206,9 +206,9 @@ static uint64_t sun4u_load_kernel(const char *kernel_fi= lename, if (*initrd_size > 0) { for (i =3D 0; i < 64 * TARGET_PAGE_SIZE; i +=3D TARGET_PAGE_SI= ZE) { ptr =3D rom_ptr(*kernel_addr + i, 32); - if (ptr && ldl_p(ptr + 8) =3D=3D 0x48647253) { /* HdrS */ - stl_p(ptr + 24, *initrd_addr + *kernel_addr); - stl_p(ptr + 28, *initrd_size); + if (ptr && ldl_be_p(ptr + 8) =3D=3D 0x48647253) { /* HdrS = */ + stl_be_p(ptr + 24, *initrd_addr + *kernel_addr); + stl_be_p(ptr + 28, *initrd_size); break; } } --=20 2.52.0