From nobody Mon Feb 9 00:30:51 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1768250527; cv=none; d=zohomail.com; s=zohoarc; b=ac5lPkTmOXJBIVA/Qh8YW59Ji0RIE1KqRd18Ok8UqhCbI3DRhq9aYE9GxrQQAl8P2E9pNcPCW73Mcm34CEv1qcr1rJNVtVAOOw/F7dbGNHxxa5y+kLuJc7fvG8a1XhyNQJ6QIyFCbxt6HM5eAjLwIJNXHrUQCHA6M5P4oyfDSqY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768250527; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=dF1H6qznpiQYfOI1hQnBHGD2oROtcCfhHIsx6kC/alQ=; b=nhz6fgSC1lXHOvajy0UN/Lk8pY1mH4B4+gB+jfIvQsUIb7G/Et4VKx9eOVw0+ULBfVzL7Otich0woPm0FaQ6TPrFKngjD0/jQ3FhcK6tsidYDOiJBFLusCjK3B+uk+YR+l+Wg++CpRWrivjRDfXVgXim8ouxGvhGPfiT2mhDapU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768250527961730.3267818228551; Mon, 12 Jan 2026 12:42:07 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vfOiz-0007dK-6F; Mon, 12 Jan 2026 15:41:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfOix-0007cl-Ft for qemu-devel@nongnu.org; Mon, 12 Jan 2026 15:41:15 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfOiw-0000r2-0d for qemu-devel@nongnu.org; Mon, 12 Jan 2026 15:41:15 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-399-pllCwTavPY6_kUCBG7LM2A-1; Mon, 12 Jan 2026 15:41:10 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 11E9918003FD; Mon, 12 Jan 2026 20:41:09 +0000 (UTC) Received: from toolbx.redhat.com (unknown [10.42.28.178]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5C4B330001A2; Mon, 12 Jan 2026 20:41:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768250473; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dF1H6qznpiQYfOI1hQnBHGD2oROtcCfhHIsx6kC/alQ=; b=gaK4hWW1RiagmizO+VVSo22Bt+XaauxWNHr/mwj+/u+F3mwDau3cPWpamZ6Mu/UP8YQ2mV tY9Cd0aHSCATzK2cv4SeUUSz2RVGPDK9GGyR4vCVyrsyi+JxnPHilunf9o7wxqXf704wLu MeurXZUihC0SxzX0NHcm8rrWm+r8xmM= X-MC-Unique: pllCwTavPY6_kUCBG7LM2A-1 X-Mimecast-MFC-AGG-ID: pllCwTavPY6_kUCBG7LM2A_1768250469 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: Hanna Reitz , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , John Snow , Paolo Bonzini , qemu-block@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Kevin Wolf , Thomas Huth , Cleber Rosa , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH v2 12/13] tests: add QEMU_TEST_IO_SKIP for skipping I/O tests Date: Mon, 12 Jan 2026 20:40:25 +0000 Message-ID: <20260112204026.710659-13-berrange@redhat.com> In-Reply-To: <20260112204026.710659-1-berrange@redhat.com> References: <20260112204026.710659-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1768250529477158501 The nature of block I/O tests is such that there can be unexpected false positive failures in certain scenarios that have not been encountered before, and sometimes non-deterministic failures that are hard to reproduce. Before enabling the I/O tests as gating jobs in CI, there needs to be a mechanism to dynamically mark tests as skipped, without having to commit code changes. This introduces the QEMU_TEST_IO_SKIP environment variable that is set to a list of FORMAT-OR-PROTOCOL:NAME pairs. The intent is that this variable can be set as a GitLab CI pipeline variable to temporarily disable a test while problems are being debugged. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Thomas Huth --- docs/devel/testing/main.rst | 7 +++++++ tests/qemu-iotests/testrunner.py | 16 ++++++++++++++++ 2 files changed, 23 insertions(+) diff --git a/docs/devel/testing/main.rst b/docs/devel/testing/main.rst index 910ec11ab4..bb90ea5f15 100644 --- a/docs/devel/testing/main.rst +++ b/docs/devel/testing/main.rst @@ -285,6 +285,13 @@ that are specific to certain cache mode. More options are supported by the ``./check`` script, run ``./check -h`` f= or help. =20 +If a test program is known to be broken, it can be disabled by setting +the ``QEMU_TEST_IO_SKIP`` environment variable with a list of tests to +be skipped. The values are of the form FORMAT-OR-PROTOCOL:NAME, the +leading component can be omitted to skip the test for all formats and +protocols. For example ``export QEMU_TEST_IO_SKIP=3D"luks:149 185 iov-padd= ing`` +will skip for LUKS only, and ``185`` and ``iov-padding`` for all. + Writing a new test case ~~~~~~~~~~~~~~~~~~~~~~~ =20 diff --git a/tests/qemu-iotests/testrunner.py b/tests/qemu-iotests/testrunn= er.py index dbe2dddc32..ecb5d4529f 100644 --- a/tests/qemu-iotests/testrunner.py +++ b/tests/qemu-iotests/testrunner.py @@ -145,6 +145,18 @@ def __init__(self, env: TestEnv, tap: bool =3D False, =20 self._stack: contextlib.ExitStack =20 + self.skip =3D {} + for rule in os.environ.get("QEMU_TEST_IO_SKIP", "").split(" "): + rule =3D rule.strip() + if rule =3D=3D "": + continue + if ":" in rule: + fmt, name =3D rule.split(":") + if fmt in ("", env.imgfmt, env.imgproto): + self.skip[name] =3D True + else: + self.skip[rule] =3D True + def __enter__(self) -> 'TestRunner': self._stack =3D contextlib.ExitStack() self._stack.enter_context(self.env) @@ -251,6 +263,10 @@ def do_run_test(self, test: str) -> TestResult: description=3D'No qualified output ' f'(expected {f_reference})') =20 + if f_test.name in self.skip: + return TestResult(status=3D'not run', + description=3D'Listed in QEMU_TEST_IO_SKIP') + args =3D [str(f_test.resolve())] env =3D self.env.prepare_subprocess(args) =20 --=20 2.52.0