From nobody Mon Feb 9 16:51:01 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1768223898; cv=none; d=zohomail.com; s=zohoarc; b=A/gpgRkKhzmMaeuTNKOPpfspvrc8WPicDiaI7SXBJGvlQPUNnSo/xChUW54BzUoliPUcXhzixH/qLVfvA8iwQw29vo90Z/VNYAHV3KE3Z+6VRETqpKeUXHIe2HgYYx7jRk8c0CCyZzeeFqZBDrfvVH3W/1JwQyQnnHNCMcQZ9uk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768223898; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=10XZMlig4LGw9p0kOKwBqLurpUaIpsrfkUplGVNrEW0=; b=FPTTElpoOVgXnkitYye7h/C9Mo82TZA09RHW4T5kbdnnLROhdt8obTmF1F5smsg6ah66H2s7K0ehR5eJOFKNvEpO9OQIw3m6sPzgh25q8JxrchGnx4mGNwL4wU0Su3F7SMMCUnYKFpdtoSQGrP+NgH6h1eLXhRwnxqPwZSsv/8o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768223898538711.1932331629085; Mon, 12 Jan 2026 05:18:18 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vfHo5-0002pO-89; Mon, 12 Jan 2026 08:18:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfHlP-0001S9-JZ for qemu-devel@nongnu.org; Mon, 12 Jan 2026 08:15:20 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfHlO-0002Wb-0r for qemu-devel@nongnu.org; Mon, 12 Jan 2026 08:15:19 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-359-BkLs4P87PjGmXX1qo96UHA-1; Mon, 12 Jan 2026 08:15:15 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8060C1956050; Mon, 12 Jan 2026 13:15:14 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.224.179]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id ED38430001A7; Mon, 12 Jan 2026 13:15:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768223717; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=10XZMlig4LGw9p0kOKwBqLurpUaIpsrfkUplGVNrEW0=; b=SQQBqjiZ/89/nQ8C2L8oRfjeQ+n3hf1Epe23Kt3chVSIOUtOgxXL0s3frn1X728KHyeDfI NOW0jy3qKxBsESiCG8fw5dWuZZ2a/uYJoBVIr+8cONFPCPOkyjUz2vy3q+i+Lpp96+P0pO nxfDy1X/IWwwZo94YX0Ok7XUDSbsFVs= X-MC-Unique: BkLs4P87PjGmXX1qo96UHA-1 X-Mimecast-MFC-AGG-ID: BkLs4P87PjGmXX1qo96UHA_1768223714 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson Subject: [PULL 06/15] tests/functional: Add a generic test that checks the files with pylint Date: Mon, 12 Jan 2026 14:14:48 +0100 Message-ID: <20260112131457.67128-7-thuth@redhat.com> In-Reply-To: <20260112131457.67128-1-thuth@redhat.com> References: <20260112131457.67128-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1768223899524158500 Content-Type: text/plain; charset="utf-8" From: Thomas Huth To avoid that new pylint-related warnings get committed, let's check the files with pylint during each run (similar to what we are doing for the iotests already). Message-Id: <20251119082636.43286-16-thuth@redhat.com> Signed-off-by: Thomas Huth --- MAINTAINERS | 1 + tests/functional/generic/meson.build | 1 + tests/functional/generic/test_linters.py | 41 ++++++++++++++++++++++++ 3 files changed, 43 insertions(+) create mode 100755 tests/functional/generic/test_linters.py diff --git a/MAINTAINERS b/MAINTAINERS index a6168cb46f7..6dfd9b27c20 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4461,6 +4461,7 @@ F: docs/devel/testing/functional.rst F: scripts/clean_functional_cache.py F: tests/functional/meson.build F: tests/functional/generic/meson.build +F: tests/functional/generic/test_linters.py F: tests/functional/pylintrc F: tests/functional/qemu_test/ =20 diff --git a/tests/functional/generic/meson.build b/tests/functional/generi= c/meson.build index 013cc96fbf8..09763c5d229 100644 --- a/tests/functional/generic/meson.build +++ b/tests/functional/generic/meson.build @@ -3,6 +3,7 @@ tests_generic_system =3D [ 'empty_cpu_model', 'info_usernet', + 'linters', 'version', 'vnc', ] diff --git a/tests/functional/generic/test_linters.py b/tests/functional/ge= neric/test_linters.py new file mode 100755 index 00000000000..b5b90fcf7a3 --- /dev/null +++ b/tests/functional/generic/test_linters.py @@ -0,0 +1,41 @@ +#!/usr/bin/env python3 +# +# SPDX-License-Identifier: GPL-2.0-or-later +# +'''Python linter tests''' + +import os + +from pathlib import Path +from qemu_test import QemuBaseTest, skipIfMissingImports + + +class LinterTest(QemuBaseTest): + ''' + Run python linters on the test *.py files + ''' + + @skipIfMissingImports("pylint") + def test_pylint(self): + '''Check source files with pylint''' + from pylint.lint import Run as pylint_run + from pylint.reporters.collecting_reporter import CollectingReporter + srcdir =3D os.path.join(Path(__file__).parent.parent, self.arch) + rcfile =3D os.path.join(Path(__file__).parent.parent, "pylintrc") + self.log.info('Checking files in %s with pylint', srcdir) + reporter =3D CollectingReporter() + pylint_run(["--rcfile", rcfile, srcdir], reporter=3Dreporter, exit= =3DFalse) + if reporter.messages: + fmt =3D '"{path}:{line}: {msg_id}: {msg} ({symbol})"' + for msg in reporter.messages: + if msg.category =3D=3D "error": + self.log.error(msg.format(fmt)) + elif msg.category =3D=3D "warning": + self.log.warning(msg.format(fmt)) + else: + self.log.info(msg.format(fmt)) + self.fail("Pylint failed, see base.log for details.") + + +if __name__ =3D=3D '__main__': + QemuBaseTest.main() --=20 2.52.0