From nobody Sun Feb 8 12:31:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1768223768; cv=none; d=zohomail.com; s=zohoarc; b=n+d2a8atsZH2xga3GRPDRp7V0KlQB8p1fSFyeW8vwxyt5gmH2zgKDPP2io89Q6O41p6Y0r3Ps6y5U4vZhQLz6sL5G1TbYWbgdBIVk5bO8/3S2HXE/mFdPknrH/q19KVS5fX+nbp5lWozgQiVsJwfD7uWNK0C1SpcjMi9mA56+t8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768223768; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=KjMKzPxFT+2U5k7E3jIkUOtPx8Xv7ycoeQSEjk6D25k=; b=fuQ8DaOgf2Jf46O1fu1hin3G+Z3iCbv9LPIMdfjaeOSoFD+C/CqhRmFhNWNzD3/AH9zlnGZnBHDA2Y7bmWIcp3qym5mLpiJ8d4TXg61HArd4YSvKscDTc8GQPTmFaMa1tbK1umwvhRpsPat4jB/67bCsmuLUWc2AF5NxoOOSYPo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768223768627568.8091847422742; Mon, 12 Jan 2026 05:16:08 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vfHld-0001Xo-1n; Mon, 12 Jan 2026 08:15:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfHlJ-0001Dn-0T for qemu-devel@nongnu.org; Mon, 12 Jan 2026 08:15:13 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfHlG-0002VG-3A for qemu-devel@nongnu.org; Mon, 12 Jan 2026 08:15:11 -0500 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-184-LHkOQguxMHmwwNRbHagQPQ-1; Mon, 12 Jan 2026 08:15:04 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3DDFB19540D7; Mon, 12 Jan 2026 13:15:03 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.224.179]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2478830001A2; Mon, 12 Jan 2026 13:15:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768223707; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KjMKzPxFT+2U5k7E3jIkUOtPx8Xv7ycoeQSEjk6D25k=; b=R8ii/bZ3DwI4Tkm4JElBVMdl+jdd+g5gFNCXIOOlGFXdh6yoYDCZyBHggk7/kDAW61NYji 2d4WgRl/zejsm7C7EmIJD2lITxInJw5lXP1FDgyuXon9nd4rnKZi0/sT7F2cF/s7G4xFtr nz4A6UAYnJG20vCmQIkzMbloEEfzu6s= X-MC-Unique: LHkOQguxMHmwwNRbHagQPQ-1 X-Mimecast-MFC-AGG-ID: LHkOQguxMHmwwNRbHagQPQ_1768223703 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson Subject: [PULL 01/15] tests/functional: Add a pylintrc file Date: Mon, 12 Jan 2026 14:14:43 +0100 Message-ID: <20260112131457.67128-2-thuth@redhat.com> In-Reply-To: <20260112131457.67128-1-thuth@redhat.com> References: <20260112131457.67128-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1768223771153158500 Content-Type: text/plain; charset="utf-8" From: Thomas Huth Add a pylintrc file that can be used for checking the python code of the functional tests. For the beginning, we use some rather lax settings. We still can refine them later if we think that there's a need for it. Message-Id: <20251119082636.43286-2-thuth@redhat.com> Signed-off-by: Thomas Huth --- MAINTAINERS | 1 + tests/functional/pylintrc | 84 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 85 insertions(+) create mode 100644 tests/functional/pylintrc diff --git a/MAINTAINERS b/MAINTAINERS index 3a46c7fd0b0..a6168cb46f7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4461,6 +4461,7 @@ F: docs/devel/testing/functional.rst F: scripts/clean_functional_cache.py F: tests/functional/meson.build F: tests/functional/generic/meson.build +F: tests/functional/pylintrc F: tests/functional/qemu_test/ =20 Windows Hosted Continuous Integration diff --git a/tests/functional/pylintrc b/tests/functional/pylintrc new file mode 100644 index 00000000000..049c3e76f12 --- /dev/null +++ b/tests/functional/pylintrc @@ -0,0 +1,84 @@ +# Config file for checking the functional tests with pylint +# +# SPDX-License-Identifier: GPL-2.0-or-later + +[DESIGN] + +# Maximum number of arguments for function / method. +max-args=3D9 + +# Maximum number of attributes for a class (see R0902). +max-attributes=3D7 + +# Maximum number of boolean expressions in an if statement (see R0916). +max-bool-expr=3D5 + +# Maximum number of branch for function / method body. +max-branches=3D12 + +# Maximum number of locals for function / method body. +max-locals=3D15 + +# Maximum number of parents for a class (see R0901). +max-parents=3D7 + +# Maximum number of positional arguments for function / method. +max-positional-arguments=3D7 + +# Maximum number of public methods for a class (see R0904). +max-public-methods=3D20 + +# Maximum number of return / yield for function / method body. +max-returns=3D6 + +# Maximum number of statements in function / method body. +max-statements=3D50 + +# Minimum number of public methods for a class (see R0903). +min-public-methods=3D2 + + +[MESSAGES CONTROL] + +# Only show warnings with the listed confidence levels. Leave empty to show +# all. Valid levels: HIGH, CONTROL_FLOW, INFERENCE, INFERENCE_FAILURE, +# UNDEFINED. +confidence=3DHIGH, + CONTROL_FLOW, + INFERENCE, + INFERENCE_FAILURE + +# Disable the message, report, category or checker with the given id(s). Y= ou +# can either give multiple identifiers separated by comma (,) or put this +# option multiple times (only on the command line, not in the configuration +# file where it should appear only once). You can also use "--disable=3Dal= l" to +# disable everything first and then re-enable specific checks. For example= , if +# you want to run only the similarities checker, you can use "--disable=3D= all +# --enable=3Dsimilarities". If you want to run only the classes checker, b= ut have +# no Warning level messages displayed, use "--disable=3Dall --enable=3Dcla= sses +# --disable=3DW". +disable=3Dbad-inline-option, + consider-using-f-string, + file-ignored, + fixme, + import-outside-toplevel, + locally-disabled, + logging-fstring-interpolation, + logging-not-lazy, + missing-function-docstring, + missing-module-docstring, + missing-class-docstring, + raw-checker-failed, + suppressed-message, + too-many-locals, + too-many-statements, + use-implicit-booleaness-not-comparison-to-string, + use-implicit-booleaness-not-comparison-to-zero, + use-symbolic-message-instead, + useless-suppression, + + +[SIMILARITIES] + +# Minimum lines number of a similarity. +min-similarity-lines=3D20 --=20 2.52.0 From nobody Sun Feb 8 12:31:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1768223768; cv=none; d=zohomail.com; s=zohoarc; b=YmF9p9rnAfipiRchewBJwagvBpfNguIYAgxG/ynF7PrQ2VawSqTZr75zhQLA/EqDVrbTAUpE/8A2uAu9xr1RyqtuEDgLiA4noB6j3t+kUCUtXtO3pCGfK04ADoMBv5jhFPet9/ShPK2cyqeTQmsofLHn5DbEJiRvWenhy89hQ5g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768223768; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=bYNER3tv7jKHijECoLFlWzyNVq0wnfgD03vxD77kjgc=; b=FjaN1HSoeG2F8ew/J+TwXE6GeiWA0Yq8ytWU6B6kTpG3FxqhreQ1/ujks/f+1BQVQv9qdhe77uVlY/MFihNmGxj6drErzj7uaamfheV2G48MUnDODeW7xMeeZgArQvxHRVS1sTCVnXGdTCCb98Vs9wTJGGWN/ZGmIv8x/L4RzBE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176822376893748.20925079354288; Mon, 12 Jan 2026 05:16:08 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vfHlU-0001WD-5c; Mon, 12 Jan 2026 08:15:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfHlK-0001F4-7a for qemu-devel@nongnu.org; Mon, 12 Jan 2026 08:15:14 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfHlI-0002Ve-ON for qemu-devel@nongnu.org; Mon, 12 Jan 2026 08:15:13 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-436-DFzMbf4OMZW97BJ_TKY95Q-1; Mon, 12 Jan 2026 08:15:06 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 96C52180061A; Mon, 12 Jan 2026 13:15:05 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.224.179]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B566930001A2; Mon, 12 Jan 2026 13:15:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768223711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bYNER3tv7jKHijECoLFlWzyNVq0wnfgD03vxD77kjgc=; b=GKuBNYKHqjeyAAnHyMJ3J2VwFWdYi4BYL/91ELZgQBX46fTeTxdEiqrx21PwpDyMjAJbsG 4q9YCsKjZ53QPEjnjz2rdN/h/9Cnc3hfvxFlPa7PvBgT032/DGJ2/QIQFPIvOeaN6vm1DZ nGbwxGrVBBWKafz8v9rGHEV6qze+PcU= X-MC-Unique: DFzMbf4OMZW97BJ_TKY95Q-1 X-Mimecast-MFC-AGG-ID: DFzMbf4OMZW97BJ_TKY95Q_1768223705 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson Subject: [PULL 02/15] tests/functional/mips/test_malta: Silence warnings reported by pylint Date: Mon, 12 Jan 2026 14:14:44 +0100 Message-ID: <20260112131457.67128-3-thuth@redhat.com> In-Reply-To: <20260112131457.67128-1-thuth@redhat.com> References: <20260112131457.67128-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1768223771128158500 Content-Type: text/plain; charset="utf-8" From: Thomas Huth Pylint complains about too many positional arguments for the mips_check_wheezy() function. Add a "*" to enforce that the later ones are passed with an argument name (all calling sites are doing this already). Also turn some old-school format strings into proper f-strings now. Message-Id: <20251119082636.43286-6-thuth@redhat.com> Signed-off-by: Thomas Huth --- tests/functional/mips/test_malta.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/functional/mips/test_malta.py b/tests/functional/mips/te= st_malta.py index 7a734bc069b..e8f49f130be 100755 --- a/tests/functional/mips/test_malta.py +++ b/tests/functional/mips/test_malta.py @@ -50,7 +50,7 @@ def mips_run_common_commands(test, prompt=3D'#'): ' : ata_piix') wait_for_console_pattern(test, prompt) =20 -def mips_check_wheezy(test, kernel_path, image_path, kernel_command_line, +def mips_check_wheezy(test, kernel_path, image_path, kernel_command_line, = *, dl_file, hsum, nic=3D'pcnet', cpuinfo=3D'MIPS 24Kc'): test.require_netdev('user') test.require_device(nic) @@ -59,10 +59,10 @@ def mips_check_wheezy(test, kernel_path, image_path, ke= rnel_command_line, port=3D8080 test.vm.add_args('-kernel', kernel_path, '-append', kernel_command_line, - '-drive', 'file=3D%s,snapshot=3Don' % image_path, + '-drive', f'file=3D{image_path},snapshot=3Don', '-netdev', 'user,id=3Dn1' + ',tftp=3D' + os.path.basename(kernel_path)= + - ',hostfwd=3Dtcp:127.0.0.1:0-:%d' % port, + f',hostfwd=3Dtcp:127.0.0.1:0-:{port}', '-device', f'{nic},netdev=3Dn1', '-no-reboot') test.vm.set_console() @@ -111,7 +111,7 @@ def test_mips_malta(self): self.vm.add_args('-kernel', kernel_path, '-append', kernel_command_line) self.vm.launch() - console_pattern =3D 'Kernel command line: %s' % kernel_command_line + console_pattern =3D f'Kernel command line: {kernel_command_line}' self.wait_for_console_pattern(console_pattern) =20 ASSET_KERNEL_4_5_0 =3D Asset( --=20 2.52.0 From nobody Sun Feb 8 12:31:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1768223797; cv=none; d=zohomail.com; s=zohoarc; b=IWC3McMbM9okqdPIpD2L1leudSvprvRLIsC9DDPJTuNpTTqwzFf/Un/DsE4IXW2VfgTdMeI8XwSpQXnUm4sGrCQrx07uiPvrVC4AURwL23lZ3Ofpkeo1Y7R1H0BTmhF1IZMniBl/LjUHuCJuGleLrAoLuVU3Hbflpa2qohCP/Ro= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768223797; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=oKfegducDODgkba1XJ/HW/MbccnFLGGMVBYQq+f+uTM=; b=B8vDH5PDV7JtR7/cKtxLd8rqs3dXNYl2MoZirt2dfbLWmn06vivr5i77bMbhX0OxEMTWGfv/c8UmGcF1pil7SKiKRhZ93WahzlE5DgjscHODF1kQ0vX+Cr/tOZEjIEFApp5XtbrWLfsJYRD+D0puyGSJP4PGk5yGdbFWwyM4Ing= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768223797191912.4126170379405; Mon, 12 Jan 2026 05:16:37 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vfHmQ-0001ce-72; Mon, 12 Jan 2026 08:16:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfHlK-0001FI-AJ for qemu-devel@nongnu.org; Mon, 12 Jan 2026 08:15:14 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfHlI-0002Vb-4A for qemu-devel@nongnu.org; Mon, 12 Jan 2026 08:15:14 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-610-XIp_bFlnOd-fK-tadKqcIw-1; Mon, 12 Jan 2026 08:15:09 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5EE0F1800451; Mon, 12 Jan 2026 13:15:08 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.224.179]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id BE40330001A2; Mon, 12 Jan 2026 13:15:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768223710; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oKfegducDODgkba1XJ/HW/MbccnFLGGMVBYQq+f+uTM=; b=jEDsdZXWidoqgIy7rg4AI8mWOCeAi7hRtrbF7vmAFkKHzpK5ZTgqf9FpbRFgIU43z/6RKj iJI+ZThFdVm5dubKXeOB/deLyMwdXjOg6Q1DZHnUqvrIJx8hsNcbh73imehU7/FoK/vr3q Eq3O+m5oe2L6KXwRDvQ+wVFC+lcAXuI= X-MC-Unique: XIp_bFlnOd-fK-tadKqcIw-1 X-Mimecast-MFC-AGG-ID: XIp_bFlnOd-fK-tadKqcIw_1768223708 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson Subject: [PULL 03/15] tests/functional/ppc64/test_hv: Silence warnings reported by pylint Date: Mon, 12 Jan 2026 14:14:45 +0100 Message-ID: <20260112131457.67128-4-thuth@redhat.com> In-Reply-To: <20260112131457.67128-1-thuth@redhat.com> References: <20260112131457.67128-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1768223799018158500 Content-Type: text/plain; charset="utf-8" From: Thomas Huth To make pylint happy here, remove unused variables, switch to f-string, use "check=3DTrue" when calling subprocess.run() and split a line that was too long. Message-Id: <20251119082636.43286-7-thuth@redhat.com> Signed-off-by: Thomas Huth --- tests/functional/ppc64/test_hv.py | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/tests/functional/ppc64/test_hv.py b/tests/functional/ppc64/tes= t_hv.py index d87f440fa79..beec1dbbea3 100755 --- a/tests/functional/ppc64/test_hv.py +++ b/tests/functional/ppc64/test_hv.py @@ -29,8 +29,6 @@ @skipBigDataTest() class HypervisorTest(QemuSystemTest): =20 - timeout =3D 1000 - KERNEL_COMMON_COMMAND_LINE =3D 'printk.time=3D0 console=3Dhvc0 ' panic_message =3D 'Kernel panic - not syncing' good_message =3D 'VFS: Cannot open root device' =20 @@ -49,8 +47,8 @@ def extract_from_iso(self, iso, path): """ filename =3D self.scratch_file(os.path.basename(path)) =20 - cmd =3D "xorriso -osirrox on -indev %s -cpx %s %s" % (iso, path, f= ilename) - subprocess.run(cmd.split(), + cmd =3D f"xorriso -osirrox on -indev {iso} -cpx {path} {filename}" + subprocess.run(cmd.split(), check=3DTrue, stdout=3Dsubprocess.DEVNULL, stderr=3Dsubprocess.DE= VNULL) =20 os.chmod(filename, 0o600) @@ -66,7 +64,6 @@ def setUp(self): =20 def do_start_alpine(self): self.vm.set_console() - kernel_command_line =3D self.KERNEL_COMMON_COMMAND_LINE self.vm.add_args("-kernel", self.vmlinuz) self.vm.add_args("-initrd", self.initramfs) self.vm.add_args("-smp", "4", "-m", "2g") @@ -78,7 +75,8 @@ def do_start_alpine(self): wait_for_console_pattern(self, 'localhost login:') exec_command_and_wait_for_pattern(self, 'root', ps1) # If the time is wrong, SSL certificates can fail. - exec_command_and_wait_for_pattern(self, 'date -s "' + datetime.utc= now().strftime('%Y-%m-%d %H:%M:%S' + '"'), ps1) + cmd=3D'date -s "' + datetime.utcnow().strftime('%Y-%m-%d %H:%M:%S'= + '"') + exec_command_and_wait_for_pattern(self, cmd, ps1) ps1=3D'alpine:~#' exec_command_and_wait_for_pattern(self, 'setup-alpine -qe', ps1) exec_command_and_wait_for_pattern(self, 'setup-apkrepos -c1', ps1) --=20 2.52.0 From nobody Sun Feb 8 12:31:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1768223864; cv=none; d=zohomail.com; s=zohoarc; b=X98eIKfqNCr95XJLJZsSct7ZYZOYyiucAfRtlrdGXWnXHU52NeeOxAZhmxgbGvJzNVAdQwjXHnFeNrAAbN9buc2WdTYiLSIcSh8efebZG4GEoNWN5rW8+JL08wTa2pSkcboFp5TJwa2jQ4mEvpOrm4E3z5vsipsgYKQU2CHnQ/M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768223864; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=fPtgGIP/wuubytcrixEAHq8wAU0Nauyq+QdHtcvOLUw=; b=RSkC9WR/EsMDAi0faeW+7/hvh6M3YzM97N2h35J5SXUowh4Ai2LolcHuts7cUji1OV/6euj1SHW+qMPXm7May0vY816yEwBPqwuefBVX6+MIuc6Pffedj96ptvyFTvPBWqdddRvSS1H9r8hfEA8Isb4xa2DUAMbbXljcEz/J+l4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768223864633787.8202796419107; Mon, 12 Jan 2026 05:17:44 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vfHme-0001y9-52; Mon, 12 Jan 2026 08:16:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfHlN-0001Mv-FH for qemu-devel@nongnu.org; Mon, 12 Jan 2026 08:15:17 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfHlL-0002WN-OQ for qemu-devel@nongnu.org; Mon, 12 Jan 2026 08:15:17 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-593-QRg5Y23bMbuBhQ5zsKlErw-1; Mon, 12 Jan 2026 08:15:11 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6BEA9195605B; Mon, 12 Jan 2026 13:15:10 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.224.179]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3931E30001A2; Mon, 12 Jan 2026 13:15:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768223714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fPtgGIP/wuubytcrixEAHq8wAU0Nauyq+QdHtcvOLUw=; b=eKsM7aaDrOQzrX0uS/Rk1+HxN3Whwq9QmeMfabDXOkIWuMo7EoEzGdaJZsuP+gXBLRetJu F4GX5RuIaOz821Tklg4Gn3IufwhPW6O0HlKgSxOenPsaU3G5E2WY1+XIfoYVkaxOqN4zUp 8hhjvrrx7Kuv+Uz41lpYewB6eqxIu7Y= X-MC-Unique: QRg5Y23bMbuBhQ5zsKlErw-1 X-Mimecast-MFC-AGG-ID: QRg5Y23bMbuBhQ5zsKlErw_1768223710 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson Subject: [PULL 04/15] tests/functional/aarch64/test_virt_gpu: Fix style issues Date: Mon, 12 Jan 2026 14:14:46 +0100 Message-ID: <20260112131457.67128-5-thuth@redhat.com> In-Reply-To: <20260112131457.67128-1-thuth@redhat.com> References: <20260112131457.67128-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1768223867240158500 Content-Type: text/plain; charset="utf-8" From: Thomas Huth Reshuffle the import statements according to the suggestions from pylint, use lowercase letters for variable names, and drop some spaces that flake8 did not like. Message-Id: <20251119082636.43286-12-thuth@redhat.com> Signed-off-by: Thomas Huth --- tests/functional/aarch64/test_virt_gpu.py | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/tests/functional/aarch64/test_virt_gpu.py b/tests/functional/a= arch64/test_virt_gpu.py index c26a1f20c65..6ed0e0fc1a9 100755 --- a/tests/functional/aarch64/test_virt_gpu.py +++ b/tests/functional/aarch64/test_virt_gpu.py @@ -9,16 +9,16 @@ # # SPDX-License-Identifier: GPL-2.0-or-later =20 -from qemu.machine.machine import VMLaunchFailure +from re import search +from subprocess import check_output, CalledProcessError =20 -from qemu_test import Asset +from qemu_test import Asset, skipIfMissingCommands from qemu_test import exec_command_and_wait_for_pattern as ec_and_wait -from qemu_test import skipIfMissingCommands =20 from qemu_test.linuxkernel import LinuxKernelTest =20 -from re import search -from subprocess import check_output, CalledProcessError +from qemu.machine.machine import VMLaunchFailure + =20 class Aarch64VirtGPUMachine(LinuxKernelTest): =20 @@ -81,16 +81,16 @@ def _launch_virt_gpu(self, gpu_device): self.wait_for_console_pattern('buildroot login:') ec_and_wait(self, 'root', '#') =20 - def _run_virt_weston_test(self, cmd, fail =3D None): + def _run_virt_weston_test(self, cmd, fail=3DNone): =20 # make it easier to detect successful return to shell - PS1 =3D 'RES=3D[$?] # ' - OK_CMD =3D 'RES=3D[0] # ' + ps1 =3D 'RES=3D[$?] # ' + ok_cmd =3D 'RES=3D[0] # ' =20 ec_and_wait(self, 'export XDG_RUNTIME_DIR=3D/tmp', '#') - ec_and_wait(self, f"export PS1=3D'{PS1}'", OK_CMD) + ec_and_wait(self, f"export PS1=3D'{ps1}'", ok_cmd) full_cmd =3D f"weston -B headless --renderer gl --shell kiosk -- {= cmd}" - ec_and_wait(self, full_cmd, OK_CMD, fail) + ec_and_wait(self, full_cmd, ok_cmd, fail) =20 @skipIfMissingCommands('zstd') def test_aarch64_virt_with_virgl_gpu(self): --=20 2.52.0 From nobody Sun Feb 8 12:31:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1768223881; cv=none; d=zohomail.com; s=zohoarc; b=MsCYee6bjqk3DvYpPpQu1THiXla7bhzC/qalw0DdzE+UgRVZlDoI8MNhcySEju70WGugDE4L8K1y8RmYgVrK2MuHXwFfIHQDv1DmZnn7kJlgvuM4a2i7w56YEu9x8UZs63gcwIMxZo+6DHhz+nEmu+GyoFZ2E8CUIrrAQlJCPDw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768223881; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=aTS78RJMEmewPIelL+r4vbpycGrTGPekMU0TWw1puFk=; b=FCHMUAGCHycDr7svvw5jLoo2m/Hx8oQS1lpxExP7bEWvcfboYZnlKj4q06GQin2OtPpg1vRyerdK0sQmTkAmT0GfS8/rnlJVNU48/JTVZgGEoF1fTbzv2iTo0onjS5nZKO7wGmzd61fY5wM0CST9EiVudXhe1MPJGXX1auvbOec= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768223881097321.0595703958096; Mon, 12 Jan 2026 05:18:01 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vfHn8-0002FP-H3; Mon, 12 Jan 2026 08:17:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfHlO-0001Ps-RQ for qemu-devel@nongnu.org; Mon, 12 Jan 2026 08:15:19 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfHlN-0002WU-El for qemu-devel@nongnu.org; Mon, 12 Jan 2026 08:15:18 -0500 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-694-prVWs8XZNdeVTUpQxI9x9g-1; Mon, 12 Jan 2026 08:15:13 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7A4A61800342; Mon, 12 Jan 2026 13:15:12 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.224.179]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 58E1830001A7; Mon, 12 Jan 2026 13:15:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768223716; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aTS78RJMEmewPIelL+r4vbpycGrTGPekMU0TWw1puFk=; b=gQZH616Xt2ayZBDA8YJJSf+t4eVh94jYvrV+eH+SsymPfE6s1gzyasa4OBdWwYRGq+sp2i TrmLJPac4uzPxygPq2OZnTOQPzbsv2Uk4SV8Xcla0hKoNxfwwlo1HYDw7czC1O4YL+OxlP Vq5TalNHfnjeQ8KS4FTDnCOjG2HbSuU= X-MC-Unique: prVWs8XZNdeVTUpQxI9x9g-1 X-Mimecast-MFC-AGG-ID: prVWs8XZNdeVTUpQxI9x9g_1768223712 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson Subject: [PULL 05/15] tests/functional/aarch64/test_smmu: Silence warning from pylint Date: Mon, 12 Jan 2026 14:14:47 +0100 Message-ID: <20260112131457.67128-6-thuth@redhat.com> In-Reply-To: <20260112131457.67128-1-thuth@redhat.com> References: <20260112131457.67128-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1768223887403158501 Content-Type: text/plain; charset="utf-8" From: Thomas Huth Pylint thinks that the accel variable might be used here without being set first, since it does not know that skipTest() never returns. Thus initialize "accel =3D None" here to make it happy. Message-Id: <20251119082636.43286-14-thuth@redhat.com> Signed-off-by: Thomas Huth --- tests/functional/aarch64/test_smmu.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/functional/aarch64/test_smmu.py b/tests/functional/aarch= 64/test_smmu.py index e0f4a922176..87b9b14e7a5 100755 --- a/tests/functional/aarch64/test_smmu.py +++ b/tests/functional/aarch64/test_smmu.py @@ -50,6 +50,7 @@ def common_vm_setup(self, kernel, initrd, disk): elif kvm_available(self.qemu_bin): accel =3D "kvm" else: + accel =3D None # for keeping pylint happy self.skipTest("Neither HVF nor KVM accelerator is available") self.require_accelerator(accel) self.require_netdev('user') --=20 2.52.0 From nobody Sun Feb 8 12:31:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1768223898; cv=none; d=zohomail.com; s=zohoarc; b=A/gpgRkKhzmMaeuTNKOPpfspvrc8WPicDiaI7SXBJGvlQPUNnSo/xChUW54BzUoliPUcXhzixH/qLVfvA8iwQw29vo90Z/VNYAHV3KE3Z+6VRETqpKeUXHIe2HgYYx7jRk8c0CCyZzeeFqZBDrfvVH3W/1JwQyQnnHNCMcQZ9uk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768223898; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=10XZMlig4LGw9p0kOKwBqLurpUaIpsrfkUplGVNrEW0=; b=FPTTElpoOVgXnkitYye7h/C9Mo82TZA09RHW4T5kbdnnLROhdt8obTmF1F5smsg6ah66H2s7K0ehR5eJOFKNvEpO9OQIw3m6sPzgh25q8JxrchGnx4mGNwL4wU0Su3F7SMMCUnYKFpdtoSQGrP+NgH6h1eLXhRwnxqPwZSsv/8o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768223898538711.1932331629085; Mon, 12 Jan 2026 05:18:18 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vfHo5-0002pO-89; Mon, 12 Jan 2026 08:18:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfHlP-0001S9-JZ for qemu-devel@nongnu.org; Mon, 12 Jan 2026 08:15:20 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfHlO-0002Wb-0r for qemu-devel@nongnu.org; Mon, 12 Jan 2026 08:15:19 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-359-BkLs4P87PjGmXX1qo96UHA-1; Mon, 12 Jan 2026 08:15:15 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8060C1956050; Mon, 12 Jan 2026 13:15:14 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.224.179]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id ED38430001A7; Mon, 12 Jan 2026 13:15:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768223717; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=10XZMlig4LGw9p0kOKwBqLurpUaIpsrfkUplGVNrEW0=; b=SQQBqjiZ/89/nQ8C2L8oRfjeQ+n3hf1Epe23Kt3chVSIOUtOgxXL0s3frn1X728KHyeDfI NOW0jy3qKxBsESiCG8fw5dWuZZ2a/uYJoBVIr+8cONFPCPOkyjUz2vy3q+i+Lpp96+P0pO nxfDy1X/IWwwZo94YX0Ok7XUDSbsFVs= X-MC-Unique: BkLs4P87PjGmXX1qo96UHA-1 X-Mimecast-MFC-AGG-ID: BkLs4P87PjGmXX1qo96UHA_1768223714 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson Subject: [PULL 06/15] tests/functional: Add a generic test that checks the files with pylint Date: Mon, 12 Jan 2026 14:14:48 +0100 Message-ID: <20260112131457.67128-7-thuth@redhat.com> In-Reply-To: <20260112131457.67128-1-thuth@redhat.com> References: <20260112131457.67128-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1768223899524158500 Content-Type: text/plain; charset="utf-8" From: Thomas Huth To avoid that new pylint-related warnings get committed, let's check the files with pylint during each run (similar to what we are doing for the iotests already). Message-Id: <20251119082636.43286-16-thuth@redhat.com> Signed-off-by: Thomas Huth --- MAINTAINERS | 1 + tests/functional/generic/meson.build | 1 + tests/functional/generic/test_linters.py | 41 ++++++++++++++++++++++++ 3 files changed, 43 insertions(+) create mode 100755 tests/functional/generic/test_linters.py diff --git a/MAINTAINERS b/MAINTAINERS index a6168cb46f7..6dfd9b27c20 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4461,6 +4461,7 @@ F: docs/devel/testing/functional.rst F: scripts/clean_functional_cache.py F: tests/functional/meson.build F: tests/functional/generic/meson.build +F: tests/functional/generic/test_linters.py F: tests/functional/pylintrc F: tests/functional/qemu_test/ =20 diff --git a/tests/functional/generic/meson.build b/tests/functional/generi= c/meson.build index 013cc96fbf8..09763c5d229 100644 --- a/tests/functional/generic/meson.build +++ b/tests/functional/generic/meson.build @@ -3,6 +3,7 @@ tests_generic_system =3D [ 'empty_cpu_model', 'info_usernet', + 'linters', 'version', 'vnc', ] diff --git a/tests/functional/generic/test_linters.py b/tests/functional/ge= neric/test_linters.py new file mode 100755 index 00000000000..b5b90fcf7a3 --- /dev/null +++ b/tests/functional/generic/test_linters.py @@ -0,0 +1,41 @@ +#!/usr/bin/env python3 +# +# SPDX-License-Identifier: GPL-2.0-or-later +# +'''Python linter tests''' + +import os + +from pathlib import Path +from qemu_test import QemuBaseTest, skipIfMissingImports + + +class LinterTest(QemuBaseTest): + ''' + Run python linters on the test *.py files + ''' + + @skipIfMissingImports("pylint") + def test_pylint(self): + '''Check source files with pylint''' + from pylint.lint import Run as pylint_run + from pylint.reporters.collecting_reporter import CollectingReporter + srcdir =3D os.path.join(Path(__file__).parent.parent, self.arch) + rcfile =3D os.path.join(Path(__file__).parent.parent, "pylintrc") + self.log.info('Checking files in %s with pylint', srcdir) + reporter =3D CollectingReporter() + pylint_run(["--rcfile", rcfile, srcdir], reporter=3Dreporter, exit= =3DFalse) + if reporter.messages: + fmt =3D '"{path}:{line}: {msg_id}: {msg} ({symbol})"' + for msg in reporter.messages: + if msg.category =3D=3D "error": + self.log.error(msg.format(fmt)) + elif msg.category =3D=3D "warning": + self.log.warning(msg.format(fmt)) + else: + self.log.info(msg.format(fmt)) + self.fail("Pylint failed, see base.log for details.") + + +if __name__ =3D=3D '__main__': + QemuBaseTest.main() --=20 2.52.0 From nobody Sun Feb 8 12:31:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1768223848; cv=none; d=zohomail.com; s=zohoarc; b=i49Hm5bBqnPY1gV3dEXExsp9vaxzkxtwaEkMK/hRQNaHqi2syS9gjco9tpncVGCVwGZAf/ZhQZH7hVsZ1x362B1rtQmI6oNN6bilfFPQNNI5+q0Zxhl7GhzViH8e2GuUiCywe00nFMzfrCeA/iWykxRkTjbyqRmZrJeGalrqpkg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768223848; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ZvsWtIfrf4yznnr06FlcP4VHxBPYYTEfls48cI2EW78=; b=F0Yf/Nj6beFPzm4CBIjpAZsbTu9UUJ0Ul9WZQ+1LMF5KYrIwvsREstTuwdKUXtASKUFYN3CDB4Bw0pps8jEaS7Ef9yykp/M1nHMQYa4S0MDiAvcSCSq5VbKqndadyXyfpQ5LTAoTOnAXw/jMa3W4Jpz00wpOoOM9dOv5UWvm/PM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768223848480402.3120118617551; Mon, 12 Jan 2026 05:17:28 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vfHmZ-0001vA-SG; Mon, 12 Jan 2026 08:16:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfHlZ-0001Xw-03 for qemu-devel@nongnu.org; Mon, 12 Jan 2026 08:15:30 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfHlX-0002bG-Ig for qemu-devel@nongnu.org; Mon, 12 Jan 2026 08:15:28 -0500 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-266-mHiBBlH8NfKoFq0b6go1Dw-1; Mon, 12 Jan 2026 08:15:18 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9531F18002C8; Mon, 12 Jan 2026 13:15:17 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.224.179]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 00AE83000218; Mon, 12 Jan 2026 13:15:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768223727; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZvsWtIfrf4yznnr06FlcP4VHxBPYYTEfls48cI2EW78=; b=eR3FO5zE7h1xr6Z+S4gjcuXJZsZSBnEFHN/DZO5rCQ/oZu7lW9aqHX292Bc0Fjk6py7HRT W1w7X55g4qugsbjkS3iw6qqmLL1rq6vEvMmcS6g1hkQ5h4ZX/+iEic1E+jyxPNB5DCVDhc n0yeYnF/CgtA6O9rOf1OSZfbCbcsVCE= X-MC-Unique: mHiBBlH8NfKoFq0b6go1Dw-1 X-Mimecast-MFC-AGG-ID: mHiBBlH8NfKoFq0b6go1Dw_1768223717 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson , peter.maydell@linaro.org, qemu-trivial@nongnu.org, Ani Sinha , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [PULL 07/15] docs: update copyright year to 2026 Date: Mon, 12 Jan 2026 14:14:49 +0100 Message-ID: <20260112131457.67128-8-thuth@redhat.com> In-Reply-To: <20260112131457.67128-1-thuth@redhat.com> References: <20260112131457.67128-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1768223849241158500 From: Ani Sinha We are already in 2026. Update docs to update copyright info to year 2026. Cc: peter.maydell@linaro.org Cc: qemu-trivial@nongnu.org Signed-off-by: Ani Sinha Reviewed-by: Alex Benn=C3=A9e Message-ID: <20260107045250.34420-1-anisinha@redhat.com> Signed-off-by: Thomas Huth --- docs/conf.py | 2 +- include/qemu/help-texts.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/conf.py b/docs/conf.py index bc4e9622dc8..f835904ba1e 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -92,7 +92,7 @@ =20 # General information about the project. project =3D u'QEMU' -copyright =3D u'2025, The QEMU Project Developers' +copyright =3D u'2026, The QEMU Project Developers' author =3D u'The QEMU Project Developers' =20 # The version info for the project you're documenting, acts as replacement= for diff --git a/include/qemu/help-texts.h b/include/qemu/help-texts.h index bc8fab91697..a9ccec7b38c 100644 --- a/include/qemu/help-texts.h +++ b/include/qemu/help-texts.h @@ -2,7 +2,7 @@ #define QEMU_HELP_TEXTS_H =20 /* Copyright string for -version arguments, About dialogs, etc */ -#define QEMU_COPYRIGHT "Copyright (c) 2003-2025 " \ +#define QEMU_COPYRIGHT "Copyright (c) 2003-2026 " \ "Fabrice Bellard and the QEMU Project developers" =20 /* Bug reporting information for --help arguments, About dialogs, etc */ --=20 2.52.0 From nobody Sun Feb 8 12:31:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1768223890; cv=none; d=zohomail.com; s=zohoarc; b=gsQ3HQaiZXs4MM0xDvkVUKcf07JlzdsFWlshFJf79G4YGHYREQ4TEnBtfBkhyKZBmfPN0xe1udGuL0WvIif6jt3uceomJIXHwLU+tX66J/qNM7ESHumq5WYwyRRAD1uWoCxcm5e6a0v6/x5wL2NzhPga+gIEb+S4waOfqRJ6bzc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768223890; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=t+Moj1HKTWbYuxZ++iDn1wHHhWRGuDIZAFTVME3YgBU=; b=OXpB2YOP+e/JvswEhbvNXkGM2gpixFh0oi8fwOvwX2dIKJ+XExS1i5nd7musSHnnVeIdWp40MOJs9xnxTjM9dskNLvz+2OZKrh+k4eFfaHmAmtGQoFWMPeowAQp83NCe/azm3CxoM3DrZ6rLCCaOZ4x0TfLEqdKqQc7v/pYk+Hc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768223890881494.05441703461054; Mon, 12 Jan 2026 05:18:10 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vfHmn-00022W-PE; Mon, 12 Jan 2026 08:16:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfHlW-0001Xp-H5 for qemu-devel@nongnu.org; Mon, 12 Jan 2026 08:15:30 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfHlU-0002YF-Eb for qemu-devel@nongnu.org; Mon, 12 Jan 2026 08:15:26 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-26-eop_FrtpN4WKxE2_R66PsA-1; Mon, 12 Jan 2026 08:15:22 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 68FD818005B2; Mon, 12 Jan 2026 13:15:20 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.224.179]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 73CF130001A7; Mon, 12 Jan 2026 13:15:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768223723; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t+Moj1HKTWbYuxZ++iDn1wHHhWRGuDIZAFTVME3YgBU=; b=QwUCLlKU4Gck0kEnT+A6YOOxJ+IYDDhWaJjsfjEXHBnW4ww+9tfPpd5Jth/5qmuubvLwzI xw6Q/RBCauWNoywbveXMY1wi7u7D9QgGL8CapxGkyLZ/7cG6FKcQXaL6rdZnYGvwvWaazd E3zVaZQuL7AHfBOo+WLam+3MJMGEHoI= X-MC-Unique: eop_FrtpN4WKxE2_R66PsA-1 X-Mimecast-MFC-AGG-ID: eop_FrtpN4WKxE2_R66PsA_1768223720 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 08/15] target/s390x: Restrict WatchPoint API to TCG Date: Mon, 12 Jan 2026 14:14:50 +0100 Message-ID: <20260112131457.67128-9-thuth@redhat.com> In-Reply-To: <20260112131457.67128-1-thuth@redhat.com> References: <20260112131457.67128-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1768223893553158500 From: Philippe Mathieu-Daud=C3=A9 By inverting the 'tcg_enabled()' check in s390_cpu_set_psw() we can let the compiler elide the s390_cpu_recompute_watchpoints() call when TCG is not available. Move this function -- along with s390x_cpu_debug_excp_handler() which was introduced in the same commit 311918b979c ("target-s390x: PER storage-alteration event support") -- to a TCG specific file to avoid compiling dead code on KVM. This restricts the WatchPoint API calls to TCG. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth Message-ID: <20260107130807.69870-2-philmd@linaro.org> Signed-off-by: Thomas Huth --- target/s390x/s390x-internal.h | 2 - target/s390x/tcg/tcg_s390x.h | 5 ++ target/s390x/cpu.c | 30 ++++++------ target/s390x/helper.c | 38 --------------- target/s390x/tcg/debug.c | 85 ++++++++++++++++++++++++++++++++++ target/s390x/tcg/excp_helper.c | 32 ------------- target/s390x/tcg/meson.build | 3 ++ 7 files changed, 108 insertions(+), 87 deletions(-) create mode 100644 target/s390x/tcg/debug.c diff --git a/target/s390x/s390x-internal.h b/target/s390x/s390x-internal.h index 9691366ec91..a4b54dc441c 100644 --- a/target/s390x/s390x-internal.h +++ b/target/s390x/s390x-internal.h @@ -259,7 +259,6 @@ ObjectClass *s390_cpu_class_by_name(const char *name); =20 =20 /* excp_helper.c */ -void s390x_cpu_debug_excp_handler(CPUState *cs); void s390_cpu_do_interrupt(CPUState *cpu); bool s390_cpu_exec_interrupt(CPUState *cpu, int int_req); =20 @@ -317,7 +316,6 @@ void s390_cpu_gdb_init(CPUState *cs); void s390_cpu_dump_state(CPUState *cpu, FILE *f, int flags); void do_restart_interrupt(CPUS390XState *env); #ifndef CONFIG_USER_ONLY -void s390_cpu_recompute_watchpoints(CPUState *cs); void s390x_tod_timer(void *opaque); void s390x_cpu_timer(void *opaque); void s390_handle_wait(S390CPU *cpu); diff --git a/target/s390x/tcg/tcg_s390x.h b/target/s390x/tcg/tcg_s390x.h index 78558912f99..7c8aede80d2 100644 --- a/target/s390x/tcg/tcg_s390x.h +++ b/target/s390x/tcg/tcg_s390x.h @@ -21,4 +21,9 @@ G_NORETURN void tcg_s390_data_exception(CPUS390XState *en= v, uint32_t dxc, G_NORETURN void tcg_s390_vector_exception(CPUS390XState *env, uint32_t vxc, uintptr_t ra); =20 +#ifndef CONFIG_USER_ONLY +void s390_cpu_recompute_watchpoints(CPUState *cs); +void s390x_cpu_debug_excp_handler(CPUState *cs); +#endif + #endif /* TCG_S390X_H */ diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c index 6af7446fd9f..cd472d38be7 100644 --- a/target/s390x/cpu.c +++ b/target/s390x/cpu.c @@ -40,6 +40,7 @@ #include "system/reset.h" #endif #include "hw/s390x/cpu-topology.h" +#include "tcg/tcg_s390x.h" =20 #define CR0_RESET 0xE0UL #define CR14_RESET 0xC2000000UL; @@ -74,26 +75,25 @@ void s390_cpu_set_psw(CPUS390XState *env, uint64_t mask= , uint64_t addr) env->psw.mask =3D mask; =20 /* KVM will handle all WAITs and trigger a WAIT exit on disabled_wait = */ - if (!tcg_enabled()) { - return; - } - env->cc_op =3D (mask >> 44) & 3; + if (tcg_enabled()) { + env->cc_op =3D (mask >> 44) & 3; =20 #ifndef CONFIG_USER_ONLY - if (is_early_exception_psw(mask, addr)) { - env->int_pgm_ilen =3D 0; - trigger_pgm_exception(env, PGM_SPECIFICATION); - return; - } + if (is_early_exception_psw(mask, addr)) { + env->int_pgm_ilen =3D 0; + trigger_pgm_exception(env, PGM_SPECIFICATION); + return; + } =20 - if ((old_mask ^ mask) & PSW_MASK_PER) { - s390_cpu_recompute_watchpoints(env_cpu(env)); - } + if ((old_mask ^ mask) & PSW_MASK_PER) { + s390_cpu_recompute_watchpoints(env_cpu(env)); + } =20 - if (mask & PSW_MASK_WAIT) { - s390_handle_wait(env_archcpu(env)); - } + if (mask & PSW_MASK_WAIT) { + s390_handle_wait(env_archcpu(env)); + } #endif + } } =20 uint64_t s390_cpu_get_psw_mask(CPUS390XState *env) diff --git a/target/s390x/helper.c b/target/s390x/helper.c index 184428c6d9d..8d1e03f6768 100644 --- a/target/s390x/helper.c +++ b/target/s390x/helper.c @@ -143,41 +143,3 @@ void do_restart_interrupt(CPUS390XState *env) =20 s390_cpu_set_psw(env, mask, addr); } - -void s390_cpu_recompute_watchpoints(CPUState *cs) -{ - const int wp_flags =3D BP_CPU | BP_MEM_WRITE | BP_STOP_BEFORE_ACCESS; - CPUS390XState *env =3D cpu_env(cs); - - /* We are called when the watchpoints have changed. First - remove them all. */ - cpu_watchpoint_remove_all(cs, BP_CPU); - - /* Return if PER is not enabled */ - if (!(env->psw.mask & PSW_MASK_PER)) { - return; - } - - /* Return if storage-alteration event is not enabled. */ - if (!(env->cregs[9] & PER_CR9_EVENT_STORE)) { - return; - } - - if (env->cregs[10] =3D=3D 0 && env->cregs[11] =3D=3D -1LL) { - /* We can't create a watchoint spanning the whole memory range, so - split it in two parts. */ - cpu_watchpoint_insert(cs, 0, 1ULL << 63, wp_flags, NULL); - cpu_watchpoint_insert(cs, 1ULL << 63, 1ULL << 63, wp_flags, NULL); - } else if (env->cregs[10] > env->cregs[11]) { - /* The address range loops, create two watchpoints. */ - cpu_watchpoint_insert(cs, env->cregs[10], -env->cregs[10], - wp_flags, NULL); - cpu_watchpoint_insert(cs, 0, env->cregs[11] + 1, wp_flags, NULL); - - } else { - /* Default case, create a single watchpoint. */ - cpu_watchpoint_insert(cs, env->cregs[10], - env->cregs[11] - env->cregs[10] + 1, - wp_flags, NULL); - } -} diff --git a/target/s390x/tcg/debug.c b/target/s390x/tcg/debug.c new file mode 100644 index 00000000000..50d2853d443 --- /dev/null +++ b/target/s390x/tcg/debug.c @@ -0,0 +1,85 @@ +/* + * QEMU S/390 debug routines + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include "qemu/osdep.h" +#include "exec/breakpoint.h" +#include "exec/watchpoint.h" +#include "target/s390x/cpu.h" +#include "target/s390x/s390x-internal.h" +#include "tcg_s390x.h" + +void s390_cpu_recompute_watchpoints(CPUState *cs) +{ + const int wp_flags =3D BP_CPU | BP_MEM_WRITE | BP_STOP_BEFORE_ACCESS; + CPUS390XState *env =3D cpu_env(cs); + + /* We are called when the watchpoints have changed. First + remove them all. */ + cpu_watchpoint_remove_all(cs, BP_CPU); + + /* Return if PER is not enabled */ + if (!(env->psw.mask & PSW_MASK_PER)) { + return; + } + + /* Return if storage-alteration event is not enabled. */ + if (!(env->cregs[9] & PER_CR9_EVENT_STORE)) { + return; + } + + if (env->cregs[10] =3D=3D 0 && env->cregs[11] =3D=3D -1LL) { + /* We can't create a watchoint spanning the whole memory range, so + split it in two parts. */ + cpu_watchpoint_insert(cs, 0, 1ULL << 63, wp_flags, NULL); + cpu_watchpoint_insert(cs, 1ULL << 63, 1ULL << 63, wp_flags, NULL); + } else if (env->cregs[10] > env->cregs[11]) { + /* The address range loops, create two watchpoints. */ + cpu_watchpoint_insert(cs, env->cregs[10], -env->cregs[10], + wp_flags, NULL); + cpu_watchpoint_insert(cs, 0, env->cregs[11] + 1, wp_flags, NULL); + + } else { + /* Default case, create a single watchpoint. */ + cpu_watchpoint_insert(cs, env->cregs[10], + env->cregs[11] - env->cregs[10] + 1, + wp_flags, NULL); + } +} + +void s390x_cpu_debug_excp_handler(CPUState *cs) +{ + CPUS390XState *env =3D cpu_env(cs); + CPUWatchpoint *wp_hit =3D cs->watchpoint_hit; + + if (wp_hit && wp_hit->flags & BP_CPU) { + /* + * FIXME: When the storage-alteration-space control bit is set, + * the exception should only be triggered if the memory access + * is done using an address space with the storage-alteration-event + * bit set. We have no way to detect that with the current + * watchpoint code. + */ + cs->watchpoint_hit =3D NULL; + + env->per_address =3D env->psw.addr; + env->per_perc_atmid |=3D PER_CODE_EVENT_STORE | get_per_atmid(env); + /* + * FIXME: We currently no way to detect the address space used + * to trigger the watchpoint. For now just consider it is the + * current default ASC. This turn to be true except when MVCP + * and MVCS instructions are not used. + */ + env->per_perc_atmid |=3D env->psw.mask & (PSW_MASK_ASC) >> 46; + + /* + * Remove all watchpoints to re-execute the code. A PER exception + * will be triggered, it will call s390_cpu_set_psw which will + * recompute the watchpoints. + */ + cpu_watchpoint_remove_all(cs, BP_CPU); + cpu_loop_exit_noexc(cs); + } +} diff --git a/target/s390x/tcg/excp_helper.c b/target/s390x/tcg/excp_helper.c index d4a096f5998..019eb4fba1f 100644 --- a/target/s390x/tcg/excp_helper.c +++ b/target/s390x/tcg/excp_helper.c @@ -24,7 +24,6 @@ #include "exec/helper-proto.h" #include "exec/cputlb.h" #include "exec/target_page.h" -#include "exec/watchpoint.h" #include "s390x-internal.h" #include "tcg_s390x.h" #ifndef CONFIG_USER_ONLY @@ -607,37 +606,6 @@ bool s390_cpu_exec_interrupt(CPUState *cs, int interru= pt_request) return false; } =20 -void s390x_cpu_debug_excp_handler(CPUState *cs) -{ - CPUS390XState *env =3D cpu_env(cs); - CPUWatchpoint *wp_hit =3D cs->watchpoint_hit; - - if (wp_hit && wp_hit->flags & BP_CPU) { - /* FIXME: When the storage-alteration-space control bit is set, - the exception should only be triggered if the memory access - is done using an address space with the storage-alteration-event - bit set. We have no way to detect that with the current - watchpoint code. */ - cs->watchpoint_hit =3D NULL; - - env->per_address =3D env->psw.addr; - env->per_perc_atmid |=3D PER_CODE_EVENT_STORE | get_per_atmid(env); - /* FIXME: We currently no way to detect the address space used - to trigger the watchpoint. For now just consider it is the - current default ASC. This turn to be true except when MVCP - and MVCS instrutions are not used. */ - env->per_perc_atmid |=3D env->psw.mask & (PSW_MASK_ASC) >> 46; - - /* - * Remove all watchpoints to re-execute the code. A PER exception - * will be triggered, it will call s390_cpu_set_psw which will - * recompute the watchpoints. - */ - cpu_watchpoint_remove_all(cs, BP_CPU); - cpu_loop_exit_noexc(cs); - } -} - void s390x_cpu_do_unaligned_access(CPUState *cs, vaddr addr, MMUAccessType access_type, int mmu_idx, uintptr_t retaddr) diff --git a/target/s390x/tcg/meson.build b/target/s390x/tcg/meson.build index ee4e8fec77c..515cb8b473d 100644 --- a/target/s390x/tcg/meson.build +++ b/target/s390x/tcg/meson.build @@ -12,3 +12,6 @@ s390x_ss.add(when: 'CONFIG_TCG', if_true: files( 'vec_int_helper.c', 'vec_string_helper.c', )) +s390x_system_ss.add(when: 'CONFIG_TCG', if_true: files( + 'debug.c', +)) --=20 2.52.0 From nobody Sun Feb 8 12:31:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1768223965; cv=none; d=zohomail.com; s=zohoarc; b=lh/koRCkix7CZVHSVf+XLF2GcK7eZC+obqiNx2I0r9bIzoz1fSHLjq0AI4GD9ucKxm1HvxHrvy9jZ7nKxuYNyEf1vfNDNJl0mViQk625o/mfo7+fYQV4lNTFqdtp45+3ayqofghYoeCKfYW6OuCYOu6Kmg/QP9BDj1Q01ysmHZg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768223965; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=rN50g8yKxgmlRGKcD2wI0yamanQvPuWmPF6MPdjdOmI=; b=g26MbLAGBPFB9Uhdxf8NsppFraHD/yroC4ZHODGt85pF47CYp1UAWGOYhNQehfdVR+y9VzaWdKELc/kWeNpzuFJQ+myovnkww2J9d5+87p439L1/UkMgXKaLvx1c9facCDu5fP+hfeoJeAcBa0OhBAo9rFDSZVLahEad3HWNuDU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768223965435748.7010670117659; Mon, 12 Jan 2026 05:19:25 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vfHoh-0003R0-Et; Mon, 12 Jan 2026 08:18:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfHlX-0001Xr-44 for qemu-devel@nongnu.org; Mon, 12 Jan 2026 08:15:30 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfHlV-0002Zw-DC for qemu-devel@nongnu.org; Mon, 12 Jan 2026 08:15:26 -0500 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-416-DOHOXD6hONS-o2ObhH718Q-1; Mon, 12 Jan 2026 08:15:23 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 77AE419560B9; Mon, 12 Jan 2026 13:15:22 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.224.179]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DD32630001A2; Mon, 12 Jan 2026 13:15:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768223724; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rN50g8yKxgmlRGKcD2wI0yamanQvPuWmPF6MPdjdOmI=; b=MK/xeBlX6CX3bxVv+eASHKf50XEdGR55xjUWxdjB3sx21vtWeXZeICI7F+HFXnuSlrfNxG x4Jn04tdiRqYtRdCJ2ArRuf0hqO+cVDnLWsL4iHRFtd94/EjXinAjnY+z0XM9pmdKzvQ19 CfNxqW8ZmKWUGzSoQgqAuJNS5O90Vp4= X-MC-Unique: DOHOXD6hONS-o2ObhH718Q-1 X-Mimecast-MFC-AGG-ID: DOHOXD6hONS-o2ObhH718Q_1768223722 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 09/15] target/s390x: Use vaddr for $pc in get_next_pc() Date: Mon, 12 Jan 2026 14:14:51 +0100 Message-ID: <20260112131457.67128-10-thuth@redhat.com> In-Reply-To: <20260112131457.67128-1-thuth@redhat.com> References: <20260112131457.67128-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1768223967910158500 From: Philippe Mathieu-Daud=C3=A9 DisasContextBase::pc_next is of vaddr type. Since translator_lduw_end() returns a uint16_t, also use that type for clarity. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth Message-ID: <20260107130807.69870-4-philmd@linaro.org> Signed-off-by: Thomas Huth --- target/s390x/tcg/translate.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c index e38607ee18c..540c5a569c0 100644 --- a/target/s390x/tcg/translate.c +++ b/target/s390x/tcg/translate.c @@ -6405,10 +6405,9 @@ static void s390x_tr_insn_start(DisasContextBase *dc= base, CPUState *cs) tcg_gen_insn_start(dc->base.pc_next, dc->cc_op, 0); } =20 -static target_ulong get_next_pc(CPUS390XState *env, DisasContext *s, - uint64_t pc) +static vaddr get_next_pc(CPUS390XState *env, DisasContext *s, vaddr pc) { - uint64_t insn =3D translator_lduw_end(env, &s->base, pc, MO_BE); + uint16_t insn =3D translator_lduw_end(env, &s->base, pc, MO_BE); =20 return pc + get_ilen((insn >> 8) & 0xff); } --=20 2.52.0 From nobody Sun Feb 8 12:31:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1768224027; cv=none; d=zohomail.com; s=zohoarc; b=gNcf5pDXcldxAwrwD/LvgKyPlwZrcYlotK9ia+gmVJK2s/s7FlyFZbAP/1WOQw1mugJNnq27/h6v3SEzdxp6wyJSK2i1XOPM/hLYJ8ck1eio+1MRD5zumDT80rnEFBw3XfGebz0JYH1Q6laCPp1Nnd2zz14WOfusBCy+tW+I4kA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768224027; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=aZUJUXlTONMlWRfr4eM1Jg9J+vE+nPqvdFsuDHwXiuE=; b=gkYoPdUP5GES8OeH+CZK1UIE8wz+ySg0sFAAO2DxB0IjOH0xx+dPXtlYz1aERPEO0Vu4jJ/tM9zvKUQfSj2unH5gBRk/9BcERL4fUEX4Hr+U5d0qZJT6F3GJ9Y2CDjk42MEMSIhO9ktOt0dR8K/OZKvQM1MOkKWVPhloMbXA21Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768224027471106.92617043314146; Mon, 12 Jan 2026 05:20:27 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vfHpQ-0004Fa-L4; Mon, 12 Jan 2026 08:19:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfHlb-0001Ys-5a for qemu-devel@nongnu.org; Mon, 12 Jan 2026 08:15:31 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfHlZ-0002bZ-LS for qemu-devel@nongnu.org; Mon, 12 Jan 2026 08:15:30 -0500 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-303-D9uOO-xPOsaWzMJ7Em30bQ-1; Mon, 12 Jan 2026 08:15:25 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 84EBF195399A; Mon, 12 Jan 2026 13:15:24 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.224.179]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1BCFD30002DA; Mon, 12 Jan 2026 13:15:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768223729; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aZUJUXlTONMlWRfr4eM1Jg9J+vE+nPqvdFsuDHwXiuE=; b=BFR+fCjORGvvlsPLkpxHye/+nhOWFQY8lNIdOMyYvxLiEccI60j/j84NMngHTF9DlydtTn yi1yP/tMKjf1scFvv8vBD+nSTAZC6RpP8zzkvnj4YouevP+PQcLp7f4JjB6JR+wZt+9BIR J42NzLjSQID/cbYmIrYhlEdOhSw3Dno= X-MC-Unique: D9uOO-xPOsaWzMJ7Em30bQ-1 X-Mimecast-MFC-AGG-ID: D9uOO-xPOsaWzMJ7Em30bQ_1768223724 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 10/15] target/s390x: Replace target_ulong -> uint64_t in gdb_write_register() Date: Mon, 12 Jan 2026 14:14:52 +0100 Message-ID: <20260112131457.67128-11-thuth@redhat.com> In-Reply-To: <20260112131457.67128-1-thuth@redhat.com> References: <20260112131457.67128-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1768224028205158500 From: Philippe Mathieu-Daud=C3=A9 On s390x target_ulong expands to uint64_t. Besides, ldq_be_p() returns a uint64_t type. Use that instead. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth Message-ID: <20260107130807.69870-5-philmd@linaro.org> Signed-off-by: Thomas Huth --- target/s390x/gdbstub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/s390x/gdbstub.c b/target/s390x/gdbstub.c index d1f02ea5ce4..9ae715add4d 100644 --- a/target/s390x/gdbstub.c +++ b/target/s390x/gdbstub.c @@ -46,7 +46,7 @@ int s390_cpu_gdb_read_register(CPUState *cs, GByteArray *= mem_buf, int n) int s390_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n) { CPUS390XState *env =3D cpu_env(cs); - target_ulong tmpl =3D ldq_be_p(mem_buf); + uint64_t tmpl =3D ldq_be_p(mem_buf); =20 switch (n) { case S390_PSWM_REGNUM: --=20 2.52.0 From nobody Sun Feb 8 12:31:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1768223898; cv=none; d=zohomail.com; s=zohoarc; b=M7L6ZEeOK36tKrA5rFj8xiarPpT3mO0GYU4scRdgrbAfXos+153E/EtSMDKWYVEr6GEPReT0F4l6Avh3bR+XYvVM8Qb0iYGdDuZzu9KCa5WCcLd9DlM7fMIZluTQNXNu5PwXSmZQIqT0DG1BeLC1G6SKIBF9p/f7IywVufo9yJw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768223898; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=3LFCkKY5XgP12F2ImbVWWwQ1H7RA9GzjXE9aQY0PmWw=; b=f3TKdE9ewN6yMdtQ6vrDfccfd/O/KTLYWwVDPUDeNyGwCaYDnfZOIAI3RZTbu/iPSzMTnO50asC0pqt+i6u1QHSk98GfOMKNmLuB8OjjG/CEBJavAYMrkDsTcowrCC8lLeG4f9zEjBP0ZWbDBaqY3yMync8H6QR304Rmt3vwdoM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17682238989251.9427313721491828; Mon, 12 Jan 2026 05:18:18 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vfHnd-0002a9-0J; Mon, 12 Jan 2026 08:17:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfHlb-0001Yt-6A for qemu-devel@nongnu.org; Mon, 12 Jan 2026 08:15:32 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfHlZ-0002bb-P3 for qemu-devel@nongnu.org; Mon, 12 Jan 2026 08:15:30 -0500 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-259-l_FqIZEAPbyH-BQgL-lf6Q-1; Mon, 12 Jan 2026 08:15:27 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CB1931800473; Mon, 12 Jan 2026 13:15:26 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.224.179]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 42B553000218; Mon, 12 Jan 2026 13:15:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768223729; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3LFCkKY5XgP12F2ImbVWWwQ1H7RA9GzjXE9aQY0PmWw=; b=W+6TC4/AQwwSXMtPctpThcoolefkwopNlKehly/FhQ7flDu4+hcdb1JZY6r736Rppf2mjF XVniqiq4h2NX9UZoUGDkzTox3JPafdP5hOrSX0KtMiMwHFjGFybmr65lAA8AHrJFldYhLt pOhsvm/CYGhDHybqdgGmBzogkwKit5o= X-MC-Unique: l_FqIZEAPbyH-BQgL-lf6Q-1 X-Mimecast-MFC-AGG-ID: l_FqIZEAPbyH-BQgL-lf6Q_1768223726 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 11/15] target/s390x: Remove unused 'gdbstub/helpers.h' header in helper.c Date: Mon, 12 Jan 2026 14:14:53 +0100 Message-ID: <20260112131457.67128-12-thuth@redhat.com> In-Reply-To: <20260112131457.67128-1-thuth@redhat.com> References: <20260112131457.67128-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1768223899497158500 From: Philippe Mathieu-Daud=C3=A9 "gdbstub/helpers.h" uses target-specific symbols, but we don't need it, so remove it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Tested-by: Thomas Huth Message-ID: <20260107130807.69870-6-philmd@linaro.org> Signed-off-by: Thomas Huth --- target/s390x/helper.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/s390x/helper.c b/target/s390x/helper.c index 8d1e03f6768..a6c89ed0af3 100644 --- a/target/s390x/helper.c +++ b/target/s390x/helper.c @@ -21,7 +21,6 @@ #include "qemu/osdep.h" #include "cpu.h" #include "s390x-internal.h" -#include "gdbstub/helpers.h" #include "qemu/timer.h" #include "hw/s390x/ioinst.h" #include "system/hw_accel.h" --=20 2.52.0 From nobody Sun Feb 8 12:31:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1768223881; cv=none; d=zohomail.com; s=zohoarc; b=aQDg9lJUdc/tNSvyU+26TO8zNLbxdn6zSaVGe6fVCdOdVrTab92u1zy+rY+msAO86H+ytRd/gyybyfcc25NEMOSjSF6igIaeZejcRd4vsBqXpdSahHVcr56x22q+maqfiJwG6hnujuXXAvGR5EidUE2tA06i7CtWbVum7GMulgQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768223881; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1BBB0qFSJi0GhP/DTeqzyi1vrmJY0plBlAa5qkOZ0JU=; b=jrLFvC5bXDL8PmeYw+14xYoLRpKtQEe0tw9UrYXE2E5EHP++peVPRtrcUHAIQdIfjioP+iUPIoB3vLcjB7Zs/0HHc1xMUw3Fca5EOvHf+ampqpVW3+8DkotKdHC4lSFn9q7JRTeRRaVKRFaM5Cv5wRu6r/L3Qg+HiKbUY7BohtM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768223880465361.67580084370684; Mon, 12 Jan 2026 05:18:00 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vfHnb-0002XR-8Y; Mon, 12 Jan 2026 08:17:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfHlg-0001a5-Gm for qemu-devel@nongnu.org; Mon, 12 Jan 2026 08:15:37 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfHle-0002cG-2B for qemu-devel@nongnu.org; Mon, 12 Jan 2026 08:15:36 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-260-8lnhfLrbMWe5xlkuqP8oHw-1; Mon, 12 Jan 2026 08:15:29 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D1128180061E; Mon, 12 Jan 2026 13:15:28 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.224.179]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4B74130001A2; Mon, 12 Jan 2026 13:15:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768223733; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1BBB0qFSJi0GhP/DTeqzyi1vrmJY0plBlAa5qkOZ0JU=; b=hd5bHZIPqhK1K95nHjUmg74dPkziHy9woaIO+5K0f1HIDGfZBOxlIltuQpv3hxFNLQ7b7Y nd3ruHpXa3bqZi+GEu2j+VG3aqG36WSD8ptQk9hERtiC/SrcjqUgvOPhurySoaoiUyZ59x ywAHz4wBKNkwZswsEOJU3lJd3zR+ziI= X-MC-Unique: 8lnhfLrbMWe5xlkuqP8oHw-1 X-Mimecast-MFC-AGG-ID: 8lnhfLrbMWe5xlkuqP8oHw_1768223728 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 12/15] target/s390x: Simplify S390_ADAPTER_SUPPRESSIBLE definition Date: Mon, 12 Jan 2026 14:14:54 +0100 Message-ID: <20260112131457.67128-13-thuth@redhat.com> In-Reply-To: <20260112131457.67128-1-thuth@redhat.com> References: <20260112131457.67128-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1768223883312158500 From: Philippe Mathieu-Daud=C3=A9 Commit 1497c160661 ("s390x: add flags field for registering I/O adapter") defined S390_ADAPTER_SUPPRESSIBLE twice, one when KVM is available and another when it isn't. However both definitions expand to the same value. Unify them, adding an extra safety check in KVM-specific file. This allows removing the target-specific 'CONFIG_KVM' definition in "cpu.h". Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth Message-ID: <20260107130807.69870-15-philmd@linaro.org> Signed-off-by: Thomas Huth --- include/hw/s390x/css.h | 2 ++ target/s390x/cpu.h | 6 ------ target/s390x/kvm/kvm.c | 2 ++ 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/include/hw/s390x/css.h b/include/hw/s390x/css.h index 0b0400a9d4f..d3326237c9f 100644 --- a/include/hw/s390x/css.h +++ b/include/hw/s390x/css.h @@ -238,6 +238,8 @@ uint32_t css_get_adapter_id(CssIoAdapterType type, uint= 8_t isc); void css_register_io_adapters(CssIoAdapterType type, bool swap, bool maska= ble, uint8_t flags, Error **errp); =20 +#define S390_ADAPTER_SUPPRESSIBLE 0x01 + SubchDev *css_find_subch(uint8_t m, uint8_t cssid, uint8_t ssid, uint16_t schid); bool css_subch_visible(SubchDev *sch); diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h index ba2bf177e8f..40bc1f0741d 100644 --- a/target/s390x/cpu.h +++ b/target/s390x/cpu.h @@ -39,12 +39,6 @@ =20 #define S390_MAX_CPUS 248 =20 -#ifndef CONFIG_KVM -#define S390_ADAPTER_SUPPRESSIBLE 0x01 -#else -#define S390_ADAPTER_SUPPRESSIBLE KVM_S390_ADAPTER_SUPPRESSIBLE -#endif - typedef struct PSW { uint64_t mask; uint64_t addr; diff --git a/target/s390x/kvm/kvm.c b/target/s390x/kvm/kvm.c index bd6c440aefb..54d28e37d4d 100644 --- a/target/s390x/kvm/kvm.c +++ b/target/s390x/kvm/kvm.c @@ -2082,6 +2082,8 @@ int kvm_s390_vcpu_interrupt_post_load(S390CPU *cpu) return r; } =20 +QEMU_BUILD_BUG_ON(S390_ADAPTER_SUPPRESSIBLE !=3D KVM_S390_ADAPTER_SUPPRESS= IBLE); + int kvm_arch_fixup_msi_route(struct kvm_irq_routing_entry *route, uint64_t address, uint32_t data, PCIDevice *d= ev) { --=20 2.52.0 From nobody Sun Feb 8 12:31:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1768224027; cv=none; d=zohomail.com; s=zohoarc; b=Z3pMSmR9vib7Q50pB47g4NjMQrZiHeBhc+EMoStZ9542catRvKUZNt5u9KN/nFjZ2JQYWnuuGhlOlDyO0Tmb4id8HXq3L7q7JQ0ztaiaEUY4+v3b0tYH9HTDHLHl4V21BFHsHaIW72g8tKkn/kM4hFZJiTb4pGXXsNos6dbm/vs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768224027; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=oG9Dsze0JU1GCFIaRY/UGoIwmjHYD7VTV+1WbSmKAZo=; b=Q5Ptf+5obQqxm7XMKVyeEl8aLnrPOfOn6fDIv+wF6xzN71GY4AMtAC2qvijI83ydAPGTErLFUbWy54myre0W66bnVyvGvwHK8R6uZ0rzKmj7Qia3CuAqXeCRilLmq0R7iPsPLKlQV+ETVPFi+NW7Dj4PywO2+XokhoS5+KP8KKc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768224027944203.93677806019002; Mon, 12 Jan 2026 05:20:27 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vfHp5-0003nj-L4; Mon, 12 Jan 2026 08:19:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfHll-0001d3-Pz for qemu-devel@nongnu.org; Mon, 12 Jan 2026 08:16:00 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfHlj-0002ce-0S for qemu-devel@nongnu.org; Mon, 12 Jan 2026 08:15:41 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-169-wyUBvxG-MSCeg-jkX7WDgw-1; Mon, 12 Jan 2026 08:15:32 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 29D4318005AF; Mon, 12 Jan 2026 13:15:31 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.224.179]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5473D30001A2; Mon, 12 Jan 2026 13:15:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768223737; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oG9Dsze0JU1GCFIaRY/UGoIwmjHYD7VTV+1WbSmKAZo=; b=WJL2aKF1RajyIlZKsRxbOCQZkCnpIa26fDprqsi/3CRgGqtNog2c0m1VwZjHf8/bnxyzPz VP1lvgUu6cA9Qo3zp3D0nKSZifFVQ7HJ0fwW0E9uZgylGvko9W6DUp1LIdgpYB1MxCn3ES ECWU1zMVoQamFYtQeAPxOteMKeLEusQ= X-MC-Unique: wyUBvxG-MSCeg-jkX7WDgw-1 X-Mimecast-MFC-AGG-ID: wyUBvxG-MSCeg-jkX7WDgw_1768223731 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 13/15] target/s390x: Un-inline s390_is_pv() Date: Mon, 12 Jan 2026 14:14:55 +0100 Message-ID: <20260112131457.67128-14-thuth@redhat.com> In-Reply-To: <20260112131457.67128-1-thuth@redhat.com> References: <20260112131457.67128-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1768224030044158500 From: Philippe Mathieu-Daud=C3=A9 Inlining a method which use a static variable is really a bad idea, as it totally defeats the point of both concepts. Currently we have 12 + 4 =3D 16 static 'ccw' variables...: $ git grep -wl target/s390x/kvm/pv.h | fgrep .h hw/s390x/ipl.h $ git grep -wl target/s390x/kvm/pv.h | fgrep .c | wc -l 12 $ git grep -wl hw/s390x/ipl.h | fgrep .c | wc -l 4 Fixes: c3347ed0d2e ("s390x: protvirt: Support unpack facility") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth Message-ID: <20260107130807.69870-16-philmd@linaro.org> Signed-off-by: Thomas Huth --- target/s390x/kvm/pv.h | 24 +----------------------- target/s390x/kvm/pv.c | 18 ++++++++++++++++++ 2 files changed, 19 insertions(+), 23 deletions(-) diff --git a/target/s390x/kvm/pv.h b/target/s390x/kvm/pv.h index 94e885e9335..e266fc3d545 100644 --- a/target/s390x/kvm/pv.h +++ b/target/s390x/kvm/pv.h @@ -12,8 +12,6 @@ #ifndef HW_S390_PV_H #define HW_S390_PV_H =20 -#include "qapi/error.h" -#include "system/kvm.h" #include "hw/s390x/s390-virtio-ccw.h" =20 struct S390PVResponse { @@ -23,27 +21,7 @@ struct S390PVResponse { }; =20 #ifdef CONFIG_KVM -#include "cpu.h" - -static inline bool s390_is_pv(void) -{ - static S390CcwMachineState *ccw; - Object *obj; - - if (ccw) { - return ccw->pv; - } - - /* we have to bail out for the "none" machine */ - obj =3D object_dynamic_cast(qdev_get_machine(), - TYPE_S390_CCW_MACHINE); - if (!obj) { - return false; - } - ccw =3D S390_CCW_MACHINE(obj); - return ccw->pv; -} - +bool s390_is_pv(void); int s390_pv_query_info(void); int s390_pv_vm_enable(void); void s390_pv_vm_disable(void); diff --git a/target/s390x/kvm/pv.c b/target/s390x/kvm/pv.c index 2bc916a5455..3d508165f34 100644 --- a/target/s390x/kvm/pv.c +++ b/target/s390x/kvm/pv.c @@ -25,6 +25,24 @@ #include "target/s390x/kvm/kvm_s390x.h" #include "target/s390x/kvm/pv.h" =20 +bool s390_is_pv(void) +{ + static S390CcwMachineState *ccw; + Object *obj; + + if (ccw) { + return ccw->pv; + } + + /* we have to bail out for the "none" machine */ + obj =3D object_dynamic_cast(qdev_get_machine(), TYPE_S390_CCW_MACHINE); + if (!obj) { + return false; + } + ccw =3D S390_CCW_MACHINE(obj); + return ccw->pv; +} + static bool info_valid; static struct kvm_s390_pv_info_vm info_vm; static struct kvm_s390_pv_info_dump info_dump; --=20 2.52.0 From nobody Sun Feb 8 12:31:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1768224015; cv=none; d=zohomail.com; s=zohoarc; b=ke5Y8FXizXC/9Z0Ci7D9SlZVUr3/DZ9aTUoWQVezo65dF+VP8kll9LYuD4b05YMb4GGWlng6aBoVxturEmmgWl6zEZoZJ1R4SqQl7hlXEUCTSzTEBWLUpJN1PO4C9Rz0XZ7jA2NFfwAmqPoX/ajAKlLnU3Asxg2mjk5IbYLJOXM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768224015; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Ask/kaEfsqPjdW7TMeUlFhRmQNDQ/cdJ4fFt3gBuhLA=; b=CY/v2EV5sC1ymXxC4BDmpGcBIsQE+2uMpNi92zToYVRt8COlrppZJ7+AgZy/ivdLJT/Jyeex7z+/8/QpYtY8+R/Eslb6pCZ16V0+Xha2+wUTyAdSPjosHUGlLSxTMgPt2Hl5mNr6SUVm7k03gFKL/ZldTyDRkKudtMVciBDUVYM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768224015395374.9475212474455; Mon, 12 Jan 2026 05:20:15 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vfHp4-0003jk-07; Mon, 12 Jan 2026 08:19:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfHlk-0001c5-VK for qemu-devel@nongnu.org; Mon, 12 Jan 2026 08:15:41 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfHli-0002cc-Vy for qemu-devel@nongnu.org; Mon, 12 Jan 2026 08:15:40 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-551-PU4PMbrYPZeFZxksfoRnVw-1; Mon, 12 Jan 2026 08:15:33 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EA6E9195605B; Mon, 12 Jan 2026 13:15:32 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.224.179]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9BC7630001A2; Mon, 12 Jan 2026 13:15:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768223737; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ask/kaEfsqPjdW7TMeUlFhRmQNDQ/cdJ4fFt3gBuhLA=; b=Wznzj/QjSjBO4V0C96aLYb54GPCYwUDbRC3w5e8KPvOos5PUIwjW4fLOJe6DqWF8wwfSoQ vsC2VUM0D7w8zLijUWq06jhIq0vRFeBr6HdLP9rrdZE9Bk29Sm2zyQVchwfr94qLN4pL9p SW3ZpOdr/Vda0dOR7tecvftAvTEUXnA= X-MC-Unique: PU4PMbrYPZeFZxksfoRnVw-1 X-Mimecast-MFC-AGG-ID: PU4PMbrYPZeFZxksfoRnVw_1768223733 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson , Ilya Leoshkevich Subject: [PULL 14/15] target/s390x: Fix infinite loop during replay Date: Mon, 12 Jan 2026 14:14:56 +0100 Message-ID: <20260112131457.67128-15-thuth@redhat.com> In-Reply-To: <20260112131457.67128-1-thuth@redhat.com> References: <20260112131457.67128-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1768224016101158500 Content-Type: text/plain; charset="utf-8" From: Ilya Leoshkevich Replaying even trivial s390x kernels hangs, because: - cpu_post_load() fires the TOD timer immediately. - s390_tod_load() schedules work for firing the TOD timer. - If rr loop sees work and then timer, we get one timer expiration. - If rr loop sees timer and then work, we get two timer expirations. - Record and replay may diverge due to this race. - In this particular case divergence makes replay loop spin: it sees that TOD timer has expired, but cannot invoke its callback, because there is no recorded CHECKPOINT_CLOCK_VIRTUAL. - The order in which rr loop sees work and timer depends on whether and when rr loop wakes up during load_snapshot(). - rr loop may wake up after the main thread kicks the CPU and drops the BQL, which may happen if it calls, e.g., qemu_cond_wait_bql(). Firing TOD timer twice is duplicate work, but it was introduced intentionally in commit 7c12f710bad6 ("s390x/tcg: rearm the CKC timer during migration") in order to avoid dependency on migration order. The key culprits here are timers that are armed ready expired. They break the ordering between timers and CPU work, because they are not constrained by instruction execution, thus introducing non-determinism and record-replay divergence. Fix by converting such timer callbacks to CPU work. Also add TOD clock updates to the save path, mirroring the load path, in order to have the same CHECKPOINT_CLOCK_VIRTUAL during recording and replaying. Link: https://lore.kernel.org/qemu-devel/20251128133949.181828-1-thuth@redh= at.com/ Signed-off-by: Ilya Leoshkevich Tested-by: Thomas Huth Message-ID: <20251201215514.1751994-1-iii@linux.ibm.com> [thuth: Add SPDX license identifiers to the new stubs files] Signed-off-by: Thomas Huth --- hw/s390x/tod.c | 5 +++++ stubs/async-run-on-cpu.c | 11 +++++++++++ stubs/cpus-queue.c | 8 ++++++++ target/s390x/machine.c | 4 ++++ util/qemu-timer.c | 30 ++++++++++++++++++++++++++++++ stubs/meson.build | 2 ++ 6 files changed, 60 insertions(+) create mode 100644 stubs/async-run-on-cpu.c create mode 100644 stubs/cpus-queue.c diff --git a/hw/s390x/tod.c b/hw/s390x/tod.c index 3f913cc88ab..81bce90c030 100644 --- a/hw/s390x/tod.c +++ b/hw/s390x/tod.c @@ -72,6 +72,11 @@ static void s390_tod_save(QEMUFile *f, void *opaque) qemu_put_byte(f, S390_TOD_CLOCK_VALUE_PRESENT); qemu_put_byte(f, tod.high); qemu_put_be64(f, tod.low); + + tdc->set(td, &tod, &err); + if (err) { + warn_report_err(err); + } } =20 static int s390_tod_load(QEMUFile *f, void *opaque, int version_id) diff --git a/stubs/async-run-on-cpu.c b/stubs/async-run-on-cpu.c new file mode 100644 index 00000000000..b8975bf5a8a --- /dev/null +++ b/stubs/async-run-on-cpu.c @@ -0,0 +1,11 @@ +/* + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include "qemu/osdep.h" +#include "hw/core/cpu.h" + +void async_run_on_cpu(CPUState *cpu, run_on_cpu_func func, run_on_cpu_data= data) +{ + abort(); +} diff --git a/stubs/cpus-queue.c b/stubs/cpus-queue.c new file mode 100644 index 00000000000..c59fb76a108 --- /dev/null +++ b/stubs/cpus-queue.c @@ -0,0 +1,8 @@ +/* + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include "qemu/osdep.h" +#include "hw/core/cpu.h" + +CPUTailQ cpus_queue =3D QTAILQ_HEAD_INITIALIZER(cpus_queue); diff --git a/target/s390x/machine.c b/target/s390x/machine.c index 3bea6103ffb..f714834a98a 100644 --- a/target/s390x/machine.c +++ b/target/s390x/machine.c @@ -52,6 +52,10 @@ static int cpu_pre_save(void *opaque) kvm_s390_vcpu_interrupt_pre_save(cpu); } =20 + if (tcg_enabled()) { + tcg_s390_tod_updated(CPU(cpu), RUN_ON_CPU_NULL); + } + return 0; } =20 diff --git a/util/qemu-timer.c b/util/qemu-timer.c index 2a6be4c7f95..d93a020064f 100644 --- a/util/qemu-timer.c +++ b/util/qemu-timer.c @@ -30,6 +30,7 @@ #include "exec/icount.h" #include "system/replay.h" #include "system/cpus.h" +#include "hw/core/cpu.h" =20 #ifdef CONFIG_POSIX #include @@ -387,11 +388,40 @@ static void timer_del_locked(QEMUTimerList *timer_lis= t, QEMUTimer *ts) } } =20 +static void timer_fire(CPUState *cpu, run_on_cpu_data data) +{ + QEMUTimer *t =3D data.host_ptr; + + t->cb(t->opaque); +} + static bool timer_mod_ns_locked(QEMUTimerList *timer_list, QEMUTimer *ts, int64_t expire_time) { QEMUTimer **pt, *t; =20 + /* + * Normally during record-replay virtual clock timers and CPU work are + * deterministically ordered. This is because the virtual clock can be + * advanced only by instructions running on a CPU. + * + * A notable exception are timers that are armed already expired. Their + * expiration is not constrained by instruction execution, and, theref= ore, + * their ordering relative to CPU work is affected by what the + * record-replay thread is doing when they are armed. This introduces + * non-determinism. + * + * Convert such timers to CPU work in order to avoid it. + */ + if (replay_mode !=3D REPLAY_MODE_NONE && + timer_list->clock->type =3D=3D QEMU_CLOCK_VIRTUAL && + !(ts->attributes & QEMU_TIMER_ATTR_EXTERNAL) && + expire_time <=3D qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL)) { + async_run_on_cpu(first_cpu, timer_fire, + RUN_ON_CPU_HOST_PTR(ts)); + return false; + } + /* add the timer in the sorted list */ pt =3D &timer_list->active_timers; for (;;) { diff --git a/stubs/meson.build b/stubs/meson.build index 0b2778c568e..d3b551f4def 100644 --- a/stubs/meson.build +++ b/stubs/meson.build @@ -41,6 +41,8 @@ if have_block or have_ga stub_ss.add(files('monitor-internal.c')) stub_ss.add(files('qmp-command-available.c')) stub_ss.add(files('qmp-quit.c')) + stub_ss.add(files('async-run-on-cpu.c')) + stub_ss.add(files('cpus-queue.c')) endif =20 if have_block or have_user --=20 2.52.0 From nobody Sun Feb 8 12:31:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1768224018; cv=none; d=zohomail.com; s=zohoarc; b=OF73ggNZ53GpK2EAsOwV6c82a+t3CuJFOrlZnUOoHV++Z6LaNCn7tS3ptw9BnxsCQuGrr1ohI+KU3TlxR1CakiCcAFaWh88bJnRsSxbtthsKVhULT/VI2Y6OI07QrZh/6wsopFlos4VLrJ891BomyVMcwulqCOSeE0QWVeKSO2Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768224018; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=x5PU5FgWkmHMj7tzDBRtNubeqZqU7aAzAk56WObzado=; b=MtSSlHtrH7/L6SaOJdwG2aSSF3ihZUoTimc0FmWDFVg4CR+6gYoIt64yv2ib6tiZjytId0JClfA6BfDOHJdK0fiQDY5Cxrb4LqDgYsU2qHazJuMSkNJbPDhrWfJ58PAHKg8NxQt5sZPKFw/4XbBE6fNJM2hVK2i5jQzW6leebiQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768224018867993.4739501180612; Mon, 12 Jan 2026 05:20:18 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vfHoy-0003bF-Rr; Mon, 12 Jan 2026 08:19:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfHlk-0001bf-GV for qemu-devel@nongnu.org; Mon, 12 Jan 2026 08:15:40 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfHlj-0002cl-0X for qemu-devel@nongnu.org; Mon, 12 Jan 2026 08:15:40 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-18-kXDb_9z8MGCEPnNj2S6wXg-1; Mon, 12 Jan 2026 08:15:36 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C2F07180060F; Mon, 12 Jan 2026 13:15:35 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.224.179]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C947B30001A7; Mon, 12 Jan 2026 13:15:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768223738; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x5PU5FgWkmHMj7tzDBRtNubeqZqU7aAzAk56WObzado=; b=Lg81IQu/D1AFIBakODbZqh3uqyHipdqHsERwJ7865bEF7t9cc+Ptl+DMOQXdhdg7UCddEx 3Yep1z6BlgxdzQYVuL1woM6RhwChW2c0cihsmjtd3gJYFdqlJyhx6nXaKOQHO2f4GawHfG ATUgX3gbSuSJ8TOx9mZaQRIgDccJVwY= X-MC-Unique: kXDb_9z8MGCEPnNj2S6wXg-1 X-Mimecast-MFC-AGG-ID: kXDb_9z8MGCEPnNj2S6wXg_1768223735 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson , Ilya Leoshkevich Subject: [PULL 15/15] tests/functional/s390x: Add reverse debugging test for s390x Date: Mon, 12 Jan 2026 14:14:57 +0100 Message-ID: <20260112131457.67128-16-thuth@redhat.com> In-Reply-To: <20260112131457.67128-1-thuth@redhat.com> References: <20260112131457.67128-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1768224020023158500 Content-Type: text/plain; charset="utf-8" From: Thomas Huth We just have to make sure that we can set the endianness to big endian, then we can also run this test on s390x. Reviewed-by: Ilya Leoshkevich Signed-off-by: Thomas Huth Message-ID: <20251128133949.181828-1-thuth@redhat.com> --- tests/functional/reverse_debugging.py | 4 +++- tests/functional/s390x/meson.build | 1 + tests/functional/s390x/test_reverse_debug.py | 21 ++++++++++++++++++++ 3 files changed, 25 insertions(+), 1 deletion(-) create mode 100755 tests/functional/s390x/test_reverse_debug.py diff --git a/tests/functional/reverse_debugging.py b/tests/functional/rever= se_debugging.py index 86fca8d81f1..8b9507674a0 100644 --- a/tests/functional/reverse_debugging.py +++ b/tests/functional/reverse_debugging.py @@ -64,7 +64,7 @@ def vm_get_icount(vm): =20 @skipIfMissingImports("pygdbmi") # Required by GDB class @skipIfMissingEnv("QEMU_TEST_GDB") - def reverse_debugging(self, gdb_arch, shift=3D7, args=3DNone): + def reverse_debugging(self, gdb_arch, shift=3D7, args=3DNone, big_endi= an=3DFalse): from qemu_test import GDB =20 # create qcow2 for snapshots @@ -99,6 +99,8 @@ def reverse_debugging(self, gdb_arch, shift=3D7, args=3DN= one): gdb_cmd =3D os.getenv('QEMU_TEST_GDB') gdb =3D GDB(gdb_cmd) try: + if big_endian: + gdb.cli("set endian big") self.reverse_debugging_run(gdb, vm, port, gdb_arch, last_i= count) finally: self.log.info('exiting gdb and qemu') diff --git a/tests/functional/s390x/meson.build b/tests/functional/s390x/me= son.build index 70cd36e2913..0f03e1c9db8 100644 --- a/tests/functional/s390x/meson.build +++ b/tests/functional/s390x/meson.build @@ -6,6 +6,7 @@ test_s390x_timeouts =3D { =20 tests_s390x_system_quick =3D [ 'vmstate', + 'reverse_debug', ] =20 tests_s390x_system_thorough =3D [ diff --git a/tests/functional/s390x/test_reverse_debug.py b/tests/functiona= l/s390x/test_reverse_debug.py new file mode 100755 index 00000000000..0767dc91678 --- /dev/null +++ b/tests/functional/s390x/test_reverse_debug.py @@ -0,0 +1,21 @@ +#!/usr/bin/env python3 +# +# SPDX-License-Identifier: GPL-2.0-or-later +# +''' +Reverse debugging test for s390x +''' + +from reverse_debugging import ReverseDebugging + + +class ReverseDebuggingS390x(ReverseDebugging): + + def test_revdbg(self): + self.set_machine('s390-ccw-virtio') + self.reverse_debugging(gdb_arch=3D's390:64-bit', shift=3D6, + big_endian=3DTrue, args=3D('-no-shutdown',)) + + +if __name__ =3D=3D '__main__': + ReverseDebugging.main() --=20 2.52.0