From nobody Tue Feb 10 01:35:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1768213877; cv=none; d=zohomail.com; s=zohoarc; b=OIuQdT+q4Q0M8F+WAuRBn8Pk1wwEaP9pH+IAA9lHMKCUwFZQ5SEU/UPXsBcuasEFGgFfMmzc5z/HS1JcOpk4V2tmGKV8s6OHV5ESjkCETXK55MmzUJ1xIXpphUbc0fYs+bTeJK5AUa+41VdwH4zxFCNtIVrAYZ5JXFV5O/fRY/A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768213877; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=iuteZZxP72AdlZG/ZllJpEmgG/znqQ6KfrKPEYlPSPU=; b=U5Vk5lHHPV8mMMGwKUTc2IpB8nx/Mrg4V9ewDqokKCX0wOF/r7OhjnZGaI0GPKBy8qnY0Unb5DrgUovZAgkA7gw+wjev9sf+OUQlEM9g4V5vNqnX51W9oo17m3d1zH9E1ylRyK/qn2u9lRUW1ZvinV+T4P+Yh8dig9hVaIjBqG0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768213877857767.6320938107046; Mon, 12 Jan 2026 02:31:17 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vfFCX-0000kW-4M; Mon, 12 Jan 2026 05:31:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfFCK-0000Qh-Lp for qemu-devel@nongnu.org; Mon, 12 Jan 2026 05:30:58 -0500 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vfFCH-0001eF-6A for qemu-devel@nongnu.org; Mon, 12 Jan 2026 05:30:55 -0500 Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-42fb2314eb0so5143101f8f.2 for ; Mon, 12 Jan 2026 02:30:51 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd0e19bfsm37495823f8f.18.2026.01.12.02.30.48 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 12 Jan 2026 02:30:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768213850; x=1768818650; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iuteZZxP72AdlZG/ZllJpEmgG/znqQ6KfrKPEYlPSPU=; b=RHIpCqsehl4bge5RejRPLxpoE8U3D9o8Os0ghh2qzGztC5QWXAFrfxU7ldi5Z10eAm 9bn7ny7I+U4KtmXFGfbgoODIa7oBtFJTVlbeoo5ze1eCfLpNtql7au4+dJwtlW//qhdc 11krX4N99bfSnhQX8KTj+qDRXQv84qXHkAyvnH6VUONGljGd4EUmYOFU9tTZcuzp0/pf Glar4sQA1dHxz8QniQMFJZIZjWtY2PV9VW0DmRQXy2jQAJFzXTeSKWprnbZBYTQbGXU/ McMH+butvmsCWMv29s1Xtc6uLKgCnHUjHGDkNKqnzCGKmLd6K4gUAT6zN6ZErLvK9Xg4 Z9Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768213850; x=1768818650; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=iuteZZxP72AdlZG/ZllJpEmgG/znqQ6KfrKPEYlPSPU=; b=XWaqh/EkeAaUBPVpR5CheeNgljFueyozBA4Gaw10sM1UJ5Hxhmhh0OyAKE13KZjJPV ouOexrC7UcyBpz7bOKmKAR2VBaJcdigrDPMymTVKSJCsM5KELftfNWwqw2GcaAyP722p Lyg0ZThCtNAuAK7Oh7CojaskDIazu2l/R68m3+MlJ6xQ01YIi3BV2/m4VoT4F7D5LaRp 41kKZycOPheHlRjfhN129lqlM9Z/31sYwje2VRgeRrB+x7cP23HAd/6F8Hw4fs7JZ0hT UkmmDW1EO4qe0Kwe922kkIsklmF2qaiXKBMLaHTI9z4OFOWK6uQ83od2KarJqdr3Mxwf uHGA== X-Gm-Message-State: AOJu0Yy0jVoTdBzOxTSJeDuIAYtF/SclX+p3WP1Fo1JTEo0NKBnUjZC6 04MDQgKMUzHHWk1ye5ry0dfJAY7F10vAJrvTiNQp7+mNaXjoiDMeAM75rJHBNCbiy9ozE8ghN0p fBaC5lLM= X-Gm-Gg: AY/fxX5qEXOK4UpXqH+yqHqmufDDic5UeGT1FyDFWjtKtwrcpDu9CGmVel+AGZEu7P6 fYiiVrLlbOmzQasCbyClGL+HU1+2pyysyI4GcWo/sTB+qjanWGfdzR5Ts+AIibn8qpyA7PcV5GJ /yxNeR8DEv1AX6NUjwX4aG2ZcH/aADpHvKMeDFbJgu7XUiNpsIdO8mkQdVBF/4ewzynCYcVfwXl +7mndvH90PqJaXxX66JC+Gu5Xi87EQDV3jflRqx/e4fwi/6k8v3HYGYh2ljVIPlNoEasiAva9R6 HLxecq5y8eouSjcrFzOGBPxqhpnOyTQOJjfaQ9tEtoS36/qSB5UIotmG9iqns2gnzO+//ZrFxTS 2R+2Xsq4S8im310maW0f86kf5TVu+HkOs1eL98evJ8rnDrs732sKZg2E9z8T6dxQD716n4MOqUl KSXswcbLZjadc1ML2oipiDjDpChQ4Q5hgGmPtmdjA+7d3OAVHR3i0Tk6SFx/S3 X-Google-Smtp-Source: AGHT+IF3ZTbLdnzutbrVwqWTwnPZgqWmiDXh0eTf7bS3s1GZRQU2C189gzuaYXrsvaFVRd2tv+1gxw== X-Received: by 2002:a05:6000:4313:b0:433:1d30:44c with SMTP id ffacd0b85a97d-4331d3005d3mr1641586f8f.43.1768213849925; Mon, 12 Jan 2026 02:30:49 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Joelle van Dyne , Mads Ynddal , Phil Dennis-Jordan , Nguyen Dinh Phi , Mohamed Mediouni , Cameron Esfahani , Roman Bolshakov , Peter Collingbourne , qemu-arm@nongnu.org, Akihiko Odaki , Alexander Graf , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v6 02/19] target/i386/hvf: Use host page alignment in ept_emulation_fault() Date: Mon, 12 Jan 2026 11:30:16 +0100 Message-ID: <20260112103034.65310-3-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260112103034.65310-1-philmd@linaro.org> References: <20260112103034.65310-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=philmd@linaro.org; helo=mail-wr1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1768213879735158500 While on x86 the host page size is fixed to 4KB, it is better to call qemu_real_host_page_size() for consistency. Reviewed-by: Peter Maydell Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Akihiko Odaki --- target/i386/hvf/hvf.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c index 2023a7bfbb0..731cd954630 100644 --- a/target/i386/hvf/hvf.c +++ b/target/i386/hvf/hvf.c @@ -76,7 +76,7 @@ #include "qemu/main-loop.h" #include "qemu/accel.h" #include "target/i386/cpu.h" -#include "exec/target_page.h" +#include "exec/cpu-common.h" =20 static Error *invtsc_mig_blocker; =20 @@ -137,9 +137,12 @@ static bool ept_emulation_fault(hvf_slot *slot, uint64= _t gpa, uint64_t ept_qual) =20 if (write && slot) { if (slot->flags & HVF_SLOT_LOG) { - uint64_t dirty_page_start =3D gpa & ~(TARGET_PAGE_SIZE - 1u); + uintptr_t page_size =3D qemu_real_host_page_size(); + intptr_t page_mask =3D -(intptr_t)page_size; + uint64_t dirty_page_start =3D gpa & page_mask; + memory_region_set_dirty(slot->region, gpa - slot->start, 1); - hv_vm_protect(dirty_page_start, TARGET_PAGE_SIZE, + hv_vm_protect(dirty_page_start, page_size, HV_MEMORY_READ | HV_MEMORY_WRITE | HV_MEMORY_EXE= C); } } --=20 2.52.0