From nobody Mon Feb 9 16:03:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1768168790; cv=none; d=zohomail.com; s=zohoarc; b=LoUgOaF5vSY2DNdsI9u//aCUxDgOWCfBhfLSRVJsQ8PfzQPjKgbYSEuOroL2phZLN+HeciUgfB2rgfVoxXZwLcZUo1mqeoPeVRDNDNKg9Mq3kuaU74Bc2vL/l0I+t1EsbccJeD6/1yx9RHjT9Tt3yYQxstQAFxtdcAZ9dnD6C84= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768168790; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=7t6nw/UxLr3T9liZ2npxtCDDAh6coiuxkrxLk4TiJc0=; b=nqRNQxNVRqjs2mPZsRpEVK7cx5fJV2xUkXXR+gBNUO8mUJXXFuZvTsPzvUsetB7+594PckL3N48WeDw8Yr1qil5w8Ngo2YLIfbNj2oEu4nQVKsNz0UUsW84NBGmMkYfoZRKbQyrQz1OfQmdYKaNC/d2IiMP6FT1jPVf0wTsrWQc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768168790224193.5946019637022; Sun, 11 Jan 2026 13:59:50 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vf3SC-0005IS-FZ; Sun, 11 Jan 2026 16:58:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vf3SB-0005I7-Jl for qemu-devel@nongnu.org; Sun, 11 Jan 2026 16:58:31 -0500 Received: from mail-pg1-x531.google.com ([2607:f8b0:4864:20::531]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vf3S9-0003ps-Vw for qemu-devel@nongnu.org; Sun, 11 Jan 2026 16:58:31 -0500 Received: by mail-pg1-x531.google.com with SMTP id 41be03b00d2f7-bcfd82f55ebso1941437a12.1 for ; Sun, 11 Jan 2026 13:58:29 -0800 (PST) Received: from stoup.. ([202.86.209.61]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3c3a31dsm155272365ad.9.2026.01.11.13.58.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 13:58:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768168708; x=1768773508; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7t6nw/UxLr3T9liZ2npxtCDDAh6coiuxkrxLk4TiJc0=; b=cYF1MWSM6XIBpLUje+KXkBKClXZQhYdnINjnGE0eEGXmDTbfEf+StMvMwTPON72mPD AtJg3WG8u1nbZbI/oAOuZ+lTh3yTKNebn2PSGkptUm8sSDD3lI8WHTtUUHHG+2Oxj/4j VL67uNoCdok55gYSh/rr3TN97AyTgaaZSDP+b1vlykmVacmUnEW2sSg5c4hoS0mCYBq1 SXp1DDpabn2CW9o9iobrBHaCAzF5fJLu1Q01UuZMww2i2CRghVn/4J+Ekwc2fq6dYRAC tA/9NysqINgoZpRuXUu6ODdN0eRhxiHbZ5fcyVpRQdkbRCToS16gdNdAvWIacMDymWYC WWxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768168708; x=1768773508; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7t6nw/UxLr3T9liZ2npxtCDDAh6coiuxkrxLk4TiJc0=; b=InFRSo1NOgrNyJqI5QPcXGy0MDx/Rlq0xSZtahVNVM42SmrFe2PfC4zR0+z59GbLf6 kTZ8Z4KYyZi5ZMoq6AXQVZyowK9vnd2SRLTzcF7Fqt6Ct88gsQ0APGa0VT1Iptzz1BSD 6LH40hH1aBykbX/TSnRKW5CAd1zsjHYfymTF1Nr7gd5Y7udB642a9E5wevszlcPgRbW4 QZwxshXrCpYof8nMLtGtiSYDnOywOLMMsuIAULGNyZ3Ckc+00kKP8TXCp2UVtMH4awk4 F00PcGxGesrMf2KfNAiLp8qb8v7ruV2H0bOtmxkDUzC5vxJnPzN0czw4SSngWLKNd54X aJVw== X-Gm-Message-State: AOJu0YxS/ONcFakhroBwwwHg77Wwhu0xMxDQ8WtS3DRRGcD25oWN88ef yueXeBwLLuqH3SYy38bMqDr6sMV+x+q65Osd4ttixgbn4ytb9kgHJoNz7Lz95L19DYBxbQJGv9n kcj/UWKI= X-Gm-Gg: AY/fxX5xmT7PR/wEBkz2oUMI1u1+2Z6pc+ivjmHRQtJKyzOxKf0YZfIl/v4I7XChymL iNHVonhYu1Dtaba0q3ON6yeQ/XGVmdqZwcxGAkMmBuLY9FD5hSFLwL1DqvWQI+PwqQcXp1lzyW+ D9KCzZM0xn2AymQ5JyoDIRsqCGFANNrvwqapAXdBBtABfLmFuWqiGBK9ciFEy706b+L5vngthcS nTRnkQjnYmbdcI9yrEwtQdFFbaV60s1ooVO722LJ2uDUB0vAo2aYH/qa1Sk1h0+GMRBxJByx/Lt /dzRfVnP4EHLucRh0u7t8rqgONbWp+hreMg2g8ZdMG7qXkmgxoo8PzNlop6hdVh7JPW2mJKO7Fi 6yAbyeWmztEB7+2pcjDYRRrM0R/Suikumfn52MqqSYyNIEvfgtlHqkbxPI/WFWxz9rye5mBpi8w HHHgnC+756R/KG/Tw= X-Google-Smtp-Source: AGHT+IFnMIw/Ex0rYkycWspwa+H8hW2C7c/OqLWPVPP8ld4TEqlL5WfypXwLSTdsLOugzOkfGJrGkQ== X-Received: by 2002:a17:902:f606:b0:295:28a4:f0c6 with SMTP id d9443c01a7336-2a3eda6542bmr170960435ad.0.1768168708356; Sun, 11 Jan 2026 13:58:28 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, Manos Pitsidianakis , Pierrick Bouvier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 01/13] tcg/optimize: Save o_mask in fold_masks_zosa_int Date: Mon, 12 Jan 2026 08:58:06 +1100 Message-ID: <20260111215819.569209-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260111215819.569209-1-richard.henderson@linaro.org> References: <20260111215819.569209-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::531; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x531.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1768168792310158500 When adding o_mask to this function, we used it in a couple of places but failed to save it for future use. Also, update a related comment. Cc: qemu-stable@nongnu.org Fixes: 56f15f67ea1 ("tcg/optimize: Add one's mask to TempOptInfo") Reported-by: Manos Pitsidianakis Reviewed-by: Pierrick Bouvier Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Richard Henderson --- tcg/optimize.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index f69702b26e..1f95da487b 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1088,8 +1088,9 @@ static bool fold_masks_zosa_int(OptContext *ctx, TCGO= p *op, =20 ti =3D ts_info(ts); ti->z_mask =3D z_mask; + ti->o_mask =3D o_mask; =20 - /* Canonicalize s_mask and incorporate data from z_mask. */ + /* Canonicalize s_mask and incorporate data from [zo]_mask. */ rep =3D clz64(~s_mask); rep =3D MAX(rep, clz64(z_mask)); rep =3D MAX(rep, clz64(~o_mask)); --=20 2.43.0 From nobody Mon Feb 9 16:03:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1768168761; cv=none; d=zohomail.com; s=zohoarc; b=mmqRE9hY2Sn4Jqwhb4P1UQFdNnOU1mkCn1V/hYSFs+2jjNy1Dke8yxO2whuQyjRHunHmfmG0EuyAUpyfxQ+BigAHrnbw/SwLHseK63ew/qz1cYFVoSeMccx2EzKgszW0RhfwFAgsd7RJXoY1fuYUdkYRLW4HpQWYwdTwLXVgEvc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768168761; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=9gUDBYmRE/wZQT2imf8AjVvWO7YLx14zwpMuc1zAE/Y=; b=EWkzO/m7z38O6C867iWO5pfzBmS/YiKyMFFVyRC4w9uRc1kVOTmw615YWD9qrMT849khRT4pL5SsXLIVdWU59ChahMZygrE86IXi9oq35YdFWLgmLZLdg/3LhU/9+1Yiv0gt9ChLeGXyeTSyQ1AaRU5nnPgoxBSezUAeA6EDkrw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768168761210992.305396982762; Sun, 11 Jan 2026 13:59:21 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vf3SG-0005Jc-6R; Sun, 11 Jan 2026 16:58:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vf3SD-0005J9-RJ for qemu-devel@nongnu.org; Sun, 11 Jan 2026 16:58:33 -0500 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vf3SC-0003qI-DR for qemu-devel@nongnu.org; Sun, 11 Jan 2026 16:58:33 -0500 Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-2a0bae9aca3so38068175ad.3 for ; Sun, 11 Jan 2026 13:58:32 -0800 (PST) Received: from stoup.. ([202.86.209.61]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3c3a31dsm155272365ad.9.2026.01.11.13.58.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 13:58:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768168711; x=1768773511; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9gUDBYmRE/wZQT2imf8AjVvWO7YLx14zwpMuc1zAE/Y=; b=xrYSRUmo/+YsERzrQ1cu9F7d/RUOUYxrMjYgYxxqkL3/BykfFS4oqz1ZlFrJEzH5YV +/C/eUAfMQhJzDLZulyTw8PIaqYXbyBx6Yj02VMFFCohTl7kXlcbfl/ciO7eI0Goau86 tRsSWgpJvjqJeDf5rJwxHfP+wXro1PyxJuP4x43ALy12gmP7P232PkLkwH5DTU2y4rGa nvXl420IPRgmpssUQOOVNbOXVOG4yKcar4qm9UUfSjjUrW+aDvGyBUtFqYzU2IfV4d6h nG9P7AQY9opsLrSM4Y3R2uh02eV7AExqZmdhMw2Hf+GoifvjoifMYDcNjljNjXaMgSem LxzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768168711; x=1768773511; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=9gUDBYmRE/wZQT2imf8AjVvWO7YLx14zwpMuc1zAE/Y=; b=YD3LcFMdfqU9om8i0zcS003DYkKbLyCDNy6dQJBL0ltNIy8a0DsAi41Lyv7HuCXtRJ +vxawb18WZPEkWgdyNuFGyaFUt1GPQu1ScjLil/kN2Lz2UehQ2sf1K+vCwVwr2Om01hY XZE34tMxyUQFZs2HFeUY18494k/Bt3yNfziHEEym7n95E+ihtqZJRKQ6TqNC8EM5J9W8 Kh6txbG/GmGHeHfsZbDx82YrM1nTUmBpMfu6fJDIr3aOgo/Qgg4NFtl85ItgAra5r75j iKk6ECWZiGQqLSXzGkS3le3eh/Ba35OztPnr21OW1wOc6EnKQaHV1CF14aQfTsuiIXv6 Y1Wg== X-Gm-Message-State: AOJu0Yw4gQpFFtF0le+Avue/991eycaF7ft6QQmoYn2hnC5Ms/YwSJ2C DT9s65nlPLAnHuJkjvXkg4BiktT5dqjjAkZUc8au/X5m0L1Jw6S3xeulegaAxb1QQqFPXO7hhOD Jg1hE1Q0= X-Gm-Gg: AY/fxX5fViWOj2K3JT1VBytGEAqt+QwkRDuH18D1iKd8zzxX97P4zMfs1Rs/paUgWZw QxhOkf7i0gt0fcrHl37dyxRwjQi/XmDL2PpRa0SLsn2vv/JZfYJupOxpd7lYWYveiuvqOPbixe8 XbCehLjDmhQy90v6RBl7lSCLc3cm1GMfglTqInjuF4hAeahxHLYGeLcYoqC41w6NcvcUAla3TFV 0GeAaSm0NngQv3quKQJjqix6Nfw6ytzDbl7JhnOVGdb+iXMKhgajpDkbMUadVgU0HJLYZjUA1tY hd0ZQY5daVGmLI3G6FCbSBtdLh9tcS/3cOV6pqOTuV5T2l+TRw/l7YkiCyKMC55gYvrQLAEbou4 8n6pb9Inh4MmvBD6gh4AmvjdJ8oUadKflEHcV6ZTyPoHA1VeBd2rf4OiVm6ehmZXXmNR8B8DgRk DBodoLQwrdlPetc01lmydgCRIiLg== X-Google-Smtp-Source: AGHT+IHLDMhxQDmQ+XzLFTY2UjuwupVE3Gda+hgkYCBj8l8pzWsEKB19JNoO2GvACRJ2+hBTmteUDQ== X-Received: by 2002:a17:902:ef50:b0:2a0:b7d3:1bf4 with SMTP id d9443c01a7336-2a3ee438a24mr179061745ad.5.1768168710930; Sun, 11 Jan 2026 13:58:30 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, Pierrick Bouvier Subject: [PULL 02/13] tcg/optimize: Fix a_mask computation for orc Date: Mon, 12 Jan 2026 08:58:07 +1100 Message-ID: <20260111215819.569209-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260111215819.569209-1-richard.henderson@linaro.org> References: <20260111215819.569209-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::631; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x631.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1768168762993158500 Content-Type: text/plain; charset="utf-8" In computing a_mask, for or, we remove the bits from t1->o_mask which are known to be zero. For orc, the bits known to be zero are the inverse of those known to be one. Cc: qemu-stable@nongnu.org Fixes: cc4033ee47c ("tcg/optimize: Build and use zero, one and affected bit= s in fold_orc") Reviewed-by: Pierrick Bouvier Signed-off-by: Richard Henderson --- tcg/optimize.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 1f95da487b..db1d89396b 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -2360,7 +2360,7 @@ static bool fold_orc(OptContext *ctx, TCGOp *op) s_mask =3D t1->s_mask & t2->s_mask; =20 /* Affected bits are those not known one, masked by those known one. */ - a_mask =3D ~t1->o_mask & t2->o_mask; + a_mask =3D ~t1->o_mask & ~t2->o_mask; =20 return fold_masks_zosa(ctx, op, z_mask, o_mask, s_mask, a_mask); } --=20 2.43.0 From nobody Mon Feb 9 16:03:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1768168792; cv=none; d=zohomail.com; s=zohoarc; b=UVgJtsvzBDS+RWYKMX0cYt52AKlXz00mORnMjswssRDU3DfEw++GnnKykCrdzBXct7DcM2V9FLRfkwX5rxLu8Epa2LCvv4IEa/D06FxOhIquvV2CYkS1Q2zoH6eTL7B/m4XpTV/aTNVXCGA4zWGTTFg7vjSwExlOqSWo9IoPe8s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768168792; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=R7bUhjG5kmt8fzBfivCYU74VwPrNWZoXlTmfqsg4KSc=; b=IjQ3ureF66GnjdUkmDTgBw5IzpsT5GlLkLaiXzum6MEkCWVOGfXtP1NR+QIWY40HSNBt+ZGW/608NFEF9Dp85YyfFBsfRxYuSD1SVduzRq7P2vrYy/cuvt0afCeszaCX/DJYQPeysj/LB0XxPoM66klYh8yXBirJ/46wz7pvzXY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768168792304492.91553343577107; Sun, 11 Jan 2026 13:59:52 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vf3SW-0005Nl-K5; Sun, 11 Jan 2026 16:58:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vf3SH-0005KF-Il for qemu-devel@nongnu.org; Sun, 11 Jan 2026 16:58:38 -0500 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vf3SG-0003qf-31 for qemu-devel@nongnu.org; Sun, 11 Jan 2026 16:58:37 -0500 Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-29f102b013fso56050955ad.2 for ; Sun, 11 Jan 2026 13:58:34 -0800 (PST) Received: from stoup.. ([202.86.209.61]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3c3a31dsm155272365ad.9.2026.01.11.13.58.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 13:58:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768168714; x=1768773514; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=R7bUhjG5kmt8fzBfivCYU74VwPrNWZoXlTmfqsg4KSc=; b=h1qjihBYtN2lW2Uwl8L7HP068QOilkd/rmyBw12WgS3FCtSA5vosvc1RKAuUPUkoSf 99d0D7bqMHALbOflg1nluRZ5R+82pMQrnnItLjh5FeRxZezpcL07dH20n9LkWpLfIB+s 2ElsRLwDoVyWf7Dw7ujms5nmPaUerh2YPIi+7D5LDt0iQL+zi0eO0A/RhyiFeN0bGDOz 6Z7zjArXipkYPs8+kBRab99515WMYnZW4s+31U37BmRtNwM7SNLz8k27Kq/5BU+xjoo2 70EIj+RzWe6FH5zts5jvrpTVDsGXMyi8ze2WclpMLhuTd92sUtXqkgcELEvvhZVSvv70 53yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768168714; x=1768773514; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=R7bUhjG5kmt8fzBfivCYU74VwPrNWZoXlTmfqsg4KSc=; b=OKy/MNnfAJGHdXFe6iT2FX8qEzAgAIRyOlLw4LDsut1EgaWoGAG9zXLs3tqSp+9qwm B5s5sBD1EUvehLHbompRFj2Mxw8hn5CTJeePeRccbpA96njiNrz4G5X21itt4vSYv7A6 UeqIDQI2229EsfP/9Arb2K5IBTm6jnCOzbAJsYPSf4HGln5UeKV9/zOhYpxc7urKHlI6 x5SVRr+eW2JY+IcgmLPlnI+Sg/uY4o1v1e7lbNlDf1zFC/J1Afe7FyeK2Xjx2PRh0Q+b DVCErTUI9BBhh0bvk9JMKiLuCV0cG/oMaCtTB45nxvODTK8GVwxdZhJFy4d9cZHNuxyl Mmfg== X-Gm-Message-State: AOJu0YzBHoIrP/GN7fOVvxTB/pE78IqsMIDwTCmgHRU3+ewmbJ/CI98z luMFFVRZuMFN9Lx52xwjR7rDUpkb/8lLYsxRhBSj0UFEoisjDvmro8GoRJjGoBxmyVavpsHnihW 7ZbVl2qU= X-Gm-Gg: AY/fxX5GpH7FDPhSrVi+bHmr4nKoei5ARJhhxuQJhKoiipibFZ3JBU5a80oU3Yj4SiB DruXdxUDyQf6aHVgsTn19gOGFfisM30aGy/ZC7XcSWIgx8unDVL9HcUzaVP/uuJW8/P1TjoJJxd 0mI4qWS7zHsSTF2Kb2sqMIumFLIvTYCA5LErwjytKlpG6AMU5tNYSVNvh62+OSX2ru4Lid5Kj+R XoKxsVGqbaVKNpDOJXIm6G+khW6NegKQfLuCGj/2BcJPdJaT2Ymu51G4M8/DqHR2KEzFx/dEGH4 Skc22Wa3mA0eZSZiCclHwKBttbb69rgFtfJ19SENpTv1VY/lcTK6EtbrhQRpFyltWoLeWRo/c2z UgHQVCUz7hx6TtyELMETAm3L97rksHeOSBbH7zlfWAG1bhfPLoGt3nIfhwPDt5U2g7xE846slc1 v3uMTGh6U2Y8Pp/I8= X-Google-Smtp-Source: AGHT+IEMBwzALb1eOZAnGxGp6+biNRKQN3m44QN2gviEyS91ybNDI0Ug/UFA8fO+HAFIMRyhv92N2g== X-Received: by 2002:a17:902:e784:b0:298:5abe:4b1 with SMTP id d9443c01a7336-2a3ee4c11c5mr158799065ad.52.1768168713576; Sun, 11 Jan 2026 13:58:33 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Paolo Bonzini , qemu-stable@nongnu.org Subject: [PULL 03/13] tcg/optimize: Do use affected bits Date: Mon, 12 Jan 2026 08:58:08 +1100 Message-ID: <20260111215819.569209-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260111215819.569209-1-richard.henderson@linaro.org> References: <20260111215819.569209-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::629; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x629.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1768168794314158500 Content-Type: text/plain; charset="utf-8" From: Paolo Bonzini We inadvertently disabled affected bits optimizations on operations that use fold_masks_zosa. These happen relatively often in x86 code for extract/sextract; for example given the following: mov %esi, %ebp xor $0x1, %ebp the optimizer is able to simplify the "extract_i64 rbp,tmp0,$0x0,$0x20" produced by the second instruction to a move. Cc: qemu-stable@nongnu.org Fixes: 932522a9ddc ("tcg/optimize: Fold and to extract during optimize") Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson Signed-off-by: Richard Henderson Message-ID: <20251223163720.985578-1-pbonzini@redhat.com> --- tcg/optimize.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index db1d89396b..5ae26e4a10 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1103,7 +1103,7 @@ static bool fold_masks_zosa_int(OptContext *ctx, TCGO= p *op, static bool fold_masks_zosa(OptContext *ctx, TCGOp *op, uint64_t z_mask, uint64_t o_mask, int64_t s_mask, uint64_t a_ma= sk) { - fold_masks_zosa_int(ctx, op, z_mask, o_mask, s_mask, -1); + fold_masks_zosa_int(ctx, op, z_mask, o_mask, s_mask, a_mask); return true; } =20 --=20 2.43.0 From nobody Mon Feb 9 16:03:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1768168811; cv=none; d=zohomail.com; s=zohoarc; b=b4xHUTHgUeTDTckZ65MmcRAHuEVxCaGCFf0CTHZ6rJzBc1rNllvbm30mO58+Fs0k4hMqDMYc4XOccZTYmkSrwX02f1rHajuVqrwW4eVIMG5Tg0dHxo75eoivzQUzPab/esTsS3BgRvbiT8jAl3QfO0FZFH3Ln7sJ/XgD0ph1Hr0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768168811; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=BpSHIWQQ8x9eIJTo+o+MCuWeunb6JYZPGxKktINRqfc=; b=lJXr1nsN+rhpRAeN0vhrCv8rNtKGTJovdsyYH/6OzRcML9Xdn8f7SogcKtRL6tu+ZWOMf/62lQUQmfi0RU1aVImd7U1XqRZAteFSyBMtL7jqurvs5QSjAFV561ccwC5/3EMQ7RTmKh1rrum1AdtlU5ckt3fkSLvya7H7fGnBDfk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768168811075842.7397260423284; Sun, 11 Jan 2026 14:00:11 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vf3SV-0005Lf-Ca; Sun, 11 Jan 2026 16:58:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vf3SK-0005KZ-5G for qemu-devel@nongnu.org; Sun, 11 Jan 2026 16:58:40 -0500 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vf3SH-0003r3-PF for qemu-devel@nongnu.org; Sun, 11 Jan 2026 16:58:39 -0500 Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-2a137692691so38701545ad.0 for ; Sun, 11 Jan 2026 13:58:37 -0800 (PST) Received: from stoup.. ([202.86.209.61]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3c3a31dsm155272365ad.9.2026.01.11.13.58.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 13:58:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768168716; x=1768773516; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BpSHIWQQ8x9eIJTo+o+MCuWeunb6JYZPGxKktINRqfc=; b=p8nEEVwO4ezk+DgcFbpPQCBGCXiz44+3u7S9KB1t73JfYXv0qorJg5nP0/rW6pkNBX CqP/Jad/OeOr4d4w0sWc4BDBbX6//R2R++mjaBZag1f1TADjbV7cr/IG9UH/IZaGBvzz LQ28hreESnXjH6Tzr1B0Fy4/oo47XGWNChD4BbIyBjOVK13twqBEmS2i9beL5twWMky7 bJDXL2LeZVOiE/qnFuBlzlPBQBIa9tEf65ywIG92uCv/Eo2AXV2yw7zspyOi0XdYqhLp sL84yccZHOldfb5yz+mlVvYT4Nwnbq3T0WdiqFratIGZgtovQvXgy5w3cu2ZGHFIaImn Jk7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768168716; x=1768773516; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BpSHIWQQ8x9eIJTo+o+MCuWeunb6JYZPGxKktINRqfc=; b=TMYdtyn60lx3CGXZGQ8y72oQ1/9F9dRx4pKwFvurqMLwmyyvoTxzkmeOGohn+xYSp/ r9Ls6XEV1QzfVRJ9WcGTLNBHgTg91JVL2yduw7rwQyLp0ngxGX/VAaCLEh6B4VYaPMKV eBlFnVtmrr1r1EhoqwrOExYAA8E+7r7g4tBorvW7guLM6ypYOQbCTm/LMVN1IrPr4wFW gdhbD5zbliIYTxOf8y3OtvNHhV0TI7ITyMVMERmh0OcWI2j8j6U5+sSf0mW7GUT0ohei lZmCYTJVnSRQA35nT2pVB0fp83gkClHeANd+iPjjzv9UBd5V/KCICB9O9pkH339EdKHq r0qQ== X-Gm-Message-State: AOJu0YxGcR677N3e/wCKEMsaRLR8XaUHw7M+Xc6B5morU+004+jOYRHe wqHaC3gmPM53oRN965JNBtAAbxtyZmX8UKUVmxUYKjt9T8Z7E6woIfXh/RvW7ny3Ie6INyzVI8d CFMVkDJw= X-Gm-Gg: AY/fxX7jKx/Q2moC8/NcmjJBBHEpwM8r2roJ45Kp+yfCRgoaoRN9x8lUmOGgILraovw 1zA5Cm4GMuO53xe7MngYF9M+RPAlhL2IQUqTFLQORLc3ffyMay0tNF+sHX8AeFELID4q6FqKoiu 7mbJJsuqUaNB6FHGS6HkHDwCfbs0Pxst8JTkiAbnHWv/SCIISrjDLQcvqLafMTwjXgRw1y8q9ip gCKNT1QvShIUHNE4r38FoSMVPjVeZ4aHJYnA31xnqvuIBm/wRCn52ZKYU2SUzp+Hvalico32A2o xMPSpRdzeaiqhQrkRjoBPEYbAArvyIdfzTDL5F7YpbzcbcqQTB0qqincInYPISz4cUjGDc4/V3j 6lHlYShSKTrKzM7kIU3ogWoAYlflGLmoXw05DOuwW5g7VgxjemHyHp9hANaMDzOJjmNXFeVEchc MOBpYZw/XI+vtvAJs= X-Google-Smtp-Source: AGHT+IGNt+0Jl8uu3qyE0YRsm6P47B95trxtelKxi6ARj3ce/EmytsjH4kQee5bpvnx4iaua8+Iaxg== X-Received: by 2002:a17:902:f68e:b0:2a0:941a:6b08 with SMTP id d9443c01a7336-2a3ee47d754mr162761725ad.21.1768168716353; Sun, 11 Jan 2026 13:58:36 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, Zhijin Zeng Subject: [PULL 04/13] tcg/riscv: Fix TCG_REG_TMP0 clobber in tcg_gen_dup{m,i} Date: Mon, 12 Jan 2026 08:58:09 +1100 Message-ID: <20260111215819.569209-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260111215819.569209-1-richard.henderson@linaro.org> References: <20260111215819.569209-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::635; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x635.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1768168812626158500 Content-Type: text/plain; charset="utf-8" TCG_REG_TMP0 may be used by set_vtype* to load the vtype parameter, so delay any other use of TCG_REG_TMP0 until the correct vtype has been installed. Cc: qemu-stable@nongnu.org Fixes: d4be6ee1111 ("tcg/riscv: Implement vector mov/dup{m/i}") Reported-by: Zhijin Zeng Signed-off-by: Richard Henderson --- tcg/riscv/tcg-target.c.inc | 33 +++++++++++++++++++-------------- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/tcg/riscv/tcg-target.c.inc b/tcg/riscv/tcg-target.c.inc index 31b9f7d87a..0967a445a3 100644 --- a/tcg/riscv/tcg-target.c.inc +++ b/tcg/riscv/tcg-target.c.inc @@ -1074,7 +1074,7 @@ static bool tcg_out_sti(TCGContext *s, TCGType type, = TCGArg val, } =20 static bool tcg_out_dup_vec(TCGContext *s, TCGType type, unsigned vece, - TCGReg dst, TCGReg src) + TCGReg dst, TCGReg src) { set_vtype_len_sew(s, type, vece); tcg_out_opc_vx(s, OPC_VMV_V_X, dst, 0, src); @@ -1082,29 +1082,34 @@ static bool tcg_out_dup_vec(TCGContext *s, TCGType = type, unsigned vece, } =20 static bool tcg_out_dupm_vec(TCGContext *s, TCGType type, unsigned vece, - TCGReg dst, TCGReg base, intptr_t offs= et) + TCGReg dst, TCGReg base, intptr_t offset) { + /* Note set_vtype* may clobber TMP0, so do that first. */ + set_vtype_len_sew(s, type, vece); tcg_out_ld(s, TCG_TYPE_REG, TCG_REG_TMP0, base, offset); - return tcg_out_dup_vec(s, type, vece, dst, TCG_REG_TMP0); + tcg_out_opc_vx(s, OPC_VMV_V_X, dst, 0, TCG_REG_TMP0); + return true; } =20 static void tcg_out_dupi_vec(TCGContext *s, TCGType type, unsigned vece, - TCGReg dst, int64_t arg) + TCGReg dst, int64_t arg) { /* Arg is replicated by VECE; extract the highest element. */ arg >>=3D (-8 << vece) & 63; =20 - if (arg >=3D -16 && arg < 16) { - if (arg =3D=3D 0 || arg =3D=3D -1) { - set_vtype_len(s, type); - } else { - set_vtype_len_sew(s, type, vece); - } - tcg_out_opc_vi(s, OPC_VMV_V_I, dst, 0, arg); - return; + /* Note set_vtype* may clobber TMP0, so do that first. */ + if (arg =3D=3D 0 || arg =3D=3D -1) { + set_vtype_len(s, type); + } else { + set_vtype_len_sew(s, type, vece); + } + + if (arg >=3D -16 && arg < 16) { + tcg_out_opc_vi(s, OPC_VMV_V_I, dst, 0, arg); + } else { + tcg_out_movi(s, TCG_TYPE_I64, TCG_REG_TMP0, arg); + tcg_out_opc_vx(s, OPC_VMV_V_X, dst, 0, TCG_REG_TMP0); } - tcg_out_movi(s, TCG_TYPE_I64, TCG_REG_TMP0, arg); - tcg_out_dup_vec(s, type, vece, dst, TCG_REG_TMP0); } =20 static void tcg_out_br(TCGContext *s, TCGLabel *l) --=20 2.43.0 From nobody Mon Feb 9 16:03:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1768168828; cv=none; d=zohomail.com; s=zohoarc; b=SIXUwV1Kow4qxWk52Nr3dNZvqYxIsyYpiJXBawFTpDzwkdReXDOLGyoTjWviMRsJ5lJl8vVAEvML9yZjwKPKR6AiFxSM9LdHfYpvqvfCMHDp1ojJEDLSvx+DMlMZYB98oDnbz/Ja2hT8EfFzK8SEXiZtJgn9gMLgXmu/dtywCm0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768168828; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=7WU9noscw5cu2FvkNQz+IaG1JpungMpnx4UvU4kIi8U=; b=MmQaThMsMScYpwQ3lsa6RGzMFlrXq6EWcp5ir7ei3syncs1CmHY09WIgqBlNuvkiHqHVUGaXCbN+5//nRWfGUjdxPt4+QA69LwXR1ozZpLAsnGpTprnYu+XEB3bTwwUlz7En4N9Zfp/xBtioYroO+Uzd/kRrnGg/Tk0QkW1DRgw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768168828424230.40536315077213; Sun, 11 Jan 2026 14:00:28 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vf3SW-0005Nh-HX; Sun, 11 Jan 2026 16:58:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vf3SM-0005LL-Ak for qemu-devel@nongnu.org; Sun, 11 Jan 2026 16:58:43 -0500 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vf3SK-0003rj-KU for qemu-devel@nongnu.org; Sun, 11 Jan 2026 16:58:42 -0500 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-2a0d5c365ceso40055155ad.3 for ; Sun, 11 Jan 2026 13:58:40 -0800 (PST) Received: from stoup.. ([202.86.209.61]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3c3a31dsm155272365ad.9.2026.01.11.13.58.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 13:58:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768168719; x=1768773519; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7WU9noscw5cu2FvkNQz+IaG1JpungMpnx4UvU4kIi8U=; b=ng0dZFuq61lkzoWTj103/jRNHh/QHIn1KFQ4aVUJgnEwq3UJpntxMnH6qcSuv8oTNI JcZbTsNOhwNnBXKADFs50n7e9ERu/UvRI57IPas6eyT3t+5kAjq1reFMrL8AmuldSgYk dOcKVOSo/DD4R5tHa/qTBYIThp7gqXp57izfVCREfaZyI1IZeNX1JReTaEZ0Vl40NTDc mczqu4/C8GDxXTKOneemaBi4b49ATI3y9RDfbdTvE0ASRgY8WDnQWX5XtRBYa99lZxdU MY34W78a7DPcJnXQKuqd3fWpq8JTdxEIUPd7cFfe6u1kwArdhpr1b9niCcjFDjJvZ7NX 4buw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768168719; x=1768773519; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7WU9noscw5cu2FvkNQz+IaG1JpungMpnx4UvU4kIi8U=; b=Y7ZZYTHOTOgaAR/aCtUGYNutMqa0dYuBWPARE1KqfhtPhO7cYdYCJZRAxAoCOGTQ9c 3p/XiBWhesFfzjqpCMfcQTvSS6fmQkg1fwj/ZyXGCq8CTKZKDi1v7MarrZS+sc876P2k UWDolGLRQly/NkvCloTfV6nhGFP5fghGqH1v76AAia1qMNSl/d9nvUZ3PqX3X0JHauDr 9Fs3yXLTXeYNWXuWXo3lTwXKOEslOG5cjk+h0NdFv7HTSTu7JGbUX06WwXQtZNNZG5Cz LbDiRnxCUy6AcDx7i8qaBc2beSU7v1oj14Y0j6V/oAWuUctwk4ax4w7Pqr5otS5RrS5P gTfA== X-Gm-Message-State: AOJu0YwbvW5VLxDM/nB388C7ZUTnoqTeMwH9l5t9lYR4wep2WoOthkUk /2OwdCV1E5HN6hMazZRSWpOc7FaMsVV9IY1j28Et5nqs63CeEiVJACU9rrHXcbhcwJM0FddtO2t +NxKGsS8= X-Gm-Gg: AY/fxX4TSwT/6YhTE/eMb/FLBOIR4EM/xGntlkOM8IvxbgJ34bLiajjBs2420tK3MlF mKpwS1KskLP1z66vwBCyrgUr0tSPd1XDZsYekD27iV7OJG4YR/1zqU+oInd0zhLekgbobinfQBp t329OiMg6xj/EDH5Tm0HD1vT1fzyx5F1VYkLgve0BxnolCSCojkApl/BTy/bfcl8ejnHC4dXNB5 IQkrCkv5CR1Y20s+Pg718MCQl9Z0eKN4TOf95rK47ukasH+0YVAryy9VMQogWmtUg9/y/p0Swiz YJ/mXYac8mBHeI/yiWSm5NC6+ztvBK0bVaECJfaZpWeJ5HNU+V+AfI48lQPO5bijMj0epiucCe7 okqIFwOr2smepjXDjLcJA9EfHAxt0sQ+fuDPDwyxvckaHQMz4mrAD12waaLND/YASoJflc7GRDC kfEywIG21g61RurRdwZOZT9x8O4g== X-Google-Smtp-Source: AGHT+IEerdqgdN8GnGZUht5YTwUffw3px/4VXHMiSaHJN/5tJmkGwDfnAhsAnBmbsLV9CwkaEcK3RQ== X-Received: by 2002:a17:902:ecc5:b0:2a0:a0cc:9994 with SMTP id d9443c01a7336-2a3ee4d9312mr164280545ad.47.1768168719108; Sun, 11 Jan 2026 13:58:39 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Jean-Christian=20C=C3=8ERSTEA?= , qemu-stable@nongnu.org Subject: [PULL 05/13] linux-user: allow null `pathname` for statx()/fstatat() Date: Mon, 12 Jan 2026 08:58:10 +1100 Message-ID: <20260111215819.569209-6-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260111215819.569209-1-richard.henderson@linaro.org> References: <20260111215819.569209-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62e; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1768168830465158500 From: Jean-Christian C=C3=8ERSTEA Since Linux 6.11, the path argument may be NULL. Before this patch, qemu-*-linux-user failed with EFAULT when `pathname` was specified as NULL, even for Linux kernel hosts > 6.10. This patch fixes this issue by checking whether `arg2` is 0. If so, don't return EFAULT, but inst= ead perform the appropiate syscall and let the host's kernel handle null `pathn= ame`. Cc: qemu-stable@nongnu.org Signed-off-by: Jean-Christian C=C3=8ERSTEA Reviewed-by: Richard Henderson Signed-off-by: Richard Henderson Message-ID: <20251229121416.2209295-1-jean.christian.cirstea@gmail.com> --- linux-user/syscall.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 2060e561a2..ee7c34027e 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -12141,9 +12141,13 @@ static abi_long do_syscall1(CPUArchState *cpu_env,= int num, abi_long arg1, int dirfd =3D arg1; int flags =3D arg3; =20 - p =3D lock_user_string(arg2); - if (p =3D=3D NULL) { - return -TARGET_EFAULT; + p =3D NULL; + /* Since Linux 6.11, the path argument may be NULL */ + if (arg2 !=3D 0) { + p =3D lock_user_string(arg2); + if (p =3D=3D NULL) { + return -TARGET_EFAULT; + } } #if defined(__NR_statx) { --=20 2.43.0 From nobody Mon Feb 9 16:03:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1768168863; cv=none; d=zohomail.com; s=zohoarc; b=KrwE/gM8dl49PB2lj6Unc95m0xnqzyge6zPElRGXiNNoIVMwRXDaIMQ5/fK3BrVhDftewIo0z+IkZlqS+t6J2A5q4Wj+OnhHEYO9J7iSt6gjVchXvf2YaFDTOyTAAxmiXYmB5xZzl9LYbzAdiGwuFclhAy5x7MJnarpzKZc3HiQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768168863; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=OHti3C71LUbVm5pSNWQt/BFwUr/ys/K/zILSxw8aQnk=; b=eY5PJv9z5fpMoLvfMTxB+2NHM2WRNqmEvBwvz9RJdVMKVsU47rDXggLFXY80agWWvPWGtEIutnkZEny2rVhIgEDZ+yndsfuP+IbdAAVF+Ey/k9aFIRtMUF38/OFR54JXK76moBAIc+bRt7uGKQK17e8Tm/oomqBRqN8xQC+9+QE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768168863718792.7922603835522; Sun, 11 Jan 2026 14:01:03 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vf3SX-0005Ny-7o; Sun, 11 Jan 2026 16:58:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vf3SR-0005Ls-GF for qemu-devel@nongnu.org; Sun, 11 Jan 2026 16:58:49 -0500 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vf3SN-0003sP-Nk for qemu-devel@nongnu.org; Sun, 11 Jan 2026 16:58:45 -0500 Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-29f0f875bc5so47662075ad.3 for ; Sun, 11 Jan 2026 13:58:43 -0800 (PST) Received: from stoup.. ([202.86.209.61]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3c3a31dsm155272365ad.9.2026.01.11.13.58.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 13:58:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768168722; x=1768773522; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OHti3C71LUbVm5pSNWQt/BFwUr/ys/K/zILSxw8aQnk=; b=AjfXhlkC9+8j0WWgo8KrFTPiidxb5xi9EB5CWUUtLizzztkC/X4cY6IPyU4ljoZ41A sFryu9hUDoV1uKPw6RbWT8DpNqqGL7hHvom2zDKXcL9/nGDcInffIRFbifB7ocoCuqd0 hwY0VZGGpduOBuxBq/AZhAmj1tDbMcTTSwtsWEdEZdrb8otOg12KnRFJf22g7cBLtdZY N3rsGWP5fk9QE0jaLSpnDeXfT25jE8ZGTXqBjAn5Q/uNPV9IZ4/THwpm6IFamPUZLtdo VlQmghZaTQe2qUAzsoTzVzpaEwYNJLGLL1jllKvcCpdWJB8osC3PIJb/w2b7Inq5NfDN SilA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768168722; x=1768773522; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=OHti3C71LUbVm5pSNWQt/BFwUr/ys/K/zILSxw8aQnk=; b=l/JD8RokbJT9cEoxY7amgK9LU/N0Z81iGkCJZAvC5TgoGivF3H7S42kMdudwIWDa9t S3ty47flt0ofT6VRbFK0Jq5D7Dja9uM7f4SYiO+N2f5IzjAldk714dz/OjLcWHzkeiA7 PqUTmLg2adFXjbmmLCHRVabfxN7VJpLDxC4U6FB5zINSX7R1ZVAmwik4fqlrFBcTjqgj q9xYQOE7uaqoWa37HRg9f22C6E4knTFMLpMwlKRkr6B/DxereAT6I0SAQ539xbs4wxfo oiNmj7jle4UP3p3LaZW0mmLyhcVvyKE4eaNEuNPViTHF8GYpaWA7gxeSu0Gj8eqBZBVD VJUA== X-Gm-Message-State: AOJu0YzW3CIuXeaQWUL2vUfIpkBVaiJVe0WHpe3PtGFnDDQTDTsxIlfB Xvr71tbNk43WKAiw3P+iEyNrvAtUJ5oA6WsPd1f9guWBYXkgao7Z0zHFMsXCD0BdlvuG2tjWRhs 3oBejnJk= X-Gm-Gg: AY/fxX4Jg66HK1xUDsZgrfkwULbl2uMigV0cyo/Zfe2fMWQKfEJc9evHfMs70HeSJkA bKja1W7ZRexCZzXIX7vzwQYOuDfm7rN7VWyLaYHkS781qYaaZkt2TJ/jTdvhos+UZ6vKCWEmR0e GNc/ljFGeUSmu4vdB2h0Jpw4ST8fmYOWnfF7X/gOe0aLteP14GOdR6cftbM7e1C+DTQjdYNJnro OrmifztQWkOiLDrgg/BaQqPf6E4GhBupKaShXyFzGhqAZCvSVj/Vnu1eW9b/n/T4v+8/rwGOygo 4oTnsVYM4DATvr977K8CRfNnGrqf6gS/eQulNQPyB0d19YJHCvL6qTs3fUu28NTst6SFHoaix5z 9/u+7bPRfSmLV/UlzsZK8XO1wAbj5drCjnuueB8yvbyTZZY3D5DxrE0v22okPQnlqru5JtdPmYL w125uNLNtxpj6z7aA= X-Google-Smtp-Source: AGHT+IFSUvgI7sLZEb/tSS4Wn1T4u3iZRHjJOYvGgkXyUIHd1IXLydx2vidLq9ev3NHxHJcZ6h0W2w== X-Received: by 2002:a17:902:d491:b0:2a0:b02b:210b with SMTP id d9443c01a7336-2a3ee4fe86bmr154410095ad.41.1768168722214; Sun, 11 Jan 2026 13:58:42 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Jim MacArthur , qemu-stable@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 06/13] linux-user/elfload.c: Correction to HWCAP2 accessor Date: Mon, 12 Jan 2026 08:58:11 +1100 Message-ID: <20260111215819.569209-7-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260111215819.569209-1-richard.henderson@linaro.org> References: <20260111215819.569209-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62b; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1768168864622158500 From: Jim MacArthur get_elf_hwcap was used when get_elf_hwcap2 should have been. Cc: qemu-stable@nongnu.org Fixes: fcac98d0ba8b ("linux-user: Remove ELF_HWCAP2") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3259 Signed-off-by: Jim MacArthur Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Richard Henderson Message-ID: <20260106-fix-hwcap2-sve2-v1-1-1d70dff63370@linaro.org> --- linux-user/elfload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index 0002d5be2f..35471c0c9a 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -708,7 +708,7 @@ static abi_ulong create_elf_tables(abi_ulong p, int arg= c, int envc, NEW_AUX_ENT(AT_EXECFN, info->file_string); =20 if (HAVE_ELF_HWCAP2) { - NEW_AUX_ENT(AT_HWCAP2, get_elf_hwcap(thread_cpu)); + NEW_AUX_ENT(AT_HWCAP2, get_elf_hwcap2(thread_cpu)); } if (u_base_platform) { NEW_AUX_ENT(AT_BASE_PLATFORM, u_base_platform); --=20 2.43.0 From nobody Mon Feb 9 16:03:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1768168815; cv=none; d=zohomail.com; s=zohoarc; b=MS3G1cj38Jvel71nsi+n/9syQuZ5BhkjmqUF9+i4yhWWU9bfTlxmI/iooEvcQ8/PTVgKphv54VBGI4pngTBewVJfoZUJ0KOF0fsONR6f8cGVYTb6s8qGiAi9wlKMUqev4nqVf+5PwJe+XTRpsEwlvbe8dSo53Gyvhe/8EGHxS+M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768168815; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=f5ww/TrGKj3Nrn5+V3rWPu1QkcqhU9+Qwg+gP5Flqv4=; b=B2cA9GBtuvnKuciuJujHa4NFqCeRt7QW8GimHR5w84r1kPDWqlc5mVcYk+C8b8LQDKA4WzoD9eRO/H0hfDEZcCnpeTqzu5/b7+Q4+iQPqJ1mtPriatov0cjbsTPKz3ROBsjauUYHIsc8MXTSYfV+cXrdhSUOJ0f4T/NnTh9K5jY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768168815275301.45275958117963; Sun, 11 Jan 2026 14:00:15 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vf3SW-0005Nu-QG; Sun, 11 Jan 2026 16:58:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vf3SR-0005Lu-IC for qemu-devel@nongnu.org; Sun, 11 Jan 2026 16:58:49 -0500 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vf3SQ-0003sc-6R for qemu-devel@nongnu.org; Sun, 11 Jan 2026 16:58:47 -0500 Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-2a0834769f0so40546005ad.2 for ; Sun, 11 Jan 2026 13:58:45 -0800 (PST) Received: from stoup.. ([202.86.209.61]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3c3a31dsm155272365ad.9.2026.01.11.13.58.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 13:58:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768168725; x=1768773525; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=f5ww/TrGKj3Nrn5+V3rWPu1QkcqhU9+Qwg+gP5Flqv4=; b=NChOnuMm84uTsNgDgIw5W77IXsSHCYmFyWK+N8XFkNQLNIn/ZBXtmz+A0aNmHYpfsN Qb3RGgVUvD/iAxh+va4DOsmT+GWubPtjFC6zaPGnvHBqa/QUG6Baw3QQMqnzgyomfy89 F1yV38haP1YY8zaiGo9nA2b1t39OSHYBC85B8OqTY7KO3IEr+jpOluSNyFWwNycnZZCC X6CxtXtffkLFOo6etjKUfIisLPr+mVoBctjdxuFinSSnsw8onoaDeA1AY9zKoo9ycVMv iq2tAEgsfgcbyhbsec0yOgDUkKxqicv6zdF25lDtOQvxNwb5no0mOTk8Kzp2YNJB/+0W CT8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768168725; x=1768773525; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=f5ww/TrGKj3Nrn5+V3rWPu1QkcqhU9+Qwg+gP5Flqv4=; b=Zy7IwUwcws5z0hFoOd1KqmKzIIOKuB6scShmJoRgmrK6IvK3jt2SzpG2VfM30gTT3Y ixnahvvmOPluJ/6YW9dAl+B5/dBaCsQS4bmaGrHU039YfNHqYcu2e0rLlpT6IVHF9PrC 3ymBJsd2BtfpZIyv5IkRvu5QdkTE6iyLGOecdqAnFa5ysfCCl4H/V0EbhcSQU34/51g4 dAKk60ydnrvP+nlpvrsg9hRGHGn/Vj9ht9ndTTxAs76XGMRvnvnQvtTTSt4TSOyBmq02 d8bx1YkOCV7Xt8MI3zvkK+p7OUdADLHJoX6hGwS0bRi/kAKwn00GvRF3FMgOyosupT86 bTCQ== X-Gm-Message-State: AOJu0YwKFEdgPf0/sf43xWKT2MApLWXuwCaQ9CwdX2MbhQ9uE0BSVF+L tMIcf6wD73iuqVMfobFeLDhMtRwv/dhN3Jv51U627gvi7jGtCjdRPe+Zz8HUwyu65NAWsg/na0f m/ozUutQ= X-Gm-Gg: AY/fxX7MP+knxJ9YQCvaHZ7djpb3W7BrdJAI/jkRwzpedhhW7PZSXVbCHp8rEhZsc24 yQfZQnI9JlK/z8Y3c59DM39a18G1PXddtMTLuF9mnmWdtzjuiyR4h4h8pcOHwEeo2wyXADXIEAL 52bQXtHr8sNS5pTby779OYUtKAqwt4A6d5AEo3UxcgxSH/MUyqYJFa6FVIidkTIMZxYO6CWUkeJ LGneZI6zffsmD5ChJg+K7v5h4R5GuKKIrp0knt6tygUIFse/r36ou2nNmel0ylkxdadgdH62/pj mkwhlT7z5afpAZ6s3S999ar4XAxnat23Iq82ECNY+/pHIOuM42j403dFEg/O/1GAQd3UvMJjuK6 Bp3UjAnOGpSrToLcGlY0atNUDpTF+ny+lZ+vyRK/I5bkrCBOFDNMcQyURaDiea2bZMaf7RU+Rd9 DttptqyYmoubBrdow= X-Google-Smtp-Source: AGHT+IFJDPQNtbJXHa3ghWtmzGLh1buc5SvxAxWWtGyR1JX7wgcUvfm/zqPKNtPWTW79B9TJJCc4aQ== X-Received: by 2002:a17:903:2ac4:b0:2a1:3ee7:cc7a with SMTP id d9443c01a7336-2a3ee43434cmr179988155ad.17.1768168724668; Sun, 11 Jan 2026 13:58:44 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Matthew Lugg Subject: [PULL 07/13] linux-user: fix mremap unmapping adjacent region Date: Mon, 12 Jan 2026 08:58:12 +1100 Message-ID: <20260111215819.569209-8-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260111215819.569209-1-richard.henderson@linaro.org> References: <20260111215819.569209-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::631; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x631.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1768168816487158500 Content-Type: text/plain; charset="utf-8" From: Matthew Lugg This typo meant that calls to `mremap` which shrink a mapping by some N bytes would, when the virtual address space was pre-reserved (e.g. 32-bit guest on 64-bit host), unmap the N bytes following the *original* mapping. Signed-off-by: Matthew Lugg Reviewed-by: Richard Henderson Signed-off-by: Richard Henderson Message-ID: <20251117170954.31451-2-mlugg@mlugg.co.uk> --- linux-user/mmap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/linux-user/mmap.c b/linux-user/mmap.c index 423c77856a..ef3833a2bb 100644 --- a/linux-user/mmap.c +++ b/linux-user/mmap.c @@ -1171,7 +1171,8 @@ abi_long target_mremap(abi_ulong old_addr, abi_ulong = old_size, errno =3D ENOMEM; host_addr =3D MAP_FAILED; } else if (reserved_va && old_size > new_size) { - mmap_reserve_or_unmap(old_addr + old_size, + /* Re-reserve pages we just shrunk out of the mapping = */ + mmap_reserve_or_unmap(old_addr + new_size, old_size - new_size); } } --=20 2.43.0 From nobody Mon Feb 9 16:03:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1768168814; cv=none; d=zohomail.com; s=zohoarc; b=Fc3WXTHgxbsERa09Jy4L0mXqArvQfBbedWGFFQtp9fLtrZpRU0s8ymeFe7pcFusKYoRr/Un9Zvz5zklxJYHjfYi0NhBkjHgG/tkA8HU7x+WJih4ry6cWbdF4i4alga1DsLk/HEUVW7XpJbw152TWosZaGU2V5hGLF0bRPU3bE2c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768168814; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=fqO9HbfMIwt05kz/abBQlPaxORHTbzUMkp2EwctPJB8=; b=g5HAk0JULi1ljZNt8JLz5MaevagFjIbUhbcEojSJYrmWwsh3ufK1EDeFzKpZrnB/zEShzhxsASsqov/IAr+Y0sQsQOMtJr4v/1tbniQtg2tgYsDPSJnklOznJSFBmZQskgdzgMOsgH/4Yvw0aaa88/nsN/KRH8DRz79rB+ybpaY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768168814344676.832813718595; Sun, 11 Jan 2026 14:00:14 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vf3SY-0005OH-0o; Sun, 11 Jan 2026 16:58:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vf3SV-0005N4-IR for qemu-devel@nongnu.org; Sun, 11 Jan 2026 16:58:51 -0500 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vf3SS-0003t1-IZ for qemu-devel@nongnu.org; Sun, 11 Jan 2026 16:58:49 -0500 Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-2a0d06ffa2aso42935775ad.3 for ; Sun, 11 Jan 2026 13:58:48 -0800 (PST) Received: from stoup.. ([202.86.209.61]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3c3a31dsm155272365ad.9.2026.01.11.13.58.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 13:58:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768168727; x=1768773527; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fqO9HbfMIwt05kz/abBQlPaxORHTbzUMkp2EwctPJB8=; b=vsD1fTV591CXj8sdTs4TWHhKOi02YgTft+pcS7ClESYhHUMlO7xnYNXGitCaVweEX0 ytilm0FFE7j+tmdltJczvhWxLhvdfW5YpIZKT0+OkYNxWowd/RnGNuo3p7YIgYditINt 3d8D3GF/txP/Nz/4Do3a55M/zGau+YfG3KLODP1OkE2b6K2nFRaEmvv8O+ExH4ZkXKNU VEqYpFBQKrc6XSIVzsHq+mHZL31PsIkOBQRNxiFV4YxAwoodttebYu/5VDSEtVrqvT4r XdYAcW17iZnNPB6oJ+P2BI0q12KhfBiUL6V65SWQpRI8lBTauskant6rA5z7xEd8voHY eDpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768168727; x=1768773527; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fqO9HbfMIwt05kz/abBQlPaxORHTbzUMkp2EwctPJB8=; b=pL+Bag58PlgRY/PrAVujsmR4rJQg5RSANrSJxMqcrUYlVIF8jideBPLBJ2Uv98fVF2 96+kerKT9oGo2R/Ht7uPR69TytuRmcLS1QalkAhYF4GlcDiHkEYkWs1eep2oRbyn39fC YSc9rO4lLkNtvoHWzgGyylQM63OfcnKz7gx3HIkmEh0kKNRgwr8ZdanY1035XIrlwWFK zZcuyJM8Ieidd7LQo1uS8/hbdX5gs+WOFL2SQmjV2rUJU1F9wXYsYzPvx3quQ9TYCfPp pMoNWJeEUY6A3hD+8Rwf78JRJ3lSeMQMle7Fz+YyKG0HfvZLxSLuaXroMCwl/ttDYf8U Ex0g== X-Gm-Message-State: AOJu0YzyzK2NZKEYvXvP3EfQLgnbX08MvBC4IiO21J7Wx2ZnwiPGYwkc U9V1vxhGSgFOX3M/EFKuiGyBh1ZhVF2ZVFVeX9saAiygvGChX6YYKKo2RchI9+qBp2SCJokkFTG LRMlEWPY= X-Gm-Gg: AY/fxX5onGw7XE2AE00FdauoootZao2wnCImeJ+sppUlWWcucFcgW+bo8+6rt/FZ72c 69ty+l+eC4zEONGdWyotzhTf6cS4spDtnOzy6cKd89/g6TeLr5NGAYEes7UGlAMS7VEbghS+Khi yUMfiH+Tr7StdHG7eQvE7lgXkNkGMFOwU8oHwAE01romZKiL0hreyyoE1VAy3ZWylxT/K4n9fyj j1OtfJIOTFac6Z+rfDIq21h2QlWo/AIkaaURCaNXFE7j6dX6suulvF8bWo+ADas1OeLLiwx7Dyf FPmD87MiEoUXorZuKmeOVmYp6mKYFmVGGcAU1wGw3PEk1H/Xx3CDM9duT9ZfDM+vRv7EI76iqrX sJW740oPz3Hl4ti0PLg4qQCVBFjH43jGTGH/JjKSljeSOfIo4CkGs0DFx6N/gw+uvOf3qo4PQlK 5LlF/A7NU71f+YOwg= X-Google-Smtp-Source: AGHT+IEFcCOXZaDRrSJlNXXGtve1MASzR4R4Ile1Q5YXLNaunWsUXKjzjxUa0hQhSQ1cn7YYO9GuDQ== X-Received: by 2002:a17:902:d50a:b0:2a0:c5a6:c8df with SMTP id d9443c01a7336-2a3ee429962mr162657035ad.21.1768168727148; Sun, 11 Jan 2026 13:58:47 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Matthew Lugg Subject: [PULL 08/13] linux-user: fix mremap errors for invalid ranges Date: Mon, 12 Jan 2026 08:58:13 +1100 Message-ID: <20260111215819.569209-9-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260111215819.569209-1-richard.henderson@linaro.org> References: <20260111215819.569209-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::629; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x629.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1768168816496158500 Content-Type: text/plain; charset="utf-8" From: Matthew Lugg If an address range given to `mremap` is invalid (exceeds addressing bounds on the guest), we were previously returning `ENOMEM`, which is not correct. The manpage and the Linux kernel implementation both agree that if `old_addr`/`old_size` refer to an invalid address, `EFAULT` is returned, and if `new_addr`/`new_size` refer to an invalid address, `EINVAL` is returned. Signed-off-by: Matthew Lugg Signed-off-by: Richard Henderson Message-ID: <20251117170954.31451-3-mlugg@mlugg.co.uk> --- linux-user/mmap.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/linux-user/mmap.c b/linux-user/mmap.c index ef3833a2bb..6163f1a0d1 100644 --- a/linux-user/mmap.c +++ b/linux-user/mmap.c @@ -1110,12 +1110,15 @@ abi_long target_mremap(abi_ulong old_addr, abi_ulon= g old_size, int prot; void *host_addr; =20 - if (!guest_range_valid_untagged(old_addr, old_size) || - ((flags & MREMAP_FIXED) && + if (((flags & MREMAP_FIXED) && !guest_range_valid_untagged(new_addr, new_size)) || ((flags & MREMAP_MAYMOVE) =3D=3D 0 && !guest_range_valid_untagged(old_addr, new_size))) { - errno =3D ENOMEM; + errno =3D EINVAL; + return -1; + } + if (!guest_range_valid_untagged(old_addr, old_size)) { + errno =3D EFAULT; return -1; } =20 --=20 2.43.0 From nobody Mon Feb 9 16:03:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1768168812; cv=none; d=zohomail.com; s=zohoarc; b=YeCUBCrNFQ7NAArHSBaLfOpJLu/tbADbiEuY8IxeGSDTxcJ/fP3RwNAtZERZabWQuURDLuFgvv3Fg9MYZGsr39JXFRvqldop3GYafgalR7xA71RQ6vbG80d+4mwskQOxbNepkZ3jSWKDwIVL7BQpOLbIeMHI9881Ck2HJLbfUHk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768168812; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=GVaAl+5IUsLS+7adpLV4oBcC5fg9pMBam+ikbK+jV9M=; b=WAyRgCkLmoHWBfgntjmAiDSDf741R3aaK/A4kDlYQoxP09NWJb/viLgka4NNdLaGu0ushtUk4XD5HCXER19MPvaRSHQFnqJy83CdW88E6kCDJ6dgcCPhWjNcrvXLK7yO6UXtyF+gORFgdkaU6rRtYVrCsizGaSbIdIWhaTtuXXo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768168812218825.9434786489464; Sun, 11 Jan 2026 14:00:12 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vf3SY-0005Og-Mh; Sun, 11 Jan 2026 16:58:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vf3SX-0005Nw-1a for qemu-devel@nongnu.org; Sun, 11 Jan 2026 16:58:53 -0500 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vf3SV-0003tE-CP for qemu-devel@nongnu.org; Sun, 11 Jan 2026 16:58:52 -0500 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-2a0d06ffa2aso42935845ad.3 for ; Sun, 11 Jan 2026 13:58:50 -0800 (PST) Received: from stoup.. ([202.86.209.61]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3c3a31dsm155272365ad.9.2026.01.11.13.58.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 13:58:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768168730; x=1768773530; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GVaAl+5IUsLS+7adpLV4oBcC5fg9pMBam+ikbK+jV9M=; b=WiIgFczC6yujg2wIm8m+Y0L5f55CxThthtsXdiGN7awQlW0lr2XqDaU1QDhq0hbqQj g7nu+hsgA9hSFSK3dPyZubhod4tl/oSZxUyO1uNckK5w6ulsfyYIEbTb9hy3YOXjf4AA /x7bPHiVnBdFUMBiyN8lIHq9CtLLA7dGO7Toh9JHQ4v5PHfCb1LlDi7pDMUFydIkMiVW wAxqmUamUT7x25zIpENOstI5OXpdRhqvvku07SAxDEXLkOXqn8EUsRvUc+wly8q1hgnU NsW20tQSQrsXFG2mdXM9tNXj5nUQtS/y6vLb4MRz1LmsfjD6EXQwEm8a3PansGE3dnYt nVRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768168730; x=1768773530; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GVaAl+5IUsLS+7adpLV4oBcC5fg9pMBam+ikbK+jV9M=; b=IhvGathdFMXBqsgWQ3Fyuok9ZCDTyXLbIlW0x2dc4tvy6TNGNG7LMjuzaHWi+B95GL dVp+Ge9DtKgWMUBRE8vSv8qMVq3AffE1BlkxQkMu49ye/cuqLUR1YN/XaQyw4hMmaqw7 dzqAZRh2LxGVu9ZNj/+FqKs4/8mCsHRx+uPHhVnjFC2xMlE2dFgI78sihbw7FTJ9MWok jd454R7+NxhagnL28QuJFpWMm0EL+DyE+xcbcei8hdpa4oZ0syzfBZ73Tn/Rv/Eo80ys 91ECskHsfENvk0YImAyWORtvI5xJSFYpk3cFyIzcudN9HwA89qzUmJSNLB/zyW93BK9V 76Wg== X-Gm-Message-State: AOJu0Yx9rtvCREmf2Iurr/09qEQM3mtXr+vKYCTJvLjLTY0Fwk0efS6p WRfctqot80n9p776saeYd+bTu3YOgnIlXqX9VABumw7D79o4gleqsFbuBv0qgVMzSULC3wENBWJ o7+RPwcY= X-Gm-Gg: AY/fxX7uUDpwCmj2eyln7J8f6ZE5BhzGnn6m9NehzNRJYwfxFiA0fgsoIlNEVwEm1i/ GJWuAUehQi1Ng3tx6Bed7gcLeOgd6Xai7XIXlnSvUcLHCcJWXtqp11jyRITrhyEOEbmpTHN29l8 c/mhcH/BLGncRq5BaxAcLeB5lM2JU6kvMp4FXB6AlvUp54kCY8ikqFU1rbQFYKMGSZ46MzpWOe9 +2tprruHNI8UZxZJq9DsTa03eoUvjWhyngDyN2ObZ5/Fb73DhNy9fuxDTxKDttfMVL1tK9jT9hR 2oj2Nmze/KfsJls6iQquEINyHFd92E0+6pqx6xYiGFej6uZLxBc2nlDufC8evnkYLARJYv0hIrf OoOW/Y2pwaach8DJfTCdOr/QLUhaHxF4JktoxlzWMqfavARbliMmAtZE/lgQldKfPhmm/iyqYtP t/QwETnnmUDwgV14g= X-Google-Smtp-Source: AGHT+IF7hStAS3u2JSfmTtsIL9eDbFwp1Lsc2e+e5g29O9a6FM6oX+flxICbzr1AtHn/2WyOoBZ/uQ== X-Received: by 2002:a17:903:b48:b0:2a0:b02b:210c with SMTP id d9443c01a7336-2a3ee4135a7mr155016435ad.1.1768168729560; Sun, 11 Jan 2026 13:58:49 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Matthew Lugg Subject: [PULL 09/13] linux-user: fix reserved_va page leak in do_munmap Date: Mon, 12 Jan 2026 08:58:14 +1100 Message-ID: <20260111215819.569209-10-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260111215819.569209-1-richard.henderson@linaro.org> References: <20260111215819.569209-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62c; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1768168814489158500 Content-Type: text/plain; charset="utf-8" From: Matthew Lugg The old logic had an off-by-one bug. For instance, assuming 4k pages on host and guest, if 'len' is '4097' (indicating to unmap 2 pages), then 'last =3D start + 4096', so 'real_last =3D start + 4095', so ultimately 'real_len =3D 4096'. I do not believe this could cause any observable bugs in guests, because `target_munmap` page-aligns the length it passes in. However, calls to this function in `target_mremap` do not page-align the length, so those calls could "drop" pages, leading to a part of the reserved region becoming unmapped. At worst, a host allocation could get mapped into that hole, then clobbered by a new guest mapping. Signed-off-by: Matthew Lugg Reviewed-by: Richard Henderson Signed-off-by: Richard Henderson Message-ID: <20251117170954.31451-4-mlugg@mlugg.co.uk> --- linux-user/mmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-user/mmap.c b/linux-user/mmap.c index 6163f1a0d1..4bcfaf7894 100644 --- a/linux-user/mmap.c +++ b/linux-user/mmap.c @@ -1029,9 +1029,9 @@ static int mmap_reserve_or_unmap(abi_ulong start, abi= _ulong len) void *host_start; int prot; =20 - last =3D start + len - 1; + last =3D ROUND_UP(start + len, TARGET_PAGE_SIZE) - 1; real_start =3D start & -host_page_size; - real_last =3D ROUND_UP(last, host_page_size) - 1; + real_last =3D ROUND_UP(last + 1, host_page_size) - 1; =20 /* * If guest pages remain on the first or last host pages, --=20 2.43.0 From nobody Mon Feb 9 16:03:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1768168807; cv=none; d=zohomail.com; s=zohoarc; b=DTnzUgItOZyTTThKrXlB9P0bOVcF5U/oIrpdTnUaEPaWDS0roX+qb9szXpYj4Yq1/Z/reGZ4XY/YE3NuLVP55nauWhI7UXUMqLLP5ji9VbagSNJUZ8YEQSNFhTX2gQaFshWqmYhkWzjbVTxtqBAyYl+M/YGykgRQ7wYN2ZdKJYE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768168807; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=NbrAaN7JsAz6eZwl17xTGDw3px0xTVunNGwx3Itrcys=; b=frvq2lztXxridOiPZtOJ0uw38OfhjGGT32VwWvRxi0toM8yt7I+brP9tz6cqlx+kwZwE9n1J7BJwPK5jy754wjMag2DXWRG3RGEv6v6kfsl5r/0czC+ZJT6iUI16GlK4odShpxNXkRq4iGaFbtuhZSOlcEn2urPrWigt1wgKk7o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768168807754552.14123636034; Sun, 11 Jan 2026 14:00:07 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vf3Sa-0005Qu-DM; Sun, 11 Jan 2026 16:58:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vf3SZ-0005Pk-56 for qemu-devel@nongnu.org; Sun, 11 Jan 2026 16:58:55 -0500 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vf3SX-0003tf-Ex for qemu-devel@nongnu.org; Sun, 11 Jan 2026 16:58:54 -0500 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-2a0d0788adaso38405115ad.3 for ; Sun, 11 Jan 2026 13:58:53 -0800 (PST) Received: from stoup.. ([202.86.209.61]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3c3a31dsm155272365ad.9.2026.01.11.13.58.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 13:58:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768168732; x=1768773532; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NbrAaN7JsAz6eZwl17xTGDw3px0xTVunNGwx3Itrcys=; b=Qh5rVa75kLsAcio5TFG6EuBC2pGuNbUeG6h4yG58EJ4HgpG10LAWCHDZ3SgjV6B63O kkGolOg+kT3f02gmSmfAT4AzSsOsRqbOdRWsi6xvAKfZb7u6xIwIAO7GLFEbcZFvrQYd gNK1Fm+CykKQggGVjkrfJ3Nv/pKqmgcKVYp4rvk1IUmo5lGgCJSaKfIU3aBO7qKqSNcK 9m0fV/e6kGLTjTImA3aF1dtXQztiFCm44tC9JgEpVtwNV+ojSwxmA3lzw4BfwMYnVmZi 1x2cvVUylSTvCml9srS338aG8TQXX+Nxsh7zcpc2a8ODfow5lq9dpb2pq60HwwANN/1y SDNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768168732; x=1768773532; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=NbrAaN7JsAz6eZwl17xTGDw3px0xTVunNGwx3Itrcys=; b=N+AKydqG/VgAoJYwJwLnIwNWFeoJ8kU6nEl31Yh1gaWz/Pb+QzKsyB7nPbYVlR4HZv Q9DpBbEIO65hXdfTJpqV2RufQdhyjEIUIy4H5ivDpf0/iu+bsdcoXtWT+8OIzUgWyMf7 Ogy+pbbqpLy0dghVRZp3lhZ/75OsSrJyuwUFRRgLLDf0fDJ+2q4GjD6OSK/3cBqfkpHw SAaEmx1pHBUI4wjkC8VgA/kf07s0qG/9zM9QjfQLM2haAw5DAJv+wn9ql3Wa3vej03Er pnn9JsOnvFutGSKDusND8qGXAfGQu4q1FPmy7fb9vXsmRmbCtJFiOFdJIxKiPHtwDvig gntw== X-Gm-Message-State: AOJu0YxxQKDaLcOH4RJvAdxUODn2pYdpeyDMm62/bbyY79yaIR8+EGSm PtIiqMm77ygQy9h77bIyYSSVsX/LbGWz4ZLaORQrocd31s5J6VCSu2MDZNdisA9xfsv3Nyb/8NL 1IeQgx5A= X-Gm-Gg: AY/fxX5GLfz4LkVKqNdxwHHYpv0nbWSXK4YuQyIQ7fi/PQ9Z0wxoka8OUw/SWIG8Qwe xv7Yf0dZMeiqXTHt6NYBhjX8/VCENj1p6tmskZdf4U2s60tckS/m7vt1xrHMBuncJu0zrXHXiDH pjdyWRkq9Vou5IU6sSaJAYx0H2iD0T/vIt/IiUrAL/DO175crSqXx5XNEa4Cymb2vJztvMYFnyO NUg1plqxPS1a9QeReEg31qRrpAh4r3tMrVk1BlnAzhnmCXFMOvQZU/9tNf1AaI2oJU7JSYk15tV qIE1BMm7fqe11n0NtKGCBdUuFTjSf8uFgN0ZrTsilppM4RqUi7uwnFS2+yEGC9m9Afi9L5nXx3j ZGBp8TwGwlC31408mZheDjOMbGvW9fjeMkI0xTqGlzvYWe01qdxHh/jTAKT6mGQSnQLDtJJ3dCs EC+JLXAbaVZjdME4Q= X-Google-Smtp-Source: AGHT+IGllwwYTpnXu5ywVxVF16g48vFl5wgBXng81h81rY2T94jKtuu6wfABH7ci0/5jUVIvj/dPmw== X-Received: by 2002:a17:903:1252:b0:2a0:fb1c:143d with SMTP id d9443c01a7336-2a3ee40ec42mr145897305ad.1.1768168731996; Sun, 11 Jan 2026 13:58:51 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Matthew Lugg Subject: [PULL 10/13] tests: add tcg coverage for fixed mremap bugs Date: Mon, 12 Jan 2026 08:58:15 +1100 Message-ID: <20260111215819.569209-11-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260111215819.569209-1-richard.henderson@linaro.org> References: <20260111215819.569209-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62c; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1768168808687158500 Content-Type: text/plain; charset="utf-8" From: Matthew Lugg These tests cover the first two fixes in this patch series. The final patch is not covered because the bug it fixes is not easily observable by the guest. Signed-off-by: Matthew Lugg Signed-off-by: Richard Henderson Message-ID: <20251117170954.31451-5-mlugg@mlugg.co.uk> --- tests/tcg/multiarch/test-mmap.c | 42 +++++++++++++++++++++++++++++++-- 1 file changed, 40 insertions(+), 2 deletions(-) diff --git a/tests/tcg/multiarch/test-mmap.c b/tests/tcg/multiarch/test-mma= p.c index 96257f8ebe..e297f4b1e9 100644 --- a/tests/tcg/multiarch/test-mmap.c +++ b/tests/tcg/multiarch/test-mmap.c @@ -22,6 +22,7 @@ * along with this program; if not, see . */ =20 +#define _GNU_SOURCE #include #include #include @@ -41,7 +42,7 @@ do = \ } \ } while (0) =20 -unsigned char *dummybuf; +unsigned char *dummybuf; /* length is 2*pagesize */ static unsigned int pagesize; static unsigned int pagemask; int test_fd; @@ -451,9 +452,45 @@ void check_invalid_mmaps(void) fail_unless(addr =3D=3D MAP_FAILED); fail_unless(errno =3D=3D ENOMEM); =20 + /* Attempt to remap a region which exceeds the bounds of memory. */ + addr =3D mremap((void *)((uintptr_t)pagesize * 10), SIZE_MAX & ~(size_= t)pagemask, pagesize, 0); + fprintf(stdout, "%s mremap addr=3D%p", __func__, (void *)addr); + fail_unless(addr =3D=3D MAP_FAILED); + fail_unless(errno =3D=3D EFAULT); + fprintf(stdout, " passed\n"); } =20 +void check_shrink_mmaps(void) +{ + unsigned char *a, *b, *c; + a =3D mmap(NULL, pagesize * 2, PROT_READ, MAP_PRIVATE | MAP_ANONYMOUS,= -1, 0); + b =3D mmap(NULL, pagesize * 2, PROT_READ, MAP_PRIVATE | MAP_ANONYMOUS,= -1, 0); + c =3D mmap(NULL, pagesize * 2, PROT_READ, MAP_PRIVATE | MAP_ANONYMOUS,= -1, 0); + + fail_unless(a !=3D MAP_FAILED); + fail_unless(b !=3D MAP_FAILED); + fail_unless(c !=3D MAP_FAILED); + + /* Ensure we can read the full mappings */ + memcpy(dummybuf, a, 2 * pagesize); + memcpy(dummybuf, b, 2 * pagesize); + memcpy(dummybuf, c, 2 * pagesize); + + /* Shrink the middle mapping in-place; the others should be unaffected= */ + b =3D mremap(b, pagesize * 2, pagesize, 0); + fail_unless(b !=3D MAP_FAILED); + + /* Ensure we can still access all valid mappings */ + memcpy(dummybuf, a, 2 * pagesize); + memcpy(dummybuf, b, pagesize); + memcpy(dummybuf, c, 2 * pagesize); + + munmap(a, 2 * pagesize); + munmap(b, pagesize); + munmap(c, 2 * pagesize); +} + int main(int argc, char **argv) { char tempname[] =3D "/tmp/.cmmapXXXXXX"; @@ -468,7 +505,7 @@ int main(int argc, char **argv) =20 /* Assume pagesize is a power of two. */ pagemask =3D pagesize - 1; - dummybuf =3D malloc (pagesize); + dummybuf =3D malloc (pagesize * 2); printf ("pagesize=3D%u pagemask=3D%x\n", pagesize, pagemask); =20 test_fd =3D mkstemp(tempname); @@ -496,6 +533,7 @@ int main(int argc, char **argv) check_file_fixed_eof_mmaps(); check_file_unfixed_eof_mmaps(); check_invalid_mmaps(); + check_shrink_mmaps(); =20 /* Fails at the moment. */ /* check_aligned_anonymous_fixed_mmaps_collide_with_host(); */ --=20 2.43.0 From nobody Mon Feb 9 16:03:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1768168803; cv=none; d=zohomail.com; s=zohoarc; b=RszSd0gU3aziK9W5uaf5QUyuGPm+Z3MasL72pgrMZDAWtu6M2c7qqoVlAbvUXZNz+ALqXx1JCjrYX/jl6KuPycl6EHYmhwwDE9T3cO9D5Sjm8HJqGSZP4WAdt1MqCh/9e0cL7/VfmYR4w40G4LX+A8fB+YtnMwti7AfGk9CsN4Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768168803; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=O3EB7qIEaNPc7salkmu1WZ3Rl3gRT11tXN+JnGgXxZw=; b=byX0o4mqvza/FvJO5OHwJ4Cfb93Vl4dGN25hwlI99eDN+2hmUK7mll137GKIL8Y/FIIDJt4Wd4ZeMhzg5589W+04yTxWqonaahxUDd23F35KfuFY73EetffNXQtqpUCj56yFS/NpdmF+k3r+qUYRRPMrKH0nYH3QOjBPPwIc0e4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768168803919505.67108296300864; Sun, 11 Jan 2026 14:00:03 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vf3Sd-0005Rp-FT; Sun, 11 Jan 2026 16:58:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vf3Sb-0005RE-R6 for qemu-devel@nongnu.org; Sun, 11 Jan 2026 16:58:57 -0500 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vf3Sa-0003u2-9o for qemu-devel@nongnu.org; Sun, 11 Jan 2026 16:58:57 -0500 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-2a09757004cso54072925ad.3 for ; Sun, 11 Jan 2026 13:58:55 -0800 (PST) Received: from stoup.. ([202.86.209.61]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3c3a31dsm155272365ad.9.2026.01.11.13.58.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 13:58:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768168735; x=1768773535; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=O3EB7qIEaNPc7salkmu1WZ3Rl3gRT11tXN+JnGgXxZw=; b=fmR0dgWwdgeOKX3YoA2ze+KUXbJ4NpIPVtB+aK7EnLcGF4t2l4R765v87YFPGbv0iM 4+D8dCdDFVeQ+X0vXJjrVru9iPSDqdYtzvt81LYkuN5XZ+0pmX+2l1jwEvyaeq2nSDAP AEJ5g0T5Pk1l+3eqFW2WALwrbSqfSZrkW6tumN0oAd/GCyQRW9/519QLEJkTK82jsXuH bZq225lK8kIGN76vp//5sDEoVx1bSx/x162n8FtQvRNUacfuBEArEmDlSOiuQnJL4J+n Gabbq1TmkzubDfXlwr7XZ5Q7sUv7U0t+zLNhdjAG/G4a6p0ZN/EUcsdMfLdqCEuzr9l+ I9RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768168735; x=1768773535; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=O3EB7qIEaNPc7salkmu1WZ3Rl3gRT11tXN+JnGgXxZw=; b=BtHynotDyHwJoFIZRDrdGBwFnOncW/oa9svXFBWR31bm+w6jrkfwH0zrCSPlKslndi vxSXE/e0nGw78nPjp8jdX3FE1k7+//BzmXzCtxeduE9SbmY4OL37TKBLK6FfM2uAMyrC 1CUTFw6rzxMPBZZRz/y0bXj1K0j1fxYATIIZNnLdOSsEpyYJBSMmaa3T2QDcM2oVX4sS QKCgpYHN8co4Nr83pnchv1dunt3WMEEWsq57r5CSutcyteS7EyRa+CzbiDmOSv9fQphK uRn01LRzIcLjA7kHrtgKuavUlXDVSt+36CWV+wAH3E9dTFPWmvhpymvUNKn2+zkdSvuT Q4Ow== X-Gm-Message-State: AOJu0YzCZYKZvyIR794itAtkPSGCswVaqvF7dqAy1j3K+dJ6FE0eC411 PSpgQSJccBwp5ZNGwGbaeRNLWJNiFj/AeuxsXAYQKW41FxhIPOrCbrkg5sAisjY5IGs/gzOY2Ix 8zgZkFYY= X-Gm-Gg: AY/fxX4cojQHlGApo8TvDXB3hQPExnURdDrR1bKFGdFuDbcQENHEdVcNoDKkwQJL5CR HGUVa61fBqO4Fk2toSZla538a8vJn5d5wnLnGSGzfMcmTCFfadruLnUdr0NmiX98PpxgKL2PXTc 4A8fuS8tnJKXJuLciTcz2JdFQPSqLuBDOCC2uRVd3KNb+W2MiZ4ty60lQ5+e+VdV3kJ7yy4Pf8K WWTxNqrkGLHuLZauIDOhQcx7eAWT02RlrAfvwpAm/EMB7Z4yZ7ziF0+rXKqrdApIY18OCWDptq0 X4+ONfkCf4WLacvlnGGktRFaWmqBGN+Y7n8RtmYokYork7rg7hBeAeFtb3EulHRMl/3l0WkRX/x WUC4TNUh28yYWU/5hZtsPfO/0oxxtdUe43XVcdmZqYe0hWOkNaAifnjh7mxpsqDZ8DQ8hn+vcNZ Gfd0bophTTAJL8oc0= X-Google-Smtp-Source: AGHT+IGmgF0edlPjiaIYeeWovDxcsPMEpvj1lEuLwKNpSAWJ/3/BcGq4YbZC/RS3eFKpS0Kl03wz/Q== X-Received: by 2002:a17:903:1a6b:b0:2a0:de4f:ca7 with SMTP id d9443c01a7336-2a3ee41516dmr158599705ad.1.1768168734799; Sun, 11 Jan 2026 13:58:54 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Michael Tokarev , Pierrick Bouvier Subject: [PULL 11/13] linux-user: cleanup epoll_pwait ifdeff'ery Date: Mon, 12 Jan 2026 08:58:16 +1100 Message-ID: <20260111215819.569209-12-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260111215819.569209-1-richard.henderson@linaro.org> References: <20260111215819.569209-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::633; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1768168804495158500 Content-Type: text/plain; charset="utf-8" From: Michael Tokarev All linux targets these days have epoll_pwait system call (while some miss epoll_wait, which is less generic). And all linux targets definitely has one or another epoll_*wait* system call - so whole code block dealing with this system call should always be present. Remove the now-unneeded ifdef'fery. Reviewed-by: Pierrick Bouvier Signed-off-by: Michael Tokarev Signed-off-by: Richard Henderson Message-ID: <20260109090937.599881-2-mjt@tls.msk.ru> --- linux-user/syscall.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index ee7c34027e..2c7e1eb5b2 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -13619,13 +13619,10 @@ static abi_long do_syscall1(CPUArchState *cpu_env= , int num, abi_long arg1, } #endif =20 -#if defined(TARGET_NR_epoll_wait) || defined(TARGET_NR_epoll_pwait) #if defined(TARGET_NR_epoll_wait) case TARGET_NR_epoll_wait: #endif -#if defined(TARGET_NR_epoll_pwait) case TARGET_NR_epoll_pwait: -#endif { struct target_epoll_event *target_ep; struct epoll_event *ep; @@ -13650,7 +13647,6 @@ static abi_long do_syscall1(CPUArchState *cpu_env, = int num, abi_long arg1, } =20 switch (num) { -#if defined(TARGET_NR_epoll_pwait) case TARGET_NR_epoll_pwait: { sigset_t *set =3D NULL; @@ -13670,7 +13666,6 @@ static abi_long do_syscall1(CPUArchState *cpu_env, = int num, abi_long arg1, } break; } -#endif #if defined(TARGET_NR_epoll_wait) case TARGET_NR_epoll_wait: ret =3D get_errno(safe_epoll_pwait(epfd, ep, maxevents, timeou= t, @@ -13694,8 +13689,7 @@ static abi_long do_syscall1(CPUArchState *cpu_env, = int num, abi_long arg1, g_free(ep); return ret; } -#endif -#endif +#endif /* CONFIG_EPOLL */ #ifdef TARGET_NR_prlimit64 case TARGET_NR_prlimit64: { --=20 2.43.0 From nobody Mon Feb 9 16:03:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1768168834; cv=none; d=zohomail.com; s=zohoarc; b=LO19wLUloLJq/GkScq9KfYxj/TEpNgD0eWY/I0Kaw/0IzJwFwbK0Pwvn09Mnpt69N1IT/gx0c0eLs9XM6YYpxVxzgiLabowuoTbdB1b3U+jhFD56X/5SmnFxLoWbKThg0NiE13DlSfioNoU8OB7xsirpls3GtxYJiagrkHf5lf8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768168834; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=gAbrBW43TSmdFxMsFe0oqQvzIcATowrJezfs7xJvcpM=; b=lB61fKoUcYvhx9CTdXQcTLrqFZKgODppR0doFAnwIMvPL/DezQYdp6VLcRlHvK0p6A9aE8fJClqhqHGd6UN/ZVWjWAu6YPhogIOCwbNKwKN8hEpAfAjQJcfePsCXOyKA22Guw6J68NUGPpILauyH21UPLmcddaZ+iwOQrm/6cJY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768168834961364.70540378448584; Sun, 11 Jan 2026 14:00:34 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vf3Sf-0005ST-L5; Sun, 11 Jan 2026 16:59:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vf3Se-0005Rw-E6 for qemu-devel@nongnu.org; Sun, 11 Jan 2026 16:59:00 -0500 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vf3Sc-0003uZ-Pc for qemu-devel@nongnu.org; Sun, 11 Jan 2026 16:59:00 -0500 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-2a0d06ffa2aso42936105ad.3 for ; Sun, 11 Jan 2026 13:58:58 -0800 (PST) Received: from stoup.. ([202.86.209.61]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3c3a31dsm155272365ad.9.2026.01.11.13.58.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 13:58:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768168737; x=1768773537; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gAbrBW43TSmdFxMsFe0oqQvzIcATowrJezfs7xJvcpM=; b=hO7Z2WQtQHmumGYzYo4nTDKTxzrxLg8NZLw2mfMjytf8eb6ikB0RGczog5kIoq2H00 AVRNxt+ut3S/+VL9003ZRooLVxZl65zKSruKRWrADBdfL7BXJfQ60yO5UwYyUW7ExN5N hSt5pG3R/0sKnXCsv2HZ5adc1JKXfVjxk7T9wSEgrfuhovDJejzDWB4IoNKi6ce+7vQg dxJJydbaATV0vzIDpx8tp2bUSQZLblHPsGYrzURkB31lAeakavpuKlnICDE0IrB6geoR pheAr+p+JrprYtS+or4TmtAzSjjUkiDbPcijy1wBnze3cZZINveTlnB5Lego1oygeMbD 6ShQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768168737; x=1768773537; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gAbrBW43TSmdFxMsFe0oqQvzIcATowrJezfs7xJvcpM=; b=ZcfxsQlLwaYu6Hek30DV9+ouCbhZyAXkER0UbBUjgrcdymdw9HY6wG3Jy8yA7pT5u4 j4OLbR1mDhWLVDo+7xT0omAhH0ttYqtg+t9BW/V0Y/gjnk7I+6k4Xi3Bh8nJUImdrsou IEORh3SXe58yC1Rz88DJ7QBMTOplw0R42Ecuaz3mEAFBoTzgAF+Y1gTxfuSEQNARr/RQ sFIadfBi51LWPHEyavhCWcwjkS53lHkUz5K+CaxJRxmRAiQ53y/v2CkK9W8tMCp+Q9ei 7nxhIMk8itAd8r2oSTfqpA9N8iEqcSzZs0PelT6BtEiRlMcPPYZGEM1QK378LZzGnnVY XbbQ== X-Gm-Message-State: AOJu0YwhzsD2eetLU6UZG3xTG2GAphJC65j3uz/KT/9Dq/p4YDmi++Za rPMnPQpHL91d5PrXTF+LySW+gqt5thAryjECTL72o7did2M2udA0gL9pFoldncjPdJb0HaMGDtz 7PE0gUWk= X-Gm-Gg: AY/fxX7AhbEpghEHGDQhPpwIEoS0L+pZuQujnxXqf2ldoMZzhnYDeRo06uzLT59p8Z3 T2Lm4vDQRtW1BnLly6O9EHDh6i5PYgnzEz9C5HhPJebljqMP3w+tOrOm8ER04Rn0SOjMEFHBUDq o+Ez/CVW7VUdrR9PywrkMGwp8Iw0igp7AyViGynlDfWsLim2Apy+Ytxu0xAVcNBrE76CkMA82IL P82+YLnW288hvLyEmWDxlY7R6byugpGQqhcKeVBzp1ouQDdc8N4G24QpVdV6PG/F4njn3Y4PlDK VvVRlSe+O/GD4u0mpCp+j+EiPslDvbhBUx2Ox1/eMgJ6E2dgV1M05uMbH2gyaBhI9z8dqUOPbME 837blbf9c64K+MyB0efitx1gxCJwbYDs/4PEk/VltIIFXERKyAUwPNdDp3CkYgd+ZDEnRmnLbBt fPazjax/tjLz9SF4U= X-Google-Smtp-Source: AGHT+IH1Z1uPxFEsP6S2TCuDvgVH2JD08gvE2cd4dXJhYGC6Y/jlHt8agLvhRRWbBdacZT47fl82Pw== X-Received: by 2002:a17:903:3c2f:b0:295:586d:677f with SMTP id d9443c01a7336-2a3ee4139acmr162412705ad.10.1768168737292; Sun, 11 Jan 2026 13:58:57 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Michael Tokarev , Pierrick Bouvier Subject: [PULL 12/13] linux-user: implement epoll_pwait2 syscall Date: Mon, 12 Jan 2026 08:58:17 +1100 Message-ID: <20260111215819.569209-13-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260111215819.569209-1-richard.henderson@linaro.org> References: <20260111215819.569209-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::632; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x632.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1768168836457158500 Content-Type: text/plain; charset="utf-8" From: Michael Tokarev epoll_pwait2 is the same as epoll_pwait but with timeout being (a pointer to) struct timespec instead of an integer. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3210 Signed-off-by: Michael Tokarev Reviewed-by: Pierrick Bouvier Signed-off-by: Richard Henderson Message-ID: <20260109090937.599881-3-mjt@tls.msk.ru> --- linux-user/syscall.c | 29 +++++++++++++++++++++++------ 1 file changed, 23 insertions(+), 6 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 2c7e1eb5b2..67ad681098 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -708,8 +708,11 @@ safe_syscall5(int, ppoll, struct pollfd *, ufds, unsig= ned int, nfds, size_t, sigsetsize) #endif safe_syscall6(int, epoll_pwait, int, epfd, struct epoll_event *, events, - int, maxevents, int, timeout, const sigset_t *, sigmask, - size_t, sigsetsize) + int, maxevents, int, timeout, + const sigset_t *, sigmask, size_t, sigsetsize) +safe_syscall6(int, epoll_pwait2, int, epfd, struct epoll_event *, events, + int, maxevents, struct timespec *, timeout_ts, + const sigset_t *, sigmask, size_t, sigsetsize) #if defined(__NR_futex) safe_syscall6(int,futex,int *,uaddr,int,op,int,val, \ const struct timespec *,timeout,int *,uaddr2,int,val3) @@ -13623,12 +13626,20 @@ static abi_long do_syscall1(CPUArchState *cpu_env= , int num, abi_long arg1, case TARGET_NR_epoll_wait: #endif case TARGET_NR_epoll_pwait: + case TARGET_NR_epoll_pwait2: { struct target_epoll_event *target_ep; struct epoll_event *ep; int epfd =3D arg1; int maxevents =3D arg3; - int timeout =3D arg4; + struct timespec ts, *timeout_ts =3D NULL; + + if (num =3D=3D TARGET_NR_epoll_pwait2 && arg4 !=3D 0) { + if (target_to_host_timespec(&ts, arg4)) { + return -TARGET_EFAULT; + } + timeout_ts =3D &ts; + } =20 if (maxevents <=3D 0 || maxevents > TARGET_EP_MAX_EVENTS) { return -TARGET_EINVAL; @@ -13648,6 +13659,7 @@ static abi_long do_syscall1(CPUArchState *cpu_env, = int num, abi_long arg1, =20 switch (num) { case TARGET_NR_epoll_pwait: + case TARGET_NR_epoll_pwait2: { sigset_t *set =3D NULL; =20 @@ -13658,8 +13670,13 @@ static abi_long do_syscall1(CPUArchState *cpu_env,= int num, abi_long arg1, } } =20 - ret =3D get_errno(safe_epoll_pwait(epfd, ep, maxevents, timeou= t, - set, SIGSET_T_SIZE)); + if (num =3D=3D TARGET_NR_epoll_pwait) { + ret =3D get_errno(safe_epoll_pwait(epfd, ep, maxevents, ar= g4, + set, SIGSET_T_SIZE)); + } else { + ret =3D get_errno(safe_epoll_pwait2(epfd, ep, maxevents, t= imeout_ts, + set, SIGSET_T_SIZE)); + } =20 if (set) { finish_sigsuspend_mask(ret); @@ -13668,7 +13685,7 @@ static abi_long do_syscall1(CPUArchState *cpu_env, = int num, abi_long arg1, } #if defined(TARGET_NR_epoll_wait) case TARGET_NR_epoll_wait: - ret =3D get_errno(safe_epoll_pwait(epfd, ep, maxevents, timeou= t, + ret =3D get_errno(safe_epoll_pwait(epfd, ep, maxevents, arg4, NULL, 0)); break; #endif --=20 2.43.0 From nobody Mon Feb 9 16:03:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1768168805; cv=none; d=zohomail.com; s=zohoarc; b=NoviEFhCeX5bYBop3ZUv2oju7Mg/CldKYMYFbsBG4Hpurj2VxB+6LmFDzFpHNJFAG+62dpgL/SF6ch1Tx0M/+VQupfx55SvRfUV/Hrmpb7rA4GC7Lf+TfH553bu3or27bPlqMJJCcR/CUKhD+sGMn95S99S1LNWplH2RWpmvNzk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768168805; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=JwX2WyW0Mkw+5cxrd/3E0Z7rlg0VrOsm3MpTq3nX9Jc=; b=BG/UVKFF69mhvmbamAvdB/G/nhLnzKJykazyYtM1NCgibW8XUDw1AVORO9vO0i8/+yYQnK27D5SNbZ8PZK8nvafV1VB/RHeI96bg6kR2ZEderQFq80Z5CCHQSee9usq0jZlz8KCJr7rJCKv7RKRTM1b4VDe4pJWfNYvLPPP8yJU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1768168805793835.3702461557938; Sun, 11 Jan 2026 14:00:05 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vf3Si-0005TY-I0; Sun, 11 Jan 2026 16:59:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vf3Sg-0005Sq-V3 for qemu-devel@nongnu.org; Sun, 11 Jan 2026 16:59:02 -0500 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vf3Sf-0003uz-Ah for qemu-devel@nongnu.org; Sun, 11 Jan 2026 16:59:02 -0500 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-2a0d6f647e2so59098995ad.1 for ; Sun, 11 Jan 2026 13:59:00 -0800 (PST) Received: from stoup.. ([202.86.209.61]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3c3a31dsm155272365ad.9.2026.01.11.13.58.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 13:58:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768168740; x=1768773540; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JwX2WyW0Mkw+5cxrd/3E0Z7rlg0VrOsm3MpTq3nX9Jc=; b=Qjih0D0/ajr2WtVjp0BX+pUjXuCI20SzO58GPUk9bsU4nw6h7fGPLjGtggUEy/FCP5 qGzPayUubHQPOBiLHuSO2aNj0EX9IEWa9Ajif/zhhtoRVNHUrqmSQVyzK7GZGjgQtIEp V8sy3tMBqcgb7gJXYhJ/J/BRpZCGhHg2Ih6kHY+6/hvH362cbDdZI6WqmY2y9C+1xoqE vwUhk9K2HPGteUklFzFHWjhs1ULWB/X6ldTt0+5z6S9lvzqWLorCKZIs0Zxkyvac7i/8 Rta9CH8DHQCSFCTEEfz5TA2eLdDwnYg3up9SDedY66lV9Rdm+61gtGmQNhX49aPQSHg3 2byg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768168740; x=1768773540; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=JwX2WyW0Mkw+5cxrd/3E0Z7rlg0VrOsm3MpTq3nX9Jc=; b=F8PLvAvsyZVm33t3Vz996T04wowOb7/0ttiiiYlr3GpyogrM6b0KZvfnXBJAElnWos oorYMbsABlCbYygzZnT90pJ6R8X+Ik3wmTn4NeYAV4iirSiIcdN0jkE93Uyh4JCgsiOy SQlcuNCuAuYebEIrIq9iNsQeDzwTqd8tXob6SVluGOW8JUej6PJe9CUN06W3Aoqqe37E Ffqw9miqMthDhattfTQLGQ21pBTLgNmQAfQAFHqH+sh8/XXh9tBvpf41CtIS4JuKgFue tEEd74TLjhGaVVIIh76qKO0p1b451Nb9+TIgDe82OPUwtaJMewZOoyhIFcKNijoDvPib e3MQ== X-Gm-Message-State: AOJu0Yw9IV0RElOPjQSoW8x6VSl4zGXjEEN8MzO7mY23C90M2ONzTWSu uwq88FzhIqGmzyCZU6zsLR4dL+ObZov+arkb35WTuIPV2Y172+lWretcpZyoV42nUW6pNBlpsgw dSF+T2wA= X-Gm-Gg: AY/fxX7jOOxpsl980bqjO7V5F0iYNsx+2q7QfeusjuSQqfWZU8IkYbmrg+h+f0NAF8V +Bg6MDubXdnLO3FJRyA6vPTkj47jgPz8Yjq062e4ujsVrj679QGuA/jCBIpZ+XloIifpzPdaE3Y VCMvqGPDf2rDsokwOjB9cPtKKeXVIqJ12PTw6car51QokHQWiewvdA3IvgbpMqidrEEh9gi/MJE vH+g10Fcf9f7TyoYMoXMY7LKJWKLkdiSDJDNym9z/XdooExJgWLQN3VcS3F8CsEwTdatoPeZ/9p KOaRaCS5hRjd42lHUtgRdTIKUswFpJ5hSaZ824wvE6OSRqU5eNKAEg5XoVMiXZXjlgkAvfM9bOx MselMFCGkPPIJtKbgCpQOFpioEgz3u0D1/gaCO4q2ucBQUHxIroHu8GjF9DURY1dMs/jEmKlpPx BchMoCVr+fjo3sO8s= X-Google-Smtp-Source: AGHT+IECdf/uHoYtjvvADcML59CoClcUke3Vf6d9mwKkNdZL5seZ2a1fhqD7QCZ9wxnGVypLVhSUoA== X-Received: by 2002:a17:903:2f8a:b0:24b:270e:56c7 with SMTP id d9443c01a7336-2a3ee4137cdmr161464095ad.7.1768168739898; Sun, 11 Jan 2026 13:58:59 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Paolo Bonzini Subject: [PULL 13/13] meson: disable libatomic with GCC >= 16 Date: Mon, 12 Jan 2026 08:58:18 +1100 Message-ID: <20260111215819.569209-14-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260111215819.569209-1-richard.henderson@linaro.org> References: <20260111215819.569209-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62c; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1768168806417158501 From: Daniel P. Berrang=C3=A9 Historically it was required to ask for libatomic explicitly with -latomic, but with GCC >=3D 16 apps will get linked to libatomic whether they ask for it or not. This invalidates QEMU's check for atomic op support for int128 which explicitly does NOT want to use the libatomic impl. As a result with GCC >=3D 16, QEMU is now getting linked to libatomic and is activating CONFIG_ATOMIC128. This in turn exposes a bug in GCC's libatomic.a static buld which is incompatible with the use of -static-pie leading to build failures like: /usr/bin/ld: /usr/lib/gcc/x86_64-redhat-linux/16/libatomic.a(cas_16_.o)= : relocation R_X86_64_32 against hidden symbol `libat_compare_exchange_16_i= 1' can not be used when making a PIE object /usr/bin/ld: failed to set dynamic section sizes: bad value collect2: error: ld returned 1 exit status The newly introduced -fno-link-libatomic flag can be used to disable the new automatic linking of libatomic. Setting this in qemu_isa_flags early on ensures that the check for CONFIG_ATOMIC128 still works correctly. Signed-off-by: Daniel P. Berrang=C3=A9 Acked-by: Paolo Bonzini Reviewed-by: Richard Henderson Signed-off-by: Richard Henderson Message-ID: <20260108141407.2151817-1-berrange@redhat.com> --- meson.build | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/meson.build b/meson.build index db87358d62..56df08c10e 100644 --- a/meson.build +++ b/meson.build @@ -445,6 +445,15 @@ if host_arch in ['i386', 'x86_64'] endif endif =20 +# GCC >=3D 16 automatically tries to link libatomic for all programs. +# +# QEMU explicitly does NOT want to use libatomic for int128 types. +# +# Later checks assume we won't get atomic ops for int128 without +# explicitly asking for -latomic, so we must disable GCC's new +# automatic linking with the new -fno-link-libatomic flag +qemu_isa_flags +=3D cc.get_supported_arguments('-fno-link-libatomic') + qemu_common_flags =3D qemu_isa_flags + qemu_common_flags =20 if get_option('prefer_static') --=20 2.43.0