From nobody Mon Feb 9 15:10:53 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1767969318; cv=none; d=zohomail.com; s=zohoarc; b=YVYAVuG1v3+yzhhQaIimbhVWxoRiTKQ+JdS4GvZJPJ/uF5Pd+6xpB1e0mrwiRec4lzBpbwb6N7HixI4WvYjGNezyh+7IepLt4ITtnhbyC4oRpP4oAT79RPE+1GeQZIB38ORrC58P5xeF0avUwJkf0jBEjqXY09UZz3vbCbsm9Zk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767969318; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=NRabUwKCcnSa4tcxD8eunuOpk4bc+IJarAuAxh7ITUE=; b=iuJRhnyyN0MDN+l8Okim/GQL6fTmXTn7NQY0f8sjPL+OtsTMbopasi9xY0SYjpPdU04G2r3TVv7Oa6DlV6C08rWpATww0i4evprCAVoX18mkW0SLY8hg5vM+WDxiWCVGMgklVe0jBMcBn4L9ueEbDU+Zj+5bSjazxYzRLOffq00= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767969318083224.1790230724108; Fri, 9 Jan 2026 06:35:18 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1veDZh-0004uH-BT; Fri, 09 Jan 2026 09:34:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1veDZf-0004tv-M2 for qemu-devel@nongnu.org; Fri, 09 Jan 2026 09:34:47 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1veDZe-0005Qq-9D for qemu-devel@nongnu.org; Fri, 09 Jan 2026 09:34:47 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-654-6G9LkJXhOVGlCvQ16DNN4g-1; Fri, 09 Jan 2026 09:34:42 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9171B18005AE; Fri, 9 Jan 2026 14:34:40 +0000 (UTC) Received: from osteffen-laptop.redhat.com (unknown [10.45.225.84]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 69C0318001D5; Fri, 9 Jan 2026 14:34:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767969285; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NRabUwKCcnSa4tcxD8eunuOpk4bc+IJarAuAxh7ITUE=; b=DmZEcLfRIMJ6B3dX/+2HReYueAx3YYL0e7jcyti4fJSNlHRtxxhF2xy6vRl8+moNICjZdb PRTMwrzvQyqV9d3kbRcvGjHiKueHSc5sMsO6X+HSDYu+miBPamLpFkEbKQ/9ooZp1FeNfY jA5Lw4Bai6Ui8jY4i2BXNhrzQpsanb4= X-MC-Unique: 6G9LkJXhOVGlCvQ16DNN4g-1 X-Mimecast-MFC-AGG-ID: 6G9LkJXhOVGlCvQ16DNN4g_1767969280 From: Oliver Steffen To: qemu-devel@nongnu.org Cc: Richard Henderson , Igor Mammedov , Paolo Bonzini , Marcelo Tosatti , Ani Sinha , Stefano Garzarella , Luigi Leonardi , Zhao Liu , Joerg Roedel , Gerd Hoffmann , kvm@vger.kernel.org, Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum , Oliver Steffen Subject: [PATCH v3 3/6] igvm: Add missing NULL check Date: Fri, 9 Jan 2026 15:34:10 +0100 Message-ID: <20260109143413.293593-4-osteffen@redhat.com> In-Reply-To: <20260109143413.293593-1-osteffen@redhat.com> References: <20260109143413.293593-1-osteffen@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=osteffen@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1767969319134158500 Content-Type: text/plain; charset="utf-8" Check for NULL pointer returned from igvm_get_buffer(). Documentation for that function calls for that unconditionally. Signed-off-by: Oliver Steffen --- backends/igvm.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/backends/igvm.c b/backends/igvm.c index a350c890cc..dc1fd026cb 100644 --- a/backends/igvm.c +++ b/backends/igvm.c @@ -170,9 +170,16 @@ static int qigvm_handler(QIgvm *ctx, uint32_t type, Er= ror **errp) (int)header_handle); return -1; } - header_data =3D igvm_get_buffer(ctx->file, header_handle) + - sizeof(IGVM_VHS_VARIABLE_HEADER); - result =3D handlers[handler].handler(ctx, header_data, errp); + header_data =3D igvm_get_buffer(ctx->file, header_handle); + if (header_data =3D=3D NULL) { + error_setg( + errp, + "IGVM: Failed to get directive header data (code: %d)", + (int)header_handle); + result =3D -1; + } else { + result =3D handlers[handler].handler(ctx, header_data + sizeof= (IGVM_VHS_VARIABLE_HEADER), errp); + } igvm_free_buffer(ctx->file, header_handle); return result; } --=20 2.52.0