From nobody Mon Feb 9 16:19:29 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1767913529; cv=none; d=zohomail.com; s=zohoarc; b=iYZ7mUAuQjItFpzwELDn1M/7B2HijdexAxaLq63K1N3G/1rOPL/qzZtN5m3YzH81Ym5mwMd/gqOYqnpqcJUkjBe03PAnXu0jQPTO9/DotXOJqz8TqWRrtnaVmxJkPf3ym4qGkbpNRqvUjaHVOAuNb1WOPFyC5gTemSkLuaYav1w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767913529; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ekEeGNhYf1wo4cndvv34o+xcugaOgiL9C4rrO036rJ0=; b=ARLCptUQsOIIw9VDNaJ05QrC4hAqXFPVgPueSsuXujtK3UREtCTFB2SCGCf2NJqU9UDIyH8NhvrUqM8KiL/auRS1rEF7anzX+cEcck2B+4wzMuobKrUNdYgiWv0unw0wbNCv8xjKxEfVZzhXIZkH3R9hcwgcjZilstDcm1OTzxk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767913529965289.7416940604418; Thu, 8 Jan 2026 15:05:29 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vdz3N-0007Bq-BR; Thu, 08 Jan 2026 18:04:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vdz3L-00079O-IG for qemu-devel@nongnu.org; Thu, 08 Jan 2026 18:04:27 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vdz3K-0003Un-7l for qemu-devel@nongnu.org; Thu, 08 Jan 2026 18:04:27 -0500 Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-86-vyZbpPxkPfeMoMiOZYkzug-1; Thu, 08 Jan 2026 18:04:23 -0500 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8bb0ae16a63so433169485a.3 for ; Thu, 08 Jan 2026 15:04:23 -0800 (PST) Received: from csomani-thinkpadp1gen7.rmtusca.csb ([47.153.136.179]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8c37f51b787sm680000685a.29.2026.01.08.15.04.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 15:04:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767913464; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ekEeGNhYf1wo4cndvv34o+xcugaOgiL9C4rrO036rJ0=; b=Jfeb6XpgOjO+JATfcw+0wtWJqkozaEtcw55wpvQYrakm9eXIKkvibzHjWtgU31s6x2jqzb 2CRbChKF3MD9zdrKdFG73XIszGLwzOiS1ak5JOd04ZpshxHivWGxxdKIHhsDRaZjqT47xy z4D/hCUcvGRe3XWBfBAN+MKt5HIs1lE= X-MC-Unique: vyZbpPxkPfeMoMiOZYkzug-1 X-Mimecast-MFC-AGG-ID: vyZbpPxkPfeMoMiOZYkzug_1767913463 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767913463; x=1768518263; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ekEeGNhYf1wo4cndvv34o+xcugaOgiL9C4rrO036rJ0=; b=Jva3wNaYXRoaa+LDvXYa/U8o2MpiEp+kZQZ5XYGO4dza5neRAzOM2NHWh/ZFdvqHun UC8N2eBvrbEGxeptJe9G+aLle6rcbQ7LjhDo+Ld7sXM9SQ9buvzkJUO35un3zFCoxxW9 KPIJGaZQxsit147dTrl8CpLHEo+h3yiCdmEZpT6kswfsRf4GgwRLdrFWBn5fPDjZSTcN QoZlegty+XGlOyeybonpdSmA81prFzQD45aaKbLKnL5Y4eyQYPnC8+ibcv85ZaZKAaHv IjVUyPXg9cRZYD436DjUo/lSn2DLpc767iZ3eBYsYj/tAzCWzBH2mfuNWEGNhRABVqpM nUyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767913463; x=1768518263; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ekEeGNhYf1wo4cndvv34o+xcugaOgiL9C4rrO036rJ0=; b=NDWk21Xf9oSxNZAuBAocZBoGdmU7Dd4pafyUuZpYJSMfKtXCjzfRnwW83qgA8czyWQ T3HVrd4dmrwfbW3x/KfvDZ0lXUEHlh/tym84No2Prqn17K+4gnAZvdwugroMN4xyCI02 O6pNdTqJgF/lsfcAoHZkFiq3AtNpOSBWlFjJq4FiH+DLruRCzkFSyyl8urPOOcjR/UUH JOas9m0nP1Bkq1sJIvmT/EN6x1/9LOWNoHcstlm1ccs+p4DY2CE2jlOO8Oz+UhXomqg0 M3maFQbkABgR+qD7h0LB/zNlBo6TCNUp+SBySQXsW14uFLx2LN+93TbCfmbWG98+pzax gWgQ== X-Gm-Message-State: AOJu0YyI1l4L/o17i99HfGE2lqZVS98qzJS5Og7v/gM9PtFZg/sUKPnz rNNmr8BbV78ZKejFCIP80wWXC8OxHGNrkxsprGRPrcgao4aZS2rVWsS5PYMAzPAhtbwnVkrb4ta fa+3JB0jHmDu4SQrrmmzKYUcCu2LA+aVzotiilUW33xVCkReHGd5+JkOyqdku317tkFqC8rMFvK 9GR6Od4vBpWIGILldYjhbdDnv19rjeHfnC6Y8f58E= X-Gm-Gg: AY/fxX6abRkTyas8YIUlTXs2eXjmhaVkIHipgw1dYN7ObRe6mhp+lG2omWM2xkrQr8d gYrn9ggaC77I52zd10jQmJYivsjrEgaVqEzYID9yxsPZxF2/c6Czzp5va9/9yZ5bdYVDhYjODDs XiOXPeWCfdRHEHi4OMa3gyAwHYGuKsLlEe1vILICYWj+udgG9jWqQZ6rsXkaZpfkgKIhvQTIW4G Ux1kNKUdrDe9L/CsB9sRmLyFMCxBmfKSsGdf5+W0sxDlPgIXNovpULF1Ir9niE37qmtPr70kYv+ p1880LxkzRtUCrVR+rMbaMW3jtk49ocTYDnItrZlOFRslCKVLZxCDRbjrDLVIh2H+OpjYfgf2Yq Ary72PwtQpW8hmiRtv8aoZiKFY4T3Di5t0Sm1Hb4= X-Received: by 2002:a05:620a:bd5:b0:8c3:650d:577e with SMTP id af79cd13be357-8c38935626bmr996316385a.4.1767913462749; Thu, 08 Jan 2026 15:04:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IGtNa9F5T/ZPQsam91EtBOSONlUmlt1eVw72/FDVleaBJ6UFyiYc3oh8d8KrXmxMjIygpTBsA== X-Received: by 2002:a05:620a:bd5:b0:8c3:650d:577e with SMTP id af79cd13be357-8c38935626bmr996311085a.4.1767913462080; Thu, 08 Jan 2026 15:04:22 -0800 (PST) From: Chandan Somani To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, marcandre.lureau@gmail.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Stefan Berger , Paolo Bonzini , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Eduardo Habkost Subject: [PATCH v2 2/5] qdev: make release_string() idempotent Date: Thu, 8 Jan 2026 15:03:08 -0800 Message-ID: <20260108230311.584141-3-csomani@redhat.com> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20260108230311.584141-1-csomani@redhat.com> References: <20260108230311.584141-1-csomani@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=csomani@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1767913531717158500 From: Marc-Andr=C3=A9 Lureau So it can eventually be called multiple times safely. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Stefan Berger Message-Id: <20250429140306.190384-2-marcandre.lureau@redhat.com> --- hw/core/qdev-properties.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c index c8379fda9d..aba55c02b5 100644 --- a/hw/core/qdev-properties.c +++ b/hw/core/qdev-properties.c @@ -551,7 +551,8 @@ const PropertyInfo qdev_prop_usize =3D { static void release_string(Object *obj, const char *name, void *opaque) { const Property *prop =3D opaque; - g_free(*(char **)object_field_prop_ptr(obj, prop)); + + g_clear_pointer((char **)object_field_prop_ptr(obj, prop), g_free); } =20 static void get_string(Object *obj, Visitor *v, const char *name, --=20 2.51.1