From nobody Mon Feb 9 19:55:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767882979; cv=none; d=zohomail.com; s=zohoarc; b=GDcH0cX6r4sCFXA54SlNy3qRPCkKqi35Rwsn8J9c8zgtEXnEbc8wQlWyfatl2+bnOv78ctI3fZn2KFkPQZUZx2tkm+x7nrO1HaA4pKvoH4gptPwMSl7oB+UySwJXLoG0wCYpZzNqnV5I/LgoQlVv8M5PIQek/X7GWfYr6uORs4U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767882979; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=NNPkfTC8hSB2O54A92j5y8SEHslcucm7cyY4HjTcIuM=; b=XcBw94UgR+mmh+IPosO2tOvi5SaAQT5pNKMaccedZydNVKcyGYkHp1hrxrrESvMO+uYzOyOtI/66bqYSXiRKXfI7rs9RdHW+TDFA2wubu2/THlZKvDyvaxZye0saRt08i1HvBl2cFLZA2iMgexT+qwU2u78WpXlO+UPMe6/n2Ok= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767882979420597.1492407035973; Thu, 8 Jan 2026 06:36:19 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vdr6B-0007D1-8V; Thu, 08 Jan 2026 09:34:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vdr5w-000729-V9 for qemu-devel@nongnu.org; Thu, 08 Jan 2026 09:34:38 -0500 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vdr5t-0000iS-Kd for qemu-devel@nongnu.org; Thu, 08 Jan 2026 09:34:35 -0500 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-47d493a9b96so19642295e9.1 for ; Thu, 08 Jan 2026 06:34:32 -0800 (PST) Received: from draig.lan ([185.126.160.19]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d8715b5f7sm40785975e9.4.2026.01.08.06.34.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 06:34:27 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id ECC525F8D1; Thu, 08 Jan 2026 14:34:23 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767882871; x=1768487671; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NNPkfTC8hSB2O54A92j5y8SEHslcucm7cyY4HjTcIuM=; b=T7AxQwtwC8nruwByO5sWdmGorgWfAgoaf+r+R6vQbZt/i14b2rgNYsuwCcJYCnWRT9 HytQzCigVx3LXpCtQK/eY+2R222cu+WAAlJxlp3Fxdr4Rfl+77RbNyUeyIqzSz+6At2D +AMfhC3RtGB8Rexu+YMgBaPWLHI+7Hu4cUo7eLY3vNmGpXifDVPQjIS42LlrfL5hzxoT K0BOgyVyfPQnD5OMXA95+AqGnzC/3VQiCV5IeVzPEuYDS7SkEA+RQYlUci1STyuXYIDT 1ZeQTWGVxEOf0iJ2m3o63oGXdh84+S4Dv2UPIP062YRmD0ZhZuWitXjPetTbqVihjpR8 7t+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767882871; x=1768487671; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=NNPkfTC8hSB2O54A92j5y8SEHslcucm7cyY4HjTcIuM=; b=jAReXz/qdFxXz44yTK+nOxdbPttcdVtIagvywWDNWX3IHxGtqz8dDtgZQCygWrtglL mecgVoN+AlMZlB8owIPTRaCrJ2XiN4NNl/xhliYPt55Hyq1KbTI5e5bizNgof2ptPDEe wBq2yc0MHEjfnPq4x39mV32veubDTCSLV8q9OJfA4r+L2ogerjAryO8bQ/TIcycaqdrl L2AE8Gs+/N9LebfErf67BHU/KJB3X+I2To2M7lY8Zz4y8XkKeAXQFlbJ3GwXwR7JDkar +mFhgRm7QfqT5c3pUO7GqwyS2Vy5WU5jjG7FN3PraqB9c+yVC7w+RZKkAvtKT8SyCCei Dibw== X-Gm-Message-State: AOJu0YyyLMmxApCfZqHGQ0mUZaxdDk3HfBapcD0RXioqH4BP0wM57yZ0 LAEqZ+jwcGSw196WHXs86a6PPK3/GFGcExAIgnnVEr8G1NZZHNvEu1l3Xkv+agnQp2k= X-Gm-Gg: AY/fxX4sGqe7FU7MZzOJxdzedF6LAVI1okfT3SJrzHSKbEmbd6NOCQR1qBbEhJ/JZr2 Ce5JfH1wDYxHJH5zdQRzNu2WseiS7eEwiaRcDNLEvBV2L7no93K3MsvebqcQ83Jr+R6sKCbknnw HyFo13S0J3CclhQWnb4rsE+5p8BQjbgt9BG12kgnw0H4enIZTgLwyO3nI+3P4ifywfcXF+eeleW fgvw4C1qhl2BoUTgCWt0fisf0Ez49duqTT8Aw7h8ioWS00q2qGiSnkR+8JYWFL7NHEXMnzoguQV eFDyJT9GWNTUjQKa2G77ku/j8LGGmDs3rbZUXE3p4DBHXPl1T9RPFsiW18WbDUzz2SqzaULoRW7 nBXmZbs69m0AqAYJ+RulgcNwC+N2TB0B75vAB4UC97usoHw3o5mKwAbpanVzjrYnZnRc6sWGVR+ WwcEYazLogPW1dNp8T1lUYVg== X-Google-Smtp-Source: AGHT+IGCbmw18fNIwlDNBzWCAdNHDFbb56mz7vbgowQfcwqwBe7oDhevb+s+QGfjbElOCftQfjfsMA== X-Received: by 2002:a05:600c:1385:b0:47a:94fc:d057 with SMTP id 5b1f17b1804b1-47d84b0b0e7mr68176435e9.2.1767882871357; Thu, 08 Jan 2026 06:34:31 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Aurelien Jarno , Jiaxun Yang , Bastian Koppelmann , Marcel Apfelbaum , Zhao Liu , Peter Maydell , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org, Yoshinori Sato , Yanan Wang , Aleksandar Rikalo , Thomas Huth , Eduardo Habkost , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [RFC PATCH 01/12] target/sh4: drop cpu_reset from realizefn Date: Thu, 8 Jan 2026 14:34:12 +0000 Message-ID: <20260108143423.1378674-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260108143423.1378674-1-alex.bennee@linaro.org> References: <20260108143423.1378674-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767882980798158500 Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Richard Henderson --- target/sh4/cpu.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/sh4/cpu.c b/target/sh4/cpu.c index 21ccb86df48..1dd21ad9ed6 100644 --- a/target/sh4/cpu.c +++ b/target/sh4/cpu.c @@ -255,7 +255,6 @@ static void superh_cpu_realizefn(DeviceState *dev, Erro= r **errp) return; } =20 - cpu_reset(cs); qemu_init_vcpu(cs); =20 scc->parent_realize(dev, errp); --=20 2.47.3 From nobody Mon Feb 9 19:55:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767883016; cv=none; d=zohomail.com; s=zohoarc; b=Y9xYNu+WCbkUnh/wPlb/fcO+p5C0+RMqEFpkfHNmvyFh850Rj7O3NNkY/KEmJ9E/ONNf8BRA9bcyaMNxHNDYXUIsUQHz8NKDaWP9/3RM6MKdDHhBisqlcM87LOo19xdR9nMCuldZCx92Azp/zC6po28W2Ujm4tkPRyPOxcPNbOA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767883016; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/KVOlUvDlycuELIbU/nTcJH/sre0/0JiNhQLMY+dTJQ=; b=VbSphS+btN3QSH4pxqW29z0QVEVtssO/K/G3hroPTRp/MNV/0RsSUh8NdhC17JjbKwJVhaXFXeJdMcHdAj0jI12TuGfhvbymlxXlLFfFn3Q+nRJ52rdnXvMv6RcS8r+6CfmtLX2WjbLtqw0fZ3vHejk/kNy3sku7ezhbU98mIt4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767883016871998.1988550766304; Thu, 8 Jan 2026 06:36:56 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vdr5y-00075D-WE; Thu, 08 Jan 2026 09:34:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vdr5q-000710-Q6 for qemu-devel@nongnu.org; Thu, 08 Jan 2026 09:34:33 -0500 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vdr5o-0000gI-1V for qemu-devel@nongnu.org; Thu, 08 Jan 2026 09:34:30 -0500 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-47d5e021a53so24563505e9.3 for ; Thu, 08 Jan 2026 06:34:26 -0800 (PST) Received: from draig.lan ([185.126.160.19]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5feaf8sm16663691f8f.39.2026.01.08.06.34.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 06:34:24 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 0C5A15F8DF; Thu, 08 Jan 2026 14:34:24 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767882866; x=1768487666; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/KVOlUvDlycuELIbU/nTcJH/sre0/0JiNhQLMY+dTJQ=; b=Y0G/a6s9bVo8awMVDkA/4gEmiSGYAYwEiw5uLNqsYQKRABJ/1u+cgLdbdXpeDgyBj9 ui439s1DAwjhoKbCsxBCCdZwiNsXhSmLUfW3IrD64oLGwydK6Ye84P+tmr2lAZ1vpHVM uAJcXlKole2GP+/gb8HP5R3TRMQ8fp5Ic3XJOYOlhGyg1IvBRsOrG+bdm1bK5Pt0AJCd uXxxjQP9ujtjowymT2NdxxhE2dNqlfD5dR6q7QM0DMNqc0fTpeejhPic73ifvf49Ciwt jFw+jNjhjW3pAk3lAT3w+e/d4BBvktcHTn5gQkFmjHqyz+AO5TXjJKQvbHXQ85S6DWct qibw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767882866; x=1768487666; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/KVOlUvDlycuELIbU/nTcJH/sre0/0JiNhQLMY+dTJQ=; b=XV691YzLNtg6NXiPjtmNSGyjGWYxNi0TBZeL3vphlHo57AUjD600P3Oep0xjs0mrdS yUTiWC1Py5T9t9WV+JVFcekVmLdFCM2hH3oO6PHcwNcN4fnnUX3c83xGlpzmnYrMNTtv LIiTHL4gS6ZHkFhGUhPcnSMfSH2hQoqmEdRJaU9ENSHyU8MKaq55TCFLbhr3ow4NMQ4N HjCvXmYcmY8M6j/XqROpx1IMHhjFqEiFTD/kSNY8zVWGv+tQdGb/aN/T/cniN7icf/DT syevfyf2DUTX0X3RcEaKZGmoNQV2Orxd5OF8zBgMjJnnjwYcyZQ35LK3wjftA6pf61fW sFww== X-Gm-Message-State: AOJu0Yx5MRH1WfGnDIu23pWtf/bhBZ5crPjq7pO5aErFl49oJk5lipVx jkRbVWJOWkmH3xeScPSbHjGhHRGtsER1780KXzHdUNoeSfAk+A9wwtB5H/UajGjbF/s= X-Gm-Gg: AY/fxX7IlSFrYrfm8UlSf9ViR1d6Xm+sU1W8DkJP53g/a7Rltb8dgsjGfvfBWvobGA3 d6BtiOsJmR/RLj1u6yQCQOmYkvXsXKuTbgtLFup/bP6saWgisKX3d0dSUsBfgrZFUycm+RtazDX E7+yEFaSg+U7v6hwX+lPVR9c5NY1X+YMuEVokXp/uE5GV2iqlz+8LB+3s7cfnOGxqhRecXiHre6 vQ36eR19RjG/L6UQUN8T8Vp/29d4k0v+LGcHthMabwhqU9+ZrLtgebj8ZGrzdzBl9DTozDVrwlw qDC8nbWcd/Jf2UpIAYIxc/R0XC4pdWXokDoNwVxY2F3vtAvMoGA0qh4aJzFS/EjZUtVU0ViixLw COQMIPx8b7C4yCH4MXGiE/MwYAaNJdRI9g4tYyyLNOOFH2ruxCVIuw2NG3qH1so+Gll/m7gCG99 ejh4muZ/8UAWQ= X-Google-Smtp-Source: AGHT+IFrigIMRj1Fu7UQDZqoA4+G8mVP/VMqzMDX7eqsu7W3FCGzgFfrtVM8wmwRw8nFA5cmiRpzNA== X-Received: by 2002:a05:6000:4284:b0:432:bc90:2cfa with SMTP id ffacd0b85a97d-432c374f5b2mr8866039f8f.33.1767882865561; Thu, 08 Jan 2026 06:34:25 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Aurelien Jarno , Jiaxun Yang , Bastian Koppelmann , Marcel Apfelbaum , Zhao Liu , Peter Maydell , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org, Yoshinori Sato , Yanan Wang , Aleksandar Rikalo , Thomas Huth , Eduardo Habkost , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [RFC PATCH 02/12] target/m68k: introduce env->reset_pc Date: Thu, 8 Jan 2026 14:34:13 +0000 Message-ID: <20260108143423.1378674-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260108143423.1378674-1-alex.bennee@linaro.org> References: <20260108143423.1378674-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767883018961158501 To transition CPUs to use the multi-phase resettable logic we need to stash some information for the reset handlers. Arm does this with arm_boot_info but for m68k all we really need is the PC we should reset to. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth --- target/m68k/cpu.h | 1 + 1 file changed, 1 insertion(+) diff --git a/target/m68k/cpu.h b/target/m68k/cpu.h index d9db6a486a8..fda015c4b7b 100644 --- a/target/m68k/cpu.h +++ b/target/m68k/cpu.h @@ -155,6 +155,7 @@ typedef struct CPUArchState { =20 /* Fields from here on are preserved across CPU reset. */ uint64_t features; + uint32_t reset_pc; } CPUM68KState; =20 /* --=20 2.47.3 From nobody Mon Feb 9 19:55:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767882977; cv=none; d=zohomail.com; s=zohoarc; b=e4soIl3Dn+QEKt9GGl/w176yFYLrtE0cnpRq6ZQCzYW35BXaCQ3vpBya60Od4ij40fbBXvzdb4f7J0pA/jrzbjUutHkHq+pdUC66g89bNG5cs9QSR547t2PUNfCGibR+gdGFCHAOytOXJ8UWPQCilrvV7HIhrCsiy0DJwDgdNB4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767882977; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=xegit4ejNTk5f0W5DGBT7IrkTCynuOYYrskO3sfAUpw=; b=GXmUvUm5vsuu0+kTs5ES6EfFCToFD/tLvfpqAi07+xXub2DrumiNnjkt4oSr6ubQqAOKorh4h6VmSx81aReBFAaQVXVgbThpDqu3PKnvIhWN2xuwYP8A/HAUkiOnBO778lk3jD8BzrL8X16LlUhEzu3upgCBmJARgBGXxvznqns= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176788297694730.947229133277915; Thu, 8 Jan 2026 06:36:16 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vdr61-00076E-Mz; Thu, 08 Jan 2026 09:34:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vdr5q-000711-Vx for qemu-devel@nongnu.org; Thu, 08 Jan 2026 09:34:33 -0500 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vdr5n-0000gM-Vr for qemu-devel@nongnu.org; Thu, 08 Jan 2026 09:34:30 -0500 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-47d1d8a49f5so21974595e9.3 for ; Thu, 08 Jan 2026 06:34:27 -0800 (PST) Received: from draig.lan ([185.126.160.19]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f410c6csm167037385e9.1.2026.01.08.06.34.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 06:34:24 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 21A055F8ED; Thu, 08 Jan 2026 14:34:24 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767882866; x=1768487666; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xegit4ejNTk5f0W5DGBT7IrkTCynuOYYrskO3sfAUpw=; b=HLpPbAvlBYEuciJnAg7EivyOW+LuSPk3JAulHjUj09RdTwuxwJqy+ckyKgfQSqm0Mn TnHFPRYgvBzvZ69hx8hK/aQMYqiKQYJSuKUUCmSM5neGqYdePXVW2RAKi34QZWX/mf/+ iEhbUMG61bMt5sVILtbC3+Px55YDKKObMy55yvl4QoE/HEv5S5vJiGjGJAgVnlnKOSKQ acPAo34zdYI9oO9wpnb74OzJEXUNLgDAUkRNXBWrXb7G8cpnwwC9bViqQ9L6dBG5B7i+ /EZKJX4apDSpAUXdWD7z8T5J/kvqGxg81QcBtCWP+jy36vhekb509ezA4eY3repaNxtF q3lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767882866; x=1768487666; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xegit4ejNTk5f0W5DGBT7IrkTCynuOYYrskO3sfAUpw=; b=cI3xcjyGDZkKoJdmyPF4Mx9krWfeVAtousE8kwKrDI14m0TVgB5XL+P5apckwKUGxJ 2S6Bg65OOf0rRWKKAlTbVlNGfTfKEsbAIUsk+44tIpYSjKvMr7vPjaJEgBMSKVaTyLe6 4xFiZA4S4MUzTBjEnXcgX2jydHysobNrUIAPX2RrgYf6o7eiyMgK2IBwaPgGHZS3tvB1 17ZbVZhzEBC5Yi+Zz0pQuY8nvadxmAqqLqKoweNDHYzB3165/OxpzUEX0qFeHr6ckX5V fk5H1a78mu0x7ByPo4R/Er0Xnx4TOmyiAqXXwON/XHPedFwRpVuGjHLr8JonM2teIe7r 79Iw== X-Gm-Message-State: AOJu0Yx/E1zFn0KCkPw80pJcPOMu9SJvnGnPLiZYRq7clpDWBt0EtzyB LeEPwxOLXePy4cMplIgmNiANjGnEzyqplruDyymbSucHPmmLlAezIFXCUjGQXqROJII= X-Gm-Gg: AY/fxX6SKOt7paLH8DV4UX+uEryHnqQTZotUqPwuNv5KcuuOw9i5Lv4KFKALXk/LrJC x0QfP2LYjz0Egz/V/o2BdxxaC/pPenAUB1duCckL0kJGD8MTD/q/wIkuy5uTNSzztQ++9epFmfS f0o2cG8h/JH2HiBTYAuOXrGnyPIM9+1/rgQy7wAY2QCeyPxdxPKg6iQkbzafhJlQYFdrGkAE1nL XSzkL62ZUQzro9ocly5MoJ65/levl3o7+utvXgb0ZmfEaXr/0cz0rTu85jnzB/ZZ7KgsITdAEWt CRaxnAhSoEP674fg6YwS0mrr8ye8HmrUBuFVHN1Nz+mT5o2kEVbcoxWpoyVOwCfnQ1kYrHLFtUk KdWN7+Rx//V3W0iy0ARXOc57MLhbc4waRRc7JWBwMDSDB9utfJo9R1aF1SRunT+ih4OE3SZTZz3 +t9KBHyPr7Sdc= X-Google-Smtp-Source: AGHT+IEx+WjdFSQNuvpe/UppetDTRNkYuwVaL12fCmNTmDl4lE5Wr+4Uohf6JheTbqrvNh2aXPuT0A== X-Received: by 2002:a05:600c:470c:b0:477:79f8:da9d with SMTP id 5b1f17b1804b1-47d84b3b522mr82961925e9.24.1767882865921; Thu, 08 Jan 2026 06:34:25 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Aurelien Jarno , Jiaxun Yang , Bastian Koppelmann , Marcel Apfelbaum , Zhao Liu , Peter Maydell , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org, Yoshinori Sato , Yanan Wang , Aleksandar Rikalo , Thomas Huth , Eduardo Habkost , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [RFC PATCH 03/12] hw/m68k: register a nextcube_cpu_reset handler Date: Thu, 8 Jan 2026 14:34:14 +0000 Message-ID: <20260108143423.1378674-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260108143423.1378674-1-alex.bennee@linaro.org> References: <20260108143423.1378674-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767882979359158500 This is a fairly simple migration to the handler. Alternatively we could eschew stashing the value in reset_pc and just re-read the ROM on reset. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth --- hw/m68k/next-cube.c | 23 +++++++++++++++++------ 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c index 26177c7b867..3d66f5e7607 100644 --- a/hw/m68k/next-cube.c +++ b/hw/m68k/next-cube.c @@ -16,6 +16,7 @@ #include "exec/cpu-interrupt.h" #include "system/system.h" #include "system/qtest.h" +#include "system/reset.h" #include "hw/core/irq.h" #include "hw/m68k/next-cube.h" #include "hw/core/boards.h" @@ -1249,6 +1250,19 @@ static const TypeInfo next_pc_info =3D { .class_init =3D next_pc_class_init, }; =20 +static void nextcube_cpu_reset(void *opaque) +{ + M68kCPU *cpu =3D opaque; + CPUM68KState *env =3D &cpu->env; + CPUState *cs =3D CPU(cpu); + + cpu_reset(cs); + /* Initialize CPU registers. */ + env->vbr =3D 0; + env->sr =3D 0x2700; + env->pc =3D env->reset_pc; +} + static void next_cube_init(MachineState *machine) { NeXTState *m =3D NEXT_MACHINE(machine); @@ -1264,12 +1278,9 @@ static void next_cube_init(MachineState *machine) error_report("Unable to find m68k CPU definition"); exit(1); } + qemu_register_reset(nextcube_cpu_reset, cpu); env =3D &cpu->env; =20 - /* Initialize CPU registers. */ - env->vbr =3D 0; - env->sr =3D 0x2700; - /* Peripheral Controller */ pcdev =3D qdev_new(TYPE_NEXT_PC); object_property_set_link(OBJECT(pcdev), "cpu", OBJECT(cpu), &error_abo= rt); @@ -1335,8 +1346,8 @@ static void next_cube_init(MachineState *machine) /* Initial PC is always at offset 4 in firmware binaries */ ptr =3D rom_ptr(0x01000004, 4); g_assert(ptr !=3D NULL); - env->pc =3D ldl_be_p(ptr); - if (env->pc >=3D 0x01020000) { + env->reset_pc =3D ldl_be_p(ptr); + if (env->reset_pc >=3D 0x01020000) { error_report("'%s' does not seem to be a valid firmware image.= ", bios_name); exit(1); --=20 2.47.3 From nobody Mon Feb 9 19:55:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767883026; cv=none; d=zohomail.com; s=zohoarc; b=LS1fElf48y/YN6Wb27L8NCCN+aXQelOoiV/PiCdWA8eqt6g4TAIDbPFj5I6xY02o+Ko/MZIMn2lwi4lEbH/16JOGXlLxWbtsceGIRKM76+m1pValvhTxKt7a9lTXkomL5/S8MMWmOG9xxMn0hArhvqHSb5v9mSJVTpPVnC2opyU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767883026; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=JrvdGZYfUVb/G7Ck+UxozbwBKfyc29iJxW1XdKqiM0k=; b=dyyHZQXe3A3gPXUwiwzPlnNKqMThCo+TYjHiQePnmgqAaZvz1q4aTMx/bMLcWw1+mpdgJo5ZfLMKfF3RZv4H7CSW4m/zavJiED+cD3KEGtFK0Qr1mtJIIIZ/szUn17suE5hzN4lP/yGE+IXEzes9RneMBSP2Q8wIXhtj5I5tke0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767883026465153.42133402872776; Thu, 8 Jan 2026 06:37:06 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vdr5z-00075O-KL; Thu, 08 Jan 2026 09:34:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vdr5r-00071B-3u for qemu-devel@nongnu.org; Thu, 08 Jan 2026 09:34:33 -0500 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vdr5p-0000gm-8C for qemu-devel@nongnu.org; Thu, 08 Jan 2026 09:34:30 -0500 Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-43277900fb4so925423f8f.1 for ; Thu, 08 Jan 2026 06:34:28 -0800 (PST) Received: from draig.lan ([185.126.160.19]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5df939sm16366478f8f.21.2026.01.08.06.34.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 06:34:25 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 351915F90C; Thu, 08 Jan 2026 14:34:24 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767882868; x=1768487668; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JrvdGZYfUVb/G7Ck+UxozbwBKfyc29iJxW1XdKqiM0k=; b=WyGdm3xQ59BQsfUKgWOkLSVQzWu9j/s9Zkw+xNuHNdXgi+GOujx87FAOevePisW8pJ foJo2lXXNSMZqMm+E/HuIsuarocykrHXcbHuSod+bOJ6baXY9smCM/0nP8qpct+dN0bD oVxL5hYVIq6oN7suCKVWg8V17AnmjdUgB7QxArTEB5KpHA/ZaQAMPc5ASLKJ2mnZtsZT U4bfn5qJZH48ULHsEQsMaLZiWmSB7Jr5FPb+F7EaFNlDOhcvQvp2Jj7Zreir2uQLYuzj 2jGhJac2JMVg3vdY9kecBcG0Ur8wV6NbIOi3fxQ3o48641y8c9vEqeo0/bQI2WlWTwvB ZDqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767882868; x=1768487668; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=JrvdGZYfUVb/G7Ck+UxozbwBKfyc29iJxW1XdKqiM0k=; b=g3CBxA65SRjl15HL0KOO54p3TWB7vhdv3m5DgF7lc8fe/DiaQWmgsfe6I4t15fM9Xd KTy9czjvp11WeyuopTQkydFnEQq6syCill8ohfLdUynezf6RsFRRNP/OWwaoJyLQ2WnM 56UxdyNUXWRWDOXZvLWG7zrRZqHRSlKfdKOx5JaOG1uQmAQYh2bKKyQJTZHHnpFnI2VS VCYsE1706IR4s70TKS/QDCvUFHCPiKPRwIcoeZjz1argSLTrxtNcDzhJf310+iasbpUL hD//x3pKYSk8AXBex/bmoXKeFQI1Jvh0d4eDV8Mg0n7JfGZMKaTr01OiPwEPDQXZFSsy vOqg== X-Gm-Message-State: AOJu0YzJmsxpHdNnpjhNCkMkRG9NSkzzoBK57pY2JgBH/9jEzSPxV0wI h2ip/6Hsy5dGmZf/7g7OvDjwHITyh/6F6WSB+T/FpnP4iU0DEQHye6IgsfTclredpn8= X-Gm-Gg: AY/fxX759gEhY4ZliS7bozWvMpYcS7zS+1sH1cK41pOnGSH0k0vBSWYY3mkVvPtAmMK FtoqEyBVH1AR3UU26m//tOpdV0JelFCkLMLgj9FFzCFjlkRc50NbWmRlSxShJz01CbmtNrWBtts uTpBXf2g03RTzXXQIpKQLRDzZFPZtypeERkb+LzJXtggnz+Fz+gYTRbl6w2oAz8i3VQ5gyNaQnb TwgePwlanYECqAOIQZFVdJBr+T6bDgdvxfkvjCnbu+FZJzGA1ASM6vLFScs6IqbPYZBGaE+R6JN a10g61JicqRYcqLtgEyMMO5+frRqfFbOHGsCrDP/frHrP+RRDgBkuaeRWqScyL3Eocp10OJxmw7 kdtDiQU4w4JDh2ulPjfFJ/9xGI5pVS4cuxzk2pvNstSrmUQ3zIKB9TOdLNZ9Fxgwz0nRsTo4M2d b3jtR4n+QJOk8= X-Google-Smtp-Source: AGHT+IGDHIfwJErYbSMAyAu5Hd64Y5pQD62DUstZYKJavFXL02WDUeDl9svWVvVL744sh9c/Ayw0Dw== X-Received: by 2002:a5d:64c7:0:b0:431:327:5dd6 with SMTP id ffacd0b85a97d-432c3634312mr7519174f8f.8.1767882867572; Thu, 08 Jan 2026 06:34:27 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Aurelien Jarno , Jiaxun Yang , Bastian Koppelmann , Marcel Apfelbaum , Zhao Liu , Peter Maydell , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org, Yoshinori Sato , Yanan Wang , Aleksandar Rikalo , Thomas Huth , Eduardo Habkost , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [RFC PATCH 04/12] hw/m68k: register a mcf5208evb_cpu_reset handler Date: Thu, 8 Jan 2026 14:34:15 +0000 Message-ID: <20260108143423.1378674-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260108143423.1378674-1-alex.bennee@linaro.org> References: <20260108143423.1378674-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767883029602158500 It looks like allowing a -kernel to override any firmware setting is intentional. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Richard Henderson --- hw/m68k/mcf5208.c | 25 +++++++++++++++++++------ 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/hw/m68k/mcf5208.c b/hw/m68k/mcf5208.c index c6d1c5fae9f..5680d516a23 100644 --- a/hw/m68k/mcf5208.c +++ b/hw/m68k/mcf5208.c @@ -27,6 +27,7 @@ #include "qemu/timer.h" #include "hw/core/ptimer.h" #include "system/system.h" +#include "system/reset.h" #include "system/qtest.h" #include "net/net.h" #include "hw/core/boards.h" @@ -274,6 +275,20 @@ static void mcf_fec_init(MemoryRegion *sysmem, hwaddr = base, qemu_irq *irqs) memory_region_add_subregion(sysmem, base, sysbus_mmio_get_region(s, 0)= ); } =20 +static void mcf5208evb_cpu_reset(void *opaque) +{ + M68kCPU *cpu =3D opaque; + CPUM68KState *env =3D &cpu->env; + CPUState *cs =3D CPU(cpu); + + cpu_reset(cs); + /* Initialize CPU registers. */ + env->vbr =3D 0; + /* TODO: Configure BARs. */ + env->aregs[7] =3D ldl_phys(cs->as, 0); + env->pc =3D env->reset_pc; +} + static void mcf5208evb_init(MachineState *machine) { ram_addr_t ram_size =3D machine->ram_size; @@ -289,11 +304,9 @@ static void mcf5208evb_init(MachineState *machine) MemoryRegion *sram =3D g_new(MemoryRegion, 1); =20 cpu =3D M68K_CPU(cpu_create(machine->cpu_type)); - env =3D &cpu->env; + qemu_register_reset(mcf5208evb_cpu_reset, cpu); =20 - /* Initialize CPU registers. */ - env->vbr =3D 0; - /* TODO: Configure BARs. */ + env =3D &cpu->env; =20 /* ROM at 0x00000000 */ memory_region_init_rom(rom, NULL, "mcf5208.rom", ROM_SIZE, &error_fata= l); @@ -359,7 +372,7 @@ static void mcf5208evb_init(MachineState *machine) /* Initial PC is always at offset 4 in firmware binaries */ ptr =3D rom_ptr(0x4, 4); assert(ptr !=3D NULL); - env->pc =3D ldl_be_p(ptr); + env->reset_pc =3D ldl_be_p(ptr); } =20 /* Load kernel. */ @@ -388,7 +401,7 @@ static void mcf5208evb_init(MachineState *machine) exit(1); } =20 - env->pc =3D entry; + env->reset_pc =3D entry; } =20 static void mcf5208evb_machine_init(MachineClass *mc) --=20 2.47.3 From nobody Mon Feb 9 19:55:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767882979; cv=none; d=zohomail.com; s=zohoarc; b=DKu0yt2TliFh6T7TSbpO5ba2OARkhKROjhDMl8WO3/BDg7m6kxojm2xipB14fwHCaeaUbZuhXJpgeAXAAGw4UvTBXcMsHYxkwFUKZX72kKjiM6rk7Xb+K+B25ZeRk4opW3LGUCsKa62JVmr21iWjrP3hgDgFpBEEH97SFhsfRM8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767882979; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Sbu0M+maxtcRxXrgLFp4j1Dj8ytESdyrwiWOp43GF9w=; b=nYB/l+eMETe2PxaQ/Tn6bt82juQmepcjRjQXtTHB+ONC2ayJte2XsBXJnTI8u3V7RO7qngoQPkrOVPmG6XNRs52+uyx08YL9DfozuaVTyBRRHjsJHwJhfQeNEp6e2wZCLJhcgucpGlguog9/VyFdyfdLt9DugtZ1+hiqxKXsjsQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767882979721372.194811403332; Thu, 8 Jan 2026 06:36:19 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vdr6G-0007QY-H9; Thu, 08 Jan 2026 09:34:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vdr5x-00072S-Uf for qemu-devel@nongnu.org; Thu, 08 Jan 2026 09:34:38 -0500 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vdr5u-0000in-36 for qemu-devel@nongnu.org; Thu, 08 Jan 2026 09:34:37 -0500 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-47d3ffb0f44so21690025e9.3 for ; Thu, 08 Jan 2026 06:34:33 -0800 (PST) Received: from draig.lan ([185.126.160.19]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d86637b90sm42599195e9.2.2026.01.08.06.34.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 06:34:27 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 48F365F917; Thu, 08 Jan 2026 14:34:24 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767882873; x=1768487673; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Sbu0M+maxtcRxXrgLFp4j1Dj8ytESdyrwiWOp43GF9w=; b=gn2BDc8Db/3PE20HBSfrSfyEvv3tAhXbrAG/OBYrOiM5avEcOWyluVpQGLhNojzbqb cfN5hBYcIylkU6EgI/uj3/t76/2lZlZ7lEIhsXGINzU9DEJy1G4RYd9vCgBAXygjpksl KFcufQ5o14E6fHG5uxPAPn3eW2CFLK4okQfeikOcL/7SVmFgoQApfDZpdusRI1JHBfBK TZlDmZPdadJLVwTywwL/yL2+m3lwVCEP7UiLIKW9qQexx1XB5d3kdRTUdyRs2i5BsTCu 58z9eZXmTOgrVJzO1krHiM+/Qcbc7C8yD7LG9X9GYR0ktJGD7g55pQydDfN33PRhtqge HUdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767882873; x=1768487673; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Sbu0M+maxtcRxXrgLFp4j1Dj8ytESdyrwiWOp43GF9w=; b=ftlkGJW+faMXGgSLKaVhMMCFghlDG0kYaoNwJuVrSN+Gc+2QCD/DhZjUgkTf8/XO/i WJqWIn5cPVo92AlaCHesZvzz35aCg/ps/qOFDnVb4kWjIzZqGeqPuZPLA/Gn/1aw+JG/ SuhA7Ty98qotVTT65++hpm35mXMX9k4wty01+7J4rtI6TjzddsXPiThzWu74I79U4I/J 7u1/zTMbss4wvxAGICG0p+xxgWQ7Y7awc9Uw2jjtg0tDEnN2GJSZqhbqEVK1KFUfbXKU k0x8oa/CXCkzyc9QPTyZRF6tNcBINJyEW7BvDqaI+VPESVqjT47piXbMADGL/VHYDXUu DBjA== X-Gm-Message-State: AOJu0Yx0/iQ4OjcdheiPfkKHxiUT66aSdFTPwhMq1CTlj0Fm4FxOxmQj B/hemHKj6MSYXaE4Iuu/7nDN5DQD4VrtrACMoKzlP3+fMq+PBdgn2qGNd9RhJqj4eSysHmB0DPp eIx8u X-Gm-Gg: AY/fxX4iX2J7sp45ocV31BBOG5ShGu9IRGNqOPhQNBG+CUa/J7hiO9J5nAlsjtjrfCb GLNVrt2xgultecGn2bD9UjH3TItgOUAbPUrbtFXtmeoiD8Y8kH4z3qNaFiXqU4l5tVCqPEkYPP2 vJRVMU4jhIkXoP0Cb3RtEGZ1Kvie1CDWXQa53fnnejNg9kjyIMPnRWBxCBa45DmMZPFB0i4Crs3 Rh27uVG1LPq/Ja16I6fMvEBczSU0gm5Q3SldiUgwOYlYXj7JJzrzoTrfcSAeInwXvAQ116NYlFu B6VgOV5vY9QhL3oWa7SsQLmvORrtUxVTwlhqD65LxRI/+yPGtQs8O3DceL4wcrA5xVK1wjkAdib /lH1G5a70oBqZrzZYCrR9J8IkZrY5NGQhuSrAV6mZInBJxJn7sZPi+OQlca4hhB0v0kRwsZI1a+ IjMYRSucu0Czyf7mxkNB/Msw== X-Google-Smtp-Source: AGHT+IHHSKKF+8FsIcUnpmA+HxWnW4K6jZYoR2rUxPtSe+qc42mC3oncWJhn1rGbKjit/NRtcIjHyw== X-Received: by 2002:a05:600c:620f:b0:477:9fcf:3fe3 with SMTP id 5b1f17b1804b1-47d8f34f2e2mr6490295e9.0.1767882872578; Thu, 08 Jan 2026 06:34:32 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Aurelien Jarno , Jiaxun Yang , Bastian Koppelmann , Marcel Apfelbaum , Zhao Liu , Peter Maydell , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org, Yoshinori Sato , Yanan Wang , Aleksandar Rikalo , Thomas Huth , Eduardo Habkost , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [RFC PATCH 05/12] hw/m68k: register a an5206_cpu_reset handler Date: Thu, 8 Jan 2026 14:34:16 +0000 Message-ID: <20260108143423.1378674-6-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260108143423.1378674-1-alex.bennee@linaro.org> References: <20260108143423.1378674-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767882980800158500 As the mbar/rambar0 values are currently fixed we can migrate the setting of them to the reset handler as well. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth --- hw/m68k/an5206.c | 24 +++++++++++++++++------- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/hw/m68k/an5206.c b/hw/m68k/an5206.c index f92a5d6a339..918c376a384 100644 --- a/hw/m68k/an5206.c +++ b/hw/m68k/an5206.c @@ -15,11 +15,26 @@ #include "elf.h" #include "qemu/error-report.h" #include "system/qtest.h" +#include "system/reset.h" =20 #define KERNEL_LOAD_ADDR 0x10000 #define AN5206_MBAR_ADDR 0x10000000 #define AN5206_RAMBAR_ADDR 0x20000000 =20 +static void an5206_cpu_reset(void *opaque) +{ + M68kCPU *cpu =3D opaque; + CPUM68KState *env =3D &cpu->env; + CPUState *cs =3D CPU(cpu); + + cpu_reset(cs); + cpu->env.vbr =3D 0; + cpu->env.mbar =3D AN5206_MBAR_ADDR | 1; + cpu->env.rambar0 =3D AN5206_RAMBAR_ADDR | 1; + + cpu->env.pc =3D env->reset_pc; +} + static void mcf5206_init(M68kCPU *cpu, MemoryRegion *sysmem, uint32_t base) { DeviceState *dev; @@ -47,14 +62,9 @@ static void an5206_init(MachineState *machine) MemoryRegion *sram =3D g_new(MemoryRegion, 1); =20 cpu =3D M68K_CPU(cpu_create(machine->cpu_type)); + qemu_register_reset(an5206_cpu_reset, cpu); env =3D &cpu->env; =20 - /* Initialize CPU registers. */ - env->vbr =3D 0; - /* TODO: allow changing MBAR and RAMBAR. */ - env->mbar =3D AN5206_MBAR_ADDR | 1; - env->rambar0 =3D AN5206_RAMBAR_ADDR | 1; - /* DRAM at address zero */ memory_region_add_subregion(address_space_mem, 0, machine->ram); =20 @@ -90,7 +100,7 @@ static void an5206_init(MachineState *machine) exit(1); } =20 - env->pc =3D entry; + env->reset_pc =3D entry; } =20 static void an5206_machine_init(MachineClass *mc) --=20 2.47.3 From nobody Mon Feb 9 19:55:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767883036; cv=none; d=zohomail.com; s=zohoarc; b=irLvGK2TfpDIdVgBzj7huDSkfDC2kBvuxuyOmfuoBkz+30NGe9apPuBeCRpbOr7uWQbrauR0cSY0TtkcLH2RQtpvOxnyz2P+lAdpyhEY1DB13e1XvG6h7xmHt/zDJPBCzivrd+NPUC8EArwQFjACyW1ndcX1aHPy8k23iaa5Al8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767883036; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=CJzuVbaZdIwgkAzM484kEZrNbs3ZhkcE6xTd5j2Mceg=; b=d03wohsQS2JH87hFAoGroK+Lklh7wiKbxUx0CGkpZLh2sIuM4efQJpLAY8LLDMR6lL5VLMJtLwOXu/ACRWc/gEweFE0Peph+pYMcLFcg5jyFOPgm7oG5oUrpBDCNnjxu+w1x8qZSgYBHkpweC92u5c13E+0AIFkPFk9JDc5J4Ok= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767883036343875.1466319961064; Thu, 8 Jan 2026 06:37:16 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vdr6A-0007CP-W2; Thu, 08 Jan 2026 09:34:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vdr5x-00072E-8b for qemu-devel@nongnu.org; Thu, 08 Jan 2026 09:34:38 -0500 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vdr5t-0000hm-Qs for qemu-devel@nongnu.org; Thu, 08 Jan 2026 09:34:37 -0500 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-47d3ffa6720so33702405e9.0 for ; Thu, 08 Jan 2026 06:34:31 -0800 (PST) Received: from draig.lan ([185.126.160.19]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d8719e695sm37602105e9.17.2026.01.08.06.34.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 06:34:27 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 6156D5F943; Thu, 08 Jan 2026 14:34:24 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767882870; x=1768487670; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CJzuVbaZdIwgkAzM484kEZrNbs3ZhkcE6xTd5j2Mceg=; b=HYygImr4GhSEdt1R/SIEM+pDUdO/MLWXiAIlyg60A2D7iOkfkyc+ASIL8LdRoUyDcX o0tlFgzlwHsAcuL+6svx36tTurp4oJbD5AwEwF1b4tnT3Ztmg26+4tylczwPC7/DZkWo g+wvu/DnzehhcreiVR+HKqquU9LSuThe1cbe9WmhDhmbM02/MjiMZB0BqlqHeHf4I1LN Bz8QVfTJ5uDtnB/dU78Z/2rRjqJR3FzIKZ5aJry44ap4HoabZiuX1pflO4X3ba8x29mh 2fmwqDYHlZrq9nhuxnwER9w4dPt5ABrQbU2BII4x8QRvE7yi7w8BH9OLbEokVvvoLq5+ O/wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767882870; x=1768487670; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CJzuVbaZdIwgkAzM484kEZrNbs3ZhkcE6xTd5j2Mceg=; b=RsbbPRQVmWdKcPFr6WilXGcXf0oPwccDb/VoazdDCpUQBCMbboXaJpt1K8tYwgeSoA RFGxv4uZ+5FIQ9RLG6cIxNxIO8b7TgklraROg75EfNIcBhf7CxC4adiuGxHu0jAZB3xN WUTdvam9K6nmr4YCB/T7+NpbxqUhw8oy4mZCCxeY68jcAo8LrH6XcebsggzAFmVm2kKT TfxufNYL0rjwneRXuv4GacKfnMpvM+BkgqTGVxd0HpmzyCWadBChHeEy2o/g/GHPgwuI sVtvEUyiNsaGynAgKUowIltbaQ8R8CwwbAq9Xn7tpoDxBUS7eQyv7FWSQSLuoIbw4RCN q+Tw== X-Gm-Message-State: AOJu0YyLQeHTLDmUXh37qU5fRPc9bY0FkIlL87a+OG3WT5YX+TnGrL+/ s4drb2oL6GJGS7NY6BTh4hs4md5MdpIqlJLJ4lzhcaFaFHOu3ImZyT4r1rz69b0pTHI= X-Gm-Gg: AY/fxX6QYuO6wGfiu1Kc2EJY7QJmv8/ZNvlxCaZvhlWAwN5KaAVDCagPCo1h6giddGS VtDze67LYqOl9mzQ75of1ao5WqQw5O2m84i9RL1wydfgLkAGCkqwNkM9Tkt/k50eSKZXZRWxEVp NYTTSWRZNAVgOaEgJfVvXfcJDkoygeZIQInescgCpdN5H9DOjPVT/FFOMgtCwbzznDO36vn2SN+ ttCTt2KWdGKy5CUDICClwjfkdMH2VHrpH1J7loBsIkE5km3gaHBXk4wyRF2BXtDjZyCtkJkcNB1 qt4R5dhEqK2AwEl6fWXDKfDqdth1KGqfcfOuPBq4hKepyyBbKxAbURQm+2V9lLwbeSJ0lwqTwgR L48T3Jx9qD1bo4LL9XmCVyqzUIoj9hcwoKzaeNh6JcynDerZz/yuqAYUiAf6wMK45MRFfMjon2p PooPW5B6P33AOvP7Sl2G83eQ== X-Google-Smtp-Source: AGHT+IEszrccpcodAmK2Okm4qvXdSHUt71l38BB9KgWymhwhe6pMkgAQT1Emcr+HTay4HgOGZdg82w== X-Received: by 2002:a05:600c:4fc6:b0:477:5ad9:6df1 with SMTP id 5b1f17b1804b1-47d84b0aaa3mr69677235e9.3.1767882870170; Thu, 08 Jan 2026 06:34:30 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Aurelien Jarno , Jiaxun Yang , Bastian Koppelmann , Marcel Apfelbaum , Zhao Liu , Peter Maydell , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org, Yoshinori Sato , Yanan Wang , Aleksandar Rikalo , Thomas Huth , Eduardo Habkost , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [RFC PATCH 06/12] hw/m68k: just use reset_pc for virt platform Date: Thu, 8 Jan 2026 14:34:17 +0000 Message-ID: <20260108143423.1378674-7-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260108143423.1378674-1-alex.bennee@linaro.org> References: <20260108143423.1378674-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767883037157158500 We never actually set initial_stack so revert to the previous behaviour and stash pc in the common env->reset_pc holding place. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth --- hw/m68k/virt.c | 24 +++++++----------------- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/hw/m68k/virt.c b/hw/m68k/virt.c index e67900c727d..6af74b7ba1d 100644 --- a/hw/m68k/virt.c +++ b/hw/m68k/virt.c @@ -87,21 +87,14 @@ #define VIRT_VIRTIO_MMIO_BASE 0xff010000 /* MMIO: 0xff010000 - 0xff01f= fff */ #define VIRT_VIRTIO_IRQ_BASE PIC_IRQ(2, 1) /* PIC: 2, 3, 4, 5, IRQ: ALL = */ =20 -typedef struct { - M68kCPU *cpu; - hwaddr initial_pc; - hwaddr initial_stack; -} ResetInfo; - static void main_cpu_reset(void *opaque) { - ResetInfo *reset_info =3D opaque; - M68kCPU *cpu =3D reset_info->cpu; + M68kCPU *cpu =3D opaque; CPUState *cs =3D CPU(cpu); =20 cpu_reset(cs); - cpu->env.aregs[7] =3D reset_info->initial_stack; - cpu->env.pc =3D reset_info->initial_pc; + cpu->env.aregs[7] =3D ldl_phys(cs->as, 0); + cpu->env.pc =3D cpu->env.reset_pc; } =20 static void rerandomize_rng_seed(void *opaque) @@ -129,8 +122,8 @@ static void virt_init(MachineState *machine) SysBusDevice *sysbus; hwaddr io_base; int i; - ResetInfo *reset_info; uint8_t rng_seed[32]; + CPUM68KState *env; =20 if (ram_size > 3399672 * KiB) { /* @@ -142,13 +135,10 @@ static void virt_init(MachineState *machine) exit(1); } =20 - reset_info =3D g_new0(ResetInfo, 1); - /* init CPUs */ cpu =3D M68K_CPU(cpu_create(machine->cpu_type)); - - reset_info->cpu =3D cpu; - qemu_register_reset(main_cpu_reset, reset_info); + qemu_register_reset(main_cpu_reset, cpu); + env =3D &cpu->env; =20 /* RAM */ memory_region_add_subregion(get_system_memory(), 0, machine->ram); @@ -235,7 +225,7 @@ static void virt_init(MachineState *machine) error_report("could not load kernel '%s'", kernel_filename); exit(1); } - reset_info->initial_pc =3D elf_entry; + env->reset_pc =3D elf_entry; parameters_base =3D (high + 1) & ~1; param_ptr =3D param_blob; =20 --=20 2.47.3 From nobody Mon Feb 9 19:55:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767883039; cv=none; d=zohomail.com; s=zohoarc; b=i8gZis9MF8YsfstiywvGfVQMBnA3wgaARD9tp/02BAu1mwiZNLGqH0u0G6q8cFPRIIEyGbxTnBw91jAWGRA3hP0I/e93KHbDaxy95G6DrlQVCrgUFAchRE7ah1SipNejtGT2oJ0D9n8jkq/Y1s5+JD6IrUuih7YaTQ+uvwOgHyI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767883039; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ksGvb6tIIoBcL19IyLaGN8z74U9Al+XLv7vvohNmR5E=; b=OhK9ejAk4smOnsfLeuJn4wbiUnoaVBK+zLshTGUXEejjXnD4l7XxXNRwdQ3ksr4YG8MdjbO06RNGOim+CByR4hBHYPJ9BbB6ocDWHguiEhp6F8F5FFeA+OWl6YJ2q3+Ge//Fb4E7yySZaliij591A0cjaz7FvpP+lxOJsPR0VgE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767883039697210.4620079766005; Thu, 8 Jan 2026 06:37:19 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vdr6I-0007S9-9E; Thu, 08 Jan 2026 09:34:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vdr5u-00071k-1P for qemu-devel@nongnu.org; Thu, 08 Jan 2026 09:34:36 -0500 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vdr5q-0000h7-7D for qemu-devel@nongnu.org; Thu, 08 Jan 2026 09:34:32 -0500 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-432d256c2e6so442256f8f.3 for ; Thu, 08 Jan 2026 06:34:29 -0800 (PST) Received: from draig.lan ([185.126.160.19]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5edd51sm16659017f8f.29.2026.01.08.06.34.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 06:34:27 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 74F565F94A; Thu, 08 Jan 2026 14:34:24 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767882869; x=1768487669; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ksGvb6tIIoBcL19IyLaGN8z74U9Al+XLv7vvohNmR5E=; b=jP8iKv3th8Ojq91UcBlmWn5SJwEbvAktG1okFdHG7u8ImnyvHIDSOIuolDIZ0430rc k4uG/cpCwizDxcrzG+aga2NNc5oZEU9g7t+p5rVP+sfL8XIXiP48MHQener4TXo6i9pR bwrVSv+zdsnFBOqRxo05eTsurTlx5jqDpMHlcR5GtA5KUkhd+Oy2fiYTFFI491YA3tnC zKSNviIp7Qhs42z0BUzeOuuNgdUeZ7KE/JGHHIrdRf77V/6qZe9pClom8kZ0Wq4xFJ9i lgLpibx+jW+ZdrELtqdRQNuXOC/ALxMkW5b0PvG5d3CqAsr9u9RaUGoMBZ3ax4n4Ebe2 yFuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767882869; x=1768487669; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ksGvb6tIIoBcL19IyLaGN8z74U9Al+XLv7vvohNmR5E=; b=JuqN0y3yV8rWuPYwuG90LMpO/hzgNNzwbAVoRYdytLFQpvC4Vk/OqLXajzULat4xjm 4XPqzDwLvZPfy0dlgpL3XrJDF4n6hLMTTuD4jSl4W6X2br9FPPf9P767hl4GzSeVqcTM kwZolvhn3j2V3hOK72PyeZqngEc7ivg9F5syDZK+VW5vH632VuSP9QsiMEIoVa0CVxKR lJe6XI3ZRmZitS87OYeXMN8hqZHgHvBGMtwdxVPnJ5gMRtj6uQrrJI/jpB9IkKycmFth IfdKTFrRbyj+W1BvfubDua8Focwk4IPaV7IfFPBdGzJO1OL+Ys4jvEP25vdB4fwRDXIa pdKA== X-Gm-Message-State: AOJu0Yx+tEl79LO1bXjBxDL2qSoaneSxQgDwk51UrZNdPtSSgmS/yol2 dk/ixPMMiNKUquOB7S4p/YX/awIxzhMaMHEG7616bGoqEkPh83cqZwrzpQuapYHL4B4= X-Gm-Gg: AY/fxX4CJKQ05jLKLbqp77DapZlT++Rx1TWxik9lKPGXodcLlxwujlD1EopnSSdZN79 13NwR3b0o2ADU3OGnoq65azMqSPnvm2900FkMcnhZuUgdiAwMXg9+RrI8B8wHVGrd9WC2c9Q6yM BVa3a/BSdHbm+4VJiotnh7RFio22TEeMkGl+lGYuiejBvYlLkrTtkTBdOJgGjGvsWpGG5KRivP0 D6a+fhCeXPCGGBh9OX4CBzHUYmyPg1AXof3NVCyVbc94U91gv3uNVVoVjAeOXSPm7r12D1gVidA pTC3ZLI7+HLA/3fZ4S7kyrZr0VPZkt62J0M4TAF+UDvsU/Q3fsZJk8NVze8efDHki/bW6C7wXpC It4QL2IUvBgv5waZPukQ9zkSRRrY7rM83nNR6GlIwPJpVPq89zr5s+r73l+M+YDG3Y4D1CyM2iY /b6KzaNe1afO8= X-Google-Smtp-Source: AGHT+IFVmLmMizmNB2LIXR8Xv3q2Sppf9Sh1lb/5R/XMq5lNlyeZkdJf+M6Qph5BQgNY23BgFi5Zzg== X-Received: by 2002:a05:6000:3104:b0:432:7068:17d with SMTP id ffacd0b85a97d-432c3775aa7mr8314435f8f.20.1767882868653; Thu, 08 Jan 2026 06:34:28 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Aurelien Jarno , Jiaxun Yang , Bastian Koppelmann , Marcel Apfelbaum , Zhao Liu , Peter Maydell , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org, Yoshinori Sato , Yanan Wang , Aleksandar Rikalo , Thomas Huth , Eduardo Habkost , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [RFC PATCH 07/12] target/m68k: drop cpu_reset on realizefn Date: Thu, 8 Jan 2026 14:34:18 +0000 Message-ID: <20260108143423.1378674-8-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260108143423.1378674-1-alex.bennee@linaro.org> References: <20260108143423.1378674-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767883040719158500 Now all the m68k machines have cpu reset handlers we can drop this extra case here. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth --- target/m68k/cpu.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/m68k/cpu.c b/target/m68k/cpu.c index f1b673119d6..a540a754969 100644 --- a/target/m68k/cpu.c +++ b/target/m68k/cpu.c @@ -392,7 +392,6 @@ static void m68k_cpu_realizefn(DeviceState *dev, Error = **errp) =20 m68k_cpu_init_gdb(cpu); =20 - cpu_reset(cs); qemu_init_vcpu(cs); =20 mcc->parent_realize(dev, errp); --=20 2.47.3 From nobody Mon Feb 9 19:55:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767882933; cv=none; d=zohomail.com; s=zohoarc; b=J1lgzUD8+ma4kCIhUzlexFcuCGdsav4qR2K8U83TyCbnLpzjhN6+nCs9hCaoiMxvz8sRho0zOCFuCuP8gM2bCsvF97QrRo1TNclf9F6Q8f1lg2gapylUmTPvKCV5Tz/30rQcY+4BybEQxjujxD8JV1wuQ8DIsgcS3XM3I4pqp3s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767882933; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Iroa14hBK2LVpeSpQfZj+3dFVlP7qrWupPJPhYrPWjw=; b=jFfoClZcP/YJQHBEvvdC+AN6k3t1Mbuf2WMmCLeBlU3dc2l7i6AMc6d20SK7pNSL6WJ2UuoGUGGOxtfYt1oVKmjnRJ4UvBVC9CSvKUK+thl7dfZt1ZPpakP4Et3k+YW2WXq2odDGe/zcDGUZa6DgfGbDvnuGTUlAmZ65xvrZF4c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767882933718880.0692322759538; Thu, 8 Jan 2026 06:35:33 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vdr61-000768-NA; Thu, 08 Jan 2026 09:34:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vdr5t-00071Q-TH for qemu-devel@nongnu.org; Thu, 08 Jan 2026 09:34:36 -0500 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vdr5p-0000gu-RY for qemu-devel@nongnu.org; Thu, 08 Jan 2026 09:34:32 -0500 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-432d2670932so449727f8f.2 for ; Thu, 08 Jan 2026 06:34:29 -0800 (PST) Received: from draig.lan ([185.126.160.19]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5edd51sm16659018f8f.29.2026.01.08.06.34.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 06:34:27 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 90AE65F9E0; Thu, 08 Jan 2026 14:34:24 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767882868; x=1768487668; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Iroa14hBK2LVpeSpQfZj+3dFVlP7qrWupPJPhYrPWjw=; b=ESCndYqRS41Cbbtxt2Guiqz5CYulL46Oh7+0bPwD8bR+sHEV2PiLHqp5/T4TyB5gSf mmgkGPYONjSNLWfRfWZREWkxerwcxYM5yYjTfuzaEGMZclXRZGl0M/XbzQlrHZcfb25f 70yaK5pu6uV0Pv268jgUkdLUCsTAKEZyLWXRu9Jb66eVI6ydc3BBWaWAqjDmJboeMf8S gZ5o0wuyHcWH8gyKeAohaAL4eJqXz/JtXJqzoNR+uoCMmqBPs/RCxmGnxGP1VMrf/Cg0 3JrPxSJ2bR8vuLZ8ZZ0AeoToEcAjXvoFCOae/FpXAUifEn+zTOw8s2vxegu3kogjSlow ThHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767882868; x=1768487668; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Iroa14hBK2LVpeSpQfZj+3dFVlP7qrWupPJPhYrPWjw=; b=Qc49cmOacLUGygwIz0z06OzkLKyVDGS6CvwehVkiiY+y7fEh70RblWiZwAkslY8m0G drwT4enyGFwmrbJfCSrAri48dVhfdTjFApTrmgHxr2NQfqr7xAoU3HCpp3GAmfQeIJEa e4NkDYEJy+f62vBVpviELdavA80+dRBVWHyHHm7nsTzttyDyLVBVINeyzBY/g+jhRuJD K163yBQ19VYn1msbwAEQ1TscNVDich+rZHCM8KRuMCLdzMs3dz6/fKzpua0PRZ5pXa8M ejDlUV2kMsqrcgclCiWKNefpRFiFzL2xf7j8JjiFUDkXjA+sOM1Ua/gpuJhkpJYGI5wD 42yw== X-Gm-Message-State: AOJu0YwE2PscDLnj1FUWYDM5AmkoX9lXvfCY1MDORHhf7l02kiv+qNvq 5d70i8fz0HtNX25ng7OBvEn5pt6H6F7EB8LF2Jba9OjzLSZX+XL+GN4Jb1SZGdNbCng= X-Gm-Gg: AY/fxX53v6kQqlyiXMYQ0UGPv2OOpMhYfUMHbLqXNRT9ZGRfy07aaJblKAniSwm6oGH ULDH//6co/hwBRGVi3PKz/3K0CnKbCDG3S88zzvBZHER9g3nOU+PYfki2bmcrfGjZHZsDR5OPHR 63kuxrLjzzRd4H5mYyV3oQiLeDPZtXX+ipSaQheIIpt02HMD8qlvg9IO6KgMiUCxMI6Hureu0bg /tI6jXVuaa0vgLWE4Ef6VQgWsDGx0vfBF8RYT1YJAFpvCWgwwrcNUEVx0YFX3rCHx/1EG/kkkfC r32YhZj55qmhZw6iTlrVOq6C4m6w+cHpkkG4oxoQoT98yD18xUewy5alORaVFKIoLsL78XQ3yCp XrrE8rof5wV0SbMQDWGqdjmC0IDI6r7tDOLZPjh8+EpgPJUKWfQVH8DI4LYnJWq7d140XRTF5YN ZwuRYWhKPQ1aFcciw+EnYojw== X-Google-Smtp-Source: AGHT+IH8epdayj+gumqDsbORe6YPW9g0b8aY7CGQSZG/pUWsyk8DyQ+Bv3AOBxBD8y9um1EG9+w8og== X-Received: by 2002:a05:6000:18a7:b0:432:c092:ee3b with SMTP id ffacd0b85a97d-432c38d2696mr9095341f8f.62.1767882868178; Thu, 08 Jan 2026 06:34:28 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Aurelien Jarno , Jiaxun Yang , Bastian Koppelmann , Marcel Apfelbaum , Zhao Liu , Peter Maydell , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org, Yoshinori Sato , Yanan Wang , Aleksandar Rikalo , Thomas Huth , Eduardo Habkost , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [RFC PATCH 08/12] hw/mips: defer finalising gcr_base until reset time Date: Thu, 8 Jan 2026 14:34:19 +0000 Message-ID: <20260108143423.1378674-9-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260108143423.1378674-1-alex.bennee@linaro.org> References: <20260108143423.1378674-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767882935101158500 Currently the cpu_reset() in mips_cpu_realizefn() hides an implicit sequencing requirement when setting gcr_base. Without it we barf because we end up setting the region between 0x0-0x000000001fbfffff which trips over a qtest that accesses the GCR during "memsave 0 4096 /dev/null". By moving to the reset phase we have to drop the property lest we are admonished for "Attempting to set...after it was realized" but there doesn't seem to be a need to expose the property anyway. NB: it would be safer if I could guarantee the place in the reset tree but I haven't quite grokked how to do that yet. Currently I see this sequence when testing: =E2=9E=9C env MALLOC_PERTURB_=3D43 G_TEST_DBUS_DAEMON=3D/home/alex/lsrc/= qemu.git/tests/dbus-vmstate-daemon.sh UBSAN_OPTIONS=3Dhalt_on_error=3D1:abo= rt_on_error=3D1:print_summary=3D1:print_stacktrace=3D1 QTEST_QEMU_IMG=3D./q= emu-img QTEST_QEMU_BINARY=3D./qemu-system-mips64el SPEED=3Dthorough MESON_T= EST_ITERATION=3D1 MSAN_OPTIONS=3Dhalt_on_error=3D1:abort_on_error=3D1:print= _summary=3D1:print_stacktrace=3D1 PYTHON=3D/home/alex/lsrc/qemu.git/builds/= debug/pyvenv/bin/python3 QTEST_QEMU_STORAGE_DAEMON_BINARY=3D./storage-daemo= n/qemu-storage-daemon ASAN_OPTIONS=3Dhalt_on_error=3D1:abort_on_error=3D1:p= rint_summary=3D1 G_TEST_SLOW=3D1 RUST_BACKTRACE=3D1 /home/alex/lsrc/qemu.gi= t/builds/debug/tests/qtest/test-hmp --tap -p /mips64el/hmp/boston TAP version 14 # random seed: R02S89554f0dc696ece515363e554b13b7f9 # Start of mips64el tests # Start of hmp tests # starting QEMU: exec ./qemu-system-mips64el -qtest unix:/tmp/qtest-88337= 2.sock -qtest-log /dev/null -chardev socket,path=3D/tmp/qtest-883372.qmp,id= =3Dchar0 -mon chardev=3Dchar0,mode=3Dcontrol -display none -audio none -run= -with exit-with-parent=3Don -S -M boston -accel qtest mips_cpu_reset_hold: dbg mips_gcr_init: 0x5600f2160050 - 0 main_cpu_reset: dbg mips_cpu_reset_hold: dbg mps_reset: 000000001fbf8000 mips_cpu_reset_hold: dbg ok 1 /mips64el/hmp/boston # End of hmp tests # End of mips64el tests 1..1 Signed-off-by: Alex Benn=C3=A9e Cc: Peter Maydell --- hw/mips/cps.c | 22 +++++++++++++--------- hw/misc/mips_cmgcr.c | 1 - 2 files changed, 13 insertions(+), 10 deletions(-) diff --git a/hw/mips/cps.c b/hw/mips/cps.c index 620ee972f8f..c91243599e0 100644 --- a/hw/mips/cps.c +++ b/hw/mips/cps.c @@ -55,6 +55,18 @@ static void main_cpu_reset(void *opaque) cpu_reset(cs); } =20 +static void mps_reset(void *opaque) +{ + DeviceState *dev =3D opaque; + MIPSCPSState *s =3D MIPS_CPS(dev); + hwaddr gcr_base; + + /* Global Configuration Registers - only valid once the CPU has been r= eset */ + gcr_base =3D MIPS_CPU(first_cpu)->env.CP0_CMGCRBase << 4; + memory_region_add_subregion(&s->container, gcr_base, + sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->gcr)= , 0)); +} + static bool cpu_mips_itu_supported(CPUMIPSState *env) { bool is_mt =3D (env->CP0_Config5 & (1 << CP0C5_VP)) || ase_mt_availabl= e(env); @@ -65,7 +77,6 @@ static bool cpu_mips_itu_supported(CPUMIPSState *env) static void mips_cps_realize(DeviceState *dev, Error **errp) { MIPSCPSState *s =3D MIPS_CPS(dev); - target_ulong gcr_base; bool itu_present =3D false; =20 if (!clock_get(s->clock)) { @@ -144,16 +155,11 @@ static void mips_cps_realize(DeviceState *dev, Error = **errp) memory_region_add_subregion(&s->container, 0, sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->gic)= , 0)); =20 - /* Global Configuration Registers */ - gcr_base =3D MIPS_CPU(first_cpu)->env.CP0_CMGCRBase << 4; - object_initialize_child(OBJECT(dev), "gcr", &s->gcr, TYPE_MIPS_GCR); object_property_set_uint(OBJECT(&s->gcr), "num-vp", s->num_vp, &error_abort); object_property_set_int(OBJECT(&s->gcr), "gcr-rev", 0x800, &error_abort); - object_property_set_int(OBJECT(&s->gcr), "gcr-base", gcr_base, - &error_abort); object_property_set_link(OBJECT(&s->gcr), "gic", OBJECT(&s->gic.mr), &error_abort); object_property_set_link(OBJECT(&s->gcr), "cpc", OBJECT(&s->cpc.mr), @@ -161,9 +167,7 @@ static void mips_cps_realize(DeviceState *dev, Error **= errp) if (!sysbus_realize(SYS_BUS_DEVICE(&s->gcr), errp)) { return; } - - memory_region_add_subregion(&s->container, gcr_base, - sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->gcr)= , 0)); + qemu_register_reset(mps_reset, s); } =20 static const Property mips_cps_properties[] =3D { diff --git a/hw/misc/mips_cmgcr.c b/hw/misc/mips_cmgcr.c index 3e262e828bc..9e1c8d26ea5 100644 --- a/hw/misc/mips_cmgcr.c +++ b/hw/misc/mips_cmgcr.c @@ -214,7 +214,6 @@ static const VMStateDescription vmstate_mips_gcr =3D { static const Property mips_gcr_properties[] =3D { DEFINE_PROP_UINT32("num-vp", MIPSGCRState, num_vps, 1), DEFINE_PROP_INT32("gcr-rev", MIPSGCRState, gcr_rev, 0x800), - DEFINE_PROP_UINT64("gcr-base", MIPSGCRState, gcr_base, GCR_BASE_ADDR), DEFINE_PROP_LINK("gic", MIPSGCRState, gic_mr, TYPE_MEMORY_REGION, MemoryRegion *), DEFINE_PROP_LINK("cpc", MIPSGCRState, cpc_mr, TYPE_MEMORY_REGION, --=20 2.47.3 From nobody Mon Feb 9 19:55:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767883016; cv=none; d=zohomail.com; s=zohoarc; b=RoAuXprFhwxlzDUfvAsa91k5opM8wEwqYYR5AL3DFpi6miWO0Fmku5UZNsvlS7QFLX/f96qryglyYZxlY69qmxFXLuuz4g1CAGoG5s9qnPy4LHTir/obbp5dw3u1rOKdd/VfUCmIfWgoxvTp248WUCMayX7CRZWx6LLODq1xEmk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767883016; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=jIBuc/mkbQabpqpdJIoXotFl/D1JCK+3Ji0AYvgjRGo=; b=fMQZKVeI9kUDc2aaZPrJDaqcE+5yxT9UvpZ8HPuCyqXFet+GoHSRBmiIiRwk4IHy2cBm+zeqi5/DylTsW6ygJuQGtkQ65ZPw8kH2hQH1+ysw0n6u4rpCrc3p1J7eYdGPwP2jel387s4NHaHFp9ZYFMWFexPJmghnCYKOgQSXM80= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767883016523105.3988077222001; Thu, 8 Jan 2026 06:36:56 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vdr6B-0007DZ-Dd; Thu, 08 Jan 2026 09:34:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vdr5v-000722-Gg for qemu-devel@nongnu.org; Thu, 08 Jan 2026 09:34:38 -0500 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vdr5t-0000hh-KR for qemu-devel@nongnu.org; Thu, 08 Jan 2026 09:34:34 -0500 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-477a219dbcaso27021955e9.3 for ; Thu, 08 Jan 2026 06:34:31 -0800 (PST) Received: from draig.lan ([185.126.160.19]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f68f686sm155235405e9.3.2026.01.08.06.34.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 06:34:27 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id A84B85FA2E; Thu, 08 Jan 2026 14:34:24 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767882870; x=1768487670; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jIBuc/mkbQabpqpdJIoXotFl/D1JCK+3Ji0AYvgjRGo=; b=feYKpyncOSjWQgbNZEDUbr4+fJYTWJpDqocXnl606LQP6zZECIxtcch9zEtHv58bST ypsYqPYnBzy3EJ5+FFMgtga2/ZUE6UrTdEB5BV2WTkAK7HSNX6DCfP5CqEwQBh62hChA UWsOrPtZRJQlN2vMHcvcHIT3MJdB3dVkcsQxAd3oxrxNWKNgo2QUeE/wdVdW/sQaHNw7 rp3U0EFOcfpOVXIuguZJlCF4GRSFaiJQrAXP/nKueJhh+2rHEaPGRv1nQB/Q9Vj+Axxe 6FCXOy6FwacV+AWlpMzXesO05oG+T4uIJQHN4tPoTiAIY5SSbnmMCaoNbAU6Q3i9jAh+ n+6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767882870; x=1768487670; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=jIBuc/mkbQabpqpdJIoXotFl/D1JCK+3Ji0AYvgjRGo=; b=pZenxUPqM2NeAb3GxC3DAxu/Syimri2+nCTmx2DkNBbq7vW23n8V/kIR6whw8BEpJQ Se9CbnqlfK9FN8I8EzPR5Lj3fHnLKFO1vW+8VC8Kv84s2ktMYxR56CvbHhu/n1MffxmI DN/XveDBXSVG5AwPeG9P9mLhcunKLihki2f0jGR4WU9nz4mwatTXh6l4+TotU0PRljhr 1PbNgCb8posOmCcwEFzmFqXN5kQeDhf8FvrURtv8xTM5HiVLmYpYIqkoLI6k6ZcSd2r2 56pY5hheBFfXJ/PNAwpGV4pYBIvf1j1zhaaf7BkfUQcK1OGJKYvSlIgHAArHkXyLtjU5 ysIQ== X-Gm-Message-State: AOJu0Ywwvx4zjwrkYFjcHdVZiLkkGrdR4od+f91IjXmNmSsBXN6ag1Bd i1j2CLjEKOJ5/3jU4cBCYetttq8D4JS6JhkuJ93ADjf3miizUNv1eoRg4j4rP5Z4DZo= X-Gm-Gg: AY/fxX74UPpIm1hCf2egxaQURDa3LuivRW58TXQav6jJtsYclD84s+yP7yz6QMoUp5I ddP7raeM2z0UAFnQU9MJHIN+HVIl+RHrcN5TpS4iPbk7mfrRkO1ZKGaQ5Ue7vfGkGMKmCAHwjNq uUm0BCcJK0loSHOJn/JetP8TQxioHEtgBh522IqqncE4Pc1A4JKw3ky5QLh9wtDyvcpqWRCePCD 3xb8f+i9AqMUTAt9o02b/gF1j6I1x8MPZWR8AsiR68kIAU9MgmnUKJzAmDOMuE2LC3nCqWGI6Eo uyRN5ijUV7vJHLo1pGQAaHPtgIzatiXS4HyBh6YYujUSMlBJcFgc3YzNMY/r2XEtkDN6i1sErmp ATNnt0lNP9rRSfI4okH5bxiI5bQucUoC2NNLSbVuTN8SL37X8fPVjjWObuLi09L9OewjrQKPNqb v2piSqAgJwL0E= X-Google-Smtp-Source: AGHT+IEYWVBCrSY/JFej/cH3QHt7HU4nTfQ1442Rqd9guEJxuXvZ3FOOtY3PLbbYmA2SO9ig+kmt0Q== X-Received: by 2002:a05:600c:444f:b0:477:df3:1453 with SMTP id 5b1f17b1804b1-47d8a177307mr34722715e9.28.1767882869557; Thu, 08 Jan 2026 06:34:29 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Aurelien Jarno , Jiaxun Yang , Bastian Koppelmann , Marcel Apfelbaum , Zhao Liu , Peter Maydell , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org, Yoshinori Sato , Yanan Wang , Aleksandar Rikalo , Thomas Huth , Eduardo Habkost , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [RFC PATCH 09/12] hw/mips: drop cpu_reset in mips_cpu_realizefn Date: Thu, 8 Jan 2026 14:34:20 +0000 Message-ID: <20260108143423.1378674-10-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260108143423.1378674-1-alex.bennee@linaro.org> References: <20260108143423.1378674-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767883018944158500 We will always do a cpu_reset during mips_cpu_reset_hold(). Signed-off-by: Alex Benn=C3=A9e --- target/mips/cpu.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/mips/cpu.c b/target/mips/cpu.c index f74a9d5f615..e61497c0f6b 100644 --- a/target/mips/cpu.c +++ b/target/mips/cpu.c @@ -485,7 +485,6 @@ static void mips_cpu_realizefn(DeviceState *dev, Error = **errp) fpu_init(env, env->cpu_model); mvp_init(env); =20 - cpu_reset(cs); qemu_init_vcpu(cs); =20 mcc->parent_realize(dev, errp); --=20 2.47.3 From nobody Mon Feb 9 19:55:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767882982; cv=none; d=zohomail.com; s=zohoarc; b=GchDo4RUkeILnQlkNPWrBxdxLsiYhCRx3t9GIzHMtPD8ap8R0F816bXcmE6E11c7+9AT30piXSle4XfTTGK0OpA8CE8xLKwWx/nEu0MLV9dnl5t6AbUOVmsz/SDsndjr0p+1jAkSfY6LUbuHylunFTlJnaBCxGucuhSzGl5GiwU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767882982; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=4tMArHc3fpfAyjhrmZC/JPcKIoMMLYn+9tiOMpEVPwg=; b=cQaXJvpWyo7KbbyPua8lBjQS38XH+cn5MEq8i9SY6Oh2C8NaC3YBmt6fKaY2X7UCU5qWJto/LhTOeqw/KSq2ZW3kXDNhZw24EPnyrDOF/TT9tfSab0X9S+Uti4fw1Iv6mXHqz6bcvfuXiHdK8nz3KKhuNGQxoFl2JEZ4FYVSAe4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767882982305223.54473840459502; Thu, 8 Jan 2026 06:36:22 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vdr6B-0007Ct-5v; Thu, 08 Jan 2026 09:34:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vdr5w-00072A-VZ for qemu-devel@nongnu.org; Thu, 08 Jan 2026 09:34:38 -0500 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vdr5t-0000iC-Oh for qemu-devel@nongnu.org; Thu, 08 Jan 2026 09:34:35 -0500 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-4779cc419b2so28521765e9.3 for ; Thu, 08 Jan 2026 06:34:31 -0800 (PST) Received: from draig.lan ([185.126.160.19]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f6f0e15sm151880935e9.10.2026.01.08.06.34.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 06:34:27 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id BADCF5FA43; Thu, 08 Jan 2026 14:34:24 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767882871; x=1768487671; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4tMArHc3fpfAyjhrmZC/JPcKIoMMLYn+9tiOMpEVPwg=; b=rsPqBg7z/CpNF7p0A9Fq7t17E39KhznUwiz8jAoiGu0fn38vV2DRtT9UOwyAHhv66g OsAt+j9yocxJXgAY5nma9YBEv0jqcNFlzKdvoZbwj10ZDM3RvLEOdPy4LNY8RGJCVk6Z 9W1F57tl3pKvOvO43+vM1A5CynjliboQoOodlj6gKLsJxya4Y+7/bE4g9hqPJVELkooh 2axeuO4mWGJt+5jAQkGzeD8zGHh4s4u0YPHYszXFbx2Rty/JtXNi4fe6sqG5vKS6TRVe e/IGSIh9iUHjYCiipogHGPXXC8WnVkvZv0V0VOsQYuW/9NmqCtzoSdQFciJz/w4ZDsdf mnvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767882871; x=1768487671; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4tMArHc3fpfAyjhrmZC/JPcKIoMMLYn+9tiOMpEVPwg=; b=gdLylH3Ttk7fUbQWIlDUna4Yxi2yivLFzcO/LA6sxjw2Lz/+9tOvFtJ1Kqwm5zWzUl 8EFoFQ02Wps60KdP/ItqacK4s4/BzUUVYWbndHUDsylSwBQxfXtVD8sL+2y6kGfGR2NL de+YSvxJAVz6FR3kQdUPVbv5cbDWr9+V9VY2OUjQL+Qedq1svM/a0DAhWQoehH5o819a 0Q2Jrsf2cWS99cha3g3xk81yFfv8PJkYrf89K1zqI1aa3PX5zzJZkJ5B38qMrqrekAa3 Dv3k/z6inGs2FC6gUA26QtT4TG80kNUXsKANt+HdjwkncRASb8DCmb0c90ZRLak7H+q+ +i0g== X-Gm-Message-State: AOJu0YyEs/s5Yov+UKZFxpUzS42FuMN5at/XPqt5Nw5ijKay3nzJmO1Z e4+Twc8Kh5k9cOnExHAN38etAgsoJ8uzCvK5DVc7NDzRVcUeF3u82LqoEr/dNWEno/s= X-Gm-Gg: AY/fxX57vizSFTsKp6/Hp/AlOz6GZK8I0uG69WlkFKmEFTL8hSAzOTbp4xl9qFu3qYy gbvalwSEj7c2eGqUrluVh4n7Hen0D3pMhaljOo2A9ag+QazAtAITziuoNJYE4bpfNUJsHSHK/Gh 1zIgxba5twabMvdxsRZ7s8jZ56x1p+S4LeUtf6F6RXqqsEQgVhRaEUvaRFyUVEyAGPYTfDiIefN 3uivNgVAiTi2ptZmU9Qerwoazf7JT0zwE2l6OvYNe+nHfVYJYfZh0pjosthiBUy8eNZC2CE1pnO Wk1geyUmsE16IWyPaT10wpfI7yM7gj6bubqy1QwcJWxpbsoPT4/p2K/ZQawXMw30EdTiby35A/Y B/l/MHIdVYwn3DtSo8FWu6790InX01kirUV6l8mhZPo41eFcWpG1kAaQZOCDbQzBGBpxICSmXPn 4yrNbxtMdHCOU= X-Google-Smtp-Source: AGHT+IHVOmi2wf66jvsMbt43DmnepHxzKqyfjk3Ie12Q2wlyN40HtlHxf0wwxQZu/Pawgbt1iVWkJg== X-Received: by 2002:a05:600c:c0ca:b0:47d:87ac:73b8 with SMTP id 5b1f17b1804b1-47d87ac7a94mr50207325e9.27.1767882870776; Thu, 08 Jan 2026 06:34:30 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Aurelien Jarno , Jiaxun Yang , Bastian Koppelmann , Marcel Apfelbaum , Zhao Liu , Peter Maydell , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org, Yoshinori Sato , Yanan Wang , Aleksandar Rikalo , Thomas Huth , Eduardo Habkost , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [RFC PATCH 10/12] target/tricore: move cpu_reset from tricore_cpu_realizefn Date: Thu, 8 Jan 2026 14:34:21 +0000 Message-ID: <20260108143423.1378674-11-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260108143423.1378674-1-alex.bennee@linaro.org> References: <20260108143423.1378674-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767882984919158500 Implement a proper cpu reset handler for tricore cpus. Signed-off-by: Alex Benn=C3=A9e --- target/tricore/cpu.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/target/tricore/cpu.c b/target/tricore/cpu.c index 04319e107ba..c3dda9f6a54 100644 --- a/target/tricore/cpu.c +++ b/target/tricore/cpu.c @@ -24,6 +24,7 @@ #include "qemu/error-report.h" #include "tcg/debug-assert.h" #include "accel/tcg/cpu-ops.h" +#include "system/reset.h" =20 static inline void set_feature(CPUTriCoreState *env, int feature) { @@ -81,6 +82,12 @@ static void tricore_cpu_reset_hold(Object *obj, ResetTyp= e type) cpu_state_reset(cpu_env(cs)); } =20 +static void tricore_cpu_reset(void *opaque) +{ + CPUState *cs =3D opaque; + cpu_reset(cs); +} + static bool tricore_cpu_has_work(CPUState *cs) { return true; @@ -120,8 +127,8 @@ static void tricore_cpu_realizefn(DeviceState *dev, Err= or **errp) if (tricore_has_feature(env, TRICORE_FEATURE_131)) { set_feature(env, TRICORE_FEATURE_13); } - cpu_reset(cs); qemu_init_vcpu(cs); + qemu_register_reset(tricore_cpu_reset, cs); =20 tcc->parent_realize(dev, errp); } --=20 2.47.3 From nobody Mon Feb 9 19:55:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767883044; cv=none; d=zohomail.com; s=zohoarc; b=fNKXBOMIZqFwt9fqPGtfrOVTKsNkkwFXf6SfjpAq93NPK0GTRA8OEkdHdRSJKZRqXTt0ubSKFMr9iu0GkGrrY3Yx1i3LKo0g5zJSBgFW6FPSN2JSYrmT8W8NfyJTXZkWtIuzG3yrNQfILkrKnWwuRrK5QsXfncahJ8gzQrY3Wrs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767883044; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=MKZCBRJMVl+HwSw4Or6YDzCMoqNlO7kCpo//7lZNDA8=; b=cfwGqBPN9avsEeuBLLmThylXa8aoO0aR42lmYIZlAkbD2feWmkUbX9LqKs2czwZcQjY2EH/EJXDUziP9vMQo4vb/xsuTnBYbcz9uhgqXh1G/FRnVuygFCcDspPfhda1iNjaiqQ0w9sT0zbAyf2l62qpA6PeORkGkyoutM/v2UpU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767883044293854.5675624872035; Thu, 8 Jan 2026 06:37:24 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vdr6E-0007Ls-KH; Thu, 08 Jan 2026 09:34:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vdr5y-000737-B9 for qemu-devel@nongnu.org; Thu, 08 Jan 2026 09:34:38 -0500 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vdr5v-0000jB-9h for qemu-devel@nongnu.org; Thu, 08 Jan 2026 09:34:38 -0500 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-4779ce2a624so27216135e9.2 for ; Thu, 08 Jan 2026 06:34:34 -0800 (PST) Received: from draig.lan ([185.126.160.19]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f68f69dsm158067355e9.1.2026.01.08.06.34.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 06:34:32 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id D1BFC5FADA; Thu, 08 Jan 2026 14:34:24 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767882873; x=1768487673; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MKZCBRJMVl+HwSw4Or6YDzCMoqNlO7kCpo//7lZNDA8=; b=vIwPeR9vXxRhLNZAEx3MKTV7cY0OXWL5g++S+pgSo0h8xQ8Z6hUeba6bKqqmCIfQSe YXP8qqbOwtZ7W3XSN93rBwHXr/Hr10Rrms8x18wosGPk9EWjDqoooYjUwrUoUYpw6F52 ZpoPp93RjJrguxryhLc6VkjBEzaAOMOqil/N1Ug4vLKbUi11Ljx5kNDXPFcfK5rKZMMb St+D0p+UBD0WjE9nzFyve51Z70bD29oo3cqPBE9XKrABxBK30aFvejha8vNRaXvgXwIu KS/VNR7GsjPweuZkzLpzfshJSdFxsBJxg8IBfzCTED7IbhUSlDQe3SuYyNFgtMSG7cDb McJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767882873; x=1768487673; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MKZCBRJMVl+HwSw4Or6YDzCMoqNlO7kCpo//7lZNDA8=; b=cw+OxtjsPWhbkuU4QWe6pTyKqPbVkIGviWsOi7R4b1N1oLVaC7FCdnguTOAX5FjKve /RLh/vqAFLPFcyHr9JAifyx8S/FnJSe+Ae0Yv/6TlfzcOuO40SYmTGnpkk0s+nmymbVC 7f/A+5uzm4zyce26OVLHoyC9yvzFo9RAdGpSnqW1nPS/BFeyvBSZ4aSVW+T5v88Ac/H/ Q7H/D7H0DceJodRiPbQrxnPIhoodENubKVOQsxTXtVSc02IOYxhMF8LghsKhmJttoCpR 0RZ3Bp2m7aZpiRdvMkEDnC3a1E7T6vLAcaeREUUIReMQBp6KKdAg+AS4ZoBT/3/QImXS K6dg== X-Gm-Message-State: AOJu0YzJvpVNOaA7No0OnhFskSCSlCzi4RNHI8gEHZLKHrY/uAKPF/+6 Iq8udmHfffQxhgc948iKD2373xaGtROvvccT8AmFzsS2mVX1bdxAu2Ra71jPcfnJyTA= X-Gm-Gg: AY/fxX5kqv1DlQyWTFpqOU6q3bAQYAfUOOA31nVKbFvrJ6AOIIEzmEB68JcT/A44mZr 8kbHOSy9IM8FI7mIx6bgVntQqhXXbvgHHPc6FGhayo31xei0tFpsCPX4oKv13Qq+4x/RuiKH0DJ ieWdWw52dysLIjwUWUwuRVcSKGrlqmUepUMRORp99PYSSEiPmT76qRfzWYG+dFQQfx7Ko/nszp+ dXx1I57JmEeQrCkZZZyqY+fPMzYLd4PFDLazmEKc0NafaAJj8gq8Zz7V8H/pm5zknToUl4siAC9 lw6CGGKG+gFB+UQ1LZPP5c19GQm/31PSrOgLMwcRDI7cayNazquwqmS3Id0s6crVFJTIPwBPDv0 AT+m+sBqUboP/Hoa3zXfYHqB51TBBXrxzrl1waFaOQAWvkWoaKE7B/eezycmnt8z0BRLioy3ZDK x7qtSC5jKEeAA= X-Google-Smtp-Source: AGHT+IEMotvXhQTv160rwPcsVO9t+3//HM2qgzgfG8RwcgsbLPqB+CzG8MnZZAgqmXNlPB4P9Rb3IQ== X-Received: by 2002:a05:600c:190e:b0:477:9aeb:6a8f with SMTP id 5b1f17b1804b1-47d84b1faffmr81020035e9.9.1767882873126; Thu, 08 Jan 2026 06:34:33 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Aurelien Jarno , Jiaxun Yang , Bastian Koppelmann , Marcel Apfelbaum , Zhao Liu , Peter Maydell , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org, Yoshinori Sato , Yanan Wang , Aleksandar Rikalo , Thomas Huth , Eduardo Habkost , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [RFC PATCH 11/12] target/arm: remove extraneous cpu_reset from realizefn Date: Thu, 8 Jan 2026 14:34:22 +0000 Message-ID: <20260108143423.1378674-12-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260108143423.1378674-1-alex.bennee@linaro.org> References: <20260108143423.1378674-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767883044721158500 We already have do_cpu_reset called when the system is reset so there is no need to do it here. By removing this we now only do (smp*2)-1 calls to cpu_reset. Once per core as part of qemu_system_reset and then once per secondary core as PSCI calls are made to reset them. Signed-off-by: Alex Benn=C3=A9e --- target/arm/cpu.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index caf7980b1fc..015131aea08 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -2208,7 +2208,6 @@ static void arm_cpu_realizefn(DeviceState *dev, Error= **errp) } =20 qemu_init_vcpu(cs); - cpu_reset(cs); =20 acc->parent_realize(dev, errp); } --=20 2.47.3 From nobody Mon Feb 9 19:55:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767883040; cv=none; d=zohomail.com; s=zohoarc; b=dlKn5vGGFTlNIcLS3A8a95i1HSEoNBZv6sCcJjZ/xInRpYc62ogGGqAN5/G5bp8uMNodBjJ9zG5oJbsDvK8gS9r+Kf0y/5QVeRiuxv9fX31lxhyNtb81CeVRhebbQMa+imYp+zkM+sKGAFC13zlDkhelfKQeXhCBwq3NW3BQSBk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767883040; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=M6tH0CF/GJKELoBmGqjsJGSOS1a50aHiTGJ/qCRa94o=; b=GeFJupiJI5rlZYlwVGdlVl0iYm3JVkX+Xzh/vOK/BukPt3G4qVAtNIVW9QLhdAk9PhlOtVjgBlnSkdF3UlvQWEbccEi+xqVVUC3OORmbCt8dP3yPLMofykyUzjrSZnpvrHCHjNqolE/Re16ZYXp4lm6xl2dxktW8zfg/SCavVTk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767883040522775.9600386916179; Thu, 8 Jan 2026 06:37:20 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vdr6E-0007Lz-L6; Thu, 08 Jan 2026 09:34:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vdr5y-00074P-Hn for qemu-devel@nongnu.org; Thu, 08 Jan 2026 09:34:38 -0500 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vdr5v-0000jT-AL for qemu-devel@nongnu.org; Thu, 08 Jan 2026 09:34:38 -0500 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-47bdbc90dcaso24184475e9.1 for ; Thu, 08 Jan 2026 06:34:34 -0800 (PST) Received: from draig.lan ([185.126.160.19]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd0e16d2sm17391256f8f.13.2026.01.08.06.34.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 06:34:32 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id E9D995FADF; Thu, 08 Jan 2026 14:34:24 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767882874; x=1768487674; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=M6tH0CF/GJKELoBmGqjsJGSOS1a50aHiTGJ/qCRa94o=; b=HS4Qf1jSb82GjuDAbydiaDt/Eq83vsu8awTfomJ+OQlCi5rZ4LJO5j4enPSPWw1NGe LoYslHzbFB8ymK5PDtr4jTT1NtotBfSCKaeKCgscWJCiaBm+ZcngXPW52j9w7+6X0tbA OVI+wDDJNxFdsWqhEvkQjv99ew0h4psNfVy6TfuLvIA9Wclst9gNFKMF8P781IXVUqMQ 9P0VK20EmFroxRNesi4s/3FBteuw+f8db1HkOE9C4q3I5DJvMga2tr2xBINGSFDnJg4s Dhlninp/BZwvgo9gqhR5I9tdSbD510fzE091ytZALInU9KXEBuBKDntjibtrBIRQrtvA qDoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767882874; x=1768487674; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=M6tH0CF/GJKELoBmGqjsJGSOS1a50aHiTGJ/qCRa94o=; b=FcLidnFQC4a6i5yQvCRnE3GMkeG7FykVcdySpXqkr8yA3WulHGd1NBDcicPgqt3VOD dy/HYg/dEAfkXBMhnq4nxuS+spBo81bF5SzregST//GbfdM+iqm9cEcV5lke/Qdv5ltx fRVxRwnxkOMKtymnV2UTCwmp4dm1gQfUtBxm5epdA6TN0TaQkeHAHb+SQSc/l3ngC9Ui 2i3BDcOmsaFogf6A7jumy61ErvvmtKr9rCr84xJqrZUSWLPGWq2oFf5sjMozGbw9QFps 4WvXKp9nTklOsV8f44sahXRAkZtaM3RB9Z2iLXPjqLWWk+8dZN8fDAnAsJ8LT7BOXRaw 9+gQ== X-Gm-Message-State: AOJu0YzkaMWPUdkmr3nkvFuPUtfVgjutbv640kBcxlh/d1D1inojtwPF MOVdoDcMd85Fh59MfckfWG23IpMLLQUTfLr1IlLhX5kXImR1gPDZchCtJQ6VWURycTM= X-Gm-Gg: AY/fxX6rwKDUzSSkRg59VLPy4WvnNWe7XuY55yntWtmxUt6RRkm6zUOsU/uIz5xsPoi 69fdUNi27TUqi87uhgIiFIQUa9cZJjvb2ApnEvpp/7j4Y9p5KmDR1HhD3gIdD3iHJYkP8wBySfM 2WDk5MKtQbq5R3ebStBt5h2iYyJUZkpcXvNtdZRVHRaBX7dwrPO2yRtIOSIuSsPI6Fhbw8oe08V pZDRzwVETnFtZJ31Nbq9YzlPumn3n5pFrWHBVyADpIIrR2xv2zTJ+OGbR8B+JaZhcrFFDCxJkjK G0AihDNvEP8/san3jdpAOic4fizl4AdTdAtIPqkOLAXuIH8zAzArgm5OLBWRO7WZgm70BjHcgTX rW3/cjFjkLM/vv3ChGOjkOcL/aRJggWEuRWV7zEZCC4o5lrUm8mG/7ReoDv5Lc/DB9H5KJ+muIw Kytg08dJQpJDo= X-Google-Smtp-Source: AGHT+IFQ2b7jHgSZCCtLDyudNjBkpAYBfcgv7i5tpvjUUC07gUibqxAEQZnVr+TfhdHtcSVluMmqnQ== X-Received: by 2002:a05:600c:1392:b0:477:6d96:b3c8 with SMTP id 5b1f17b1804b1-47d84b34673mr79074405e9.23.1767882873727; Thu, 08 Jan 2026 06:34:33 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Aurelien Jarno , Jiaxun Yang , Bastian Koppelmann , Marcel Apfelbaum , Zhao Liu , Peter Maydell , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org, Yoshinori Sato , Yanan Wang , Aleksandar Rikalo , Thomas Huth , Eduardo Habkost , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [RFC PATCH 12/12] include/hw: expand cpu_reset function docs Date: Thu, 8 Jan 2026 14:34:23 +0000 Message-ID: <20260108143423.1378674-13-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260108143423.1378674-1-alex.bennee@linaro.org> References: <20260108143423.1378674-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767883042756158500 Add a hint to the developer that this should only be called from a reset chain. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Richard Henderson --- include/hw/core/cpu.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index f6f17df9e64..9f938e00492 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -811,6 +811,9 @@ void cpu_list_remove(CPUState *cpu); /** * cpu_reset: * @cpu: The CPU whose state is to be reset. + * + * You should refrain from calling this during CPU realization and + * make sure this is called from the reset logic instead. */ void cpu_reset(CPUState *cpu); =20 --=20 2.47.3