From nobody Mon Feb 9 23:38:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1767856554; cv=none; d=zohomail.com; s=zohoarc; b=LTV30QAH0QK58UjNEMQSqfpLGNYZh33CTCTm9xcPzLZYYAzrnfX2sJW+vkC9VIS05q2/3C2tvRYDVN/DuS3S1QOWolMxp5HXqBZWKQgCBEMRuI7pwhtI5ZUBP8mi/rGglsCs0LOEMnU5vrDsGIKY0SX5/IKVJ6N1fiutQLaIFJY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767856554; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=gONgRn/GNyBGob63kNT426dkqmiq4qN/s3arf4kHFSI=; b=ROk/pVbtg4jXJM0dYFF6LQSrTrLjUQFQMbWMJSXAHsIuxG6Kj224MHBeU44+WmTcxnu+bX6upFdrvphpVilYdHV8mORKu27zGUGQm2QyOxU21f47cgDshNz2Pd5elrg7X/qhYcMD1hh1Q2Mi/s4YCoVbcxyz9tUrqq+tdSD0Ytk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17678565543901019.1584699006485; Wed, 7 Jan 2026 23:15:54 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vdk6b-0007JO-Sv; Thu, 08 Jan 2026 02:06:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vdk6S-0006pK-Io for qemu-devel@nongnu.org; Thu, 08 Jan 2026 02:06:41 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vdk6Q-0006ce-Jm for qemu-devel@nongnu.org; Thu, 08 Jan 2026 02:06:40 -0500 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-665--y-M8g2NMHOywAafuALT4Q-1; Thu, 08 Jan 2026 02:06:33 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 20614180035D; Thu, 8 Jan 2026 07:06:32 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.32]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AA00218008FF; Thu, 8 Jan 2026 07:06:31 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 10FB521E61B3; Thu, 08 Jan 2026 08:06:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767855998; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gONgRn/GNyBGob63kNT426dkqmiq4qN/s3arf4kHFSI=; b=akTONvq8px2J7Hnt/UOZLcXsPr5fCcWWIMgaJmQq2L59DDuvD4yAyr4zuW3xj6lUwenvAf fB9gKMxyTMckOj4S3xKwRCQeNrj0DQOTUpnSxQtws+N6NYYaKd4kp7JQ5mLOfxlRkX/lkd z2yrJ1x1AMJ+XCc6RPoqgarx0r4+Hvk= X-MC-Unique: -y-M8g2NMHOywAafuALT4Q-1 X-Mimecast-MFC-AGG-ID: -y-M8g2NMHOywAafuALT4Q_1767855992 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: richard.henderson@linaro.org, "Dr. David Alan Gilbert" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL v2 08/17] tap-solaris: Use error_setg_file_open() for better error messages Date: Thu, 8 Jan 2026 08:06:16 +0100 Message-ID: <20260108070625.1586474-9-armbru@redhat.com> In-Reply-To: <20260108070625.1586474-1-armbru@redhat.com> References: <20260108070625.1586474-1-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1767856556526158500 Error messages change from Can't open /dev/ip (actually /dev/udp) Can't open /dev/tap Can't open /dev/tap (2) to Could not open '/dev/udp': REASON Could not open '/dev/tap': REASON where REASON is the value of strerror(errno). Signed-off-by: Markus Armbruster Reviewed-by: Dr. David Alan Gilbert Message-ID: <20251121121438.1249498-5-armbru@redhat.com> Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- net/tap-solaris.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/tap-solaris.c b/net/tap-solaris.c index 75397e6c54..faf7922ea8 100644 --- a/net/tap-solaris.c +++ b/net/tap-solaris.c @@ -87,13 +87,13 @@ static int tap_alloc(char *dev, size_t dev_size, Error = **errp) =20 ip_fd =3D RETRY_ON_EINTR(open("/dev/udp", O_RDWR, 0)); if (ip_fd < 0) { - error_setg(errp, "Can't open /dev/ip (actually /dev/udp)"); + error_setg_file_open(errp, errno, "/dev/udp"); return -1; } =20 tap_fd =3D RETRY_ON_EINTR(open("/dev/tap", O_RDWR, 0)); if (tap_fd < 0) { - error_setg(errp, "Can't open /dev/tap"); + error_setg_file_open(errp, errno, "/dev/tap"); return -1; } =20 @@ -107,7 +107,7 @@ static int tap_alloc(char *dev, size_t dev_size, Error = **errp) =20 if_fd =3D RETRY_ON_EINTR(open("/dev/tap", O_RDWR, 0)); if (if_fd < 0) { - error_setg(errp, "Can't open /dev/tap (2)"); + error_setg_file_open(errp, errno, "/dev/tap"); return -1; } if(ioctl(if_fd, I_PUSH, "ip") < 0){ --=20 2.52.0