From nobody Mon Feb 9 12:28:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1767798909; cv=none; d=zohomail.com; s=zohoarc; b=PRZMGKajUUxztRRGEHlNpyC7WQRPnkic3rDpsbcL1/wcdMYNJi76Rv31XeNnq/lUZooMWrIGqshmEBnf8rHp5aVCBVATqhlHE6xt4hUH1X53hw5h8CdPl7GFlV8zhGMGcoPOrX0d6Nl5OS6eVEZuxSTA0R3d4YqSWDuk7vqFzDA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767798909; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=SJTfX9vnrMV0tPHM38seWbDHpgKlBHplIleCEmi8Ac0=; b=d2tyj8zimgdpGfE5C6yVPmqqT78gFLFWF6lrpeK8lOTL8tilke9oMtc55i/CkUaESC5ZbKHLTv9Fs5wtxU2LiWwuLu/BGXzEeTpFPJwIg1Qay7+WW9rbB1MHW3/OaDTfinZ99xFfyaZU330GHJfU7AcSJCDbX9Z8CB/pbO8xkVk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767798909862397.04778288185275; Wed, 7 Jan 2026 07:15:09 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vdVEv-0007of-6i; Wed, 07 Jan 2026 10:14:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vdVEl-0007lF-O7 for qemu-devel@nongnu.org; Wed, 07 Jan 2026 10:14:15 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vdVEg-0007NV-2y for qemu-devel@nongnu.org; Wed, 07 Jan 2026 10:14:11 -0500 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-245-mcfZsUneMn2dz3Lo63Ngew-1; Wed, 07 Jan 2026 10:14:06 -0500 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-47a83800743so5161915e9.0 for ; Wed, 07 Jan 2026 07:14:06 -0800 (PST) Received: from [192.168.10.48] ([151.61.26.160]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f410c86sm105075265e9.3.2026.01.07.07.14.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 07:14:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767798848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SJTfX9vnrMV0tPHM38seWbDHpgKlBHplIleCEmi8Ac0=; b=WGH8UzJ23q6fmbUwTy1LMoRhKnBTV0H4NRoSn8Wz/fj2tpG4K1mgvG8zUQ2JNGsusqALo6 gfWYmLsxh5X9HzOzAQcb7Y3SGyasuIEPuMuU0nB0Pb0gPYAHxCF4fghKL33lYhBvdIf2mk F0v4gGeVSf3cvw5ckIIW0Axqd1XNWsM= X-MC-Unique: mcfZsUneMn2dz3Lo63Ngew-1 X-Mimecast-MFC-AGG-ID: mcfZsUneMn2dz3Lo63Ngew_1767798845 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767798845; x=1768403645; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=SJTfX9vnrMV0tPHM38seWbDHpgKlBHplIleCEmi8Ac0=; b=HYF+DmoVL0VQanjS+UhhvTqoNRCy92bE9Y661lAIuwxc6D6aB3jg+HeFaH3DCDz31h 8zMsZfuRmgmFZeaJIHRU6pUm4VSiuE2CDwRCYHWGYa+IAvNGgj075FrwYKBrs66JAAOs LC+ddE58813mJ9veErYXzW0dwRYGXjn/nkQxcrWZ7hzcDPGzCwXf6sR29BpJlpzVMJKW ruXP3QSvAuW8gTM3KyWqgLi8kmHBK9C5ZnymDbcCoGRq6hxS1wVACnWled2x6FF3hPdd 8jQFwfcM0HZgCPriYaSoFL0KNB1Br7DzwnfehYbqUsSqsf5GC/EZCutPt11jQT3zEvrp 3dbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767798845; x=1768403645; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=SJTfX9vnrMV0tPHM38seWbDHpgKlBHplIleCEmi8Ac0=; b=Xv8mkeLdJEE+TZ9Ip+l3HT+XTp2SwIDc8BbaDBW190LcPM+AkBIS9oaYLzZTsioYJA Mf4JhoC97OmnTDBAgbizfjZNw9MI36sAYxomB85MeMP0JqkotA7jpREurO6/CmqJKTUN WaHbKnhdOk0abajJ3C3j+eL+LgioPyyzX/RGnXiT7VObk4T2kuE+l9iOsWhXSlLargml y6SJtztf4DcsyS/rCrG68DWmmukeRFTg3URXGq3ObytbiuOqgaDUpD3GtH0LNdhRm2XL DhwPOJpruY//Ybe5avvQy8LU3P7MOuuB0d86OqX7D5T5xX1mjo5XPiaJ/qzdNXXGhtgb gCJQ== X-Gm-Message-State: AOJu0Yxg2zph7ECgx/PJCDx88wnMJTdINrnKxkTR6bmG9d2oak5Xv4a/ Mll1g/+DMeb+P1hnALz47hnpLcv4JYPomnn1LXEtVPxdLj9/+vClHszZXLYTcaK0JrlMDkVjMVi +9Kd/mJOiEMFUqdXE4jxTpcgym6CjZWRt00oygB24mIj3mbEX68w5fRlsyatXi+Zp7H2TIBU7To y0nXRqFxX0fwV7oEHcUjRvIs10c7O+9/uKIsESQJK6 X-Gm-Gg: AY/fxX7HwRDYXSUJjwot4YGvga6Pm5ig9RKbJfSl6jej+pxwlobdx3y9Ma54SFTYtv0 7WEbcl1WeH53EVONU2BYSrg84alnYsVC1uoUeNEX1riknPe7FJSx1v4/VymVTmcnuTiUj8OY15O MTuBIJFrQxg/+RYCmLKEtLmOOA77O7SVp0GrJhDrG0y+4ixoCIHkJlu9dzpjDz0CREN/kxMmVy1 AOrEz6BNNQ3qxaa+HScdNbwaU/22M9feSDvUliFtq+EgkNUBaE2zAHwqNIOdLehACX5VqmGLm7s tdNdnZuiWCXP/Zk41U6zOjT0vPfpyyg+mmrA0HZ9WC/2I9Jck1sOg1pb43gcYzAUyeDn7goaHbQ +HXvaFTWJNgYlu+Z1qvmrm95WF2MjYpc4ANmcEEKzxl5pDoz4WC5a9chlGZTKlpwv/x0xoBQxyM WYvxfM2b3VSGj4dQ== X-Received: by 2002:a05:600d:41c9:b0:45d:5c71:769d with SMTP id 5b1f17b1804b1-47d8484a4e7mr33591065e9.8.1767798844800; Wed, 07 Jan 2026 07:14:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IGOIPi4aN4GlTO/H6W+R1mDzN95/Wjj+L5odpbRwQSL+QYxRbsJ3x2gZjvx64XGG7DvhI2C6A== X-Received: by 2002:a05:600d:41c9:b0:45d:5c71:769d with SMTP id 5b1f17b1804b1-47d8484a4e7mr33590685e9.8.1767798844367; Wed, 07 Jan 2026 07:14:04 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PATCH 1/5] target/i386/tcg: remove dead code Date: Wed, 7 Jan 2026 16:13:56 +0100 Message-ID: <20260107151400.273916-2-pbonzini@redhat.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260107151400.273916-1-pbonzini@redhat.com> References: <20260107151400.273916-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1767798912120158500 Content-Type: text/plain; charset="utf-8" Remove dead code; it arose when I noticed that, because 0x3? opcodes do have a pop, case 0x32 works just fine as fcomp (even though 0x?2 is fcom): there is no need to hack the op to 0x03. Reported by Coverity as CID 1643922. Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson --- target/i386/tcg/translate.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index 7c444d5006d..460848e4223 100644 --- a/target/i386/tcg/translate.c +++ b/target/i386/tcg/translate.c @@ -2543,9 +2543,6 @@ static void gen_x87(DisasContext *s, X86DecodedInsn *= decode) break; } break; - /* map to fcomp; op & 7 =3D=3D 2 would not pop */ - op =3D 0x03; - /* fallthrough */ case 0x00 ... 0x07: /* fxxx st, sti */ case 0x22 ... 0x23: /* fcom2 and fcomp3, undocumented ops */ case 0x32: /* fcomp5, undocumented op */ --=20 2.52.0 From nobody Mon Feb 9 12:28:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1767798975; cv=none; d=zohomail.com; s=zohoarc; b=iHmcZPVKWTANpFCjXmnLwvmk3y5ZeKMntNs+Ovk8Z0y86B3Lyx1gxNi1kJnhcuq5K8JcSXg/JjPC9ohnMvYvvfgIhJdQiOJ50GJTmQKQxJseec60Kb2MXAi5QAnkjfSc84rEoB3orrZgM5tEOvr8/XfJZZ5Tq+zy9Sw9Ivvc6hA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767798975; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ML8OL3iKvgCC+Xcm6fSbC6KGxridnBQyXVL/pHGenBk=; b=VWmuOVuXLLJn6nm1myh53jni43GRBAsj3tbj6yU6fl0kgXkH0fvGraXjnWzErRaZLZZpAUVtUvkI/WopzutO1wgtT5xIX1Ljd6VpQoXhx0SYb+E1/XCc8UhskKTa9L5gDIilktLIprz9BfWSmnvKeS02U28BxDMLi8QfURd90dA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767798975869645.7734732126154; Wed, 7 Jan 2026 07:16:15 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vdVFK-0007vh-MU; Wed, 07 Jan 2026 10:14:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vdVEn-0007mQ-Ia for qemu-devel@nongnu.org; Wed, 07 Jan 2026 10:14:18 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vdVEk-0007Nn-6E for qemu-devel@nongnu.org; Wed, 07 Jan 2026 10:14:17 -0500 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-446-Jv8KUbk2O1WofMJi5vbPXg-1; Wed, 07 Jan 2026 10:14:10 -0500 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-477cf2230c8so20306065e9.0 for ; Wed, 07 Jan 2026 07:14:10 -0800 (PST) Received: from [192.168.10.48] ([151.61.26.160]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d87166d0csm14722455e9.6.2026.01.07.07.14.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 07:14:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767798851; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ML8OL3iKvgCC+Xcm6fSbC6KGxridnBQyXVL/pHGenBk=; b=Mue48PhM3pVn1A0VQ8CXf7fIoOkfkxpzwE30nI3ezfDc2b0S+8DGQtIFTiM0POWiByuWDs vDkvAniRRfbENf9TCuzcoxGQexj2TzDBRffXhs5Urt5uQzrM/hHKMg5xzDvjAnIiY9QT8E SwRE5Qk7s2AsgSLZYdI4221KlxsvHL0= X-MC-Unique: Jv8KUbk2O1WofMJi5vbPXg-1 X-Mimecast-MFC-AGG-ID: Jv8KUbk2O1WofMJi5vbPXg_1767798849 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767798849; x=1768403649; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ML8OL3iKvgCC+Xcm6fSbC6KGxridnBQyXVL/pHGenBk=; b=mm/h9T2mwm+AYDY9axs9xy6X9xUuQ8N8yiEVA1dPGcWab5rG8iHUGgic9SyMpPHinf O8v5nuffH8nmhHImkxgM0519i4lm00S4eo/sDrksoK2QQDOC00RI1z1QnAIy8AH+35ji zP6FTnfydMlr18eejZlH4HelEd2MfosQh5yQhYdEmuXPfO2YVfwhqftK1ctfn9MKpzbq 6r/Eoy2L91x3KKZoTu/q5H/xMU8XkCb2aCdtQc/Kvi4nWaahe85shQ5IePRurZiQoGXt MmmRG+n5MHCkQdyCkRoHcYQm2RsPfIabrXdnJ0C6REavUXj8VmWt05tCk/glLsa1Y4a6 6jEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767798849; x=1768403649; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ML8OL3iKvgCC+Xcm6fSbC6KGxridnBQyXVL/pHGenBk=; b=TUnBRd1Qx1mtrq3PVs8n4iHGKayzP+kjOwHB4QtM+FPl+Ac/Phc+0GHnyuY32OKrwg 4oveGt+ytORzQ35ZsvXIUWbXnx9ggXeokcPLElPdwCsXifoCAggH4hvH1OjUECLrlWr2 QeZjn+W3OH7wmSfJ6Odyr1CgAuoUrVeAIcMzzXMEVaXnjeXh+dxBc1RJBpWJjKVf/Ukv JFPT+uC27TpQx5e8UEf6dKJreSXCrUBbzPgGV/dEbNs4Y3znuRMCMN431dQ1n7Xkl0z1 +8YX19zXKrexxaBCTkPZRhc5YeC832OHCGMP0JeHB8tuwN/zfjNAI+yVjkTM00nxgalq FS6A== X-Gm-Message-State: AOJu0Yznt+EpEa1Z3ZCmF+Ca/nXyRkTVewSBukbwNe4x6lpowhRIL54x khhlJU09UofIxW+pgC0nMmaoScO3uRhBnkuNudeZAxyf7grdTNLOImr0xAMZz3zlRvodZRh9P+j rbkRGGTeuX+UZZxNgjsoscIA5WsApfDC9dQasAYAOEh9/0Urx6xakPJOvsKJ1sC9oLWnEhY6V1R wsXQi52wZ6LOnJUBIFbb1JUxqeOVJJJhVpDqr0OO4S X-Gm-Gg: AY/fxX7robVBuq17kQ9g2tf64kMWde6YWByEsI2tFjpxoh2C7mb2V7ht1raK4LrHcY3 5o8KkyYaSsjDRE4gSGakIrl+cOIDt0IDY2MPxzbiwo+h1lRFWYYGLbWr82qRgb3z2ZLKEFjzgUQ K8idKoisnLvtkKlZMEXnAA/7pgkGbIaGEYqSbx2P5JszqqPip3DWSdWsPKsz0TLQvl/OSOfmNmH v5XX2PgBb1R18U6f/5neHkr+I+V1oZ3yhdM9u/pYpmYJT6+BAaTfGiJk1SgMfFW3XfRQkjiSzca oiRx96PHa/qYwq55+KFCzbuoxkdDKnlb+jn/49DdCNfn0W15q6M518w3qqOnIhcthOXYI9+Zew+ tS8uvumIpGY+HsTARXpcqJTgAJx2GRs6Ekq0eGHxlmJYRUJazGsHx/wHJfI2xWmxJoFV+99zVmV 5Wg7Xbv2Am45JL6Q== X-Received: by 2002:a05:600c:45ca:b0:475:e09c:960e with SMTP id 5b1f17b1804b1-47d84b38676mr34075275e9.32.1767798848610; Wed, 07 Jan 2026 07:14:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IHZC+iCkA1gEdtHhCPALFp0EreNnpwCr+7E7vwLulZpwul8Ojd8pvMJuMzf6EfMcYytlOFbxQ== X-Received: by 2002:a05:600c:45ca:b0:475:e09c:960e with SMTP id 5b1f17b1804b1-47d84b38676mr34073995e9.32.1767798847155; Wed, 07 Jan 2026 07:14:07 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org Subject: [PATCH 2/5] target/i386/tcg: do not mark all SSE instructions as unaligned Date: Wed, 7 Jan 2026 16:13:57 +0100 Message-ID: <20260107151400.273916-3-pbonzini@redhat.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260107151400.273916-1-pbonzini@redhat.com> References: <20260107151400.273916-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1767798976489158500 Content-Type: text/plain; charset="utf-8" If the vex_special field was not initialized, it was considered to be X86_VEX_SSEUnaligned (whose value was zero). Add a new value to fix that. Cc: qemu-stable@nongnu.org Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson --- target/i386/tcg/decode-new.h | 2 ++ target/i386/tcg/decode-new.c.inc | 11 +++++++---- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/target/i386/tcg/decode-new.h b/target/i386/tcg/decode-new.h index 7f23d373ea7..92822969003 100644 --- a/target/i386/tcg/decode-new.h +++ b/target/i386/tcg/decode-new.h @@ -242,6 +242,8 @@ typedef enum X86InsnSpecial { * section of the manual. */ typedef enum X86VEXSpecial { + X86_VEX_None, + /* Legacy SSE instructions that allow unaligned operands */ X86_VEX_SSEUnaligned, =20 diff --git a/target/i386/tcg/decode-new.c.inc b/target/i386/tcg/decode-new.= c.inc index 9d3a7c0d426..f662364c600 100644 --- a/target/i386/tcg/decode-new.c.inc +++ b/target/i386/tcg/decode-new.c.inc @@ -1068,15 +1068,15 @@ static void decode_0F10(DisasContext *s, CPUX86Stat= e *env, X86OpEntry *entry, ui static void decode_0F11(DisasContext *s, CPUX86State *env, X86OpEntry *ent= ry, uint8_t *b) { static const X86OpEntry opcodes_0F11_reg[4] =3D { - X86_OP_ENTRY3(MOVDQ, W,x, None,None, V,x, vex4), /* MOVUPS */ - X86_OP_ENTRY3(MOVDQ, W,x, None,None, V,x, vex4), /* MOVUPD */ + X86_OP_ENTRY3(MOVDQ, W,x, None,None, V,x, vex4_unal), /* MOVUPS= */ + X86_OP_ENTRY3(MOVDQ, W,x, None,None, V,x, vex4_unal), /* MOVUPD= */ X86_OP_ENTRY3(VMOVSS, W,x, H,x, V,x, vex5), X86_OP_ENTRY3(VMOVLPx, W,x, H,x, V,q, vex5), /* MOVSD */ }; =20 static const X86OpEntry opcodes_0F11_mem[4] =3D { - X86_OP_ENTRY3(MOVDQ, W,x, None,None, V,x, vex4), /* MOVUPS */ - X86_OP_ENTRY3(MOVDQ, W,x, None,None, V,x, vex4), /* MOVUPD */ + X86_OP_ENTRY3(MOVDQ, W,x, None,None, V,x, vex4_unal), /* MOV= UPS */ + X86_OP_ENTRY3(MOVDQ, W,x, None,None, V,x, vex4_unal), /* MOV= UPD */ X86_OP_ENTRY3(VMOVSS_st, M,ss, None,None, V,x, vex5), X86_OP_ENTRY3(VMOVLPx_st, M,sd, None,None, V,x, vex5), /* MOVSD */ }; @@ -2624,6 +2624,9 @@ static bool validate_vex(DisasContext *s, X86DecodedI= nsn *decode) X86OpEntry *e =3D &decode->e; =20 switch (e->vex_special) { + case X86_VEX_None: + break; + case X86_VEX_REPScalar: /* * Instructions which differ between 00/66 and F2/F3 in the --=20 2.52.0 From nobody Mon Feb 9 12:28:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1767798909; cv=none; d=zohomail.com; s=zohoarc; b=bpEun13muGWZnxpiRB2/z5JzRPi2RJT0xch4PSwe/y3yXPWiJo/mOlnB1p78sVuO3zpLCoS8NT+o8ifCm8zA7j1iHQENr8s9EKf2X53ZOcF5HlFQ1evIpsVr/DpP4KmoxTmuw9DYdbLk6ZSyIXVAb5eOCsErau+W8QzzrFtLexI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767798909; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=b5N4837EjUk6A+hFp2Rk+h8B1Uk50LtkfD2wo65Id1I=; b=Qdsx5yThcdEkjY0W48rQ+sStn+bQEZr6e3nqOmhlkFvpQ1IR/irLkJBpzQjsSeEDSejg9nc3Cd1Q8btACCtKeqsmND1U9KTd8dK7y8OOQC+q+Z1swUH+n7373w1rF87QEBOtm6gR6qZjJlBAVcDS3wBd6mnrLL4/KDoLDIO0Y5o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767798909445234.1681685698626; Wed, 7 Jan 2026 07:15:09 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vdVF3-0007tR-7G; Wed, 07 Jan 2026 10:14:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vdVEn-0007mT-LJ for qemu-devel@nongnu.org; Wed, 07 Jan 2026 10:14:18 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vdVEl-0007O1-GE for qemu-devel@nongnu.org; Wed, 07 Jan 2026 10:14:17 -0500 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-90-_EDv0doCMA-XKJFTMbEZHQ-1; Wed, 07 Jan 2026 10:14:11 -0500 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-432c05971c6so755726f8f.1 for ; Wed, 07 Jan 2026 07:14:11 -0800 (PST) Received: from [192.168.10.48] ([151.61.26.160]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5ff1e9sm11438731f8f.41.2026.01.07.07.14.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 07:14:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767798853; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b5N4837EjUk6A+hFp2Rk+h8B1Uk50LtkfD2wo65Id1I=; b=B1mCRgaXx56SyEwClHdeIbH3RGlygFmZ/PQWmhiUDTkYIUKUIzPDAeMU7kd+n+fYN3dfQI ecLuNvzVGU616gxDOYK8UtAFl0FrKvMHA5aixn8mWSJAGNEy6Yl6Cf1woPxLGhfu2GRW6K pQ1JkR/g7Apdl20pT3T2IieH/ZCfVT4= X-MC-Unique: _EDv0doCMA-XKJFTMbEZHQ-1 X-Mimecast-MFC-AGG-ID: _EDv0doCMA-XKJFTMbEZHQ_1767798850 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767798849; x=1768403649; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=b5N4837EjUk6A+hFp2Rk+h8B1Uk50LtkfD2wo65Id1I=; b=f9mFbE5GWnoeFsmdoXkzu/TvRd1r9EujsWlOCb/1zkJOx8JqTmTKVMBt9Q1hxrXT6t dEhfC3+WD2/BfncAwSkEMlY4J/SzIap+Xd9CZr3Z4EKah8EEmhsAFi00/pyJFmqPY/YR 6nnHefOvPCUDSNVTgc/BwH26RzKkVvjP9cTEKAS9Yz29gJdFvq2Zt5GYFSgYyz3MQoIL D04Dr1RKBnBJQfBzNl2AsuGKukgafte8noqvu20rTulkuqOZAlXeFpcqgxZ1loa0iXGU gy4A4J2mJ0Z0XT8qsSvhoZU/GovVJenY2uxh5Ki8xOQy33ZVcROgRC6puYMctHl5ea37 cjzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767798849; x=1768403649; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=b5N4837EjUk6A+hFp2Rk+h8B1Uk50LtkfD2wo65Id1I=; b=Pjjf2meDYEr2+mKWZANhA1bh+t27VK02kmReNzPX3RVVI++lqyV3A/JczV5LjloM5w y5iTjmbiRN3kmkOTXz0SHrXoMDPxYEk2KbyeqN/CEmnUk/xbNopDqooBTbwIe6fTD/fs z4AW4P4vRdBtfIvdi3Ig3+Q31pC4HeGwfp5KyvqZXHJ/Ej01PP+zlLEh4MfdC01VSwRK 6urq3QifvnkYrUq6k1W3VbJXofmbbQPg6UFs0G2qOROsuQ/aUUUJT56gcVrf4QMWIILV TL/3TCkCPsMLkGLJLe7wCXVS+d3w16nfwMntNF16vyjA3soqjcIP6fkjYyM8EI5tCy/X 1srA== X-Gm-Message-State: AOJu0YyrZqaZpg+leivNQ8tsZxePMA/aVmyuLe1OwJ0RVEVbdcUDLjhC pS57Gk7DNX6zYZ1nKPV7xcal/GdnsxKDX9Zl69x4dA+qtkQHJcw2QugxBh4HEEzLSi6EYnVDus2 ILsu72fNS8vmGX/I5uhH596uEIxxLwSy2XSDakMKUcOG6jGMZHhjlYzJLSWH/yJD1H2yEBHX688 aOcYn3OSTbOFQttOlIBn6mRax1fn8pQBIy0RGODdY+ X-Gm-Gg: AY/fxX7QQm4g3tYB/toqcQixB+F8MKyMUeqMkQhJETBjluCD9zcDOaVJyQeHoAfbxN5 QEtf/YGnx+IEGffIqW4KwT2Vg3BXyyy+nytGkXXKWtb6IBCvxBOpVovODMWLoZK1p7vzjcU1+kN vzxS/v2Nw710yi9x7ZmvmXvDo1UycCnDI7pusR/tJ5cpN0dd2Kzafo6GP5BGPFOMcpPxKCA4g64 +XTuU7AxvUqp+rgIGwQR6tNfa5WEGnTGjb3LVQxq4R1Q/bPXPxK3+pvX/Lpa3TvYFmOwubFBAah pRCnnvhkHfP9U7XlXNs90isKGaZcMm4LkYwc3Tq7wtC/RcFMJurN5/bOhAYsylYOEvorXtVap39 FQZeclphnX1qPtg83UKyMO4is8qpot1orKwoNiTZ1U3YLIct8eJpSC6ufNlc47HyS66KtBpwlEQ SNRju9RE8wgf9eGg== X-Received: by 2002:a05:6000:2207:b0:429:b963:cdd5 with SMTP id ffacd0b85a97d-432c362bf78mr3691857f8f.5.1767798849262; Wed, 07 Jan 2026 07:14:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IHS8lL9c2l2qIT9Gm3wYWE3BvU8lEE5atwed9X2oiUnBRm0UcZY1c5MeO6Nbkjhl4cTKTW7Ew== X-Received: by 2002:a05:6000:2207:b0:429:b963:cdd5 with SMTP id ffacd0b85a97d-432c362bf78mr3691807f8f.5.1767798848762; Wed, 07 Jan 2026 07:14:08 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org Subject: [PATCH 3/5] target/i386/tcg: mask addresses for VSIB Date: Wed, 7 Jan 2026 16:13:58 +0100 Message-ID: <20260107151400.273916-4-pbonzini@redhat.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260107151400.273916-1-pbonzini@redhat.com> References: <20260107151400.273916-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1767798910283158500 Content-Type: text/plain; charset="utf-8" VSIB can have either 32-bit or 64-bit addresses, pass a constant mask to the helper and apply it before the load. Cc: qemu-stable@nongnu.org Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson --- target/i386/ops_sse.h | 16 ++++++++-------- target/i386/tcg/ops_sse_header.h.inc | 8 ++++---- target/i386/tcg/emit.c.inc | 17 +++++++++-------- 3 files changed, 21 insertions(+), 20 deletions(-) diff --git a/target/i386/ops_sse.h b/target/i386/ops_sse.h index a2e4d480399..853196b2bbd 100644 --- a/target/i386/ops_sse.h +++ b/target/i386/ops_sse.h @@ -2362,42 +2362,42 @@ void glue(helper_vpmaskmovq, SUFFIX)(CPUX86State *e= nv, Reg *d, Reg *v, Reg *s) } =20 void glue(helper_vpgatherdd, SUFFIX)(CPUX86State *env, - Reg *d, Reg *v, Reg *s, target_ulong a0, unsigned scale) + Reg *d, Reg *v, Reg *s, target_ulong a0, unsigned scale, target_ul= ong amask) { int i; for (i =3D 0; i < (2 << SHIFT); i++) { if (v->L(i) >> 31) { target_ulong addr =3D a0 + ((target_ulong)(int32_t)s->L(i) << scale); - d->L(i) =3D cpu_ldl_data_ra(env, addr, GETPC()); + d->L(i) =3D cpu_ldl_data_ra(env, addr & amask, GETPC()); } v->L(i) =3D 0; } } =20 void glue(helper_vpgatherdq, SUFFIX)(CPUX86State *env, - Reg *d, Reg *v, Reg *s, target_ulong a0, unsigned scale) + Reg *d, Reg *v, Reg *s, target_ulong a0, unsigned scale, target_ul= ong amask) { int i; for (i =3D 0; i < (1 << SHIFT); i++) { if (v->Q(i) >> 63) { target_ulong addr =3D a0 + ((target_ulong)(int32_t)s->L(i) << scale); - d->Q(i) =3D cpu_ldq_data_ra(env, addr, GETPC()); + d->Q(i) =3D cpu_ldq_data_ra(env, addr & amask, GETPC()); } v->Q(i) =3D 0; } } =20 void glue(helper_vpgatherqd, SUFFIX)(CPUX86State *env, - Reg *d, Reg *v, Reg *s, target_ulong a0, unsigned scale) + Reg *d, Reg *v, Reg *s, target_ulong a0, unsigned scale, target_ul= ong amask) { int i; for (i =3D 0; i < (1 << SHIFT); i++) { if (v->L(i) >> 31) { target_ulong addr =3D a0 + ((target_ulong)(int64_t)s->Q(i) << scale); - d->L(i) =3D cpu_ldl_data_ra(env, addr, GETPC()); + d->L(i) =3D cpu_ldl_data_ra(env, addr & amask, GETPC()); } v->L(i) =3D 0; } @@ -2408,14 +2408,14 @@ void glue(helper_vpgatherqd, SUFFIX)(CPUX86State *e= nv, } =20 void glue(helper_vpgatherqq, SUFFIX)(CPUX86State *env, - Reg *d, Reg *v, Reg *s, target_ulong a0, unsigned scale) + Reg *d, Reg *v, Reg *s, target_ulong a0, unsigned scale, target_ul= ong amask) { int i; for (i =3D 0; i < (1 << SHIFT); i++) { if (v->Q(i) >> 63) { target_ulong addr =3D a0 + ((target_ulong)(int64_t)s->Q(i) << scale); - d->Q(i) =3D cpu_ldq_data_ra(env, addr, GETPC()); + d->Q(i) =3D cpu_ldq_data_ra(env, addr & amask, GETPC()); } v->Q(i) =3D 0; } diff --git a/target/i386/tcg/ops_sse_header.h.inc b/target/i386/tcg/ops_sse= _header.h.inc index d92c6faf6d6..bbeb7301c33 100644 --- a/target/i386/tcg/ops_sse_header.h.inc +++ b/target/i386/tcg/ops_sse_header.h.inc @@ -388,10 +388,10 @@ DEF_HELPER_4(glue(vpmaskmovd_st, SUFFIX), void, env, = Reg, Reg, tl) DEF_HELPER_4(glue(vpmaskmovq_st, SUFFIX), void, env, Reg, Reg, tl) DEF_HELPER_4(glue(vpmaskmovd, SUFFIX), void, env, Reg, Reg, Reg) DEF_HELPER_4(glue(vpmaskmovq, SUFFIX), void, env, Reg, Reg, Reg) -DEF_HELPER_6(glue(vpgatherdd, SUFFIX), void, env, Reg, Reg, Reg, tl, i32) -DEF_HELPER_6(glue(vpgatherdq, SUFFIX), void, env, Reg, Reg, Reg, tl, i32) -DEF_HELPER_6(glue(vpgatherqd, SUFFIX), void, env, Reg, Reg, Reg, tl, i32) -DEF_HELPER_6(glue(vpgatherqq, SUFFIX), void, env, Reg, Reg, Reg, tl, i32) +DEF_HELPER_7(glue(vpgatherdd, SUFFIX), void, env, Reg, Reg, Reg, tl, i32, = tl) +DEF_HELPER_7(glue(vpgatherdq, SUFFIX), void, env, Reg, Reg, Reg, tl, i32, = tl) +DEF_HELPER_7(glue(vpgatherqd, SUFFIX), void, env, Reg, Reg, Reg, tl, i32, = tl) +DEF_HELPER_7(glue(vpgatherqq, SUFFIX), void, env, Reg, Reg, Reg, tl, i32, = tl) #if SHIFT =3D=3D 2 DEF_HELPER_3(vpermd_ymm, void, Reg, Reg, Reg) DEF_HELPER_4(vpermdq_ymm, void, Reg, Reg, Reg, i32) diff --git a/target/i386/tcg/emit.c.inc b/target/i386/tcg/emit.c.inc index e55b65176fc..bc3a07f972c 100644 --- a/target/i386/tcg/emit.c.inc +++ b/target/i386/tcg/emit.c.inc @@ -43,8 +43,8 @@ typedef void (*SSEFunc_0_pppi)(TCGv_ptr reg_a, TCGv_ptr r= eg_b, TCGv_ptr reg_c, TCGv_i32 val); typedef void (*SSEFunc_0_eppt)(TCGv_ptr env, TCGv_ptr reg_a, TCGv_ptr reg_= b, TCGv val); -typedef void (*SSEFunc_0_epppti)(TCGv_ptr env, TCGv_ptr reg_a, TCGv_ptr re= g_b, - TCGv_ptr reg_c, TCGv a0, TCGv_i32 scale); +typedef void (*SSEFunc_0_eppptit)(TCGv_ptr env, TCGv_ptr reg_a, TCGv_ptr r= eg_b, + TCGv_ptr reg_c, TCGv a0, TCGv_i32 scale, = TCGv amask); typedef void (*SSEFunc_0_eppppi)(TCGv_ptr env, TCGv_ptr reg_a, TCGv_ptr re= g_b, TCGv_ptr reg_c, TCGv_ptr reg_d, TCGv_i32= flags); typedef void (*SSEFunc_0_eppppii)(TCGv_ptr env, TCGv_ptr reg_a, TCGv_ptr r= eg_b, @@ -1100,18 +1100,19 @@ VEXW_AVX(VPMASKMOV, vpmaskmov) =20 /* Same as above, but with extra arguments to the helper. */ static inline void gen_vsib_avx(DisasContext *s, X86DecodedInsn *decode, - SSEFunc_0_epppti d_xmm, SSEFunc_0_epppti q= _xmm, - SSEFunc_0_epppti d_ymm, SSEFunc_0_epppti q= _ymm) + SSEFunc_0_eppptit d_xmm, SSEFunc_0_eppptit= q_xmm, + SSEFunc_0_eppptit d_ymm, SSEFunc_0_eppptit= q_ymm) { - SSEFunc_0_epppti d =3D s->vex_l ? d_ymm : d_xmm; - SSEFunc_0_epppti q =3D s->vex_l ? q_ymm : q_xmm; - SSEFunc_0_epppti fn =3D s->vex_w ? q : d; + SSEFunc_0_eppptit d =3D s->vex_l ? d_ymm : d_xmm; + SSEFunc_0_eppptit q =3D s->vex_l ? q_ymm : q_xmm; + SSEFunc_0_eppptit fn =3D s->vex_w ? q : d; TCGv_i32 scale =3D tcg_constant_i32(decode->mem.scale); TCGv_ptr index =3D tcg_temp_new_ptr(); + TCGv mask =3D tcg_constant_tl(MAKE_64BIT_MASK(0, 8 << s->aflag)); =20 /* Pass third input as (index, base, scale) */ tcg_gen_addi_ptr(index, tcg_env, ZMM_OFFSET(decode->mem.index)); - fn(tcg_env, OP_PTR0, OP_PTR1, index, s->A0, scale); + fn(tcg_env, OP_PTR0, OP_PTR1, index, s->A0, scale, mask); =20 /* * There are two output operands, so zero OP1's high 128 bits --=20 2.52.0 From nobody Mon Feb 9 12:28:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1767798927; cv=none; d=zohomail.com; s=zohoarc; b=Ym+/CmB4lWPW74qtOF+bzPVUJZA3qV4NsZ00RV1DIPy/c43wA2DInT65zYWUgGl/WmG2lBGLQs5DPa1vJLx+F7EqM1WDhF/8e9QfsgWKQm56cDwaOcPPBSvueirUwHoVFaWoRJMOOf1vkRKcK5cN01r799TZKM7/MX7xOHbE2GM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767798927; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=CnZA0IHH2GsMAGJ/CguzzLpofX9iu8pWCGdVSHIMEvU=; b=bvrz+OTiKqDXZxoMpW/0FTEiMntWHm7KdMqM21t2HnBmyA1hJB8ABBrq1JPA6wOEyoK7xA4VvyWWWkKvHI3iZVgnLU5dSxWIOuGfxpt/zFOfVUcy5bPAmQf0QQ7zmjQ27KezDgQBc2BG/2/BKphoeGavDCwkX1TKRM0+oaZSCo0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767798927972541.8895283014663; Wed, 7 Jan 2026 07:15:27 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vdVFN-0007zD-Sy; Wed, 07 Jan 2026 10:14:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vdVEn-0007mS-Ko for qemu-devel@nongnu.org; Wed, 07 Jan 2026 10:14:18 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vdVEl-0007O8-GN for qemu-devel@nongnu.org; Wed, 07 Jan 2026 10:14:17 -0500 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-428-Aus9TCpXPfW205L6DGAdQQ-1; Wed, 07 Jan 2026 10:14:13 -0500 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-43284edbbc8so1450284f8f.0 for ; Wed, 07 Jan 2026 07:14:13 -0800 (PST) Received: from [192.168.10.48] ([151.61.26.160]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5edb7esm10475826f8f.30.2026.01.07.07.14.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 07:14:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767798854; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CnZA0IHH2GsMAGJ/CguzzLpofX9iu8pWCGdVSHIMEvU=; b=MlEqKFWG8gvx89i4fWBbATez9xmEdOWBqBpZF5cK60uY7qSoHXFYQfc38JvW7LoNRmKoMi eS3tqMZh2yRKMzXBOdG/4mOhna1GyCj1izJP8dJZx9UfK6AJyZgnKwa+M9bh9TJ5WZXXsC Pg9VyeSY3JF8aRfUkOE7vyreBlpZzuo= X-MC-Unique: Aus9TCpXPfW205L6DGAdQQ-1 X-Mimecast-MFC-AGG-ID: Aus9TCpXPfW205L6DGAdQQ_1767798852 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767798852; x=1768403652; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CnZA0IHH2GsMAGJ/CguzzLpofX9iu8pWCGdVSHIMEvU=; b=dnNLjp9KJS/HPPiHdkMNjLcdLNOxZPJfHVF6YRwA3+OIm7Avykgwoe4iodpkZ9/89/ X+IlMbXatPIdpvvrUdtGmeKnGgDLf41AwSeHs2DwrD4BFuIWNKSR3CpgG+bU2nIowbeW U0gC5jSF3ECLkJAnc02r+obYURRnmWT5OX1hb74bHDqFuYo0RWL/ZQTFfFo/eVJBmz1W L9G5RzARRjemfWxdsljLbajvtKB8lNSEeJoRhQ5aIog0m05vD2R1pGVaIfjs+izO3h4j c4GJXbzg14DTJByMmov25eaHn1pAfjR7CtaEUKTT4H9vNKaanxF/AV+gqvCvh608m7Ni GIuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767798852; x=1768403652; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CnZA0IHH2GsMAGJ/CguzzLpofX9iu8pWCGdVSHIMEvU=; b=OYnkcKxB/RcLUUh2bhyOgN1OpfatLPnnj+rXTxwiB0UMIyyd0p9ko81k4bZvyWjbjH sdSNT3N3kQJgztY+GFM+zvNg1u7WHNgZ+M8SpjtaHWbFH5PiyhW95+j9qCtc0V7RH4ub 82vKaYyjehzImxz6lsBeEELtovywOPsrK5p5/RN6gNGKWoNfpZ/1FYy6PRJJ2df6kmrn gEVq7zkoyCLcbiDSyz1yX8pCmrsn8KJvwJzqKa/0PQSaAWQUlYJmZ71l1TSQQy8rnFrN niZ5mOo7HX3pAiPv/RyZ8OCV0D0SwVuN6WZ8490X3tE1bF+hNT9dzLlDHTtCP/Lme9QG EtAg== X-Gm-Message-State: AOJu0Yzhti+HJsGYIqIyemKn3nTS++jDZ5R8/UyKYZfAqeFfw3rNTWOw BGPhwiadDe/TKmiHhQCeOqoCSzpGmy13z1rvrzMO9lWyZwoqqdQrT3MuH2ZQg/PtaC0KVwMYpuR TJTgoanDCj4LItYuo/KAEytEN2Ggw6SWj5aA+tQ75Lmvi5yiYoW7SR+opZXSkV9h/RY9T07nLlH bgYSXIO7eRz0zuWtQOeh3Q/YxZ1/7L911uJyCQu7P1 X-Gm-Gg: AY/fxX7+7LoArm2k0rZf9QFCZDATF2QNoQ27k13wTLXl4eSxuk8HhBzhxXEWly3C1WB cKrnYbE6su0JT+Gu+XLkiqrmT8gpBkCT0sydysxhxFEW1JngRDIZRZmmRljgN+LWa5WTcDTyLWX 42V52pttmXKRl7kxE6QuTC2IXrf0rRNi2AiQ5UGHTxgaRrjTChn9RwPCGdA9hWffl559K0D5x8u dk9wpKIiYQWxkJxHf/5ws6h34kH/KmyJmBYUa1JEI/RqBjduaJbvCKMqP6LX3+XSY3B0rFVT256 YF+9XPU7nMmb3jpU+dtyo2dmug5dNLL9UdQuUriOW1qP7yDxrc4zE3hK07f+3jDvx8PpnFvI7HG NtG65IvGUR+JPfD++Os4C9n7OwVbpGil4X5npTUewMi8lnNcSzzHg6DsU1wdYSxD8ZjJ7l5KHtB 0ie7+iVFzAVf+AyQ== X-Received: by 2002:a5d:5d0e:0:b0:42b:3b62:cd86 with SMTP id ffacd0b85a97d-432c378a8bamr3246269f8f.6.1767798851951; Wed, 07 Jan 2026 07:14:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IESAIrbAialmUD2EWrg2OCUpdekMaqKCZ5bX5RJPsm3INv5CyaxKtutBPbrjHvhzmLnVz01Jw== X-Received: by 2002:a5d:5d0e:0:b0:42b:3b62:cd86 with SMTP id ffacd0b85a97d-432c378a8bamr3246228f8f.6.1767798851410; Wed, 07 Jan 2026 07:14:11 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org Subject: [PATCH 4/5] target/i386/tcg: allow VEX in 16-bit protected mode Date: Wed, 7 Jan 2026 16:13:59 +0100 Message-ID: <20260107151400.273916-5-pbonzini@redhat.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260107151400.273916-1-pbonzini@redhat.com> References: <20260107151400.273916-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1767798930256158500 Content-Type: text/plain; charset="utf-8" VEX is only forbidden in real and vm86 mode; 16-bit protected mode supports it for some unfathomable reason. Cc: qemu-stable@nongnu.org Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson --- target/i386/tcg/decode-new.c.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/tcg/decode-new.c.inc b/target/i386/tcg/decode-new.= c.inc index f662364c600..243df7e3735 100644 --- a/target/i386/tcg/decode-new.c.inc +++ b/target/i386/tcg/decode-new.c.inc @@ -2875,7 +2875,7 @@ static void disas_insn(DisasContext *s, CPUState *cpu) * VEX prefixes cannot be used except in 32-bit mode. * Otherwise the instruction is LES or LDS. */ - if (CODE32(s) && !VM86(s)) { + if (PE(s) && !VM86(s)) { static const int pp_prefix[4] =3D { 0, PREFIX_DATA, PREFIX_REPZ, PREFIX_REPNZ }; --=20 2.52.0 From nobody Mon Feb 9 12:28:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1767798947; cv=none; d=zohomail.com; s=zohoarc; b=avwWPMc2a8GRyPekbJ7p1CWa+5PN5CDVUp+uy2YvHpGRPuhytqY0ZldDlLws3m0dNm77t8OsnJqFORZ+jORMuSFEalM+xB0XS4MkAk3dsGpRBf11MgNwPjInOyBjnnZgI5FxM9QzgRf3Oo2yixvRzNMWddh6j4o8WHGQ9QmHY2A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767798947; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=y+b6NAkRwc1jIzqS3KyEOjNsfNtfzRZdJR3QGZ1FAac=; b=Y71K6aI0BdiBcZVeo463r3pGZzNlvUhR1c5F2BTpvxgNTTi15JFUvAr4wFBgJvN76omOAJNvU+T1N5LyAkp/TL68xW45elqSjMyrER0+UpdkRExSvcIvHBIeH6078Gac93JVW/hpf2uY8VMVHwkOzAzbDyWkrzXINC/zrjzxTbc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17677989475701.5829622262222074; Wed, 7 Jan 2026 07:15:47 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vdVFK-0007wM-Lk; Wed, 07 Jan 2026 10:14:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vdVEp-0007n2-Q7 for qemu-devel@nongnu.org; Wed, 07 Jan 2026 10:14:21 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vdVEn-0007Ol-Cv for qemu-devel@nongnu.org; Wed, 07 Jan 2026 10:14:18 -0500 Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-464-msVfdpDgPqKKN6777D8cUw-1; Wed, 07 Jan 2026 10:14:15 -0500 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-430fcf10287so1622079f8f.0 for ; Wed, 07 Jan 2026 07:14:15 -0800 (PST) Received: from [192.168.10.48] ([151.61.26.160]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5ff0b2sm10763196f8f.42.2026.01.07.07.14.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 07:14:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767798856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y+b6NAkRwc1jIzqS3KyEOjNsfNtfzRZdJR3QGZ1FAac=; b=cX0AIviPZjIye3Gp12UcLlGxJRae93+49Dx/pfdFI/7+Hgko3fA4j8i5r8qqSsBfYx7b6k pcBwSG7luTo8Hb3a6OTSRu9PMy6sm9WPEHoB0UlYiG9Jb13+upoj+uJtYgjolG/8QU6sW/ zG7TgnZs70Son1B/Pm0RDmd5yluWOVE= X-MC-Unique: msVfdpDgPqKKN6777D8cUw-1 X-Mimecast-MFC-AGG-ID: msVfdpDgPqKKN6777D8cUw_1767798854 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767798854; x=1768403654; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=y+b6NAkRwc1jIzqS3KyEOjNsfNtfzRZdJR3QGZ1FAac=; b=a5PjIHDceP7qkFHPLbnVCmiKpF6N6cvyC9k5HFzvnxxlw8lJvUO01s7VBfCzI7B55y DkEnPZhYdjNxUOA4NqlJsrDJed4H26JSdIDT/CS+8nwoqhxKxrU9Y8ihjUwIDyYjudLf SNhzTpO89TcoWQDoSeJdi7VSYsoJu7F9FnLE+gD4KlcdDZ4nO/9WEWACcDllCei+mPhw PZY7k6IkAjzlZSyJkq4KDRBuJ7d3AKZ5xuS35GWZ0T4VjEmeEn4xS6etfM4mnFbFhj8A oy7eg3dNoR5WTIZB1FsMwF8C5U9H5QcILvUY+6xlcddx4AmhiBbkY9aWMvH5GQwSLymV c8gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767798854; x=1768403654; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=y+b6NAkRwc1jIzqS3KyEOjNsfNtfzRZdJR3QGZ1FAac=; b=W5h/W38aOWzSOfz3i4ItOta/I6eSM6TDngWkv86ZIB2Kc+CxdxdPe+4gDTEqGgab3e xtlOuHXs6iRC710VVAjaXku5lV9Yv6tm++Bp6mLDdE1CNB3Dfc4ECCks/G5NDo3y7fF2 ncPwY7OMq8/1ZOxt0b7pbXH4tr63VYj11kwxReFxV2B07RFfe9ZajJiSCVtKYiyp9nOb wAqMfSG4VVGcSnRv9b4ExXD7NxGhH15cIInTC6YgDevR25bTba1RxGqT6y9AJ/YlGGkD MBfqxdrIMLoNPMk2153oaLKohNsj/PfqMXHNkTY4pZPB198fdP0F9LERJJ9kEytslPU+ 4b6A== X-Gm-Message-State: AOJu0YyOste84Xo0DaKaSbKdGfr/Ti6W0bbphX40ntYhyxdF0/MJ3N7S YC5cDYZfdz6lBgj4k4jc8MXUqcQxRIhtEGZQ13Ddf8ldYRrQ3/eqUgLGAch0VKZhBUeJEFC+7mP WLCA/DFRxfcI2FnW01jYHNPL3k1dmpoGWdp344d5Z5t6dSzwqQH3et+m3PFe8DS0ynf7g6p8YlW +Cdm7z8JQciU0d6dih4dL6mXiiXzkGcr8YthIxdITP X-Gm-Gg: AY/fxX4ZCC8vDYY4zzWB0mQ6YrZIH17c/r//nvtYVrjAUiCn+szLtsKxleNjcq1PCYk 3yQAZMadeXNAWNdKcTw5wFw5koqUccbZrrkrrFjKaa/h+kMHFihWn89ARLa8yJy68ZNMOX00/0n phHMdavI3KEL+rd/kaie5E6UoIFFJoJinb5QBw1WwL2TBvGJul6w3OTkG/vypqfWOo+pMPBjRLi d3IdWw+8DhuRqBOgx+WjIbcO/1p+veLyDlMM7sKVxTV7/pepa/ks3Cp7scZG7mzxRT6iiDL1HiN AW2A3y78la84z3WzvXOXuko6tnfKz9AmhkSPBR4UDxdV243WmYi5/obiGk4OHz+A3qMKh1ZBaf0 BYvN6S8Qq29LsnXCaQscpXHC5lYBlWCZrZcqHPYEL5ww/gPHH25xcVZudNQOH0xo8BCmOVCVB1V IuUj1UtcQcbZmK8w== X-Received: by 2002:a05:6000:1865:b0:432:857d:e42c with SMTP id ffacd0b85a97d-432c37c87famr3349081f8f.34.1767798853789; Wed, 07 Jan 2026 07:14:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IHCjI8Gk0XNVxZKgswRiO/IDOGImv9C2X1KUlOFYTPsFxGLKRxlDH5LKsr6XWWfEOU+sTiUNQ== X-Received: by 2002:a05:6000:1865:b0:432:857d:e42c with SMTP id ffacd0b85a97d-432c37c87famr3349035f8f.34.1767798853323; Wed, 07 Jan 2026 07:14:13 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PATCH 5/5] target/i386/tcg: remove register case from decode_modrm_address Date: Wed, 7 Jan 2026 16:14:00 +0100 Message-ID: <20260107151400.273916-6-pbonzini@redhat.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260107151400.273916-1-pbonzini@redhat.com> References: <20260107151400.273916-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1767798948318158500 Content-Type: text/plain; charset="utf-8" Unlike the older code in translate.c, mod=3D11b *is* filtered out earlier by decode_modrm. Signed-off-by: Paolo Bonzini --- target/i386/tcg/decode-new.c.inc | 7 ------- 1 file changed, 7 deletions(-) diff --git a/target/i386/tcg/decode-new.c.inc b/target/i386/tcg/decode-new.= c.inc index 243df7e3735..7b595607fa7 100644 --- a/target/i386/tcg/decode-new.c.inc +++ b/target/i386/tcg/decode-new.c.inc @@ -2024,12 +2024,6 @@ static AddressParts decode_modrm_address(CPUX86State= *env, DisasContext *s, rm =3D modrm & 7; base =3D rm | REX_B(s); =20 - if (mod =3D=3D 3) { - /* Normally filtered out earlier, but including this path - simplifies multi-byte nop, as well as bndcl, bndcu, bndcn. */ - goto done; - } - switch (s->aflag) { case MO_64: case MO_32: @@ -2127,7 +2121,6 @@ static AddressParts decode_modrm_address(CPUX86State = *env, DisasContext *s, g_assert_not_reached(); } =20 - done: return (AddressParts){ def_seg, base, index, scale, disp }; } =20 --=20 2.52.0