From nobody Mon Feb 9 01:50:39 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767715126; cv=none; d=zohomail.com; s=zohoarc; b=OHp54gszr4NhCQgDk3c3iDc4JUPi4Y7gpD0A1yZaOWIP/ZJ/9lXH3YBWXDhXy0VP0jXWHfdhRspG4BcK9hoF/PG4JFfc1WGRxdpzn+Z0vE/NYfR81uksBOFvSz90GxyXN5Jfy4jmrxjZm3oxzlAqvr4mMgYcycMLybbLbFcIJM4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767715126; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=E5roLA89uLgbVSNGHvODMTx5DI2hyxThnFPheFtSmSs=; b=lP8mcBgxFaKLs2HN6ipxooYWJdvAaM0BUp/+mS2gimU52HO5S1qvwonul2beq2JbgvcvlLbpLx/Sbv73nttWinVqW19O6LUYv9f3uQyyVinLvT3Ujtx2SC6COFq214zrBx02dn9VQwazgk0FFneON0UC+gDluJq7FySuNQdEACg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767715126259453.0410739287149; Tue, 6 Jan 2026 07:58:46 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vd9Rh-0003Ht-03; Tue, 06 Jan 2026 10:58:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vd9Rf-0003Hk-O2 for qemu-devel@nongnu.org; Tue, 06 Jan 2026 10:58:07 -0500 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vd9Re-0006TC-6F for qemu-devel@nongnu.org; Tue, 06 Jan 2026 10:58:07 -0500 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-42fb5810d39so647541f8f.2 for ; Tue, 06 Jan 2026 07:58:05 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd0e180csm4967390f8f.10.2026.01.06.07.58.03 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 06 Jan 2026 07:58:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767715084; x=1768319884; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=E5roLA89uLgbVSNGHvODMTx5DI2hyxThnFPheFtSmSs=; b=ZgKCUYJzNsrjk+hQDSwH89xprHuKIf3bouvvHS+ZdN+Ap0TR1/S5CRluc92rQl2xoA 82kUEm7WT2lfAbEZ0KVL+mxgGguaTtHY2a0im+cYppypjEYZ/wGXIrFCY2wTbL5YIWlA +XVrFQ0taUNO5yCLOVi4bm1fAt/JdZs+2pZ5ZEsD/OFhWvPHrXntPDrdOV6r63Kkd6ii +LB0HHNH5xXvZvp1VmMSfdg8/uJdpk+P6qK3fh/T4w91WG6DWEFo+5ANFGiYNnNkkrzF dXNGvaL5UfFdEUF98cQobAk9uCSOe9yWY75f1WxgxhmG0TEbvIksL2Jhf/BIm+KEUKsa E5Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767715084; x=1768319884; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=E5roLA89uLgbVSNGHvODMTx5DI2hyxThnFPheFtSmSs=; b=nAFLjhJtq29ZP8N9F+poaohigUKBeSRLK3rAVMIuc2P01PF1CNVWlOiM1XbWhQkdtn BfcdqnWbtuSIEh+nrlDlZPNwymoZ3U6xY4ln1D1EF+InXb7RvZgfdzJK1we3PSPVYbUg JTG09IF+KouzM6c+ZdSyKLpdpPtYoBWu2FXx5wydUuonDEOmOR22z/pY+cEwH0JyXIde hNn9qOY9R4OYWLg4Qtcgw/Ia6YWowxcQv3Q9agL35EuGgDzW+FZ50Eslvxlebj5K9K9k sGr0mmNhHRcsf8VJ14TDvFtVRySGxyn2k2rYr5lnCqn5i3ghtYGLLqu4ywglRkvbgEAT Vo/g== X-Gm-Message-State: AOJu0YxHjq7nfYxDcxuTvdjjzU36hXhddVngkYnYbQ6IK236c740RVuz 8xgZMaNzM8sipET5+YLJPIObu5kBvfK8AZXCAvZ5ig6Yi4ZKLkPkKHp67BG4+ZMz/lnUaA0RdNA LrWony1U= X-Gm-Gg: AY/fxX5HTFjGJ/EJQJvaOMshk5XIcypx55Ya/nvH3dND72b5e8cmW3xDYv12TztdXvS EiN6xyF53p3TmKSXUheSVOUsgUhn07mB4csL2qsQDqAEqKEDgHCFurgy+ZHhMrw1AjBM4ciqpYf hrIevGGw0wsZ/Vh190tmxqXCq8+UecN0d+9DNDWL7EaNHC2ScenbKNIbFvJ90jVRd/Mae7ZsKds IVq3LGF5TgGgrwOI7ySXmN37HmSRhEvMLHwRn3XdR1Rtdz3qFWgaCfsicUuL7m4iN7ICvbo/TM2 3z+SUYtKIqS2a24HKNiyBf9nW7dyk9oYIC+cJr/NAK+9N6NlR1XxQ6zwxlXFmrGKeMbjZ3T/389 9gVKToG899BDyW/E1JENeyw+we2Rec3GW6u+y9vpOo84RK5+wdtmoYf9/pdUv3OBfM1AVJ1Lncp sikH58S5hV1hAeLsg1f6xS/0bZGNiFTxjG0v9EZZizXbROGH1YxLz03BWwK6/ovGUgg9W4L6E= X-Google-Smtp-Source: AGHT+IE15yS0TX56lvaufPD4IOv+N3Eu6w+89GICp6O6msnA0bjYS1nfSQif+7WSefs+LtLeWUL3tQ== X-Received: by 2002:a05:6000:2204:b0:430:f704:4ef with SMTP id ffacd0b85a97d-432bca58d28mr4124477f8f.61.1767715084064; Tue, 06 Jan 2026 07:58:04 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Laurent Vivier , Richard Henderson , Pierrick Bouvier , Anton Johansson , Manos Pitsidianakis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 1/8] hw/alpha: Use explicit little-endian LD/ST API Date: Tue, 6 Jan 2026 16:57:47 +0100 Message-ID: <20260106155755.53646-2-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260106155755.53646-1-philmd@linaro.org> References: <20260106155755.53646-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=philmd@linaro.org; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767715129011158500 The Alpha architecture uses little endianness. Directly use the little-endian LD/ST API. Mechanical change running: $ for a in uw w l q; do \ sed -i -e "s/ld${a}_p(/ld${a}_le_p(/" \ $(git grep -wlE '(ld|st)u?[wlq]_p' hw/alpha/); done Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Manos Pitsidianakis Reviewed-by: Richard Henderson --- hw/alpha/dp264.c | 11 +++++------ hw/alpha/typhoon.c | 4 ++-- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/hw/alpha/dp264.c b/hw/alpha/dp264.c index cddd94fec82..5e64528431e 100644 --- a/hw/alpha/dp264.c +++ b/hw/alpha/dp264.c @@ -194,12 +194,11 @@ static void clipper_init(MachineState *machine) load_image_targphys(initrd_filename, initrd_base, ram_size - initrd_base, NULL); =20 - address_space_stq(&address_space_memory, param_offset + 0x100, - initrd_base + 0xfffffc0000000000ULL, - MEMTXATTRS_UNSPECIFIED, - NULL); - address_space_stq(&address_space_memory, param_offset + 0x108, - initrd_size, MEMTXATTRS_UNSPECIFIED, NULL); + address_space_stq_le(&address_space_memory, param_offset + 0x1= 00, + initrd_base + 0xfffffc0000000000ULL, + MEMTXATTRS_UNSPECIFIED, NULL); + address_space_stq_le(&address_space_memory, param_offset + 0x1= 08, + initrd_size, MEMTXATTRS_UNSPECIFIED, NULL= ); } } } diff --git a/hw/alpha/typhoon.c b/hw/alpha/typhoon.c index 01fda4b1c8a..7722d4fd009 100644 --- a/hw/alpha/typhoon.c +++ b/hw/alpha/typhoon.c @@ -622,8 +622,8 @@ static bool make_iommu_tlbe(hwaddr taddr, hwaddr mask, = IOMMUTLBEntry *ret) translation, given the address of the PTE. */ static bool pte_translate(hwaddr pte_addr, IOMMUTLBEntry *ret) { - uint64_t pte =3D address_space_ldq(&address_space_memory, pte_addr, - MEMTXATTRS_UNSPECIFIED, NULL); + uint64_t pte =3D address_space_ldq_le(&address_space_memory, pte_addr, + MEMTXATTRS_UNSPECIFIED, NULL); =20 /* Check valid bit. */ if ((pte & 1) =3D=3D 0) { --=20 2.52.0 From nobody Mon Feb 9 01:50:39 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767715112; cv=none; d=zohomail.com; s=zohoarc; b=hGsnmzvK9a+qBrfeMJ0FZIxOv1oJ5lGdUXaD+1F0qHFg8LBXbjWWHHpNTXSRwEG5Gvx7DFgcDpvA/kdr5iy5xp2AKJOYojRKWEG1sok2cF5j55K1zDZ/iMn4DFk2vndmdY20ftnuqCQM/we94Ec0CMG2Pmtq6gXh0YR1Dd4bW7M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767715112; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=O3ZOyyrZ+O3zgjlLHnoxYf+lt/LGps43wfGqI92W+nU=; b=EqB614C+RSGxzdxYSumLvml2E2wS/cBI/fDKPtKS/dN1RSpi5b+OJ1jMg5pDjnxG3vl1SgTLL4djTlX/iM6DVuIrvDyRAb5oS1TxfBzOth/r5Mf3wjmonUjpdRVs4pjS1gw8VjcI+3auT9uaf2NWdsbDXXmlx2bYiDA8Lg8SM5s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767715112926320.64033316798884; Tue, 6 Jan 2026 07:58:32 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vd9Rn-0003Ia-Lf; Tue, 06 Jan 2026 10:58:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vd9Rm-0003IS-He for qemu-devel@nongnu.org; Tue, 06 Jan 2026 10:58:14 -0500 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vd9Rk-0006Tb-Vj for qemu-devel@nongnu.org; Tue, 06 Jan 2026 10:58:14 -0500 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-4327555464cso641737f8f.1 for ; Tue, 06 Jan 2026 07:58:12 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd0e175csm5161993f8f.14.2026.01.06.07.58.09 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 06 Jan 2026 07:58:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767715091; x=1768319891; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=O3ZOyyrZ+O3zgjlLHnoxYf+lt/LGps43wfGqI92W+nU=; b=zqZlQuR2M6DPRpw+NNJB65gyZ5+j6Iqj8UznTXqGIiPiSF7UMJg9GRG1usAs81hd08 Ctj0Dq1tMENoS9OuCRuYHgM+KKQmkb0KxZdQXh+iYKfme6Eiv3jLMqUybFiTeul8F22O k8hWF6YIed254x6MPgouuGdp2kPmJ4IjhOBqGvuC0Acaj4hhE6iqXN7m+HLetPhEj64F 07kelXx3/7ZENWvm49IO/N84u7550yq5xAjTqqOFWOsETJfWaGFkesBTMh/G/PjMzREp B1Vf6r2ELd+0GoFGQ0gBLAIVG0O0GFPRHepjGvAy/klelnshRzNZjWrzzQwLsB89hkCP 4Udw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767715091; x=1768319891; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=O3ZOyyrZ+O3zgjlLHnoxYf+lt/LGps43wfGqI92W+nU=; b=uhCVw3/ZhY+8oXFuQPcSrqJbHAKoy1AZBVI7KPkVVeb5PJfvb9P3+lNGTTGZHqAXuG h1R/+U4ztzoZWkXqHyZH/Y9bV5n9Oiw3X1jTfFSZYNvelhXbdqjZRcWqavivykBCByTy /mNVuX2sH50XB49/Fe6pKMGVZC2G/8lfX9Nv7+FjJm2fiUabgkasJ+51cTnduPJdNvMH 7RZpkawWtEGvSdFrKfkTV/0FKfG2tCIfjHA5JjtU7ydYtq7RoXB/euAVbdxXfFdzUP8T c5+gEn4scwhbtPAsw8ZCiqEES60gv6MEMwkaw51PpjiLw1a8GAMSVRplHsIw2jIXS9dW Bv+Q== X-Gm-Message-State: AOJu0Ywq9GaPisEpQBBsUFx2kRNPMEW1waK+RAGtVz2064lloN1Qecob 4hsjbbib745NuKAhP8a+hfZ7vE34ts5Fm7qm3sh5XDbekYRbhfGKfdbmZH7fm9SYjjoocnGLOIU hO/4Zddg= X-Gm-Gg: AY/fxX48nCk62jNWl9JiCCvGEU0cGOWagwL7zsScN2CTvJ4C+RW1YZ8RaNzrW+WYWjt EaGbe7/D6IVPuyMMcPOBBiu2MJPOJ033K+vCoAVsNeIRDkpdYHn4KbdAcrZgXm2kCtRGCu2E9D7 REqJwh/zgUHR23WJ1R4dQf3uvc5OFqEXK+0dJmyoH1fwX9sIJFgXVvzaPnjuUX0fJ/9rk1lc0R0 Ef0lsYATGF/DiDJKXwLapGscyKcZarZWFQ55LDH4lYrQVil6Eh6oRVolYvIaJ9kD1CBnS6H2xlR LIzfY1xT0OAOVtclrG5Ms16I/xpIVFTCLhA592Ljm8YNqF1F9G+BmNo/HdfOB5c6yOyKkNUUQLl SFEe8DtP6XQWJhfDXCzHivjfxbIv6gjR+lsym0kgYKqMdsX1twUyf0o7oHCkLMUXJKv3KhUdeIL +GXxpFh+oAsjN+9Ujn7FEZpB0VYB9WPBC3bk3Z7tMsaygIfKEuN1+8MAdafFtS X-Google-Smtp-Source: AGHT+IEZ86I3WcEW/eKZMbQiX9Fc+OHHuEzEwEvc5KzfTW8G9rLRJ+YDP9TFcDEeEapQkZPdunuQ6w== X-Received: by 2002:a05:6000:26cd:b0:430:feb3:f5bb with SMTP id ffacd0b85a97d-432bca5227fmr4838632f8f.60.1767715090978; Tue, 06 Jan 2026 07:58:10 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Laurent Vivier , Richard Henderson , Pierrick Bouvier , Anton Johansson , Manos Pitsidianakis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 2/8] target/alpha: Use explicit little-endian LD/ST API Date: Tue, 6 Jan 2026 16:57:48 +0100 Message-ID: <20260106155755.53646-3-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260106155755.53646-1-philmd@linaro.org> References: <20260106155755.53646-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=philmd@linaro.org; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767715114744158500 The Alpha architecture uses little endianness. Directly use the little-endian LD/ST API. Mechanical change running: $ for a in uw w l q; do \ sed -i -e "s/ld${a}_p(/ld${a}_le_p(/" \ $(git grep -wlE '(ld|st)u?[wlq]_p' target/alpha/); done Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Manos Pitsidianakis Reviewed-by: Richard Henderson --- target/alpha/helper.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/target/alpha/helper.c b/target/alpha/helper.c index a9af52a928f..80542cb0665 100644 --- a/target/alpha/helper.c +++ b/target/alpha/helper.c @@ -214,17 +214,18 @@ static int get_physical_address(CPUAlphaState *env, t= arget_ulong addr, =20 pt =3D env->ptbr; =20 - /* TODO: rather than using ldq_phys() to read the page table we should + /* + * TODO: rather than using ldq_phys_le() to read the page table we sho= uld * use address_space_ldq() so that we can handle the case when * the page table read gives a bus fault, rather than ignoring it. - * For the existing code the zero data that ldq_phys will return for + * For the existing code the zero data that ldq_phys_le will return for * an access to invalid memory will result in our treating the page * table as invalid, which may even be the right behaviour. */ =20 /* L1 page table read. */ index =3D (addr >> (TARGET_PAGE_BITS + 20)) & 0x3ff; - L1pte =3D ldq_phys(cs->as, pt + index*8); + L1pte =3D ldq_phys_le(cs->as, pt + index * 8); =20 if (unlikely((L1pte & PTE_VALID) =3D=3D 0)) { ret =3D MM_K_TNV; @@ -237,7 +238,7 @@ static int get_physical_address(CPUAlphaState *env, tar= get_ulong addr, =20 /* L2 page table read. */ index =3D (addr >> (TARGET_PAGE_BITS + 10)) & 0x3ff; - L2pte =3D ldq_phys(cs->as, pt + index*8); + L2pte =3D ldq_phys_le(cs->as, pt + index * 8); =20 if (unlikely((L2pte & PTE_VALID) =3D=3D 0)) { ret =3D MM_K_TNV; @@ -250,7 +251,7 @@ static int get_physical_address(CPUAlphaState *env, tar= get_ulong addr, =20 /* L3 page table read. */ index =3D (addr >> TARGET_PAGE_BITS) & 0x3ff; - L3pte =3D ldq_phys(cs->as, pt + index*8); + L3pte =3D ldq_phys_le(cs->as, pt + index * 8); =20 phys =3D L3pte >> 32 << TARGET_PAGE_BITS; if (unlikely((L3pte & PTE_VALID) =3D=3D 0)) { --=20 2.52.0 From nobody Mon Feb 9 01:50:39 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767715145; cv=none; d=zohomail.com; s=zohoarc; b=LIOLNJbAwnsc+XVixW6J6GAaSK1XnapiNvS4DYTac3S92gw7/w7o8yCvJiZKgaOvSL4Swu0A6VdfIstwuNE7vEkZVZ0wy9pfEhnhSLgK/Hp2te13EZhN4cHoYcK5P6ThNRFHqrFhCJznGmkRlAoTnvse0k3K71F85E82H0VLVME= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767715145; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=o0RCypk/eN7poBbZcD877As9DAVSnOVK/KObwXFd6P8=; b=gAtjaqcsr5JJ0qI/fgNzcbB2W5mlpasne54ipunKpcVWurarJbEFhvfSB9oWA1r3Hd+/WIdb0iALpNQKzuSgj4WM9qx6OJMfJBtoX4SbD6eVCvjmNamqbeXQbufSEwpELH8uTaatm0J3Vt2PlKwVA7uSBw08Mrw2sUYRTYcZOEc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767715145579952.6945462088474; Tue, 6 Jan 2026 07:59:05 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vd9Ry-0003Mc-1v; Tue, 06 Jan 2026 10:58:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vd9Rt-0003JD-Ew for qemu-devel@nongnu.org; Tue, 06 Jan 2026 10:58:21 -0500 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vd9Rr-0006US-Uz for qemu-devel@nongnu.org; Tue, 06 Jan 2026 10:58:21 -0500 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-42fbc305914so766414f8f.0 for ; Tue, 06 Jan 2026 07:58:19 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd0e17aasm5100181f8f.15.2026.01.06.07.58.16 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 06 Jan 2026 07:58:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767715098; x=1768319898; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=o0RCypk/eN7poBbZcD877As9DAVSnOVK/KObwXFd6P8=; b=pfYJIxTuwfLfNSuHFVEJhzX7zONV+7y42sPUOJYSXzkAlk3tWGBOD2iIPmDZeMozQF Ns1lnNf2HS8jiPEf8U9+CGiIdJJi4lR8xs1RhjxRXsccBcb/ca5pDgpxA8L6FzfjWnm0 fcJ02Tngcrf0bGmeNNMyf/e0k5gjlCZCeT9UVDojV19zSOza1dX7Yc1Jdr5nc0YmwrMK A1ztUYhzr3UG45XPgxPEHbp7Jh9uj9Sqj0pr1p2VG7RLjTnfF9jMGpqYTogvoY9mqDA9 hB8clcC69o08yAfp/gXWSEhpUIXJYWMTAngTt7nglZMJmrWDUyJomjGmiFaK994ios/d X9Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767715098; x=1768319898; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=o0RCypk/eN7poBbZcD877As9DAVSnOVK/KObwXFd6P8=; b=CMDJ4zKqzef7FTsl1YqDnxTCMz67owpzwfOaKHsTpsohBZ2RcmEcC5nkLiAouMuETW ZcRwR4qmLMNbBKiB5Mc+e6xNI3KJ33P4XIRfzt1WljaI+FxbOKYINQsuK29Cf9zwcVLi W9JvDydgrH2Wuei3qP+ncyXoArikTOELB04kTvntbVfbWUX0K8Ew+wm8jqhW5u0yeBuT DCIbHtUgRoGIi5hxSstyTKgbfMfiaAF36Mt5wUXef5qhduE2oWLb2eU3dWXEA5PmYUhI HV+nAlwRzK1yV0OeD/Xm1av7GfmZ2NZ+HexGfob/sbVxICEW14O7E3iMjKybMnYicX5x Gt7A== X-Gm-Message-State: AOJu0YyEbQNQJwrpsu+I7qxOlUzscmWW12RBkFizqPdLMTtiIH+EIMDD 4guoolc5FA4wOwoNXfGnSHFtPknqrTByUNLvG0oRuKP/9Dl45UAId+hyHbBfjmyQO6v6TH2ii1F BngVqi3M= X-Gm-Gg: AY/fxX7FKoHiMJiyzB+PJ//LmtjxriJKTEDuGAeKMUpXKrKUOHP+INg0qdKz+K6vfQV 5D+cm3gO524SEnB9i6a+hcK0/U+Wv2Ejzmp8pd+cnBxd1fR0lGsTt0mlRX20MC2QQMrEEZBLlai OenIZ8os9Ir/SBEteTaAyKcwmhe/OpvEBjNQHKpWw/cVbi5zB0bvAl9TFAcf9af9pc76PKYpzIi tdcmR3B8NkjadLKSkIexxqGclaI7gkPuWKCZTIyNoImGJ5qs0C0+F++iNgYkXwdpnmznyMJ9m3x BTYhA/XAwqSxQpsM2xeeiRA76C9+l+p6blx+Q4nnPc47e4aPI7TXBm/rC5f7zNWNbfqof235xp0 D3+7yz2PD0k1AoT8S2VCbj9n7DUcWp1kNsJK44ZPM+VL1oWOZ1WOY+kwXqJOqTPE/J4ULlEFJQY XVtD5uPE/iREdhpMlIsBJPNCpvahYweC9dyj3YHD+6vH5JkBwID5zIfpxoazIt X-Google-Smtp-Source: AGHT+IFcNmVC82Ta2qKuPmJK65bu0ewS1oD34i3V3bQOBqOoE6OS9N58jDYwCCfZzcld9DtGjEZLyw== X-Received: by 2002:a05:6000:2387:b0:432:5b81:483 with SMTP id ffacd0b85a97d-432bc9d37e3mr5179478f8f.24.1767715097917; Tue, 06 Jan 2026 07:58:17 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Laurent Vivier , Richard Henderson , Pierrick Bouvier , Anton Johansson , Manos Pitsidianakis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 3/8] target/alpha: Inline cpu_ldl_code() call in do_unaligned_access() Date: Tue, 6 Jan 2026 16:57:49 +0100 Message-ID: <20260106155755.53646-4-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260106155755.53646-1-philmd@linaro.org> References: <20260106155755.53646-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=philmd@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767715146930158500 In preparation of removing the cpu_ldl_code wrapper, inline it. Use the return address argument. Since Alpha instructions are always stored in little-endian order, replace MO_TE -> MO_LE. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/alpha/mem_helper.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/alpha/mem_helper.c b/target/alpha/mem_helper.c index 2113fe33ae2..572ea9cb418 100644 --- a/target/alpha/mem_helper.c +++ b/target/alpha/mem_helper.c @@ -24,13 +24,15 @@ =20 static void do_unaligned_access(CPUAlphaState *env, vaddr addr, uintptr_t = retaddr) { + CPUState *cs =3D env_cpu(env); + MemOpIdx oi =3D make_memop_idx(MO_LEUL, cpu_mmu_index(cs, true)); uint64_t pc; uint32_t insn; =20 cpu_restore_state(env_cpu(env), retaddr); =20 pc =3D env->pc; - insn =3D cpu_ldl_code(env, pc); + insn =3D cpu_ldl_code_mmu(env, pc, oi, retaddr); =20 env->trap_arg0 =3D addr; env->trap_arg1 =3D insn >> 26; /* opcode */ --=20 2.52.0 From nobody Mon Feb 9 01:50:39 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767715148; cv=none; d=zohomail.com; s=zohoarc; b=Vdbo+4QlIunD+Ik7oIeRtD4FoVZ7BFqQecQM32TE1+zVTqVsliEI66ueSU9qCShmG6yIEWe0cEuSBUbFaVjmoCDqUMlg+H7e9QGB8MCe08Dbq/ipEpiqLwSCHsTB1vqvGVf6yue/jCdUr7V35zmqVzYt0Mwp2fZWdJ/9A94YgRg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767715148; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=WX7ny9hKTTzw6SP1v80xQA6vUE2M3vQFdosLC/UPUo0=; b=R0KD6U83+jG3rx4eNZTdeeU2+pv8wGmcswIVacGN3hsU0pNBMWIFtPoc0t0XvPp0Tc4rPktWoBf1K+62kCpIWXZkFiGnVRfMzGVqRGw8UFaYIRvd1xQEpb1KJ4mN8wjHrdKjq2R3ovp2Fv1g3S/DudrSKy8SWPtYRryfneZyPrc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767715148830562.4479043786594; Tue, 6 Jan 2026 07:59:08 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vd9SC-0003T7-Io; Tue, 06 Jan 2026 10:58:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vd9S1-0003OA-JZ for qemu-devel@nongnu.org; Tue, 06 Jan 2026 10:58:30 -0500 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vd9S0-0006ge-4q for qemu-devel@nongnu.org; Tue, 06 Jan 2026 10:58:29 -0500 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-47d1d8a49f5so7657585e9.3 for ; Tue, 06 Jan 2026 07:58:27 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f99bc42sm21150025e9.0.2026.01.06.07.58.23 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 06 Jan 2026 07:58:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767715106; x=1768319906; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WX7ny9hKTTzw6SP1v80xQA6vUE2M3vQFdosLC/UPUo0=; b=AcpS523B3qQJXjaRS7sWjAMORxmA44sioIeCGPSdMdFtCVTYw3GvmtiSP03M56InnW n97gpsQnVGjUCAcqv0S7Pf26Yb5tUQ+Xz9EDsYb2E/GraO7Ki4n6GQUu6OyGauvkP9x8 qI27ZSO/3qJaGy8I07i0KApykkwai3sYe6vkKSk8qLeWWDCbHuTDv0xcQQ0UE6np0GaO 1+oJb8lRmJM3eSlZIkVTHVeMU4+hNHtwOGhqssKSmgfyKTnnfTACUNl00+m13Hfk9qYu p8C81bUFQpUcvkzsbBBDqRVs+VGIvFHVMTRQp5ioM8xGtBnUMpW/awBy9Q3a2EkziCNp uiIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767715106; x=1768319906; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WX7ny9hKTTzw6SP1v80xQA6vUE2M3vQFdosLC/UPUo0=; b=Uh5wOzSBrntqd8c3WHrsf4jFXSI5fjLEEx+4XInfpe58qyZdvoWsYUGgdskdyS/2bw 8jsm85esfeWZ5OQfw1k++DrW1UQPk4j3fJt4xp5ze/Vpz6jvUqQKhfJDwgLnUQz22YHM KDV8TedmkfNb2W4Zf+4Ps5n2uPFFAorJxW3DKoZ8bM6l7F1upzplmWYBElSbzemlfzSU aXpcgED7wA69J5GYVy+bFP8At7O/tPeRG6vyRmM3lUwE9mxIAtJAKdzentJ37VwfJq1k 2kt4VcOi9LhPWf2+hqKrnjh3Rx4ug/y0rsyJc44Q8uui2dkSR17TdbtehTVnoDrfjXDl 2o8w== X-Gm-Message-State: AOJu0Yz05oEPC5BjAMnrkBcrdAvDpT3S2yaVcwJ/p+N2nT1oGuTmWpWR /lk/4utZDJBqrHjs4V8V9cZ7Nb2pg/2lalunIzPsZuLe/pkv10av0ebK+2FDYqD03NHXENh67bu Y4BkQEVI= X-Gm-Gg: AY/fxX5ob9JkmNhHInPofjBZTOiCAn6FwCKjSWEqmXqYoREeqW7F6ufN+AK+4AbIIfj m4FWEDSGE5DemgdqY4LHold2sF68yB4LMegzm4AQKIMpstOzin0epoqBDVAD0joWaKGDT0/gwDe ZbOLooDFRZsI/THVg/psHY3Tg/nBxGx/+UaI8FAe9eE55yumiP1jRyPdx5g/93qbSI5KCe2U/Bp /Gp1aZnRuefMfVqgg8OxeCVzMZ4zLyuIiGmhy7rAV5i+C5WrA80MlUWLQXa4bURtD3G05Y52+sw qkREFdiXUC1O1frtflmTOub306gdgcNG35gR6z/UA65lvH46dWGNesoBfpbcoNJFglZHZbXUuhT PTpq+yQsIh3iPGCMM4AMy6J4oOGAV2qE2wjinp3EbI/W7pNpntLlGF535drler+4CaNVcdjHVEu UBzd7h9QZd4E8fDPwUocMJC6dSAs+Mb7sDy9wpsytKp78ixq7SwXLkA6+FHU45 X-Google-Smtp-Source: AGHT+IE871QmAPL1wi12j9BKO8IjYBYH0/x7ojMPGeJPDT26p5jlRZWRPL6ZQzLS5lY+ji1ewuYWqg== X-Received: by 2002:a05:600c:8887:b0:479:3a86:dc1d with SMTP id 5b1f17b1804b1-47d7f36e16emr27413125e9.37.1767715106025; Tue, 06 Jan 2026 07:58:26 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Laurent Vivier , Richard Henderson , Pierrick Bouvier , Anton Johansson , Manos Pitsidianakis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 4/8] target/alpha: Inline translator_ldl() Date: Tue, 6 Jan 2026 16:57:50 +0100 Message-ID: <20260106155755.53646-5-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260106155755.53646-1-philmd@linaro.org> References: <20260106155755.53646-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767715150933158500 translator_ldl() is defined in "exec/translator.h" as: 198 static inline uint32_t 199 translator_ldl(CPUArchState *env, DisasContextBase *db, vaddr pc) 200 { 201 return translator_ldl_end(env, db, pc, MO_TE); 202 } Directly use the inlined form. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/alpha/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/alpha/translate.c b/target/alpha/translate.c index b1d8a4eb80a..3be97057465 100644 --- a/target/alpha/translate.c +++ b/target/alpha/translate.c @@ -2904,8 +2904,8 @@ static void alpha_tr_insn_start(DisasContextBase *dcb= ase, CPUState *cpu) static void alpha_tr_translate_insn(DisasContextBase *dcbase, CPUState *cp= u) { DisasContext *ctx =3D container_of(dcbase, DisasContext, base); - uint32_t insn =3D translator_ldl(cpu_env(cpu), &ctx->base, - ctx->base.pc_next); + uint32_t insn =3D translator_ldl_end(cpu_env(cpu), &ctx->base, + ctx->base.pc_next, MO_TE); =20 ctx->base.pc_next +=3D 4; ctx->base.is_jmp =3D translate_one(ctx, insn); --=20 2.52.0 From nobody Mon Feb 9 01:50:39 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767715131; cv=none; d=zohomail.com; s=zohoarc; b=Kw8CuS3jn4YoVQQHp31CmevmkFDWoPC/kRkRo8hlvYTmPrKnaw5MmLm4uOENNKycf/2e6fUH4Tvq5Ldk0u+uyEARHxz7HwSSkvfKbfIvhlOmg5h8aMdU9/vU6SSITP1/EOol8QMvswUE3zyZcGEBUDuFYBjIUwBT3B1PXPi1MmM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767715131; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=JsmbcceSWYg0oBTVRUldiOXkUQKy7EHtgbIvYk6Ti2M=; b=b9IvBJtqsg4Ds4JEGYZbg8mHmMtXi5KmiXIFkVaYvx2IOhRM1bjaLqQSrx4q5H1iau/pi7ib9r6zTO7k+HRW4Cqev/nlgLjV2TfVS6MKcpv086kGna6GNY5kt2td2Tk/5mqCEbXEbvqNpS5UgzxdTNzoO9Kjfbze5NDK/um5n9M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767715131828164.77383372991324; Tue, 6 Jan 2026 07:58:51 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vd9SE-0003VW-5z; Tue, 06 Jan 2026 10:58:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vd9S8-0003QE-GF for qemu-devel@nongnu.org; Tue, 06 Jan 2026 10:58:36 -0500 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vd9S6-0006je-Tr for qemu-devel@nongnu.org; Tue, 06 Jan 2026 10:58:36 -0500 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-47d493a9b96so6815695e9.1 for ; Tue, 06 Jan 2026 07:58:34 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7faf05a8sm20133295e9.7.2026.01.06.07.58.31 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 06 Jan 2026 07:58:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767715113; x=1768319913; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JsmbcceSWYg0oBTVRUldiOXkUQKy7EHtgbIvYk6Ti2M=; b=O++RiiguiuxnIoyQ+s6KoL0J7a6TeDj5HDH/14SVfHsIXWZXq5ETvuYgR/wXcp11Ha TcJefDc45abXJr14moAgzM1DTpQy5arfs08kWNS2piEzNVZKvs0TDiKpUWd02s96fPl3 gDp1Z8Rq+ctKgW7YgREXKfqAgOkr9nUZ4+aPTsoodKX7QArbelzmwTM6zGq7rGggNwCy HSWSgTV//X3Gc9uCjtmiehB2lxaRIqxcvvGBjJ7KFBtt8TG70B2htKaACzziafOZ1Brw Pio9wPsquSVnzbpgfvcXw7hoq9hL9v1684KcMSORbDgznXN1ibnU8DC8tLt/dXjTk6KZ EE+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767715113; x=1768319913; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=JsmbcceSWYg0oBTVRUldiOXkUQKy7EHtgbIvYk6Ti2M=; b=MuGJc56MSW8IRNRU64wQwjV9p6Mnm8HyzT6txIGyqQvDhpoqJ6b9D5bfEZNwTFIPzu pTUX1mlh7kztGhmJDXFr2O4KoONQ86PzS5Xl/9zWzCHaoUvZWryygoYVO0HM7wqZ1MkV kAGyczMYLJUi2YEuhfZ67wIMT2aHq5hBQUOFM8KAR9rTqrlRcfwC4S9Zqyn0KGuMcQNN Z4MaBVVD1K2Iiak/QBjaytsxcc/5U3ui9VekvJ2W+8okDr80BtkwTpkUmPDpWtMWlTwm tsAMgFHVkQzBlylrCWWsz1pF4ixVDGhrC6jIAmAZmWk4bkxfdf3+g7fBANVCOUhdAO8Y ifXA== X-Gm-Message-State: AOJu0Yx583pSDJbHV9VvtGq6MO+llNOGTlft6hLaXrYUbzwFS9OBrQBT yunYy/Ngv7gmuKOeFUIvDAOhL5ZI5JPoR5Q6r0VNeIz/A6wWIvY9GyGkYvF1x1jU4NkffjCrIvf HhNigow8= X-Gm-Gg: AY/fxX7GzxRSMeNsVad7O+AQemjf/JGuR7RPdf8mlF31lw3lrnLz9TPRTREAxG8aTfC NRIJ8XRrex/8WAGbAsUrTlfAezaKqvkbMQs20EQsZCDCvkERMoDyOsZfeHlbhck1IMCbgeJBtT2 oQMNaif53Ix/HqxOcBSN062vbnE26ksEsbonwr11QJyHFxAwOuF3hYW3RUZR+UfX67B1F/NlVtt YuwXhFC5oudPpcjxXbNWqdqclm1ZwjzoZng9TaPakHEiWwFD9jFouYQ0Gll7J6hQG+i/1HnF4YG ijcI4rB5ezVmVrieGtfUpN3SlOQgHKMEeWZZgMnjGhLAhhPsefIq0xF+30RQrSvKbyfwwY+HaEq rZj9jYHils852GPNyVqpj0evsEEOxDsZu3e7HGErBOVjWyn4mcchBvSqqaK4zcXliXQKQ4ckZ4n 4po0YkBKKwWhyVGB4Hvb/QokETxaCf7zP9brSHdbMceADChyV4Yfikc3dpnk03 X-Google-Smtp-Source: AGHT+IGle4zSoPygz2LgdyL21jWjRKLTSUx0e85DDeOFVWepi3Y+otym2t3Hp5FCsAS3TeEaE/S9iA== X-Received: by 2002:a05:600c:b8a:b0:471:9da:5232 with SMTP id 5b1f17b1804b1-47d7f06ff42mr42952915e9.15.1767715113034; Tue, 06 Jan 2026 07:58:33 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Laurent Vivier , Richard Henderson , Pierrick Bouvier , Anton Johansson , Manos Pitsidianakis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 5/8] target/alpha: Factor mo_endian() helper out Date: Tue, 6 Jan 2026 16:57:51 +0100 Message-ID: <20260106155755.53646-6-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260106155755.53646-1-philmd@linaro.org> References: <20260106155755.53646-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=philmd@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767715132931158500 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/alpha/translate.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/target/alpha/translate.c b/target/alpha/translate.c index 3be97057465..4f918cbfe63 100644 --- a/target/alpha/translate.c +++ b/target/alpha/translate.c @@ -96,6 +96,11 @@ static TCGv cpu_lock_value; static TCGv cpu_pal_ir[31]; #endif =20 +static inline MemOp mo_endian(DisasContext *dc) +{ + return MO_TE; +} + void alpha_translate_init(void) { #define DEF_VAR(V) { &cpu_##V, #V, offsetof(CPUAlphaState, V) } @@ -2905,7 +2910,7 @@ static void alpha_tr_translate_insn(DisasContextBase = *dcbase, CPUState *cpu) { DisasContext *ctx =3D container_of(dcbase, DisasContext, base); uint32_t insn =3D translator_ldl_end(cpu_env(cpu), &ctx->base, - ctx->base.pc_next, MO_TE); + ctx->base.pc_next, mo_endian(ctx)); =20 ctx->base.pc_next +=3D 4; ctx->base.is_jmp =3D translate_one(ctx, insn); --=20 2.52.0 From nobody Mon Feb 9 01:50:39 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767715175; cv=none; d=zohomail.com; s=zohoarc; b=beBCqvCyPUZuczO6XAFmfNr676Z+N2E7JU+DHC/mS3OEZbHBh6FgydTnGRQS69+Jq1uli2InvWjQhCxZ7YQikqEZvsVP3BXf9nIaC+U6HOTkvf+rY2daEYDQ7witv/7f24IsAnmMiHrOI5ABb1/VvtXHzspO4uGvo6vlTI7TxLg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767715175; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=jPPHx6tYO5HdcZWsR0MQu0bzC+/0x4C/yY9Fp2J0+/k=; b=RHMW18KVb096mO9/QK7HtzOlDjbKu5RojdK3nfEMolvzQP3QxjhOYD+9EdRroV7oqCLyAYNNteVJq/mwH5/b2e0XCc8Dq4AfHj/sbgku02tz1UEmJGS6e/gqed7sO8sW3d0TgDMi0B9iLdVADkC3dBM5W2Ys+ebQCrrds5vKlMs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767715175319384.3591742360037; Tue, 6 Jan 2026 07:59:35 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vd9SG-0003dx-Hg; Tue, 06 Jan 2026 10:58:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vd9SF-0003Xz-4J for qemu-devel@nongnu.org; Tue, 06 Jan 2026 10:58:43 -0500 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vd9SD-0006jw-MB for qemu-devel@nongnu.org; Tue, 06 Jan 2026 10:58:42 -0500 Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-4327555464cso642043f8f.1 for ; Tue, 06 Jan 2026 07:58:41 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5df96asm4952247f8f.28.2026.01.06.07.58.38 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 06 Jan 2026 07:58:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767715120; x=1768319920; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jPPHx6tYO5HdcZWsR0MQu0bzC+/0x4C/yY9Fp2J0+/k=; b=BvVZuUIECh5mjbjnxsVEK58OXkVYtzG8AvadA+Q96h0kbW/gTFr5ox5HVv+wYRgpsQ OIax54S0GCLSNOQi9i/9beNvN3WMYCJ/MwubNFEmRoUYWhWqGCbD8aebpqcUMvSKTyM5 8R9qgNIyiAvbV+hGQw+GcSxmQBh5UgIngqt0Cc/RGTyPzGEHp4R2DVdmi1O6NfH8oHOZ QLt2lCL9/dv2US5VOOosgiJiI1X/DrckgOVWa6S/8/qKTUHFi/NL1E6PQlR1nHrue08n I9m0EeNANiVFBu4eDx/lOxgRru91HIMrQEu4fFJl+wBfV+i52fOMoxf8fgZKnuT7AzL3 6y9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767715120; x=1768319920; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=jPPHx6tYO5HdcZWsR0MQu0bzC+/0x4C/yY9Fp2J0+/k=; b=jTzZF8v45T7YgDqsX3Jae/kqsJrb57Q6j1CAozCeJHtKkg/vSUmnaijZhu2X1Sr5ev rfn3Y5LCs0XP84w2L4xnX38DlGc7gEnZKJffJTTuoSTOVPBi6X/0pbx1fGVqb3A4UcGx MV6U4AWW8oy/2+5SXWiODRbl24Z0/IWwp6otYRd6aRdcdwTUxx1mruxmi1stt76DEX5H 55KwnPmlikAjVZn4k+Py5d2YlA7ZA1gktj5IsaWmqfmAeG5RQ1Ips66xh5lmk4lbYg4l iq5f0EBWyrnYtsjxNOCLiW0xauRbkTuI/BUKnN3tyYdnQTTOJdzs/E9m2/g6RKmNv19E +BqQ== X-Gm-Message-State: AOJu0YxrPfBuyO4fabAgGMkUzF8RwA3ssYloJuakMhR8JIL85g7Nrgmg n8bO1Rp3eM4F8TT6HixA+SfRwMvdtVq3akOYYt7Tl6yW6crkMNITYT2oujsg8wcyDBy5rHd59Qk hZTfdY7Y= X-Gm-Gg: AY/fxX7G74pYaOVNqivyDdj4bmOuGj323pT5nNw9SvpVTIqLTs3P8ZTVQ8ckpS5ccDG vzbd39DWea1phRdDtB/UwKkUOnQcPfMMIfdpe8oThzGYy+1M2IEdOJuM6G5MJwwY1PiE9X/dNMx ZH7Iyeo+bRIgnm4hGPHfAPpMu+yksX+aKLagxMiBZ+Ag3lR1vNMPVJ1AR0rt5S+RsjJ/UbiEzln BJJiHzEQZ2aogdZWURGvccsr+1uRBaHGgQpHyGQQ9lIPwAnEQF+dF49ypD/A/h7v8Xpkws9av3Z +dR2stutTEioOVnCJ/wFEeFzHHjSLPvKkPYXSaRymHUZAqd49v+JU655G6woKNgfUiL8S5fTD7W Mk6EcboaPWlBwePO5ofy+eqmveKmlx6BVlK4iTqiEn3PQ1XAgALs2uoZk/AGUdUINYi0n5hEg5H 6ltN181uo+6Wf5C7+VmYQsu1lGZrwoeoGG/CJGyDjRM4axxkEURHuPkboP06hv X-Google-Smtp-Source: AGHT+IEh8/7VbkJDHrdMj/Nd0SzC9jWMWgrNKyKsvOfoVcx7tJ790onUyIqo3aw+CZh7YNL5xtajww== X-Received: by 2002:a5d:5888:0:b0:42b:2ac7:7942 with SMTP id ffacd0b85a97d-432bca168c4mr5129097f8f.5.1767715119898; Tue, 06 Jan 2026 07:58:39 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Laurent Vivier , Richard Henderson , Pierrick Bouvier , Anton Johansson , Manos Pitsidianakis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 6/8] target/alpha: Replace MO_TE -> MO_LE Date: Tue, 6 Jan 2026 16:57:52 +0100 Message-ID: <20260106155755.53646-7-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260106155755.53646-1-philmd@linaro.org> References: <20260106155755.53646-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=philmd@linaro.org; helo=mail-wr1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767715176943158500 We only build the Alpha targets using little endianness order: $ git grep -L TARGET_BIG_ENDIAN configs/targets/alpha-* configs/targets/alpha-linux-user.mak configs/targets/alpha-softmmu.mak Therefore the MO_TE definition always expands to MO_LE. Use the latter to simplify. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Pierrick Bouvier --- target/alpha/translate.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/target/alpha/translate.c b/target/alpha/translate.c index 4f918cbfe63..d9248e54eb6 100644 --- a/target/alpha/translate.c +++ b/target/alpha/translate.c @@ -98,7 +98,11 @@ static TCGv cpu_pal_ir[31]; =20 static inline MemOp mo_endian(DisasContext *dc) { - return MO_TE; + /* + * Technically, Alpha can be run in big-endian mode, but we don't both= er. + * This was only ever used for the Cray T3[DE] machines. :-) + */ + return MO_LE; } =20 void alpha_translate_init(void) --=20 2.52.0 From nobody Mon Feb 9 01:50:39 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767715191; cv=none; d=zohomail.com; s=zohoarc; b=ax9RA7NqRmxD4BpCIwA7SI4LC4AKGjDOO8ISu3JEu6KXralAfNaVqp5g3HdmQxj4yXfZGVvRDrMUkTMA68HIBLsZSdfZZGSSeu/dc48yVqGzgq/2pKMmxjTE9xCTLAWZ8KgRLwTQWNvIYgu04zhqu2MOHqCDof3+TiGYnQ1aUEQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767715191; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=cU1qPLi7V3iHSoMptT16Z6RgGX5P/muNEJTKJG4e/8A=; b=eApuJ34gWWi6NJR4KcbM4YFRXdsuapj8wb8MVWvTzarCMXd6SEfliR0SeRSs8kI81kjewaY+rIKKAbQcV7FvHEwVkNxfRj4U9+C7W4LFVlYLuBgpKSAOBElN/uMdo97J9Hs8yNlrRD4rG3yoniwA2FGtL0v9A5b+j/qAjcsVMgk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767715191656796.8197692236126; Tue, 6 Jan 2026 07:59:51 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vd9SO-0004dJ-Jk; Tue, 06 Jan 2026 10:58:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vd9SM-0004KF-4N for qemu-devel@nongnu.org; Tue, 06 Jan 2026 10:58:50 -0500 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vd9SK-0006ka-IL for qemu-devel@nongnu.org; Tue, 06 Jan 2026 10:58:49 -0500 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-47d63594f7eso7053885e9.0 for ; Tue, 06 Jan 2026 07:58:48 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f653cd6sm53336535e9.9.2026.01.06.07.58.45 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 06 Jan 2026 07:58:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767715127; x=1768319927; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cU1qPLi7V3iHSoMptT16Z6RgGX5P/muNEJTKJG4e/8A=; b=TRgsH95oHXVNpORilXDzikfeqrpxlQxk0pOjEOv96uInqHo1XC7p1aT87uqI9plKUW H97TLpZor1aA96FpjW+PHcTlmADGtwth5PUtdb7COVJUBfok43/AXPEd9CkoEVorJ55Y iIONUm1eWGkUNa07G5nXCI/vYRAzPcsf8SifhNExjVKZIj+KsG/7blZEqK3nJBPsALDy a6bgdgchUtcREoNO7EcGthkmuZH12BlpOCeZRkx8gtueY+UsEACChNnOsuu0XDXo+Dil GVRjMitV9nuwLGZ8o5vZ4epUyY/sG9KpkvxkpQnA0nPIa1nLaufmF4JDHRtsgOLNQ/IG IL8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767715127; x=1768319927; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cU1qPLi7V3iHSoMptT16Z6RgGX5P/muNEJTKJG4e/8A=; b=SNKPxhWlX/SlHOqeG+xIbX+ZBlO1r684ejvcymNfcuY0Fi8mhKsWqMTSco4TgadkCa Y95UeCGtdZDrbUHi5qdCK6imundAbWdohsyUybx2mMnAMlsMQqeaSzt06+/+MlisdfDu bqkfnPkJdxdV4pzNpVkpGiklFTIlmRX52IyMtawx2GThopdnZF8NEpzG4bhcw7BtX/ix uWLqp/QB858eC3dpQ+bCaLuWOnEFn8l+gDXOohX6urZo1dBc3pEqMZHpXv1P40JgUUIr zH3CPZn18I/TSijB4xR62Fc1vHWfA6xZFlPsitWkeKUAoQlTl6HIMBDZIH1Uh+6jr6qD 4rMQ== X-Gm-Message-State: AOJu0YxB9WyskCU1xVtg66VwukFUQ5nS1uncG5oDWjpzs/gXnn2HtDMS wDgbQJoC/JRltrJx6P3mUXVnz4IxUwYnBfCKzdm4X4AC56MmPGXgtooRTAbtFA6zYd5H4G99BNB jhpNJzX4= X-Gm-Gg: AY/fxX6UP+OQT5Vffl2Lku1tWadieip6vj1fewlsIOHOUwJMFwPYgLV6cYyyObeGHjX qyWQQ0TDknK61tntWeDrvY3oDS5knmXlA6YVzX1KRuMBZNq4UYwVpevnac8pLp5BavL4F+xNiYi aDTvKmtAlrCDUseu3OJozOZRNTRjbjR4yDz3769yBLE0YyR5xe6gdiyj7YDUt3tKi9f+DPItAJB FGOY23R+ZUw9sXe+c3ovgb0cy0S8F++dVlMUI/JLa2ex486MxSq1rzdgQ2fg1jbQtgYjo054PiG fwwOHRDmwdNj0zDPHunixn/UTNye/K0e/pxWmu2ZM38MZlOqFjQfd+ujFvhaUxSGVnHwW+7xCiq jaAy6FaiFfKc9yvnVtN1jH2Z9JMPuojUXrp9Tu2hh9JTb1c/LDshVDYct/7C4hbyCiC2k4xjiQd U2ssAN+uIn53SP2itfksX7MnZFu6VJkTXoRYWkJwOGdakBD1ObVpHromXTZRht X-Google-Smtp-Source: AGHT+IF7JMm6yaYLqs/4cSNJSty6b08BDjfbBoAxO7agsYa9Rv7fmyt3oM1X9dA2BZ8DhM3THARl8Q== X-Received: by 2002:a05:600c:848a:b0:477:9dc1:b706 with SMTP id 5b1f17b1804b1-47d7f09c98bmr39800575e9.19.1767715126808; Tue, 06 Jan 2026 07:58:46 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Laurent Vivier , Richard Henderson , Pierrick Bouvier , Anton Johansson , Manos Pitsidianakis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 7/8] configs/targets: Forbid Alpha to use legacy native endianness APIs Date: Tue, 6 Jan 2026 16:57:53 +0100 Message-ID: <20260106155755.53646-8-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260106155755.53646-1-philmd@linaro.org> References: <20260106155755.53646-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767715193009158500 All Alpha-related binaries are buildable without a single use of the legacy "native endian" API. Unset the transitional TARGET_USE_LEGACY_NATIVE_ENDIAN_API definition to forbid further uses of the legacy API. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- configs/targets/alpha-linux-user.mak | 1 + configs/targets/alpha-softmmu.mak | 1 + 2 files changed, 2 insertions(+) diff --git a/configs/targets/alpha-linux-user.mak b/configs/targets/alpha-l= inux-user.mak index aa25766236e..ee505e16ef4 100644 --- a/configs/targets/alpha-linux-user.mak +++ b/configs/targets/alpha-linux-user.mak @@ -3,3 +3,4 @@ TARGET_SYSTBL_ABI=3Dcommon TARGET_SYSTBL=3Dsyscall.tbl TARGET_LONG_BITS=3D64 TARGET_XML_FILES=3D gdb-xml/alpha-core.xml +TARGET_NOT_USING_LEGACY_NATIVE_ENDIAN_API=3Dy diff --git a/configs/targets/alpha-softmmu.mak b/configs/targets/alpha-soft= mmu.mak index e31f059a52d..22fbbf0cb08 100644 --- a/configs/targets/alpha-softmmu.mak +++ b/configs/targets/alpha-softmmu.mak @@ -1,3 +1,4 @@ TARGET_ARCH=3Dalpha TARGET_LONG_BITS=3D64 TARGET_XML_FILES=3D gdb-xml/alpha-core.xml +TARGET_NOT_USING_LEGACY_NATIVE_ENDIAN_API=3Dy --=20 2.52.0 From nobody Mon Feb 9 01:50:39 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767715178; cv=none; d=zohomail.com; s=zohoarc; b=mez+WzZEtkHR8n+il+MQB2pn0zAq5mTdGmNahjWg0x5Soa391c25PDsLSrWOtdQpoEhaa4rCfrBvMZXlLEul3BJwNanTKP/kkKuP3S97VvxGv7JiAtdbH1Ubq6/DrCbiZXwM+bkoYzVm1LYqqvCSK8gY4XZMb3ssWUXiRYGzJOI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767715178; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=algqxa9leaG3RbyZjAx1RsJr8ynE3Caj6OBqSK2e0YI=; b=Cp7TrHIDz5uqZtBFEH0YvuKFiBVzFgloxGTxu7Bl6pOXYVywQsrDC/t0lUsRDUZb5hAgB1Y+kOnvma8ZyXXsVcBueAq8oUMVgfjiN4Gaq+hak22ZC9oU7xaUnZRAxg5a6A68mi8BvnhRj+GUnr/u9LkH9oj5VUtdAW79h3cKB80= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767715178882139.22641692119225; Tue, 6 Jan 2026 07:59:38 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vd9Sa-0004tH-Eb; Tue, 06 Jan 2026 10:59:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vd9SU-0004q2-Cx for qemu-devel@nongnu.org; Tue, 06 Jan 2026 10:59:00 -0500 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vd9SR-0006lK-Mf for qemu-devel@nongnu.org; Tue, 06 Jan 2026 10:58:57 -0500 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-47796a837c7so8628595e9.0 for ; Tue, 06 Jan 2026 07:58:55 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f70bc4fsm48481035e9.15.2026.01.06.07.58.52 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 06 Jan 2026 07:58:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767715134; x=1768319934; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=algqxa9leaG3RbyZjAx1RsJr8ynE3Caj6OBqSK2e0YI=; b=U06MNXDwaR0So55MLg8e0JAHitOP6X2rMIYcN39M2FAWALOBL0XzvWJg3tnXxFUxDk dzx+PrQHfLeDOIfG96Vr6hFDIKP2qJUU0sve6kyapaKNo1HS3+dCsPwjD5ikQ3W7XJar Q45wPS0/OkARyhSkEfq1LRUXuOm3+xrG8P7NwEeFQj0R1K5HJVo71F81jdm/yrvM6LrE ie+uCdRwSK4jFtxU9MOi4BIBwTTZ8ynQuTBugZdaIrUQHrmABQtr18MI7gyspSzY7MsN zqpUl9NNpib7BbHY4v7n4tDqNHlXmahX6gLmMff3OpKXwJaKlXRnvTad3AuV9g9ytx0p swmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767715134; x=1768319934; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=algqxa9leaG3RbyZjAx1RsJr8ynE3Caj6OBqSK2e0YI=; b=OE29pFfVsIsz7ffdoCK4C1A30o8VlPU5/qcuJJbMYxizLX9qOzsGGp9PjdPG7kCoyU 3NKRIeEHwbc4TgYqjzsEJGiPgbwZE2OE/hZtEkYQNFzBXr4X/4yZ09O413KDMWmxX70O iguHCCp20DXkIc9PDluNX/1RYE0dneLQxb6IGphVVmd1KVsPdX5bSu8Zi1Ad+TAxrKos nEDDpn5Ce4+G5O9W8tmjRa0QFBcQQflDV1dUBBr1mb+KYceFwAUUdCfURKtCD7GrXLOQ TPYRwY8J/l8mWs02QCs6+vfhL3q+uYQN24vPdLMDNeLDUwmdxFMg1MYAOkKUi2jdg1UX g57A== X-Gm-Message-State: AOJu0YxJ4x+QWBLhEmnmBojHalBwcZC1vQ1aNuQ6dTq/GQxOkdqh/ApV zjtP15ig8dhoXLlQNADwp8vq4oFh7sWAi/NuRZRaAwl3bc8TzjOvI1DwD6ucpxHjpEAVN0SaiVK QfEWT/pQ= X-Gm-Gg: AY/fxX5JRFPhCDOatGnWpuIofzU1lf/aZFrxklDn27oJNKVjKpI0iA5114RiTy4MPYy mFcy3qdaEL/dyuuoCx3tOsWRlwHMHk1JD9kkin1yKUyPnwVlwXqJpxtiybaKz2T53M2hds2SasO IiHEUyvw0bjMYaPLgnTcM7o4WWp10xrlwFhjJ6qLhgZZ0+DeSto/c81sI0m8i5++BO+/F8Fs87I qCIJ3Q6n3A4f4ox//VveGnvsl+/ywt2d31Ym/lyy43/ytRnThwlgB9ZuqM6pNwrixuf/U3OZIua L8VUnPgNBvUQARLXD0kIbYPnWJBnqwyIC0DhNjhGdNKme66sXV/FTPWLUiPqt1wiYe9RRW1v4aD eEZef8D4VexBjArGI80ofK7GgZ8B8cV9Ap3N3YPlWdHStBZtq2DKYmhUORz5CfYfcd5ZPcq7AkX 9GLpKJYaobRSov7NAAm6A+vuJERmieAGvwqbR9pkfDE3ubh5IXe08X2X84w2EK X-Google-Smtp-Source: AGHT+IEhL0jk9+1p/kjnE1cRg7NNF3HigWkiAapuOckZIaEvfnTVm0JjOYgCqr8ieIjoOpn3QRY8sA== X-Received: by 2002:a05:600c:46ca:b0:471:1716:11c4 with SMTP id 5b1f17b1804b1-47d837edcccmr11162205e9.34.1767715133727; Tue, 06 Jan 2026 07:58:53 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Laurent Vivier , Richard Henderson , Pierrick Bouvier , Anton Johansson , Manos Pitsidianakis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 8/8] target/alpha: Replace legacy ld_phys() -> address_space_ld() Date: Tue, 6 Jan 2026 16:57:54 +0100 Message-ID: <20260106155755.53646-9-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260106155755.53646-1-philmd@linaro.org> References: <20260106155755.53646-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767715181090158501 Prefer the address_space_ld/st API over the legacy ld_phys() because it allow checking for bus access fault. Since we removed the last legacy uses of the legacy ldst_phys() API, set the TARGET_NOT_USING_LEGACY_LDST_PHYS_API variable to hide the legacy API to alpha binaries, avoiding further API uses to creep in. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- configs/targets/alpha-linux-user.mak | 1 + configs/targets/alpha-softmmu.mak | 1 + target/alpha/helper.c | 29 ++++++++++++++++------------ 3 files changed, 19 insertions(+), 12 deletions(-) diff --git a/configs/targets/alpha-linux-user.mak b/configs/targets/alpha-l= inux-user.mak index ee505e16ef4..2f1312f0362 100644 --- a/configs/targets/alpha-linux-user.mak +++ b/configs/targets/alpha-linux-user.mak @@ -4,3 +4,4 @@ TARGET_SYSTBL=3Dsyscall.tbl TARGET_LONG_BITS=3D64 TARGET_XML_FILES=3D gdb-xml/alpha-core.xml TARGET_NOT_USING_LEGACY_NATIVE_ENDIAN_API=3Dy +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy diff --git a/configs/targets/alpha-softmmu.mak b/configs/targets/alpha-soft= mmu.mak index 22fbbf0cb08..5c6af0eafc1 100644 --- a/configs/targets/alpha-softmmu.mak +++ b/configs/targets/alpha-softmmu.mak @@ -2,3 +2,4 @@ TARGET_ARCH=3Dalpha TARGET_LONG_BITS=3D64 TARGET_XML_FILES=3D gdb-xml/alpha-core.xml TARGET_NOT_USING_LEGACY_NATIVE_ENDIAN_API=3Dy +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy diff --git a/target/alpha/helper.c b/target/alpha/helper.c index 80542cb0665..126a53c829b 100644 --- a/target/alpha/helper.c +++ b/target/alpha/helper.c @@ -169,6 +169,7 @@ static int get_physical_address(CPUAlphaState *env, tar= get_ulong addr, int prot_need, int mmu_idx, target_ulong *pphys, int *pprot) { + const MemTxAttrs attrs =3D MEMTXATTRS_UNSPECIFIED; CPUState *cs =3D env_cpu(env); target_long saddr =3D addr; target_ulong phys =3D 0; @@ -176,6 +177,7 @@ static int get_physical_address(CPUAlphaState *env, tar= get_ulong addr, target_ulong pt, index; int prot =3D 0; int ret =3D MM_K_ACV; + MemTxResult txres; =20 /* Handle physical accesses. */ if (mmu_idx =3D=3D MMU_PHYS_IDX) { @@ -214,18 +216,13 @@ static int get_physical_address(CPUAlphaState *env, t= arget_ulong addr, =20 pt =3D env->ptbr; =20 - /* - * TODO: rather than using ldq_phys_le() to read the page table we sho= uld - * use address_space_ldq() so that we can handle the case when - * the page table read gives a bus fault, rather than ignoring it. - * For the existing code the zero data that ldq_phys_le will return for - * an access to invalid memory will result in our treating the page - * table as invalid, which may even be the right behaviour. - */ - /* L1 page table read. */ index =3D (addr >> (TARGET_PAGE_BITS + 20)) & 0x3ff; - L1pte =3D ldq_phys_le(cs->as, pt + index * 8); + L1pte =3D address_space_ldq_le(cs->as, pt + index * 8, attrs, &txres); + if (txres !=3D MEMTX_OK) { + /* bus fault */ + goto exit; + } =20 if (unlikely((L1pte & PTE_VALID) =3D=3D 0)) { ret =3D MM_K_TNV; @@ -238,7 +235,11 @@ static int get_physical_address(CPUAlphaState *env, ta= rget_ulong addr, =20 /* L2 page table read. */ index =3D (addr >> (TARGET_PAGE_BITS + 10)) & 0x3ff; - L2pte =3D ldq_phys_le(cs->as, pt + index * 8); + L2pte =3D address_space_ldq_le(cs->as, pt + index * 8, attrs, &txres); + if (txres !=3D MEMTX_OK) { + /* bus fault */ + goto exit; + } =20 if (unlikely((L2pte & PTE_VALID) =3D=3D 0)) { ret =3D MM_K_TNV; @@ -251,7 +252,11 @@ static int get_physical_address(CPUAlphaState *env, ta= rget_ulong addr, =20 /* L3 page table read. */ index =3D (addr >> TARGET_PAGE_BITS) & 0x3ff; - L3pte =3D ldq_phys_le(cs->as, pt + index * 8); + L3pte =3D address_space_ldq_le(cs->as, pt + index * 8, attrs, &txres); + if (txres !=3D MEMTX_OK) { + /* bus fault */ + goto exit; + } =20 phys =3D L3pte >> 32 << TARGET_PAGE_BITS; if (unlikely((L3pte & PTE_VALID) =3D=3D 0)) { --=20 2.52.0