From nobody Mon Feb 9 04:15:14 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=me@linux.beauty; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=linux.beauty) ARC-Seal: i=2; a=rsa-sha256; t=1767688788; cv=pass; d=zohomail.com; s=zohoarc; b=nmtUvqslf+FQXrlr+PEOC6B5+9wGe6nlOia+UvhLxKTKZQ5UxOWe+zNPo+jHIgO+zJsfhPXlZLT1mBoL9RyrRuNB9mvuV4BPj7jGmztu+z2pS1JG45lezgBRRvy73PkjSXhNaRskCPhW7c+Et4mQn0ir/r8W7UUsF2Fj35lMfmU= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767688788; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=wQhER49pCJdH9RYGPala/E5TT2h5UjcEyJS5CiemJys=; b=T48lLheYAA42f+TBX1Vjy0IoAxiz/tWws5YcUr67ax+q4Qfi5EGOu7/pwFJUJ2OKZ0ZAUo/2QUHHszciO1EYzodRrr9F2WiD/K0UYp1fp4eJ4A9WvB45Z6oYwVFN6sDy/xtnNZgN5Wve/RUQhq9JwUJ8C83ZackDprueB2uO2Fc= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass header.i=me@linux.beauty; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=linux.beauty) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767688788668699.7541020415177; Tue, 6 Jan 2026 00:39:48 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vd2b2-0001tW-HE; Tue, 06 Jan 2026 03:39:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vd2az-0001tB-Ih for qemu-devel@nongnu.org; Tue, 06 Jan 2026 03:39:18 -0500 Received: from sender4-pp-f112.zoho.com ([136.143.188.112]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vd2ax-0007WO-1u for qemu-devel@nongnu.org; Tue, 06 Jan 2026 03:39:17 -0500 Received: by mx.zohomail.com with SMTPS id 1767688742583327.5420992961897; Tue, 6 Jan 2026 00:39:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1767688745; cv=none; d=zohomail.com; s=zohoarc; b=YkugCPi23U7F/YVRWYuqNfefwD4PdQAVz0tiWyDjDD6Yj4L38yXqS1sc16B8kFgYB84HTer1eRy95d6BqNunDOW5ni9yLCAuH3W/FCtVDYNJViNsBfl9ZU/SVqsQNTYBq0A1M9ZyaHSOI204DHD74Qhf1xZOfhUV881owLAbJBk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767688745; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=wQhER49pCJdH9RYGPala/E5TT2h5UjcEyJS5CiemJys=; b=NsDvcMKqt7qYPQhvQjYsYW7UwxUqVs123LnWsA/yvJEjO7axn2mW8QJjKbFJ/Au7uO+DSQZynfNmlueTgDTIRzNvmboCI/pKJa5e1XY7/RT07IwTxugBcRn0ThvgvT+Zx5VGM/DUcemjYRzhwHGKWpp3wOnDH7FrbtlOtUkTWCA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=linux.beauty; spf=pass smtp.mailfrom=me@linux.beauty; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1767688745; s=zmail; d=linux.beauty; i=me@linux.beauty; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To; bh=wQhER49pCJdH9RYGPala/E5TT2h5UjcEyJS5CiemJys=; b=FQOiX4pFKtXMk8nDI1IaVljn3agS8xa02YcfdJgH8phX8nnsFjtQvpej1j3ncW8P o/PmnDidlsneJGnhCLTlqktqJtdXX9qqQm6mG3UR2ZOmBdNf4JZaAI9TNA2bTDz1tGy gLKZl7XEzwE46Qyj5JESpOrXh8Yckif/T7e2vZ3g= From: Li Chen To: "Michael S . Tsirkin" Cc: qemu-devel@nongnu.org, Li Chen Subject: [PATCH] virtio-pmem: ignore empty queue notifications Date: Tue, 6 Jan 2026 16:38:59 +0800 Message-ID: <20260106083859.380338-1-me@linux.beauty> X-Mailer: git-send-email 2.52.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=136.143.188.112; envelope-from=me@linux.beauty; helo=sender4-pp-f112.zoho.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity me@linux.beauty) X-ZM-MESSAGEID: 1767688790269158500 Content-Type: text/plain; charset="utf-8" From: Li Chen virtio_pmem_flush() treats a NULL return from virtqueue_pop() as a fatal error and calls virtio_error(), which puts the device into NEEDS_RESET. However, virtqueue handlers can be invoked when no element is available, so an empty queue should be handled as a benign no-op. With a Linux guest this avoids spurious NEEDS_RESET and the resulting -EIO propagation (e.g. EXT4 journal abort and remount-ro). Signed-off-by: Li Chen Acked-by: Michael S. Tsirkin --- hw/virtio/virtio-pmem.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/virtio/virtio-pmem.c b/hw/virtio/virtio-pmem.c index 3416ea1827..cec1072f78 100644 --- a/hw/virtio/virtio-pmem.c +++ b/hw/virtio/virtio-pmem.c @@ -74,7 +74,6 @@ static void virtio_pmem_flush(VirtIODevice *vdev, VirtQue= ue *vq) trace_virtio_pmem_flush_request(); req_data =3D virtqueue_pop(vq, sizeof(VirtIODeviceRequest)); if (!req_data) { - virtio_error(vdev, "virtio-pmem missing request data"); return; } =20 --=20 2.52.0