From nobody Sat Feb 7 04:47:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1767634690; cv=none; d=zohomail.com; s=zohoarc; b=Acta2eZ0GaSjuBFvwf/xjhgLU48VbRCjzGmVzXdR0y9AAtXGzALsmKMHXIU2q0lovVbxitmCcunKAgOv+14sFYXkBbIPeCX/OyIIiYt3ovngmApWBXQ3572mGuFGvOhgvQLxWbJJRwkOeU3S4kNqdsdQE3eB/q9KLlL6Ihl6Ebo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767634690; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=yVvkNaI2l/ZmXnGkz9CF3gAqA68Cf3pw8mqAPS0l6kU=; b=Gk/71wTv+su8/fH0UY5qErckT8PV11Sqi3ao6JY917K1ezAZzoLnK/26gifkPUOmPYwcgNtbgqlVcLkZrsHPhTgiCKZ7SwwpSOpbW3qq/dkIvuJXEREQhXD0gt8UHk74sSVeCtwCz6ggfEaJx6hcsD8C+pVFnrnPlFCM9DVSIxc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767634690800425.5900218758327; Mon, 5 Jan 2026 09:38:10 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vcn3K-0005ZE-45; Mon, 05 Jan 2026 11:03:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vcn24-00051R-Bw; Mon, 05 Jan 2026 11:02:29 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vcn1w-0001Hp-Sy; Mon, 05 Jan 2026 11:02:10 -0500 Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 605DH6MC008176; Mon, 5 Jan 2026 16:01:52 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4betu601rm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Jan 2026 16:01:52 +0000 (GMT) Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 605FsTnm016064; Mon, 5 Jan 2026 16:01:51 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4betu601rd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Jan 2026 16:01:51 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 605EI42M005210; Mon, 5 Jan 2026 16:01:50 GMT Received: from smtprelay02.wdc07v.mail.ibm.com ([172.16.1.69]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4bfexjxm61-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Jan 2026 16:01:50 +0000 Received: from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com [10.39.53.230]) by smtprelay02.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 605G1non29360822 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 5 Jan 2026 16:01:49 GMT Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4D1185805A; Mon, 5 Jan 2026 16:01:49 +0000 (GMT) Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6E07858054; Mon, 5 Jan 2026 16:01:48 +0000 (GMT) Received: from gfwr532.rchland.ibm.com (unknown [9.10.239.133]) by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP; Mon, 5 Jan 2026 16:01:48 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=yVvkNaI2l/ZmXnGkz 9CF3gAqA68Cf3pw8mqAPS0l6kU=; b=gCxFBLsHhOsVAeopIfFui1+BLeQ5OdOxU Ac/hAwmf8XM2i8TCu/fwlHUokjUJeQ8wsN40iulYkSMkbMf/7Lq4NeRH0BoB6ty3 +k+05k1qtWOvmeo6gMMpGoWogFRmnFbygvjfAL0eg7yNq5EBfr+Aih4u18SJy442 f90qMkMAhufuNFsdrU7el56mGXDMQK83FXVuL+JiRZX9jRbxWNYRC3ekV7DCQHb7 dA3b3cBy0IQ4Rq0XR7c4LccoHDCeXm5OfNIfLx5MRHenBaheF7DSloIWjdB057is rsP+uK+p1IGusg0ZGHkHDDVdifl/DFcCuQGYNKYnXgF3eDwdwAUpw== From: Caleb Schlossin To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, npiggin@gmail.com, adityag@linux.ibm.com, milesg@linux.ibm.com, alistair@alistair23.me, chalapathi.v@linux.ibm.com, kowal@linux.ibm.com, angeloj@linux.ibm.com, harshpb@linux.ibm.com, calebs@linux.ibm.com Subject: [PATCH v4 1/7] hw/ppc: Add VMSTATE information for LPC model Date: Mon, 5 Jan 2026 10:01:32 -0600 Message-ID: <20260105160138.3242709-2-calebs@linux.ibm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260105160138.3242709-1-calebs@linux.ibm.com> References: <20260105160138.3242709-1-calebs@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=QbNrf8bv c=1 sm=1 tr=0 ts=695be070 cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=vUbySO9Y5rIA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VnNF1IyMAAAA:8 a=GMd5MdSob7TKo89JhDQA:9 X-Proofpoint-ORIG-GUID: KOSSMkX-f0ybNKqSIPYTNsBHL7DK3-qj X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA1MDEzOCBTYWx0ZWRfX7PPYuCQUCLri OWjVouHgeVVK4odLKlU1oEzhlZhqwWLuZLwWO2SmtG1q03sgAQzidt91lM0JUmCEncDBPwnfunQ p1XWXGtHF+vmKCxVnOEeDFq60DVtarXUVdkCqqD6UeP9ODcfC7y7yeh+3Sm/Qec8h8DovxcX4U1 7F7sUNqKOJbn/7BupcbuHx392Et3fDwbHoLOmBOAXvYzIJEODxjmqW+OfKLFwdGv2NFaZ68YCBl /NSoUarUxInM11UfqHa4hRwCaaXihW0k9HMLFUlzXzVFLZXxu0R8xhbJOR291FwzvrvXXZXMwU/ t66H1kFEfs2ewtXTo2JP5Vh27zD+/8ynN7QF5yqoc3Zu7F8A/KcBQHiJdnCxjliFgJESSD2N7Ag zKNgYWnxlwLota7YOqdrtOOTfPiAKb9uoPhOMJvk3B/lwq2w55L7rtbNzP4zkBODFWEdEoHNoEn +rQcWsXvKgGm7dU4Gwg== X-Proofpoint-GUID: S-VPBPZ9gqCVZM3gmGcTXHhApBa-SEds X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-05_01,2026-01-05_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 bulkscore=0 suspectscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2512120000 definitions=main-2601050138 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.156.1; envelope-from=calebs@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ibm.com) X-ZM-MESSAGEID: 1767634693051158500 Content-Type: text/plain; charset="utf-8" The PNV LPC model needs snapshot/migration support. Added a VMSTATE descriptor to save model data and an associated post_load() method. Snapshot support added for Power8, Power9, and Power10. Signed-off-by: Michael Kowal Reviewed-by: Michael Kowal Signed-off-by: Caleb Schlossin Reviewed-by: Aditya Gupta Reviewed-by: Chalapathi V --- hw/ppc/pnv_lpc.c | 41 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) diff --git a/hw/ppc/pnv_lpc.c b/hw/ppc/pnv_lpc.c index 3b65c12316..d1357dd359 100644 --- a/hw/ppc/pnv_lpc.c +++ b/hw/ppc/pnv_lpc.c @@ -30,6 +30,7 @@ #include "hw/ppc/pnv_lpc.h" #include "hw/ppc/pnv_xscom.h" #include "hw/ppc/fdt.h" +#include "migration/vmstate.h" =20 #include =20 @@ -696,6 +697,43 @@ static const MemoryRegionOps opb_master_ops =3D { }, }; =20 +static int vmstate_pnv_lpc_post_load(void *opaque, int version_id) +{ + PnvLpcController *lpc =3D PNV_LPC(opaque); + + memory_region_set_alias_offset(&lpc->opb_isa_fw, + lpc->lpc_hc_fw_seg_idsel * LPC_FW_OPB_S= IZE); + pnv_lpc_eval_serirq_routes(lpc); + + pnv_lpc_eval_irqs(lpc); + return 0; +} + +static const VMStateDescription vmstate_pnv_lpc =3D { + .name =3D TYPE_PNV_LPC, + .version_id =3D 1, + .minimum_version_id =3D 1, + .post_load =3D vmstate_pnv_lpc_post_load, + .fields =3D (const VMStateField[]) { + VMSTATE_UINT64(eccb_stat_reg, PnvLpcController), + VMSTATE_UINT32(eccb_data_reg, PnvLpcController), + VMSTATE_UINT32(opb_irq_route0, PnvLpcController), + VMSTATE_UINT32(opb_irq_route1, PnvLpcController), + VMSTATE_UINT32(opb_irq_stat, PnvLpcController), + VMSTATE_UINT32(opb_irq_mask, PnvLpcController), + VMSTATE_UINT32(opb_irq_pol, PnvLpcController), + VMSTATE_UINT32(opb_irq_input, PnvLpcController), + VMSTATE_UINT32(lpc_hc_irq_inputs, PnvLpcController), + VMSTATE_UINT32(lpc_hc_fw_seg_idsel, PnvLpcController), + VMSTATE_UINT32(lpc_hc_irqser_ctrl, PnvLpcController), + VMSTATE_UINT32(lpc_hc_irqmask, PnvLpcController), + VMSTATE_UINT32(lpc_hc_irqstat, PnvLpcController), + VMSTATE_UINT32(lpc_hc_error_addr, PnvLpcController), + VMSTATE_UINT32(lpc_hc_fw_rd_acc_size, PnvLpcController), + VMSTATE_END_OF_LIST() + } +}; + static void pnv_lpc_power8_realize(DeviceState *dev, Error **errp) { PnvLpcController *lpc =3D PNV_LPC(dev); @@ -721,6 +759,7 @@ static void pnv_lpc_power8_class_init(ObjectClass *klas= s, const void *data) PnvLpcClass *plc =3D PNV_LPC_CLASS(klass); =20 dc->desc =3D "PowerNV LPC Controller POWER8"; + dc->vmsd =3D &vmstate_pnv_lpc; =20 xdc->dt_xscom =3D pnv_lpc_dt_xscom; =20 @@ -766,6 +805,7 @@ static void pnv_lpc_power9_class_init(ObjectClass *klas= s, const void *data) PnvLpcClass *plc =3D PNV_LPC_CLASS(klass); =20 dc->desc =3D "PowerNV LPC Controller POWER9"; + dc->vmsd =3D &vmstate_pnv_lpc; =20 device_class_set_parent_realize(dc, pnv_lpc_power9_realize, &plc->parent_realize); @@ -782,6 +822,7 @@ static void pnv_lpc_power10_class_init(ObjectClass *kla= ss, const void *data) DeviceClass *dc =3D DEVICE_CLASS(klass); =20 dc->desc =3D "PowerNV LPC Controller POWER10"; + dc->vmsd =3D &vmstate_pnv_lpc; } =20 static const TypeInfo pnv_lpc_power10_info =3D { --=20 2.47.3 From nobody Sat Feb 7 04:47:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1767634715; cv=none; d=zohomail.com; s=zohoarc; b=E8yCeCYxAW95Ac7tn3SaJVXuXRPPelglAEqeooETeLT0NM+nCmovyGIna2qT41wP2zYQFRJ1oWA9uflWKDjaQTzS6maTl7STPD8Sf2L7SfGVWtZGpFDkA9AM6GOC8UMDE5YVl3G4W8tJcuy8U/qQTwxYpk9UvClB0/XLLB2URjg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767634715; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=P6UXoVjvsDkuwgnHdVavBdkRzuZbxGIl5ksQA7lT53Y=; b=loD3i7bBBrmkLBD8hhb2e6zLLookJqgGFE7lAHCJa+SDdqrzmRyrMYEa7cU0TbJNqdp22+d3x3IvnQkhYmHVKqblCrGogQ52RIAutPrQWz/MId/s2Hz5FjvGQ/TgjhIN8HSjC6IiSZ0ZTtCA0+kyd9CvR0Y79hKTtcoyzVh8644= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767634715066807.2837670592791; Mon, 5 Jan 2026 09:38:35 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vcn3K-0005ZS-7u; Mon, 05 Jan 2026 11:03:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vcn29-00052G-6d; Mon, 05 Jan 2026 11:02:31 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vcn22-0001Hx-Hn; Mon, 05 Jan 2026 11:02:13 -0500 Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 605DmNT0012556; Mon, 5 Jan 2026 16:01:54 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4betu601rx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Jan 2026 16:01:54 +0000 (GMT) Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 605G1rlm032411; Mon, 5 Jan 2026 16:01:53 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4betu601rq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Jan 2026 16:01:53 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 605EErbN014523; Mon, 5 Jan 2026 16:01:52 GMT Received: from smtprelay04.wdc07v.mail.ibm.com ([172.16.1.71]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4bfeempnnp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Jan 2026 16:01:52 +0000 Received: from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com [10.39.53.230]) by smtprelay04.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 605G1p9W58786206 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 5 Jan 2026 16:01:51 GMT Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 34A825805C; Mon, 5 Jan 2026 16:01:51 +0000 (GMT) Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 54F9F58054; Mon, 5 Jan 2026 16:01:50 +0000 (GMT) Received: from gfwr532.rchland.ibm.com (unknown [9.10.239.133]) by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP; Mon, 5 Jan 2026 16:01:50 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=P6UXoVjvsDkuwgnHd VavBdkRzuZbxGIl5ksQA7lT53Y=; b=MBHiLLTmn+NaAt0C0YT0q/ngzEEF3pXZP jMzHvSOg4BR1C9gaS/NHYdaxIDlIBs8d0X96ej14DNekgwIVHa39Qzn+hlJKFM47 336S/znwUByl5dTBUTskj90fqojTWekB2HPOFA9Ez5eLVHmYtvc3M97SaQEePI7B Y8ffz010sfXP5CEaBw2pczQZuoEQTRfRsD9UTgKi9+Ax+ciGTCgbBFQ7r+JQXsTt /flH+4Z5UeNFUeqdgo9TC4Las2hWyrIJkOSV/+gobmGWldI5H+PrkDq7L8UARm0z ZdR12I/49vVMmtPw2oTCn5kHmJmqw+2RbHAIOn9+/soMH0LdfQUZg== From: Caleb Schlossin To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, npiggin@gmail.com, adityag@linux.ibm.com, milesg@linux.ibm.com, alistair@alistair23.me, chalapathi.v@linux.ibm.com, kowal@linux.ibm.com, angeloj@linux.ibm.com, harshpb@linux.ibm.com, calebs@linux.ibm.com Subject: [PATCH v4 2/7] hw/ppc: Add pnv_spi vmstate support Date: Mon, 5 Jan 2026 10:01:33 -0600 Message-ID: <20260105160138.3242709-3-calebs@linux.ibm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260105160138.3242709-1-calebs@linux.ibm.com> References: <20260105160138.3242709-1-calebs@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=QbNrf8bv c=1 sm=1 tr=0 ts=695be072 cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=vUbySO9Y5rIA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VnNF1IyMAAAA:8 a=zPJzuvo3V7OF8ZkWVCkA:9 X-Proofpoint-ORIG-GUID: ciPb-7xuckwYJy2GYg_YvaeqbCN0_x1D X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA1MDEzOCBTYWx0ZWRfXwrfON48b95QT aC3D5jUkCQ5l4OChUoobe5sbOMsMwMDGqWOKfa9vnAgshwJyuBukEbnBKpSqjA0Z9EmtuE1uawz SURVpNkVXGqOf9gGG1fYMS2zFzX4z9OUuQv5j7Exx6OP74R7Uc2ao3jZd8VHl+dtV+QjMtGv7jT 1Exxfv6+IbVFvHO6MXlZb2OF/lyc76EHBW+u7GbaZU7dPPOOsRhK5DPAZqVP1LlRoP54k8s7vbX BvMMK8Y4dJRHT27OdQLnJBOvfxsHJgCKvPJY8lyoDb/hUBwmL8cseOwbueHoo1nhB97krW+jmjL eqGVSKB22dQsjEmm+Pol6wpoql5fkxbdcoFPV3uybRGwv5JZIO6qmYaxKMMVarPSUlu51NPmyA5 GND0JVvSv4sMlJpQkIMausexZWUU+J4ky0omQobtuwvvcVmodzESCHYrJbJjwnPn9jP0KQNm+iV 9qTtfYdXDtGmlRLJjZA== X-Proofpoint-GUID: vQZTk2MXKBjN7-cVNUFT4hSJvRQlWBJy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-05_01,2026-01-05_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 bulkscore=0 suspectscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2512120000 definitions=main-2601050138 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.156.1; envelope-from=calebs@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ibm.com) X-ZM-MESSAGEID: 1767634717400158500 Content-Type: text/plain; charset="utf-8" - Add support for needed PnvSpi structure variables Reviewed-by: Michael Kowal Signed-off-by: Caleb Schlossin Reviewed-by: Aditya Gupta Reviewed-by: Chalapathi V --- hw/ssi/pnv_spi.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/hw/ssi/pnv_spi.c b/hw/ssi/pnv_spi.c index 1cf3a4416d..76304d26fc 100644 --- a/hw/ssi/pnv_spi.c +++ b/hw/ssi/pnv_spi.c @@ -13,6 +13,7 @@ #include "hw/ssi/pnv_spi.h" #include "hw/ssi/pnv_spi_regs.h" #include "hw/ssi/ssi.h" +#include "migration/vmstate.h" #include #include "hw/core/irq.h" #include "trace.h" @@ -1199,6 +1200,31 @@ static int pnv_spi_dt_xscom(PnvXScomInterface *dev, = void *fdt, return 0; } =20 +static const VMStateDescription pnv_spi_vmstate =3D { + .name =3D TYPE_PNV_SPI, + .version_id =3D 1, + .fields =3D (const VMStateField[]) { + VMSTATE_UINT8(fail_count, PnvSpi), + VMSTATE_UINT8(transfer_len, PnvSpi), + VMSTATE_UINT8(responder_select, PnvSpi), + VMSTATE_BOOL(shift_n1_done, PnvSpi), + VMSTATE_UINT8(loop_counter_1, PnvSpi), + VMSTATE_UINT8(loop_counter_2, PnvSpi), + VMSTATE_UINT8(N1_bits, PnvSpi), + VMSTATE_UINT8(N2_bits, PnvSpi), + VMSTATE_UINT8(N1_bytes, PnvSpi), + VMSTATE_UINT8(N2_bytes, PnvSpi), + VMSTATE_UINT8(N1_tx, PnvSpi), + VMSTATE_UINT8(N2_tx, PnvSpi), + VMSTATE_UINT8(N1_rx, PnvSpi), + VMSTATE_UINT8(N2_rx, PnvSpi), + VMSTATE_UINT64_ARRAY(regs, PnvSpi, PNV_SPI_REGS), + VMSTATE_UINT8_ARRAY(seq_op, PnvSpi, PNV_SPI_REG_SIZE), + VMSTATE_UINT64(status, PnvSpi), + VMSTATE_END_OF_LIST(), + }, +}; + static void pnv_spi_class_init(ObjectClass *klass, const void *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); @@ -1209,6 +1235,7 @@ static void pnv_spi_class_init(ObjectClass *klass, co= nst void *data) dc->desc =3D "PowerNV SPI"; dc->realize =3D pnv_spi_realize; device_class_set_legacy_reset(dc, do_reset); + dc->vmsd =3D &pnv_spi_vmstate; device_class_set_props(dc, pnv_spi_properties); } =20 --=20 2.47.3 From nobody Sat Feb 7 04:47:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1767640361; cv=none; d=zohomail.com; s=zohoarc; b=JTsUTfM9S0A7Wck7q6PYgNRYMnNCA7KP/2bqETUJ0rGF5B+1lbQJ5rCppjuFjT/SK672biCTLNoRlSkCiYh0DVgpd8Y1DrNru8/QV/ZLNJB6Pulp724a8wW041NOxUKUzVRfXocf67rhhrK3+VHtgvHnc2Dadi25I6lVmsw4Hto= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767640361; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=hgzlkT4TGK48LI1xnxY+B7JxVUQD7CEwUUXrORbz1UY=; b=k1Kceqm9OE8ikp3JmcK0WxxOriht0Bs6ScuWE4pm3n9jokfYghowA7gInSq7lo73K2xXfjl8Zrra1S8feyqk+3EQvE7T9Ws7EbfZl0YG/vIyOG1yx9jV1qpzPKe8Ho2jR4k5ON8cGnRIhlGjIgWT2PqT2UG46maGfpRUPQVqXWI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767640361075970.3977096405806; Mon, 5 Jan 2026 11:12:41 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vcn2w-0005BM-Fv; Mon, 05 Jan 2026 11:03:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vcn22-00051I-Im; Mon, 05 Jan 2026 11:02:14 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vcn1w-0001IA-OR; Mon, 05 Jan 2026 11:02:08 -0500 Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 6058QT20022903; Mon, 5 Jan 2026 16:01:56 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4betm702n4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Jan 2026 16:01:55 +0000 (GMT) Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 605G1tSb012663; Mon, 5 Jan 2026 16:01:55 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4betm702n0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Jan 2026 16:01:55 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 605DmjG2023511; Mon, 5 Jan 2026 16:01:54 GMT Received: from smtprelay06.wdc07v.mail.ibm.com ([172.16.1.73]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4bg3rm39wp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Jan 2026 16:01:54 +0000 Received: from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com [10.39.53.230]) by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 605G1rMZ7078614 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 5 Jan 2026 16:01:53 GMT Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E71305805A; Mon, 5 Jan 2026 16:01:52 +0000 (GMT) Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 140E458054; Mon, 5 Jan 2026 16:01:52 +0000 (GMT) Received: from gfwr532.rchland.ibm.com (unknown [9.10.239.133]) by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP; Mon, 5 Jan 2026 16:01:51 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=hgzlkT4TGK48LI1xn xY+B7JxVUQD7CEwUUXrORbz1UY=; b=VU8Awk/i++1gtma16AxJBk2OZW3Dxlt3k czdqvuTzM+5+JqXGvYsdkoSMjpYlKHnRDD2V1I1z4yG7dykuBe0TglzMv9bMOyvf ycJUKsoSC7gErQKuEg87Ru6wSk/r/wpKPudTNSQxXKdb7d1CqLgxUxB2AQaCd5L4 ceikwZSyJ9Ujj6cK5OFR2qpk8XiA0kQIGlxdwmjbEVmgNf/b0QszA33E8nTTJn47 uBabOE9AO3sPWqKi3pMoCCsUPI/G6ukrlgBHUINx4wnWNoELmzJ8aAcKhTTYbxap dqQfWwsvyL5aIg3jVuwPIJSsiXh759i2wm1Yafu9NDkEB32Ive2+w== From: Caleb Schlossin To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, npiggin@gmail.com, adityag@linux.ibm.com, milesg@linux.ibm.com, alistair@alistair23.me, chalapathi.v@linux.ibm.com, kowal@linux.ibm.com, angeloj@linux.ibm.com, harshpb@linux.ibm.com, calebs@linux.ibm.com Subject: [PATCH v4 3/7] hw/ppc: Add pnv_i2c vmstate support Date: Mon, 5 Jan 2026 10:01:34 -0600 Message-ID: <20260105160138.3242709-4-calebs@linux.ibm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260105160138.3242709-1-calebs@linux.ibm.com> References: <20260105160138.3242709-1-calebs@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=OdmVzxTY c=1 sm=1 tr=0 ts=695be073 cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=vUbySO9Y5rIA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VnNF1IyMAAAA:8 a=DGM2Vrrcx73IGRt511UA:9 X-Proofpoint-GUID: OSnkJtiCsQMPvfhzBys2O1uEpO5Var9V X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA1MDEzOCBTYWx0ZWRfXyG46jCwkZFvi UKCQVRVvNbTRMtWIkhhId0odiYA6qy9PSbig87dVIezuUzmy4WBGJEb1EZ+uwk1cs5w43tm+6A/ upLVBB4RFTXTjFQtWYyIRDoEydvcLChGPqj1qCYLlPt3Ney7ILpUQmYrM+8Kts22CrM2aFuqySz QBntZXhuDb0ZSSfvNFD1w8tIVpU7bogO5e4yhXKqb8qDrkeJSHsRQcOhunNBsqWSLpmjUnFmpCf GOj0UZE6jlILW7jztfXvXhTx++r506qHvvS80Jdp2Hs7gU3TjQBqUdHunZyzNz3sjrbZe7CU4tg 4DxwHkvLRkaQiGXXBMnhWawrXmdGSyWnR2P4ExmeKfw8+AWiqNhenZs/FJgF9lSiT+iJGNt2CDV d0HIxCt8OotOtpaKY7zSsiqK4ArAdAi+tsY8Z2XDFhw64YrdBvGhZNBgb4X7CksErAEhwMaotAG ptCS0MkuqQz5IxAlnYg== X-Proofpoint-ORIG-GUID: 2d44hpNiy-utypJRcZdipYeYLedTXICT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-05_01,2026-01-05_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 phishscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2512120000 definitions=main-2601050138 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.156.1; envelope-from=calebs@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ibm.com) X-ZM-MESSAGEID: 1767640362076158500 Content-Type: text/plain; charset="utf-8" - Add vmstate support for i2c registers Reviewed-by: Michael Kowal Signed-off-by: Caleb Schlossin Reviewed-by: Aditya Gupta Reviewed-by: Chalapathi V --- hw/ppc/pnv_i2c.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/hw/ppc/pnv_i2c.c b/hw/ppc/pnv_i2c.c index c8e90c636f..60f7164a1c 100644 --- a/hw/ppc/pnv_i2c.c +++ b/hw/ppc/pnv_i2c.c @@ -19,6 +19,7 @@ #include "hw/ppc/pnv_i2c.h" #include "hw/ppc/pnv_xscom.h" #include "hw/ppc/fdt.h" +#include "migration/vmstate.h" =20 #include =20 @@ -549,6 +550,15 @@ static const Property pnv_i2c_properties[] =3D { DEFINE_PROP_UINT32("num-busses", PnvI2C, num_busses, 1), }; =20 +static const VMStateDescription pnv_i2c_vmstate =3D { + .name =3D TYPE_PNV_I2C, + .version_id =3D 1, + .fields =3D (const VMStateField[]) { + VMSTATE_UINT64_ARRAY(regs, PnvI2C, PNV_I2C_REGS), + VMSTATE_END_OF_LIST(), + }, +}; + static void pnv_i2c_class_init(ObjectClass *klass, const void *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); @@ -561,6 +571,7 @@ static void pnv_i2c_class_init(ObjectClass *klass, cons= t void *data) =20 dc->desc =3D "PowerNV I2C"; dc->realize =3D pnv_i2c_realize; + dc->vmsd =3D &pnv_i2c_vmstate; device_class_set_props(dc, pnv_i2c_properties); } =20 --=20 2.47.3 From nobody Sat Feb 7 04:47:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1767639391; cv=none; d=zohomail.com; s=zohoarc; b=RKw7RiIhWuoaSWKJ+YmmAnRCoFctwpLZEgJ6VIhpB39RU9LgQnj5VtXhdG0PgoVyr/Rv2D3JaRlgnrdXWSTEPSnDoMNqcDSMqdRpl1gT3pRD2TAEyhanVgOojo0o1DrzR/+AuNAzm3tga3GuJW2UrbDfQAoKGxYwKu1BsN1DDS8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767639391; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ASJBjbP7k6PqWeHdHwLii+dopCWg1KUoXzyMmz4LIYc=; b=gqKyKUqkZqU96IIz0rCiEwJ8PwCuJQemO2eA+VfiMtTW1SfnEnFCY7siiQerEi53WgsfvWowOJ9hu2NzlGeHIYzEB0BhQ9fDT3Uszl/sdk2LvAmm6W2XzmGwGcF0qTYOtkusiP79sJsYrRKGxzpvzC3rlYOvtJUnAxJbf6Mz9uM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17676393911996.3376104402963165; Mon, 5 Jan 2026 10:56:31 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vcn3P-0005eh-4d; Mon, 05 Jan 2026 11:03:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vcn24-00051Q-C3; Mon, 05 Jan 2026 11:02:29 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vcn1w-0001IT-Td; Mon, 05 Jan 2026 11:02:10 -0500 Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 605ESTiQ008531; Mon, 5 Jan 2026 16:01:58 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4betm702nd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Jan 2026 16:01:58 +0000 (GMT) Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 605G1voF012690; Mon, 5 Jan 2026 16:01:57 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4betm702n8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Jan 2026 16:01:57 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 605EU0sl005284; Mon, 5 Jan 2026 16:01:56 GMT Received: from smtprelay02.dal12v.mail.ibm.com ([172.16.1.4]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4bfexjxm76-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Jan 2026 16:01:56 +0000 Received: from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com [10.39.53.230]) by smtprelay02.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 605G1tTq1638976 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 5 Jan 2026 16:01:55 GMT Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 025A458054; Mon, 5 Jan 2026 16:01:55 +0000 (GMT) Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 236D35805D; Mon, 5 Jan 2026 16:01:54 +0000 (GMT) Received: from gfwr532.rchland.ibm.com (unknown [9.10.239.133]) by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP; Mon, 5 Jan 2026 16:01:54 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=ASJBjbP7k6PqWeHdH wLii+dopCWg1KUoXzyMmz4LIYc=; b=lpmoYWJcLo9YDndG1zIwdNmQiR5/iLL5P CjooIML4cCGQ+aRZULPqsQ7FIjQfdPuHpgmM8FEkuhDTaEM5+kqOHUj7PV7/qlDI 167H8eZBg7bbg8ydUvD1Rx5V8MQXwNiAYXf4hrT0IgV5rDlHjNrkVEpnIQpeKOAl TZ7yHPB0bycH6qVMjpgz3mN73CgK6cOfD/f50dVMidLJoGFG7HdeNKWhcHxNlCt7 0fTH5Mn8czK4YxGVUOY+c+Tpoiu59dAmHDu7iQkUpdh2WCWn+a5mTTSsfwkcrT2g xc5ltNnIHUyOPYHLbvltkqco6nqs+SQJzikFM6e1CG17/ba0t/02Q== From: Caleb Schlossin To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, npiggin@gmail.com, adityag@linux.ibm.com, milesg@linux.ibm.com, alistair@alistair23.me, chalapathi.v@linux.ibm.com, kowal@linux.ibm.com, angeloj@linux.ibm.com, harshpb@linux.ibm.com, calebs@linux.ibm.com Subject: [PATCH v4 4/7] hw/ppc: pnv_adu.c added vmstate support Date: Mon, 5 Jan 2026 10:01:35 -0600 Message-ID: <20260105160138.3242709-5-calebs@linux.ibm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260105160138.3242709-1-calebs@linux.ibm.com> References: <20260105160138.3242709-1-calebs@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=OdmVzxTY c=1 sm=1 tr=0 ts=695be076 cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=vUbySO9Y5rIA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VnNF1IyMAAAA:8 a=CZX88_KXqTBcai1-icQA:9 X-Proofpoint-GUID: dMs7jwXwdpR29-ZiH9036yxv38k7Qc50 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA1MDEzOCBTYWx0ZWRfX4LyBJku7Tlof p/Lgbl2pURGaR70pzLNQnuGHI4w0yaDbwwKuLxBveSNrYn+4ZcEXPoaeh7f4j2sz4rRs9PK+039 z5dhLyyzDsdOy5qDtXtupt4U3QoX/0M+wahA0hgEUG9tlPGflXTT4O8Gu/qUCMh0dgOIMxVUI9E Uqpj5hCjkiihSRWlVGF45x1ePykvdswYh1NMc8t8bXA2q7Wf1whYwpWk2/F1/gV2QyAZJ8Ejity xir+VFMoRp3zHHlRq9hhfqsAWnyQKT+/XkJegRrQ8IfxvlTyHthUPw/wBT9+zFh8VoTDAtdPQz/ uDUeB7H1fZ4CkJByKWS3rzlhRfXnZfgmkVJnE90+kE3R5121xoJmRmo61c8znPzS7J8ZHJA8nUK 2g7oZ8dTYu9mVKL8rEPsWPDAlYLrZ5wvWrGAftkrgH6MotINvBLIoKnmuLTvC+ZnwxsrhdeMxdr J7zx3dzcE1QaDC6ZEgw== X-Proofpoint-ORIG-GUID: 9qPYYiKQt3kP_KV9PBn21-DdSYvR3hmE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-05_01,2026-01-05_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 phishscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2512120000 definitions=main-2601050138 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.156.1; envelope-from=calebs@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ibm.com) X-ZM-MESSAGEID: 1767639393487158500 Content-Type: text/plain; charset="utf-8" - Added vmstate support for ADU model Signed-off-by: Angelo Jaramillo Reviewed-by: Michael Kowal Signed-off-by: Caleb Schlossin Reviewed-by: Aditya Gupta Reviewed-by: Chalapathi V --- hw/ppc/pnv_adu.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/hw/ppc/pnv_adu.c b/hw/ppc/pnv_adu.c index d686bfa62d..f921a7bcbf 100644 --- a/hw/ppc/pnv_adu.c +++ b/hw/ppc/pnv_adu.c @@ -23,6 +23,7 @@ #include "hw/ppc/pnv_chip.h" #include "hw/ppc/pnv_lpc.h" #include "hw/ppc/pnv_xscom.h" +#include "migration/vmstate.h" #include "trace.h" =20 #define ADU_LPC_BASE_REG 0x40 @@ -189,6 +190,16 @@ static const Property pnv_adu_properties[] =3D { DEFINE_PROP_LINK("lpc", PnvADU, lpc, TYPE_PNV_LPC, PnvLpcController *), }; =20 +static const VMStateDescription pnv_adu_vmstate =3D { + .name =3D TYPE_PNV_ADU, + .version_id =3D 1, + .fields =3D (const VMStateField[]) { + VMSTATE_UINT64(lpc_cmd_reg, PnvADU), + VMSTATE_UINT64(lpc_data_reg, PnvADU), + VMSTATE_END_OF_LIST(), + }, +}; + static void pnv_adu_class_init(ObjectClass *klass, const void *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); @@ -197,6 +208,7 @@ static void pnv_adu_class_init(ObjectClass *klass, cons= t void *data) dc->desc =3D "PowerNV ADU"; device_class_set_props(dc, pnv_adu_properties); dc->user_creatable =3D false; + dc->vmsd =3D &pnv_adu_vmstate; } =20 static const TypeInfo pnv_adu_type_info =3D { --=20 2.47.3 From nobody Sat Feb 7 04:47:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1767631040; cv=none; d=zohomail.com; s=zohoarc; b=PmUbHncteol0paThaCmOOnUH2rQdei6T0FkhpOrnDSJzgBM49I9Eoe/t+PpCx/HT3ZVeDCjOvOqZ8IZ6piM89cciLS+3iCblopV8pAHinhrChSoun7FtlTXlEoMfwPsA/4oEmFqPoF3OWQLr+oLWrOmd7NwQ6E/ugu+23fLFyaQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767631040; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=hR9Op/uk0vupq98tWhVjphviuJajcEYo5k/Jema+QAY=; b=SVj7vUZjq3op9t3rsT7BJJCnBxI5e5YTNxd916Z3AZv5Fx9pIjvW+72U6xC0gukpE6Z24hwC5ZJvnkUDdiTpp5SDSkak0a0EDOsm9bI1oDl+FgvNVnTrwmQTJslFhCrTNa9WeHboYmoPPL7ytftU4oboipUd5IDj3RUwtIauexw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767631040882787.615206420844; Mon, 5 Jan 2026 08:37:20 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vcn2x-0005DB-0M; Mon, 05 Jan 2026 11:03:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vcn29-00052H-6l; Mon, 05 Jan 2026 11:02:31 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vcn22-0001IW-I4; Mon, 05 Jan 2026 11:02:13 -0500 Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 605CgZIK001294; Mon, 5 Jan 2026 16:01:59 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4betrtfdba-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Jan 2026 16:01:59 +0000 (GMT) Received: from m0360072.ppops.net (m0360072.ppops.net [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 605G1wuP021213; Mon, 5 Jan 2026 16:01:59 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4betrtfdb7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Jan 2026 16:01:58 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 605ExDOU012572; Mon, 5 Jan 2026 16:01:58 GMT Received: from smtprelay03.dal12v.mail.ibm.com ([172.16.1.5]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4bffnj6ev7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Jan 2026 16:01:58 +0000 Received: from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com [10.39.53.230]) by smtprelay03.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 605G1uc455837100 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 5 Jan 2026 16:01:57 GMT Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D4DFE5805C; Mon, 5 Jan 2026 16:01:56 +0000 (GMT) Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F06B45805A; Mon, 5 Jan 2026 16:01:55 +0000 (GMT) Received: from gfwr532.rchland.ibm.com (unknown [9.10.239.133]) by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP; Mon, 5 Jan 2026 16:01:55 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=hR9Op/uk0vupq98tW hVjphviuJajcEYo5k/Jema+QAY=; b=C259mRjn9kX0AMOl4HFIozJIPQB0D3e7g ypAi+wN7oKbOGSikYKop46liSS4/Wagr8mMe0PUMP5xcFxFIHaGIygXeZopVdE9E T+EdiuDciLJ/efu1LgU+c0ZqxTglgNZ0VjavFEfVj/B0hQu5gB7bvFNa3lLVAOyM IHbgRNgoFpG0NdOQpUOBDxfYnM2yqT4TFeOq7TSxWR5VFdMXM90x7tNirRgQ35u+ ScgdS9uQqIOism/FhUceK5xeIsLvcFuEq32S0EIkgUxHPE+rb3SiZIu7ZzY8aYzX MlHSo+kaptxWnkkGiQGKDKDXIqGtysDUnlAfhruLuDOSFh6jftqHA== From: Caleb Schlossin To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, npiggin@gmail.com, adityag@linux.ibm.com, milesg@linux.ibm.com, alistair@alistair23.me, chalapathi.v@linux.ibm.com, kowal@linux.ibm.com, angeloj@linux.ibm.com, harshpb@linux.ibm.com, calebs@linux.ibm.com Subject: [PATCH v4 5/7] hw/ppc: pnv_core.c add vmstate support Date: Mon, 5 Jan 2026 10:01:36 -0600 Message-ID: <20260105160138.3242709-6-calebs@linux.ibm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260105160138.3242709-1-calebs@linux.ibm.com> References: <20260105160138.3242709-1-calebs@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=aaJsXBot c=1 sm=1 tr=0 ts=695be077 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=vUbySO9Y5rIA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VnNF1IyMAAAA:8 a=ijNBCCglf-f1jh5ZZN4A:9 X-Proofpoint-GUID: oAJbwRLgc7i6kIQuhZ_eBeC0RGh1KU1S X-Proofpoint-ORIG-GUID: snn2PLAr_xh0UksLzNcMti_Aju1gtCZK X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA1MDEzOCBTYWx0ZWRfXxjjO8fupe1l2 AwXZm6xZsNd2+gkHei3W5iuycwfTpIy7TiB70xci51ur/iaevK4hf5kihTA/rapAxKuZMdIpjcD 86N41pzu5/0Y9KfrcwrOvDXUfqCui3VwoSFE6IoNlztuxuldodUB+5+LwVqkv3PYafmFWeV9Adr zKP4NXsxq7IUwU+4Pt0ovhF7wXB+7SVmamPYYXEXI7AQC4uGShGaGT8HpPGLqZx0F9lch0WmoJV Jj3VmkSqviyEmNqNlon562SVUYQOjpsgq6GRvBjX50+i2PE7sYBti1vKgN+BMr2q7QRjuVid39u fG3E0LTgw/Du0v66486JVpi3zgQqekOIv7rW/CTprZrbgmgF4804YpxJXIlvhtH+6XzQIrOYBsQ rGBBk2elJeiZw8VegDwnF6fqt25C5vuLHC9kweCs8fcztwso2vxh0vTPEfgOsfP9ZHIL3h6Z3QA awOVx86NBG+9T25w1kA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-05_01,2026-01-05_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 clxscore=1015 phishscore=0 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2512120000 definitions=main-2601050138 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.158.5; envelope-from=calebs@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ibm.com) X-ZM-MESSAGEID: 1767631042355158500 Content-Type: text/plain; charset="utf-8" - Add vmstate support PnvCore and PnvQuad capturing scratch registers and special wakeup registers Signed-off-by: Angelo Jaramillo Reviewed-by: Glenn Miles Signed-off-by: Caleb Schlossin Reviewed-by: Aditya Gupta Reviewed-by: Chalapathi V --- hw/ppc/pnv_core.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/hw/ppc/pnv_core.c b/hw/ppc/pnv_core.c index 59a9eee597..8939515c2c 100644 --- a/hw/ppc/pnv_core.c +++ b/hw/ppc/pnv_core.c @@ -31,6 +31,7 @@ #include "hw/ppc/xics.h" #include "hw/core/qdev-properties.h" #include "helper_regs.h" +#include "migration/vmstate.h" =20 static const char *pnv_core_cpu_typename(PnvCore *pc) { @@ -478,6 +479,15 @@ static void pnv_core_power11_class_init(ObjectClass *o= c, const void *data) pnv_core_power10_class_init(oc, data); } =20 +static const VMStateDescription pnv_core_vmstate =3D { + .name =3D TYPE_PNV_CORE, + .version_id =3D 1, + .fields =3D (const VMStateField[]) { + VMSTATE_UINT64_ARRAY(scratch, PnvCore, 8), + VMSTATE_END_OF_LIST(), + }, +}; + static void pnv_core_class_init(ObjectClass *oc, const void *data) { DeviceClass *dc =3D DEVICE_CLASS(oc); @@ -486,6 +496,7 @@ static void pnv_core_class_init(ObjectClass *oc, const = void *data) dc->unrealize =3D pnv_core_unrealize; device_class_set_props(dc, pnv_core_properties); dc->user_creatable =3D false; + dc->vmsd =3D &pnv_core_vmstate; } =20 #define DEFINE_PNV_CORE_TYPE(family, cpu_model) \ @@ -737,12 +748,23 @@ static void pnv_quad_power11_class_init(ObjectClass *= oc, const void *data) pnv_quad_power10_class_init(oc, data); } =20 +static const VMStateDescription pnv_quad_vmstate =3D { + .name =3D TYPE_PNV_QUAD, + .version_id =3D 1, + .fields =3D (const VMStateField[]) { + VMSTATE_BOOL(special_wakeup_done, PnvQuad), + VMSTATE_BOOL_ARRAY(special_wakeup, PnvQuad, 4), + VMSTATE_END_OF_LIST(), + }, +}; + static void pnv_quad_class_init(ObjectClass *oc, const void *data) { DeviceClass *dc =3D DEVICE_CLASS(oc); =20 device_class_set_props(dc, pnv_quad_properties); dc->user_creatable =3D false; + dc->vmsd =3D &pnv_quad_vmstate; } =20 static const TypeInfo pnv_quad_infos[] =3D { --=20 2.47.3 From nobody Sat Feb 7 04:47:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1767632886; cv=none; d=zohomail.com; s=zohoarc; b=LWy7oTo67KvZtkhlgmoHPnMic7JJ+mhPWMZMM6xSIy6rVhcj16i2TwlUyiUYWaFQUUCJjv5Iz1ZzfVrRJRgiUoo2eUtDCMPLdaOxs0HOPT/xeYBZ68z7nKbaCK/eCoObTe9FsgrA/sohX4SGCuojnnDIwzeoIAHxW97rB8um0TE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767632886; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=hJ51RG39gGgoaCYgj0262/k/3ZkvDgSNgVSxBUs/jak=; b=HC+KeYoyPIP4AS2wxnSHZiVHbZbnCDUryNawYbB6rTLiF8sRQ23+59pEbLHqM+PTGI0BywGlyY0kHyJ+SLHcUgBw9uA+QaM5uNeVa+JmKPNhgA3kcxIeVBXs9oKbbYnuYAFD/bVXuY2MJ5LxtHa+yi1ciXFDddlp7Z2Gtf2eK70= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767632886334151.14736975540336; Mon, 5 Jan 2026 09:08:06 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vcn3R-0005fq-25; Mon, 05 Jan 2026 11:03:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vcn2A-00052J-1a; Mon, 05 Jan 2026 11:02:31 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vcn22-0001Ik-KK; Mon, 05 Jan 2026 11:02:13 -0500 Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 605CRs8l029415; Mon, 5 Jan 2026 16:02:01 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4besheqgyk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Jan 2026 16:02:01 +0000 (GMT) Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 605Fx7h3021785; Mon, 5 Jan 2026 16:02:00 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4besheqgyf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Jan 2026 16:02:00 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 605F1Dpr012536; Mon, 5 Jan 2026 16:01:59 GMT Received: from smtprelay05.dal12v.mail.ibm.com ([172.16.1.7]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4bffnj6evg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Jan 2026 16:01:59 +0000 Received: from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com [10.39.53.230]) by smtprelay05.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 605G1wqk49938922 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 5 Jan 2026 16:01:59 GMT Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B5EAF5805A; Mon, 5 Jan 2026 16:01:58 +0000 (GMT) Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D703058054; Mon, 5 Jan 2026 16:01:57 +0000 (GMT) Received: from gfwr532.rchland.ibm.com (unknown [9.10.239.133]) by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP; Mon, 5 Jan 2026 16:01:57 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=hJ51RG39gGgoaCYgj 0262/k/3ZkvDgSNgVSxBUs/jak=; b=nocWy1+WXtDrZiuIL3RPJ9KEXXcokJ/u+ 9wtE+aNLBVHWrutWHsDYfMXLDHEXfxZE11AoAYhYpi3BakLNR3CrftYVxlNr/GuV qDTrL76GX45c2Nw4bPEghSVixRWzCMkW6F3StwfA24swEQzEnjNGyCBZB5IAgN0a DBI55ZrI8sKrYrshSzf/yneeVp2h5rt8sq6CuZvR1BbKTXd6s9EsxJFlNZYB84OU 7xTKvrW/UsJPSqv4sjg0BcOV2pR7Qkrz3WyZ1F7iIaHZmF+TAUYUhg84+qQh502R C3D5Ddv6WbObzRWBBLs/67+GBb21Xsq9EmmXM6imxEodCVsvv0LwQ== From: Caleb Schlossin To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, npiggin@gmail.com, adityag@linux.ibm.com, milesg@linux.ibm.com, alistair@alistair23.me, chalapathi.v@linux.ibm.com, kowal@linux.ibm.com, angeloj@linux.ibm.com, harshpb@linux.ibm.com, calebs@linux.ibm.com Subject: [PATCH v4 6/7] hw/ppc: pnv_chiptod.c add vmstate support Date: Mon, 5 Jan 2026 10:01:37 -0600 Message-ID: <20260105160138.3242709-7-calebs@linux.ibm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260105160138.3242709-1-calebs@linux.ibm.com> References: <20260105160138.3242709-1-calebs@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA1MDEzOCBTYWx0ZWRfX7DDy6IxXDjWF eYyrTlnakCLHlyZ0+InEB9nVG9fEkzkdf054FUa7I0gnr2vRRfx/cnJk3BtEhg5putlqabUjcTm hjjQ42/u4YshT7+ei3O5yoeKYTimcnNB4xSOdhMj8iB29GSDAV5MIQ7y6mFie6n+/eR9Gi/Ukir Jhe1qYvKmJJxBgk743ANLCA0MspBqSCs7b7Do7/VYJQCbbtFsmgnF2h1KObGPP9lp9i25uE6jwY VGdzmxw4ubByRc6HokeSNMGLns4xkEdnls2iF3dNCw9ueqvlScFG4FRWRuTfIO6HZuQ9SmBKvaG 9GkKtod9ZFoZO8e7T8mRbaZf0vOSBJr6236Zp6/+958ZAcFX60lIqnc0r2I7YdPqQK+CgpOm3Yp Fr9G/yf2XiyqMujBUU39/hJA4QyNQlo7o3zaPezN14G1bRM99NKZnZHxOf05aWfgjEmRCu9SpoY erbQuT/N8Tq9EjVypuw== X-Proofpoint-GUID: LeggJpSJdxntsojQvL7lInPQa8Sq6Bhz X-Proofpoint-ORIG-GUID: aojQD99FGA4akIRzi3vYfwzPh7gjUelB X-Authority-Analysis: v=2.4 cv=AOkvhdoa c=1 sm=1 tr=0 ts=695be079 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=vUbySO9Y5rIA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VnNF1IyMAAAA:8 a=aOXUxLJ6JlOQ0ORGhkoA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-05_01,2026-01-05_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 adultscore=0 malwarescore=0 impostorscore=0 clxscore=1015 suspectscore=0 bulkscore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2512120000 definitions=main-2601050138 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.158.5; envelope-from=calebs@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ibm.com) X-ZM-MESSAGEID: 1767632887068158501 Content-Type: text/plain; charset="utf-8" - Added pre_save and post_load methods to handle slave_pc_target and tod_st= ate Signed-off-by: Angelo Jaramillo Reviewed-by: Michael Kowal Signed-off-by: Caleb Schlossin Reviewed-by: Aditya Gupta Reviewed-by: Chalapathi V --- hw/ppc/pnv_chiptod.c | 38 ++++++++++++++++++++++++++++++++++++ include/hw/ppc/pnv_chiptod.h | 2 ++ 2 files changed, 40 insertions(+) diff --git a/hw/ppc/pnv_chiptod.c b/hw/ppc/pnv_chiptod.c index 09a5a52ac7..bcf9b615a4 100644 --- a/hw/ppc/pnv_chiptod.c +++ b/hw/ppc/pnv_chiptod.c @@ -37,6 +37,7 @@ #include "hw/ppc/pnv_core.h" #include "hw/ppc/pnv_xscom.h" #include "hw/ppc/pnv_chiptod.h" +#include "migration/vmstate.h" #include "trace.h" =20 #include @@ -341,6 +342,8 @@ static void pnv_chiptod_xscom_write(void *opaque, hwadd= r addr, " TOD_TX_TTYPE_CTRL_REG val 0x%" PRIx64 " invalid slave address\n", val); } + /* Write slave_pc_target to a uint64_t variable for vmstate suppor= t. */ + chiptod->tx_ttype_ctrl =3D val; break; case TOD_ERROR_REG: chiptod->tod_error &=3D ~val; @@ -613,6 +616,40 @@ static void pnv_chiptod_unrealize(DeviceState *dev) qemu_unregister_reset(pnv_chiptod_reset, chiptod); } =20 +static int vmstate_pnv_chiptod_pre_save(void *opaque) +{ + PnvChipTOD *chiptod =3D PNV_CHIPTOD(opaque); + chiptod->tod_state_val =3D (uint8_t)chiptod->tod_state; + return 0; +} + +static int vmstate_pnv_chiptod_post_load(void *opaque) +{ + PnvChipTOD *chiptod =3D PNV_CHIPTOD(opaque); + if (chiptod->tx_ttype_ctrl !=3D 0) { + pnv_chiptod_xscom_write(chiptod, TOD_TX_TTYPE_CTRL_REG << 3, + chiptod->tx_ttype_ctrl, 8); + } + chiptod->tod_state =3D (enum tod_state)chiptod->tod_state_val; + return 0; +} + +static const VMStateDescription pnv_chiptod_vmstate =3D { + .name =3D TYPE_PNV_CHIPTOD, + .version_id =3D 1, + .pre_save =3D vmstate_pnv_chiptod_pre_save, + .pre_load =3D vmstate_pnv_chiptod_post_load, + .fields =3D (const VMStateField[]) { + VMSTATE_BOOL(primary, PnvChipTOD), + VMSTATE_BOOL(secondary, PnvChipTOD), + VMSTATE_UINT64(tod_error, PnvChipTOD), + VMSTATE_UINT64(pss_mss_ctrl_reg, PnvChipTOD), + VMSTATE_UINT64(tx_ttype_ctrl, PnvChipTOD), + VMSTATE_UINT8(tod_state_val, PnvChipTOD), + VMSTATE_END_OF_LIST(), + }, +}; + static void pnv_chiptod_class_init(ObjectClass *klass, const void *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); @@ -621,6 +658,7 @@ static void pnv_chiptod_class_init(ObjectClass *klass, = const void *data) dc->unrealize =3D pnv_chiptod_unrealize; dc->desc =3D "PowerNV ChipTOD Controller"; dc->user_creatable =3D false; + dc->vmsd =3D &pnv_chiptod_vmstate; } =20 static const TypeInfo pnv_chiptod_type_info =3D { diff --git a/include/hw/ppc/pnv_chiptod.h b/include/hw/ppc/pnv_chiptod.h index 466b06560a..3e5e3b02b2 100644 --- a/include/hw/ppc/pnv_chiptod.h +++ b/include/hw/ppc/pnv_chiptod.h @@ -41,6 +41,8 @@ struct PnvChipTOD { uint64_t tod_error; uint64_t pss_mss_ctrl_reg; PnvCore *slave_pc_target; + uint64_t tx_ttype_ctrl; + uint8_t tod_state_val; }; =20 struct PnvChipTODClass { --=20 2.47.3 From nobody Sat Feb 7 04:47:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1767637175; cv=none; d=zohomail.com; s=zohoarc; b=JNe4TqD8Wf9WolS0J2v8Zhqh6ErhJ7m2/K2m+EWGMlV2oGKdklbjpLJfb5CdjWSJgAFyiT1TYbdwF3C+66S+Ij5jPaBHnrDaL4BizP1MXQ/Oe8wqcsOHAOFfMLMXKhxhJMIQz+zMlNFxSQyl1x8LAXc2nVEmhvTi+pLiXVGeVVA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767637175; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=dTwAjVCkao+L39FcbVg2fbqRAyzRacYVBrRk6AFr7ac=; b=S/JrVuDi/j3LDKtgS2TsQpOzBGRnW7wPI7mqgbObLrQB+m7i9fe58NAQox/b6lm1S/e+PLyfNICyWGk4w/T4A972j3M8bDuEeWi3KtPZRmYNNOKe4BCsYVOQl+aiXyTp31TVBCsv76UF7zGScvKL7eEkVBMx6KwYbKZ9DAQ1NY0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767637175394139.1973987885708; Mon, 5 Jan 2026 10:19:35 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vcn3N-0005d7-At; Mon, 05 Jan 2026 11:03:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vcn2A-00052I-1i; Mon, 05 Jan 2026 11:02:31 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vcn22-0001J0-Iu; Mon, 05 Jan 2026 11:02:13 -0500 Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 605AKFRF028393; Mon, 5 Jan 2026 16:02:03 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4betrtfdbs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Jan 2026 16:02:03 +0000 (GMT) Received: from m0360072.ppops.net (m0360072.ppops.net [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 605G22oo021369; Mon, 5 Jan 2026 16:02:02 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4betrtfdbn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Jan 2026 16:02:02 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 605EJsg9005216; Mon, 5 Jan 2026 16:02:02 GMT Received: from smtprelay07.dal12v.mail.ibm.com ([172.16.1.9]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4bfexjxm7x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Jan 2026 16:02:02 +0000 Received: from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com [10.39.53.230]) by smtprelay07.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 605G20Le9306706 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 5 Jan 2026 16:02:00 GMT Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8772D58054; Mon, 5 Jan 2026 16:02:00 +0000 (GMT) Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A88AE5805D; Mon, 5 Jan 2026 16:01:59 +0000 (GMT) Received: from gfwr532.rchland.ibm.com (unknown [9.10.239.133]) by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP; Mon, 5 Jan 2026 16:01:59 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=dTwAjVCkao+L39Fcb Vg2fbqRAyzRacYVBrRk6AFr7ac=; b=K0BufWhMtO5wJYDvAUdK821x5Tb5X4UNK ek+Gf93cfE/s+qNZc3ReF8OjIpScfAIKLzhSrk1vK6ujXGG8WVID3+r5LyxKlqVw cwSkl+FvnsYq7o1CWUbKJ8T1skvLuoewRgy7P0xJAZLiTxWbORAr5YKGu2NVruED rOll9Q2cDZTaDckKL/kClAplkIa0ZNbfR40YyoPE6K0QAnmA2GWaKjUNHRie+a+K U7jsuctaqBsKfryofIiONWUDLaWPpeyEkc5J8aHzC9hU5KKXGnEEyxiveCIdP1/V YjUbNVfohzDhdKqrBUTTE2pK6jEZflRDp6SmAb6GFMutA/6yz5nNg== From: Caleb Schlossin To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, npiggin@gmail.com, adityag@linux.ibm.com, milesg@linux.ibm.com, alistair@alistair23.me, chalapathi.v@linux.ibm.com, kowal@linux.ibm.com, angeloj@linux.ibm.com, harshpb@linux.ibm.com, calebs@linux.ibm.com Subject: [PATCH v4 7/7] hw/ppc: Add VMSTATE information to PnvPsi Date: Mon, 5 Jan 2026 10:01:38 -0600 Message-ID: <20260105160138.3242709-8-calebs@linux.ibm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260105160138.3242709-1-calebs@linux.ibm.com> References: <20260105160138.3242709-1-calebs@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=aaJsXBot c=1 sm=1 tr=0 ts=695be07b cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=vUbySO9Y5rIA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VnNF1IyMAAAA:8 a=oruG57yO5g4gZiaFByIA:9 X-Proofpoint-GUID: 8r9n8DMYhPBtgFGTWI2hOlPoi0CqurzK X-Proofpoint-ORIG-GUID: Y_cMpYYQ6QSaJpAKI0f92GK82ljgK3oD X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA1MDEzOCBTYWx0ZWRfX1judwAC2+rSX dxqmUzjan6ADYNID4nIeBGlmbtAeCs+CGq/nuL/5/JPrJU3SeaAM3FYNUBc7FuZrAvTSXC6d1gv 9ZzskPorgH9UYgcsgppQGLn2j9YQOIegb6jk3rVrXwwGYytOtlpy91kat81OibjkAuAPWDsqodt McBSlrHmVHKotA5NsTguZK/1drFji2fOVNYzAq9NQDXzgw9ChXllcwLzap0iSI03hoVIr2nO92d p2MW7wWeamAXYABQMUfsw+GpOIko0pg6/Rhg2x91+lHIBfUZ8Btdwdzv1p71n+Ufn7zwLesnkSh TJ6D4vT5nIaQtG2mJldzOCcWVSfEHy02IATW6YwBkRerZakOPQcypo1tV0aNneMx7TnaysV7zWH qPru/jCijPTuZDkOQkQxKjXl8iclfgPZwMBfb22rMh1YnvmKfKxRl6WlxCyPCdYZkK1NjjKd9uj UveX+dXHP6QaeJgyQnQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-05_01,2026-01-05_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 clxscore=1015 phishscore=0 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2512120000 definitions=main-2601050138 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.158.5; envelope-from=calebs@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ibm.com) X-ZM-MESSAGEID: 1767637177073158500 Content-Type: text/plain; charset="utf-8" PnvPsi needs to be able to save/load snapshots. Add VMSTATE information to the device class and a post_load() method to restore dynamic data items = and memory region mappings. Signed-off-by: Michael Kowal Reviewed-by: Michael Kowal Signed-off-by: Caleb Schlossin Reviewed-by: Aditya Gupta Reviewed-by: Chalapathi V --- hw/ppc/pnv_psi.c | 36 ++++++++++++++++++++++++++++++++++-- 1 file changed, 34 insertions(+), 2 deletions(-) diff --git a/hw/ppc/pnv_psi.c b/hw/ppc/pnv_psi.c index 264568cdfb..e8701c6100 100644 --- a/hw/ppc/pnv_psi.c +++ b/hw/ppc/pnv_psi.c @@ -25,6 +25,7 @@ #include "qemu/module.h" #include "system/reset.h" #include "qapi/error.h" +#include "migration/vmstate.h" =20 =20 #include "hw/ppc/fdt.h" @@ -130,12 +131,11 @@ static void pnv_psi_set_bar(PnvPsi *psi, uint64_t bar) { PnvPsiClass *ppc =3D PNV_PSI_GET_CLASS(psi); MemoryRegion *sysmem =3D get_system_memory(); - uint64_t old =3D psi->regs[PSIHB_XSCOM_BAR]; =20 psi->regs[PSIHB_XSCOM_BAR] =3D bar & (ppc->bar_mask | PSIHB_BAR_EN); =20 /* Update MR, always remove it first */ - if (old & PSIHB_BAR_EN) { + if (memory_region_is_mapped(&psi->regs_mr)) { memory_region_del_subregion(sysmem, &psi->regs_mr); } =20 @@ -919,6 +919,37 @@ static const TypeInfo pnv_psi_power9_info =3D { }, }; =20 +static int vmstate_pnv_psi_post_load(void *opaque, int version_id) +{ + PnvPsi *psi =3D PNV_PSI(opaque); + Pnv9Psi *psi9 =3D PNV9_PSI(psi); + MemoryRegion *sysmem =3D get_system_memory(); + uint64_t esb_bar; + hwaddr esb_addr; + + /* Set the ESB MMIO mapping */ + esb_bar =3D psi->regs[PSIHB_REG(PSIHB9_ESB_CI_BASE)]; + + if (esb_bar & PSIHB9_ESB_CI_VALID) { + esb_addr =3D esb_bar & PSIHB9_ESB_CI_ADDR_MASK; + memory_region_add_subregion(sysmem, esb_addr, + &psi9->source.esb_mmio); + } + + return 0; +} + +static const VMStateDescription vmstate_pnv_psi =3D { + .name =3D TYPE_PNV_PSI, + .version_id =3D 1, + .minimum_version_id =3D 1, + .post_load =3D vmstate_pnv_psi_post_load, + .fields =3D (const VMStateField[]) { + VMSTATE_UINT64_ARRAY(regs, PnvPsi, PSIHB_XSCOM_MAX), + VMSTATE_END_OF_LIST() + } +}; + static void pnv_psi_power10_class_init(ObjectClass *klass, const void *dat= a) { DeviceClass *dc =3D DEVICE_CLASS(klass); @@ -926,6 +957,7 @@ static void pnv_psi_power10_class_init(ObjectClass *kla= ss, const void *data) static const char compat[] =3D "ibm,power10-psihb-x\0ibm,psihb-x"; =20 dc->desc =3D "PowerNV PSI Controller POWER10"; + dc->vmsd =3D &vmstate_pnv_psi; =20 ppc->xscom_pcba =3D PNV10_XSCOM_PSIHB_BASE; ppc->xscom_size =3D PNV10_XSCOM_PSIHB_SIZE; --=20 2.47.3