From nobody Sat Jan 3 12:33:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1767384884; cv=none; d=zohomail.com; s=zohoarc; b=DZ3Xh896O8ophUz3u1iV6Az5FBrYkbmA+xr2IzcOf2zKssfTOUgs89d7+I5Nr+pYBepkWgUYGbFdpQCaAFGkmoIoB33SJAttFEipjZRK/HHIzi64yuST8QU7Ybav9aKB+mA4IRiqQlM8voLcHJ56R7RQloaaCDbgCLx7sqV6Xsc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767384884; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=pKYjqfTXgQGZVxyGZkOxNio7I/520YSRrDNyn/er0eo=; b=Cpl5dpGOdpdw/CNEr8Z9RIIEelyQ5Z3eDz1P8GetKQ71+olEEtBXrxfSe32HzDRDVEW+BfJvmSCViUAEIP9m6FOFwnTNBwqj7IXiaJbb51A5UYCBdpg2YNd6ZcpoR7yQF4jS5rZxmo5LSZ0mpSXww6NxecidJnqLSxBytRwlUZk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767384884274355.7801405981502; Fri, 2 Jan 2026 12:14:44 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vblVy-000438-0y; Fri, 02 Jan 2026 15:12:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vblVj-0003vZ-04 for qemu-devel@nongnu.org; Fri, 02 Jan 2026 15:12:36 -0500 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vblVf-0002Tg-SG for qemu-devel@nongnu.org; Fri, 02 Jan 2026 15:12:34 -0500 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6029VxDY637501 for ; Fri, 2 Jan 2026 20:12:26 GMT Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bd3v8vn6s-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 02 Jan 2026 20:12:26 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c337375d953so8984025a12.3 for ; Fri, 02 Jan 2026 12:12:26 -0800 (PST) Received: from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b140c42e7esm1794621eec.22.2026.01.02.12.12.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jan 2026 12:12:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:content-type:date:from :in-reply-to:message-id:mime-version:references:subject:to; s= qcppdkim1; bh=pKYjqfTXgQGZVxyGZkOxNio7I/520YSRrDNyn/er0eo=; b=Ws hzK2Q37IFMHBnm2f5HD2NnDn4+zov9lmWnAWGaPPbaoQTc6CI1UIzGnKm3dnBj6F 2V8XNbvwOpROmkQ/N4FHu+pYJ87R2EiXOrDl+3NyuaYZw38F2qKoUMYCZtZWMORh KRw9jQqz2LjVmQ7geqn63DYUCHANOjlEP7+rOEWHnIRdv5STuumOPi9NCdDhektE C789slIqtkcoMZf8gvEjlTAgxjE+ugxygjk0oMiQ15XUEWN3+SJK993gyP9aXLc5 yVttprEEaFCQ+hv8WbaVXB+33GrlhxtYr8Si+625JIhJLbDquqNsn88F7YRiVOoz oDw9T73LG1q4QkQC3kmA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767384745; x=1767989545; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pKYjqfTXgQGZVxyGZkOxNio7I/520YSRrDNyn/er0eo=; b=f4rAhHrEHXN1LWLl+qCdfrW/Mv8d78hmcJw/3nQLe7YcjUZhrf+qWMLUvencTjomLt HnBotdenjiamMC/eqPitHw9UPyQyTpttHGmFRdBYLj+9ql7YO+oY+15M0UwhTlKhY5kS X+g4r8oPhFM3iV9dMnu4N+AxX1r8fhs04g3HMoPu4598W0den+AU15mb/1I7CRhY/rF5 a+v5R68AKzb2w/yG/35GyoVK4nuLtS5gba5j3v5jwZK88IOHqp+xLzW8fcPbUfjAQknz LabrzWJCMKAldPuRRo4vv6JhC3lULyuSvHlBjSJ2qd4ODWiuAzJK+o9ITBD4Gc/jsHDY aIGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767384745; x=1767989545; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pKYjqfTXgQGZVxyGZkOxNio7I/520YSRrDNyn/er0eo=; b=cietK6RCex8YRJ9TH1WBhBfS4jCTe4rPeBqK7AzZND6I8DLpHKVrkd7HDgzTcBEWgk 5Zg5TQCTbpBF93V0YjZyn66HtAHCEFGYsqYbacvHShMHShVjpka/DwTaPD46QxooPJDp eee7F6p5SuIBqZkOWboumNpGwaaHwcDKm+BcHrwUETetq9lCDl+mws2vIxYZU8NpTSzz kNBeS7n7LlEkSP2jIitZVKeBocMliBKULvRk9jSmd7HsyINtdEOXY/JblKoIhCZsyNyf veyCdep6YgSWpur+5Ho7Y/nBklla+hrX6b2SigNTNvhELDU1ZANrADcyeKRsNGLxOfSC NIfA== X-Gm-Message-State: AOJu0Yzt3Fi2eMjQvMMs3s0ML9a7pud/y2oPxphMjqzNAT9cSMrMXU9o cvmX/NeUgWRRUWNwWbk1XWMl5KF3m7pC0tV10jlLJ32s1ixM9BiTsEdIV0X0dlcw1UnprCkE+se iZsyIP7dR7nQOaR6sszmBJlaPpMGvSQ3q37srebwuhXywvdqQYFq1LQPdy71Y84B/VQ== X-Gm-Gg: AY/fxX4QO1Xa+8XcKoK1VcSmHJ7E40u7B0Sq8bjqeNS8FgjJQhLDa2c9f2F/m61fHVE D2922NHuWJpjCXp4M7ntQEUMXkONyx3f/Gq1kLXcbgaPcKAnYGmvUIiYgca8xHvrVTxHIT68mgq oQuLaPi0okv0wPIR/K3XAI/AVhs49gJNsfFKbAjpKDY1G/HB0abfnykyCR/Qaa2DKwgq4i5menD Bmy9zaBnrZWsHP0RKcEvWJeb0GX3wRukf68NTXaFqj85ykGe/iY0BBMiEDsfR4EwMfw/dmcmJfB Gdi6e7ciODInjivOEA5LysF/FYAhUpL6kyOImTj63dVU79KApocLiXIyxRVrknMy1osDj2ju5l/ 53VZ82M1yF/dv1AjhrkE+jYLGHNpYAM2xMw59JQFRaa5YWEwE4qVGzZIuXg== X-Received: by 2002:a05:7300:ea05:b0:2ae:6118:dbcc with SMTP id 5a478bee46e88-2b05ec04ad5mr25254544eec.11.1767384745259; Fri, 02 Jan 2026 12:12:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IEYYnQa32B1RYA40/uzc0gpSDuoRlxDMY9JZh1XTHdQHtqnRG1BPRKpgMKkDCQeE3okRFdizA== X-Received: by 2002:a05:7300:ea05:b0:2ae:6118:dbcc with SMTP id 5a478bee46e88-2b05ec04ad5mr25254530eec.11.1767384744672; Fri, 02 Jan 2026 12:12:24 -0800 (PST) From: Brian Cain To: qemu-devel@nongnu.org, richard.henderson@linaro.org Cc: brian.cain@oss.qualcomm.com, ltaylorsimpson@gmail.com, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alessandro Di Federico , Anton Johansson Subject: [PULL 7/9] Hexagon (target/hexagon) s/gen_log_pred_write/gen_pred_write Date: Fri, 2 Jan 2026 12:12:03 -0800 Message-Id: <20260102201205.2050363-8-brian.cain@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260102201205.2050363-1-brian.cain@oss.qualcomm.com> References: <20260102201205.2050363-1-brian.cain@oss.qualcomm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTAyMDE4MSBTYWx0ZWRfX7AX6WdDGFeC6 ybAh+TEAalgJN0kfvbu9rqYTRfAi6mTorrhrPIY1wvJKri7ork3PfZXypGQ3O0THvnR+3nOkaS1 DJprNWdb3ug3C96ityRo9M6Xt5eioP1vlN10pHwE0RV+Frl2VyhKLb2WEIiMKJBumH30cHO6vnc gpD9tTNaaZ1sqPrVxl/DMlbrJttobhcM5hCZKQy95yHh1VC6Y20gU3FRfjF44b3DhaLHy8+PnTl In8KnIhVSdT8FCjV3p8fdMv+BdBYkVHeU1BJF7UvTeNJHUeNcv1eAMXx5+iopbrOyclS1pZTpAJ qhP/lFZyrZxu5/Y69zVjcs8fZISa8EwiCFa1j9IWus7c4pIxOjDCRtrhq5NjX459AO9KrWVCtG6 x9IslMeeRhWT/Cg6hDq0VnwLaX4mStcDbE58zlD1l0sRabRA/SOmfDOChu9bTowy1ZyfTpmkDwr cRJSfREYu7SPXCxrYRg== X-Authority-Analysis: v=2.4 cv=JdOxbEKV c=1 sm=1 tr=0 ts=695826aa cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=pGLkceISAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=nbF6Ex3ZqfVUxDqS_3QA:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: wjA1R3ZAnCL_vkIdukbe6-5qCvij4HEx X-Proofpoint-ORIG-GUID: wjA1R3ZAnCL_vkIdukbe6-5qCvij4HEx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-02_03,2025-12-31_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 malwarescore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 adultscore=0 phishscore=0 clxscore=1015 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601020181 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=brian.cain@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1767384885117158500 Content-Type: text/plain; charset="utf-8" From: Taylor Simpson The function doesn't "log" anything, it just generates the write Signed-off-by: Taylor Simpson Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Brian Cain Signed-off-by: Brian Cain --- target/hexagon/gen_tcg.h | 4 ++-- target/hexagon/genptr.h | 2 +- target/hexagon/genptr.c | 14 +++++++------- target/hexagon/idef-parser/parser-helpers.c | 2 +- target/hexagon/hex_common.py | 4 ++-- 5 files changed, 13 insertions(+), 13 deletions(-) diff --git a/target/hexagon/gen_tcg.h b/target/hexagon/gen_tcg.h index 4895884fae..7b96dab918 100644 --- a/target/hexagon/gen_tcg.h +++ b/target/hexagon/gen_tcg.h @@ -599,7 +599,7 @@ TCGv p0 =3D tcg_temp_new(); \ gen_helper_cabacdecbin_pred(p0, RssV, RttV); \ gen_helper_cabacdecbin_val(RddV, RssV, RttV); \ - gen_log_pred_write(ctx, 0, p0); \ + gen_pred_write(ctx, 0, p0); \ } while (0) =20 /* @@ -914,7 +914,7 @@ do { \ TCGv p0 =3D tcg_temp_new(); \ gen_comparei(TCG_COND_EQ, p0, RsV, uiV); \ - gen_log_pred_write(ctx, 0, p0); \ + gen_pred_write(ctx, 0, p0); \ } while (0) =20 #define fGEN_TCG_J2_jump(SHORTCODE) \ diff --git a/target/hexagon/genptr.h b/target/hexagon/genptr.h index d932255042..228d7f1d7d 100644 --- a/target/hexagon/genptr.h +++ b/target/hexagon/genptr.h @@ -37,7 +37,7 @@ TCGv gen_read_reg(TCGv result, int num); TCGv gen_read_preg(TCGv pred, uint8_t num); TCGv get_result_gpr(DisasContext *ctx, int rnum); TCGv get_result_pred(DisasContext *ctx, int pnum); -void gen_log_pred_write(DisasContext *ctx, int pnum, TCGv val); +void gen_pred_write(DisasContext *ctx, int pnum, TCGv val); void gen_set_usr_field(DisasContext *ctx, int field, TCGv val); void gen_set_usr_fieldi(DisasContext *ctx, int field, int x); void gen_set_usr_field_if(DisasContext *ctx, int field, TCGv val); diff --git a/target/hexagon/genptr.c b/target/hexagon/genptr.c index d300f07f16..2534d96620 100644 --- a/target/hexagon/genptr.c +++ b/target/hexagon/genptr.c @@ -120,7 +120,7 @@ TCGv get_result_pred(DisasContext *ctx, int pnum) } } =20 -void gen_log_pred_write(DisasContext *ctx, int pnum, TCGv val) +void gen_pred_write(DisasContext *ctx, int pnum, TCGv val) { TCGv pred =3D get_result_pred(ctx, pnum); TCGv base_val =3D tcg_temp_new(); @@ -215,7 +215,7 @@ static void gen_write_p3_0(DisasContext *ctx, TCGv cont= rol_reg) TCGv hex_p8 =3D tcg_temp_new(); for (int i =3D 0; i < NUM_PREGS; i++) { tcg_gen_extract_tl(hex_p8, control_reg, i * 8, 8); - gen_log_pred_write(ctx, i, hex_p8); + gen_pred_write(ctx, i, hex_p8); } } =20 @@ -557,7 +557,7 @@ static void gen_ploopNsr(DisasContext *ctx, int N, TCGv= RsV, int riV) tcg_gen_mov_tl(get_result_gpr(ctx, HEX_REG_LC0), RsV); tcg_gen_movi_tl(get_result_gpr(ctx, HEX_REG_SA0), ctx->pkt->pc + riV); gen_set_usr_fieldi(ctx, USR_LPCFG, N); - gen_log_pred_write(ctx, 3, tcg_constant_tl(0)); + gen_pred_write(ctx, 3, tcg_constant_tl(0)); } =20 static void gen_ploopNsi(DisasContext *ctx, int N, int count, int riV) @@ -597,7 +597,7 @@ static void gen_cmpnd_cmp_jmp(DisasContext *ctx, if (ctx->insn->part1) { TCGv pred =3D tcg_temp_new(); gen_compare(cond1, pred, arg1, arg2); - gen_log_pred_write(ctx, pnum, pred); + gen_pred_write(ctx, pnum, pred); } else { TCGv pred =3D tcg_temp_new(); tcg_gen_mov_tl(pred, ctx->new_pred_value[pnum]); @@ -654,7 +654,7 @@ static void gen_cmpnd_tstbit0_jmp(DisasContext *ctx, TCGv pred =3D tcg_temp_new(); tcg_gen_andi_tl(pred, arg, 1); gen_8bitsof(pred, pred); - gen_log_pred_write(ctx, pnum, pred); + gen_pred_write(ctx, pnum, pred); } else { TCGv pred =3D tcg_temp_new(); tcg_gen_mov_tl(pred, ctx->new_pred_value[pnum]); @@ -834,7 +834,7 @@ static void gen_endloop0(DisasContext *ctx) TCGLabel *label1 =3D gen_new_label(); tcg_gen_brcondi_tl(TCG_COND_NE, lpcfg, 1, label1); { - gen_log_pred_write(ctx, 3, tcg_constant_tl(0xff)); + gen_pred_write(ctx, 3, tcg_constant_tl(0xff)); } gen_set_label(label1); =20 @@ -908,7 +908,7 @@ static void gen_endloop01(DisasContext *ctx) */ tcg_gen_brcondi_tl(TCG_COND_NE, lpcfg, 1, label1); { - gen_log_pred_write(ctx, 3, tcg_constant_tl(0xff)); + gen_pred_write(ctx, 3, tcg_constant_tl(0xff)); } gen_set_label(label1); =20 diff --git a/target/hexagon/idef-parser/parser-helpers.c b/target/hexagon/i= def-parser/parser-helpers.c index f5802ceadb..70bfa64432 100644 --- a/target/hexagon/idef-parser/parser-helpers.c +++ b/target/hexagon/idef-parser/parser-helpers.c @@ -1713,7 +1713,7 @@ void gen_pred_assign(Context *c, YYLTYPE *locp, HexVa= lue *left_pred, /* Extract first 8 bits, and store new predicate value */ OUT(c, locp, "tcg_gen_andi_i32(", left_pred, ", ", &r, ", 0xff);\n"); if (is_direct) { - OUT(c, locp, "gen_log_pred_write(ctx, ", pred_id, ", ", left_pred, + OUT(c, locp, "gen_pred_write(ctx, ", pred_id, ", ", left_pred, ");\n"); } } diff --git a/target/hexagon/hex_common.py b/target/hexagon/hex_common.py index 093def9386..1277fec9a2 100755 --- a/target/hexagon/hex_common.py +++ b/target/hexagon/hex_common.py @@ -571,7 +571,7 @@ def decl_tcg(self, f, tag, regno): """)) def log_write(self, f, tag): f.write(code_fmt(f"""\ - gen_log_pred_write(ctx, {self.reg_num}, {self.reg_tcg()}); + gen_pred_write(ctx, {self.reg_num}, {self.reg_tcg()}); """)) def analyze_write(self, f, tag, regno): f.write(code_fmt(f"""\ @@ -608,7 +608,7 @@ def decl_tcg(self, f, tag, regno): """)) def log_write(self, f, tag): f.write(code_fmt(f"""\ - gen_log_pred_write(ctx, {self.reg_num}, {self.reg_tcg()}); + gen_pred_write(ctx, {self.reg_num}, {self.reg_tcg()}); """)) def analyze_read(self, f, regno): f.write(code_fmt(f"""\ --=20 2.34.1