From nobody Thu Jan 8 15:12:59 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=jablonski.xyz ARC-Seal: i=1; a=rsa-sha256; t=1767216142; cv=none; d=zohomail.com; s=zohoarc; b=JKUWNhw59jOTShp4QnhqhjQIGrwOjrAjjD5vKgnLu2SJSdj4w0W60o3eDbn7l0Mcw5T+C7k1mf19zfpPlhML4i22PKEZdC9FShUY+a2/ufJ2ma1jljlf3Uw9CcrRzSAAfYHyS7sxp1n/45lKn7BdoGfVawamyZ7T1HwZukbXrZw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767216142; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=UJM3F3BQuLVendrDWJtrPOsf6gS3z8el+Rf/CxbEnE8=; b=Ef4Fb2QrNGlpnEh4QMMh53DyW7CBjBzvgN0q4xrAGG+oJ0/UK8MS6TlJ/IVZSe6wJg6/pZ1UGmw9/3Zjsp8sro7hD9C3tMTdum5C7ciVFrqWTtp6k+5e7KjXVdVhPaaaQdmGJYo+y+yx7RLKHiwnoRqqOfBOFUfvnOqSXzVfc4g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767216141936487.64436594936785; Wed, 31 Dec 2025 13:22:21 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vb3dN-0000pW-PK; Wed, 31 Dec 2025 16:21:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vb3dJ-0000oT-Pl for qemu-devel@nongnu.org; Wed, 31 Dec 2025 16:21:29 -0500 Received: from fhigh-a8-smtp.messagingengine.com ([103.168.172.159]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vb3dI-0003hz-2v for qemu-devel@nongnu.org; Wed, 31 Dec 2025 16:21:29 -0500 Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailfhigh.phl.internal (Postfix) with ESMTP id A63A31400046; Wed, 31 Dec 2025 16:21:27 -0500 (EST) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-02.internal (MEProxy); Wed, 31 Dec 2025 16:21:27 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 31 Dec 2025 16:21:27 -0500 (EST) Received: from localhost (chomposaur [local]) by chomposaur (OpenSMTPD) with ESMTPA id aa83430f; Wed, 31 Dec 2025 21:21:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jablonski.xyz; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1767216087; x= 1767302487; bh=UJM3F3BQuLVendrDWJtrPOsf6gS3z8el+Rf/CxbEnE8=; b=C EbglSYWQvBG1Va33ktSfnfLKndwTu0P5lFmNtFAG9+Ye8UPaMzfMP/4OSBi2Ycr1 u9R8rGbkoozaUOJcoP0LnzZcd8kxKVagvruqxsfJua7L3ZRQjY7Nx/rRe/fKW4f8 fqemBeY/BjseB7y8sqzvsDlnqHcrCG6Ei+wEcd6vIkVaqQuB+bHC4k7fPl2nAE0c UnPcYMcejnNFNG3PnFzfBKUtOQoGyhVzMn3Z9oDWleWC3MfZrXlXOpK/5Pi/GxeB IHvWmwePS+McioLBXLtCaCHGRqyGjZYJofhdx7Cb7aMUsRwBvyrUZeiKyx2l9+jP E76vpvkJYNWofrpM4SsFA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1767216087; x=1767302487; bh=U JM3F3BQuLVendrDWJtrPOsf6gS3z8el+Rf/CxbEnE8=; b=uDfROu74H9fmSV4B8 Bs13oApRUGh4ylyH8uoeBsKbn2pCBaqwAeZBY5hqXLZOFquktSHY5dBtiSZOCVAL GlZTjoswLkD+mfgBEcvKbX/RIW3jefhq34TyoujzHTyz5KsynHFfIvXy+U4OcUcU LnvvZH3001FTfWdqFAzGSLlOeuflZnP4UXovvisGOLHIrcW60LZydIkOg8jXFuaE Ki2qiv/BqoG5GnsynYK9ICVKK50SLzfgxMxD+q9B8NdqLXj/jD57AEF1/UcFlPWr Rx90u45WP7kr2DjljYsZGeHu+KMysv799Zqbd4kkFQKA9zPt4Rbf5KH87O+Tijby 8tJXw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdekfeeljecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecufghrlhcuvffnffculdejtddmnecujfgurhephffvvefuff fkofgjfhgggfestdekredtredttdenucfhrhhomhepvehhrgguucflrggslhhonhhskhhi uceotghhrggusehjrggslhhonhhskhhirdighiiiqeenucggtffrrghtthgvrhhnpefgie etjefhleehfeeiteejgfeljeffhfeuffdvudeijefgueeuuedvvdekjefhleenucevlhhu shhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegthhgrugesjhgrsg hlohhnshhkihdrgiihiidpnhgspghrtghpthhtohepfedpmhhouggvpehsmhhtphhouhht pdhrtghpthhtoheptghhrggusehjrggslhhonhhskhhirdighiiipdhrtghpthhtohepqh gvmhhuqdguvghvvghlsehnohhnghhnuhdrohhrghdprhgtphhtthhopegsrghlrghtohhn segvihhkrdgsmhgvrdhhuh X-ME-Proxy: Feedback-ID: ib26944c1:Fastmail From: Chad Jablonski To: qemu-devel@nongnu.org Cc: balaton@eik.bme.hu, Chad Jablonski Subject: [PATCH 3/7] ati-vga: Implement PM4_BUFFER_CNTL register Date: Wed, 31 Dec 2025 16:21:03 -0500 Message-ID: <20251231212107.1020964-4-chad@jablonski.xyz> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251231212107.1020964-1-chad@jablonski.xyz> References: <20251231212107.1020964-1-chad@jablonski.xyz> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=103.168.172.159; envelope-from=chad@jablonski.xyz; helo=fhigh-a8-smtp.messagingengine.com X-Spam_score_int: -2 X-Spam_score: -0.3 X-Spam_bar: / X-Spam_report: (-0.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.498, PDS_OTHER_BAD_TLD=1.997, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @jablonski.xyz) X-ZM-MESSAGEID: 1767216143887158500 Content-Type: text/plain; charset="utf-8" The PM4_BUFFER_CNTL register is used to set up the CCE FIFO. These are straightforward reads and writes. Future CCE patches make use of this state. Signed-off-by: Chad Jablonski --- hw/display/ati.c | 11 +++++++++++ hw/display/ati_cce.h | 4 ++++ hw/display/ati_regs.h | 12 ++++++++++++ 3 files changed, 27 insertions(+) diff --git a/hw/display/ati.c b/hw/display/ati.c index bac0ceaa79..f8e1fe2861 100644 --- a/hw/display/ati.c +++ b/hw/display/ati.c @@ -560,6 +560,11 @@ static uint64_t ati_mm_read(void *opaque, hwaddr addr,= unsigned int size) */ s->cce.microcode.raddr =3D s->cce.microcode.addr; break; + case PM4_BUFFER_CNTL: + val =3D ((s->cce.buffer_mode & 0xf) << 28) | + (s->cce.no_update << 27) | + (s->cce.buffer_size_l2qw & 0x7ffffff); + break; default: break; } @@ -1099,6 +1104,12 @@ void ati_reg_write(ATIVGAState *s, hwaddr addr, s->cce.microcode.addr +=3D 1; break; } + case PM4_BUFFER_CNTL: { + s->cce.buffer_size_l2qw =3D data & 0x7ffffff; + s->cce.no_update =3D (data >> 27) & 1; + s->cce.buffer_mode =3D (data >> 28) & 0xf; + break; + } default: break; } diff --git a/hw/display/ati_cce.h b/hw/display/ati_cce.h index f2ef1345de..25a2430c60 100644 --- a/hw/display/ati_cce.h +++ b/hw/display/ati_cce.h @@ -21,6 +21,10 @@ typedef struct ATIPM4MicrocodeState { =20 typedef struct ATICCEState { ATIPM4MicrocodeState microcode; + /* BufferCntl */ + uint32_t buffer_size_l2qw; + bool no_update; + uint8_t buffer_mode; } ATICCEState; =20 #endif /* ATI_CCE_H */ diff --git a/hw/display/ati_regs.h b/hw/display/ati_regs.h index 8f3335817f..94b7ed0d37 100644 --- a/hw/display/ati_regs.h +++ b/hw/display/ati_regs.h @@ -387,7 +387,19 @@ #define PC_BUSY 0x80000000 =20 #define BUS_MASTER_DIS 0x00000040 + + +/* PM4_BUFFER_CNTL buffer mode bit constants */ #define PM4_BUFFER_CNTL_NONPM4 0x00000000 +#define PM4_BUFFER_CNTL_192PIO 0x00000001 +#define PM4_BUFFER_CNTL_192BM 0x00000002 +#define PM4_BUFFER_CNTL_128PIO_64INDBM 0x00000003 +#define PM4_BUFFER_CNTL_128BM_64INDBM 0x00000004 +#define PM4_BUFFER_CNTL_64PIO_128INDBM 0x00000005 +#define PM4_BUFFER_CNTL_64BM_128INDBM 0x00000006 +#define PM4_BUFFER_CNTL_64PIO_64VCBM_64INDBM 0x00000007 +#define PM4_BUFFER_CNTL_64BM_64VCBM_64INDBM 0x00000008 +#define PM4_BUFFER_CNTL_64PIO_64VCPIO_64INPIO 0x0000000f =20 /* DP_DATATYPE bit constants */ #define DST_8BPP 0x00000002 --=20 2.51.2