From nobody Wed Jan 7 09:26:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767128943; cv=none; d=zohomail.com; s=zohoarc; b=PTwi7DVsex/S9OpaveCaIbCUvYXhV+FvIb0JW0jUFXneqmlhvJhlGQt5Rq++EDm4hwaS0wLoW+YxUYN79wbxvBq124CWLFbSAhF9GxkT8V6uq1Y0I3dvL2OnJPe5V2rPMPhTyWnk3+KQL1zgqSEKVlNfqdVnehiIPzzCQqKj7bM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767128943; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=GjeIlFrwrxliG9M3hGVWzNWmCSduRcXmwSt0xjJf9vA=; b=aaA1YgCXguvgjJoTUnpaIZDKmd3XE5Y4pDIt4b3ZKo34F4WoVEW0ZolsNawrVa20i3PsPmbnafdY8M07QSjGK7J2wCYC9lywgVYMSPlftaydgonMPUwnq/Hd7pUUnnfmKumqpKCkw+XIYnhnJ7Iru7sF8y2RtPjUEAlcpY1RB8g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767128943268929.0465817943912; Tue, 30 Dec 2025 13:09:03 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vagwt-0004VP-4H; Tue, 30 Dec 2025 16:08:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vagwr-0004Un-9z for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:08:09 -0500 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vagwp-0002BA-SU for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:08:09 -0500 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-4775ae77516so103339965e9.1 for ; Tue, 30 Dec 2025 13:08:07 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be3a204e9sm255956595e9.2.2025.12.30.13.08.05 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Dec 2025 13:08:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767128886; x=1767733686; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=GjeIlFrwrxliG9M3hGVWzNWmCSduRcXmwSt0xjJf9vA=; b=EGKK9uJon6d1bX5bd86umb8SNHmDo3E9auCWhPeun/4txHoDnL+GxnN97iKsqMAoNu Mod/ySSyT9JrBIJfBuFrvvE4LU0rdu2GHJMRygrcGVxdhvn7yiNeIUSFJkzS1u8UQZqu WD3bgA9vQLQlwjaih5aLVxTbzEom743gLKiybHNqZYkMePC5A0BS1RwCbXE748aLsFxm 0/HDFDmFYBa7J6ygtmTBWSC5r7KyB13n5NQxAkPUxw0mn00HHJCQ+cimecnemEJYk0TT 8JTone1jD0ZMmMo1WQ62C1Qa+Dw3z0vdyMWsZJbs/QSvDEArwh332qGBfcd+zwD2KTz9 klHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767128886; x=1767733686; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=GjeIlFrwrxliG9M3hGVWzNWmCSduRcXmwSt0xjJf9vA=; b=N6/ofET9UQuTVCXDZQQkNj5GBzjabu4CVDM+9B6/2zdfjU+TCyWXGlcc5piTYT+rb1 Am20q7lqwHq4D2ESGpfn31rTHeAJ3vGa1iiXJ5ILfMScBFVeGtlI73t0QOqlF5LE/e5N Tl9g5b/PrT2WuyGKG/0qrUgV237hJnSXebecoBcVV4pfooIECCmh1rqJZ8EOXaYcE/O8 BX6nVuYKEq8tzM+neqTbXRpTzUCJPguqmNfAR3bRE6AM2s1/KEbAVNE94jqbM538IEcr x9HrV4c7+ahyixAzSHp8NYMuGcqxKaQ6s5yzPoCFONwsLOXgfWxwa7zIi0pvja5Zl1tc uy5w== X-Gm-Message-State: AOJu0YxK3RWlWdzcNW/X9DxCjcxzQBJU+XFpzkaZtEEvWvvifiGmWd5H x3INNg8NkS0OQ3EZcODwC7oxZWgrN1KdkFF3VhdMuQzyi+tZYiH6Yp+ctViq/538u8OYxdhoArV k5bGDh6U= X-Gm-Gg: AY/fxX6A3PqftRRYPhk57hUuWkW8Y6Gxj+jUgRuM5mlhq/mbMP+8iGeFL16vu92gmBT KW2R4XIa4xy/+Bt1zwMYgk65eGofi4tzDBf9a5O5nmuLXGsEYGbgvpnrkwe5MEQyx+3G6/qyk0U y3qctHTJTEWw4XoTfPPAhzU5GZVXYBlI94G9vKCeDBC3EsrkPc5gPpHXh1FTd+/LGprSyZKnMPg gCsF2XQqFqbulVeftxYZW0b5mcMgPoOjdWzhkdkmUMXAnwmlNOyqoOdwTJS0nRSgk9uUbaF7TwP envhSGQffbS/eGQd/wHOP/3KILEzIc7pOPd5DICubPyoVIcBRSHPscNxA6iPFjhB0wDEK6ILKWj FL8mlmr+bOBK33g2+qYyGU3M7K9sEmfhWnokRQ42VbHLAO3LaYJxdUOeFZkjxnhY8nq3ifIY/dQ a1WZ5OOajScOrs/wDHn1xid0WtYAifXSTSN5OKGYX7lM983L9w3oLvx5lrXPE+vfNTdYLAlVw= X-Google-Smtp-Source: AGHT+IET+NQM4/QwkDzDB5otrGFvTdqyFWj2l7qfTFDOquFdsuBv87tQNVVuHsgKPt6UystMfTNcxA== X-Received: by 2002:a05:600c:19c6:b0:471:14f5:126f with SMTP id 5b1f17b1804b1-47d195c201bmr438915905e9.33.1767128885798; Tue, 30 Dec 2025 13:08:05 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 01/34] hw/sd: Remove unused header includes in ssi-sd.c Date: Tue, 30 Dec 2025 22:07:23 +0100 Message-ID: <20251230210757.13803-2-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251230210757.13803-1-philmd@linaro.org> References: <20251230210757.13803-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=philmd@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767128945160158500 From: Bin Meng Remove these header files which are not used by ssi-sd.c Signed-off-by: Bin Meng Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20251110104311.1640772-1-bmeng.cn@gmail.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/sd/ssi-sd.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/hw/sd/ssi-sd.c b/hw/sd/ssi-sd.c index c6e350af2dd..1782fb74316 100644 --- a/hw/sd/ssi-sd.c +++ b/hw/sd/ssi-sd.c @@ -16,14 +16,10 @@ */ =20 #include "qemu/osdep.h" -#include "system/blockdev.h" #include "hw/ssi/ssi.h" #include "migration/vmstate.h" -#include "hw/core/qdev-properties.h" #include "hw/sd/sd.h" -#include "qapi/error.h" #include "qemu/crc-ccitt.h" -#include "qemu/module.h" #include "qom/object.h" =20 //#define DEBUG_SSI_SD 1 --=20 2.52.0 From nobody Wed Jan 7 09:26:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767128946; cv=none; d=zohomail.com; s=zohoarc; b=K1anfRQwjfecgVx5Hd3E0WxVJkPMYhxsSEwApq784YLVRchOkKQ8cSalR1thxcjPS947ElRP3VkKrW9j8r3vFUM9NlZAZ1KluODhTufydFJ0SP2jjjQes5bRnoV+tqKF1Y4kVUQS3ocGpaITIwS2pJ5+TcySXpXpbSncnnuN7OQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767128946; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=SQymeuOhNMLqrAqX+KAFZo2+ziNig5pvD/1MSmnD9x4=; b=GOjNTZvXqY6Nzse7QwhmHTQHXefTMRXMCfY7ifJzl+FVg87hJJmZ9Y1YEo4bmuNp7kNbWd8EmdxskfRjDBfA9aTVHOEnGycihlmnq5gaD704PaBW+jGHXGhL1clsXn5X9/MvK/yvPVTly2j9RhiutKSvsTdp1g+TPro6JV+PviI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767128946428908.1846438940316; Tue, 30 Dec 2025 13:09:06 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vagwy-0004WY-Hy; Tue, 30 Dec 2025 16:08:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vagwx-0004WQ-RL for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:08:15 -0500 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vagww-0002C4-Db for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:08:15 -0500 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-430f3ef2d37so8176346f8f.3 for ; Tue, 30 Dec 2025 13:08:13 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eaa08d9sm70766179f8f.30.2025.12.30.13.08.11 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Dec 2025 13:08:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767128892; x=1767733692; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=SQymeuOhNMLqrAqX+KAFZo2+ziNig5pvD/1MSmnD9x4=; b=a3PFuDE2ixMGsTYqzPGUtJ6f7vXkTZHSO3yTLn1SfqURNij1umGhAIKUYuI0N2iFpQ LNE8ot+r3WWD6a1g4hXeg5/vOkXDp1fGIKwGdFQdQjYMm9IYI8xBbRRDMEtOMkpVa9yY p1pH60yBoikAM0ZlJbRIHlsmakqbx/k/kBQO3IvA0AepisjHKGo4qwlw4sAiW89yqpvg IrOOhZezWbjRzU97COUzSWQc4aSDuU8FNId2yj1ipkDNKc/niSrfAe7BskB+3w/nBnAg frCVYJYXH+MrfdStyNm7bbymPECFoMJGHPwfu8UMAS+Ca8QrU5j8oeQbl+wN0n5pyMny BRPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767128892; x=1767733692; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=SQymeuOhNMLqrAqX+KAFZo2+ziNig5pvD/1MSmnD9x4=; b=kaLRMY9xXV0wnpUjzFvRrkmvyM+fAfUUY1M7zfTjBCTio09COy9RQcrT8FUta7d8YC Y505NMxliuinKH8bRQWArl7BD/hoJmb+LIPXig0VDccoK+08LB0YnzTCjQJNHIs176YO sbJNWxfomtXoLmhkGc1bT6Ti2ldh2eiP+nqqjQGIiIWg4Re9+vVdyiY5zEy8wQSQLiia ucR1CA6b6oROei//nKjWQD+d1tnUSxUqdzCFf4RUxwcwga9LEM8bx4GSKdhqnRmEcxWk rqsWNGo7jT6GxBi2MYZo3utaj0IwejLr6VwGiNmfQ8g9akdXkJGoDEdzq858DhC7XskE RUJg== X-Gm-Message-State: AOJu0YyX6x6CESPdrYmmQx2AU14XJNEDnr9KKOi2xdt0UqD87qlrnKte uBhnXXnEtZy6BX9Zr7cxvIhQIj7jyvu741ki2JsAm80FpNKHL2bO2e1Fn6F6X5ZY+UkUWo+uiiJ 3gEiuIXo= X-Gm-Gg: AY/fxX6o4EYEK1IQnZZGJGoVvpScJqGv6fmHSHWoKH2zlH9M1xPGb2M1DuO6JTi30OH PU022D0DYloRwzO9ueph76LUm8wRiDwZdNB86xLyjEhoeCAJSo/4Rfy1ydC8huxCBTrTQ3PDMi3 lcfl6nF7uMG/NnLgL6APt5TdB2d5/t6FWj7spmopPVqHwvN4OutCzme782QeOtXEVAxiNtrEmSV N+vpwxFGb3/1t/3Dfvq4zbfCWOQjyxTrI+ESe8QXJ1nRWtPOBo2O7dwSLPa7cf7js5uKGJLYyKr Pqxg8cM1VL8GpE4bw22h3VPhOgfwGdRoyCx05+OcZfWFwAjU5Oqki6LQYmHM41a2rsL5zohj+8o 01waY6x0srkX8HspXhZAzd8G/25bDTW2DDnfnvR8K7D9qpejgq3jKH3b1EFJxRSvgZ/fm19NiKP Hhhvx0AjHfDWgMLR6WlrYSLl7uEKtqb+NGZqgequGvf+PH3pXeO6F4f3T2sEUcFvwrP30JKPY= X-Google-Smtp-Source: AGHT+IGhGaFy94KCgKuPi+ela8zv5XOLqBfNujPxQjHjhQaOgmW1g3L4z7FeZ9HDBxR+IA1HvhoeyQ== X-Received: by 2002:a5d:63d1:0:b0:432:58c8:b90e with SMTP id ffacd0b85a97d-43258c8bbbfmr34203982f8f.15.1767128892243; Tue, 30 Dec 2025 13:08:12 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 02/34] hw/core: remove duplicate include Date: Tue, 30 Dec 2025 22:07:24 +0100 Message-ID: <20251230210757.13803-3-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251230210757.13803-1-philmd@linaro.org> References: <20251230210757.13803-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=philmd@linaro.org; helo=mail-wr1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767128947225158501 From: Osama Abdelkader qemu/target-info.h is included twice. Signed-off-by: Osama Abdelkader Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20251126210832.34011-1-osama.abdelkader@gmail.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- system/vl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/system/vl.c b/system/vl.c index 2417f82c3ec..b60b8830509 100644 --- a/system/vl.c +++ b/system/vl.c @@ -41,7 +41,6 @@ #include "qemu/help_option.h" #include "qemu/hw-version.h" #include "qemu/uuid.h" -#include "qemu/target-info.h" #include "system/reset.h" #include "system/runstate.h" #include "system/runstate-action.h" --=20 2.52.0 From nobody Wed Jan 7 09:26:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767128963; cv=none; d=zohomail.com; s=zohoarc; b=glzLNbsdZpve7C/76CAnk7vCgP7WzSdQLBNOjDlWgGSmngD5+/oLMbbC7emIfVmEiuNEDZ0eQfuLNi/p2/e7xPqGEWSL7edusm8KlR3Cq7WLsDlWNbgMyVqkkAkci9ogDkDwzxBjPhG5zM1yfh0nJBzwk/DwktU34UmvSrcCunQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767128963; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=lzRXwIe1Jc8ddqbcAemZlDpnfBq+V4MD5nODk/G3BH4=; b=Qubzd70hTv4vt2Br/qjdJdYRyqNWIrB2cdJfx2xHjf4E1VpfEg0BSyjh3tACm0cfKUuUOEDNvJBOLvxAr5Nel7OrW+37QtRSUWmaEUiAbnS7zV8230ZOeJ5Y1iMWC1jdQISKEoi6JP/RvmKWjTVtIUnga8ee+6cZCujnnRrBGHk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767128963740232.1875049157643; Tue, 30 Dec 2025 13:09:23 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vagx6-0004Z1-HR; Tue, 30 Dec 2025 16:08:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vagx4-0004YR-HV for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:08:22 -0500 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vagx2-0002CV-Pi for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:08:22 -0500 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-43277900fb4so1809420f8f.1 for ; Tue, 30 Dec 2025 13:08:20 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea1af2bsm70137622f8f.1.2025.12.30.13.08.18 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Dec 2025 13:08:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767128899; x=1767733699; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=lzRXwIe1Jc8ddqbcAemZlDpnfBq+V4MD5nODk/G3BH4=; b=DaLd8VRUHHQtlYjjES4hB66egx9o/GsGpQrDC8HrCUXqlgLXzPNnkZghcRHQiDxm6n bQGD3a6gi4YgMisT2NoUCT0iRvTjmorhOKEwSabCqHQwXp/ZFDFi9RmXmlD5LodNmuE2 sMoN0XSf8XwUa8xBOAnHe/fNcWcOo8DaNCbzzOn3q46JG1DJ7M1pG04wVXv8TFzoJYmD hVQup3EWoUpCHF1p5DAKprsKBwyLTfgC7hZmE92IFfWRTREWn8dk3f2LOlJCE2o4e+gd RT7bk4ol1wMNadwLUG3j6tNOB06k0/lqlkVHfTT76CCX/Ck7r8MSWSnT6h8OfjXT+RG1 k8eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767128899; x=1767733699; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=lzRXwIe1Jc8ddqbcAemZlDpnfBq+V4MD5nODk/G3BH4=; b=ma3hOknKQnSTllDlVDLci2++9D8hb2vXiHz41Unhd2l5B3+9iwCGROwcWtI/KUcRda OunwrTQ2xu9aZy0jyJmCiPEzT+1UhmGHEsdyYZPS9GvtQk3RzHhpwbCAK71vx9Yzv8uD t/6eZfiN/nSMrLz0PVobDXvwaMTGveu+5bM/nQkYjrhUGTXsKmLCTYTpVNSqwkNc/E8Z MODOGiJwhUQ0u20jddzw2bYB1OQhoJ7sl92Ug8ewytQ5ZgMO2w+gFxZzL18b+cjg3fOj a07c4dOoGCKVzZ2F5jzwHi0dqjFD0Vf+RUBH/ZhSRUtatIKjN7ZFTAdU+oD10CNWZ2/b Mpwg== X-Gm-Message-State: AOJu0Yx1SAGrbCbO/QCGe2LSlX6WKUKf83g8t4Xaw0dGaCPOWHN89KyQ xQL/VfBTD6KMMLq1V5zdhUx+MgyjFG3AN10KIlXFusblRxeERQpKoTmU8KrIav2LKHuQwnjPZla Q8BDRKaU= X-Gm-Gg: AY/fxX4YNUczXZThSw0Ohi76em0h4QARG9Y9ENyb3tLVNwKEi65rkUyVXngHmYqhytu Roez2oQLwNG8TA8JF2+r3GNi1+WivjSkkBWit4Fco0/EI32Z/s5VaS8NPXFlJG/nIQ/R6E8fc2J IfcoQjbQ/vNLJqEpAJmAjATrAF6V0mtt4OeXlBmUR+kZdKCMhkYZR//odP4ulk9KeGxpbjGMg9b JLaYIhAEo+SAC4fOVTZbyEJpVOQMe20EiUpSJ+J/IBMqL6+cdmQWXDa8EpuDb7uc4KyR/tYieRN eM3pSQ6600yGzTZ/pyQX/mHEnt3E9hTiYYbqVMxaJK7IJRZU0xExa6hZGZyNI8k9BgVfAWxbBQd Thmdax/FZgaR79e0yGTLvGWszQukjZrrpunSgNMweF9FRur2gpQ4pEuVmkg9S+7KcjGacs7YmvG ZsSYmeVZCkrAWhOQQjpvdjPrOGzvZBbJPraUs1aA3JBD6KAFoA5rIqULPxAAP8 X-Google-Smtp-Source: AGHT+IEbx5oTGr66BMSxHkLtY0pp53PGAt32kN+7qD1+O64wUPZb/QSL9bPpjAi96EJxhd22sGdrNg== X-Received: by 2002:a5d:64e9:0:b0:431:382:f141 with SMTP id ffacd0b85a97d-4324e3f5da3mr53342152f8f.12.1767128898771; Tue, 30 Dec 2025 13:08:18 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 03/34] hw/riscv: Treat kernel_start_addr as vaddr Date: Tue, 30 Dec 2025 22:07:25 +0100 Message-ID: <20251230210757.13803-4-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251230210757.13803-1-philmd@linaro.org> References: <20251230210757.13803-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=philmd@linaro.org; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767128965256158500 From: Anton Johansson Changes kernel_start_addr from target_ulong to vaddr. Logically, the argument represents a virtual address at which to load the kernel image, which gets treated as a hwaddr as a fallback if elf and uimage loading fails. Suggested-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Anton Johansson Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20251210132130.14465-1-anjo@rev.ng> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/riscv/boot.h | 6 +++--- hw/riscv/boot.c | 6 +++--- hw/riscv/microchip_pfsoc.c | 3 ++- hw/riscv/sifive_u.c | 3 ++- hw/riscv/spike.c | 2 +- hw/riscv/virt.c | 3 ++- 6 files changed, 13 insertions(+), 10 deletions(-) diff --git a/include/hw/riscv/boot.h b/include/hw/riscv/boot.h index 35964bf8318..f00b3ca1224 100644 --- a/include/hw/riscv/boot.h +++ b/include/hw/riscv/boot.h @@ -43,8 +43,8 @@ bool riscv_is_32bit(RISCVHartArrayState *harts); char *riscv_plic_hart_config_string(int hart_count); =20 void riscv_boot_info_init(RISCVBootInfo *info, RISCVHartArrayState *harts); -hwaddr riscv_calc_kernel_start_addr(RISCVBootInfo *info, - hwaddr firmware_end_addr); +vaddr riscv_calc_kernel_start_addr(RISCVBootInfo *info, + hwaddr firmware_end_addr); hwaddr riscv_find_and_load_firmware(MachineState *machine, const char *default_machine_firmware, hwaddr *firmware_load_addr, @@ -57,7 +57,7 @@ hwaddr riscv_load_firmware(const char *firmware_filename, symbol_fn_t sym_cb); void riscv_load_kernel(MachineState *machine, RISCVBootInfo *info, - target_ulong kernel_start_addr, + vaddr kernel_start_addr, bool load_initrd, symbol_fn_t sym_cb); uint64_t riscv_compute_fdt_addr(hwaddr dram_base, hwaddr dram_size, diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c index df1f3abd171..e5490beda00 100644 --- a/hw/riscv/boot.c +++ b/hw/riscv/boot.c @@ -74,8 +74,8 @@ void riscv_boot_info_init(RISCVBootInfo *info, RISCVHartA= rrayState *harts) info->is_32bit =3D riscv_is_32bit(harts); } =20 -hwaddr riscv_calc_kernel_start_addr(RISCVBootInfo *info, - hwaddr firmware_end_addr) { +vaddr riscv_calc_kernel_start_addr(RISCVBootInfo *info, + hwaddr firmware_end_addr) { if (info->is_32bit) { return QEMU_ALIGN_UP(firmware_end_addr, 4 * MiB); } else { @@ -228,7 +228,7 @@ static void riscv_load_initrd(MachineState *machine, RI= SCVBootInfo *info) =20 void riscv_load_kernel(MachineState *machine, RISCVBootInfo *info, - target_ulong kernel_start_addr, + vaddr kernel_start_addr, bool load_initrd, symbol_fn_t sym_cb) { diff --git a/hw/riscv/microchip_pfsoc.c b/hw/riscv/microchip_pfsoc.c index 0cf849ffb6d..4ff83e49403 100644 --- a/hw/riscv/microchip_pfsoc.c +++ b/hw/riscv/microchip_pfsoc.c @@ -521,7 +521,8 @@ static void microchip_icicle_kit_machine_init(MachineSt= ate *machine) uint64_t mem_low_size, mem_high_size; hwaddr firmware_load_addr; const char *firmware_name; - hwaddr firmware_end_addr, kernel_start_addr; + hwaddr firmware_end_addr; + vaddr kernel_start_addr; uint64_t kernel_entry; uint64_t fdt_load_addr; DriveInfo *dinfo =3D drive_get(IF_SD, 0, 0); diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c index f1b47ab5848..7ec67b25651 100644 --- a/hw/riscv/sifive_u.c +++ b/hw/riscv/sifive_u.c @@ -515,7 +515,8 @@ static void sifive_u_machine_init(MachineState *machine) MemoryRegion *system_memory =3D get_system_memory(); MemoryRegion *flash0 =3D g_new(MemoryRegion, 1); hwaddr start_addr =3D memmap[SIFIVE_U_DEV_DRAM].base; - hwaddr firmware_end_addr, kernel_start_addr; + hwaddr firmware_end_addr; + vaddr kernel_start_addr; const char *firmware_name; uint32_t start_addr_hi32 =3D 0x00000000; uint32_t fdt_load_addr_hi32 =3D 0x00000000; diff --git a/hw/riscv/spike.c b/hw/riscv/spike.c index ea527c7bfc1..1493b928dad 100644 --- a/hw/riscv/spike.c +++ b/hw/riscv/spike.c @@ -199,7 +199,7 @@ static void spike_board_init(MachineState *machine) MemoryRegion *mask_rom =3D g_new(MemoryRegion, 1); hwaddr firmware_end_addr =3D memmap[SPIKE_DRAM].base; hwaddr firmware_load_addr =3D memmap[SPIKE_DRAM].base; - hwaddr kernel_start_addr; + vaddr kernel_start_addr; char *firmware_name; uint64_t fdt_load_addr; uint64_t kernel_entry; diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index c87c169d38c..bd8608ea5bf 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -1434,7 +1434,8 @@ static void virt_machine_done(Notifier *notifier, voi= d *data) machine_done); MachineState *machine =3D MACHINE(s); hwaddr start_addr =3D s->memmap[VIRT_DRAM].base; - hwaddr firmware_end_addr, kernel_start_addr; + hwaddr firmware_end_addr; + vaddr kernel_start_addr; const char *firmware_name =3D riscv_default_firmware_name(&s->soc[0]); uint64_t fdt_load_addr; uint64_t kernel_entry =3D 0; --=20 2.52.0 From nobody Wed Jan 7 09:26:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767128934; cv=none; d=zohomail.com; s=zohoarc; b=GI6E/ehuJrEk0Yloh7p0zYrheO3l03/Z9iAnBYbvPTZwy/0DX9gOQ0ybSOweZRylTo0ExECGTXL1X9ddZMO4BoqGXlJ20pfue4rbt0n8oikSgbVQYtd48BByh3EwN2zPy0oc5EGRSK3Ag9f7xNWdN8Fj0Yp4E9z92++QSuWdG+k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767128934; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=YEG6iZ6Aw3LQd9IRTTR+j/7S3SvDhMq9IcY5HHvReKc=; b=XuinVVDy9Vh0+PjzJpoPZ8RX//YmyRr2IhZfaf2PoVsY1kmKprlzZs7qNztvpms1olHBMtczWv6t08sehrb9352qhpRvO0OY+aNWwvo2PnnOLCGulm7sMALQxtrRx3K0XYFOBk1q0qtA6SaScGxqOBpwsWL2geTij7kgdsIVaj8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767128934036628.4412533531943; Tue, 30 Dec 2025 13:08:54 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vagxB-0004aq-Rm; Tue, 30 Dec 2025 16:08:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vagxA-0004Zz-U0 for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:08:28 -0500 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vagx9-0002Ej-5E for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:08:28 -0500 Received: by mail-wm1-x342.google.com with SMTP id 5b1f17b1804b1-47755de027eso61075955e9.0 for ; Tue, 30 Dec 2025 13:08:26 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d193621c8sm609207835e9.7.2025.12.30.13.08.24 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Dec 2025 13:08:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767128905; x=1767733705; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=YEG6iZ6Aw3LQd9IRTTR+j/7S3SvDhMq9IcY5HHvReKc=; b=YSgpjQfdNREyXxKHE7+4Yu75rG+BL+k0FG2zNVCnJ4X++dXRR5v+qNcb4ha8T896N4 hZRi2QZyX47emHwBw5JsUlALXHkJb9gyeYQYJI+Rb0j1Qc3iCBtO/+wyV/UdEsiSMtD3 7oYyhQhbXBSfjuewU1CT1SdNuTsCcw5a5li7LYk8Y9SYFm9958z66Bn/Bw82GnRnbYSR nMlbRSZmlT7db9ChnJY5tVUN82JPzDDjueSk+ygl1hFiy7FyePK9EnmW5v1eNTOuozSm VJ+svPx8tEKBfgiJbKOwq2/mh36OZwSBVrTlSgTY34A8mE/vfOJD0uSCuJAdwlMrV3Nc nYwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767128905; x=1767733705; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=YEG6iZ6Aw3LQd9IRTTR+j/7S3SvDhMq9IcY5HHvReKc=; b=A1SOV+GxA3re7XnFEAdHXwIOHWlIy1E9KeHaPOLLh7hXO2Rwn4OwwfBpQVYW3r3jOX ibrOMq13b4u6fQ2HIsmEzPAlwxRGZxcnmk+GD+lCHBECk0JC8b0GmzefRMaG1TKRvxTv LnhKbmCRkVDSBz1q9jDYUqF02zpnmO32czMngoPAIpY8Eo5tWRM8L7keBcJVOF+Z+1vy w1TT+E+df8KkQkYrRsDcDZeautajjrqZdi3dIPvtUqI1vDY7SU+BJJkgxdXZ0q5aAJL1 AtSN6L1cqrZKY36vW6Z5ZAGlwtEw7lhvmnEpsF2+LmK1GGSsWI8zjjgQ4L8/HxhpcWQm 6zEA== X-Gm-Message-State: AOJu0Yw9f4CU4ttoCk1k/aF80VgZTKXp1R5QjWUKguLpkfTO3lyPGlSX W+AQITZ/U3rFC0oQX5GMnaupvqjFS06nxbFN/UPLmtqovArQHZtu27KPHqnpf+8mz4vt351RjK3 3g/iaLk8= X-Gm-Gg: AY/fxX6dnN/Cf59q8d2iPgSusDYrCKjzAr/8sRdPJFWUuajaWzrFrQFcYaxMrE/v38c lMxzJ4oCSZTHtBBQmqspeBag5LDvVThOHm88+spOaN+jqEa226cfoB2odBC2yiusW7XZAkmBJai jzhaLtxeuoxpDGm7Z1Kzj3u7OA6lXcjlWE0bSEO7yjOJsocVJQMmdoil1B8s/I6+320Rn36qw6t KJ+mAWDIqZh6vh7Lqyn8hyMnxAaYs04XzU/iqH4mB/xf+6byCoWAsA/gPQkhASOtaytUpuA7gXM Ca+bSW54WwBE5DZV1VfdIotsuLJBFcKBsCgk5zOr7GDbTz4LXQA9PtEmm2z8IAZkOhAn/wrv94f b5S1nIITRArPjslvjUdEVsPvC5p9sa9RLpFc+b9MBxtsWbsPzcSZPTPpatFS62p5bBFBX+FiXri Y6jjKdCPcZhMiaDfLuWsLlwGN04X93iJMdDc1VP9vSmfsqJJDZY/QWVuZEGFav7DIhhJr50to= X-Google-Smtp-Source: AGHT+IEPHCNmtgG5XM11k8QqrbT6RoyvIC3v+e+8gRAeVchklO+RXBRHUNAmdK/7JgNQL8hDKQYT4Q== X-Received: by 2002:a05:600c:46ce:b0:477:8985:4036 with SMTP id 5b1f17b1804b1-47d1953bb1emr442489195e9.1.1767128905218; Tue, 30 Dec 2025 13:08:25 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 04/34] hw/misc: make the tz-ppc-port names more useful Date: Tue, 30 Dec 2025 22:07:26 +0100 Message-ID: <20251230210757.13803-5-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251230210757.13803-1-philmd@linaro.org> References: <20251230210757.13803-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::342; envelope-from=philmd@linaro.org; helo=mail-wm1-x342.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767128935500158500 From: Alex Benn=C3=A9e The TrustZone peripheral protection controller (tz-ppc) sits between peripherals and the main system. However this results in "info mtree" looking at bit confusing, especially as the sequence numbers can overlap and miss steps: 0000000000000000-ffffffffffffffff (prio -2, i/o): system 0000000000000000-00000000003fffff (prio 0, i/o): tz-mpc-upstream 0000000000400000-00000000007fffff (prio 0, i/o): alias ssram-0-alia= s @tz-mpc-upstream 0000000000000000-00000000003fffff 0000000028000000-00000000281fffff (prio 0, i/o): tz-mpc-upstream 0000000028200000-00000000283fffff (prio 0, i/o): tz-mpc-upstream 0000000040080000-0000000040080fff (prio 0, i/o): iotkit-secctl-ns-r= egs 0000000040100000-0000000040100fff (prio 0, i/o): tz-ppc-port[1] 0000000040101000-0000000040101fff (prio 0, i/o): tz-ppc-port[2] 0000000040102000-0000000040102fff (prio 0, i/o): tz-ppc-port[3] 0000000040103000-0000000040103fff (prio 0, i/o): tz-ppc-port[4] 0000000040110000-0000000040110fff (prio 0, i/o): tz-ppc-port[0] 0000000040111000-0000000040111fff (prio 0, i/o): tz-ppc-port[1] 0000000040112000-0000000040112fff (prio 0, i/o): tz-ppc-port[2] 0000000040113000-0000000040113fff (prio 0, i/o): tz-ppc-port[3] 0000000040200000-0000000040200fff (prio 0, i/o): tz-ppc-port[5] 0000000040201000-0000000040201fff (prio 0, i/o): tz-ppc-port[6] 0000000040202000-0000000040202fff (prio 0, i/o): tz-ppc-port[7] 0000000040203000-0000000040203fff (prio 0, i/o): tz-ppc-port[8] 0000000040204000-0000000040204fff (prio 0, i/o): tz-ppc-port[9] 0000000040205000-0000000040205fff (prio 0, i/o): tz-ppc-port[0] 0000000040206000-0000000040206fff (prio 0, i/o): tz-ppc-port[1] 0000000040207000-0000000040207fff (prio 0, i/o): tz-ppc-port[10] 0000000040208000-0000000040208fff (prio 0, i/o): tz-ppc-port[11] 0000000040209000-0000000040209fff (prio 0, i/o): tz-ppc-port[2] 000000004020a000-000000004020afff (prio 0, i/o): tz-ppc-port[3] 000000004020b000-000000004020bfff (prio 0, i/o): tz-ppc-port[4] 000000004020c000-000000004020cfff (prio 0, i/o): tz-ppc-port[12] 000000004020d000-000000004020dfff (prio 0, i/o): tz-ppc-port[13] 0000000040300000-0000000040300fff (prio 0, i/o): tz-ppc-port[0] 0000000040301000-0000000040301fff (prio 0, i/o): tz-ppc-port[1] 0000000040302000-0000000040302fff (prio 0, i/o): tz-ppc-port[2] 0000000041000000-000000004113ffff (prio 0, i/o): tz-ppc-port[0] 0000000042000000-00000000420000ff (prio 0, i/o): tz-ppc-port[5] 0000000048007000-0000000048007fff (prio -1000, i/o): FPGA NS PC 0000000050080000-0000000050080fff (prio 0, i/o): iotkit-secctl-s-re= gs 0000000058007000-0000000058007fff (prio 0, i/o): tz-ppc-port[0] 0000000058008000-0000000058008fff (prio 0, i/o): tz-ppc-port[1] 0000000058009000-0000000058009fff (prio 0, i/o): tz-ppc-port[2] 0000000080000000-0000000080ffffff (prio 0, ram): mps.ram So as a quality of life feature lets expose the name of the underlying region so we get something more useful: 0000000000000000-ffffffffffffffff (prio -2, i/o): system 0000000000000000-00000000003fffff (prio 0, i/o): tz-mpc-upstream 0000000000400000-00000000007fffff (prio 0, i/o): alias ssram-0-alias = @tz-mpc-upstream 0000000000000000-00000000003fffff 0000000028000000-00000000281fffff (prio 0, i/o): tz-mpc-upstream 0000000028200000-00000000283fffff (prio 0, i/o): tz-mpc-upstream 0000000040080000-0000000040080fff (prio 0, i/o): iotkit-secctl-ns-regs 0000000040100000-0000000040100fff (prio 0, i/o): tz-ppc-port[gpio0] 0000000040101000-0000000040101fff (prio 0, i/o): tz-ppc-port[gpio1] 0000000040102000-0000000040102fff (prio 0, i/o): tz-ppc-port[gpio2] 0000000040103000-0000000040103fff (prio 0, i/o): tz-ppc-port[gpio3] 0000000040110000-0000000040110fff (prio 0, i/o): tz-ppc-port[pl080] 0000000040111000-0000000040111fff (prio 0, i/o): tz-ppc-port[pl080] 0000000040112000-0000000040112fff (prio 0, i/o): tz-ppc-port[pl080] 0000000040113000-0000000040113fff (prio 0, i/o): tz-ppc-port[pl080] 0000000040200000-0000000040200fff (prio 0, i/o): tz-ppc-port[uart] 0000000040201000-0000000040201fff (prio 0, i/o): tz-ppc-port[uart] 0000000040202000-0000000040202fff (prio 0, i/o): tz-ppc-port[uart] 0000000040203000-0000000040203fff (prio 0, i/o): tz-ppc-port[uart] 0000000040204000-0000000040204fff (prio 0, i/o): tz-ppc-port[uart] 0000000040205000-0000000040205fff (prio 0, i/o): tz-ppc-port[pl022] 0000000040206000-0000000040206fff (prio 0, i/o): tz-ppc-port[pl022] 0000000040207000-0000000040207fff (prio 0, i/o): tz-ppc-port[arm_sbco= n_i2c] 0000000040208000-0000000040208fff (prio 0, i/o): tz-ppc-port[arm_sbco= n_i2c] 0000000040209000-0000000040209fff (prio 0, i/o): tz-ppc-port[pl022] 000000004020a000-000000004020afff (prio 0, i/o): tz-ppc-port[pl022] 000000004020b000-000000004020bfff (prio 0, i/o): tz-ppc-port[pl022] 000000004020c000-000000004020cfff (prio 0, i/o): tz-ppc-port[arm_sbco= n_i2c] 000000004020d000-000000004020dfff (prio 0, i/o): tz-ppc-port[arm_sbco= n_i2c] 0000000040300000-0000000040300fff (prio 0, i/o): tz-ppc-port[mps2-scc] 0000000040301000-0000000040301fff (prio 0, i/o): tz-ppc-port[i2s-audi= o] 0000000040302000-0000000040302fff (prio 0, i/o): tz-ppc-port[mps2-fpg= aio] 0000000041000000-000000004113ffff (prio 0, i/o): tz-ppc-port[gfx] 0000000042000000-00000000420000ff (prio 0, i/o): tz-ppc-port[lan9118-= mmio] 0000000048007000-0000000048007fff (prio -1000, i/o): FPGA NS PC 0000000050080000-0000000050080fff (prio 0, i/o): iotkit-secctl-s-regs 0000000058007000-0000000058007fff (prio 0, i/o): tz-ppc-port[tz-mpc-r= egs] 0000000058008000-0000000058008fff (prio 0, i/o): tz-ppc-port[tz-mpc-r= egs] 0000000058009000-0000000058009fff (prio 0, i/o): tz-ppc-port[tz-mpc-r= egs] 0000000080000000-0000000080ffffff (prio 0, ram): mps.ram Signed-off-by: Alex Benn=C3=A9e Cc: Jim MacArthur Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20251215170548.2594651-1-alex.bennee@linaro.org> [PMD: Wrap long line to avoid checkpatch.pl warning] Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/misc/tz-ppc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/misc/tz-ppc.c b/hw/misc/tz-ppc.c index 159073d1e6d..6f820430eed 100644 --- a/hw/misc/tz-ppc.c +++ b/hw/misc/tz-ppc.c @@ -273,8 +273,8 @@ static void tz_ppc_realize(DeviceState *dev, Error **er= rp) continue; } =20 - name =3D g_strdup_printf("tz-ppc-port[%d]", i); - + name =3D g_strdup_printf("tz-ppc-port[%s]", + memory_region_name(port->downstream)); port->ppc =3D s; address_space_init(&port->downstream_as, port->downstream, name); =20 --=20 2.52.0 From nobody Wed Jan 7 09:26:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767128991; cv=none; d=zohomail.com; s=zohoarc; b=fUQEVtQAINp3y7JM/kZJ7btdp9pwoReC6Wj0AI/++Q6ZzBTH4lDAr4xd5vf0BLuEruDa6IiIH+cpuuVzORRtFiCcL3vDfrzeSsrQ0oco30JnEYXNiF7UdXZdnRxL9uCC698pzgWDF2D4+PzuogCAxquN7gu5R7ASIBclgrpXu7U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767128991; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=ybCEBCayktp2Kdzo91lHKG/5ah0/ISp9PAz7gvS8NAw=; b=cpw1j+hEu8UXUocG1dKv2+TivXr3+y9DzwEzpMzUAt7E+GQSRq/GHEHpDWFI1oeFW41hEBicUHSFUl54R5KfD4xBkAXjAl96Wn9sWyESqyXhjgHJMIt2LY1fWkz4DZYBrwfXtyCMbgXPTH27xiKM/rMKUkWHXr46ZQ6xCGTlgnk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767128991119508.51201129025094; Tue, 30 Dec 2025 13:09:51 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vagxI-0004dt-8N; Tue, 30 Dec 2025 16:08:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vagxG-0004dG-NQ for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:08:34 -0500 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vagxF-0002F7-Ai for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:08:34 -0500 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-4327790c4e9so1826404f8f.2 for ; Tue, 30 Dec 2025 13:08:32 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea830fesm71316978f8f.20.2025.12.30.13.08.30 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Dec 2025 13:08:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767128911; x=1767733711; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=ybCEBCayktp2Kdzo91lHKG/5ah0/ISp9PAz7gvS8NAw=; b=g1InOQYasGuXmew7Yr8JuLiy/dcxLdFJtVSIAFgT+2E84Xbajo1bsfQ9Z0+w9sEBwI HNmSVz/poSQQWUFn0tQf76SAMmTntVmiYzAXHeXYRBlgn7eOA5JSB0AFUJArcSuxQWyf 7DzSIkavBHuGTt+GdAYdUdomkrwfNxCcCh90EHZZFoN3g4i7CvPO+rTCPIeYB8JKXiPX C3O7pxs32dji9TbccW0bERQANJ3Wz/oDGhBH0iiclhjRFxCsPfD797p8QiMb/L5gCseY SDDtqDON83/WDYnbdhH/D+W5wI8JjtLd/ogcVGjoR1Ktq2hISgrIp60Zs8NXtCrkAJF/ 0JQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767128911; x=1767733711; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ybCEBCayktp2Kdzo91lHKG/5ah0/ISp9PAz7gvS8NAw=; b=ijo7VPDyRKqL0f3w9WbnMoIGFmkkGBTNAGqq6sjkIJfm2A3uzMudN7BtYWICrM04in HllDs8MqzSJB4dQe4rEAb5/wflfEXplADnu9/3748ZJxISceftnTI7wJKOrUrXY52cA9 BP5wrEYqbgsfmXJCeVVU5hYOMWv6e6CTdbnddxcltQjnD6b9mCSwJMxU95hrqjEcjAGK 2xSdNUEPTMfAv2OanpS9FONP140Z17XhKihINtBLs/VfqD+0FcZMjufEDBeYy5KC7n+5 Ltw2XMig2JheQvTpXf6n5fGQGRVXoUgh6q/JeR3ZlEDs0ZWPM+kvta/U3xF61efm4rXN RVbw== X-Gm-Message-State: AOJu0Yy63Ow5pVplzCcofFGEXWxRW1su+71qkbFUdnd8qDeYKf10yMZt NcGGdBonBkm2+wWUODLGDfTduMTL2FsJicUWfTHxpriPQzPVcYgBuS4ZOaFpKTDJEYxcHOg0FOd KnFSeyro= X-Gm-Gg: AY/fxX6LQqYll9w+LIoErwNnJ77W9vCOx1DEkP2DONT4Llic804N8iJR/qSYaHUKhoh O4bNCVSLDWcg6RpoUceX9hcmMEoXWRSaQyjR2vBwg+KKHNNJyMs0LYPeFXVmM9q2qXAZkE4JgOS CtLc2MbTgezrsVhxdVAbaGRj7kA+W9anIJn+H0HLEvhlRgKvknR9ftAujC3LoxX6NpQO/WedPj6 1D8hyd2hIIIbSZGuPuG3HGkNtsjN79LnIoc6TbcR/hteX59D2W8DyZe/ecJXUyUocMtaHJOEI21 3WwQc32AeZTpj2z6Fg+tl8cr65ISjrb6cCyvhO+r5eq/H7BTHtzGcZj/eYtajm0cunVO5DkXBlP EiSqWzXIOFuobH5txM7qR0lvE8cZhK3uaXuAB7AuGl+5aH7J7b5TiVLHIzFmSmbtiZ+NxWldXew v9lvXMtI1vX6dCbeOZ0p8iNuDiv6ND+WeZqzdnClZinCjLAtJ6cgF7eTgVScOg X-Google-Smtp-Source: AGHT+IHRCWgTHZyobfwDLUXHLGfTF71MFoCuahJjPI9RjtaDx43wlLhwWReTJFnCI5JZUp/Xcyln0g== X-Received: by 2002:a05:6000:420c:b0:430:fbe1:3822 with SMTP id ffacd0b85a97d-4324e511811mr51135784f8f.54.1767128911605; Tue, 30 Dec 2025 13:08:31 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 05/34] monitor/hmp: Replace target_ulong -> vaddr in hmp_gva2gpa() Date: Tue, 30 Dec 2025 22:07:27 +0100 Message-ID: <20251230210757.13803-6-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251230210757.13803-1-philmd@linaro.org> References: <20251230210757.13803-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=philmd@linaro.org; helo=mail-wr1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767128993227158500 cpu_get_phys_page_debug() takes a vaddr type since commit 00b941e581b ("cpu: Turn cpu_get_phys_page_debug() into a CPUClass hook"). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Manos Pitsidianakis Reviewed-by: Dr. David Alan Gilbert Message-Id: <20251229231546.50604-2-philmd@linaro.org> --- monitor/hmp-cmds-target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/monitor/hmp-cmds-target.c b/monitor/hmp-cmds-target.c index e9820611466..2976f986d35 100644 --- a/monitor/hmp-cmds-target.c +++ b/monitor/hmp-cmds-target.c @@ -301,7 +301,7 @@ void hmp_gpa2hva(Monitor *mon, const QDict *qdict) =20 void hmp_gva2gpa(Monitor *mon, const QDict *qdict) { - target_ulong addr =3D qdict_get_int(qdict, "addr"); + vaddr addr =3D qdict_get_int(qdict, "addr"); CPUState *cs =3D mon_get_cpu(mon); hwaddr gpa; =20 --=20 2.52.0 From nobody Wed Jan 7 09:26:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767128964; cv=none; d=zohomail.com; s=zohoarc; b=dXNPra4Mv3z3SzFDFunJzUGJD6zQ18fkLqiUhH9s1ibTSqFjlrrw+prTCV6SfsA9tjFNx2hJ+o4unGyoCbrJNTDsSoLY7c++ZnMFWrsAFgLcmlGQ3395P7S4KLiDVAqTiEVQXTBPlB7Yal2qejY1UFzmYNmshYjg4r10La4tII4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767128964; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=dq6gDL+VvfsJgspbVgIcSIatyQ9ZwkoXNNTZK0OwJ2Y=; b=Um18G4ztQ7PGoWhL2aow48cNf8lwMOartxJBkFz7ohXIi/v8eNrA5U0AFZ4CpLcMQCPCAYHpUM842KqNBidAHI8m9ymffa45K5CHVZp5WAKduBwSa1k0w6J+1uE1Sg+QvjtbRFWf81bl+Zgj8oSBlD7Oig6ljynAqaQdiIvjI5g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767128964109300.8993727159992; Tue, 30 Dec 2025 13:09:24 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vagxS-0004wm-UV; Tue, 30 Dec 2025 16:08:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vagxO-0004pv-Fr for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:08:43 -0500 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vagxM-0002Ff-Qn for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:08:42 -0500 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-430fbb6012bso8572882f8f.1 for ; Tue, 30 Dec 2025 13:08:40 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eaa46c0sm70687019f8f.34.2025.12.30.13.08.37 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Dec 2025 13:08:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767128919; x=1767733719; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=dq6gDL+VvfsJgspbVgIcSIatyQ9ZwkoXNNTZK0OwJ2Y=; b=nOSYvE14j1JQo7oEsjzulP0fd1vOeBl8elMXh+Sj+lEr1njJvpMaNCW1jEgtdMz7LX eGKbWuej2IsvEuL843vBVEmBhOrzBr4i5ve23h8ATZcbLYEjpCq1eWQyymFJaSdcZvTT GI883dGiDkcCrE/p+weecyzeQpNJr2l4TOf0bR6VzDVDa41ZW5LcgMLLsvbs9bZKpDEe ivClzYYJnBdeVbxKEug98XRvIQpe2D1kETC8fptyRZfSzIb63B8aSijaq07AkO2YmRsk YoxezBpFReWrrRmYCmFDLCg8ZE83x3yPtFS1VXalgM5tKDhB3caKbawbaLDWCE1yoUgk TPDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767128919; x=1767733719; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=dq6gDL+VvfsJgspbVgIcSIatyQ9ZwkoXNNTZK0OwJ2Y=; b=WF9n2foE1CRg4Xrx+5mS1V3wuVIGXPEADblv54oNkt1kT7r655SWawtxoYhuH9DlyJ vZM31pFWpeNpYkJVY5iagCC0HFJh5t6AF6VX30X9JXdxYQuOB+87LnOMhdxRTdzMVyfr 9S0L4q3zEGWKDzQlL2hGVH+PwKtO+W8fieGwN/rwN9m5fXEbwCC78R4dgBAF0aD7/kdV lZkcX+BZHGGqBJ7PCuT4vCPPnm0rXYjJ9egik/rsWj0icFEmZWKsoEpHiOIF5jYQTD/2 hr46kDDJwjnw4upUCVcKluFBtPuGywCgPFAcqnwV6u7uU6R1f3LAYRTgoMehF9y2tGhs p/fQ== X-Gm-Message-State: AOJu0YyXbMvaOhhTHOp8RhyYsMRacTDp4TnOECIwEjKycURpwSexuoPN pXWjHWNREg2iKUFHwebwBBqN7l5vwoJ4LtJUBZneIltbkyOlaRG1PvsrTYP5AmIPOx/PWqKufCo fbCwNNvk= X-Gm-Gg: AY/fxX71Vbu8Ox3ESEtm3RWK2CmqAhQ69xxSfe456nTiwBUjtGoS8am1CC8EhyS7n7q 2uN2TTqvrb9lKmm5DAQX5i1hVGw1kj9zv7Kq5+3kvG19uAmWQaghj9wvaomrZUQv6EAS1m2g2Zs i4F+HHYIqafmQaajvi9StOKi0o8zp67NMvPt3WoR/UQqeiKG9FIQZnt49xcSDKnaP3H9JnC6ztc 88aW70VERwRQ5dFMi/lOCXmsUYNI3ZoI/T/FOxJwpH0M2B8sLRfgEPxXsm0XBokXRUkFdeu/LZW pZ0rK4C9Q8S3Cib3fcGJtfPwxLuA8NvaF+f64uFxT6j8CFXH0oaF/Vf+pYEjvarFR0QtaLGpRW+ dDfyUe5UMWOd5r3VTgg0UxCw9nZe8poTiA+uPVhopv5RpCFvc9y/+nb9B5rK4GGaN+pddBU2r1l aSpN78Swwu5ZFp0zTKJlOCGe0u0X16VgikZFd0zaP2RX6ROvplsA6OEQqQo2Hh X-Google-Smtp-Source: AGHT+IEtlzQySgxjCQZCN/743cdzfbyg0bK42e6Plmkm5pEsW9B3rapzsVviqnsu30LtJBq6Y5WK6Q== X-Received: by 2002:a5d:5d0d:0:b0:431:3a5:d9b8 with SMTP id ffacd0b85a97d-4324e510810mr41922457f8f.52.1767128918791; Tue, 30 Dec 2025 13:08:38 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 06/34] monitor/hmp: Make memory_dump() @is_physical argument a boolean Date: Tue, 30 Dec 2025 22:07:28 +0100 Message-ID: <20251230210757.13803-7-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251230210757.13803-1-philmd@linaro.org> References: <20251230210757.13803-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=philmd@linaro.org; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767128965198158500 Suggested-by: Dr. David Alan Gilbert Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Manos Pitsidianakis Message-Id: <20251229231546.50604-3-philmd@linaro.org> --- monitor/hmp-cmds-target.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/monitor/hmp-cmds-target.c b/monitor/hmp-cmds-target.c index 2976f986d35..51dcb9e314c 100644 --- a/monitor/hmp-cmds-target.c +++ b/monitor/hmp-cmds-target.c @@ -122,7 +122,7 @@ void hmp_info_registers(Monitor *mon, const QDict *qdic= t) } =20 static void memory_dump(Monitor *mon, int count, int format, int wsize, - hwaddr addr, int is_physical) + hwaddr addr, bool is_physical) { int l, line_size, i, max_digits, len; uint8_t buf[16]; @@ -237,7 +237,7 @@ void hmp_memory_dump(Monitor *mon, const QDict *qdict) int size =3D qdict_get_int(qdict, "size"); target_long addr =3D qdict_get_int(qdict, "addr"); =20 - memory_dump(mon, count, format, size, addr, 0); + memory_dump(mon, count, format, size, addr, false); } =20 void hmp_physical_memory_dump(Monitor *mon, const QDict *qdict) @@ -247,7 +247,7 @@ void hmp_physical_memory_dump(Monitor *mon, const QDict= *qdict) int size =3D qdict_get_int(qdict, "size"); hwaddr addr =3D qdict_get_int(qdict, "addr"); =20 - memory_dump(mon, count, format, size, addr, 1); + memory_dump(mon, count, format, size, addr, true); } =20 void *gpa2hva(MemoryRegion **p_mr, hwaddr addr, uint64_t size, Error **err= p) --=20 2.52.0 From nobody Wed Jan 7 09:26:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767128939; cv=none; d=zohomail.com; s=zohoarc; b=UEpukQuCUq5ymKczI0J4nvCNKWm5nEC8t7Q4oN+2uyXOP3Vh2eNjpliy63JjPZofR0EcrjBtG6GC1oInOaVFyF7+0ofZcYg6C/FOhqum3RLi4d7PsgouCJFhaJWALyd/W7dLHqwmc8Mfn+ikic8qMb6S3rtfqhnhzPiE4sNPQng= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767128939; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=J6K9VfrYM9O58NYLBO+LcXYAGm/XGIvX82MjEg9FdAU=; b=H9DWeCXLum2AFIt+GXTK5GwQj3JPoXuYR4C99FICGtDGbC/JVgjstygP2eQbLjuJhiKyF21jGrUo1l6UyRc0xpiKPm8wuxlda9TXFg7fEnbjcKwkEU004H3uu6TBECCnMEAiHgc5sNq9nsgZ8uZsoWsXI5OPJJXM5QSu2D6NwzM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767128939052895.533920834103; Tue, 30 Dec 2025 13:08:59 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vagxW-00053s-DU; Tue, 30 Dec 2025 16:08:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vagxU-000537-Jv for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:08:48 -0500 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vagxT-0002G0-3O for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:08:48 -0500 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-4779aa4f928so103152855e9.1 for ; Tue, 30 Dec 2025 13:08:46 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d193621c8sm609217975e9.7.2025.12.30.13.08.44 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Dec 2025 13:08:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767128925; x=1767733725; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=J6K9VfrYM9O58NYLBO+LcXYAGm/XGIvX82MjEg9FdAU=; b=uz3CsImxacePYGEQ3lQ+2edmNcwQDxP3cdcpB541ZJ7bM2oYb9l9zdRisR6HOjiTBh xVGI9SRHEM+J7NM08GEEWNQBs62phaaidzN/9dP0MMSVVKOBG4qIGcLkPEy8DjfYPm28 XsvnSnDN2zYQfcyOPXYch3pA6QqwtYSpxrpvMfcKXhZ1mkLQ8LtFOYoMDlsZYoIWrywZ mpoqzKWmYd4g9J+vObnr3/JRRThnG4m9v1kL/kBXGWP21zocvehfD4FRmuasNC6RM+nU pVF5L7cLAqZk3KK6N5Fdg2MzVBnqlUgXBwscDC+iCXw0ON5PaY1IiviE+qGQjHtmS4Rs 4Jjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767128925; x=1767733725; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=J6K9VfrYM9O58NYLBO+LcXYAGm/XGIvX82MjEg9FdAU=; b=BZ6bTVlhwqept6y5RRnV8x4AtS9jkrhlh6EpqFG44JzwIdMKH/3b8bFDwb4Ci5MluO UURp2yZgz7jLHQwEuSTPHpbyajbxocS2uJoDewMEK4Chw+4mMwuiFWS9znUM1scKsIEb Uhw2ifpHPQcIwyv1lNVkgm8XonVJXqdyAy3DFz4jJuReylFM/LcYwyEdeY5bWiTefaqQ qjqVzcdp6+Z4TzFB+ZzX6JK1AnPVaicCybLsiuJHFBkdhtVndkAJsgaEjjYe7jGoh5Kn oCfmUUp//jQIw7q3KdmGqJEmWv0AMd4RbCCaQ+g016jpE0X1LA+b32FwU8urqnv6XcSN CeoQ== X-Gm-Message-State: AOJu0YyX7GpDHXotIl8ONJLzNTvbSf5QSagZYIkFI1aaKStsMuqBrCT9 YZyrsrDhGcLfnkZ5P1hXeKhnZ+omJCKpNA2zWIf0tApNRKm2SbkvlDM4KY5uldQR7WKvTUdUhYC bbgrnbFo= X-Gm-Gg: AY/fxX5EJHBNZTUs/bSgYsRKBO4pNX/HuXCMIBuqP1NGlaMkOFWsHDR9MlqVS5MsBGK AUeCZh0NApj7aOocRRxaK3jsUf2uMoKk13efQS/zv0sKkN936qTjCFhZYzMRFRQT4A6y+d9VfjU OyW2pNZUuOOHuO3MmvNiYS01g/T1ix9UDTN5+2Xj5IUz9nHzCY6+DWrCdtRqahH91VbGQvK3sVj DKy84LjU6DXwReBbxEOVuJ4yGxsz50aQamEbd9ML1qGafGkswnPyVO0Dud/E4nX3Csk5QaDcwW6 tO0pEs3BQ+gODRAD+aMBvDAI7cyvD52PpABm39tUHXXVh14kCc8igMQwrVyNKw132xpEjJkbnpR V/GyMMYHYtQMMYiXK7i7nNi4JLRuFoWEo/gOxpjrDIulSIzjayw5EO2Hip3RIVDVqG0q1QbFoaJ KMKdbpYQq0BNuSP10sz6h3W+1LTuAj+EIAXC4+E3tlzuto6SFFfkIif8WXfkzK X-Google-Smtp-Source: AGHT+IHjRJFEPCpmtF1d1fOUz6/NeEeSSDi7ivz4NbqDULRUK52RohkvYyyH+icCxmzz4YWOGdHf1g== X-Received: by 2002:a05:600c:524f:b0:45d:d8d6:7fcc with SMTP id 5b1f17b1804b1-47d1958b73cmr422165405e9.27.1767128925308; Tue, 30 Dec 2025 13:08:45 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 07/34] monitor/hmp: Use plain uint64_t @addr argument in memory_dump() Date: Tue, 30 Dec 2025 22:07:29 +0100 Message-ID: <20251230210757.13803-8-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251230210757.13803-1-philmd@linaro.org> References: <20251230210757.13803-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=philmd@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767128941152158500 memory_dump() takes either hwaddr or vaddr type, depending on the @is_physical argument. Simply use uint64_t type which is common to both. Pad address using field width formatting, removing the need for the target_ulong type. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Manos Pitsidianakis Reviewed-by: Dr. David Alan Gilbert Message-Id: <20251229231546.50604-4-philmd@linaro.org> --- monitor/hmp-cmds-target.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/monitor/hmp-cmds-target.c b/monitor/hmp-cmds-target.c index 51dcb9e314c..e855c0d8a2c 100644 --- a/monitor/hmp-cmds-target.c +++ b/monitor/hmp-cmds-target.c @@ -122,12 +122,13 @@ void hmp_info_registers(Monitor *mon, const QDict *qd= ict) } =20 static void memory_dump(Monitor *mon, int count, int format, int wsize, - hwaddr addr, bool is_physical) + uint64_t addr, bool is_physical) { int l, line_size, i, max_digits, len; uint8_t buf[16]; uint64_t v; CPUState *cs =3D mon_get_cpu(mon); + const unsigned int addr_width =3D is_physical ? 8 : (target_long_bits(= ) * 2); =20 if (!cs && (format =3D=3D 'i' || !is_physical)) { monitor_printf(mon, "Can not dump without CPU\n"); @@ -165,11 +166,7 @@ static void memory_dump(Monitor *mon, int count, int f= ormat, int wsize, } =20 while (len > 0) { - if (is_physical) { - monitor_printf(mon, HWADDR_FMT_plx ":", addr); - } else { - monitor_printf(mon, TARGET_FMT_lx ":", (target_ulong)addr); - } + monitor_printf(mon, "%0*" PRIx64 ":", addr_width, addr); l =3D len; if (l > line_size) l =3D line_size; --=20 2.52.0 From nobody Wed Jan 7 09:26:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767128970; cv=none; d=zohomail.com; s=zohoarc; b=Mbo1Bk4fAwidfvR7vFDao8/zphQGKM/Ut7S96e6BtNaR872nuedXVY3uiYh/RFVgBexJ/Mr0ASNm6XcVVaR0xrmkOzVFDoQGGDqkp7ktIZ5ZxPH65RLFj4uLQVORNT9fEO5FWj9lMS2nbs4FDJ67ezd8XDsyoMZNLUEyWinzoEo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767128970; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=K7woP2d9AEbAAS/OFb9VFEAdFLMEwZL/u+yEwg3TqSs=; b=Fb72Njf3oeG2x/6W8+qf0VI+WIkQacROSgMbxCouVYjibgMbzstJvyThs0qKN7AEt0ALe2QM/cBwwWBIKqBFu/gxBML9S7zwQygS/Ph+xZ0MPQW/0aUofBx9RQoubM5+XteDOyX+Pra/Q3vUpDfpKW6XR+NiXh9Z3cOKVY1MOEw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767128970523973.0633532700903; Tue, 30 Dec 2025 13:09:30 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vagxg-0005Sw-Db; Tue, 30 Dec 2025 16:09:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vagxd-0005H4-E1 for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:08:57 -0500 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vagxZ-0002GQ-Pg for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:08:55 -0500 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-432755545fcso2370702f8f.1 for ; Tue, 30 Dec 2025 13:08:53 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea1b36fsm69879299f8f.5.2025.12.30.13.08.51 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Dec 2025 13:08:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767128932; x=1767733732; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=K7woP2d9AEbAAS/OFb9VFEAdFLMEwZL/u+yEwg3TqSs=; b=YBFUlroltgM+vJWOnTRFQcP+sCfpeBmWI58H301g6q3vBMda1wefPOaL/3jhIa5knz 8Jj5piI8yxUZlNYOxRSZOH/MgOFiNVJZWEI5BoP6MV3wIMm7zkCKdcHkU/ZmeOZVSwrf AqfgVr7L86SE3gkMaNh8Fx2lkrOyiH8RhgE1pkHzBL9UrdImXb7xZY7gY+BXbFUG6Kw+ w4gLrk92z0TQg5qtfWR63l0zpMnwk84QVui3jICcZUrirS58ofbURdQjhXJNKM5tVhgA 97OBDztrCU13TVj0rVm0r07DjhF9i6B8rp4f4Hu5HByj3i1rIt9R7MLFW8n40NKGhmO/ KkUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767128932; x=1767733732; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=K7woP2d9AEbAAS/OFb9VFEAdFLMEwZL/u+yEwg3TqSs=; b=eXY1AO7JxTl6HpvvwKaH3UhyFg/QV/RHDV4URme3bIUOXYJFt64nDq10lu2wdfngTP a/u9VzhD+dvrNRR2rruBlede0tBWt+p0ek735ul4tuZnXipzmTXTebXR+mtIMM9HCpPO qTejgXtDjOwtgsgZLD8qDxtBYEo19IE3o8KjJUUSuwQzu13am9NVIR8YXyxVM6rz639S claHQf5G6HjSh3gAeReRneDUjXMD/INqGu4HHDc5FZtah3zhQ7ucDWXFc3dTC4+OoceT 9WXkIPf5oCUNs1uddJgkQtLv5IX7qTtP97stluRD8fSA394xJHg5Q/ixw2wJnXdd1FcG TRbQ== X-Gm-Message-State: AOJu0Yydlz5K5d7vfgVnXwN55G0tdJXEykwnN/f2zWDHsIzTJCSJ4Ma7 P62U9f+lhRH2eaxK5NBEUnj5FtE+A5F3QRljckWA0D5qRNFWJ2v0fEW5wH+fo2yvqlvW5+APEr0 eslNCzdA= X-Gm-Gg: AY/fxX5Tiq1FPXE30YMW+YWZDrpACpgSYARYnTLSS+JVCrA75IOIHRpNRpPNvYRQ7nu WDz55LPHI8dKAxkejx2qKrONMjpVmae1KoUTglY0nyJ4ZLPQ7YRxeslxUYI1Bs7pWoh76xCsYYZ M2KnpYw/gJwXla+s1BPFPUALAu+6+sTrKJyfi7A3cquXyu3N5bXsIYWllX3R6exI1opuTHkpHrN vF1SuyhVA+X9cKUYlEISTJi0TlHFQ/1mRFo3T0yGAwpBYNwFYfgMauQbgE52yfN9b2Fv1BOx3q6 1j68WypPDdP5B9kqm16Z+2t5y6lepZxououYlrCOuPYj3jIarB7r2BGiDRzCJwssbux9n2xdAyJ HgKfSv1/wFcSkDFDDElBZJVs9PNfgjdNpK6O3SxXHYf71DuMowbWlYleFRlVeCi6QHptsV/gDLA dQrTzFBb0AuKvk/HUJ6XzhVwz3WWISOBcDLc56wZBoMB3L8d0oe5IZX8C9zlOh X-Google-Smtp-Source: AGHT+IFeMlUuHuI+0USpLD4M0aMIjIKz1j+ESIxghIoud7kcR17oTLbQe/F7mS6C6EFDRdz7VRkHtA== X-Received: by 2002:a05:6000:2281:b0:432:86e7:dd7b with SMTP id ffacd0b85a97d-43286e7dda0mr15096016f8f.0.1767128931739; Tue, 30 Dec 2025 13:08:51 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 08/34] monitor/hmp: Remove target_long uses in memory_dump() Date: Tue, 30 Dec 2025 22:07:30 +0100 Message-ID: <20251230210757.13803-9-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251230210757.13803-1-philmd@linaro.org> References: <20251230210757.13803-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=philmd@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767128971229158500 Pass a plain vaddr type to express virtual address. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Manos Pitsidianakis Message-Id: <20251229231546.50604-5-philmd@linaro.org> --- monitor/hmp-cmds-target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/monitor/hmp-cmds-target.c b/monitor/hmp-cmds-target.c index e855c0d8a2c..7c8bddabbac 100644 --- a/monitor/hmp-cmds-target.c +++ b/monitor/hmp-cmds-target.c @@ -232,7 +232,7 @@ void hmp_memory_dump(Monitor *mon, const QDict *qdict) int count =3D qdict_get_int(qdict, "count"); int format =3D qdict_get_int(qdict, "format"); int size =3D qdict_get_int(qdict, "size"); - target_long addr =3D qdict_get_int(qdict, "addr"); + vaddr addr =3D qdict_get_int(qdict, "addr"); =20 memory_dump(mon, count, format, size, addr, false); } --=20 2.52.0 From nobody Wed Jan 7 09:26:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767128950265243.38480143899187; Tue, 30 Dec 2025 13:09:10 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vagxk-0005tq-Tf; Tue, 30 Dec 2025 16:09:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vagxj-0005hx-15 for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:09:03 -0500 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vagxg-0002H2-8T for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:09:02 -0500 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-42fb2314eb0so7958246f8f.2 for ; Tue, 30 Dec 2025 13:08:59 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eaa08d9sm70768590f8f.30.2025.12.30.13.08.57 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Dec 2025 13:08:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767128938; x=1767733738; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=g8lepc3JFLsk2Adb0qehzcmxR31oRBQl7MkEMoqLS7s=; b=PbKxCeZ7Ebyb/bigsKrt69m3GrmPKVwJ/9YkC4CGU3m+efSYAEzFHERxQBu8muZig+ 8xoJNaPed3H3ubyUthbof1dB9alteRhvUWmToG/nCFm8lewYwoLpDdhZRupEnmYygKqH GDtlvflvS/1AWpDOV2PGOTZOH2N25M+zH9N9Lfo8oRtT965cHc/17/FG492Sv+diiXTR n7ffcvCE1SttiuJOVRO8fcpV/7Y94yjpaxmAFHqkve2dyq1D/XnMw3/bUlOGVwwOm+jr Q9+mf2u6/lYEpcNqhr5qpjohebVH3AONx9DctvykbaoAkdrrCzkYIHs+IeaoE+hHdDi/ qQvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767128938; x=1767733738; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=g8lepc3JFLsk2Adb0qehzcmxR31oRBQl7MkEMoqLS7s=; b=Wx2pYe635bjw/cC8tiVo0lKGn/fV0l2K6FsrTStmFhmCd084Pt5+6PfFV462KDfHmr p4YaoWOV62wFFPb/OjVuv/XNEJvVrQZphI7qZre1JC/GrKgmoE6JRFeuUrwtZcX+zKlt MP3JpZGhg6fvXGuIYAHUqs75nZvqKSsbL5ftnLgNaDKwYkJt1oUu5Ok8xx2mdsvqjXBK 3Oyj91WoMSI7QY9y7fK79fFj8encTcEGK4G74hxKoleCZ8z7JXedgOsBOnxZoT0yG/34 /3Em/NoxC6gLurYhv+UAwRDy1RSuS0RSgzivoPdg8j3RsWyrT/MdtOdtn3NpN/ryjj1P odRQ== X-Gm-Message-State: AOJu0YxDybtfNuF8I2ukSUPFOFFlkHApuSvzskOiosQLlU+5OsBHCkQL tNwc8lMxwpH4bwTbvuJyPFZIHoXBlF3GYVqRve2Z3oXIIDNLn1+o8FEDS+eo6MWkGkvBJ78e0D+ HBJA4rj0= X-Gm-Gg: AY/fxX6hDuvrii7iPVPonmnLZk+I+a7diNJbn1WBUkmsPXpFpaCRJRNVCWKHb1Weao0 UZm9v/Ep4YQs2dMFiS0GHN5h9e+9/5iiuJtt1yf7c84Idvms8neIYeN/k+HU21+MlhcvzKONSaT 12BXsUaOkfRoaN2dxfth4ihmlELI+6nTIAKlopX2+Demk38gdiyM1Gd5OtodwJVrJE+buBxsuu5 W5FaPz4qGLU2izo1sxq6iDEhnraFjekVsfctAXym7f8lWCyEwseOwX6qnVjYHOD4eNdP12EWIil SuL5jAwTzY2WFItx2RP2tb6drf+cg/aS8Eip+dO0IFMTv3Q4VNa//N4wGzcBpY/zvymLHieug+o DQdw3bqx9Wwr/jfchO7WTkutqXmMsWWl6Ke6kMjS15aq4kze60dSqjfYGa/PI8VihfBOl7c5Nhu V7Dq1FNK+Kh3WmSWawxvaeIkMB6bNOmCfXPHikwdXaPA1ZgcJndE/p7tU1z3iSznIQ70TWUvg= X-Google-Smtp-Source: AGHT+IGJ8jxsIWiIgLvMXHSYh6YyQ+HUR3Nwasxe1g/pkPtMo96KB28WRpRk5l/PNuLZuySgeymByA== X-Received: by 2002:a05:6000:288b:b0:430:f718:23a2 with SMTP id ffacd0b85a97d-4324e4d2cd8mr41655391f8f.28.1767128938286; Tue, 30 Dec 2025 13:08:58 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 09/34] monitor/hmp: Inline ld[uw, l, q]_p() calls in memory_dump() Date: Tue, 30 Dec 2025 22:07:31 +0100 Message-ID: <20251230210757.13803-10-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251230210757.13803-1-philmd@linaro.org> References: <20251230210757.13803-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=philmd@linaro.org; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1767128951157158500 Remove the last target-specificity in this file. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Manos Pitsidianakis Message-Id: <20251229231546.50604-6-philmd@linaro.org> --- monitor/hmp-cmds-target.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/monitor/hmp-cmds-target.c b/monitor/hmp-cmds-target.c index 7c8bddabbac..e782259c3e6 100644 --- a/monitor/hmp-cmds-target.c +++ b/monitor/hmp-cmds-target.c @@ -129,6 +129,7 @@ static void memory_dump(Monitor *mon, int count, int fo= rmat, int wsize, uint64_t v; CPUState *cs =3D mon_get_cpu(mon); const unsigned int addr_width =3D is_physical ? 8 : (target_long_bits(= ) * 2); + const bool big_endian =3D target_big_endian(); =20 if (!cs && (format =3D=3D 'i' || !is_physical)) { monitor_printf(mon, "Can not dump without CPU\n"); @@ -192,13 +193,13 @@ static void memory_dump(Monitor *mon, int count, int = format, int wsize, v =3D ldub_p(buf + i); break; case 2: - v =3D lduw_p(buf + i); + v =3D (big_endian ? lduw_be_p : lduw_le_p)(buf + i); break; case 4: - v =3D (uint32_t)ldl_p(buf + i); + v =3D (uint32_t)(big_endian ? ldl_be_p : ldl_le_p)(buf + i= ); break; case 8: - v =3D ldq_p(buf + i); + v =3D (big_endian ? ldq_be_p : ldq_le_p)(buf + i); break; } monitor_printf(mon, " "); --=20 2.52.0 From nobody Wed Jan 7 09:26:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767128963; cv=none; d=zohomail.com; s=zohoarc; b=iISHNf+Apu+SI+6P6kg56kzmoxwU2VOXalOr/3BW47KRZs9hs5JfRGzRSLYKtq1wEXLY3xpYbu156U9+zaHgJeyo908/rK9dO3SpP7HNpBiTMWZ4BBc32BjBQ7gpLtYQTUuFDTEcDNuwk8uuYJxMPuVZC/z8redr48lXYuFRjdM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767128963; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=XHuXv7foUWZRnur9mLOEsDXFW8v0pmgg4BIkmsWiURg=; b=FUL+aoamTk4lce23Na9NVw8nR9bIdtQf2f0uqeYLW6tgQ5WuAAPxjl7Zf82rof3/3UzRMO3oyTWzC+4F7Ucvo2ffywVvcZz0DYyJdw36toj+iTizrA1Pcar/sfTdplSEHfm20l7cQES7znSPcsjsQhqN7fMruOOkBgzlbjO8GZw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767128963533862.8538466865014; Tue, 30 Dec 2025 13:09:23 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vagxq-0006Nq-Gq; Tue, 30 Dec 2025 16:09:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vagxo-0006Gg-Jk for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:09:08 -0500 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vagxm-0002Iz-OC for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:09:08 -0500 Received: by mail-wm1-x343.google.com with SMTP id 5b1f17b1804b1-4775895d69cso43413235e9.0 for ; Tue, 30 Dec 2025 13:09:06 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d193d4e91sm594395325e9.13.2025.12.30.13.09.04 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Dec 2025 13:09:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767128945; x=1767733745; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=XHuXv7foUWZRnur9mLOEsDXFW8v0pmgg4BIkmsWiURg=; b=X/pf2GwtjY7itAtbAd79I/eJMFQISCzdwRV/hLF51Gyrzu19pubJAVp9Kp2Ypc70lR LreqkrgqQN/v+1580GZuDjNejyhXyGDkJR3iHHeT1wVpZbFYvMks1EfooHNcy7BrVa9F wXGInBFRKG/DgYhVht5Qa3cbYbwU6fETDRlAxaEuETTZbXf0EhSlUenejLHNtMaJqAGD xn2sx3nYCiUGjEH4qbzzp5KK/wk7x5WmQWLKfzWNh0nnlHcDUCbQ7XXyaCTlDLYzW4uB eQofRc/TxdsmD1AXeScK+NgHvAnBECC/IXCZzRG5dhHsFMxHAlHJYh2//SzA24ABlw1q 9nIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767128945; x=1767733745; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=XHuXv7foUWZRnur9mLOEsDXFW8v0pmgg4BIkmsWiURg=; b=H1tubCGhMLCbkD8HL7Wh9CfT88aEDqg0Wgn7TogjkLbXdhJSPt9bHm+iJo+0shZ5A+ 7pe91NR4bAKW8RIQhifYJxhZKhiYr/yni2iG7dDXi+ZTYDJLviBiphK7IMx+nFg4G6AP 3A6zRAnOMvk6FkyUafw/5/jWXzroCm4xjboC5Hg59ijTBZYzPgY6YFiEe52eIrOIwdIO 8cjsfLCvklFjDnhzNJSlWVBK8vPyWrjK0FJOcISOKcLxFr6y1iGhBEvMpqmitapd4zbL h0xAZAriHetLRJ+h6yWaphJEcKBFpRfpcKDEwiK17WFVOSuPGsB5m8ihHyjJrKEbzOiA 97Qg== X-Gm-Message-State: AOJu0YwSOoKrK4A3zGG7i6IavV366/976J3b5VKbwCANeSWlPTRVJc7f KCpp07fxOAgeOjkdlrevTnDWeHYxKqRPA3hUkAWA02o0KhYtIlIJzvBQcjTNU0tPzPdUgzSryco gXyoqras= X-Gm-Gg: AY/fxX67XCYBFX/qi0JM5yR3HKvIuYnT0Bt4GrwNJnm/Mjg2demdz/0Ect8pPm78t17 7XUmWW3ZenXBvhv1/+G4N6OTNMUnbcFO0D2AVN0yfSd2mTiyhkMKBynnDVRPwOb26/DmMQUed4z Y/q9xlRlD8A0Y8NgTi3QE7OhKlK8iSnfPYrNO29JDwSlk5hUjrMy5D4SLT5cOBMXTpd1CsNKS4J HonBZre1b0br1eXuF4eCsILrWRXlHc48uMJupkia65Vtdp22grEdtBN0uYooqClg+j8MqhLD6sG pzIdhT0C9qelCMtJIJJ/BKRg8bHltvZi/z3KMVhrU+IzjIXuqY/ihkXEuzSh44xVT9SEg1MMye7 3y2TcYuaplG3nUi1zVS9mc/u4h+KTngiDDMVARDc1y612pxdJI1ngfEpL8LWV0/QJ9EvuttC6+L yKjvw5emp8sjwOTCXaCHMsbXchf5y6S3hK47lgeQ1Qfyb+7HVB09bjATEmisad X-Google-Smtp-Source: AGHT+IEIEdG05Z5HqHp9iatBDlnQUT43sZdbKYBZG8FZVOMNBnI6GVT+SkgxvZfXqlxMwmEQY1t5Kw== X-Received: by 2002:a05:600c:8116:b0:477:abea:9028 with SMTP id 5b1f17b1804b1-47d1953bc47mr354696575e9.6.1767128944747; Tue, 30 Dec 2025 13:09:04 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 10/34] monitor/hmp: Fix coding style in hmp-cmds-target.c Date: Tue, 30 Dec 2025 22:07:32 +0100 Message-ID: <20251230210757.13803-11-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251230210757.13803-1-philmd@linaro.org> References: <20251230210757.13803-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::343; envelope-from=philmd@linaro.org; helo=mail-wm1-x343.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767128965241158500 Previous to moving code contained in hmp-cmds-target.c, fix the coding style. Otherwise the checkpatch.pl script would report: ERROR: space required before the open parenthesis '(' #134: FILE: monitor/hmp-cmds-target.c:152: + switch(format) { ERROR: braces {} are necessary for all arms of this statement #154: FILE: monitor/hmp-cmds-target.c:172: + if (l > line_size) [...] ERROR: space required before the open parenthesis '(' #172: FILE: monitor/hmp-cmds-target.c:190: + switch(wsize) { ERROR: space required before the open parenthesis '(' #188: FILE: monitor/hmp-cmds-target.c:206: + switch(format) { ERROR: Don't use '#' flag of printf format ('%#') in format strings, use = '0x' prefix instead #190: FILE: monitor/hmp-cmds-target.c:208: + monitor_printf(mon, "%#*" PRIo64, max_digits, v); WARNING: line over 80 characters #240: FILE: monitor/hmp-cmds-target.c:258: + error_setg(errp, "No memory is mapped at address 0x%" HWADDR_PRI= x, addr); WARNING: line over 80 characters #245: FILE: monitor/hmp-cmds-target.c:263: + error_setg(errp, "Memory at address 0x%" HWADDR_PRIx " is not RA= M", addr); ERROR: Don't use '#' flag of printf format ('%#') in format strings, use = '0x' prefix instead #297: FILE: monitor/hmp-cmds-target.c:315: + monitor_printf(mon, "gpa: %#" HWADDR_PRIx "\n", WARNING: line over 80 characters #329: FILE: monitor/hmp-cmds-target.c:347: + ret =3D ((pinfo & 0x007fffffffffffffull) * pagesize) | (addr & (page= size - 1)); Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Manos Pitsidianakis Reviewed-by: Dr. David Alan Gilbert Message-Id: <20251229231546.50604-7-philmd@linaro.org> --- monitor/hmp-cmds-target.c | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/monitor/hmp-cmds-target.c b/monitor/hmp-cmds-target.c index e782259c3e6..b4360f1f807 100644 --- a/monitor/hmp-cmds-target.c +++ b/monitor/hmp-cmds-target.c @@ -149,7 +149,7 @@ static void memory_dump(Monitor *mon, int count, int fo= rmat, int wsize, } max_digits =3D 0; =20 - switch(format) { + switch (format) { case 'o': max_digits =3D DIV_ROUND_UP(wsize * 8, 3); break; @@ -169,8 +169,9 @@ static void memory_dump(Monitor *mon, int count, int fo= rmat, int wsize, while (len > 0) { monitor_printf(mon, "%0*" PRIx64 ":", addr_width, addr); l =3D len; - if (l > line_size) + if (l > line_size) { l =3D line_size; + } if (is_physical) { AddressSpace *as =3D cs ? cs->as : &address_space_memory; MemTxResult r =3D address_space_read(as, addr, @@ -187,7 +188,7 @@ static void memory_dump(Monitor *mon, int count, int fo= rmat, int wsize, } i =3D 0; while (i < l) { - switch(wsize) { + switch (wsize) { default: case 1: v =3D ldub_p(buf + i); @@ -203,9 +204,9 @@ static void memory_dump(Monitor *mon, int count, int fo= rmat, int wsize, break; } monitor_printf(mon, " "); - switch(format) { + switch (format) { case 'o': - monitor_printf(mon, "%#*" PRIo64, max_digits, v); + monitor_printf(mon, "0%*" PRIo64, max_digits, v); break; case 'x': monitor_printf(mon, "0x%0*" PRIx64, max_digits, v); @@ -255,12 +256,14 @@ void *gpa2hva(MemoryRegion **p_mr, hwaddr addr, uint6= 4_t size, Error **errp) addr, size); =20 if (!mrs.mr) { - error_setg(errp, "No memory is mapped at address 0x%" HWADDR_PRIx,= addr); + error_setg(errp, + "No memory is mapped at address 0x%" HWADDR_PRIx, addr); return NULL; } =20 if (!memory_region_is_ram(mrs.mr) && !memory_region_is_romd(mrs.mr)) { - error_setg(errp, "Memory at address 0x%" HWADDR_PRIx " is not RAM"= , addr); + error_setg(errp, + "Memory at address 0x%" HWADDR_PRIx " is not RAM", addr= ); memory_region_unref(mrs.mr); return NULL; } @@ -312,7 +315,7 @@ void hmp_gva2gpa(Monitor *mon, const QDict *qdict) if (gpa =3D=3D -1) { monitor_printf(mon, "Unmapped\n"); } else { - monitor_printf(mon, "gpa: %#" HWADDR_PRIx "\n", + monitor_printf(mon, "gpa: 0x%" HWADDR_PRIx "\n", gpa + (addr & ~TARGET_PAGE_MASK)); } } @@ -344,7 +347,8 @@ static uint64_t vtop(void *ptr, Error **errp) error_setg(errp, "Page not present"); goto out; } - ret =3D ((pinfo & 0x007fffffffffffffull) * pagesize) | (addr & (pagesi= ze - 1)); + ret =3D (pinfo & 0x007fffffffffffffull) * pagesize; + ret |=3D addr & (pagesize - 1); =20 out: close(fd); --=20 2.52.0 From nobody Wed Jan 7 09:26:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767128984; cv=none; d=zohomail.com; s=zohoarc; b=XWxk3G7AiafMK4CJyxS5OkTsXsG0Mwn9yCQ7VlwGxPBuwBeSfJ43bDAruv12mpWIZIIDy8VQaXCoM3uxo1xDb8YEqoQEF1MeyG9ggeNRXNw5zW6KqplaM4eu6CJB3l88RqK53ZJzsMCnL+5379aMGutmmyUs8QBr6ZOaHt6WzkE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767128984; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=hhU49fbiZ3nl0kGa0lXhvD0zoh9REzkPC+zIE/tKGjE=; b=Z0CKXL4Qs1Kzaw/Deer4hI5hK+rhO3i0/A5GYZYFiAX/L8BAGzo1eAuGx5v3L58EA0QBDHnSiqTC5nPgb1rEXY3psiF+EDjmvE2D2KdCFK4vrLmvns/racX4xOYaKM6HwUyq2OCBc950HoFDLr8b4WqTFhDlJLslMkIKNU84hqs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767128984733472.88446633363355; Tue, 30 Dec 2025 13:09:44 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vagyG-0006zV-AM; Tue, 30 Dec 2025 16:09:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vagxx-0006e4-6B for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:09:20 -0500 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vagxt-0002JL-IP for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:09:16 -0500 Received: by mail-wm1-x343.google.com with SMTP id 5b1f17b1804b1-4779cb0a33fso105743645e9.0 for ; Tue, 30 Dec 2025 13:09:13 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be2723d19sm717916385e9.2.2025.12.30.13.09.10 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Dec 2025 13:09:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767128952; x=1767733752; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=hhU49fbiZ3nl0kGa0lXhvD0zoh9REzkPC+zIE/tKGjE=; b=Ml/+eWy0hS2ozcZ2O2NzTRuH1avi0180Y0wJYmgLyY3aySIU5rcu14TR5BEYw/gzrB w+WQYqxTIGL6eNXXM+BPgiWwT3WjWjCY0F0uk4n82+N5nX95hcK7DwAx8Aqk+QHLJPfr OS3OjwoYYCiP6krE+X7VmTKXevMVDgfifu2TTav3vl1mva1mkwWUtnCS3v/LlUCcvzG/ LcvkQvO0a9bbK6EjMGaokYzTCsJEe0+NxFvrLbybei1RERe6so4aUpgvLWWBIZhSN720 rFSCUuB8C470seB+rxD1gjrLccEw/HM2hXfXpfKzvZuGEMu/x7Oq7B3XsPHSz3g/aGn2 amXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767128952; x=1767733752; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=hhU49fbiZ3nl0kGa0lXhvD0zoh9REzkPC+zIE/tKGjE=; b=Pnwl4T332xv+tcXaRckXk4ydvnNNpYlgoKnITo7s1c9wsdjegRQLK1r23sqxclMvNP s5RWJPyGnk0bQVxMNusNT4qKqfpfj7YmWDC37uiGOH6I9ePAEEzTFwYHvBuQgZCkX2Zb cIGsM+nnxoq2p4sMpVTomIeFx8I7c3PFIu6OZGgS9rnnUbag1S8wPZSQjC3WEz/b8h89 cBg8IYkzHYzuU4ewh+YPvjKZwJ6n59WBOY7Nc2oaJ5V5i8ccbSRrOrOle6cYekrpNpdF xTumEc6NXbujYx6raortqNswLoNS4shEMfl/K9XNyjY9GCsL2ScUT7wDPsxB0fWyQUIj dZwg== X-Gm-Message-State: AOJu0YzuR7U5Ge6urgdlYVhPfxfDxb6drNDJsKU4XwgrRX16ijBLuvun KlSfxu+Iu1TsMSGi83i5qaLUonp/6KcW5mpJ7JZdeGXQ/3dDyyEbk0n3GjiFzw/JDgpgmnRDSjP h6l5HQAA= X-Gm-Gg: AY/fxX5hS4y8Zt1QN/RniMh16miYJu9qaaHUnyAEW6msOhQqOkjeURk1LD7CIb7HkTh NdnZpvNHO2FhqcB6LVqk9wIYOHeoeEu0MVOspiMC8+rkFOK6Vp/l9TXQgmAkY2jrrDyMUQxCSW3 3PBFhiIdcCIaQZqALVlGOjUOIGQq1chWH7yhgTr4B4eALfNR0W4OfTYwOBejPyiv0ih2G7NtNCn 6v7znZn7PvJaekhgTVN0UpWEhSCHoxC+AIx5nPradsv0ZwYusMIRWUQFJ1sJbjwetyjKuwCSicV dApXF2v49XoCtUbp38AP9CoNRPKLeQRwp5onysmaPfiGhj08PKJ55hoC9XigFibYMgoIVqkhN8m OylY+qZnX0163115aj9IGCq+5GEc2HsmimXteRcDJrVmBhtcRV578HzZEEKDYoamU7hcG/Cs5SA Ous7cM6a884xgav9w7nlmo5PplWed4WDtn8ZxQRdfzu/2GYQ+lRCc1a8qsBO/XccmekZxu5d4= X-Google-Smtp-Source: AGHT+IFoQM7XP7iZvEjbc82sUaJR+Ko/eFYBTqHS8kHMN9KEK2wd2NvfNZetxg2e/M7p4JYYhrOd/w== X-Received: by 2002:a05:600c:608d:b0:477:93f7:bbc5 with SMTP id 5b1f17b1804b1-47d195667d6mr398383395e9.10.1767128951398; Tue, 30 Dec 2025 13:09:11 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 11/34] monitor/hmp: Merge hmp-cmds-target.c within hmp-cmds.c Date: Tue, 30 Dec 2025 22:07:33 +0100 Message-ID: <20251230210757.13803-12-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251230210757.13803-1-philmd@linaro.org> References: <20251230210757.13803-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::343; envelope-from=philmd@linaro.org; helo=mail-wm1-x343.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767128985291158500 hmp-cmds-target.c is no more target specific, move its code in hmp-cmds.c, which is built once for all system binaries. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Manos Pitsidianakis Message-Id: <20251229231546.50604-8-philmd@linaro.org> --- monitor/hmp-cmds-target.c | 383 -------------------------------------- monitor/hmp-cmds.c | 354 +++++++++++++++++++++++++++++++++++ monitor/meson.build | 2 +- 3 files changed, 355 insertions(+), 384 deletions(-) delete mode 100644 monitor/hmp-cmds-target.c diff --git a/monitor/hmp-cmds-target.c b/monitor/hmp-cmds-target.c deleted file mode 100644 index b4360f1f807..00000000000 --- a/monitor/hmp-cmds-target.c +++ /dev/null @@ -1,383 +0,0 @@ -/* - * Miscellaneous target-dependent HMP commands - * - * Copyright (c) 2003-2004 Fabrice Bellard - * - * Permission is hereby granted, free of charge, to any person obtaining a= copy - * of this software and associated documentation files (the "Software"), t= o deal - * in the Software without restriction, including without limitation the r= ights - * to use, copy, modify, merge, publish, distribute, sublicense, and/or se= ll - * copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included= in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS= OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL - * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OT= HER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING= FROM, - * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS = IN - * THE SOFTWARE. - */ - -#include "qemu/osdep.h" -#include "disas/disas.h" -#include "system/address-spaces.h" -#include "system/memory.h" -#include "monitor/hmp-target.h" -#include "monitor/monitor-internal.h" -#include "qapi/error.h" -#include "qobject/qdict.h" -#include "system/hw_accel.h" -#include "exec/target_page.h" - -/* Set the current CPU defined by the user. Callers must hold BQL. */ -int monitor_set_cpu(Monitor *mon, int cpu_index) -{ - CPUState *cpu; - - cpu =3D qemu_get_cpu(cpu_index); - if (cpu =3D=3D NULL) { - return -1; - } - g_free(mon->mon_cpu_path); - mon->mon_cpu_path =3D object_get_canonical_path(OBJECT(cpu)); - return 0; -} - -/* Callers must hold BQL. */ -static CPUState *mon_get_cpu_sync(Monitor *mon, bool synchronize) -{ - CPUState *cpu =3D NULL; - - if (mon->mon_cpu_path) { - cpu =3D (CPUState *) object_resolve_path_type(mon->mon_cpu_path, - TYPE_CPU, NULL); - if (!cpu) { - g_free(mon->mon_cpu_path); - mon->mon_cpu_path =3D NULL; - } - } - if (!mon->mon_cpu_path) { - if (!first_cpu) { - return NULL; - } - monitor_set_cpu(mon, first_cpu->cpu_index); - cpu =3D first_cpu; - } - assert(cpu !=3D NULL); - if (synchronize) { - cpu_synchronize_state(cpu); - } - return cpu; -} - -CPUState *mon_get_cpu(Monitor *mon) -{ - return mon_get_cpu_sync(mon, true); -} - -CPUArchState *mon_get_cpu_env(Monitor *mon) -{ - CPUState *cs =3D mon_get_cpu(mon); - - return cs ? cpu_env(cs) : NULL; -} - -int monitor_get_cpu_index(Monitor *mon) -{ - CPUState *cs =3D mon_get_cpu_sync(mon, false); - - return cs ? cs->cpu_index : UNASSIGNED_CPU_INDEX; -} - -void hmp_info_registers(Monitor *mon, const QDict *qdict) -{ - bool all_cpus =3D qdict_get_try_bool(qdict, "cpustate_all", false); - int vcpu =3D qdict_get_try_int(qdict, "vcpu", -1); - CPUState *cs; - - if (all_cpus) { - CPU_FOREACH(cs) { - monitor_printf(mon, "\nCPU#%d\n", cs->cpu_index); - cpu_dump_state(cs, NULL, CPU_DUMP_FPU | CPU_DUMP_VPU); - } - } else { - cs =3D vcpu >=3D 0 ? qemu_get_cpu(vcpu) : mon_get_cpu(mon); - - if (!cs) { - if (vcpu >=3D 0) { - monitor_printf(mon, "CPU#%d not available\n", vcpu); - } else { - monitor_printf(mon, "No CPU available\n"); - } - return; - } - - monitor_printf(mon, "\nCPU#%d\n", cs->cpu_index); - cpu_dump_state(cs, NULL, CPU_DUMP_FPU | CPU_DUMP_VPU); - } -} - -static void memory_dump(Monitor *mon, int count, int format, int wsize, - uint64_t addr, bool is_physical) -{ - int l, line_size, i, max_digits, len; - uint8_t buf[16]; - uint64_t v; - CPUState *cs =3D mon_get_cpu(mon); - const unsigned int addr_width =3D is_physical ? 8 : (target_long_bits(= ) * 2); - const bool big_endian =3D target_big_endian(); - - if (!cs && (format =3D=3D 'i' || !is_physical)) { - monitor_printf(mon, "Can not dump without CPU\n"); - return; - } - - if (format =3D=3D 'i') { - monitor_disas(mon, cs, addr, count, is_physical); - return; - } - - len =3D wsize * count; - if (wsize =3D=3D 1) { - line_size =3D 8; - } else { - line_size =3D 16; - } - max_digits =3D 0; - - switch (format) { - case 'o': - max_digits =3D DIV_ROUND_UP(wsize * 8, 3); - break; - default: - case 'x': - max_digits =3D (wsize * 8) / 4; - break; - case 'u': - case 'd': - max_digits =3D DIV_ROUND_UP(wsize * 8 * 10, 33); - break; - case 'c': - wsize =3D 1; - break; - } - - while (len > 0) { - monitor_printf(mon, "%0*" PRIx64 ":", addr_width, addr); - l =3D len; - if (l > line_size) { - l =3D line_size; - } - if (is_physical) { - AddressSpace *as =3D cs ? cs->as : &address_space_memory; - MemTxResult r =3D address_space_read(as, addr, - MEMTXATTRS_UNSPECIFIED, buf= , l); - if (r !=3D MEMTX_OK) { - monitor_printf(mon, " Cannot access memory\n"); - break; - } - } else { - if (cpu_memory_rw_debug(cs, addr, buf, l, 0) < 0) { - monitor_printf(mon, " Cannot access memory\n"); - break; - } - } - i =3D 0; - while (i < l) { - switch (wsize) { - default: - case 1: - v =3D ldub_p(buf + i); - break; - case 2: - v =3D (big_endian ? lduw_be_p : lduw_le_p)(buf + i); - break; - case 4: - v =3D (uint32_t)(big_endian ? ldl_be_p : ldl_le_p)(buf + i= ); - break; - case 8: - v =3D (big_endian ? ldq_be_p : ldq_le_p)(buf + i); - break; - } - monitor_printf(mon, " "); - switch (format) { - case 'o': - monitor_printf(mon, "0%*" PRIo64, max_digits, v); - break; - case 'x': - monitor_printf(mon, "0x%0*" PRIx64, max_digits, v); - break; - case 'u': - monitor_printf(mon, "%*" PRIu64, max_digits, v); - break; - case 'd': - monitor_printf(mon, "%*" PRId64, max_digits, v); - break; - case 'c': - monitor_printc(mon, v); - break; - } - i +=3D wsize; - } - monitor_printf(mon, "\n"); - addr +=3D l; - len -=3D l; - } -} - -void hmp_memory_dump(Monitor *mon, const QDict *qdict) -{ - int count =3D qdict_get_int(qdict, "count"); - int format =3D qdict_get_int(qdict, "format"); - int size =3D qdict_get_int(qdict, "size"); - vaddr addr =3D qdict_get_int(qdict, "addr"); - - memory_dump(mon, count, format, size, addr, false); -} - -void hmp_physical_memory_dump(Monitor *mon, const QDict *qdict) -{ - int count =3D qdict_get_int(qdict, "count"); - int format =3D qdict_get_int(qdict, "format"); - int size =3D qdict_get_int(qdict, "size"); - hwaddr addr =3D qdict_get_int(qdict, "addr"); - - memory_dump(mon, count, format, size, addr, true); -} - -void *gpa2hva(MemoryRegion **p_mr, hwaddr addr, uint64_t size, Error **err= p) -{ - Int128 gpa_region_size; - MemoryRegionSection mrs =3D memory_region_find(get_system_memory(), - addr, size); - - if (!mrs.mr) { - error_setg(errp, - "No memory is mapped at address 0x%" HWADDR_PRIx, addr); - return NULL; - } - - if (!memory_region_is_ram(mrs.mr) && !memory_region_is_romd(mrs.mr)) { - error_setg(errp, - "Memory at address 0x%" HWADDR_PRIx " is not RAM", addr= ); - memory_region_unref(mrs.mr); - return NULL; - } - - gpa_region_size =3D int128_make64(size); - if (int128_lt(mrs.size, gpa_region_size)) { - error_setg(errp, "Size of memory region at 0x%" HWADDR_PRIx - " exceeded.", addr); - memory_region_unref(mrs.mr); - return NULL; - } - - *p_mr =3D mrs.mr; - return qemu_map_ram_ptr(mrs.mr->ram_block, mrs.offset_within_region); -} - -void hmp_gpa2hva(Monitor *mon, const QDict *qdict) -{ - hwaddr addr =3D qdict_get_int(qdict, "addr"); - Error *local_err =3D NULL; - MemoryRegion *mr =3D NULL; - void *ptr; - - ptr =3D gpa2hva(&mr, addr, 1, &local_err); - if (local_err) { - error_report_err(local_err); - return; - } - - monitor_printf(mon, "Host virtual address for 0x%" HWADDR_PRIx - " (%s) is %p\n", - addr, mr->name, ptr); - - memory_region_unref(mr); -} - -void hmp_gva2gpa(Monitor *mon, const QDict *qdict) -{ - vaddr addr =3D qdict_get_int(qdict, "addr"); - CPUState *cs =3D mon_get_cpu(mon); - hwaddr gpa; - - if (!cs) { - monitor_printf(mon, "No cpu\n"); - return; - } - - gpa =3D cpu_get_phys_page_debug(cs, addr & TARGET_PAGE_MASK); - if (gpa =3D=3D -1) { - monitor_printf(mon, "Unmapped\n"); - } else { - monitor_printf(mon, "gpa: 0x%" HWADDR_PRIx "\n", - gpa + (addr & ~TARGET_PAGE_MASK)); - } -} - -#ifdef CONFIG_LINUX -static uint64_t vtop(void *ptr, Error **errp) -{ - uint64_t pinfo; - uint64_t ret =3D -1; - uintptr_t addr =3D (uintptr_t) ptr; - uintptr_t pagesize =3D qemu_real_host_page_size(); - off_t offset =3D addr / pagesize * sizeof(pinfo); - int fd; - - fd =3D open("/proc/self/pagemap", O_RDONLY); - if (fd =3D=3D -1) { - error_setg_errno(errp, errno, "Cannot open /proc/self/pagemap"); - return -1; - } - - /* Force copy-on-write if necessary. */ - qatomic_add((uint8_t *)ptr, 0); - - if (pread(fd, &pinfo, sizeof(pinfo), offset) !=3D sizeof(pinfo)) { - error_setg_errno(errp, errno, "Cannot read pagemap"); - goto out; - } - if ((pinfo & (1ull << 63)) =3D=3D 0) { - error_setg(errp, "Page not present"); - goto out; - } - ret =3D (pinfo & 0x007fffffffffffffull) * pagesize; - ret |=3D addr & (pagesize - 1); - -out: - close(fd); - return ret; -} - -void hmp_gpa2hpa(Monitor *mon, const QDict *qdict) -{ - hwaddr addr =3D qdict_get_int(qdict, "addr"); - Error *local_err =3D NULL; - MemoryRegion *mr =3D NULL; - void *ptr; - uint64_t physaddr; - - ptr =3D gpa2hva(&mr, addr, 1, &local_err); - if (local_err) { - error_report_err(local_err); - return; - } - - physaddr =3D vtop(ptr, &local_err); - if (local_err) { - error_report_err(local_err); - } else { - monitor_printf(mon, "Host physical address for 0x%" HWADDR_PRIx - " (%s) is 0x%" PRIx64 "\n", - addr, mr->name, (uint64_t) physaddr); - } - - memory_region_unref(mr); -} -#endif diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c index 33a88ce205a..f7ff6ec90ec 100644 --- a/monitor/hmp-cmds.c +++ b/monitor/hmp-cmds.c @@ -17,9 +17,11 @@ #include "system/address-spaces.h" #include "system/ioport.h" #include "exec/gdbstub.h" +#include "exec/target_page.h" #include "gdbstub/enums.h" #include "monitor/hmp.h" #include "qemu/help_option.h" +#include "monitor/hmp-target.h" #include "monitor/monitor-internal.h" #include "qapi/error.h" #include "qapi/qapi-commands-control.h" @@ -28,7 +30,10 @@ #include "qobject/qdict.h" #include "qemu/cutils.h" #include "qemu/log.h" +#include "system/hw_accel.h" +#include "system/memory.h" #include "system/system.h" +#include "disas/disas.h" =20 bool hmp_handle_error(Monitor *mon, Error *err) { @@ -435,3 +440,352 @@ void hmp_dumpdtb(Monitor *mon, const QDict *qdict) monitor_printf(mon, "DTB dumped to '%s'\n", filename); } #endif + +/* Set the current CPU defined by the user. Callers must hold BQL. */ +int monitor_set_cpu(Monitor *mon, int cpu_index) +{ + CPUState *cpu; + + cpu =3D qemu_get_cpu(cpu_index); + if (cpu =3D=3D NULL) { + return -1; + } + g_free(mon->mon_cpu_path); + mon->mon_cpu_path =3D object_get_canonical_path(OBJECT(cpu)); + return 0; +} + +/* Callers must hold BQL. */ +static CPUState *mon_get_cpu_sync(Monitor *mon, bool synchronize) +{ + CPUState *cpu =3D NULL; + + if (mon->mon_cpu_path) { + cpu =3D (CPUState *) object_resolve_path_type(mon->mon_cpu_path, + TYPE_CPU, NULL); + if (!cpu) { + g_free(mon->mon_cpu_path); + mon->mon_cpu_path =3D NULL; + } + } + if (!mon->mon_cpu_path) { + if (!first_cpu) { + return NULL; + } + monitor_set_cpu(mon, first_cpu->cpu_index); + cpu =3D first_cpu; + } + assert(cpu !=3D NULL); + if (synchronize) { + cpu_synchronize_state(cpu); + } + return cpu; +} + +CPUState *mon_get_cpu(Monitor *mon) +{ + return mon_get_cpu_sync(mon, true); +} + +CPUArchState *mon_get_cpu_env(Monitor *mon) +{ + CPUState *cs =3D mon_get_cpu(mon); + + return cs ? cpu_env(cs) : NULL; +} + +int monitor_get_cpu_index(Monitor *mon) +{ + CPUState *cs =3D mon_get_cpu_sync(mon, false); + + return cs ? cs->cpu_index : UNASSIGNED_CPU_INDEX; +} + +void hmp_info_registers(Monitor *mon, const QDict *qdict) +{ + bool all_cpus =3D qdict_get_try_bool(qdict, "cpustate_all", false); + int vcpu =3D qdict_get_try_int(qdict, "vcpu", -1); + CPUState *cs; + + if (all_cpus) { + CPU_FOREACH(cs) { + monitor_printf(mon, "\nCPU#%d\n", cs->cpu_index); + cpu_dump_state(cs, NULL, CPU_DUMP_FPU | CPU_DUMP_VPU); + } + } else { + cs =3D vcpu >=3D 0 ? qemu_get_cpu(vcpu) : mon_get_cpu(mon); + + if (!cs) { + if (vcpu >=3D 0) { + monitor_printf(mon, "CPU#%d not available\n", vcpu); + } else { + monitor_printf(mon, "No CPU available\n"); + } + return; + } + + monitor_printf(mon, "\nCPU#%d\n", cs->cpu_index); + cpu_dump_state(cs, NULL, CPU_DUMP_FPU | CPU_DUMP_VPU); + } +} + +static void memory_dump(Monitor *mon, int count, int format, int wsize, + uint64_t addr, bool is_physical) +{ + int l, line_size, i, max_digits, len; + uint8_t buf[16]; + uint64_t v; + CPUState *cs =3D mon_get_cpu(mon); + const unsigned int addr_width =3D is_physical ? 8 : (target_long_bits(= ) * 2); + const bool big_endian =3D target_big_endian(); + + if (!cs && (format =3D=3D 'i' || !is_physical)) { + monitor_printf(mon, "Can not dump without CPU\n"); + return; + } + + if (format =3D=3D 'i') { + monitor_disas(mon, cs, addr, count, is_physical); + return; + } + + len =3D wsize * count; + if (wsize =3D=3D 1) { + line_size =3D 8; + } else { + line_size =3D 16; + } + max_digits =3D 0; + + switch (format) { + case 'o': + max_digits =3D DIV_ROUND_UP(wsize * 8, 3); + break; + default: + case 'x': + max_digits =3D (wsize * 8) / 4; + break; + case 'u': + case 'd': + max_digits =3D DIV_ROUND_UP(wsize * 8 * 10, 33); + break; + case 'c': + wsize =3D 1; + break; + } + + while (len > 0) { + monitor_printf(mon, "%0*" PRIx64 ":", addr_width, addr); + l =3D len; + if (l > line_size) { + l =3D line_size; + } + if (is_physical) { + AddressSpace *as =3D cs ? cs->as : &address_space_memory; + MemTxResult r =3D address_space_read(as, addr, + MEMTXATTRS_UNSPECIFIED, buf= , l); + if (r !=3D MEMTX_OK) { + monitor_printf(mon, " Cannot access memory\n"); + break; + } + } else { + if (cpu_memory_rw_debug(cs, addr, buf, l, 0) < 0) { + monitor_printf(mon, " Cannot access memory\n"); + break; + } + } + i =3D 0; + while (i < l) { + switch (wsize) { + default: + case 1: + v =3D ldub_p(buf + i); + break; + case 2: + v =3D (big_endian ? lduw_be_p : lduw_le_p)(buf + i); + break; + case 4: + v =3D (uint32_t)(big_endian ? ldl_be_p : ldl_le_p)(buf + i= ); + break; + case 8: + v =3D (big_endian ? ldq_be_p : ldq_le_p)(buf + i); + break; + } + monitor_printf(mon, " "); + switch (format) { + case 'o': + monitor_printf(mon, "0%*" PRIo64, max_digits, v); + break; + case 'x': + monitor_printf(mon, "0x%0*" PRIx64, max_digits, v); + break; + case 'u': + monitor_printf(mon, "%*" PRIu64, max_digits, v); + break; + case 'd': + monitor_printf(mon, "%*" PRId64, max_digits, v); + break; + case 'c': + monitor_printc(mon, v); + break; + } + i +=3D wsize; + } + monitor_printf(mon, "\n"); + addr +=3D l; + len -=3D l; + } +} + +void hmp_memory_dump(Monitor *mon, const QDict *qdict) +{ + int count =3D qdict_get_int(qdict, "count"); + int format =3D qdict_get_int(qdict, "format"); + int size =3D qdict_get_int(qdict, "size"); + vaddr addr =3D qdict_get_int(qdict, "addr"); + + memory_dump(mon, count, format, size, addr, false); +} + +void hmp_physical_memory_dump(Monitor *mon, const QDict *qdict) +{ + int count =3D qdict_get_int(qdict, "count"); + int format =3D qdict_get_int(qdict, "format"); + int size =3D qdict_get_int(qdict, "size"); + hwaddr addr =3D qdict_get_int(qdict, "addr"); + + memory_dump(mon, count, format, size, addr, true); +} + +void *gpa2hva(MemoryRegion **p_mr, hwaddr addr, uint64_t size, Error **err= p) +{ + Int128 gpa_region_size; + MemoryRegionSection mrs =3D memory_region_find(get_system_memory(), + addr, size); + + if (!mrs.mr) { + error_setg(errp, + "No memory is mapped at address 0x%" HWADDR_PRIx, addr); + return NULL; + } + + if (!memory_region_is_ram(mrs.mr) && !memory_region_is_romd(mrs.mr)) { + error_setg(errp, + "Memory at address 0x%" HWADDR_PRIx " is not RAM", addr= ); + memory_region_unref(mrs.mr); + return NULL; + } + + gpa_region_size =3D int128_make64(size); + if (int128_lt(mrs.size, gpa_region_size)) { + error_setg(errp, "Size of memory region at 0x%" HWADDR_PRIx + " exceeded.", addr); + memory_region_unref(mrs.mr); + return NULL; + } + + *p_mr =3D mrs.mr; + return qemu_map_ram_ptr(mrs.mr->ram_block, mrs.offset_within_region); +} + +void hmp_gpa2hva(Monitor *mon, const QDict *qdict) +{ + hwaddr addr =3D qdict_get_int(qdict, "addr"); + Error *local_err =3D NULL; + MemoryRegion *mr =3D NULL; + void *ptr; + + ptr =3D gpa2hva(&mr, addr, 1, &local_err); + if (local_err) { + error_report_err(local_err); + return; + } + + monitor_printf(mon, "Host virtual address for 0x%" HWADDR_PRIx + " (%s) is %p\n", + addr, mr->name, ptr); + + memory_region_unref(mr); +} + +void hmp_gva2gpa(Monitor *mon, const QDict *qdict) +{ + vaddr addr =3D qdict_get_int(qdict, "addr"); + CPUState *cs =3D mon_get_cpu(mon); + hwaddr gpa; + + if (!cs) { + monitor_printf(mon, "No cpu\n"); + return; + } + + gpa =3D cpu_get_phys_page_debug(cs, addr & TARGET_PAGE_MASK); + if (gpa =3D=3D -1) { + monitor_printf(mon, "Unmapped\n"); + } else { + monitor_printf(mon, "gpa: 0x%" HWADDR_PRIx "\n", + gpa + (addr & ~TARGET_PAGE_MASK)); + } +} + +#ifdef CONFIG_LINUX +static uint64_t vtop(void *ptr, Error **errp) +{ + uint64_t pinfo; + uint64_t ret =3D -1; + uintptr_t addr =3D (uintptr_t) ptr; + uintptr_t pagesize =3D qemu_real_host_page_size(); + off_t offset =3D addr / pagesize * sizeof(pinfo); + int fd; + + fd =3D open("/proc/self/pagemap", O_RDONLY); + if (fd =3D=3D -1) { + error_setg_errno(errp, errno, "Cannot open /proc/self/pagemap"); + return -1; + } + + /* Force copy-on-write if necessary. */ + qatomic_add((uint8_t *)ptr, 0); + + if (pread(fd, &pinfo, sizeof(pinfo), offset) !=3D sizeof(pinfo)) { + error_setg_errno(errp, errno, "Cannot read pagemap"); + goto out; + } + if ((pinfo & (1ull << 63)) =3D=3D 0) { + error_setg(errp, "Page not present"); + goto out; + } + ret =3D (pinfo & 0x007fffffffffffffull) * pagesize; + ret |=3D addr & (pagesize - 1); + +out: + close(fd); + return ret; +} + +void hmp_gpa2hpa(Monitor *mon, const QDict *qdict) +{ + hwaddr addr =3D qdict_get_int(qdict, "addr"); + Error *local_err =3D NULL; + MemoryRegion *mr =3D NULL; + void *ptr; + uint64_t physaddr; + + ptr =3D gpa2hva(&mr, addr, 1, &local_err); + if (local_err) { + error_report_err(local_err); + return; + } + + physaddr =3D vtop(ptr, &local_err); + if (local_err) { + error_report_err(local_err); + } else { + monitor_printf(mon, "Host physical address for 0x%" HWADDR_PRIx + " (%s) is 0x%" PRIx64 "\n", + addr, mr->name, (uint64_t) physaddr); + } + + memory_region_unref(mr); +} +#endif diff --git a/monitor/meson.build b/monitor/meson.build index a71523a1ce8..2647100e04c 100644 --- a/monitor/meson.build +++ b/monitor/meson.build @@ -9,4 +9,4 @@ system_ss.add(files( system_ss.add([spice_headers, files('qmp-cmds.c')]) =20 specific_ss.add(when: 'CONFIG_SYSTEM_ONLY', - if_true: [files( 'hmp-cmds-target.c', 'hmp-target.c'), spice]) + if_true: [files('hmp-target.c'), spice]) --=20 2.52.0 From nobody Wed Jan 7 09:26:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767129057; cv=none; d=zohomail.com; s=zohoarc; b=jbxRJU2gbo0TN4FZD0JbFdznEk3D2rrMdmekj8awIFug0i6wIjD6W+188ruAlhkK3JwvLZ61QpIlIjv9AnQO5ND3fl4h8q201UoRNGfJZuuyQbeDIVlIQyBoyLJ6mY7VkwTq7mUe9/uIFGSMyV3SLklVHgFh8RRGkNR5NQgnWAk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767129057; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=DgIrNp2Q4FL23fByvzV3YdB6W+rarWqyshGf/QdgOu8=; b=Z7+VP08rONWGSrLrUYGpDZwlx5+ggw4D1VROG0r1AqqsQEPVssyKHtB6aM8SFxZPMwGWa0YeKBouQP37TNvJSpfQIglODhiMPqTcZNWoKEjcgprI7NeViy4o+i/PzKG+BHTGZf4hsM79Kt3U/rtL/q7pghGm52gmGxb9l0GlrrI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17671290575811003.5748632580846; Tue, 30 Dec 2025 13:10:57 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vagyQ-00080c-Un; Tue, 30 Dec 2025 16:09:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vagy2-0006lL-Jf for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:09:25 -0500 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vagxz-0002K5-Pz for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:09:21 -0500 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-47d3ffa6720so43813495e9.0 for ; Tue, 30 Dec 2025 13:09:19 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d193cbe58sm611524755e9.9.2025.12.30.13.09.17 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Dec 2025 13:09:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767128958; x=1767733758; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=DgIrNp2Q4FL23fByvzV3YdB6W+rarWqyshGf/QdgOu8=; b=AbeUaTrWHzILkrYCdNagTkycNHLDbyF7kwNXYOlWMejqRa/mhNlIhhxWfREP9/8jJq 1ugDFK10Zni9e9sF/K+Mza0uTGYhwIP4mCYwUfmZrxoTvxuvpGhBOfboql8KqPc5yEmA 2J0Af2YZCZ/tbThTn5OhBYupxC3ONbx9P7GOpjzXsoxxh0WnjwZz5gt2daiu+26Nn5yH RTnQSFjaXU0pVSYXKiee/ek1PsXYO4yzqH8MB+sKCv4xgm5vJDdQ6gYzohjS50hrP0Jd dH053lAfeSVOLDNPs7PUaTsJQB7VoIxvZMLxhEfNJpr+AuXN9WNP113LTMq4Qq/cdhTE Ro8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767128958; x=1767733758; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=DgIrNp2Q4FL23fByvzV3YdB6W+rarWqyshGf/QdgOu8=; b=vfK0+MaPEPImsCvxMkFHdLR7+RQRT1oPdlsrCOqSTWv4GNPkYph5qyioj1hgh4SKMI Z4NvAuJYCLjv0gfIWZvtsP1Z8NtAkdayYtKSvx1621Wy4qROeCIdnIiXaMXG0aB8YxPS H+0QCeMERzWokc0SddJrYcmQMmv5oaFZhnDVZ8wKEgBeh6hNR7iafRM/YXqYgjMc4H3r Tih/5V25OmjZP4n4AXVHXercxTJqScAUeFoTperwIUjXvkkge+eeDeSuh9FTR0kMz866 mLkx2UmgjiTeUZjCoFOLl+h+sDcf0GeOa6gVBgMy3OhbHLeE7rxwknuttZG3oIKMc7rJ qJ+Q== X-Gm-Message-State: AOJu0YySZ3KGVyBtj7qAfZwJSHwf6Zq4lcb2o8HJE3g0EYsnKn5B+bh+ Gf0+fqrDKJJCUCgoZalTrHwY6poQCwz7a1XtjZCP4wszVBZyv1uugEqclUq2N73a+7/9VjhwN7O EcM3jOP8= X-Gm-Gg: AY/fxX4OYYbgt/eTfQeGsFN2KDTgruUShoOOGXkXeskVznDX0bv1eRGLprFvqEGU9oX NaihgIDHjheADwrhjwx1XSwO2OOAElCZsY+Wz+aziQEl8/e8G6H4DOb+KoGGVyQmqIu+B2vR6K/ 0y4uy/TgaaRltMc7pkFezFVUzOlWqyjn1XofNHd2dfFH6USn7tZLmD5hN/KWSgQBZjG8hrNPYGl XeoH9X05QSSFNpie3AW6kzqbXk2Y0EHqxiCsKqHz4XzWgb1xBmwhUcYtgn4LlWz3BtnJMGpVcRK E0Y4iJ5D+memDuAkd9pcGMddKhpkqGLMveVclpBLzIetxd/NcYIxJLGSQCUYGPQKJXTyGjDLcd3 t5X/FWV4qD/tvUqSHMn+8inM3093suEUoqw47LWZ1gXrYuJRh0vxRnzROZDdZiI2zOhiIgbful9 yvXgNgy9G/nkFr2FSXYIaoC4vvR8Mi6Egrl1CwkbD6FQg2NfTIWIVvIsshmfr3 X-Google-Smtp-Source: AGHT+IFPWEPE2P2Warughsbvvh4HvSsodSqsri/i/NSj+sSOlZY8AMbMZqqZaJLN2NHpHZBYV5sM5g== X-Received: by 2002:a05:600c:3584:b0:46e:59bd:f7d3 with SMTP id 5b1f17b1804b1-47d195a724bmr457324115e9.20.1767128957863; Tue, 30 Dec 2025 13:09:17 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 12/34] hw/arm/Kconfig: Have FSL_IMX6UL SoC select IMX_USBPHY Date: Tue, 30 Dec 2025 22:07:34 +0100 Message-ID: <20251230210757.13803-13-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251230210757.13803-1-philmd@linaro.org> References: <20251230210757.13803-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=philmd@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767129059521158500 Since commit 17372bd812d, the SoC used by the mcimx6ul-evk machine requires the IMX USB PHY component. As this component is only used by 2 machines, do not select it by default (it will be automatically selected when necessary). Fixes: 17372bd812d ("hw/arm/fsl-imx6ul: Wire up USB controllers") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Message-Id: <20251224134644.85582-2-philmd@linaro.org> --- hw/arm/Kconfig | 1 + hw/usb/Kconfig | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 78775063840..97d747e2062 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -638,6 +638,7 @@ config FSL_IMX6UL select IMX select IMX_FEC select IMX_I2C + select IMX_USBPHY select WDT_IMX2 select SDHCI select USB_CHIPIDEA diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig index 69c663be52f..de95686720c 100644 --- a/hw/usb/Kconfig +++ b/hw/usb/Kconfig @@ -132,7 +132,6 @@ config USB_CANOKEY =20 config IMX_USBPHY bool - default y depends on USB =20 config USB_DWC3 --=20 2.52.0 From nobody Wed Jan 7 09:26:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767128994; cv=none; d=zohomail.com; s=zohoarc; b=KIIW1KzDLLh9/K7zJDS9wxU8EqnkGgoHSgpgg3ILtAo0UtPkV9AapkAOx0HqEjtVMo2elKn8qGvqDR11mFFLCoevk4UdfLrYqU30/+N/4r69Xku8J6L0dhy1aTnafZtLW6xgNWMBc1a3hInbc0OGV3m0fNBG/ZhFzfvZNxSX7wU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767128994; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=O8snffjzsXivY+VrMCvVGRQf0hPgiUgCcuP0Hn1j+LY=; b=bsW7vfAJ+Wgba+37h43AO04HEkgDewUulJ8/afwMuh9m4Bcd6Z132ejl7yisDEHNFPWMOaWOLbU6Nam7XiG4KZem3JC97k9eKBXPkJsBV3W7dZEQ1FjVrTec2ajiH7c/KaKUq0kp/IVP+dgkaQTQkfHNNd24/3T+ZBQlvqdGvdw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767128994991137.99889789770236; Tue, 30 Dec 2025 13:09:54 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vagyN-0007MI-CL; Tue, 30 Dec 2025 16:09:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vagy9-0006pk-9y for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:09:32 -0500 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vagy6-0002Kd-Bx for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:09:29 -0500 Received: by mail-wm1-x344.google.com with SMTP id 5b1f17b1804b1-477563e28a3so62836695e9.1 for ; Tue, 30 Dec 2025 13:09:26 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d193cba81sm601445195e9.10.2025.12.30.13.09.23 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Dec 2025 13:09:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767128964; x=1767733764; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=O8snffjzsXivY+VrMCvVGRQf0hPgiUgCcuP0Hn1j+LY=; b=CowzSSeTLmlEtl2iXBO/3EZ4nPWpLERq+F0hKBY8TytoPcQSS8S238O3U4L7NOwEzY sC6BdX2Ty6vvRsg+OTQmAzCErvd1i54CjHw6QeWczLStB0AvyElEDyU2H1YctEejoexV 8sNJMUYRJ5iOBK7wR4Ysk/+n5mMiKcj7y1Hw928gASgBUAmo91J0rNaTFv08ag+3AcNP ilMD+bcIi50mSumSKCt173oeopIjgSdPL1j92mZuwPT1PBpWSJXXmhYPsDrbsX6QsM6S xl0SSwspQSv52E4ugrPUKSKGHLXdifKuvMJGfJb/1lpbC31vLddyr/3whslBRSuAw6yr 4RQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767128964; x=1767733764; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=O8snffjzsXivY+VrMCvVGRQf0hPgiUgCcuP0Hn1j+LY=; b=t7/OI0YQaIPoI9ibjFYcZsEgI0vFeiwxoS5M/SvOSfdcULJU3vr8uanjS/9R9QBfQ2 dgD8CLjSR4X8SPbxe3+r8Pr9+qHVHioYsdS/mgf1WwRleZ/8MU+RNU78k7BH6zgTdnAU ZXdYzTbzBbsFqZ9lqnCTAIL7R/AR1jZH7t8TTMqAx3mDPw2DLl9iCMJGSvgIpBYbcu5X 9tPOg3AKa123lWWGZ9rAQ60KPgY3tGSXfsfvYWjrSwbo8b79URHuRnKhG39L4Av4ddzW 69IwLF6JYiPefk3gEIhecNwCpjMt+XkTIIen9wqAhm+6+5OJ3gJ24Avntvbs6qdb3ldN tadA== X-Gm-Message-State: AOJu0Yz3TKx15vZFq4oXXPUlv6Ez/M1SH4DVMCZe+bJnYgAyElF4cbrw YQvkMhlUno18Q05m/laAnoaerPDUFEJpxS8G33m6PHkCg2Trk4HWaAXcupz4KMkyO7RzHT1oTMM VwNzMJ5Je4w== X-Gm-Gg: AY/fxX7YSFZ7JlSO84OlqF9tXNtPF87QO6Em2AuVNygh5+BNi8xHzHknHRYMY4rn95L 7JubJnvxbWEi4TV7Naz/GhUcDjOHjCSJjSwCt+knbn0fkQ3hdNrjJBuWDPZ/sVB8Pr1AlZAarbG 9oA8aCJJS3Pu5dGBAuKImdYtfJMAa69RwN/TeEMm/MNG70r9HWI/o2KmeUAdeYKf/hGYJ7L3ON+ L0gl/eJ8/kWOihcMat6Og0idl8cod/jKE2QsOHobWIe7DrqsLEzHzVqdDn5qH29/mAa9hblgEqb nr2Zu8roOKJFYzgxXpsf5+M0xPSrLI+mRtE1OcrGBby6g3pfl2vO+oklRhq6imIjhseXi3rqeI8 RGXMfAjo7+yptKV1jgmKISroOgz3IlE1j+ccmTGWOyiTONSaAv9FOdy4EAd0jDFMp4H/8/0yVCO n0azvxlUWxrF+vlU2iYHDoinlSRQsP0U4gNdayRD4Ztk8GUXrlPudCjmPfDqgPzA1g08qsu88= X-Google-Smtp-Source: AGHT+IEPtTkrXnXhRPm8BP0968p2YnVr1BxfbkhxAheNo5shjVnpHKIvMLJpOFNQBOi9vJiFXmGH9A== X-Received: by 2002:a05:600c:8718:b0:477:9d88:2da6 with SMTP id 5b1f17b1804b1-47d18b0ad6fmr398817425e9.0.1767128964259; Tue, 30 Dec 2025 13:09:24 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 13/34] hw/net/opencores: Clarify MMIO read/write handlers expect 32-bit access Date: Tue, 30 Dec 2025 22:07:35 +0100 Message-ID: <20251230210757.13803-14-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251230210757.13803-1-philmd@linaro.org> References: <20251230210757.13803-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::344; envelope-from=philmd@linaro.org; helo=mail-wm1-x344.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767128995352158500 The read/write handlers access array of 32-bit register by index: 277 struct OpenEthState { .. 287 uint32_t regs[REG_MAX]; .. 291 }; 546 static uint64_t open_eth_reg_read(void *opaque, 547 hwaddr addr, unsigned int size) 548 { .. 551 OpenEthState *s =3D opaque; 552 unsigned idx =3D addr / 4; .. 559 v =3D s->regs[idx]; .. 563 return v; 564 } This is a 32-bit implementation. Make that explicit in the MemoryRegionOps structure (this doesn't change the maximum access size, which -- being unset -- is 64-bit). Move the structure just after the handlers to ease code review. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20251224134644.85582-3-philmd@linaro.org> --- hw/net/opencores_eth.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/hw/net/opencores_eth.c b/hw/net/opencores_eth.c index 6abeffcc9c7..a25f8eccff3 100644 --- a/hw/net/opencores_eth.c +++ b/hw/net/opencores_eth.c @@ -683,6 +683,15 @@ static void open_eth_reg_write(void *opaque, } } =20 +static const MemoryRegionOps open_eth_reg_ops =3D { + .read =3D open_eth_reg_read, + .write =3D open_eth_reg_write, + .impl =3D { + .min_access_size =3D 4, + .max_access_size =3D 4, + }, +}; + static uint64_t open_eth_desc_read(void *opaque, hwaddr addr, unsigned int size) { @@ -706,12 +715,6 @@ static void open_eth_desc_write(void *opaque, open_eth_check_start_xmit(s); } =20 - -static const MemoryRegionOps open_eth_reg_ops =3D { - .read =3D open_eth_reg_read, - .write =3D open_eth_reg_write, -}; - static const MemoryRegionOps open_eth_desc_ops =3D { .read =3D open_eth_desc_read, .write =3D open_eth_desc_write, --=20 2.52.0 From nobody Wed Jan 7 09:26:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767129035; cv=none; d=zohomail.com; s=zohoarc; b=b4TuUnGexdHC6CC+/asUiYSsvA8km2qSY3uLws0IGkIhdhvC+jF3oOyPVBDLwOkkXEv+vZf9pmlVReZIGg2C898MMHJzfJ9yX4CJ8h26UITW/IABFfyflsV4AoeNKnZH5PUS6sh94c2BzPm3dOG5BDpsLJvYZOzhtvn+lgPB8Vo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767129035; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=mJcdNi7cESlpTXpcLSi0wl3ojZ5ipv+IdVxBLAwJeR8=; b=hog36VJG1u7+GmNDkCnot0dmhcES68VaP745WkusYduNz6F+uJYbZEO6ErAIfx/OrYIT0VLWO+auxj+sGEu5e1HNZ4sI9ZOGpHGNN0BN7h4A0plxuUgr44mDnQx9HhfOihXpfjAt9wKCIhDeII56j9z+063ifVJYTe+Cc3UrKdA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176712903579121.629747988224267; Tue, 30 Dec 2025 13:10:35 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vagyR-00085k-Ke; Tue, 30 Dec 2025 16:09:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vagyG-00070k-9x for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:09:40 -0500 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vagyC-0002LB-Ju for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:09:34 -0500 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-42b3b0d76fcso5904531f8f.3 for ; Tue, 30 Dec 2025 13:09:32 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea1b1bdsm69743829f8f.8.2025.12.30.13.09.30 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Dec 2025 13:09:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767128971; x=1767733771; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=mJcdNi7cESlpTXpcLSi0wl3ojZ5ipv+IdVxBLAwJeR8=; b=vYVEv5KCPXwJ9ZlH5yTvnpoHT++KQa7WYPR112pzGq/+DZlqHBhDVb9bpWezrzmewJ 6OlTJD6sphvi9KiLM6qORnT6Ft13BsCz3TYGiNrYMofsxVNxsjXWFq3kR5atB21bSRym 90unBmp1QenGwKA0eBXJgMPo3V0zccIOugTLc0ZjMTilVOuWJGQzbO2YmqfFMhcw1wxE FX8qzXwXIus89Z9HWU/EOB3+xinq/xmZnFIHjuy4ARcbwvc4npSJ8iR39AKaQpPZ7SFg dMU+Qz3WX8g7wVVWskFgxiyx/ZvcQS+1BhdLQaPVK3UTYQX01DI83EKz352YfY/vCmND g+tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767128971; x=1767733771; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=mJcdNi7cESlpTXpcLSi0wl3ojZ5ipv+IdVxBLAwJeR8=; b=MNCjWY3KwwIf9DPymNYK1fdBm+w401oljJ+2tY4ijGDfEzQJC14fPW67yiVfs4pArl Fw7x/Ek6bVh5bNUaOBDyWqBf9RwtK2vp2Ig8rnihmp7JTFsBHxdRx/WukDW7rmXL1oV3 oW4o45mBFXRbpEIuDkQtiNBcgW4ezigZMBjAzB4tyWFSdM5gK5FX5WH0vfymnAG6oVJb 9aWmCwdZuQCBG5fMiW0IC3PKiyoM0uRlHjEjxLtR5PXYCZhHfJLsQ61tcOzJp762m4oE GpoSpoXIQrMAM2HRZXaOtNXEsDT1Ll5U+LMEdR63hW8bnasPxmSlIO4YtAPCnRyRhaFV mTPA== X-Gm-Message-State: AOJu0YyUVhVI3tysHUbQlbga4+DsIxK49Aj9OmPwS23frgiVfoNVhrne jtbjybgqDbr0wGktDXp6+TAGjMm4tf955Z97L8q/2xDV+O9XjYgB4QMkY2nadYKjO0Ccc2f++iY T79jmC38= X-Gm-Gg: AY/fxX6lkdFIJy3Hl9wQSoUVK23qTiSe69DcgWOMmUhWGKYfqjmbDfamSRUNqY/fBoN 7Z+JqG5hMLqbJycr4tCPaaOEsCwejonG41l7xUJcuO6MiHj00dN4JC5TieI7xVLOET9ZHfQDz+w DdDGUw4SOtQaQ5hHIYWsPXB8nE0T1oQwVSH2wv4eCckcuQJ0Ecv7/hhIDTBhWX8qbEesEJiPKIK YkMi+dqZOHlRPQJawTp+AyYPUSvG3wtmIPPUFmoAE9mz+6tTq649YVhPu/FKO2YPQ8vjSUxawp2 Y86V4y4cCKh7ZhwZoB7kF9z6rLiS8p+HkchFsAoYXVwwTn5DtUiP6Pi/bcduCbPrkriasl0qfb5 A53LOM47sIQLN6JypVDkluABtZkaphquQQPy9Pxs1xCKFzRHDpp+Tc/7ag2kd4jVBwYl7Dm1RMV d/cOHITnNlDNL/6esjD16q0SL0ZawacSx/D7wKPD2EX1/no72YKrJ25iOgtYiQ X-Google-Smtp-Source: AGHT+IE3Tp52NTXgfyzTAuLHeHcKPhMhAKpArIzI4SA60Exwe7ML8nk7xXTWUGybBbXSM9+B1eelFg== X-Received: by 2002:a05:6000:2002:b0:430:fdfc:7dd0 with SMTP id ffacd0b85a97d-4324e714856mr39491042f8f.63.1767128970756; Tue, 30 Dec 2025 13:09:30 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 14/34] hw/char/serial: Let compiler pick serial_mm_ops[] array length Date: Tue, 30 Dec 2025 22:07:36 +0100 Message-ID: <20251230210757.13803-15-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251230210757.13803-1-philmd@linaro.org> References: <20251230210757.13803-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=philmd@linaro.org; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767129037390158500 No need to enforce the MemoryRegionOps array length. We index by device_endian enum, the compiler will easily pick the correct length. Besides, this allow further adjustments in the device_endian enum itself. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20251224134644.85582-4-philmd@linaro.org> --- hw/char/serial-mm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/char/serial-mm.c b/hw/char/serial-mm.c index 6e963e581f9..0e0be26fa9f 100644 --- a/hw/char/serial-mm.c +++ b/hw/char/serial-mm.c @@ -44,7 +44,7 @@ static void serial_mm_write(void *opaque, hwaddr addr, serial_io_ops.write(&s->serial, addr >> s->regshift, value, 1); } =20 -static const MemoryRegionOps serial_mm_ops[3] =3D { +static const MemoryRegionOps serial_mm_ops[] =3D { [DEVICE_NATIVE_ENDIAN] =3D { .read =3D serial_mm_read, .write =3D serial_mm_write, --=20 2.52.0 From nobody Wed Jan 7 09:26:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767129028; cv=none; d=zohomail.com; s=zohoarc; b=AyA6CzxPBthwDmvrtI8QJJdMxmEiYC17EonsPjKs9JT0dxyAybdqZrb6mWrnpzYYKli+xzsjCpOKTBvmlh0eBt0TqSz4uaPsB57ccrW6Z7l8wX2oqEgAV5eeav17hurHxTPgNwV6ezGG2ENTs8ujaPyYBhYtnpgRRpHINjzfgIo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767129028; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=ATjngnnV3ksOsOxX3aLV+GZq9KCpLPtZIU5jqLOQRSk=; b=CAV9xGpggBrfHupLGqEDzazuz/SxSCGrkhng6+HrGIE/7NQ5g1p6w0+QFe0MyLc2spUL8d6bBiiVF/4eZs/vkBSsPIfBMVvzhqTGCwx3HEll4qfTtJ8eaSHVnwTemprvnfrWDiwhWgNyfWIo8bpOMUEoh0KqQLOqB9jqSGuaZNg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767129028367575.4710110688874; Tue, 30 Dec 2025 13:10:28 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vagyQ-0007qJ-1Y; Tue, 30 Dec 2025 16:09:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vagyL-0007D9-GO for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:09:42 -0500 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vagyK-0002Lr-3W for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:09:41 -0500 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-4775ae5684fso33770325e9.1 for ; Tue, 30 Dec 2025 13:09:38 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be27b0d5asm673737575e9.13.2025.12.30.13.09.36 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Dec 2025 13:09:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767128977; x=1767733777; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=ATjngnnV3ksOsOxX3aLV+GZq9KCpLPtZIU5jqLOQRSk=; b=OTLKwpjr97unswQrQ2PN6ywYi4ausOhtdFEtaVsetAAU7uijC9ioUIz4/fyhz1ablt dUhGT7ON0q5GlsC3fjYZp/1OtvVLVE/TMk5NEdfbCVZQqskPy2N5g/n3dJGojtVrDsqA lsdGHIbFvjH1vXn0KSL2cRD40aGKhgv5LPV8isV2SFwwfrrJyrR7id889doXiefHCJPp JM9D+wHzAM3bsDeuG2XRFtjCPRh0X8xZu/ZMIViMaafDfR5MhYjEy04a6UFNLpQcogVe metbS6lm+lXI6SXDSTI/HLTGvaiMe2rAp6hqiZfIycUX7djYyri5/aBMXUFsG8o4cQZz 9n8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767128977; x=1767733777; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ATjngnnV3ksOsOxX3aLV+GZq9KCpLPtZIU5jqLOQRSk=; b=ot9nSGzl70akdAkmiAp8x4mB0NMOmggaeZKtB85znQ/1ZjyJ/5RWlKwinFlan6SbUA lXXhIXy7fGTn8nF1SHNhFNUhvgZzNk7FO0SaqAzp0/c8OxcMCJEdI7OSHJ0Bw0t5UyU9 vZfvvxn1devHiIR6K7/sp3HuVZ4Hj8q511N65ZTNhH2HWIfIKSmlthN1QBLJXuTZw7pR aR7reqml5jWO1UWm1PpLF3fg4YkBImsTzJ523plfFUfCBnvKGFK6uYodli9lI8ajfi+g 54bHWQ/k4zJyOqPxHa1WFNTSV8flHGudZzLM+X9N3G4BVKSKXKFEttDRkiZLd7zydYLM Qz6Q== X-Gm-Message-State: AOJu0YzlAtvUkDYX6EF61AwMrndA4j7U7aWnrMbgVGJbzB+g5dtL5Hpr CRhO9a0398NDlN14vIIYfvcpDLrK2LzWsPNfqk73It8D5IjoLLqf1AitONAPVl9eAMlEZqjs8tO b0xwoJ1M= X-Gm-Gg: AY/fxX6LfgqryzPD5uUXZs3jHnwBe32iOtjzx1QiBujRnfoxpCi5jxJbNuHB5YbJIdc /z5I8Im8tiqxTTP8yQomdAfjsb36Uy0ACIYleybYOl4+1CFI3BgJjlSRzxZwx3wtLreUa595LUc nebIDeIK8GpcEyKNx5XWbxM9xAxqfoTeOHu2M1M2JCcGbvrVXP55umLL+cST2D1/GvJejy0k9Q2 vkp6shYnl4kJWLKST5H6TyIJuFlDZrwBNt0GmU7wVE8IVJS+mHBc7WUNQZQM9tYribaF/XPZxCy KNUF3NtFcsMdeIXDFXIiBm1atgeuFvggPF1Hzr8jhPzKj7VWqZX+82GcGgKguEIi/RarG0Nj2vF ihSZfv5mAHYN0ZVcEwxeV/78mfF7MJGuhr6oCDaX5+T6HRrVAQwZm91gDUsEy51CTIqB8aHNhcl 8Mcz83zG2jVSKCEyN4swnHcWN2E304qbeBMj2HVKTxlVnUVl/zwCqmjkZ1BwOcRh+lYPv58ow= X-Google-Smtp-Source: AGHT+IHEGqnnYp1VrkiQl5isS5xjERQmK97xWcNN/IMuWGHSHxOZyDAruxVCa8w7lppInvGHpO4WYg== X-Received: by 2002:a05:600c:348a:b0:46e:1a5e:211 with SMTP id 5b1f17b1804b1-47d1958a755mr443284425e9.21.1767128977368; Tue, 30 Dec 2025 13:09:37 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 15/34] hw/misc/pvpanic: Expose MMIO interface as little-endian Date: Tue, 30 Dec 2025 22:07:37 +0100 Message-ID: <20251230210757.13803-16-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251230210757.13803-1-philmd@linaro.org> References: <20251230210757.13803-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=philmd@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767129029334158500 Make the PVPanic MMIO interface behave like the ISA and PCI variants: access it using little endianness. Fixes: a89607c4d0e ("hw/misc/pvpanic: Add MMIO interface") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Manos Pitsidianakis Message-Id: <20251224134644.85582-5-philmd@linaro.org> --- hw/misc/pvpanic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c index bbd06d9accd..f711ea10fd7 100644 --- a/hw/misc/pvpanic.c +++ b/hw/misc/pvpanic.c @@ -62,6 +62,7 @@ static void pvpanic_write(void *opaque, hwaddr addr, uint= 64_t val, } =20 static const MemoryRegionOps pvpanic_ops =3D { + .endianness =3D DEVICE_LITTLE_ENDIAN, .read =3D pvpanic_read, .write =3D pvpanic_write, .impl =3D { --=20 2.52.0 From nobody Wed Jan 7 09:26:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767129013; cv=none; d=zohomail.com; s=zohoarc; b=XQETKr8Q1yviBrmdj3I6Scn94ZZLz5H9sZrSRd2nNvrU0FSbaoKHx02SPBdgPIeU6oyjK1noOnLOeZJKELEsqDn8W6n22TrD4VIKmRj6u/g5zMVb3V+DdyC/Wt/4jJFq4I1GyCzksIOq0u+AhlTHn57CmtKQeoFfmbc+dj7TSHU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767129013; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=R1scoqV8tAtwsz0ByFWcQqiBZXTYa+pUST9WI20B7OM=; b=G0EVsIBe0L2ge7yR+8ySkIVc59Gcy4fN3+HUC0G5PxH6+6U/4tqQL7/6RAOH1VtStL73iAkvKsOioOhgUILD1MCGWbNMOFy4gwQ7NlwcmFir6NnrdtC4Hi8k0bizsLuidB9LYwZ38Qkgkf/G9B6eFYFG4Azca2RfysIInPR4RiA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767129013539454.60054505050755; Tue, 30 Dec 2025 13:10:13 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vagyT-0008OP-IS; Tue, 30 Dec 2025 16:09:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vagyS-00089l-0j for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:09:48 -0500 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vagyQ-0002Mr-BA for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:09:47 -0500 Received: by mail-wm1-x342.google.com with SMTP id 5b1f17b1804b1-47a95efd2ceso92959075e9.2 for ; Tue, 30 Dec 2025 13:09:45 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea82f6asm72014694f8f.27.2025.12.30.13.09.43 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Dec 2025 13:09:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767128984; x=1767733784; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=R1scoqV8tAtwsz0ByFWcQqiBZXTYa+pUST9WI20B7OM=; b=u06YXZCvNrQ4lyPUyab9NWGsWNgDGFdljf8PybVvMdlEb3UO750rwUYa82YW0Eofxs IltcGw/Kbtu8oQD2FOEbKpo6JnPesaLmE27fOIsvKiVG6mPMXV8Fw1IDN09QRZQ4i8lj 4kv5CQqthUBDzX+ZkHgl7Wrhj4OWicR3tqcgJWn45KaCwFTwOhBQ7NrBVsePAoDxdeQS 005ukotvQwPLKdE7rGbOXXwsNotQLnHCtYwB+6R1zF62aGYLWcPqyUbJlLcBcI5DyrLJ QgkliJQozqKygsiFK6E4MJlEORh61D2LeEfJ2RiV3//+gt+2qcPNT8yDJLOX1VOZn/yC UVuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767128984; x=1767733784; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=R1scoqV8tAtwsz0ByFWcQqiBZXTYa+pUST9WI20B7OM=; b=UMig6vQQsLkohVYnR5lzMZIdNGqGj5Yg39RpT23eka9yX22Iqjiae9twFl37ZN3MJ/ NJ0l3yAHAO/HGnyr7ZIE94R6HBsZ3GAmmaFyJIgEfPboBNlYzmXHsxAWPXr8bg54WGCN FkLiAH7caoXgl0kaqz1eYDjyM+DeKwZivRihbOLCBWVOjtGwWUesXvDIVl6THAlx/sbq wyJKyNf9at7V5fXDE624lz6OAi57MWzhty0W3L44eZ8RcXviBQ3grqxnwumkngqzPm1E 4PrPER3iEM8kola+/W8T4HOJKwn9FSnImJswwj8vLUO+PzatM3ecDYrfZwK3qGorEPli RYnQ== X-Gm-Message-State: AOJu0YxxpvALzFmWFpMKOn1iRlrJs9pGaBOh2RRZWI3OLdPAT2DoLg25 l6C+kPQK+6q5NFIaNsrqFrCraG3FvU5deucFQQnJIdVFDv8kMZCy9vzQri6myZNM2HXRohBHu2D QajSTGqo= X-Gm-Gg: AY/fxX6tkywR4QuzneK2FM/mS9VRAE3fvgXjTvdHQbIqqBpr5PHcrIMJrx5vQeB0O/x 18olupdCAOFaR1s7PT7X9HzIAipVIo+E/DuD70nSpSTZF4Sae+XC359ZvGIjyNSFkujBbHm+sw5 cin0aBeCHH3SDkGG+3kqJ5vNONR3kY77V0Cr+GTy74c+Fp3gNPw6YkWHW+OYZMhzXZlFO0bo07q aCF0RwuXIwK9H8f72qn3+YGyrR9BIhStMpRi2I3IgZkj2fn51JDGTsUdnJZkSKAer6s2G/GbPfX eGpjyMhgCTgSstcQffAWIATZMwg7IXlj6ejxCo8oyyfJejBPqtmw543vjpKZA4dQajimgVRFych 5g3T7L05yCkN9MsXitlA7B2l4V4dzXjntu1nVwJeMeDMdgRyoB4jBMM3rFwhHuVPb8CIXhSBOIy eE/FLgL9mvEI6vbyFzpnF5UX63tWerGHRH/2v77A5EkiPsd9VlJW87fMGZjQhs X-Google-Smtp-Source: AGHT+IGydUl/lF67iiMs3RQTIaVUeXBTrPRlAC8WT0spYyVsHtccxuAEIr8wxnBaSEpkWfyISMrE3w== X-Received: by 2002:a05:600c:8208:b0:47b:d949:9ba9 with SMTP id 5b1f17b1804b1-47d19566f0dmr411510985e9.13.1767128983880; Tue, 30 Dec 2025 13:09:43 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 16/34] hw/timer/hpet: Mark implementation as being little-endian Date: Tue, 30 Dec 2025 22:07:38 +0100 Message-ID: <20251230210757.13803-17-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251230210757.13803-1-philmd@linaro.org> References: <20251230210757.13803-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::342; envelope-from=philmd@linaro.org; helo=mail-wm1-x342.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767129015312158500 The HPET component is only built / used by X86 targets, which are only built in little endianness. Thus we only ever built as little endian, never testing the big-endian possibility of the DEVICE_NATIVE_ENDIAN definition. Simplify by only keeping the little endian variant. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Zhao Liu Message-Id: <20251224134644.85582-6-philmd@linaro.org> --- hw/timer/hpet.c | 2 +- rust/hw/timer/hpet/src/device.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c index 070b40e7f67..0d7b8e0c7a3 100644 --- a/hw/timer/hpet.c +++ b/hw/timer/hpet.c @@ -648,7 +648,7 @@ static const MemoryRegionOps hpet_ram_ops =3D { .min_access_size =3D 4, .max_access_size =3D 8, }, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_LITTLE_ENDIAN, }; =20 static void hpet_reset(DeviceState *d) diff --git a/rust/hw/timer/hpet/src/device.rs b/rust/hw/timer/hpet/src/devi= ce.rs index 3166688e4e3..4757bf5fd55 100644 --- a/rust/hw/timer/hpet/src/device.rs +++ b/rust/hw/timer/hpet/src/device.rs @@ -763,7 +763,7 @@ unsafe fn init(mut this: ParentInit) { MemoryRegionOpsBuilder::::new() .read(&HPETState::read) .write(&HPETState::write) - .native_endian() + .little_endian() .valid_sizes(4, 8) .impl_sizes(4, 8) .build(); --=20 2.52.0 From nobody Wed Jan 7 09:26:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767129002; cv=none; d=zohomail.com; s=zohoarc; b=YHGQuHQJq/6wVBO8EygR2grvlW9Z4zSEZk0N7RlJxYZ8eqUMHC3ocp0ExHvu3z8RDJRnMXpcpJZ3GECGS9qzHgVAW7t/JK7/A6OMubaKGsAkEdVyrQjptBZ5360/yG5CQCKWlGXtOq3uMPPWHl0kqYw0IruOMaYk9NiEsRsadS4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767129002; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=UCJ7R+BMO8hWETAQauSDjMMyldf8uRW23MJ8WuvIvM0=; b=WOXbjQsMt5adIndiveVe1CUADDPZViFEu0MqMX3xyJkepK0nEl3pdKnEAFlfmBM5w6SHGJV5wEIhKCWWWKj5/wa8g4oQkA4Q78X9z3+rwaRJz6qyzr39eRILnhpWDD27v0SMHpcNxWzh0+1EgGumVwogfdBB2961wETewYGHWUA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767129002494476.380181152129; Tue, 30 Dec 2025 13:10:02 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vagyZ-0000Yu-46; Tue, 30 Dec 2025 16:09:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vagyX-0000T2-L5 for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:09:53 -0500 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vagyW-0002P1-9H for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:09:53 -0500 Received: by mail-wr1-x442.google.com with SMTP id ffacd0b85a97d-42fbad1fa90so8956875f8f.0 for ; Tue, 30 Dec 2025 13:09:51 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4325b6bfe88sm62446347f8f.19.2025.12.30.13.09.49 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Dec 2025 13:09:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767128990; x=1767733790; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=UCJ7R+BMO8hWETAQauSDjMMyldf8uRW23MJ8WuvIvM0=; b=Ulaw3jE/5/YU+ALVXPyO3dlLtG4HqBrNM+FgvDwtQOsTj22hgWPFiHCsSzyUDzTsWl rigGWA2yZDSxw9fJ/qV9qYQsKT9Jx2Baz2U+yPTVPyyjTzLLiDRDrNEBqYdy7XYplX/r gmUEnjnEIXYIYyRkq/M7cTqsK5K2jcZd8ndVMNBfGd6rCQo3RsSMqO5/VZVYk3e6HCy9 w5+cXRfGlgbYsMCh3sS9WfMylWoaxq632SsTMMHr0pTqwY8d8Ae7GhjVIUy6QMVRDCev QopG0JfED2ss7l/cI9wIPQHkTaPuk6gG3kaaZ/p8dLgJCpHxnjdYJh/1Eeq19dbV7MJ+ PPOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767128990; x=1767733790; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=UCJ7R+BMO8hWETAQauSDjMMyldf8uRW23MJ8WuvIvM0=; b=eI5En2lI9KGlMLN3AlHjwqYRe/HmD+TbbpA3YQJzLi5mqTBMnHCGdT2ZsVvj/Fh0AN QkHkw6FdXPyr3CWRQ5MFJH6aVushED4PCS8Lg23fDq3W8ybzJMBJemcN0BMd5IkgLm91 4V9b0iMyaMrjnNDbYgpSvj7euv4K7hVWlXHvBCyrJj0tgbCR12DBpizqbbIk5TvvQkom VHV3Z9PCyvCPNpsnccJAuAkCg8ErUqpezdcoBWBVTPNRQTPPB5CEXQ+MPSRpa4YOWB3q 6aeWZAG+23BzzaME8Dl1a9fnCyDmkMsLXLttXujHi++i7HKGL7CFpDVQr1SQ76y7nKKr tYpQ== X-Gm-Message-State: AOJu0Yy02ZDIvtBM1xxrhwPBbkijVX5Lv1NSEu2l4gAIP4pfUVCuycx+ HJjG9nL3dTv7QPmvDsaV53Cp0y1kXJ9Ymb2Mhd01uPbPI6CT1Fl/RTISoRBDO9BnL3s3r8yq0Q2 yw/ujxjI= X-Gm-Gg: AY/fxX5xOLzUXw8BscQl15KysYDEhC9ntWLE6jYoQrpHieQjt56oGWERGc0ygXbuna8 zS0gYv0C1lCPndYw2fOSVK85JJdF4ebZ3esJZM9fmpX80MqZhCnvOISdzQxPp5Fjq9nRgImyrl5 Q/Q/zsgl19PF1mYfNg3W5ARdEqkLsD9NxhP9VfermRrZUzoJ3kScHPYBfh5iaSAsSKqRWnmxwuR Llw6Piii2VuhQ8mSDV7gwp5zQio5kvaYMXdwMAzR/6QHnV+aywNSFLHOevsyrfaBrioDycTM2FE /8/2cBxn0nzm4qGrjdAjSLFa8rvqFjLAYX9DWByYWpm9woUM7xlRPWczXw/ojyXFvCF9nWRPF02 rR/6mbXfP8Bce2JSy1z/3TKGcbzaNQo2ICguTqZbGPmldnwvP/Lk6dCFU+RhSnope745rBWAJnP L7BZqfxt0jaWh3RzGZDid2HUXrzEYNl0WrKF7qmYvbtzQtL6gtNKvjolLeMEoG2f4IE6FR9ug= X-Google-Smtp-Source: AGHT+IGlSu+uK8XCdtzJEB/7lylqIBu7QbKWK6u8eTTEkJ1U6oNm0IoxPV4vo3+AlDpn4Cn8oKfg/A== X-Received: by 2002:a05:6000:200f:b0:430:f879:a0ee with SMTP id ffacd0b85a97d-4324e4c1259mr46160254f8f.5.1767128990297; Tue, 30 Dec 2025 13:09:50 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 17/34] hw/char/pl011: Mark implementation as being little-endian Date: Tue, 30 Dec 2025 22:07:39 +0100 Message-ID: <20251230210757.13803-18-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251230210757.13803-1-philmd@linaro.org> References: <20251230210757.13803-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::442; envelope-from=philmd@linaro.org; helo=mail-wr1-x442.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767129003345158500 The PL011 component is only built / used by ARM targets, which are only built in little endianness. Thus we only ever built as little endian, never testing the big-endian possibility of the DEVICE_NATIVE_ENDIAN definition. Simplify by only keeping the little endian variant. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Manos Pitsidianakis Reviewed-by: Zhao Liu Message-Id: <20251224134644.85582-7-philmd@linaro.org> --- hw/char/pl011.c | 2 +- rust/hw/char/pl011/src/device.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/char/pl011.c b/hw/char/pl011.c index ac453c1057f..b2ca68e3e86 100644 --- a/hw/char/pl011.c +++ b/hw/char/pl011.c @@ -538,7 +538,7 @@ static void pl011_clock_update(void *opaque, ClockEvent= event) static const MemoryRegionOps pl011_ops =3D { .read =3D pl011_read, .write =3D pl011_write, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_LITTLE_ENDIAN, .impl.min_access_size =3D 4, .impl.max_access_size =3D 4, }; diff --git a/rust/hw/char/pl011/src/device.rs b/rust/hw/char/pl011/src/devi= ce.rs index 9f5c4a34df0..eed3b130ce8 100644 --- a/rust/hw/char/pl011/src/device.rs +++ b/rust/hw/char/pl011/src/device.rs @@ -489,7 +489,7 @@ unsafe fn init(mut this: ParentInit) { static PL011_OPS: MemoryRegionOps =3D MemoryRegionOpsB= uilder::::new() .read(&PL011State::read) .write(&PL011State::write) - .native_endian() + .little_endian() .impl_sizes(4, 4) .build(); =20 --=20 2.52.0 From nobody Wed Jan 7 09:26:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767129012; cv=none; d=zohomail.com; s=zohoarc; b=EeDpufzcLMSqs/63wCzWSnUU6MbSULMuSpNtA3CNbag0AnM3jmEUMbTsIEgi2f5gz8TplsdcO+axPINIfRdETptLmXbulMWMgrMABTiJpGiZtGstiI5ACtz0QpVovVmbbGAOKxY/4tGQG0TE5Imw7+tCJdvHLiAoJzpeLLF/6Qo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767129012; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=7PdapgrHunfm5ufaIBcnmA01QT5kJZfbNKwQl9yuLx0=; b=T442vkoz8kVWi1OPTRjQSdITV9BSmiSPJSoDjorVKzsCgP9+IZM+tRR/FwY+/6p7pR8nfKktOp2w2XsZa3/FnbIxYcKdjd7YnhS3qCSx6238XhK8eu191258GPZ8m9GHN8HmCwHEz9Ms8+aLhhNVjrV3WdaFwLLBOPMWS7OKBSQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767129012975588.779496281138; Tue, 30 Dec 2025 13:10:12 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vagyf-0000uI-Fj; Tue, 30 Dec 2025 16:10:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vagye-0000s0-2q for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:10:00 -0500 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vagyc-0002PR-LS for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:09:59 -0500 Received: by mail-wr1-x444.google.com with SMTP id ffacd0b85a97d-42b3d7c1321so6064447f8f.3 for ; Tue, 30 Dec 2025 13:09:58 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eab2721sm69926145f8f.39.2025.12.30.13.09.56 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Dec 2025 13:09:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767128997; x=1767733797; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=7PdapgrHunfm5ufaIBcnmA01QT5kJZfbNKwQl9yuLx0=; b=WDfBO0zYvzInPNet6tE5rULGvjVHWOSTfc2L27ndrblzVOMWA2N/aDSra2sQr5h221 32RYZfRNmuy8YWfqA+kHIHBiwLm6qgJZvGL8B7Yh3/prJIv5dAUE1hOishMh22HGsmkw E787eq00iYgAz4/ynHCcTsp+CnT8e8Uxi3gP3A/EQw8hINmYZuiKhZc7HEp1vvuHhFMe Y8xEyHGbkDn8fx8VqckPteeIJLMKMpHbcR3AmRMstLaKAMCuvit0M55nxzw3RHb7b/QH wk6FLciWx2UqOdfVBltoDwG8rw8puYrUWXe60ui38M1Zfew2s5nEc06Kc3q3cvqYwElK rrpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767128997; x=1767733797; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=7PdapgrHunfm5ufaIBcnmA01QT5kJZfbNKwQl9yuLx0=; b=ICDD6y43Ci+9CSieLTTZdpB4DODfKbMOVs/tO5Y1sUx6dir/gksPoXAnaI7EtPdxF5 Y+H9OJ2z906SCVsHOMVrvTW5Eh9c9RBBJTiYIyovOZwxl7/NG7c8kuHeCYM7wxMTTBGb sY797f4X+Wcuyf6xxm+ttuJM0ukW5axJqg94iLySW9obxEQYksWloj9ypuxOiaAw9fr+ iJhMsXWwUFKuSHun0tOGaYbMvuExfmF8PrYVl3NDEklE0F4XUPUOXylFH5wXoSfvc0n3 fR8CHJUYP5TGVZRQYoVKVRxT5l3tvK1lraM6E4OBfgM3aNFAQB/SJYn4LTpVm9lfeoiO D7AQ== X-Gm-Message-State: AOJu0YxFMdgEN40qkfBm/Ga/SLCGz7VYICmrlvWsZZfkXzeFtokfVfjG mPP4/6Oi5/5xTa2FpxcGMYOD8avw/wxXKyCsWEd0hf5x7PNDuKVlEBvYH1bwlJX/Pcwe1W9w+2d ASHJnM8g= X-Gm-Gg: AY/fxX6O8BMN1IAuLpu2pN57OegxnbO1omabz+SFeGO3s2DyQwYY1JPXEnQbgqfIyC1 Zuekvq4r+zq5XwJkfu6zSYucMdE/EklsjIdCjH3QXm8tJZ3vfCSdFT8hrQTKQ8LxbHVhRnuLQiX qzeo1/Uvvi+mRnsDOH9z3pOLEFYt0RBO7CpGUZzJdR6AxaHLCS1CIwBeVAuChlt+0sNmZmAW+9M 8Qj8DBnSgkQVjookQXsQoH13pImWb/uPbkUr4FBKsQP4aqUG14+aHoSszb5bmLTSGkFmbL4LcLS EurWkljPMpc4KLgs/nxt9pzpgIk2hopJJ34LKMQEsgNTCVMRy87l/yx/LIOFDJ2oquMiQwopRc0 G+YhOvvoDLPNhZSyVg/wBybqvM8kjjpCCKHsj2SrayoTYTpYHTVaBNdSWZATDubrzRsrCTc/jQM pKHLxl5zbfm6wO1DVswFUddiAsLnDUjUQUnjgG+BBmGM85H8/3TakL9rTD9X7j X-Google-Smtp-Source: AGHT+IHXPKs9PxNNeYlpsWVwJ3ry3hi50m0/5RdfTwQKTgyPjAlTgh74o+8C4mDkQ82UxZUe+STFvQ== X-Received: by 2002:a05:6000:200f:b0:431:7a0:dbc3 with SMTP id ffacd0b85a97d-4324e5061ccmr44912898f8f.29.1767128996741; Tue, 30 Dec 2025 13:09:56 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 18/34] rust/system: Stop exposing bogus DEVICE_NATIVE_ENDIAN symbol Date: Tue, 30 Dec 2025 22:07:40 +0100 Message-ID: <20251230210757.13803-19-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251230210757.13803-1-philmd@linaro.org> References: <20251230210757.13803-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::444; envelope-from=philmd@linaro.org; helo=mail-wr1-x444.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767129013391158500 We want to remove the bogus DEVICE_NATIVE_ENDIAN definition (by only having it explicit, either big or little one). Stop exposing it to rust devices to avoid it spreading further. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Manos Pitsidianakis Reviewed-by: Zhao Liu Message-Id: <20251224134644.85582-8-philmd@linaro.org> --- rust/system/src/memory.rs | 6 ------ 1 file changed, 6 deletions(-) diff --git a/rust/system/src/memory.rs b/rust/system/src/memory.rs index 4b3316bf767..4e06c16a0b5 100644 --- a/rust/system/src/memory.rs +++ b/rust/system/src/memory.rs @@ -78,12 +78,6 @@ pub const fn little_endian(mut self) -> Self { self } =20 - #[must_use] - pub const fn native_endian(mut self) -> Self { - self.0.endianness =3D device_endian::DEVICE_NATIVE_ENDIAN; - self - } - #[must_use] pub const fn valid_sizes(mut self, min: u32, max: u32) -> Self { self.0.valid.min_access_size =3D min; --=20 2.52.0 From nobody Wed Jan 7 09:26:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767129042; cv=none; d=zohomail.com; s=zohoarc; b=MZzu6Q/TXj1B4ruQi4tQNm6uXpexM9FJz7AZpkfo1COS/RVUXmiRX9Y2nGcQy8Ae5YzxFeNwgxjQxwD+JC2Tegt0wHEFyRvzRMLK6vo6xD+VncTi5XHOqIqMPpOnxRkDvqxiH+HiQzGDLCUFJxygZL4C8vCfVZ+MipeesdYDjvo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767129042; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=aWZ/wGhyjNTDvmvQyGMp4r18x0TBLO5WgYXXIpLUaQg=; b=DimRZDwDoLmg0ZzXwhPuR72sXpB8ExbUdD43HhcoEo3IaSV5DbVO18l+d2Jc5+/XkpoWptgUh2dS/HXUcsfQiLXObnYejdgMiqNxM1JsnxHDPT52eZN7vqjwaUet3pLP4VLM7lY0UdKhd7e5sEWnFztDYryp5FCoH8MgpLq09OI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767129042738570.6691840790235; Tue, 30 Dec 2025 13:10:42 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vagzA-0001co-R3; Tue, 30 Dec 2025 16:10:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vagym-0001JR-2M for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:10:10 -0500 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vagyj-0002Yd-5i for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:10:07 -0500 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-430f57cd471so5006284f8f.0 for ; Tue, 30 Dec 2025 13:10:04 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea830f3sm69502845f8f.22.2025.12.30.13.10.02 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Dec 2025 13:10:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767129003; x=1767733803; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=aWZ/wGhyjNTDvmvQyGMp4r18x0TBLO5WgYXXIpLUaQg=; b=f6SQupp5E+KDMq6YYap3MCRcTCqB+Q6sr83AcTZvF6W8l75Vy/00pXCuhWCCm7chGD +GfrWCIkN9Fr0EdpuoGMpCeVWSElBIWl2mxuZJ6yuY4uuZxaoMTb3dzeGBhFPkcZE9+z zQygEHTS6KVOYiyUCLskf4sRm+1xFxIsXIQ93MT/sASfLRKxhLan6EU5zuG/PHzEC8WZ 5qX65NdWUU1l4ZVfgXWYen+J8lisf3Y6FG6nPmPRB1+CoLeOikK8kEfkqQ04OKw3cBGO Xl5YPzKLdModDQWvkQgY8ECBPV2zp5mMocS4IiQjpSeg4G00Dsq2/yTXRNykrdoNw++k 76Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767129003; x=1767733803; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=aWZ/wGhyjNTDvmvQyGMp4r18x0TBLO5WgYXXIpLUaQg=; b=ib4lBDtiMROBR5d4LzItKXX3oq/aXfIOmPnHrVbcWPJt9mj/MYEBxGQJ8RupSNSYYe x92jmUIAGjmkzIS07q35Qd7SfPoCSBLVO4GiPX1Uzysi4sRqhTG0gjjMfu1RT7JtZ7wA g/ELiyljCGczkxonZHxh1n0Ht1BYnEpEmZ9cqhtqGorg1Do5Hzb2te4jQBZKpaCXWsZh NvaUEmriNiDXgSvPSDRD4e/TzM9gQ5U99KCEASLQtRE26nMcyFr2gbaASivIfGilveMV VPL/Pgfzw15rd8wJONP+wgM0aMdJ94aRmTzNq2jfikBAfUE7cWInWMnvktSiM0F+bB7s Jvmw== X-Gm-Message-State: AOJu0Yxnwjn5CbFNvYR6Dnzm3ID4Q61QFkQ1Moj/ldpQMuoUM46yP3oN TOyUTPAVxHktl4C71aXIZvPFO/FKlNMw6Ds+c3KP/JlxC7+w3KTplda+2hm4Be7NmdqrT1l4B/T IyEt3i64= X-Gm-Gg: AY/fxX5nG9BkkZoL01jB6LaNQOm57ZagSm85ufxkf+lmF+4qJAh+XZZJ5dAjBiG6ZTb N5DmxnKbYB+wU2y8Dr6z/ol0CV1Nd1UBl0T/naFGFW3Zjs8ELJahYYuJgFsArJhl27r/+C86peQ CF7PPfwHkjnBMizIEx3H+otl4JwwvxtQJswwPqSz2RX8AUmpiWKQUNrJx2lYnv5hWDIQYuIZDc9 y9ixd+cvBqq492PaT5aHn0UxHw8u0tmLLxjk7X9+XmbKgzz6dg5q31GrOlZ1FuXmGMd/rteBc7z cnL3gwtTtvd5BLk82qUPTKnIYhyhZ7U2yVfI5Ebtn8RLIRMEJI1xi+EABWRTq8ltyYLxGebMa+y u9xFREapFjbf743X8aX0FKYrugH63SS2RmrlB/oBG4TRkyv+l5n/elhAoaYk/H9SeCzEn08ypUf DvuVtzbDs3rIVYSYsCEzn4zir3BGsHJQW8Q5DxZ+uGr1cLV5XGfFhNlXdCc0Ti X-Google-Smtp-Source: AGHT+IFedSR6Q+ZstquTPJxsRRYF2RqcXOnttR5U2EYfYKcywkm9JQ9awEXysIRZnwDp6Wyfcn2UCQ== X-Received: by 2002:a05:6000:2dc7:b0:430:ff0c:35fb with SMTP id ffacd0b85a97d-4324e50d03dmr39984358f8f.52.1767129003310; Tue, 30 Dec 2025 13:10:03 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 19/34] target/hexagon: Include missing 'cpu.h' header in 'internal.h' Date: Tue, 30 Dec 2025 22:07:41 +0100 Message-ID: <20251230210757.13803-20-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251230210757.13803-1-philmd@linaro.org> References: <20251230210757.13803-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=philmd@linaro.org; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767129043429158500 Both CPUHexagonState and TOTAL_PER_THREAD_REGS are defined in "cpu.h" which is luckily indirectly included. However when refactoring unrelated files we get: In file included from target/hexagon/helper.h:18, from include/exec/helper-proto.h.inc:56, from include/exec/helper-proto.h:13, from target/hexagon/op_helper.c:22: target/hexagon/internal.h: At top level: target/hexagon/internal.h:29:25: error: unknown type name =E2=80=98CPUHex= agonState=E2=80=99; did you mean =E2=80=98CPUPluginState=E2=80=99? 29 | void hexagon_debug_vreg(CPUHexagonState *env, int regnum); | ^~~~~~~~~~~~~~~ | CPUPluginState target/hexagon/internal.h:30:25: error: unknown type name =E2=80=98CPUHex= agonState=E2=80=99; did you mean =E2=80=98CPUPluginState=E2=80=99? 30 | void hexagon_debug_qreg(CPUHexagonState *env, int regnum); | ^~~~~~~~~~~~~~~ | CPUPluginState target/hexagon/internal.h:31:20: error: unknown type name =E2=80=98CPUHex= agonState=E2=80=99; did you mean =E2=80=98CPUPluginState=E2=80=99? 31 | void hexagon_debug(CPUHexagonState *env); | ^~~~~~~~~~~~~~~ | CPUPluginState target/hexagon/internal.h:33:44: error: =E2=80=98TOTAL_PER_THREAD_REGS=E2= =80=99 undeclared here (not in a function) 33 | extern const char * const hexagon_regnames[TOTAL_PER_THREAD_REGS]; | ^~~~~~~~~~~~~~~~~~~~~ Fix that by including the missing header. We don't need the "qemu/log.h" since commit 0cb73cb5a02 ("target/hexagon: Remove HEX_DEBUG/HEX_DEBUG_LOG"): remove it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Matheus Tavares Bernardino Reviewed-by: Brian Cain Message-Id: <20251224134644.85582-9-philmd@linaro.org> --- target/hexagon/internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/hexagon/internal.h b/target/hexagon/internal.h index 32e96f00d97..5fc837ae229 100644 --- a/target/hexagon/internal.h +++ b/target/hexagon/internal.h @@ -18,7 +18,7 @@ #ifndef HEXAGON_INTERNAL_H #define HEXAGON_INTERNAL_H =20 -#include "qemu/log.h" +#include "target/hexagon/cpu.h" =20 int hexagon_gdb_read_register(CPUState *cpu, GByteArray *buf, int reg); int hexagon_gdb_write_register(CPUState *cpu, uint8_t *buf, int reg); --=20 2.52.0 From nobody Wed Jan 7 09:26:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767129074; cv=none; d=zohomail.com; s=zohoarc; b=Vf2NrIYa5oiKbpMZP6HiGZAXW+I7JNLOpUUMSCq2NpPHO0ad5rKYjxGYzDXF8x0Mkd1a6jotL7fz3Jp0Xmep7iKtkYME17LGG2yGLsWGaSwhbOckM/mfv+5PGfnDlVpTAtkGv0BK011W2LBh+pML3GOafR5m/0teL3sRR/2MukI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767129074; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=Ez5vl1EDt9mc2+b7pnNLOdCCl7mfnkJCH+Oj1B88Eho=; b=ALDNBKLEnVRD/46ao9wVgI923qcMO296bymKbD/94RcC0q3X2bZ6CdkjYz2SoOCjZ10PSHk/MsnNmtjonwZ768RF4gUbcTdORjOEL6bqKqnQ3afWMm7QoMOZbFCsXIq18mmrtiDLh1rrsrgOS30oWF2sPYJx/e/p3ysz1BNiLYc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767129074670510.3936784524806; Tue, 30 Dec 2025 13:11:14 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vagzP-00023n-1T; Tue, 30 Dec 2025 16:10:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vagz1-0001YL-LS for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:10:27 -0500 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vagyx-0002do-Mc for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:10:23 -0500 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-4327790c4e9so1826732f8f.2 for ; Tue, 30 Dec 2025 13:10:12 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea8311fsm70773019f8f.28.2025.12.30.13.10.09 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Dec 2025 13:10:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767129011; x=1767733811; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Ez5vl1EDt9mc2+b7pnNLOdCCl7mfnkJCH+Oj1B88Eho=; b=gxNs5wnQXvndYyx1CRPWSmFWJW2d9WDWZu5kO+dH7485Sj1SrVSr53ONcdgsDrWg8u ukhLA/eLDZ4ZWRi/df2mHTsCGdRcdXUOctvDdOtvSPQ8d3bKji+n4OOTPu8O5GWZv3LH xVGUY0pG6kIVOSGksBH7HkU/9oAxyNDwu2GG8uIEirONH5qAO0Kn9+ak2rvvknC9ptMH tl5Aqcdj2NwJtjl1f8YHUW9h76oPXayu3FA5ZSPcsJDWrTTpHNrsEODJWCuEnGJDWywZ Dys0Oc6JriT8rzWOAoVajIwwUyTqM5Zqk5MIQE/gvOVHgT1sDOgyQZY/qOlI3ekQAPyW NvPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767129011; x=1767733811; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Ez5vl1EDt9mc2+b7pnNLOdCCl7mfnkJCH+Oj1B88Eho=; b=o1NxzjPLfxqK2oeoAFv9UaJXdC8ToKyjihlVvGTFh8VkxUvpgpW5F0lLg+nNe2ySUJ UwGrePhJVtblt70gcxS0q0w9aeR6xdV9N6+rU4983CTGOBuCitCrpkwRg/Vf2meUp/+T 60cUr3/P2ccGU1yjgUo4olqjekJbw467NN1AW7koJD7UiJ6AZru+Le2XPHUOinRyBMOL F7bjjS7l1LwVWSBCqPX2DQFyJsg8pu2WYM9yyaZoc7O6KJIu5yrYW1JmbMeKHTUfZFGJ z/XhQZDcNZA/A+E0JDcEbekwN36sqS4a+tCS66WixoKDun2apU1pa8op7TclwACuvi7s 0Tpw== X-Gm-Message-State: AOJu0YxKIlIiAl2jaT2U/GVujGv6Jv5WouzJHpcpbQ5a84VS5XmpsWKb Agfe7Qlsry+ni3ArAgLKqfVcbO+yISip+zkKXvmprriww+2yChgz42y3p1ImAA6ozMtuuwxew3D DI1wv+lY= X-Gm-Gg: AY/fxX4i4deXIF49FcWxAy7mrkDq1LqbqqOx5jvdQnXrnOw6f8ZVTPipasPPgiP6rxO cKKvqvqP89Xt7LZP0e4mBYm4IvGjadLqkhHIPGVS/z2w3F3cg9xGKS2rpYcE5q26GisCgxtRC8W soow4PABD57XVfKzzvZO6YFBBGxBkkIl9QIH6U7RMHpzi5rXwAAx5Kb5r8nmP7WV9S2ATVQo5Gx wWvDnuwfGwRIbjGGFSBx/kKWs999+Qk0ZIhrsQt/pq5PmXyIhqH7uYUW/kH78RXUeKpLYAiXByU OJFwGYdkEoiCgBUJn9AZwtO0K2EYtJMZ4245HK7EhmGMNjITiwAZ5fUFrnOEel4sYLPsJcY9KSy K9UBTpnegPOl+qFgbdIWOKSlzteh0qh0bSOhYV9WM0yMpOoUJKcWSJ3JUClOARZ861ryPgJeBBM CkkmBuFkrJhNXHlDMrZre8yro+VKww8ZTsQzgWuo5OrHdZfdlBP6HON7C4ymfm X-Google-Smtp-Source: AGHT+IGdbImKySSFSy26RTdWD4TFW08Rc8ls5wCRlARa/EnjFxAZFdsozHCT5bPHccabWIejRmOD2A== X-Received: by 2002:a05:6000:420c:b0:430:fbe1:3822 with SMTP id ffacd0b85a97d-4324e511811mr51141720f8f.54.1767129011323; Tue, 30 Dec 2025 13:10:11 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 20/34] target/i386: Remove x86_stl_phys_notdirty() leftover Date: Tue, 30 Dec 2025 22:07:42 +0100 Message-ID: <20251230210757.13803-21-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251230210757.13803-1-philmd@linaro.org> References: <20251230210757.13803-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=philmd@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767129075607158500 Last use of x86_stl_phys_notdirty() was removed in commit 4a1e9d4d11c ("target/i386: Use atomic operations for pte updates"), let's remove. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Pierrick Bouvier Reviewed-by: Richard Henderson Reviewed-by: Zhao Liu Message-Id: <20251224151351.86733-2-philmd@linaro.org> --- target/i386/cpu.h | 1 - target/i386/helper.c | 10 ---------- 2 files changed, 11 deletions(-) diff --git a/target/i386/cpu.h b/target/i386/cpu.h index 41ea04099b2..2bbc977d908 100644 --- a/target/i386/cpu.h +++ b/target/i386/cpu.h @@ -2756,7 +2756,6 @@ uint32_t x86_lduw_phys(CPUState *cs, hwaddr addr); uint32_t x86_ldl_phys(CPUState *cs, hwaddr addr); uint64_t x86_ldq_phys(CPUState *cs, hwaddr addr); void x86_stb_phys(CPUState *cs, hwaddr addr, uint8_t val); -void x86_stl_phys_notdirty(CPUState *cs, hwaddr addr, uint32_t val); void x86_stw_phys(CPUState *cs, hwaddr addr, uint32_t val); void x86_stl_phys(CPUState *cs, hwaddr addr, uint32_t val); void x86_stq_phys(CPUState *cs, hwaddr addr, uint64_t val); diff --git a/target/i386/helper.c b/target/i386/helper.c index 3f179c6c11f..f9f9488eb4d 100644 --- a/target/i386/helper.c +++ b/target/i386/helper.c @@ -702,16 +702,6 @@ void x86_stb_phys(CPUState *cs, hwaddr addr, uint8_t v= al) address_space_stb(as, addr, val, attrs, NULL); } =20 -void x86_stl_phys_notdirty(CPUState *cs, hwaddr addr, uint32_t val) -{ - X86CPU *cpu =3D X86_CPU(cs); - CPUX86State *env =3D &cpu->env; - MemTxAttrs attrs =3D cpu_get_mem_attrs(env); - AddressSpace *as =3D cpu_addressspace(cs, attrs); - - address_space_stl_notdirty(as, addr, val, attrs, NULL); -} - void x86_stw_phys(CPUState *cs, hwaddr addr, uint32_t val) { X86CPU *cpu =3D X86_CPU(cs); --=20 2.52.0 From nobody Wed Jan 7 09:26:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767129051; cv=none; d=zohomail.com; s=zohoarc; b=ZJrVwYcoALVhi0Bbh6hICTZUXrzj0pMjRaQclaci5ih4KtuNFnLORnkGvXz8QiyVWu2TLejTYC+V/AOeroXKnlrZn3hdxzQMFho6p2YzSBvpwqotAAw0D/sLWKWPNcsUvw/ZTMOKvKnr2RE/m1UAnMynJRHMvSfeHoD72ya3cCc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767129051; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=L50V/EzCjudz2Uvy5oJglYhqNvb4wYscqaxHo/WQGxg=; b=XwQi4rCzNKjUZkMK5SbM/+6QkSQzm4V5mdr3+D1wTqpAQNqANVeWP7cDuyr3YK/P1eEjdkokPEPU2zZy5V3/kloflgTO8jEjwiedWYvz2PixzL+KsuHowmg4jwnXMfNt3ilMwWI4tu3Q/KUBJNDk7G0F3wU/4mRqj1wjM6xOB3c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767129051129329.8829298894017; Tue, 30 Dec 2025 13:10:51 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vagzF-0001lF-G4; Tue, 30 Dec 2025 16:10:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vagz3-0001Yn-Dm for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:10:27 -0500 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vagz0-0002fk-Qq for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:10:25 -0500 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-4779ce2a624so78973515e9.2 for ; Tue, 30 Dec 2025 13:10:19 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea1b1b1sm69761949f8f.3.2025.12.30.13.10.17 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Dec 2025 13:10:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767129018; x=1767733818; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=L50V/EzCjudz2Uvy5oJglYhqNvb4wYscqaxHo/WQGxg=; b=JlyII0pLPWp3dTevpaR7Wy5EGZXi3QDSeFB57fPcc2cBYeIopjWlx8mFu2s6ydnTDP hwiVNQ9p+ZLTFmOllD4FdphyXZSZA8MHcxMbvBqfIeixBe+4M8jvjfDkf/c+uch52KdG dPREM9uV95+0tcFyrGuqy7nr3LzJap3WiD69wU41Ka19koU0wId6qsDl70Oh24ejgTBo bzR9dlWNWfKuKVZty7lPsCAHgYdh3pzSDzV1n1u5drXWC6NV6I7HJ4fAy8ZVSGokfS+B PGxJ0175D+vutNpx9S8sbQxmaitsX1fLuF0jHsE7JLmsBQscBCbiJdGITmjNZUDz4xLY Xh7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767129018; x=1767733818; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=L50V/EzCjudz2Uvy5oJglYhqNvb4wYscqaxHo/WQGxg=; b=FEqEwDY0YUHpsTYZQoYoMFqp4CAZyuGL/IPplRNGZX/hVP0P5DYTFgJRxBKbLGEHRx vE0o7y55UstagEHhbAsQ50uQqygXB1VNc7kRB/qpAqydQMsF/XXNg/TzJnv15JTLPE1u FnuV0o8qOfxSmoaz9n0GVdxy2wQWLoINu99FG+LCEbgK1QUw0nK4nG2r6/PDVhx81PnJ 4L2PHtQmLjkmXX4H17H6g0MKYt8UPaR+MzEo6QhU39DobVD9i8bkPMw3nymMXffTEzKT K76kFzCsJOM653LosqK586AUz0y4dKrTLpsBbi/uMVPs+8sK/wCE0DygkOQVR22k0yyD u3fg== X-Gm-Message-State: AOJu0YzZob9pRm49nv4H01hYxhcx1zZHtIkUPlWLmKUQ2zIpETHCuV8P PHmcvP2mDmsZ+bmaDCMHYpOmcuyA5Ls6nFqs4+OybCnb4l5g4Jlj47FiFzfHyt51VYc1LOV+qHa fnRN3qU8= X-Gm-Gg: AY/fxX7KJjt/scIljS6Wx+o9oYHaX4RUvu3xPa4AtjOCGevgM6xFSyjCBCUE7tiiAxv xlFMExo5vhi9dJNh41jyNb+uqFManCwoN9l0sWGqRu/dItC8QjEKsZ1Ono4pCb7hHk5NHQCWXeE Se6cuXcnB8xO96913wQmjNBq+KXLlnEi4NK7vToE0W1+Ktj7TXULl6tmHGhlXoyknAS5+qkcNiq hZprs6udF7NYyF5nGAbzKswlUDQbOa6pV0l2RA5/uiMJbH5JPrwUkoeKFMMQuL9o/P5PSm3/gox OoxNrhlY0P/WU1s2Ryv1hWinkIyZOl6noAWO8TLhSDF04Q4dyAWAFzT1wt91Sfja3elXSQYaLFI 5abPGnBICHU7Y5NlJGOFv8vyARaXVqH3BQQNRqfGwCRWbiVFkXhGFIV6892fWhkly/0tFaLH+3j NZ8MSvr9KlyxDKfYx1HStFPVHb0UKQsxepHcp5Rfn3CO8gTq7hMizs/9LrBFtoyLvg7pwL4l4= X-Google-Smtp-Source: AGHT+IHs90/+ssDgsmBL+qh/7YJDd7RoVqso1/aK2jBXtrxx0En8x67lERTxV9X6aRtisgJs3lJMGw== X-Received: by 2002:adf:b605:0:b0:432:7d2a:2be4 with SMTP id ffacd0b85a97d-4327d2a2d3dmr19266331f8f.60.1767129017858; Tue, 30 Dec 2025 13:10:17 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 21/34] target/sparc: Update MMU page table using stl_phys() Date: Tue, 30 Dec 2025 22:07:43 +0100 Message-ID: <20251230210757.13803-22-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251230210757.13803-1-philmd@linaro.org> References: <20251230210757.13803-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=philmd@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767129051428158500 stl_phys_notdirty() is supposed to do an optimized CODE path store. Here we update the page table via the DATA path, so can use the normal stl_phys() helper. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Pierrick Bouvier Reviewed-by: Richard Henderson Message-Id: <20251224151351.86733-3-philmd@linaro.org> --- target/sparc/mmu_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/sparc/mmu_helper.c b/target/sparc/mmu_helper.c index 217580a4d8c..46bf500ea83 100644 --- a/target/sparc/mmu_helper.c +++ b/target/sparc/mmu_helper.c @@ -189,7 +189,7 @@ static int get_physical_address(CPUSPARCState *env, CPU= TLBEntryFull *full, if (is_dirty) { pde |=3D PG_MODIFIED_MASK; } - stl_phys_notdirty(cs->as, pde_ptr, pde); + stl_phys(cs->as, pde_ptr, pde); } =20 /* the page can be put in the TLB */ --=20 2.52.0 From nobody Wed Jan 7 09:26:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767129057; cv=none; d=zohomail.com; s=zohoarc; b=ZYfQc9FmDcjSgzmXllJDrJ1MTU3ltnmqgl4GuvuBwyWOuirJEVkIGvTRPXwXVmeFg18FeOWPtdxwdqY3UdLXkDuxjl2ntCob56mrxZ+MfQrX9oNXaqEiuqIIF0y7HMcAuYnRRxWAZ1ohuTzekH5QVmW1hSghzEz+9iOXif9C7MM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767129057; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=7QqNj0FBvOTWsnndVorR5mnhPv6tLS9zBqtC1X1aBEI=; b=lRDNdhdSQYwsnqE0q2djKgOrmq/bHG0MUuJGScHaKzfu89J6qeKsHvZkQjosf5Zu6R7iPIemsUoPCZt6NabRQP1sF5lQUo7dqtaehHnTJ5tQ6dPp64Fy3nPY8d76ID73rp7YnV4TiU5Om6Z7meqgFdvFdo49TrGrCYVGtCBvirg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767129057876489.1289725337489; Tue, 30 Dec 2025 13:10:57 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vagzR-00026B-2m; Tue, 30 Dec 2025 16:10:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vagz7-0001cp-AP for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:10:30 -0500 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vagz4-0002hM-NA for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:10:29 -0500 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-47796a837c7so66515935e9.0 for ; Tue, 30 Dec 2025 13:10:25 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eaa08d9sm70773584f8f.30.2025.12.30.13.10.23 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Dec 2025 13:10:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767129024; x=1767733824; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=7QqNj0FBvOTWsnndVorR5mnhPv6tLS9zBqtC1X1aBEI=; b=SOwMinm+qUGxS3mtqNxfwcGnKNrxC9uqLo/yQCbdtKBXXJ2rHKM+6ltN9RFUvknav5 ncdkjQWCvYu09AQXt7F4wtqMRTkUoo6xUZOKg+Qxy/Hpt1L6rzxEGWIr+tDy+f97To3O bz27VtyFO2o7BM2k+ROwD7P35s6uxQCzboXwVxB86XmyQTw742ENLHcCookMfHXvHxWB xZ+tI6eQkIgSU6j6I9yrVzpW9+CrYjTu27D+CA+ZAlKDfUGTlGLb/TfHiGl9bH4kWCj5 /exoR147+MV4B7cnAZro+KdBmORAIJLL2T5u/uig80Q245FV7gVr/tqWVzoKgONzbLYg IXKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767129024; x=1767733824; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=7QqNj0FBvOTWsnndVorR5mnhPv6tLS9zBqtC1X1aBEI=; b=R8XeAVlQ+z9vMFxaTdHuUBtkhqOmmAi41/1l2KTIyh4f3bAgE5r9tdYXswEyvZGNfi GVLAafcGHAhJogNXNMBOpbBK9FQUeHWgnpukxGJUZDca0SoMpzVZ7zApT7dhFRuD5FMj N706Uj8H90dYBAXKS0O+LyFNI6gBBqv5sTwPc4OjSgfdA+FHl2wSrdYW31wLJeEwvb/v mgCLPlAQ1JwJAjwuNb6WvUrzYoMLSqWNMXj3ZncEVaMdaQ3t3P6s/TWl4iJwiH0J1c2Z X4ZRfm5qhZTnX2KOuJSR0u2leeCfazaYrw5yGlOWsKDfQrSc0Vm9zaebbiEX8RAuuypF eqFw== X-Gm-Message-State: AOJu0YxMEMxeWNNyE0CEodoI+XZAbm5K9X5WeDY5oKZv+fg0zAgnUlO2 HWiiQMEih4tGX565DMYqUQKwlmw0m5+tGCT7JQCrqvehoJh8yhK9EEtdIx8qp+SkA8hUvB2ekDj kof/oZaQ= X-Gm-Gg: AY/fxX6dQCHeyNJPrJ1prxvL+c8ioLv5Vxpe7buqAyGT1AVqGAQJ9rgD2hYBGMPC/mT UU0m1kqtcQoQP5jcOior5MvLjEYLOWZwzhu0QNnDSIGrraSfASjB7KBghC8Lj5UzcmOOjckpYiO Sb1QiE6SGIHu1ChhuRSlt4KyVPap+J7oXaizz9EsGdQZXElI/5zmvSrd9S/OsCrl2SzT+zSh4w2 yjF1vV9ue/kr144HPAvMmmb8j6/1eaz/sKnGDYDw4kBzJXKwwIQpZ/9PwywNvl766U/lp2Ki3BH YK3Zm+An70nmSIWWV4m5hn2QLUEUpq4QAWqSS4wO5hsEEivsTfC1ZQp2nEhpBdfM0o4yTHqyiCi QAb1S1WGqf1o3cWvhdeTu12JO5miJu03YUM5gyNA4F6blh3icntvX2hc/MZ0TpSg7u8pP9hL7T+ ICMDlZB+yL9OJnwGWptL+cnqKGjkzaBQ2HNsOUEbyk7TqRu5+aqVr+F1Y1A57q X-Google-Smtp-Source: AGHT+IFr/niFut1s17jRdePbRyq9OXZJN+YbQbMECXCIGdLdNyF7JGjmpTFgN/H8HXeUvkKeQlVnjA== X-Received: by 2002:a05:600c:8b70:b0:477:a02d:397a with SMTP id 5b1f17b1804b1-47d1953b94cmr311783385e9.2.1767129024310; Tue, 30 Dec 2025 13:10:24 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 22/34] hw/arm: Avoid address_space_stl_notdirty() when generating bootloader Date: Tue, 30 Dec 2025 22:07:44 +0100 Message-ID: <20251230210757.13803-23-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251230210757.13803-1-philmd@linaro.org> References: <20251230210757.13803-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=philmd@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767129059541158501 When using the '-kernel' command line option, a bootloader is emitted, calling address_space_stl_notdirty(). The _notdirty() variant is supposed to /not/ mark the updated CODE page as dirty, to not re-translate it. However this code is only used with the '-kernel' CLI option after the machine is created and /before/ the vCPUs run, and *only* during the first (cold) reset; not during following (hot) resets. The optimisation is totally not justified, since we haven't translated any guest code yet. Replace by the normal address_space_stl() helper. Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Pierrick Bouvier Reviewed-by: Richard Henderson Message-Id: <20251224151351.86733-4-philmd@linaro.org> --- hw/arm/aspeed.c | 4 ++-- hw/arm/boot.c | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index 6199d2d2d7c..a3db3406c5f 100644 --- a/hw/arm/aspeed.c +++ b/hw/arm/aspeed.c @@ -77,8 +77,8 @@ static void aspeed_reset_secondary(ARMCPU *cpu, CPUState *cs =3D CPU(cpu); =20 /* info->smp_bootreg_addr */ - address_space_stl_notdirty(as, AST_SMP_MBOX_FIELD_GOSIGN, 0, - MEMTXATTRS_UNSPECIFIED, NULL); + address_space_stl(as, AST_SMP_MBOX_FIELD_GOSIGN, 0, + MEMTXATTRS_UNSPECIFIED, NULL); cpu_set_pc(cs, info->smp_loader_start); } =20 diff --git a/hw/arm/boot.c b/hw/arm/boot.c index d87bcb5b88a..0ba3adaf81a 100644 --- a/hw/arm/boot.c +++ b/hw/arm/boot.c @@ -266,8 +266,8 @@ static void default_reset_secondary(ARMCPU *cpu, AddressSpace *as =3D arm_boot_address_space(cpu, info); CPUState *cs =3D CPU(cpu); =20 - address_space_stl_notdirty(as, info->smp_bootreg_addr, - 0, MEMTXATTRS_UNSPECIFIED, NULL); + address_space_stl(as, info->smp_bootreg_addr, + 0, MEMTXATTRS_UNSPECIFIED, NULL); cpu_set_pc(cs, info->smp_loader_start); } =20 @@ -277,8 +277,8 @@ static inline bool have_dtb(const struct arm_boot_info = *info) } =20 #define WRITE_WORD(p, value) do { \ - address_space_stl_notdirty(as, p, value, \ - MEMTXATTRS_UNSPECIFIED, NULL); \ + address_space_stl(as, p, value, \ + MEMTXATTRS_UNSPECIFIED, NULL); \ p +=3D 4; \ } while (0) =20 --=20 2.52.0 From nobody Wed Jan 7 09:26:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767129096; cv=none; d=zohomail.com; s=zohoarc; b=YGsQY/8shrO0Zg4JElZEKdsoh0XUCko/zEkfESRC3EH+U7QuZDlg2gq4Z8Y5aP+5akTsVSAdilr6v+881ECjfnK3uwoNlaI0RZon8McePfr6g/xCPOvLJlqeHw4AxU+SLgtyvJxTC970yHxNzKB6bUJjKTVw+bPi+n2qPCGRXAs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767129096; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=4HHs8JJBlkqK5dGRyRM7AMKgYGwv/c7DPSq4oaL1jlE=; b=Hqb7zjSOH8BWqpYMhvnH4yp4zzH9WPDCd12bbO41RrGk3w8tYLLu7E8L7B8+/EKNVl6cUlEh/KXxwsYSEQJ0RW/JBtUHHKgJie3X/hidIAnkdJijxbBaZXWQo/euOsLrOOTzg1oDKNM0FN5icCLlG9vSlVwk3OgnYils7podaik= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767129096022889.3935910360884; Tue, 30 Dec 2025 13:11:36 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vagzW-0002Xb-S0; Tue, 30 Dec 2025 16:10:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vagzC-0001jK-Jh for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:10:35 -0500 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vagzA-0002jL-RY for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:10:34 -0500 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-47bdbc90dcaso64177455e9.1 for ; Tue, 30 Dec 2025 13:10:32 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be27b28a7sm664836485e9.12.2025.12.30.13.10.30 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Dec 2025 13:10:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767129031; x=1767733831; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=4HHs8JJBlkqK5dGRyRM7AMKgYGwv/c7DPSq4oaL1jlE=; b=MyyZstlX71f4yi+AuIjo0OIUBbcxCQeWkavA3Mn8ljFahAqFA1FGB5IUz6Tm+NGIBU gnHbiRy1denzdBymMCC8uIC0WnbE2ISGdfa7ZT2e46n7qYmUSewaBLjwcVw6NKeuhmsj 0aEDH3y1/7WzXzQBZh1jWtrnPXb12p9RRK/QJ2x8UydpKgBQQRTLI6bSnpLxzq22l3qt AvhVBUbW0UQUauCEZ7mP0e4lZPz/chGvHqUwLADnpZ2miF2RUf2K2Ay15GwsnMJtv7S7 XFeMh8ZcHY5zXmVlvu9Sh77pimWRIw27va0T67Bxx68AtM4aGp1nGjW31CNaLJfebz8N d4Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767129031; x=1767733831; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=4HHs8JJBlkqK5dGRyRM7AMKgYGwv/c7DPSq4oaL1jlE=; b=P1Eqw5FhngiZ21uGwaSqexHt4Ly3+xGFF39Vr38NxjCv+66ae1f4XjpIGrY3adDP9D 7YWZlQsORRLppE7nZ9PohSJOxKbNF3JcnCL9ktq7FhafZLt0u+sgEP1exjcTCTohC/zt 8ZvfbF1k8eRj/j6dED3XDlIU6F7/sN/OlHQHBFIK+QiWE+wJzAeQCmoOYUBrq0zIV4tx qsb++kvFJ/fdAHqXKIiprMZ4b3J+ao5A6aiIVRMi76I5OgoerQ3V9R2hnKNL8EAiKvMt 1JaF9vWW8NCkCKqTPY6R7WL07dUjcseRB3uFZTKYHwb0RCerUwv9G9VQaO8z1r7RxO05 C8qg== X-Gm-Message-State: AOJu0Yx1aqdv6tQuOxhO+c6NC++UrRXPn1gpLLo2RT8mG0GFV5Z3BaRI d1wZe0sQCIGh58gSKE6cExuL8tZ1u1W4qmLh8ivhLcawJ1kgf9rJA+c1tIG0Q2ig+9QqbnoMgWB 2KdvFMMc= X-Gm-Gg: AY/fxX7pxh9wLrpJaEioCN9xPnSl30koE0O8uqpLGBfAp+Pw4DfrD393xPharYWJrvn 8uXKocMJVUv9xi/p4BulFnEeG3dDJMlL/hAPp+ofSopSbqdQe0De/HD3Hnv1hfLcmB8tL8/U4Gn k5EYlaTa0d39qDW1Fkad27OX7RCEnxtxKPsia35FNOHTWCKaZgolplrlY7m91RDwc7uwt+YmBdN w0AYQjWejVante0/PH62rd2edXclFPciMna6jneefgal67H7bpyti8kj1y6k2jzTWXyKJLsuwWK N8y/Mrju5fAh67Svh6yr7jcvP2mMj5woFZVEnP/Kw6Xnn2n+wzSocjcD75RErHTTno7pAl6573G UhQwdJC8hUa11n7dRr88j14GPt/pE/KI8E6Pk7797SBIE07y5RAZ3bjtWwwGrnVbh4gHKrFHL9s HCjwRqQJt5wFhOArAGB2rscvmvAqs+OA7iKk4nBdb2VivGp7NDiGuRdl4xvjo5tcdv/TVtCGM= X-Google-Smtp-Source: AGHT+IHBIGMx4ih4HMbfdXMjwWkKOGzypUnxFyEBGW79owQgoHTdHzzzI4lA19U3aCBcgmDBUDtLqQ== X-Received: by 2002:a05:600c:4fd3:b0:477:9cdb:e337 with SMTP id 5b1f17b1804b1-47d19532e14mr349319655e9.7.1767129030718; Tue, 30 Dec 2025 13:10:30 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 23/34] system/memory: Remove address_space_stl_notdirty and stl_phys_notdirty Date: Tue, 30 Dec 2025 22:07:45 +0100 Message-ID: <20251230210757.13803-24-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251230210757.13803-1-philmd@linaro.org> References: <20251230210757.13803-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=philmd@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767129097717158500 stl_phys_notdirty() was added in commit 8df1cd076cc ("physical memory access functions") as a (premature?) optimisation for the CODE path. Meanwhile 20 years passed, we might never have understood / used it properly; the code evolved and now the recommended way to access the CODE path is via the cpu_ld/st_mmu*() API. Remove both address_space_stl_notdirty() and stl_phys_notdirty() leftovers. Suggested-by: Pierrick Bouvier Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Pierrick Bouvier Reviewed-by: Richard Henderson Message-Id: <20251224151351.86733-5-philmd@linaro.org> --- include/system/memory.h | 6 ----- include/system/memory_ldst.h.inc | 2 -- system/memory_ldst.c.inc | 39 -------------------------------- 3 files changed, 47 deletions(-) diff --git a/include/system/memory.h b/include/system/memory.h index b3597fb2d04..edef51a276d 100644 --- a/include/system/memory.h +++ b/include/system/memory.h @@ -2855,12 +2855,6 @@ MemTxResult address_space_write_rom(AddressSpace *as= , hwaddr addr, #define ARG1_DECL AddressSpace *as #include "system/memory_ldst.h.inc" =20 -static inline void stl_phys_notdirty(AddressSpace *as, hwaddr addr, uint32= _t val) -{ - address_space_stl_notdirty(as, addr, val, - MEMTXATTRS_UNSPECIFIED, NULL); -} - #define SUFFIX #define ARG1 as #define ARG1_DECL AddressSpace *as diff --git a/include/system/memory_ldst.h.inc b/include/system/memory_ldst.= h.inc index 7270235c600..173164fee3a 100644 --- a/include/system/memory_ldst.h.inc +++ b/include/system/memory_ldst.h.inc @@ -25,8 +25,6 @@ uint32_t glue(address_space_ldl, SUFFIX)(ARG1_DECL, hwaddr addr, MemTxAttrs attrs, MemTxResult *result); uint64_t glue(address_space_ldq, SUFFIX)(ARG1_DECL, hwaddr addr, MemTxAttrs attrs, MemTxResult *result); -void glue(address_space_stl_notdirty, SUFFIX)(ARG1_DECL, - hwaddr addr, uint32_t val, MemTxAttrs attrs, MemTxResult *result); void glue(address_space_stw, SUFFIX)(ARG1_DECL, hwaddr addr, uint16_t val, MemTxAttrs attrs, MemTxResult *result); void glue(address_space_stl, SUFFIX)(ARG1_DECL, diff --git a/system/memory_ldst.c.inc b/system/memory_ldst.c.inc index 333da209d1a..b45bfecd137 100644 --- a/system/memory_ldst.c.inc +++ b/system/memory_ldst.c.inc @@ -261,45 +261,6 @@ uint16_t glue(address_space_lduw_be, SUFFIX)(ARG1_DECL, DEVICE_BIG_ENDIAN); } =20 -/* warning: addr must be aligned. The ram page is not masked as dirty - and the code inside is not invalidated. It is useful if the dirty - bits are used to track modified PTEs */ -void glue(address_space_stl_notdirty, SUFFIX)(ARG1_DECL, - hwaddr addr, uint32_t val, MemTxAttrs attrs, MemTxResult *result) -{ - uint8_t *ptr; - MemoryRegion *mr; - hwaddr l =3D 4; - hwaddr addr1; - MemTxResult r; - uint8_t dirty_log_mask; - bool release_lock =3D false; - - RCU_READ_LOCK(); - mr =3D TRANSLATE(addr, &addr1, &l, true, attrs); - if (l < 4 || !memory_access_is_direct(mr, true, attrs)) { - release_lock |=3D prepare_mmio_access(mr); - - r =3D memory_region_dispatch_write(mr, addr1, val, MO_32, attrs); - } else { - ptr =3D qemu_map_ram_ptr(mr->ram_block, addr1); - stl_p(ptr, val); - - dirty_log_mask =3D memory_region_get_dirty_log_mask(mr); - dirty_log_mask &=3D ~(1 << DIRTY_MEMORY_CODE); - physical_memory_set_dirty_range(memory_region_get_ram_addr(mr) + a= ddr, - 4, dirty_log_mask); - r =3D MEMTX_OK; - } - if (result) { - *result =3D r; - } - if (release_lock) { - bql_unlock(); - } - RCU_READ_UNLOCK(); -} - /* warning: addr must be aligned */ static inline void glue(address_space_stl_internal, SUFFIX)(ARG1_DECL, hwaddr addr, uint32_t val, MemTxAttrs attrs, --=20 2.52.0 From nobody Wed Jan 7 09:26:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767129089; cv=none; d=zohomail.com; s=zohoarc; b=Oruo6iHP/NIX62vupbvdQXf2/GvsxPWMAPBBAy96S12QWYhd3WScyAOmQm2TxAqAncRYHHNWoBtZyQw3OTwbfQ2zpV90IpxF/++Sqhiq13+H4TTg/Nt2MnREnWPFR/wC1XaBKF63revD3luKkC9V7MRQa9m0Kjm0goTFAHPQDNc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767129089; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=mUsD1NrQKJS1hhbZfGXfvt9Z6Ms3MhVNlf1j+nUs6zo=; b=PpSvlIFBPulYu8LJxQbTla5hwVk0CUHUOFF43b8h0XudrH88/KCNyMGR9HCkcQLH3tzRTfaJO6gHyTIrORdKL1UYKOGFLE1ME+S/AtF2HxcRCZwu13gAsb8kdb3GRI5BA5EvKSZXkAJaiIQJJNBa6C3gsD+jyITtkWPYQFhgZ7c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767129089988628.6353612259057; Tue, 30 Dec 2025 13:11:29 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vagzV-0002Mu-Gm; Tue, 30 Dec 2025 16:10:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vagzJ-0001v0-96 for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:10:45 -0500 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vagzH-0002l8-Mu for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:10:40 -0500 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-477ba2c1ca2so108923115e9.2 for ; Tue, 30 Dec 2025 13:10:39 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be3aa9971sm259124825e9.13.2025.12.30.13.10.36 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Dec 2025 13:10:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767129037; x=1767733837; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=mUsD1NrQKJS1hhbZfGXfvt9Z6Ms3MhVNlf1j+nUs6zo=; b=PSGvvUIbD9LQOpFoacG7yiEkX4XQNQpaEa0HaHW8GzkbKYdz9T3oXrj7WIxiXQaX/o Kyq53Hhza+G04HND/XiSjsaBnovN0Jzbm0CyedYMopH+FblfsjGK0F8HgYe7SvJJfpzr w3wfwCWe4j0VzA5xq/ehnPhfrH6odppn857EXP1jPaUHA9UyvhUG/GqSSd179vnc4PCs EjpLnQZqVQIwA9U8tOPzD6CxWZfpHovuzBtvc8vkb64y+bla0rn34trEUwnV19jStrXH HPFrTfKU8++fpaVN171QJlM3NLVqdlVaEgq5oBuOQrU/PBmb/nueQEqe4bvTrLc5T6ao 0MNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767129037; x=1767733837; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=mUsD1NrQKJS1hhbZfGXfvt9Z6Ms3MhVNlf1j+nUs6zo=; b=KgaIEu1dzcsqvz/csJV0YCuyKYmFHHDjMc/EuSB8kWqHY1wHhr0o3hfzFTOrdn2zlz 1lWcBVInCjsOFpclaJQhHqRqRk5fANRqNunzEHewqPvhh1M/JlHkaIZz0LcIJyobK8JE /2KZjiRfpQGKTjaxBuT97wfMe/85SkmSXDSEJ6qDYyyHA1hId8vQ7nNBcEY6Zt3THVsd odHU/gpZ2lPy+70xeBkA5+XWx0ngfA5VPqa8qN9LAntEZMQ0XxNAjrjL44pNjFTgJMuG VoEzMynkDYZCzfGvARpOfZ9q4wM7b1yfn4uXFuccIrHCn2hsCam9cA5DKfbF/EYdglAd u4xQ== X-Gm-Message-State: AOJu0Yw7yFA6hRS+TN/b83Nt6ksaGuzHwBb/uK4rM3ja0PQ/4+1NNJIh 0JVRhzVHHQ6QRaj20oiihRqDPtKpv5PijEG0qYB6mQl9R7gxKUjtripiOTbOTMO5OE1Sc7anhQJ nfndSU6g= X-Gm-Gg: AY/fxX56tCewKN7pnwIBbjXUpILxUCjqEQz3sHt9FU+0S4UNOOqHy/YaI5kMJ9l+kMU G3JuGpwBg/dwIyW3lHrhjkhwOjqFTsLTF++Q/d0tJ4I5ZNNpnNVwkIWboPZeAxeykKSxhIHfuza nCMBQt3B6KRle6DxpiU6I5TBuMZ23yMLqd9Y8u43AqltgwFjejGhOSVteJjG1ZSY3ZuNDm9DRkW DhfojLWMaqrYxlkUDzElkVlkgpNu06+ycBjKHI8K/pTnZ6MYXlI1gcNeo12NHuQMRoI5voMULvl rZ1KXSRXbPFBk2LjQrnlA6zlQ9lSLyFSZxb7aaBNFRX9B8ZeL/nxdi2PK757GFioIANRewjxdQu Z2q7lwubssf8ciFiAEoNJnfOfSiajf4Mj79osVqr6+GznuNLSpgBcakfVj2RROl/Q/J5tp3loYI 57uDC3iUze5vcAVYnxs54UKIlJ5ulHU4TaTmKSpv5QjBFGaMqf2gXVxgRceJjm X-Google-Smtp-Source: AGHT+IGF9dRmxN9jdO3HgRa9+cJlNfNFy3ys0DYLm8wF4wk0fCB2JheVWD/Uvdhun+oH5L/+h9c9yw== X-Received: by 2002:a05:600c:4f4a:b0:477:58:7cf4 with SMTP id 5b1f17b1804b1-47d1953b79dmr463595425e9.4.1767129037290; Tue, 30 Dec 2025 13:10:37 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 24/34] system/memory: Allow restricting legacy ldst_phys() API usage Date: Tue, 30 Dec 2025 22:07:46 +0100 Message-ID: <20251230210757.13803-25-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251230210757.13803-1-philmd@linaro.org> References: <20251230210757.13803-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=philmd@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767129091739158500 Commit 500131154d6 ("exec.c: Add new address_space_ld*/st* functions") added a new API to fix a shortcoming of the ld/st*_phys() API, which does blind bus access, not reporting failure (and it also allow to provide transaction attributes). Later commit 42874d3a8c6 ("Switch non-CPU callers from ld/st*_phys to address_space_ld/st*") automatically converted the legacy uses to the new API, not precising transaction attributes (MEMTXATTRS_UNSPECIFIED) and ignoring the transation result (passing NULL pointer as MemTxResult). While this is a faithful replacement, without any logical change, we later realized better is to not use MEMTXATTRS_UNSPECIFIED or NULL MemTxResult, and adapt each call site on a pair basis, looking at the device model datasheet to do the correct behavior (which is unlikely to ignore transaction failures). Since this is quite some work, we defer that to device model maintainers. Meanwhile we introduce a definition, to allow a target which removed all legacy API call to prohibit further legacy API uses, named "TARGET_NOT_USING_LEGACY_LDST_PHYS_API". Since all targets should be able to check this definition, we take care to not poison it. Suggested-by: Pierrick Bouvier Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Manos Pitsidianakis Reviewed-by: Richard Henderson Message-Id: <20251224151351.86733-6-philmd@linaro.org> --- include/system/memory.h | 2 ++ scripts/make-config-poison.sh | 1 + 2 files changed, 3 insertions(+) diff --git a/include/system/memory.h b/include/system/memory.h index edef51a276d..0e8de527d36 100644 --- a/include/system/memory.h +++ b/include/system/memory.h @@ -2855,10 +2855,12 @@ MemTxResult address_space_write_rom(AddressSpace *a= s, hwaddr addr, #define ARG1_DECL AddressSpace *as #include "system/memory_ldst.h.inc" =20 +#ifndef TARGET_NOT_USING_LEGACY_LDST_PHYS_API #define SUFFIX #define ARG1 as #define ARG1_DECL AddressSpace *as #include "system/memory_ldst_phys.h.inc" +#endif =20 struct MemoryRegionCache { uint8_t *ptr; diff --git a/scripts/make-config-poison.sh b/scripts/make-config-poison.sh index 2b36907e239..937357b3531 100755 --- a/scripts/make-config-poison.sh +++ b/scripts/make-config-poison.sh @@ -10,6 +10,7 @@ exec sed -n \ -e' /CONFIG_TCG/d' \ -e '/CONFIG_USER_ONLY/d' \ -e '/CONFIG_SOFTMMU/d' \ + -e '/TARGET_NOT_USING_LEGACY_LDST_PHYS_API/d' \ -e '/^#define / {' \ -e 's///' \ -e 's/ .*//' \ --=20 2.52.0 From nobody Wed Jan 7 09:26:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767129096; cv=none; d=zohomail.com; s=zohoarc; b=NvOU2K7zbVWc/tV3F8TxCEerzE6jY11b4YKsEE+sqVDSjqEplR2bYSNRmQaLdKsFM5DRMAXz1VlrPUMeAUQzIt3hFhg2wF64ULa5S07Dh/6Njjpu5Z+qquZ7m9S2bCI9e+UYAqOmYK+M8uvmYi/l/SFpaHhbCPkp+cipKzNeQIg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767129096; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=X7ibe+zOWYAfY6rtdYT7opXCQK7sUSxI1ZrKDvOBvKI=; b=iZkU84NcIYe6Pg7EBkt0alum6qRs1rUN/hWJ8e9Gx5chOPFIjt2lcXhvvx4jN0LuuqJ0Y+YWP2RYzL5VaKyutFlMc2WgigixjYNs85kWufHFsGDN8AiIIIkQ1MvBy46uQftjBIj2cLZqyV3EMb20tKhxb9libAfV+vsdDDeNdcs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17671290969577.439426811137878; Tue, 30 Dec 2025 13:11:36 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vagzV-0002QW-Se; Tue, 30 Dec 2025 16:10:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vagzQ-00027z-EN for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:10:48 -0500 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vagzO-0002lx-2S for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:10:48 -0500 Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-42b3d7c1321so6064692f8f.3 for ; Tue, 30 Dec 2025 13:10:45 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4325d10cc48sm60041048f8f.16.2025.12.30.13.10.43 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Dec 2025 13:10:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767129044; x=1767733844; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=X7ibe+zOWYAfY6rtdYT7opXCQK7sUSxI1ZrKDvOBvKI=; b=lS7CIZ5KLrVdPV7fIhbyPsHD7JVg+wA2pAXNJCclBQ7jSHWXRNdcIoQJorFmFMLmjy BG3sM/cDUdggbiEVpGNhZLl4/2n8BPL26ld0pFIv+pI1L8Tn3HZzutKRqgqLEuQFodPu ov4L7ui38IBBpizZ2VLGq/Q1yGz75d5N3JsS/U0f7PnMngW530yCEKdIye9hJdJ5lx2I 9jL8BZ1wlrmq7wFwWTeCsj2yb7HUhoURXokNx7Qy3B7lcam7sR4FNsajKkFjjIIEgUFF hL2WvYkr8fQ6XscTIhr3t4wde7r5PQgwCkRFuN5Zf04F6byXFB8L3P1pLnvRwMkVYOL7 lEag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767129044; x=1767733844; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=X7ibe+zOWYAfY6rtdYT7opXCQK7sUSxI1ZrKDvOBvKI=; b=tE2aXso5XqoBVCUewWQULxaCZb5dPviwdQhQHXzQcfrnyyu+8dzz9rcFqcUrJGwVTq e3V4Dfy5egOtzJRKBRljHRVrj2q4jfm9QhZBkQfv45aYaEH+zGYg686REyywS7HWjKsk 4KbQHOr7oWDkAYkdAbFVfOj9BgynT4MwrWD7Hon4OI4bgz+r2908c8zDcaauw1XMFz2i Ow1NWcEyun1CvOBV+bUu0dwGwh+s4UP8OkTtm5mCSNpIgQVJj4Z0mpjlQdl77FtCLT0b HkwpPIsQL1wH6rh29ROwBbC4JbOHMfkctYwGQsFgnDi6mYNUUnhMaFCoBekXdC32QszY eU4w== X-Gm-Message-State: AOJu0YzeOEMU/XrU0eFQ0xwbthQK9WvneS4gXRm8KU+YlfPQ1uj5rtr9 EU/uikr7W3p6bB0AzlWpGvH28a9GEvx4ioUO9V1nGIx/QdYNEu2VUdXyDYu9MiwoVPrTvAc7rNh D7AFCOwM= X-Gm-Gg: AY/fxX43yTHP88dYfMqw8HIRvdiBmPfUyhpqb6TeDsiEEtqG9L5tIR7SKXScTjSJew0 yffkWljY1QncKtyirawxWMc+gCUBeHNoUH5OVEKw2AMB8rJlclIC7SCz/uAncx/gD3Eckp4njQ3 urgt+7HRclfvj5LwAEu8iHap1w9tAD4P1Ph22vyqeIDLIoB378/tE7bWdVxSnFq5v1ElJ5jGNjv tWIOWou3X2/zbQFlsYuTOfvsVkzXHgxl5HOj4kgYc7rBkgUdxpaXSuRcswLz0aC/jNLksgkx+TR EvorrxSK197R/rAP3mlepJWBywmdDHj+EeYoiwnEW6bztJNLPKCWY5Zh5627aNJ7UQazhuy2oud j692RHpGi+jbFV3aQucYQVl9E/XMFSvGrIWua5QapA31tej7Dxh6qRiQ4RFpecNMDbizEQ82zkd ZCfkQFFA2GmaPKyEsw53tSZDtWebR34qMR8EE/Q7+lUShKVJvIxVinggAsYSY6 X-Google-Smtp-Source: AGHT+IELipBGLFYyhF5cIgG9vpPnIgWYHDqmPC8eWg9Oqlx+xtxqO8+B/CRqyJwFGgd3TeFhXz64gQ== X-Received: by 2002:a05:6000:22c9:b0:430:f72e:c998 with SMTP id ffacd0b85a97d-4324e51081bmr46269596f8f.51.1767129044302; Tue, 30 Dec 2025 13:10:44 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 25/34] configs/targets: Mark targets not using legacy ldst_phys() API Date: Tue, 30 Dec 2025 22:07:47 +0100 Message-ID: <20251230210757.13803-26-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251230210757.13803-1-philmd@linaro.org> References: <20251230210757.13803-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=philmd@linaro.org; helo=mail-wr1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767129097729158500 Luckily these targets don't use the legacy ldst_phys() API at all. Set the TARGET_NOT_USING_LEGACY_LDST_PHYS_API variable to hide the API to them, avoiding further API uses to creep in. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Manos Pitsidianakis Reviewed-by: Richard Henderson Message-Id: <20251224151351.86733-7-philmd@linaro.org> --- configs/targets/avr-softmmu.mak | 1 + configs/targets/microblaze-softmmu.mak | 1 + configs/targets/microblazeel-softmmu.mak | 1 + configs/targets/rx-softmmu.mak | 1 + configs/targets/tricore-softmmu.mak | 1 + 5 files changed, 5 insertions(+) diff --git a/configs/targets/avr-softmmu.mak b/configs/targets/avr-softmmu.= mak index b6157fc465d..baf20fb7f2f 100644 --- a/configs/targets/avr-softmmu.mak +++ b/configs/targets/avr-softmmu.mak @@ -1,3 +1,4 @@ TARGET_ARCH=3Davr TARGET_XML_FILES=3D gdb-xml/avr-cpu.xml TARGET_LONG_BITS=3D32 +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy diff --git a/configs/targets/microblaze-softmmu.mak b/configs/targets/micro= blaze-softmmu.mak index bab7b498c24..cf635798c90 100644 --- a/configs/targets/microblaze-softmmu.mak +++ b/configs/targets/microblaze-softmmu.mak @@ -4,3 +4,4 @@ TARGET_BIG_ENDIAN=3Dy TARGET_NEED_FDT=3Dy TARGET_XML_FILES=3Dgdb-xml/microblaze-core.xml gdb-xml/microblaze-stack-pr= otect.xml TARGET_LONG_BITS=3D32 +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy diff --git a/configs/targets/microblazeel-softmmu.mak b/configs/targets/mic= roblazeel-softmmu.mak index 8aee7ebc5cf..52feb957b48 100644 --- a/configs/targets/microblazeel-softmmu.mak +++ b/configs/targets/microblazeel-softmmu.mak @@ -3,3 +3,4 @@ TARGET_ARCH=3Dmicroblaze TARGET_NEED_FDT=3Dy TARGET_XML_FILES=3Dgdb-xml/microblaze-core.xml gdb-xml/microblaze-stack-pr= otect.xml TARGET_LONG_BITS=3D32 +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy diff --git a/configs/targets/rx-softmmu.mak b/configs/targets/rx-softmmu.mak index 1c250a6450d..3a90f1b9977 100644 --- a/configs/targets/rx-softmmu.mak +++ b/configs/targets/rx-softmmu.mak @@ -3,3 +3,4 @@ TARGET_XML_FILES=3D gdb-xml/rx-core.xml # all boards require libfdt TARGET_NEED_FDT=3Dy TARGET_LONG_BITS=3D32 +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy diff --git a/configs/targets/tricore-softmmu.mak b/configs/targets/tricore-= softmmu.mak index 781ce49a62f..5e018d81068 100644 --- a/configs/targets/tricore-softmmu.mak +++ b/configs/targets/tricore-softmmu.mak @@ -1,2 +1,3 @@ TARGET_ARCH=3Dtricore TARGET_LONG_BITS=3D32 +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy --=20 2.52.0 From nobody Wed Jan 7 09:26:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767129089; cv=none; d=zohomail.com; s=zohoarc; b=dwxKT5msK4IoQb3Q+jAbMMVAS6tr1aUvHNm20IRsSTrAZv/4hYWiqv+8RXLfH568J49VdGLz7N7jG2ZEI8lihZHvQzdoSBkT6LHHUHg8IwHOXSMYvI1ONSMonFxd42NK8hZ9Y9KDzHUc9rlvzWGngRJQRH9eCUyZJYaP7cbM/7I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767129089; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=VR9BV23KQUTf4h5KpNYH7odqkl2T3CFFTAp+5wOs8cc=; b=VerVXcX/rINVWZQJN5p4fmLSyr8a7nIvRwtaU9pyXAmzvx5QQ8fwMGsoJUnL+1SnvBYohl4KsVD28R1Xk5UOvPDNCxAM8I7AeZNHJtGClaomS6WaxUngA+QSb/HNxYbqQi7bCepvSFIYgL0tQyU1Pv/Uw5LoSVVqP3pBNHbpXp4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767129089604590.5942505031054; Tue, 30 Dec 2025 13:11:29 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vagzZ-0002wL-Mq; Tue, 30 Dec 2025 16:10:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vagzX-0002dO-6r for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:10:55 -0500 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vagzV-0002nZ-Bq for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:10:54 -0500 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-4775ae77516so103358555e9.1 for ; Tue, 30 Dec 2025 13:10:52 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea227casm69791089f8f.15.2025.12.30.13.10.50 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Dec 2025 13:10:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767129051; x=1767733851; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=VR9BV23KQUTf4h5KpNYH7odqkl2T3CFFTAp+5wOs8cc=; b=he0PvotGOEJnx1BmHw9OPJCK2fVrV8DDU/ru21WV+3uAJvdJqPAABnbXgxDKoYQtWu sczS7yvmn5VimM1kjwcwW49Cv75M5B3jGtvn4X8gHFjp9v88zUdmDqgEogAIvqJpaZHw I5VsGCGhBpM0vztlA+WFHXfutx08rh7pHzWdc33INqCwVJNs3cR0oWr+DNi7HlK9zHCB B6zKlEkoAcSMlvCmHPvtEaIMfi5UIEigwViM4p4ExCT2DBepwD4sTz8HIXFZBup9dEq+ KoGkqpiiByOW5ptqIQFJNEJ13ejdKEtZHgsqk6noPvQzgzbZvTWzO8s3yjAZpBoPQjvU eflQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767129051; x=1767733851; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=VR9BV23KQUTf4h5KpNYH7odqkl2T3CFFTAp+5wOs8cc=; b=A5lM1rFOU4aw/bKuk3xfyaLAQ0wg4lIHKemkwElmHehzTm3Oc9ruyIyLr5uGUx2Mke wnLJzWm3UnytHdCIgRzHMY08H5GDmIAdCdASqIbnXdofwY6X5eCNYvzGQ6nRvmskeoy6 o9VSPl4OiSpnFtwJPMPNesMmceKFJFOthOjlN+ltpV3OEb9CYvdWeEn0ojKYok9Yh5nU Xp/xkpymaNCBa5qPbq9TFJp+1KxUv7WgcoejzRiMymowWw1kCCPA8pwXFESoCuERgM18 NAKNo2m6TGe2fM0oy/dETdoaDnwuogkOg/jMBaFKruOLOKlmt9pXOoneijZEUVQhhcVq tEuw== X-Gm-Message-State: AOJu0YyQGe4xhLKlk+CX2RB49/UBZyuKgBQNaVDsPUnVOuOQjOqTWZh8 AmJJgtidN875x0JeElTHprp05w3upUwZ9oCAe4mVZoJ7V/06lY7aeXsf6RGGl9ZwVsgVNFVk83t LX/xQ860= X-Gm-Gg: AY/fxX6k6qYd39WPwK2GYUndGa4Achm5tbK7SheOmXEoRNTTz64+XiIzPNk4P9uy9vu 0ziGNazkajBPEWuzu8CjmaDgxVBXXLaWjsjMc5Y7cc5p9eZOTNrZKRyWFFkSfJXvnEmqNp0484Z RMdxLzZ84TQe/maWXk1ZTDbldlcmvrdyvzOlD2laFup0zF/QZYKR5Ycx2POUF/gOROMvSQ3cDGq AWiZcMcn8iFgCzcpp9AfJ2TOVZK54l4mQ3TdMqXNdfzipQKnGBBjMXgL1NXiavcHr9CWfs9Fyn4 p2F6ddyNk1liLYpw+d7hy0wXVzhOu1+TSyVRTHiV85rkuIKrwF+pPOMW8pJ5yoU0axGoBHnGX4I O4Fb4EDXZTvo3KeV9HuS34IGBK/oUqt0vfUTCRaBLSMFO9KPgARoj/u9M36mhBEjz7HrIf0rQMJ HgGB7Mh1peOTAQ3ZJPjtRfVWRxo8+XIKwj7KHqNgjdsaFt34Cyd6S0EmnLzvziMsd9fXKvjJE= X-Google-Smtp-Source: AGHT+IEl2/NNJCRs0vKuAXFU6DZI23CvkC9GkM/qjznitTCQ2qaHtfBQJc43xewn7+kSAYDECiljbQ== X-Received: by 2002:a05:600c:5250:b0:479:3a86:dc1b with SMTP id 5b1f17b1804b1-47d36243a0bmr254354835e9.37.1767129051502; Tue, 30 Dec 2025 13:10:51 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 26/34] hw/virtio: Remove unused ldst_phys() helpers Date: Tue, 30 Dec 2025 22:07:48 +0100 Message-ID: <20251230210757.13803-27-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251230210757.13803-1-philmd@linaro.org> References: <20251230210757.13803-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=philmd@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767129091698158500 None of the following virtio ldst_phys() inlined helpers are used: - virtio_lduw_phys() - virtio_ldl_phys[_cached]() - virtio_ldq_phys[_cached]() - virtio_stw_phys() - virtio_stl_phys[_cached]() Just remove them. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Manos Pitsidianakis Reviewed-by: Richard Henderson Message-Id: <20251224151351.86733-8-philmd@linaro.org> --- include/hw/virtio/virtio-access.h | 85 ------------------------------- 1 file changed, 85 deletions(-) diff --git a/include/hw/virtio/virtio-access.h b/include/hw/virtio/virtio-a= ccess.h index 07aae69042a..c866769cad8 100644 --- a/include/hw/virtio/virtio-access.h +++ b/include/hw/virtio/virtio-access.h @@ -39,60 +39,6 @@ static inline bool virtio_access_is_big_endian(VirtIODev= ice *vdev) #endif } =20 -static inline uint16_t virtio_lduw_phys(VirtIODevice *vdev, hwaddr pa) -{ - AddressSpace *dma_as =3D vdev->dma_as; - - if (virtio_access_is_big_endian(vdev)) { - return lduw_be_phys(dma_as, pa); - } - return lduw_le_phys(dma_as, pa); -} - -static inline uint32_t virtio_ldl_phys(VirtIODevice *vdev, hwaddr pa) -{ - AddressSpace *dma_as =3D vdev->dma_as; - - if (virtio_access_is_big_endian(vdev)) { - return ldl_be_phys(dma_as, pa); - } - return ldl_le_phys(dma_as, pa); -} - -static inline uint64_t virtio_ldq_phys(VirtIODevice *vdev, hwaddr pa) -{ - AddressSpace *dma_as =3D vdev->dma_as; - - if (virtio_access_is_big_endian(vdev)) { - return ldq_be_phys(dma_as, pa); - } - return ldq_le_phys(dma_as, pa); -} - -static inline void virtio_stw_phys(VirtIODevice *vdev, hwaddr pa, - uint16_t value) -{ - AddressSpace *dma_as =3D vdev->dma_as; - - if (virtio_access_is_big_endian(vdev)) { - stw_be_phys(dma_as, pa, value); - } else { - stw_le_phys(dma_as, pa, value); - } -} - -static inline void virtio_stl_phys(VirtIODevice *vdev, hwaddr pa, - uint32_t value) -{ - AddressSpace *dma_as =3D vdev->dma_as; - - if (virtio_access_is_big_endian(vdev)) { - stl_be_phys(dma_as, pa, value); - } else { - stl_le_phys(dma_as, pa, value); - } -} - static inline void virtio_stw_p(VirtIODevice *vdev, void *ptr, uint16_t v) { if (virtio_access_is_big_endian(vdev)) { @@ -166,26 +112,6 @@ static inline uint16_t virtio_lduw_phys_cached(VirtIOD= evice *vdev, return lduw_le_phys_cached(cache, pa); } =20 -static inline uint32_t virtio_ldl_phys_cached(VirtIODevice *vdev, - MemoryRegionCache *cache, - hwaddr pa) -{ - if (virtio_access_is_big_endian(vdev)) { - return ldl_be_phys_cached(cache, pa); - } - return ldl_le_phys_cached(cache, pa); -} - -static inline uint64_t virtio_ldq_phys_cached(VirtIODevice *vdev, - MemoryRegionCache *cache, - hwaddr pa) -{ - if (virtio_access_is_big_endian(vdev)) { - return ldq_be_phys_cached(cache, pa); - } - return ldq_le_phys_cached(cache, pa); -} - static inline void virtio_stw_phys_cached(VirtIODevice *vdev, MemoryRegionCache *cache, hwaddr pa, uint16_t value) @@ -197,17 +123,6 @@ static inline void virtio_stw_phys_cached(VirtIODevice= *vdev, } } =20 -static inline void virtio_stl_phys_cached(VirtIODevice *vdev, - MemoryRegionCache *cache, - hwaddr pa, uint32_t value) -{ - if (virtio_access_is_big_endian(vdev)) { - stl_be_phys_cached(cache, pa, value); - } else { - stl_le_phys_cached(cache, pa, value); - } -} - static inline void virtio_tswap16s(VirtIODevice *vdev, uint16_t *s) { *s =3D virtio_tswap16(vdev, *s); --=20 2.52.0 From nobody Wed Jan 7 09:26:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767129084; cv=none; d=zohomail.com; s=zohoarc; b=QTCGI7Q7soKHj0NeA7elo+buqIqFhsfsZFEw2dW4ZAjeL/sfYHEaSspdxOlEvfvYwVJNt2zDvmbg3I5Z4YvzLwd8WmXDHqXQurkK4qvGArJ6sK6BB/IF9pg4ziAN19lnfK823/jQcvzEG7rLhN9fXF8kcgOPKvvQme+OoKhy2B0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767129084; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=/w1WLk/TO8IbZ7uavQKiXzIzSgDDg0efwkjmD+qvdIk=; b=TnmU+flTTk+jH/A8wqBuIgGfz/QctrwtMnQSIJ+02C2DrVpgLyygLJBJFWfhwzeGaFujZOo1I5zg211oijhUCI10xtr1Wuh2mvTQyPnO14ngvj353s8skfda11cKRLvv2XANhpbjxKG8+XUHfbgrf9dWNx5+Zx0YnArXtOPHYvI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767129084175826.7004081894286; Tue, 30 Dec 2025 13:11:24 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vagzg-0003ri-Db; Tue, 30 Dec 2025 16:11:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vagze-0003g7-KH for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:11:02 -0500 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vagzc-0002pj-Rs for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:11:02 -0500 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-47d59da3d81so8466805e9.0 for ; Tue, 30 Dec 2025 13:11:00 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d193522cdsm586399795e9.4.2025.12.30.13.10.57 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Dec 2025 13:10:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767129059; x=1767733859; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=/w1WLk/TO8IbZ7uavQKiXzIzSgDDg0efwkjmD+qvdIk=; b=mQIoINevI4IiSLhAgw69Q9UeGWuUaa313gxS/4i3oXGMlf1mAADQbRP2/MkOgL2r64 jDVsAPssxu7q4FC9JHe2j3fqcQWQKhoQxBKbj9SrOZpOs0s8LDq4SP5E81AYwqqEvn6G 5l7BfIzrPJA4NR0ETO6bS93iMvE/joDAguhcTeji+imYlEbSq7/1CIT9ih+yTAkrSgsh FnLoa7JhjKGM5ltO6LNDeQ468TTdIAmEdqOIU62Q3zV2Bsi11xWMDBmpMbp14oF2qmYN ZS8MZhcM3fJ8Nuohz1J8jn+AbmszmGXY8M/V0rdGnDZ+1t/P42litpA85mXFwtI/kODj Jdhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767129059; x=1767733859; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=/w1WLk/TO8IbZ7uavQKiXzIzSgDDg0efwkjmD+qvdIk=; b=ukz4Rg117db4luHy+S0q4yw7xXUGt4wOpXGKKKfqPe88e/5QeBoGrirZgIb17N8hy9 Am2jJvwtLQYDsduISO30dIORU3GRhQfWXzz6j4cbyfXzgfnI/kRBlrK0LaoGSBj+fkt9 yFEjQ6SFhwvZo1ja2+ZgiDm5HVMtWCYB7ynfbFWsqFYrVxuYeOa5o2xKsVbb34s3AXgG zbzMFkCAC3bOv06maL8wxkNHnInm7oofOKjgN6h3j9Rk7H4mIECD9drT4UTv2JBlCFTK w7jzG44iFnbPwOtyvwR0nvFWfT+s1F4K99R2NDMjhI/dKNG7bGCoUK6T01EP3QUyIyZY eLGQ== X-Gm-Message-State: AOJu0YzIB36VZRb2Anof5WEnK/INTZK1kFkBjr0Dkqg2SwLQPSf3ofX0 j+o/QHfhD31PW7HBS3Wp1MIDcqo/DY1Qp0GRBsrbikOIy5e8h/Sc7XQrzdiV1ZfjfJ35T/6ffOW Guy3CXF8= X-Gm-Gg: AY/fxX7DE9jSsSeGCxzB0Q1MfOQe8PwlqP+2SwRSXHDsVloZnXSZuzq3zEq5Rs4PRAe advdukEMsTYoVBJgdjXKyntDJp9jqDISWaN7MnjTV/16mrJjjNIOn+u5g+ocqlRmQGpYTFqQJxz 1VADyO3PwnW2eLtIE+8QQmiyoEzHut4vt/8nHxVqCINLcceODuUFLO+Crj4cYztNz45dF+d9vf1 vnrL7mEGW1WwGe1h9eVm9SyOgQ1DNGCl2eeYqbemrVvgneVw/a+U6QX/K//wgc99TC3Ta8OVeEs cZQ12xo8XRgi9naUDIJZ7WNAAho3OVOA4n1CyuSHhuiTSgHkUWkyNDYEG1KIDl8/5G6c9c2H14F QZZqsDDUodwtqzQaEwL6Ylq3y3MXyDV23JY/UAthB2OLbrCIu0pTVmD9QFZcQD+Uc618ZMnISv2 HXm1kQyI64wZ9ip0syqGewPwv+qnjWcSAMdIM7IsaDRCf//I4pKGd7B48+AnrvayExXu8REsQ= X-Google-Smtp-Source: AGHT+IGC9wJHFl2W1auGd3zJ2t15xdismIqf33uL5dJkqP6o4aZuZ3GJ2tje3t5oLuisI+L193EwNw== X-Received: by 2002:a05:600c:6749:b0:471:665:e688 with SMTP id 5b1f17b1804b1-47d18be89d5mr502264695e9.17.1767129058691; Tue, 30 Dec 2025 13:10:58 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 27/34] hw/virtio: Reduce virtio_lduw/stw_phys_cached() scope Date: Tue, 30 Dec 2025 22:07:49 +0100 Message-ID: <20251230210757.13803-28-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251230210757.13803-1-philmd@linaro.org> References: <20251230210757.13803-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=philmd@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767129085679158500 virtio_lduw_phys_cached() and virtio_stw_phys_cached() are only used within hw/virtio/virtio.c: reduce their scope by moving their definitions there. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Manos Pitsidianakis Reviewed-by: Richard Henderson Message-Id: <20251224151351.86733-9-philmd@linaro.org> --- include/hw/virtio/virtio-access.h | 21 --------------------- hw/virtio/virtio.c | 21 +++++++++++++++++++++ 2 files changed, 21 insertions(+), 21 deletions(-) diff --git a/include/hw/virtio/virtio-access.h b/include/hw/virtio/virtio-a= ccess.h index c866769cad8..5b5fff5295e 100644 --- a/include/hw/virtio/virtio-access.h +++ b/include/hw/virtio/virtio-access.h @@ -102,27 +102,6 @@ static inline uint16_t virtio_tswap16(VirtIODevice *vd= ev, uint16_t s) #endif } =20 -static inline uint16_t virtio_lduw_phys_cached(VirtIODevice *vdev, - MemoryRegionCache *cache, - hwaddr pa) -{ - if (virtio_access_is_big_endian(vdev)) { - return lduw_be_phys_cached(cache, pa); - } - return lduw_le_phys_cached(cache, pa); -} - -static inline void virtio_stw_phys_cached(VirtIODevice *vdev, - MemoryRegionCache *cache, - hwaddr pa, uint16_t value) -{ - if (virtio_access_is_big_endian(vdev)) { - stw_be_phys_cached(cache, pa, value); - } else { - stw_le_phys_cached(cache, pa, value); - } -} - static inline void virtio_tswap16s(VirtIODevice *vdev, uint16_t *s) { *s =3D virtio_tswap16(vdev, *s); diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 5b64eb4d67f..3dc9423eae9 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -216,6 +216,27 @@ static void virtio_check_indirect_feature(VirtIODevice= *vdev) } } =20 +static inline uint16_t virtio_lduw_phys_cached(VirtIODevice *vdev, + MemoryRegionCache *cache, + hwaddr pa) +{ + if (virtio_access_is_big_endian(vdev)) { + return lduw_be_phys_cached(cache, pa); + } + return lduw_le_phys_cached(cache, pa); +} + +static inline void virtio_stw_phys_cached(VirtIODevice *vdev, + MemoryRegionCache *cache, + hwaddr pa, uint16_t value) +{ + if (virtio_access_is_big_endian(vdev)) { + stw_be_phys_cached(cache, pa, value); + } else { + stw_le_phys_cached(cache, pa, value); + } +} + /* Called within call_rcu(). */ static void virtio_free_region_cache(VRingMemoryRegionCaches *caches) { --=20 2.52.0 From nobody Wed Jan 7 09:26:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767129109; cv=none; d=zohomail.com; s=zohoarc; b=isvIe5bpnWBqw5I37iaFRpcvW0c4PcXWOi/ha01LMJC9PKNNFBKbJoaSo+LgXBz2eR77gOt+iohg3Nhz6d6AUOGXvr5n/kSqwaRopYf+Bn44AFmGaSvRlp6DPSWHBt8OzLDYZcibDgGYvHIuBgWcz14p2FOLXlG/Bkz1McPXv+0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767129109; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=5sapxdoJCIiWphE18QsmorB7fBOlZsGQoNSD08EFBC8=; b=ZB89Ti2Jt/cnYsmrFp+wT4agXq/YFoQ9Vm6mUFr+LMp/XC3MesiV/RasJbT3E5DkeONcs0pmVKMnOLJSBvl/rV0FSGDxFNu1XlYgYyMd2qx+26oYW9PvXtFdMjUXdW7zzlVs+iyxV9SkLPIs7DW0D8O8hwpzdsPaUVCdf3u/iXU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176712910913156.45346003857196; Tue, 30 Dec 2025 13:11:49 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vagzn-000544-4f; Tue, 30 Dec 2025 16:11:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vagzl-0004vL-HB for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:11:09 -0500 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vagzj-0002qm-5y for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:11:09 -0500 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-47d182a8c6cso46317115e9.1 for ; Tue, 30 Dec 2025 13:11:06 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be3acdb87sm261123515e9.16.2025.12.30.13.11.04 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Dec 2025 13:11:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767129065; x=1767733865; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=5sapxdoJCIiWphE18QsmorB7fBOlZsGQoNSD08EFBC8=; b=xbpRysB2O1T/1H1t59cNF7uDICFsQJjEGmawSivYjtlzoycbR8l97+msSPvFS6xDqf i5mdSybEzkFXw9NJBE2giKXajoK7KHsrmN9T/bC6FAcPWSTs5YZYyc5tCgmTIO4+Dk5V 4n3Ufhbl8byjvqDbUWjKwmXsK8TzmgaPj1jfIUxijSAltZ7pVh6hj0fB/uIeWj6cOSFq WNzE8DFNh92Xrq+KqqqvrKdneu19nVEi9038FyI6d/pGX0cglPzNjmfZ9y2dXEiZR7Su DubfP4jFZTEAp7hUzQxGuKIkg1KBp8EI0oUcMfrNzGqh4BKj9Azvb/ROrjR/Uc6BOHkp i7Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767129065; x=1767733865; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=5sapxdoJCIiWphE18QsmorB7fBOlZsGQoNSD08EFBC8=; b=xJ7LsFMXWmCAqjppwMCWkxrMmkjZcRpNXV8ar+1TVZA5FlMBL60mG7Tc7Vw1xqqE0L 6T/d1d0OzEn1awU7QyMEIN4+YVhTBYeRdCdCWXRV+JvyX4B/1++1NrlXZKrjG8PKBrCi uO3olpRLlgvT7FlyPI4T8YB6nOumnqlfLJlJQxM87jI4k/RSR0RYi7XKesO1YRV7nCcY lkYu3gbooQag9kwzcMm3Hqg+GyoA8kwKTa53s5nFXYXg2nS7eYgmITUvK65jZXSUlfsl LVY/rkHu4b8iOoLuSKP2/3EoEXrjkz6W80l5WBX+iJC8KKb/J4GwezPMwEpRDetayF7l 4c0g== X-Gm-Message-State: AOJu0YysvNOxwjYuupeV0hlLN9CdiUrY54w/Q/PpTlv+v16vAYtzmWed MwxKsDOUYUQ72C/ZUCorBj0qIsVptV3LNhp7b3qF6nxYoqcrQEQFIaf/yLNf/vzOfG9P9pqzNxb BpJBO+/c= X-Gm-Gg: AY/fxX6i/McKH8gIl3PjxFv+JMnVu/NJ1kDVetDLb/EB8On4vZ6vXwHcidL0hT5G05p BJqYnQFB15t4C40L3XpBn1sTfR7rBwchqizMoU075iCMMLvcscjZf8W5E9Sa82t3R96Xu3ZOD+6 ghU+/1e5k1wdi+/lruMxoUvfM12XCNeH12D++BIPBUBc8lzgtzsENuGhcuh14c2VcbkCst3cl97 iyoPV5Q4oATwIL/TAwjLi+wO9zzWh5UAr2RRaEIy7gmgk4AJ4HFD8wwOElbOAah2CQdBdvBpG6c m4gWM2clMUozL8hakRXJsIGZjgLltaOKKF4KK/Nhyr3Ne321yqGyvBBS+Zmtz5guArnErcJsTKF 5MGwaCB5+3dzjKviwmbuZXJGGgyhyMr4HyJ/j6fROwU9z7vXjN3+lLUBp2/0HxZ5km7hpZYhcl2 rrk1AaRbzXQBo5k61c1UQZyrukC3nyAS07w+iHbZmphf+Xezgklx1phJZxpUde X-Google-Smtp-Source: AGHT+IGRd4Y0tg5sJUgsALMktaVVj4c3IHKf6wnw3XwKFoAxWdn+7NW2tcMjDFX/yKRNwhRcm7LWRA== X-Received: by 2002:a05:600c:45cf:b0:47a:7fdd:2906 with SMTP id 5b1f17b1804b1-47d1954a550mr403244635e9.12.1767129065228; Tue, 30 Dec 2025 13:11:05 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 28/34] configs/targets: Mark targets not using legacy ldst_phys() API Date: Tue, 30 Dec 2025 22:07:50 +0100 Message-ID: <20251230210757.13803-29-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251230210757.13803-1-philmd@linaro.org> References: <20251230210757.13803-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=philmd@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767129109834158500 These targets were only using the legacy ldst_phys() API via the virtio load/store helpers, which got cleaned up. Mark them not using the legacy ldst_phys() API to avoid further use, allowing to eventually remove it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Manos Pitsidianakis Reviewed-by: Richard Henderson Message-Id: <20251224151351.86733-10-philmd@linaro.org> --- configs/targets/mips-softmmu.mak | 1 + configs/targets/mips64-softmmu.mak | 1 + configs/targets/mips64el-softmmu.mak | 1 + configs/targets/mipsel-softmmu.mak | 1 + configs/targets/or1k-softmmu.mak | 1 + configs/targets/riscv32-softmmu.mak | 1 + configs/targets/riscv64-softmmu.mak | 1 + configs/targets/sh4-softmmu.mak | 1 + configs/targets/sh4eb-softmmu.mak | 1 + configs/targets/sparc64-softmmu.mak | 1 + configs/targets/xtensa-softmmu.mak | 1 + configs/targets/xtensaeb-softmmu.mak | 1 + 12 files changed, 12 insertions(+) diff --git a/configs/targets/mips-softmmu.mak b/configs/targets/mips-softmm= u.mak index c9588066b8d..95397af9442 100644 --- a/configs/targets/mips-softmmu.mak +++ b/configs/targets/mips-softmmu.mak @@ -1,3 +1,4 @@ TARGET_ARCH=3Dmips TARGET_BIG_ENDIAN=3Dy TARGET_LONG_BITS=3D32 +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy diff --git a/configs/targets/mips64-softmmu.mak b/configs/targets/mips64-so= ftmmu.mak index 7202655fcac..f9cc41b9ed4 100644 --- a/configs/targets/mips64-softmmu.mak +++ b/configs/targets/mips64-softmmu.mak @@ -2,3 +2,4 @@ TARGET_ARCH=3Dmips64 TARGET_BASE_ARCH=3Dmips TARGET_BIG_ENDIAN=3Dy TARGET_LONG_BITS=3D64 +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy diff --git a/configs/targets/mips64el-softmmu.mak b/configs/targets/mips64e= l-softmmu.mak index 3ebeadb29ea..4e7dedc5f30 100644 --- a/configs/targets/mips64el-softmmu.mak +++ b/configs/targets/mips64el-softmmu.mak @@ -1,3 +1,4 @@ TARGET_ARCH=3Dmips64 TARGET_BASE_ARCH=3Dmips TARGET_LONG_BITS=3D64 +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy diff --git a/configs/targets/mipsel-softmmu.mak b/configs/targets/mipsel-so= ftmmu.mak index 90e09bdc3e5..b0fba8a9d0a 100644 --- a/configs/targets/mipsel-softmmu.mak +++ b/configs/targets/mipsel-softmmu.mak @@ -1,2 +1,3 @@ TARGET_ARCH=3Dmips TARGET_LONG_BITS=3D32 +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy diff --git a/configs/targets/or1k-softmmu.mak b/configs/targets/or1k-softmm= u.mak index 0e47d9878b0..89f81b75bf7 100644 --- a/configs/targets/or1k-softmmu.mak +++ b/configs/targets/or1k-softmmu.mak @@ -3,3 +3,4 @@ TARGET_BIG_ENDIAN=3Dy # needed by boot.c and all boards TARGET_NEED_FDT=3Dy TARGET_LONG_BITS=3D32 +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy diff --git a/configs/targets/riscv32-softmmu.mak b/configs/targets/riscv32-= softmmu.mak index db55275b868..7476e596082 100644 --- a/configs/targets/riscv32-softmmu.mak +++ b/configs/targets/riscv32-softmmu.mak @@ -4,3 +4,4 @@ TARGET_XML_FILES=3D gdb-xml/riscv-32bit-cpu.xml gdb-xml/ris= cv-32bit-fpu.xml gdb-xm # needed by boot.c TARGET_NEED_FDT=3Dy TARGET_LONG_BITS=3D32 +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy diff --git a/configs/targets/riscv64-softmmu.mak b/configs/targets/riscv64-= softmmu.mak index 2bdd4a62cd2..f836f08c5b9 100644 --- a/configs/targets/riscv64-softmmu.mak +++ b/configs/targets/riscv64-softmmu.mak @@ -5,3 +5,4 @@ TARGET_XML_FILES=3D gdb-xml/riscv-64bit-cpu.xml gdb-xml/ris= cv-32bit-fpu.xml gdb-xm # needed by boot.c TARGET_NEED_FDT=3Dy TARGET_LONG_BITS=3D64 +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy diff --git a/configs/targets/sh4-softmmu.mak b/configs/targets/sh4-softmmu.= mak index 787d349b501..e0b51f8108d 100644 --- a/configs/targets/sh4-softmmu.mak +++ b/configs/targets/sh4-softmmu.mak @@ -1,2 +1,3 @@ TARGET_ARCH=3Dsh4 TARGET_LONG_BITS=3D32 +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy diff --git a/configs/targets/sh4eb-softmmu.mak b/configs/targets/sh4eb-soft= mmu.mak index cdea2c61c58..7850dac8191 100644 --- a/configs/targets/sh4eb-softmmu.mak +++ b/configs/targets/sh4eb-softmmu.mak @@ -1,3 +1,4 @@ TARGET_ARCH=3Dsh4 TARGET_BIG_ENDIAN=3Dy TARGET_LONG_BITS=3D32 +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy diff --git a/configs/targets/sparc64-softmmu.mak b/configs/targets/sparc64-= softmmu.mak index d9d51d21e59..8ee6d057682 100644 --- a/configs/targets/sparc64-softmmu.mak +++ b/configs/targets/sparc64-softmmu.mak @@ -3,3 +3,4 @@ TARGET_BASE_ARCH=3Dsparc TARGET_BIG_ENDIAN=3Dy TARGET_XML_FILES=3Dgdb-xml/sparc64-core.xml TARGET_LONG_BITS=3D64 +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy diff --git a/configs/targets/xtensa-softmmu.mak b/configs/targets/xtensa-so= ftmmu.mak index 2a9797338a6..6aad751e2ba 100644 --- a/configs/targets/xtensa-softmmu.mak +++ b/configs/targets/xtensa-softmmu.mak @@ -1,2 +1,3 @@ TARGET_ARCH=3Dxtensa TARGET_LONG_BITS=3D32 +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy diff --git a/configs/targets/xtensaeb-softmmu.mak b/configs/targets/xtensae= b-softmmu.mak index 5204729af8b..537407e11ae 100644 --- a/configs/targets/xtensaeb-softmmu.mak +++ b/configs/targets/xtensaeb-softmmu.mak @@ -1,3 +1,4 @@ TARGET_ARCH=3Dxtensa TARGET_BIG_ENDIAN=3Dy TARGET_LONG_BITS=3D32 +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy --=20 2.52.0 From nobody Wed Jan 7 09:26:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767129134; cv=none; d=zohomail.com; s=zohoarc; b=jS9YklfSHvyNoboOeybjEEQNMIF1/r3RziPPk1sCbxJuH3bvhXWqy4gCMpFwJ0J5AkZugAGcoQM8S1gWbF7ZHj7jOpw3p1T1Ek5nsqmmueoRzYeR0zJtyttKO/epcZmYnXF1pVvv0JlXBsuYlWtVSrQ+fCXiJ7rnUb4HEY7vc3Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767129134; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=Zu2BaYB0moTFOIMF7F4LVDdXIbTCjZNqLUd4CaPJB3A=; b=h3nZJWQ4YIEaHumGErT0nUB99MhuLIRSfh9G8hspsswt4lDXenx/vfW3bA1BXNLBqsHCJb6GNhQJseKtAwSXxi8+xSgtoRToBphmXXvAThrezsgU4NX88cNky71m2lmWw34OaS6FFEhFgx21RVu3XNnGeSDfZZZ0D2e26qt5e+A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767129134102759.570092826748; Tue, 30 Dec 2025 13:12:14 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vagzt-0005ii-52; Tue, 30 Dec 2025 16:11:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vagzr-0005Vn-7o for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:11:15 -0500 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vagzp-0002rN-FQ for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:11:14 -0500 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-47d3ffa5f33so19824435e9.2 for ; Tue, 30 Dec 2025 13:11:12 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d19346dfcsm739823945e9.1.2025.12.30.13.11.10 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Dec 2025 13:11:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767129072; x=1767733872; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Zu2BaYB0moTFOIMF7F4LVDdXIbTCjZNqLUd4CaPJB3A=; b=kky9DiBiGSuDezXkofVnWWHtCCcyQm5jyybiPUTRPUHbJ1LcfhVxuyDsaw3iP/ytWW 8Y7322IyCYb8r3lW4AT9P32zZym16CckLPxWVVGxYSy9gNiYUQtWmS+h0g0f+wczMLY/ HyRh7VZuuH+jMiVQWwXTxT2/r19J90AA7GNP9OOMrIsvHW9dnQJvvLxGH8BUBnBzmm7F 0gLAweaJBsh8ZJXh8JLaibTpATgUs1xi+BOfBnElklnwvhinUfuV4+f81Vl+WJLK++Yn xnfJEX3BadlkC3qamMwm2dBz4cxJ7eVdCoFclC4vgpoMSmaFJlmedDvkJEDGkrtsDMW2 Umgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767129072; x=1767733872; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Zu2BaYB0moTFOIMF7F4LVDdXIbTCjZNqLUd4CaPJB3A=; b=Si1Jfd8g8qPqrd84M05XukIO5R0qLTnXL+UpRDCw7VtznqwfQoifx0zsWxGbS1QexH 67JUikQHpOm3Z6AmWdf5Zu/038A6p9qEJ9Gi6ndGEJWTxAIMgk6iA2TUV+KSkXxRSG8W Z58J5+vTI+X8W1V64dWtZwspo9qqQWi5oMjL5euISP5McPW6gVJGfTVE/YYEvla3xlpV b2gjIum6JjMN5ILJ469QjeyMgMpEo+phriRWYrSFwTkEYq/XIEbOQpyGUvr9LcNu8DB7 xND3/QuV4LKOY+FNeuIIKVGefoEo8Er+ejjrhKIVduHxUU58ZJlnNSJ4YJ7ZIZyGqOlG P7xg== X-Gm-Message-State: AOJu0YzT9jULj24dlPmCJ5zv7hVyC1muBLJxRYhd+TIAqK9Gy7pGYKTZ 5WVYNw/otV+9bg6s20VjVorzFZ2eMeZhddY8Ka0ns9yyxRJBHou45gJIOR9hP3A5anNUsJIrR+7 XZDSbBGI= X-Gm-Gg: AY/fxX56UH8sOYDBKOZ4kGNc5QJpzE3wYXvvPa1TltXJ1447SNFfEq6rYbDqogRk+b8 KH6xg7cxgcMy1AXJHsffoASRAxx4r9tPqTSXvBbZ+Rfz/kOz7QzmLstib0U/u0i6crqosQfs1/s YyuE5GdmlhBIqqrdPz7nSJ5sVJxwZj60hrBYbNMqWu/Jax1g6sSrst1tK9zQ1IhrkA94Dr+Pofl QyFA83o/4U8brMh52RXmEJ0eyf8jrSK+tyotd3LjcEkgQUacZ+MNoCONZRfK1x6udjkDqsZG2D7 niFTVlRgJ/M3JAKCjnyHwdHoH3pz3ghouFGlq7P/D2wvlx+GHjCj2Qh591u8Axm1Pw3cP4cQr8f 1F496Og8e/FgI9Pala109TaZxqCo/LYHZzZALjn1ZN+xAE9IRcUcNh4egd2D2PJRNZuOrM60KUg oB7ixz6vnWh//U8pLxUIBmakbd4A/Xv9Xjp5iz1RShpgewKjVdeUFo+RlEz7RF X-Google-Smtp-Source: AGHT+IFnLUTeFZ+YjLjJp4l9qNWPh4YMJPcKcVKQF4mU5kqNsWVJkZq0R+IcntLNquLlShqXT9i8tw== X-Received: by 2002:a05:600c:3508:b0:477:1bb6:17de with SMTP id 5b1f17b1804b1-47d19590bbemr412516955e9.30.1767129071619; Tue, 30 Dec 2025 13:11:11 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 29/34] qga/vss-win32: Fix ConvertStringToBSTR redefinition with newer MinGW Date: Tue, 30 Dec 2025 22:07:51 +0100 Message-ID: <20251230210757.13803-30-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251230210757.13803-1-philmd@linaro.org> References: <20251230210757.13803-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=philmd@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767129135885158500 From: Nguyen Dinh Phi Newer versions of MinGW-w64 provide ConvertStringToBSTR() in the _com_util namespace via . This causes a redefinition error when building qemu-ga on Windows with these toolchains. Add a meson check to detect whether ConvertStringToBSTR is already available, and conditionally compile our fallback implementation only when the system does not provide one. Signed-off-by: Nguyen Dinh Phi Suggested-by: Pierrick Bouvier Reviewed-by: Pierrick Bouvier Reviewed-by: Kostiantyn Kostiuk Message-ID: <20251218085446.462827-2-phind.uet@gmail.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- meson.build | 12 ++++++++++++ qga/vss-win32/install.cpp | 2 ++ 2 files changed, 14 insertions(+) diff --git a/meson.build b/meson.build index 14b1160c15d..8111e62bf12 100644 --- a/meson.build +++ b/meson.build @@ -3241,6 +3241,18 @@ endif # Detect host pointer size for the target configuration loop. host_long_bits =3D cc.sizeof('void *') * 8 =20 +# Detect if ConvertStringToBSTR has been defined in _com_util namespace +if host_os =3D=3D 'windows' + has_convert_string_to_bstr =3D cxx.links(''' + #include + int main() { + BSTR b =3D _com_util::ConvertStringToBSTR("test"); + return b ? 0 : 1; + } + ''') + config_host_data.set('CONFIG_CONVERT_STRING_TO_BSTR', has_convert_string= _to_bstr) +endif + ######################## # Target configuration # ######################## diff --git a/qga/vss-win32/install.cpp b/qga/vss-win32/install.cpp index 7b25d9098ba..5b7a8e9bc52 100644 --- a/qga/vss-win32/install.cpp +++ b/qga/vss-win32/install.cpp @@ -549,6 +549,7 @@ STDAPI DllUnregisterServer(void) =20 =20 /* Support function to convert ASCII string into BSTR (used in _bstr_t) */ +#ifndef CONFIG_CONVERT_STRING_TO_BSTR namespace _com_util { BSTR WINAPI ConvertStringToBSTR(const char *ascii) { @@ -566,6 +567,7 @@ namespace _com_util return bstr; } } +#endif =20 /* Stop QGA VSS provider service using Winsvc API */ STDAPI StopService(void) --=20 2.52.0 From nobody Wed Jan 7 09:26:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767129109; cv=none; d=zohomail.com; s=zohoarc; b=UDBCda+x4jjAOPPXENak2FozhXYyh4b5MNjUV6A9whGdspGsGCMVzQxe6cBxQfkp52D9tkV1j7mv5WXpJ/gwTjpZvHQeVQGAXEMOy9yRTjsWQ8Q/393FtQHqIZgmKbZYeiK1Atifz2dPHPjQ/p4aACp0gIP4qmsNlWnaPe66jgw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767129109; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=DK0mq3Imy0OD9x4GM+uaaTCwAi8dtPUGh7Hpx81Zgo4=; b=PFqfnGdB29PUna76OZfcUHCVFtL25/yPse7Vzh6dOfecZMghkOcy3ONJYYAvyUrVj1uk6zrPz23XYly5/H5TYhTBJpoXfHBJUL8XJjhNQiI80i9nt43LV/RhRuzULQbq2hms4ia/8TlA9A0cWJaPbULIrnPQ8LofPcJMRKpMm00= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767129109478269.75147654887576; Tue, 30 Dec 2025 13:11:49 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vah00-0006K3-K2; Tue, 30 Dec 2025 16:11:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vagzx-0006Ag-Mk for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:11:21 -0500 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vagzw-0002s5-2y for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:11:21 -0500 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-47a80d4a065so51651395e9.2 for ; Tue, 30 Dec 2025 13:11:19 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d19346e48sm597817615e9.2.2025.12.30.13.11.17 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Dec 2025 13:11:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767129078; x=1767733878; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=DK0mq3Imy0OD9x4GM+uaaTCwAi8dtPUGh7Hpx81Zgo4=; b=QKFFRkncwAuRAJsuDYAT9fodRqEzKbE3tOvzs8RFWm28QbHlkD1UszpOMR1YmeSAXw in047styG9NgJce01cy7D7azbR+4qIyTqJ6bhJic1/qyp9UampAfQBiC3+CaAXzW9e/C gUxR384RsmWNgB/KCfmIneTdOCFwIanT9IHAACYbVPEVdrcMdgrYCjxYA4+A2R7cNb6C kiFpMsruj3XxubCKqNIhn3gxEwM6XYRibO29+g87F23m7coq9y8XUTFw8iGbim9rxpgI 8Mbt79ZkSYgEf+al92c29NBaqp1aYm/l1JXPoqnniOyk+g8z3VpzlkYRWrxL3S3ootvx SAyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767129078; x=1767733878; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=DK0mq3Imy0OD9x4GM+uaaTCwAi8dtPUGh7Hpx81Zgo4=; b=OLOW47c3sIivNM/v++bQVLOnQ0kL5ENERvKgIyMKh+YSoDJ/T+6/5Kj1AFDh3V3oU0 v9kzSVzE4U1Wg/cY8zf4WePz9VpqE8AHwk1SOFuNWcvHYzlkZGVW579m5xl8bPEcFHjZ GMF2w4bkZY9BQt6NmrH+6kE/fh0DABmVV9ms6uOGoXm9E1sBaMu0I7euR7CNxUSOlRM0 F/HKCUw7USoxsaKNNZDPj9gGi28t9WoO4InN9s65sjPK7eA0a+Wb1b47fcfghGZE8thy QtQYqPafTkICy2q+rvLDv6GZuzJWDooJnKO5X5PZgSMQX5SuLQDOppLorwCLQCuaYtID JBSg== X-Gm-Message-State: AOJu0YxHsdMpsAep2XMnJ11QRoyuu6xFqyq3b0ajfZVmL7eWQVc8sFr+ 6OBCaJLGOH3i6EGgQ0J6aqsqTTpPRQBz6XRAeYDf7S2FbMEn++lTWBOR+k8SUXjpAQ1XLd1d3yg F0DDvtss= X-Gm-Gg: AY/fxX78VLebH+MMWqjcbf+F6p3tMAl8z7X+0qUKHsYYCoKMsuxgf729uBwOGe352GH Q8XNDtkHKHV9gJ4WpFRXm5mge7QdKRRGGlx7IBjpvg0MiNZdltdxP+PV7LH/Fzg6UaDTMG9VBfs A1R3a233yIrLyF/CdFlZ/8QqZa1ELYCPPVHsN6PXChOLTPxDi4bY6bQKFS9iecJZ3EYhlnawlb1 4KVafafcFrl8plb6b7HaWcfD4R238Txq0EF32gu36e/VdzaxZkRX0YU0HqxeI8cVJayThgbEj7q GZdmITh4E4u1NAHBZ0IwZVRc0E4aKSBHz4hJvt99QFka0LuZLflL0d3X+HBwZUykCEu5kDx36hn 4qCR4kTaPrnyxtG/z/eFrh/uHeiLF3WNW6EBMDThVDCshJ7cykE2Wm2xcU93NXEHBXnrrBa2piV 6Fn1s7+oWz8coVTdjgAK8Ka1SeldNrKm6L8l3pEHltZyJBF9gOXp0/Skz9CVmhoxfUxtjmXJo= X-Google-Smtp-Source: AGHT+IE2F7DhkxNEtfOf2eklwmbApFPpcM98snmmVlx2xzbXi7i3GIOlSsvqJma4Bi0YXoMI2xTaMw== X-Received: by 2002:a05:600c:4f15:b0:477:b734:8c41 with SMTP id 5b1f17b1804b1-47d19538dfbmr457544785e9.1.1767129078117; Tue, 30 Dec 2025 13:11:18 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 30/34] util: Move qemu_ftruncate64 from block/file-win32.c to oslib-win32.c Date: Tue, 30 Dec 2025 22:07:52 +0100 Message-ID: <20251230210757.13803-31-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251230210757.13803-1-philmd@linaro.org> References: <20251230210757.13803-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767129109818158500 From: Nguyen Dinh Phi qemu_ftruncate64() is a general-purpose utility function that may be used outside of the block layer. Move it to util/oslib-win32.c where other Windows-specific utility functions reside. Signed-off-by: Nguyen Dinh Phi Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Pierrick Bouvier Message-ID: <20251218085446.462827-3-phind.uet@gmail.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- block/file-win32.c | 32 -------------------------------- util/oslib-win32.c | 33 +++++++++++++++++++++++++++++++++ 2 files changed, 33 insertions(+), 32 deletions(-) diff --git a/block/file-win32.c b/block/file-win32.c index 0efb609e1d5..b00039bf945 100644 --- a/block/file-win32.c +++ b/block/file-win32.c @@ -170,38 +170,6 @@ static BlockAIOCB *paio_submit(BlockDriverState *bs, H= ANDLE hfile, return thread_pool_submit_aio(aio_worker, acb, cb, opaque); } =20 -int qemu_ftruncate64(int fd, int64_t length) -{ - LARGE_INTEGER li; - DWORD dw; - LONG high; - HANDLE h; - BOOL res; - - if ((GetVersion() & 0x80000000UL) && (length >> 32) !=3D 0) - return -1; - - h =3D (HANDLE)_get_osfhandle(fd); - - /* get current position, ftruncate do not change position */ - li.HighPart =3D 0; - li.LowPart =3D SetFilePointer (h, 0, &li.HighPart, FILE_CURRENT); - if (li.LowPart =3D=3D INVALID_SET_FILE_POINTER && GetLastError() !=3D = NO_ERROR) { - return -1; - } - - high =3D length >> 32; - dw =3D SetFilePointer(h, (DWORD) length, &high, FILE_BEGIN); - if (dw =3D=3D INVALID_SET_FILE_POINTER && GetLastError() !=3D NO_ERROR= ) { - return -1; - } - res =3D SetEndOfFile(h); - - /* back to old position */ - SetFilePointer(h, li.LowPart, &li.HighPart, FILE_BEGIN); - return res ? 0 : -1; -} - static int set_sparse(int fd) { DWORD returned; diff --git a/util/oslib-win32.c b/util/oslib-win32.c index 839b8a4170e..5f3e8f4d980 100644 --- a/util/oslib-win32.c +++ b/util/oslib-win32.c @@ -899,3 +899,36 @@ int qemu_shm_alloc(size_t size, Error **errp) error_setg(errp, "Shared memory is not supported."); return -1; } + +int qemu_ftruncate64(int fd, int64_t length) +{ + LARGE_INTEGER li; + DWORD dw; + LONG high; + HANDLE h; + BOOL res; + + if ((GetVersion()&0x80000000UL) && (length >> 32) !=3D 0) { + return -1; + } + + h =3D (HANDLE)_get_osfhandle(fd); + + /* get current position, ftruncate do not change position */ + li.HighPart =3D 0; + li.LowPart =3D SetFilePointer (h, 0, &li.HighPart, FILE_CURRENT); + if (li.LowPart =3D=3D INVALID_SET_FILE_POINTER && GetLastError() !=3D = NO_ERROR) { + return -1; + } + + high =3D length >> 32; + dw =3D SetFilePointer(h, (DWORD) length, &high, FILE_BEGIN); + if (dw =3D=3D INVALID_SET_FILE_POINTER && GetLastError() !=3D NO_ERROR= ) { + return -1; + } + res =3D SetEndOfFile(h); + + /* back to old position */ + SetFilePointer(h, li.LowPart, &li.HighPart, FILE_BEGIN); + return res ? 0 : -1; +} --=20 2.52.0 From nobody Wed Jan 7 09:26:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767129123; cv=none; d=zohomail.com; s=zohoarc; b=jJfNQ6rlgPDxGmmT64wBORxfAm+ZUpqYlTvULGvLe2S9tCl5DL+8OrE00rCEn37N6suevr0cbiMQYvVI53sLqfiQhfhDWIjdvNKkljRm1nvloAyPGRbJZuV2tfP98VYd7Ggt/oRbGjINHYhIMIXCbUpTEY9nHer+GzfGtFpTTRE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767129123; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=5rXIIuuJOx9dPiHg3QhjGbzovkvDH2p8y3rHgXwhNGI=; b=hyAUW1cnLHZWYBRONQVeG16s27vKQp9rU6yywGxpamASZdOR4QGRBWD6ZF+awgaSI6mKIE1uiAfucAWQLsLAB46SP0YKpolfJszBuFpfTyP1wmL4KVMb6KAdU7bgA8aMZe67ehk/ShnD97+NZPthdW+Y38wfwlXbnuwqybpkA+I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767129123103845.6916321503961; Tue, 30 Dec 2025 13:12:03 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vah06-0006lL-Q8; Tue, 30 Dec 2025 16:11:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vah03-0006YQ-RV for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:11:27 -0500 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vah02-0002tD-Bk for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:11:27 -0500 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-4327790c4e9so1826959f8f.2 for ; Tue, 30 Dec 2025 13:11:25 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea830fesm71328031f8f.20.2025.12.30.13.11.23 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Dec 2025 13:11:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767129084; x=1767733884; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=5rXIIuuJOx9dPiHg3QhjGbzovkvDH2p8y3rHgXwhNGI=; b=bKkM9JKeN4UQGCkUO1hVTkY/IdrFjYQ+uXAWZsut9TsgH2dYBO2RqwLe+SuVxgGKft B9tLBZvmhuVlydT8LUrjoh3dLkoKBtWcHMZS+H3p+KJ0Xz6MtlCqpy1kB/CqsayoJfHB l71yPL3pJGjSIaD7TfJBBoOIXHlOmkeGKbZRnAkKtMV0PEqiATP5oroz4lj6W5YzdGG3 ZhNkBT6n1TvPurydWSGMzM7RfneopcAn3owyU/1vnRj54/+M8eBBjZcVAQfpo7h/0tvN UBXvOO1eamftdSLapocWnY6XqToUrM3RmVZsYGT5R5O1zzeBMnshVm32GRbaMV9wuYER Z78g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767129084; x=1767733884; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=5rXIIuuJOx9dPiHg3QhjGbzovkvDH2p8y3rHgXwhNGI=; b=QYpFIY2L4UOhe6Jnk+FbWENX28y77R/4RP3iWYWevVPbb1UITRrJEY6A2ZvA2dXyP+ xEPABhpaRMeEA/OUl81e34AbMCN/Sue1qM1d4cW0WscUd4bmXa5w0H+V0ZJKdcopdeqD dm0fn9Bjzo2MRJ3Ycl2gt3zQDdhInnNzBES3E7TNOnlc2U3abAHtAdB0zymWfdgwisSA hcNNcBgbIqbmuyNiRBoochEc3VvLjxN4gwlzPu7vjXjEqo9rtPJBtDfYfTGO/WPnDb7M rSj4VL7JZ6LNJHxMwtYKgLaz/4hRB7iqt6+LnEAWiwTY2JvOPg72bTGm85nJmCaUeXJL QkLg== X-Gm-Message-State: AOJu0Yy4cxQrFNV19hMAglqaQh+S5UjuldftsThT+hE36/D5cRMzzbyf U19NzHKLi4y9+BLTilpWSJy4WCk9pINAwUs94ihXIVQDAgogi+RwwIU5EF7aa1HAh4pSDnU2WW/ HRAFTpco= X-Gm-Gg: AY/fxX6fjYUWF1brUC6L9C9EIoF9SCI1pDxzWtYOkJcEtuJDvtYiJT4MR5Opd1e6Wlf TcFIaBUZkAGYOkpCV5rryUcddTZfUxR+fQK3glXXQEi6cdysitgrZRbt5HOfLrY9pPLHq9gbYcG wRyo8qaiV8FzoP9T9Jx3m2LO5uXwC/+GfjJz4fC78yRhjKiQvNyFIWU46y4MRsQETxZ4M0cRhFM vLsQnmHnysZ5rWi7vAec+D/GjkFStTsw5PcCNc1YUIPXMUd6hPFxcmfKwPvmIQnogRsiKeBWbEK 0kLjqeU3R7Pf1bSUThETJkaf4q6jScrLtYJP8/0N6dUOwxT+lwByWj2miFaH7VaBMK9xRH7z4KQ 9Cbt7ORLaDgNUZWYT2/clJHdGif533s7o9GCXlUtGN2Xat7ekiM+SZ46PSHzXhEmWXQ4behGTe5 MaKpojGBVG7BRACy0L2p7L0CGw081pPU+Hb0uYl3b+Tnp7LWJgHFt7s2cx7VJP X-Google-Smtp-Source: AGHT+IGWW7US14n06nI61jlc48DbuXSqiaUziOlB0rvaawxFfX1LYMSJ0jE6y9gbljxyR9r9OjGO7g== X-Received: by 2002:adf:e588:0:b0:430:f742:fbc8 with SMTP id ffacd0b85a97d-4324e4bfa36mr32490091f8f.6.1767129084501; Tue, 30 Dec 2025 13:11:24 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 31/34] hw/i2c/imx: Fix trace func name error Date: Tue, 30 Dec 2025 22:07:53 +0100 Message-ID: <20251230210757.13803-32-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251230210757.13803-1-philmd@linaro.org> References: <20251230210757.13803-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=philmd@linaro.org; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767129123995158500 From: Alano Song Signed-off-by: Alano Song Fixes: e589c0ea9c9 ("hw/i2c/imx_i2c: Convert DPRINTF() to trace events") Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20251218141144.51001-1-AlanoSong@163.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/i2c/imx_i2c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i2c/imx_i2c.c b/hw/i2c/imx_i2c.c index 88269653e2c..9b2d10060ca 100644 --- a/hw/i2c/imx_i2c.c +++ b/hw/i2c/imx_i2c.c @@ -151,8 +151,8 @@ static void imx_i2c_write(void *opaque, hwaddr offset, { IMXI2CState *s =3D IMX_I2C(opaque); =20 - trace_imx_i2c_read(DEVICE(s)->canonical_path, imx_i2c_get_regname(offs= et), - offset, value); + trace_imx_i2c_write(DEVICE(s)->canonical_path, imx_i2c_get_regname(off= set), + offset, value); =20 value &=3D 0xff; =20 --=20 2.52.0 From nobody Wed Jan 7 09:26:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767129135; cv=none; d=zohomail.com; s=zohoarc; b=MSMCGuZsyavzSYTZ9I8wjI/m97y6KSDWVV3YindB7rT0ReLGyBO3PllYja5QnGNOZ/0vrMGHQGGjxHiT28Qw/dt12UMA0z2HpGLfIlQUAfhNuDugXHrEOvP8NmewuyJYMkhtCgK4ZjWZqxa0Gk2lRLACjKHjSdOr3CxP03Ms09k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767129135; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=H4lmZbkpIbKlo+Cbmsb70+Gpr14aO3pvkdUUaISmtEc=; b=X5MeUT6ocXN3gRFJvIC5HGgOaviY+SLelOEFHj5QvksYtiruoFfCvA3znzNStNTLx5oauJBz9ZqQDpw+5CnSN4w/hgxHo6fPXRZ7wzOO9VXUEoySGJ+uelGqnGIFDFqJli8Z5tGZEprH98hCImHnKpS8hI4nltZIW9G/ab6OpEc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767129135578550.4757680060491; Tue, 30 Dec 2025 13:12:15 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vah0C-0007J4-HY; Tue, 30 Dec 2025 16:11:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vah0A-0007Ak-Ep for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:11:34 -0500 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vah08-0002tj-Qj for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:11:34 -0500 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-47bdbc90dcaso64181005e9.1 for ; Tue, 30 Dec 2025 13:11:32 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be272e46fsm647306255e9.4.2025.12.30.13.11.30 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Dec 2025 13:11:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767129091; x=1767733891; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=H4lmZbkpIbKlo+Cbmsb70+Gpr14aO3pvkdUUaISmtEc=; b=Hu4Jo4lYgfyOpMmkotlf3NOeZC41/AGek9U4y0n556bwUXEW6t5Sa1+G18Iv6AuDLh 0R8gQTOm3NcU8+V8ZHpfyQn6hQdPdEfgvVyLyyUp7PXmWUsFkjIwvrOjuTedoC29Qvx/ 6FHGdDU3EEP9DUxy5KCMm+uC4xsh604ZtPs2gZUc7eiqmYw7VuirsqAOKmhpkJrKspQ6 fE5ZXICoBMK11Vkhg8JSRehkIjCihL5kwZsyJtnzAkslSzCr7umaH6gHgk65G8aIEzn3 POdVx4aFTdkd+Y04p6OtWUrntBHJW8vTPQQ9hf4XU4NGrEL9eha/pqcyaisRTN3oKRUb dOjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767129091; x=1767733891; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=H4lmZbkpIbKlo+Cbmsb70+Gpr14aO3pvkdUUaISmtEc=; b=D5WMLICO+ZTPoQbriivrMIKg6uLWJKws+DW+e74NVNWNQ55cjbqsqq+kmsYlcEJ34B p8ox22m1HCWf0d4hwOQKDUcTSvCKgzsPPeW8xURBMyTMbxgfrqxTIIWcjGVzpj2wgKpT 0ptP3lT6Ribbt2JWE450Mk5sBOLhh4vZIjwEM2X7wq2vJR/hrkw30D3Rr6DnDRd/kvqg lnpOKPhE/Fj9DgxrrMuXBJgobm0QzGEr2bQ/7thj3Ol+qUfq95SnSOnjyfE9Qjq9zw3X CeYgCrbSxLRekbsDYyu8KvP3EQUms/D3vtunw49n2gsR0TcJ1dqNcXzhAQT/xQ7ZW+3z w5WQ== X-Gm-Message-State: AOJu0YzlKbvCij+IeZBBreQ5cThNapm65J5xO/AIOBGP7ogSX4dn8kOH WuMfUM41jURbPnfTaTtygHYI4QNiRvyG/GOtWUYstEoh62Bb2Trn4pnNjefclbtIxgDiRtcI9hf dcm7G0oE= X-Gm-Gg: AY/fxX5Zt4VE+acJUly2z2U8qRHAthQMGAKXiLHW4l1q8wvHH42vgDS6aTiQ0bLdGX0 Nv6KmxUkm02CQrIvHlFI/j3Z7mYUknZPeLgIhcoZTDOA3NbYLXNQvpVtca+msH82iId1nLMCv39 3TJfgYT8ZHoWaUZqpiIg7IW7KN+j+n/XgQ7sFFRcb22ebpN7YP+6M/7xrIgrR6J6gVLKMh2qrZs rgOh4KYLv6HmYL+FawssOvG5ZpqOwbjBTXQ95DPqMkmjoSzXrJ22uY/0xCSGYdko6EsFrEmxXhV VR83IPIaohU/dp50Co+Dh6HoPxWcyjojz+JT+RCgBvkz3OXSM7r1hJ3f2CMAAuHJ8OQlLZh6ikC I+oVbxGIZs1QSyplohKV+zdO+a97NNPojQADBEnid9bY4hgwUFW4jOPmQ4UMbKxni3BnOHlag1b B74Efwxf96lGnvKFFMCR0iL7RKKfI0V5CeE4q1lknFS4ir7dcoZS10+A7amb6i X-Google-Smtp-Source: AGHT+IGI1+kt8tkkyfZ373Hv3dpdD98aEP7ptvaUpzxoq7ROk9LtEntYWqi/ouzJNJYnPoEKDNQZyg== X-Received: by 2002:a05:600c:470a:b0:479:3a86:dc1f with SMTP id 5b1f17b1804b1-47d1958e43emr322603395e9.37.1767129090876; Tue, 30 Dec 2025 13:11:30 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 32/34] meson: Optimize summary_info about directories Date: Tue, 30 Dec 2025 22:07:54 +0100 Message-ID: <20251230210757.13803-33-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251230210757.13803-1-philmd@linaro.org> References: <20251230210757.13803-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=philmd@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767129135955158500 From: Bin Guo Clear summary_info first, otherwise there will be redundant output about build environment. Signed-off-by: Bin Guo Tested-by: Alex Benn=C3=A9e Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20251219230456.37178-1-guobin@linux.alibaba.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/meson.build b/meson.build index 8111e62bf12..db87358d62d 100644 --- a/meson.build +++ b/meson.build @@ -4650,6 +4650,7 @@ summary_info +=3D {'Download dependencies': get_optio= n('wrap_mode') !=3D 'nodownload summary(summary_info, bool_yn: true, section: 'Build environment') =20 # Directories +summary_info =3D {} summary_info +=3D {'Install prefix': get_option('prefix')} summary_info +=3D {'BIOS directory': qemu_datadir} pathsep =3D host_os =3D=3D 'windows' ? ';' : ':' --=20 2.52.0 From nobody Wed Jan 7 09:26:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767129133; cv=none; d=zohomail.com; s=zohoarc; b=VPdgSiOjvKNGZELQB8CDmVNa06xVngzSB7SRAtrZxOPjPmoUAgynSozV1DxtnWH3Nu1oLqFb6og98AOQksPSSQLmm6ucu+wsgh2ublfL6MJkC0PLbyeVbv9hp9WCCNW+o0G8H7YYjyLFDf2osmKIqhXhDTVOW8XucDXjCK5CC/o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767129133; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=L6ML9swyx3/50z1k31zOpaJrNweHVDBzQiceI3AV+jg=; b=T6d635CZkBrAdXBdJJqrCzbY8sL+rbuBr5o7K9CFH/FSYO4dLhxaYQxj/tBAR3dvSQKkgHYZOUFxXqldoPxTI+iBKRMt9AsS5wrY4oCjbdJm4mduCVwLxlAgXRa+RklNdu2vveJO7WbaIu5xeAr3UxpoSS7Y4rynOJuhkp7QOqo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767129133788605.5523588170255; Tue, 30 Dec 2025 13:12:13 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vah0I-0007Nm-4M; Tue, 30 Dec 2025 16:11:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vah0G-0007Mw-Me for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:11:40 -0500 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vah0F-0002v7-6W for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:11:40 -0500 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-42e2ba54a6fso4460689f8f.3 for ; Tue, 30 Dec 2025 13:11:38 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eaa2beasm69062242f8f.33.2025.12.30.13.11.36 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Dec 2025 13:11:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767129097; x=1767733897; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=L6ML9swyx3/50z1k31zOpaJrNweHVDBzQiceI3AV+jg=; b=ADyubTHfRfHlUnbFXAdFrOLyq8Eu2o0IE03Xj4fx5Ni09g7EsJ5BJmG5rFakl/eGuZ 3K+VEsNxNVljNiA8LK41Kk7j0mP01v671VNwOlfKmMsDrrld0B93koPWvjjh6vBxFToX C3G/itaeV/4cyNe7SZ7nYxuGDaZr1jUaPrYvxz8RkoDZVEgIP6KCAiy08vmwrtL3VgQq /I54XVQLgwF0Q1pJJttMlolt0OnzmY+jSTxdicPsIU59nsGQYbgR62ZSQ+D15oUj5/wr LUZKXOtwlRzFFaDSZRq51JKVjtHCpVb1/L6NjlK/93BO/CIemYjS1GaaE+u/lSFRsmCs rB8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767129097; x=1767733897; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=L6ML9swyx3/50z1k31zOpaJrNweHVDBzQiceI3AV+jg=; b=tfzij/w9oks9gp4OhCoBPywBZeS2JenTfXXcVTPB03uv/g4OqpWNBAnpIyQVu0qTkT 7SBHNfrBsKyLn3bHANHUF7GfX1aLGqWsp8TZk96YLQbr2ssREhGhgNILBgzQZryop82j 4C7mnKT+E/+Yhsk+e0H6n/E0xoxad2BEgTt+7FI0TOjcqAe+0TQb4I1xn5zczazGtsmv 1r7JOHUMMV0hPiUN7iUPPvZzby3DRDSQ6Fhb0Qmy2TNe5hHC+IhA/iqYk0KCpj+ShpQx P/qLolNhpfq6RZCB6TiZedwLlr/QwnfJl8Huf5dQ/pGJ32MpE79wwfikL5Ix8OikIb/l 9Biw== X-Gm-Message-State: AOJu0YxnENUzghc3W1QbG0sNYHkyORaYOuOt+HWAM1SpZKx6k5WM4iqu bOv/kMT+1PsSbeVGnk9IFAAEYNhVAEptaoBA9HjueUtPXzVXdPeZE337upzZDUDzPmlW9MMvSgN cpkvfFQ0= X-Gm-Gg: AY/fxX6tsPzEVnQMTTXmt60ThcJBcwJ9fCJ5aSuvIk6LQ3ufPacndB2UVHEoo4KtBOT 8uBJwQCvF59ao2OJdsK750HEUL0aBngGF+HqrvxJZUgzafjmDUYpQz7gPLQ4jn8ynv2CwIEuvZa L+kr8zri8BaAfLEzsGJq3nktqNJd4OzWOpY2/OfVaQFtbDWoqapbHSU85X09SJO/AaUDE44Lf8Z sldjM9CJyBAHg6aN513aMF1uER5vZAA3nyXlIkwRlbbkUebR0GyD59OklCcHjAFzlbS6fzDrVGr xSFTG14AIZjD0XsomSBzaKwMzNkVghxmBLPpuCLhv3NYG9zUJuI1L1DmOHJW64Qg5Y/G6R66dLk DYQFqp8JIGsEt8YEHzeS2A9XFMIR92mf2oV+S6ZlaactmEbKIuwq71leQecA1PeIYo4wccjXvmP 7SAFxADum8b7M9PT/WLRdCzAfxzWhj5EqtQhHKqGCnf2MwaUXHvdXO4jPAjgET+TiYPVUOPaM= X-Google-Smtp-Source: AGHT+IG/a7SnuP7wprj7M5p94oVcAcENC8Kw/RvUxRG7Rh4yWDKYWbBkpVc1NdXqbasatAeq2LJhLQ== X-Received: by 2002:a05:6000:24c4:b0:430:fc3a:fbce with SMTP id ffacd0b85a97d-4324e4c9d45mr50225063f8f.15.1767129097256; Tue, 30 Dec 2025 13:11:37 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 33/34] MAINTAINERS: remove old email for Bandan Das Date: Tue, 30 Dec 2025 22:07:55 +0100 Message-ID: <20251230210757.13803-34-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251230210757.13803-1-philmd@linaro.org> References: <20251230210757.13803-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=philmd@linaro.org; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767129135868158500 From: Stefan Hajnoczi Bandan recently left Red Hat and emails to his old address now result in bounce messages. I contacted Bandan and he asked me to remove his old address on his behalf. Reported-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Stefan Hajnoczi Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20251226083207.506850-1-stefanha@redhat.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index cbae7c26f83..1b4fd48935d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3543,7 +3543,6 @@ X: tests/qtest/migration-* Device Fuzzing M: Alexander Bulekov R: Paolo Bonzini -R: Bandan Das R: Stefan Hajnoczi R: Fabiano Rosas R: Darren Kenny =20 --=20 2.52.0 From nobody Wed Jan 7 09:26:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1767129139; cv=none; d=zohomail.com; s=zohoarc; b=CTz5yVteQQSBVvcPjj5wv3+kEgavus03/jnSZJeWamkcOEaDToQIeWogwHcYcJqfzg6UayQSBqJwRBLTTBQ6ILJ4iEsGS06zjmeBDuY4nzRg4M4XAluKIysDead9FZ+cSSYv+zGuYwzpef8vg2C6aXD2p9vM7E9K83psyW07p5Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767129139; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=kJzV47Vvj6GDTqW3GrUAatkuKHl3RZvRZn1ylCKI1OE=; b=Gs1zalzMgh2B8w72w31M6tnKBD/nWpuGuELLuApvjbsTmQ/6CjyVgaGJLzGRf8jJb8Di+sTY32LN5cfgoHr1SrZFyLOm/eckSJ6S6Dhcdind2nlYnq/vSwnxDG7zGQomicF4lCnmu6NjjUXt58mLHo9T2fo8bbjjnvIGFaR3R7I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1767129139873750.1716747113975; Tue, 30 Dec 2025 13:12:19 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vah0X-0007rO-BG; Tue, 30 Dec 2025 16:11:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vah0N-0007b5-SJ for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:11:47 -0500 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vah0L-0002vq-N7 for qemu-devel@nongnu.org; Tue, 30 Dec 2025 16:11:47 -0500 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-42fb2314f52so5776529f8f.0 for ; Tue, 30 Dec 2025 13:11:45 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eaa08d9sm70778311f8f.30.2025.12.30.13.11.43 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 30 Dec 2025 13:11:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767129104; x=1767733904; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=kJzV47Vvj6GDTqW3GrUAatkuKHl3RZvRZn1ylCKI1OE=; b=lB4QNPdYxx06UzMmcAfZeW0s7kwUHmCx8Hbn0n75v7EeE3Mz/O4RZi4KU6jzE1rD+3 zeInuYZIrI7em8VcmXS4xmAZrEjhPLR6B6jPbGG7lOBpsv30/SlNyo/MyCsDuRDflmxQ GGP44p3+lbz/P1yOwL+MPbFJd2z/TgOoZOttFqYKGstd/aiTJgD8Md7D8B9X8GXZOSHo w5mkESdyIT5TzKHa3QsywUL8+vXPKnw4S6DAd/82FqW0yf+v/3flfBv3tN9ud29d0WdH IWY7ovpqqqos0HZsjZBttAlfiUzJNlYI+s26DpbFwLz8oSoOHSFm9F3g2u4kLCOHPW6r 4NpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767129104; x=1767733904; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=kJzV47Vvj6GDTqW3GrUAatkuKHl3RZvRZn1ylCKI1OE=; b=PMZyeSw23jewZGgVnk5tOlT2rjCDZoYfGNIctoeE32t4xr0eHu1l1nbK8YTCnZAZVQ 6UP2ltJgyPM3aQUlv/ImShxXDrtkpm9AveScMektrYvKllzE79E3B1bI4A90eJuICHDZ gQPI/l5r92KyhpBq0IUCKBcC0INoQDU4J0YFud8XeZQk6KrMGRnHXxUiYwBNpgchj21+ 6mJZZg1iksRdZNTUrxfCxiVfgCOeMzQX1bx8tVGFV5FUI6eDjfebIWS/od1LNeduyn9v Vi7fqMtpmsE8XNBlYi0aEw31pOKe2XKiS5wwJxxblECNzUjI3EirBCL/9v0ieiz2D+Eo Ozew== X-Gm-Message-State: AOJu0YzfzOVaHKVsVwRETxAHb67j96bburcpqP9FDm07ud2KRvGUNgMT unZINW4501gFj/lySVSWUEvw0031cxUUqLtOsefv96sxSZzuzeF9xuru1N6Bk1Cr42K3xTzXOS1 pz/dUNhw= X-Gm-Gg: AY/fxX5mAhyhNFRq30ShOJjo26XiOYbGoxzFIHwRutUzAevAi0mFgPvcWINX9sYSTWL XS6E1KhSNudZS9ndjZcKPOdaEx6rZ1KJuuKg3aE2lgsyzcgqu+gT1OfZUaGnoVfH6u0cbUTbAyg cPcKLAYw/ToeQ7Dx2koCKUm4z7rqaRHgRHeozaS7afsdI/7sGh0En0RmgRCJXjMKcipIFfKVs6I YD8JZydCXAN3EPMI85T8l5oN/I4qcD4lCR4sj3gOhNPHCFqNlhx2Chbs+Xr4leZ/obGgVWI7CJn LevAus7q3ykpQp9sTwayQhN2i9wfu8PLTuvdB1yxP1D+jyTehUY/J6mSSCy+prDQzmfwacOtEIY Kv4nGHc4r0Ts7Cdcg3ILLwUQgdcGkFRxriYr9W6zj+E4GI2QXjkwpiNKCm6c30l4zIYpvtSjyG5 iehMw9bDLmfea8TRfM7PVRi54BAEVNjcvzoXT2FdzkT4gydExFFX3XzRwelmpP X-Google-Smtp-Source: AGHT+IESUFX+P0qq9X61GxAWzQv1bRsGAUjPIZ4w/6HIbLxjTvMRVjubDrVPH9ZAuv0foi9Q+bmzfg== X-Received: by 2002:a05:6000:25c1:b0:42f:bbc6:edaf with SMTP id ffacd0b85a97d-4324e504044mr43846630f8f.37.1767129103656; Tue, 30 Dec 2025 13:11:43 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 34/34] MAINTAINERS: Change email and status of TriCore Date: Tue, 30 Dec 2025 22:07:56 +0100 Message-ID: <20251230210757.13803-35-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251230210757.13803-1-philmd@linaro.org> References: <20251230210757.13803-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=philmd@linaro.org; helo=mail-wr1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1767129141967158500 From: Bastian Koppelmann I'm no longer employed at the university of Paderborn. This also means my time available for QEMU has reduced significantly. Thus, I'm dropping the status to odd fixes. Signed-off-by: Bastian Koppelmann Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20251227132135.4886-1-kbastian@mail.uni-paderborn.de> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 1b4fd48935d..cca9b57c02f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -419,8 +419,8 @@ F: include/hw/xtensa/xtensa-isa.h F: configs/devices/xtensa*/default.mak =20 TriCore TCG CPUs -M: Bastian Koppelmann -S: Maintained +M: Bastian Koppelmann +S: Odd Fixes F: target/tricore/ F: hw/tricore/ F: include/hw/tricore/ --=20 2.52.0