From nobody Wed Jan 7 09:28:20 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=laurent@vivier.eu; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=vivier.eu ARC-Seal: i=1; a=rsa-sha256; t=1766785084; cv=none; d=zohomail.com; s=zohoarc; b=niwy6iQWioGpyY+jpzAdhF2a7Z2LbY0VWJlNY/prWN211dg5309P/QriJ5llfQTgQABTTR0hisjCWneCqd6cU2Qr1vLZjuQe6SIdo8oRgWh3uqq3OmR8zW+7hMcrdUhueq+giboNncB9Wufw6AYfvZhAssIPPNSoLrPVSKPK5RA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766785084; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=QAQqEihj4nMTSUsATOWQ2IgxXdkpAiIMkGFxoNhuc8M=; b=l8SVB1ndxP5dGCecDgy6fCI24MtSFQCB/jst7S6uofx/nFBiJL6Skcg/gsjHduVlw2hzEMcEFjbmf/L01ASU5FgAluEFw+60+zbwWUFbdhXPjLvOWZBZE/lH8wT1QF54B2teNFVamlKY2fIFgTFaXg2h0SboXECc/7xygsx37Zk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=laurent@vivier.eu; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766785083878226.59785012033046; Fri, 26 Dec 2025 13:38:03 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vZFUo-00085T-0E; Fri, 26 Dec 2025 16:37:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vZFUm-00085G-Ob for qemu-devel@nongnu.org; Fri, 26 Dec 2025 16:37:12 -0500 Received: from mout.kundenserver.de ([212.227.126.135]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vZFUl-0007Cq-1E for qemu-devel@nongnu.org; Fri, 26 Dec 2025 16:37:12 -0500 Received: from quad ([82.64.211.94]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1M91Tq-1vc1S62LO2-005h6u; Fri, 26 Dec 2025 22:37:08 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivier.eu; s=s1-ionos; t=1766785028; x=1767389828; i=laurent@vivier.eu; bh=QAQqEihj4nMTSUsATOWQ2IgxXdkpAiIMkGFxoNhuc8M=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-ID: MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=TwO84/dA1S8s3wsu+oxslMTAv4nXF0Ouu342AAqDijkS7koZrZm1e+du9ZfQcK8n hhY1TPcP4m1FyNvObnlCbF6E7kFC3n+e/pblxe2Ilot1vXrAqc7RRFV3tWDREve1b W34M0RbxV7Cvk0Yjkne4vPB+dnSGUFvy2eVz6yEi1+qc/wtJRyXxl2PQvh1J3xE4c wHkQw7bhj6QvaF3CPygVcDuqmOol781gp0xlG7d3aMULsRJgTGPh8Dqn3GwjM3Pax HBrl7zyugtV0NMtP0/+hwvICSfJiJ2jJmkx8lEkkMds5onRPKOPFO1X2TfcnNV1Tx Yl/U1C5whleJ2cn4iQ== X-UI-Sender-Class: 55c96926-9e95-11ee-ae09-1f7a4046a0f6 From: Laurent Vivier To: qemu-devel@nongnu.org Cc: Laurent Vivier Subject: [PATCH] m68k: fix CAS2 writeback when Dc1==Dc2 Date: Fri, 26 Dec 2025 22:37:07 +0100 Message-ID: <20251226213707.331741-1-laurent@vivier.eu> X-Mailer: git-send-email 2.52.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:BgZh4fArkLsX1kI/w3LXy6s+g61EUJt++GXLNdA8eEEIaJrqwkW zG4YfD1hQzkyZ1AUGnF7qdTCU1YXbNCPGL/3K/T5WOmmSHT3NPua25jQfz6AbSOHKEl4jRR rSCl/4tXhACgnmPCTHC2gNV77+NplVacDq/o5gpAfENLb9TY4KzZThfnbi9WHtxyDFU1wox op3vPVYXVXD3usWWE7+qg== UI-OutboundReport: notjunk:1;M01:P0:m0H7JYxhAQM=;olG+EVAawZAqF5jdyaqRbMfN7ah 7hF2QF6dwGBF/7IeIu32W/0f1my8ywv21Rmgo+gckNiZku5bWky+80ralRj4TQgk2D3DGBXk8 kMDIQZ2dVZTwZ9GmYCmm+nJw41ZGzb/AAIUukkxuQrI63YSIWicHFFM2wDbMQoDFUNLfHOmpu CqasHrLcmr98FwbnRSLTPQ2LTPSmoFSv6LNuDF+niJszRyjUxSYKHUdA3JQYluOWCub2dSRvJ cvHDelS6b3CyEGd2Il6bwCK40q62B0pwcaKCfLMcvgoWtS3coIl571TSIFkVmSkeqX9D+f3w1 zjqbNv/9lT+DmJDm55ZSdmfGKNLdqHlfUsQdqnFDeo7JTS9u2bNCRbYPMOu4pc/YfK5aHXVCm JBIF6BLSDLWgdEalNgG5E9HDUuhvjPgtB5PiJnRVi3aiQ6fzCDXE0AtEpNafTt7CjxGUCOLw0 kXd/wkZquZo+CB5yai8df18AFjmwTXbe5i8VGk4OYFNksdeef/C6ZKK8qX0NImKeQiHymH/OD DQsHR1os6LfRLaGa+69OPwxYNlSRuq83dAWpxizp6+X5B7w9U6PcZiHd+gcQXbCJrCh0wI7Rt aKZG4uO37AB/bnvQxUmnfOUCYcKurgKVkGx431JXizdwLXzO46uNTLiAXplvMwNtk7Kpllbvv OYxfKrSUQ7YhFzt12uu1Ff7gCwZqaLqfzPMu+GsnBNm1vex5Q9neUpiMMMDfcs2f/1VTdH+N+ HtRf6BJ//u4kwFyiskLV73BH4E9WzqkDbYAIULBNKuPH08C7S4y48LVbVMEtOpk6I3gzQ+F8z RZG2SfBs6BbJxnuezCwCXwy/0fRHPvbaRzEM+UvWJ5Wz8exmvyYsuZskevZ9Lcb4Ji2hvmaRB hHTL9xLAHrpUQOxnZhB56qH8NMv7x02TByfRrGmUgdAeGsbgkRtsfSEDsWkXnRY53LyS4vM2M /YdZ4ryB8QWXr6fPBcv3ZezMbxZ7P4nhgI/ugN4dRy3PbIpf9thNGx6Z12ekCqsW3bWEBJRMo o4kai86Q+K7cXzL/FNPe2hbqa+dGLbSDWrhLIgwDMKSzPUGFbqd+/MgEeRA5uJFYaoD/VYpf3 WM+VvFG7gtISckWbiOfdYPcpGXsQ2YoITrFMd6toUxL//DM7VNYEo56JlUAtClrhQP+UcQo5E 4z1Lf0AbuWwJ+yOfX7p5SGSGYnfoU7fUO6OJ1S/fqg4vkFHEFjoI/H25ofSCbFlFQKFfmmUOd wKYi2ycElL/uEediETTt5ObqnVzJAtZ+VzcmJv3xKMKZ/MuBqZLOMN4tQJv4DrP9E/q9K54KH FG628uAmRSn4suidwKmM+nAkET08ioQR6b9HS0ndlSssaKB7An73iaqyCIuc4SkMAV5onwp/B kcmJjGhrHjo0K2WTfRkM9QhIGLE7ZWX1yjKwwYqYamZzm7QF2od9q1bd9SsVWZFtmFatis8gg mBFKiZ3f/kf5nVryAYzNeP3nKNE1xREcw4gHMlfzj960HNVViwMMFHQ6ZAI7x9j1+7dnqFQzP 59QRZafOu8Q25bQ5chywZuKEgN6QDT1xBPb3zIXCuze/gBl3aowq3UH/uKuNVvX+UWGaz6bST VHfOhapYRYDt4DavRh0MDBj/lnJe7J+64HMSd1us0AykiQCP3pbN19n2AyicWKza6RwYVcs02 rDbr7O66izuGY9r6VGB6wSEkMtdvJmMcBkcd/q7Y12+nBcULWwtZnUCo47X+6Dc/CGl0d3vcR GFC40wgUTZ9WLAfKv9SSczWxrUYhmaqMvH5hWX2h8PTj6BPMrcIHWCFU= Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=212.227.126.135; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity laurent@vivier.eu) X-ZM-MESSAGEID: 1766785084815158500 Content-Type: text/plain; charset="utf-8" According to Programmer's Reference Manual, if Dc1 and Dc2 specify the same data register and the comparison fails, memory operand 1 is stored in the data register. The current helpers wrote Dc1 then Dc2, leaving operand 2 in the shared register. Swap the writeback order for cas2w/cas2l so memory operand 1 wins. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- target/m68k/op_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/m68k/op_helper.c b/target/m68k/op_helper.c index e9c20a8e0322..10266b1e0e8b 100644 --- a/target/m68k/op_helper.c +++ b/target/m68k/op_helper.c @@ -799,8 +799,8 @@ void HELPER(cas2w)(CPUM68KState *env, uint32_t regs, ui= nt32_t a1, uint32_t a2) env->cc_v =3D c2; } env->cc_op =3D CC_OP_CMPW; - env->dregs[Dc1] =3D deposit32(env->dregs[Dc1], 0, 16, l1); env->dregs[Dc2] =3D deposit32(env->dregs[Dc2], 0, 16, l2); + env->dregs[Dc1] =3D deposit32(env->dregs[Dc1], 0, 16, l1); } =20 static void do_cas2l(CPUM68KState *env, uint32_t regs, uint32_t a1, uint32= _t a2, @@ -861,8 +861,8 @@ static void do_cas2l(CPUM68KState *env, uint32_t regs, = uint32_t a1, uint32_t a2, env->cc_v =3D c2; } env->cc_op =3D CC_OP_CMPL; - env->dregs[Dc1] =3D l1; env->dregs[Dc2] =3D l2; + env->dregs[Dc1] =3D l1; } =20 void HELPER(cas2l)(CPUM68KState *env, uint32_t regs, uint32_t a1, uint32_t= a2) --=20 2.52.0