From nobody Mon Feb 9 00:27:01 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1766757787; cv=none; d=zohomail.com; s=zohoarc; b=Uqko4kbp5Zy3U8QkMvaGHlAyZO+iZCmnYXm7Lm/uvDaS1ltQ5I8Nl1OyGrBjUmTv+5Xcd5NwHhzS+OBwLWr99KNzmFaCFeU1/jsK4K/bcxUQryhyOl7i6HQiCAp/3DfPAMXPn9HRkp6GcSdTIaQAEcuumhxNxbvXMoXedS/KXC8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766757787; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=8UqSM7Cdrp0m+S5aTDcKcvy6okhbuaqmG7RZGRZff2w=; b=ZGk7su0eY8+CS+kO3hZWBuyRt60jgsLyPqGs7csW12WTnhUeAoLVWDknBfZmpqz1ihmfRF2XhAY9s5FW5UqRo7ZRRxy1TBbvJrTE8C8Y//1lkqf66Y0BWoxNr/DVJpY99l62tNZlXhB2iutSYpv6jovZJoeKUnR80Y2KI6VNfXE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766757787982751.7515882888937; Fri, 26 Dec 2025 06:03:07 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vZ8Oa-0005Zc-9j; Fri, 26 Dec 2025 09:02:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vZ1Xi-0005vH-TF for qemu-devel@nongnu.org; Fri, 26 Dec 2025 01:43:19 -0500 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vZ1Xh-0008Mo-Ew for qemu-devel@nongnu.org; Fri, 26 Dec 2025 01:43:18 -0500 Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-2a0bae9aca3so101956625ad.3 for ; Thu, 25 Dec 2025 22:43:16 -0800 (PST) Received: from leeonlin-linux0.corp.google.com ([2401:fa00:95:201:2ce6:21ee:93a0:6263]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3d76ceesm198125235ad.91.2025.12.25.22.43.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Dec 2025 22:43:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766731395; x=1767336195; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=8UqSM7Cdrp0m+S5aTDcKcvy6okhbuaqmG7RZGRZff2w=; b=VsLO5MHb5iyGo3CYSM1mw1g8JunlnwW9xR0LGd7nnasGz+eMs6WYPkZ5uTBLuUwgky ETBfb4td3kQGOGaesNgmiklFM1zBzxIhfWdg76xTaabeqHnUrQ/IKVWkbRP5TpZ9Lknk XNMAIj4bt2XhmWw6afD93X0BWy2mvQidtvyCjSurnOnWdjWQCSFaIjSxGKtGaYEwSotC Jj6W5ENCqBD463eeZ8UvHv9ICFVAmypEIS5SncTINkh2NG8DRZS8jZx/OK0OqEyE/XUx fa+4PLNryRrucj2AOLJR2PG1Iw+1pLXDulOMMIPBK7PqBVEoPKp14z1DHwkn+a7GwZ76 mB4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766731395; x=1767336195; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8UqSM7Cdrp0m+S5aTDcKcvy6okhbuaqmG7RZGRZff2w=; b=CnNYzpSRQYSiuQ+J/6XhlHWADN6ZDXoRJMRQNBlmUTfeWQtv/wXthXYvhNKENozLuN HPpgZeSYOe8w6lZH4FGFfLrwmWuZk9SZ5GcHnUwUqJmhk2lBkkHgy2vtSZoDdqtqPAQu XKLIIlMhdh9EmiyUlc+yTXJwgCoI9pywA1LmpbzK4+0zqIbe++1zToPKn3Wd+4ZOqd4T cZq2nlluvve2rFrWgZxbXBqR0yc5Fw/6/+TPGJAhCOLeyZW7z35w9sVbyr8bEMphfZDR 7+bOU7Z8iGOgD/ZchePy5QOUPGG2lvDfAFPqmtucPN+7nwkJB8L66KYVN0XNbjhAYQbV ig2A== X-Gm-Message-State: AOJu0Yw1TLNVYo4q6Yak1BCyWrA+OmnTAVMUCPoq+3ALvybCHmKjvLmW AaPnHRv2x3rcN7JqhC2gVxYUMW8rHItwfgIvKIf2mL6fLosTeCCBtB1qM67au6bd X-Gm-Gg: AY/fxX7IDJVzf0+awh95kVbodtp22zm7LPOLCPLpx2yPjLK1/LqhN+NusplVtLOhPmR 2ZhtmgzCm9aPJJepXnoF3VJdM6OXrHkZDm7auX0TaGHFBYnCjlArzHgVgNhSt/Lzomxq2dw5IrL 5zF86WGmvdRJFxlnQI/mXuxo0/63IqiWaUKqciTIg8B/iBvbzq74vUlgiop85CIYCmPhngsXJUy k+HvFDHIw9cECg4NtDy8SLgqH0gKAmFSR+Raskb06hq5dos89ByZOQ64WyWayd2yGcUQ1Go/KM+ xJyONkhWOoHiiJ5OmcanX0KlWqyXL09iiYOMrRJC9qXZOtaMej0hlXOOXQGELNWZL21Z4aZZayB dZl1TxU18364IU8oxkfQWnLu4PIJeEZdy8j7fzwot82yIOfaqGpSRmAq7Q1ZAL72TjCbB82xltw SnURFIW+ZMaNPID/9g6GyPifXctBDHkdAhqXmLgg== X-Google-Smtp-Source: AGHT+IEyCloyq9pElrZo4wzt96RSvV3CDMRZk20BXmlYe3q/8kZLcjIFkWhUvkfT3Exd91FszWVDtw== X-Received: by 2002:a17:902:cecb:b0:29e:940c:2cdf with SMTP id d9443c01a7336-2a2f2830f73mr207150705ad.36.1766731395167; Thu, 25 Dec 2025 22:43:15 -0800 (PST) From: Li-Hang Lin To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Li-Hang Lin Subject: [PATCH] target/arm/tcg/vfp_helper: Fix incorrect bit field deposition in rsqrte_f64 Date: Fri, 26 Dec 2025 14:42:25 +0800 Message-ID: <20251226064225.791454-1-lihang.lin@gmail.com> X-Mailer: git-send-email 2.52.0.351.gbe84eed79e-goog MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::629; envelope-from=lihang.lin@gmail.com; helo=mail-pl1-x629.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 26 Dec 2025 09:02:14 -0500 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1766757789305158500 Content-Type: text/plain; charset="utf-8" Fix an error in rsqrte_f64() where the sign bit was being placed incorrectly. Specifically, ensure f64_sign is deposited into bit 63. Additionally, update the comments regarding the exponent (exp) bit width to reflect the correct double-precision specifications. Signed-off-by: Li-Hang Lin Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/arm/tcg/vfp_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/arm/tcg/vfp_helper.c b/target/arm/tcg/vfp_helper.c index e156e3774a..60188b2c7e 100644 --- a/target/arm/tcg/vfp_helper.c +++ b/target/arm/tcg/vfp_helper.c @@ -1078,8 +1078,8 @@ float64 HELPER(rsqrte_f64)(float64 input, float_statu= s *s) =20 f64_frac =3D recip_sqrt_estimate(&f64_exp, 3068, f64_frac, false); =20 - /* result =3D sign : result_exp<4:0> : estimate<7:0> : Zeros(44) */ - val =3D deposit64(0, 61, 1, f64_sign); + /* result =3D sign : result_exp<10:0> : estimate<7:0> : Zeros(44) */ + val =3D deposit64(0, 63, 1, f64_sign); val =3D deposit64(val, 52, 11, f64_exp); val =3D deposit64(val, 44, 8, extract64(f64_frac, 52 - 8, 8)); return make_float64(val); --=20 2.52.0.351.gbe84eed79e-goog