From nobody Mon Feb 9 14:34:56 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766595487; cv=none; d=zohomail.com; s=zohoarc; b=We6LrUk8WhkTBXtth2Gd3cZdaqY37bMc4v4C4oGLUKBBG1EOPIWdDJW85byMCeyRjz2cLnuuui6/ARWAAoZczuvQxMajnzmQq4Ngxu2Ov/a1wphd7CVxtCeBE27eiY287wRDuMS455IDE0G0uGZJpXjPfULOLWaaXNEdLDJbgts= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766595487; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=7rsuCWPKZHNnj/q3k9BZ8VH5K66mbplpSJozKaVMHEw=; b=L4wzlg85tgVu8RfKda+Xi0isLoxPV4UCP+jvcDqaa/l48YzEjbqyNe1G2xHmQGlkv08vpG4d5TogbUHM/ugt5Z500IEHUgwEGqWRyhJZe5C+2uf49lyqm6kZMt5Ja365ZHJR8GgVd1YI9rbDgKZS9AKVR5GFQ97SlZpnAZCLO+o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766595487602525.801810558757; Wed, 24 Dec 2025 08:58:07 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vYRhU-0007Wa-7y; Wed, 24 Dec 2025 11:27:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vYRhS-0007Vr-6R for qemu-devel@nongnu.org; Wed, 24 Dec 2025 11:26:58 -0500 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vYRhQ-0003Yb-1n for qemu-devel@nongnu.org; Wed, 24 Dec 2025 11:26:57 -0500 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-47d182a8c6cso25919275e9.1 for ; Wed, 24 Dec 2025 08:26:55 -0800 (PST) Received: from localhost.localdomain (188.171.88.92.rev.sfr.net. [92.88.171.188]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d19346d33sm310400775e9.3.2025.12.24.08.26.52 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Dec 2025 08:26:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766593614; x=1767198414; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7rsuCWPKZHNnj/q3k9BZ8VH5K66mbplpSJozKaVMHEw=; b=seIJ1UpWQcIECA1tGMv8+TJkg4eQcD6/tkkvJT+XHm3Yqb6Z0InuVbfXE3BwMxIwaP V1UdRHOIdP6gB30PChKE7i3O2mi0wjhrhflBoWeI1rVmI36bBJcFQxeccg+h5QqdeFyC rLE0Skh5h82wNeyCG+8x7DvdezmRjX1FSyVdx2Mn2mqLyyjzd5kO+lJdJqWGkFbodZD3 pYkWg32IJ6G3YPK27s8qI4JXq9Wq/DhhXu0NOJqroIB13cxVQZTu4ezl6JzIlKYX5cY7 31YhlT6j2k9J5ZEPS11sOpqpi/m9/Vjs4U383otCGbz0IB2fLgk4AiVEDhB+hECzki30 EgDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766593614; x=1767198414; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7rsuCWPKZHNnj/q3k9BZ8VH5K66mbplpSJozKaVMHEw=; b=dHSPQcSX+xxr7PrdoeUt+d4Ah6jAcSE3jOK5cesPCg0QQMjKFPsucPyI+3DpfhtwAz rKr9UoAc2Ax4tclsiI7rYMJLZ5NZmOueAdNOUXDGz+ms7UvfLH5xPDZz/Z+IKzAdIcWk DPAQstAokB5JTU2CJyufOLLR8RB/vrIy5BdarF13usrAZ7j2ICDLAKq9PMq7h0ZIew1u rO8cg1oUWuk6el4RLYdmn9rSKdhX7YES5IbJJT56xI4XWDvehtlzje8Mny/FnLPV7vjD 2M0tsJ7EyF1TzgytTT/H8we369nGnpghzr1OIr0ZnTO2b4izh9gm/pDt7vNaAvWXCsvk mZ0w== X-Gm-Message-State: AOJu0YwrTGjIShpjS3VDpC6gdvmyOEYAAPD7m2ZKRoyZ5HH0SNU6VuHe NfRAUcrkbCfP1ei8eTiABPNQuy7J761iO83gsgNnZf7R+gDnIkDSVGt0E9UC25IWFtubYuJitiW dCFfrTmk= X-Gm-Gg: AY/fxX59igR5o9xiEybSQfgmdrU4utXFjonNxmN/CZU4XToRUJscQDx8J+XEStl9ai6 rI/tGPmFAWNrHTmHs7EtisFBb0/SxrqsPYy3RYmTkSmmHmuoSZZvAqLkLcBRuPMMYfJqracs+KQ 1szpwX71LV7wO5e0EdWB1y272wMR7pr0tVsjbAhq//uzwqujkOg7hHiZMTcJyCj4pgaGyr/fw7p npHTS74WDeblSnbA1KYCeFE7tbxRoSwXuMxlozVhevTUEvAMRy7tSyaUzhOevUABohkZeDVdeu5 O7brer2YqNryKZiktU0pUxIbqvXMWXMMr2p6HWi/vvQpFQuYv0544B3rzXmJjYxDJSm5mty3MN8 s1Nqzl3nv9mLTijbw4QzBo7/8qGwMbAFVCc9CNmphkhj7zT6XycezuHuTuIUR7qmZlpIXbGDztB oVP1zVXBE6kG/0i6YsavfSKbXULyiJMSRslOHMhFJnGhJVVvt2fXMBDNw= X-Google-Smtp-Source: AGHT+IHhDiv7CgJAO5kNI97MVNcAvWfbW4LUY754xzCyCjh8RgBF7QsUY9EzaXBtk06tNHYD1ARMRQ== X-Received: by 2002:a05:600c:4447:b0:477:9a28:b0a4 with SMTP id 5b1f17b1804b1-47d194c6a2fmr170662365e9.0.1766593613994; Wed, 24 Dec 2025 08:26:53 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Gerd Hoffmann , =?UTF-8?q?Cl=C3=A9ment=20Chigot?= , Paolo Bonzini , Anton Johansson , Mark Cave-Ayland , Pierrick Bouvier , Artyom Tarasenko , Laurent Vivier , Manos Pitsidianakis , Frederic Konrad , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 1/9] hw/sparc: Mark SPARC-specific peripherals as big-endian Date: Wed, 24 Dec 2025 17:26:33 +0100 Message-ID: <20251224162642.90857-2-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251224162642.90857-1-philmd@linaro.org> References: <20251224162642.90857-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=philmd@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766595490584158500 These devices are only used by the SPARC target, which is only built as big-endian. Therefore the DEVICE_NATIVE_ENDIAN definition expand to DEVICE_BIG_ENDIAN (besides, the DEVICE_LITTLE_ENDIAN case isn't tested). Simplify directly using DEVICE_BIG_ENDIAN. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Manos Pitsidianakis Reviewed-by: Richard Henderson --- hw/audio/cs4231.c | 2 +- hw/char/grlib_apbuart.c | 2 +- hw/display/cg3.c | 2 +- hw/display/tcx.c | 14 +++++++------- hw/dma/sparc32_dma.c | 2 +- hw/intc/grlib_irqmp.c | 2 +- hw/intc/slavio_intctl.c | 4 ++-- hw/misc/eccmemctl.c | 2 +- hw/misc/slavio_misc.c | 16 ++++++++-------- hw/rtc/sun4v-rtc.c | 2 +- hw/timer/grlib_gptimer.c | 2 +- hw/timer/slavio_timer.c | 2 +- 12 files changed, 26 insertions(+), 26 deletions(-) diff --git a/hw/audio/cs4231.c b/hw/audio/cs4231.c index 97cceb44d86..498cd2da704 100644 --- a/hw/audio/cs4231.c +++ b/hw/audio/cs4231.c @@ -135,7 +135,7 @@ static void cs_mem_write(void *opaque, hwaddr addr, static const MemoryRegionOps cs_mem_ops =3D { .read =3D cs_mem_read, .write =3D cs_mem_write, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_BIG_ENDIAN, }; =20 static const VMStateDescription vmstate_cs4231 =3D { diff --git a/hw/char/grlib_apbuart.c b/hw/char/grlib_apbuart.c index b2d5a40bb4d..b9dafdc3e65 100644 --- a/hw/char/grlib_apbuart.c +++ b/hw/char/grlib_apbuart.c @@ -242,7 +242,7 @@ static void grlib_apbuart_write(void *opaque, hwaddr ad= dr, static const MemoryRegionOps grlib_apbuart_ops =3D { .write =3D grlib_apbuart_write, .read =3D grlib_apbuart_read, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_BIG_ENDIAN, }; =20 static void grlib_apbuart_realize(DeviceState *dev, Error **errp) diff --git a/hw/display/cg3.c b/hw/display/cg3.c index daeef152174..ca04f0c9549 100644 --- a/hw/display/cg3.c +++ b/hw/display/cg3.c @@ -265,7 +265,7 @@ static void cg3_reg_write(void *opaque, hwaddr addr, ui= nt64_t val, static const MemoryRegionOps cg3_reg_ops =3D { .read =3D cg3_reg_read, .write =3D cg3_reg_write, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_BIG_ENDIAN, .valid =3D { .min_access_size =3D 1, .max_access_size =3D 4, diff --git a/hw/display/tcx.c b/hw/display/tcx.c index 4853c5e1424..ba31d9bf29b 100644 --- a/hw/display/tcx.c +++ b/hw/display/tcx.c @@ -452,7 +452,7 @@ static void tcx_dac_writel(void *opaque, hwaddr addr, u= int64_t val, static const MemoryRegionOps tcx_dac_ops =3D { .read =3D tcx_dac_readl, .write =3D tcx_dac_writel, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_BIG_ENDIAN, .valid =3D { .min_access_size =3D 4, .max_access_size =3D 4, @@ -533,7 +533,7 @@ static void tcx_rstip_writel(void *opaque, hwaddr addr, static const MemoryRegionOps tcx_stip_ops =3D { .read =3D tcx_stip_readl, .write =3D tcx_stip_writel, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_BIG_ENDIAN, .impl =3D { .min_access_size =3D 4, .max_access_size =3D 4, @@ -547,7 +547,7 @@ static const MemoryRegionOps tcx_stip_ops =3D { static const MemoryRegionOps tcx_rstip_ops =3D { .read =3D tcx_stip_readl, .write =3D tcx_rstip_writel, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_BIG_ENDIAN, .impl =3D { .min_access_size =3D 4, .max_access_size =3D 4, @@ -633,7 +633,7 @@ static void tcx_rblit_writel(void *opaque, hwaddr addr, static const MemoryRegionOps tcx_blit_ops =3D { .read =3D tcx_blit_readl, .write =3D tcx_blit_writel, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_BIG_ENDIAN, .impl =3D { .min_access_size =3D 4, .max_access_size =3D 4, @@ -647,7 +647,7 @@ static const MemoryRegionOps tcx_blit_ops =3D { static const MemoryRegionOps tcx_rblit_ops =3D { .read =3D tcx_blit_readl, .write =3D tcx_rblit_writel, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_BIG_ENDIAN, .impl =3D { .min_access_size =3D 4, .max_access_size =3D 4, @@ -713,7 +713,7 @@ static void tcx_thc_writel(void *opaque, hwaddr addr, static const MemoryRegionOps tcx_thc_ops =3D { .read =3D tcx_thc_readl, .write =3D tcx_thc_writel, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_BIG_ENDIAN, .valid =3D { .min_access_size =3D 4, .max_access_size =3D 4, @@ -734,7 +734,7 @@ static void tcx_dummy_writel(void *opaque, hwaddr addr, static const MemoryRegionOps tcx_dummy_ops =3D { .read =3D tcx_dummy_readl, .write =3D tcx_dummy_writel, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_BIG_ENDIAN, .valid =3D { .min_access_size =3D 4, .max_access_size =3D 4, diff --git a/hw/dma/sparc32_dma.c b/hw/dma/sparc32_dma.c index 60c23b69e5c..2b6836b55ec 100644 --- a/hw/dma/sparc32_dma.c +++ b/hw/dma/sparc32_dma.c @@ -230,7 +230,7 @@ static void dma_mem_write(void *opaque, hwaddr addr, static const MemoryRegionOps dma_mem_ops =3D { .read =3D dma_mem_read, .write =3D dma_mem_write, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_BIG_ENDIAN, .valid =3D { .min_access_size =3D 4, .max_access_size =3D 4, diff --git a/hw/intc/grlib_irqmp.c b/hw/intc/grlib_irqmp.c index e0f26466ba3..454f25b185c 100644 --- a/hw/intc/grlib_irqmp.c +++ b/hw/intc/grlib_irqmp.c @@ -330,7 +330,7 @@ static void grlib_irqmp_write(void *opaque, hwaddr addr, static const MemoryRegionOps grlib_irqmp_ops =3D { .read =3D grlib_irqmp_read, .write =3D grlib_irqmp_write, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_BIG_ENDIAN, .valid =3D { .min_access_size =3D 4, .max_access_size =3D 4, diff --git a/hw/intc/slavio_intctl.c b/hw/intc/slavio_intctl.c index 00b80bb177c..6a7be888f24 100644 --- a/hw/intc/slavio_intctl.c +++ b/hw/intc/slavio_intctl.c @@ -135,7 +135,7 @@ static void slavio_intctl_mem_writel(void *opaque, hwad= dr addr, static const MemoryRegionOps slavio_intctl_mem_ops =3D { .read =3D slavio_intctl_mem_readl, .write =3D slavio_intctl_mem_writel, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_BIG_ENDIAN, .valid =3D { .min_access_size =3D 4, .max_access_size =3D 4, @@ -205,7 +205,7 @@ static void slavio_intctlm_mem_writel(void *opaque, hwa= ddr addr, static const MemoryRegionOps slavio_intctlm_mem_ops =3D { .read =3D slavio_intctlm_mem_readl, .write =3D slavio_intctlm_mem_writel, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_BIG_ENDIAN, .valid =3D { .min_access_size =3D 4, .max_access_size =3D 4, diff --git a/hw/misc/eccmemctl.c b/hw/misc/eccmemctl.c index 81fc536131c..4af106dcaa0 100644 --- a/hw/misc/eccmemctl.c +++ b/hw/misc/eccmemctl.c @@ -232,7 +232,7 @@ static uint64_t ecc_mem_read(void *opaque, hwaddr addr, static const MemoryRegionOps ecc_mem_ops =3D { .read =3D ecc_mem_read, .write =3D ecc_mem_write, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_BIG_ENDIAN, .valid =3D { .min_access_size =3D 4, .max_access_size =3D 4, diff --git a/hw/misc/slavio_misc.c b/hw/misc/slavio_misc.c index a034df3592f..aaca89de734 100644 --- a/hw/misc/slavio_misc.c +++ b/hw/misc/slavio_misc.c @@ -147,7 +147,7 @@ static uint64_t slavio_cfg_mem_readb(void *opaque, hwad= dr addr, static const MemoryRegionOps slavio_cfg_mem_ops =3D { .read =3D slavio_cfg_mem_readb, .write =3D slavio_cfg_mem_writeb, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_BIG_ENDIAN, .valid =3D { .min_access_size =3D 1, .max_access_size =3D 1, @@ -177,7 +177,7 @@ static uint64_t slavio_diag_mem_readb(void *opaque, hwa= ddr addr, static const MemoryRegionOps slavio_diag_mem_ops =3D { .read =3D slavio_diag_mem_readb, .write =3D slavio_diag_mem_writeb, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_BIG_ENDIAN, .valid =3D { .min_access_size =3D 1, .max_access_size =3D 1, @@ -207,7 +207,7 @@ static uint64_t slavio_mdm_mem_readb(void *opaque, hwad= dr addr, static const MemoryRegionOps slavio_mdm_mem_ops =3D { .read =3D slavio_mdm_mem_readb, .write =3D slavio_mdm_mem_writeb, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_BIG_ENDIAN, .valid =3D { .min_access_size =3D 1, .max_access_size =3D 1, @@ -245,7 +245,7 @@ static uint64_t slavio_aux1_mem_readb(void *opaque, hwa= ddr addr, static const MemoryRegionOps slavio_aux1_mem_ops =3D { .read =3D slavio_aux1_mem_readb, .write =3D slavio_aux1_mem_writeb, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_BIG_ENDIAN, .valid =3D { .min_access_size =3D 1, .max_access_size =3D 1, @@ -282,7 +282,7 @@ static uint64_t slavio_aux2_mem_readb(void *opaque, hwa= ddr addr, static const MemoryRegionOps slavio_aux2_mem_ops =3D { .read =3D slavio_aux2_mem_readb, .write =3D slavio_aux2_mem_writeb, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_BIG_ENDIAN, .valid =3D { .min_access_size =3D 1, .max_access_size =3D 1, @@ -310,7 +310,7 @@ static uint64_t apc_mem_readb(void *opaque, hwaddr addr, static const MemoryRegionOps apc_mem_ops =3D { .read =3D apc_mem_readb, .write =3D apc_mem_writeb, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_BIG_ENDIAN, .valid =3D { .min_access_size =3D 1, .max_access_size =3D 1, @@ -355,7 +355,7 @@ static void slavio_sysctrl_mem_writel(void *opaque, hwa= ddr addr, static const MemoryRegionOps slavio_sysctrl_mem_ops =3D { .read =3D slavio_sysctrl_mem_readl, .write =3D slavio_sysctrl_mem_writel, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_BIG_ENDIAN, .valid =3D { .min_access_size =3D 4, .max_access_size =3D 4, @@ -397,7 +397,7 @@ static void slavio_led_mem_writew(void *opaque, hwaddr = addr, static const MemoryRegionOps slavio_led_mem_ops =3D { .read =3D slavio_led_mem_readw, .write =3D slavio_led_mem_writew, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_BIG_ENDIAN, .valid =3D { .min_access_size =3D 2, .max_access_size =3D 2, diff --git a/hw/rtc/sun4v-rtc.c b/hw/rtc/sun4v-rtc.c index 29e24ef6bed..e9e66c2b7c5 100644 --- a/hw/rtc/sun4v-rtc.c +++ b/hw/rtc/sun4v-rtc.c @@ -49,7 +49,7 @@ static void sun4v_rtc_write(void *opaque, hwaddr addr, static const MemoryRegionOps sun4v_rtc_ops =3D { .read =3D sun4v_rtc_read, .write =3D sun4v_rtc_write, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_BIG_ENDIAN, }; =20 void sun4v_rtc_init(hwaddr addr) diff --git a/hw/timer/grlib_gptimer.c b/hw/timer/grlib_gptimer.c index 0e06fa09e99..dfe9264468c 100644 --- a/hw/timer/grlib_gptimer.c +++ b/hw/timer/grlib_gptimer.c @@ -332,7 +332,7 @@ static void grlib_gptimer_write(void *opaque, hwaddr ad= dr, static const MemoryRegionOps grlib_gptimer_ops =3D { .read =3D grlib_gptimer_read, .write =3D grlib_gptimer_write, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_BIG_ENDIAN, .valid =3D { .min_access_size =3D 4, .max_access_size =3D 4, diff --git a/hw/timer/slavio_timer.c b/hw/timer/slavio_timer.c index 3e071fbdb4c..81e6e55415d 100644 --- a/hw/timer/slavio_timer.c +++ b/hw/timer/slavio_timer.c @@ -329,7 +329,7 @@ static void slavio_timer_mem_writel(void *opaque, hwadd= r addr, static const MemoryRegionOps slavio_timer_mem_ops =3D { .read =3D slavio_timer_mem_readl, .write =3D slavio_timer_mem_writel, - .endianness =3D DEVICE_NATIVE_ENDIAN, + .endianness =3D DEVICE_BIG_ENDIAN, .valid =3D { .min_access_size =3D 4, .max_access_size =3D 8, --=20 2.52.0 From nobody Mon Feb 9 14:34:56 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766593713; cv=none; d=zohomail.com; s=zohoarc; b=imPHGvSDzuHMfpeIE5cNT17wqbDb03oyDe1UJC7S9PsUlhOod8tqcTokrQh37ksoxlYabXmCDC/CmHLTD4FfGru025xglNCmh4CYGvIE0eGVTBfE4zOLXynfsMzyZLEb4OpwAmjAcLWgJFLOBCtCIYYljHSlF9076Ysdt9j0Lv8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766593713; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=9A1gr5CJUaSQgBXQcHovtENYxaFT/E0t2tXqegO2h5o=; b=OIel6/tCl80WRZAS7xOPgkqGVziE4tkEojyEtRsXE9/4ora8kY7T/NtxiXdyK963JbJpHwRaH6mRjOaCl28y4XAjonOVtRmZ1Giv6IM/u09TqJ6EXXXGZcPGaqkhYehdaCwCh2Tv7qa4h72Zia1iS67Nr5PRIPKYhnfBKXip8hc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766593713984411.78705552512565; Wed, 24 Dec 2025 08:28:33 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vYRhu-0007eo-Vo; Wed, 24 Dec 2025 11:27:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vYRhd-0007Ym-HA for qemu-devel@nongnu.org; Wed, 24 Dec 2025 11:27:12 -0500 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vYRha-0003b2-Q7 for qemu-devel@nongnu.org; Wed, 24 Dec 2025 11:27:09 -0500 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-477bf34f5f5so44068135e9.0 for ; Wed, 24 Dec 2025 08:27:04 -0800 (PST) Received: from localhost.localdomain (188.171.88.92.rev.sfr.net. [92.88.171.188]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be3bbe1c8sm139674375e9.11.2025.12.24.08.27.00 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Dec 2025 08:27:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766593622; x=1767198422; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9A1gr5CJUaSQgBXQcHovtENYxaFT/E0t2tXqegO2h5o=; b=XNXfMo9MyDNq1uVDd0AH42Up2+yI1glak3yQVuc9zry+hAa7FvMegEHSlC0SZTrsJ4 PIa6oc+LYr0VfEd8E8xbStNv5txz7ieUt2v/qvuj0v9MePusM/dCAHdcIE+X2sUf4zdh v0LZ14/9797pVXQNFrtqGpcFYoM5EP/CGduI+VkjCWGh341UqKtc2Ua3DEhFbTJfSDwc 4/Q5vVXHMSIjTVdg4Fg40DteNUsKx/gfY3jONMuqXF3PpaXu6Czh8WKaHw1fzaDITc7F yh62uNCl53JprtUGYrnJxR4ywcqfZHR3amGUuvoKFUj3jAjvFo3mYdBYI21QDiur1nrT 5N5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766593622; x=1767198422; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=9A1gr5CJUaSQgBXQcHovtENYxaFT/E0t2tXqegO2h5o=; b=toWBTfiQB/seq6OC4KW3S9nqHRLqJ+NCAiBxZCh9JDE/KpgvoX8xioMwxz20Qvd5UF kBA/NN2OTwox1MeStywoCDQq8ucvMKvGxEUQecUjLv8M+AMlvOQcqyKEtq/O39X7GG3z oGNixqnxC0u8rCqkTP/8kObeBZ/oZ6j6EYhA9Heg1AhwenggnsgkGK1WfkOztSDN+C/U /1OS1U5TpVtAABPOkF7zZWfdOUgIhlp/1W7fWDixAQ+2rbRO5dYpug1rMO2ttJS8OITZ QpOLS6OirU1X4Bii4qTMhhROblvnc0zX20Rk1IDYDlH2YFT5Psjgkuz+/iT/PTDFEANt boIg== X-Gm-Message-State: AOJu0Ywkp477f97bmuOfIrKBOc9aTcmgvMvq30W/vt2/Mze9Yq/weKvk flH4+lgEVWmg71VcnKgHFN3rHUlx632NetAc9GHW1Xxb3rIbS6Al+CZ94OFxXaeLIOngHNdmknN 8olImmio= X-Gm-Gg: AY/fxX5Km3xIA+OqRZNisShu1veq5KFHLoKiACaXTCxdpXfpoRHJzMTBcOxCf4lpLcV 9kAAvrP/x9TSR3sRXr/5EyhbJSW0czNShFeke04/M/g7BM0yR4FKQkM06S1IgQQ5q98q26MX2C4 W33pA4EZ6hQ/CaL3zs4IFbF65LA65a5q1TPqK7Ec/GZZuLGfhor0dMSCQ+j/oPCgb4pbXO3BbIz FFTbLj2dimLUNnXoM4koHJgBqVyEvoQLG1z4Ys7qupR+xuNSbLEi99D4h/LYbUv0N0drfjv3zJa VsCoRW1UueY28AKgYqpc1P7Il7dIaCZGVVBsUYArbuVJ43rmd5jxZVxeMdOvaCG5DPUWWyzQtDq GOHK1r1/LfNLB9TtZD7j6f3vNOwfE6FbCe/HOPKudqiJKYVogYNyryzu4fwMYZ+Nkt2ghKO70OP Q0MnwAutXJ8JuKtkTMxTt0aER+PU0SYwlXT0IyDe/b3Q65h2lAFazQ0co= X-Google-Smtp-Source: AGHT+IH9FETtIJ2Dw3KXjNvWApTaUQIc2RHgg2H6eHT5VrDqDZHPI9TIMfrmKVuObpGZvXIvnJRPtQ== X-Received: by 2002:a05:600c:3b0d:b0:477:569c:34e9 with SMTP id 5b1f17b1804b1-47d20021316mr175842555e9.23.1766593622429; Wed, 24 Dec 2025 08:27:02 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Gerd Hoffmann , =?UTF-8?q?Cl=C3=A9ment=20Chigot?= , Paolo Bonzini , Anton Johansson , Mark Cave-Ayland , Pierrick Bouvier , Artyom Tarasenko , Laurent Vivier , Manos Pitsidianakis , Frederic Konrad , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 2/9] hw/sparc: Use explicit big-endian LD/ST API Date: Wed, 24 Dec 2025 17:26:34 +0100 Message-ID: <20251224162642.90857-3-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251224162642.90857-1-philmd@linaro.org> References: <20251224162642.90857-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=philmd@linaro.org; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766593715150158500 The SPARC architecture uses big endianness. Directly use the big-endian LD/ST API. Mechanical change running: $ for a in uw w l q; do \ sed -i -e "s/ld${a}_p(/ld${a}_be_p(/" \ $(git grep -wlE '(ld|st)u?[wlq]_p' hw/sparc*/); done Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Mark Cave-Ayland Reviewed-by: Chigot Cl=C3=A9ment Reviewed-by: Manos Pitsidianakis --- hw/sparc/leon3.c | 42 +++++++++++++++++++++--------------------- hw/sparc/sun4m.c | 6 +++--- hw/sparc64/sun4u.c | 6 +++--- 3 files changed, 27 insertions(+), 27 deletions(-) diff --git a/hw/sparc/leon3.c b/hw/sparc/leon3.c index 631c6113b5c..0414e9df573 100644 --- a/hw/sparc/leon3.c +++ b/hw/sparc/leon3.c @@ -78,21 +78,21 @@ typedef struct ResetData { =20 static uint32_t *gen_store_u32(uint32_t *code, hwaddr addr, uint32_t val) { - stl_p(code++, 0x82100000); /* mov %g0, %g1 */ - stl_p(code++, 0x84100000); /* mov %g0, %g2 */ - stl_p(code++, 0x03000000 + + stl_be_p(code++, 0x82100000); /* mov %g0, %g1 */ + stl_be_p(code++, 0x84100000); /* mov %g0, %g2 */ + stl_be_p(code++, 0x03000000 + extract32(addr, 10, 22)); /* sethi %hi(addr), %g1 */ - stl_p(code++, 0x82106000 + + stl_be_p(code++, 0x82106000 + extract32(addr, 0, 10)); /* or %g1, addr, %g1 */ - stl_p(code++, 0x05000000 + + stl_be_p(code++, 0x05000000 + extract32(val, 10, 22)); /* sethi %hi(val), %g2 */ - stl_p(code++, 0x8410a000 + + stl_be_p(code++, 0x8410a000 + extract32(val, 0, 10)); /* or %g2, val, %g2 */ - stl_p(code++, 0xc4204000); /* st %g2, [ %g1 ] */ + stl_be_p(code++, 0xc4204000); /* st %g2, [ %g1 ] */ =20 return code; } @@ -112,13 +112,13 @@ static void write_bootloader(void *ptr, hwaddr kernel= _addr) =20 /* If we are running on a secondary CPU, jump directly to the kernel. = */ =20 - stl_p(p++, 0x85444000); /* rd %asr17, %g2 */ - stl_p(p++, 0x8530a01c); /* srl %g2, 0x1c, %g2 */ - stl_p(p++, 0x80908000); /* tst %g2 */ + stl_be_p(p++, 0x85444000); /* rd %asr17, %g2 */ + stl_be_p(p++, 0x8530a01c); /* srl %g2, 0x1c, %g2 */ + stl_be_p(p++, 0x80908000); /* tst %g2 */ /* Filled below. */ sec_cpu_branch_p =3D p; - stl_p(p++, 0x0BADC0DE); /* bne xxx */ - stl_p(p++, 0x01000000); /* nop */ + stl_be_p(p++, 0x0BADC0DE); /* bne xxx */ + stl_be_p(p++, 0x01000000); /* nop */ =20 /* Initialize the UARTs */ /* *UART_CONTROL =3D UART_RECEIVE_ENABLE | UART_TRANSMIT_ENABLE; */ @@ -133,17 +133,17 @@ static void write_bootloader(void *ptr, hwaddr kernel= _addr) p =3D gen_store_u32(p, 0x80000318, 3); =20 /* Now, the relative branch above can be computed. */ - stl_p(sec_cpu_branch_p, 0x12800000 - + (p - sec_cpu_branch_p)); + stl_be_p(sec_cpu_branch_p, 0x12800000 + + (p - sec_cpu_branch_p)); =20 /* JUMP to the entry point */ - stl_p(p++, 0x82100000); /* mov %g0, %g1 */ - stl_p(p++, 0x03000000 + extract32(kernel_addr, 10, 22)); - /* sethi %hi(kernel_addr), %g1 */ - stl_p(p++, 0x82106000 + extract32(kernel_addr, 0, 10)); - /* or kernel_addr, %g1 */ - stl_p(p++, 0x81c04000); /* jmp %g1 */ - stl_p(p++, 0x01000000); /* nop */ + stl_be_p(p++, 0x82100000); /* mov %g0, %g1 */ + stl_be_p(p++, 0x03000000 + extract32(kernel_addr, 10, 22)); + /* sethi %hi(kernel_addr), %g1 */ + stl_be_p(p++, 0x82106000 + extract32(kernel_addr, 0, 10)); + /* or kernel_addr, %g1 */ + stl_be_p(p++, 0x81c04000); /* jmp %g1 */ + stl_be_p(p++, 0x01000000); /* nop */ } =20 static void leon3_cpu_reset(void *opaque) diff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4m.c index 53d7ae08ae9..52ca9586001 100644 --- a/hw/sparc/sun4m.c +++ b/hw/sparc/sun4m.c @@ -268,9 +268,9 @@ static unsigned long sun4m_load_kernel(const char *kern= el_filename, if (*initrd_size > 0) { for (i =3D 0; i < 64 * TARGET_PAGE_SIZE; i +=3D TARGET_PAGE_SI= ZE) { ptr =3D rom_ptr(KERNEL_LOAD_ADDR + i, 24); - if (ptr && ldl_p(ptr) =3D=3D 0x48647253) { /* HdrS */ - stl_p(ptr + 16, INITRD_LOAD_ADDR); - stl_p(ptr + 20, *initrd_size); + if (ptr && ldl_be_p(ptr) =3D=3D 0x48647253) { /* HdrS */ + stl_be_p(ptr + 16, INITRD_LOAD_ADDR); + stl_be_p(ptr + 20, *initrd_size); break; } } diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c index 82c3e7c855b..e83c82fc9ae 100644 --- a/hw/sparc64/sun4u.c +++ b/hw/sparc64/sun4u.c @@ -206,9 +206,9 @@ static uint64_t sun4u_load_kernel(const char *kernel_fi= lename, if (*initrd_size > 0) { for (i =3D 0; i < 64 * TARGET_PAGE_SIZE; i +=3D TARGET_PAGE_SI= ZE) { ptr =3D rom_ptr(*kernel_addr + i, 32); - if (ptr && ldl_p(ptr + 8) =3D=3D 0x48647253) { /* HdrS */ - stl_p(ptr + 24, *initrd_addr + *kernel_addr); - stl_p(ptr + 28, *initrd_size); + if (ptr && ldl_be_p(ptr + 8) =3D=3D 0x48647253) { /* HdrS = */ + stl_be_p(ptr + 24, *initrd_addr + *kernel_addr); + stl_be_p(ptr + 28, *initrd_size); break; } } --=20 2.52.0 From nobody Mon Feb 9 14:34:56 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766593661; cv=none; d=zohomail.com; s=zohoarc; b=BxZKU0G318pcZmNuQf8eQr6xe++kH8JOia6UINxDFrkVmzmkgmmnPGwQfyc7ocHn1gEqZR8/H6BYyhXY6tVV3vk5h1EpbJ0zD45nlQz5OXaIdQeA772odQ9yYQK9Ytxj2PL8OD9SLdSBABxxRd/bYytzli+5X1Bo5gmj0wLiKy8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766593661; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=2pPXI/RNd4YhskZ4GDGLaQPSNUsmTt2IQzm/8dEFuWw=; b=n0tcvDrr9h3i72kFbjmr+8VMcdMgCmmx/2vdvSUBFCqnk5OaKkJFw2JgZAbAlxWEmsdPRhqxlegnc0D7EAo/LVy2k6ALwegktRWwvryRjpn5mXvaYsdxA5dVV0J1r17MbV1MwvbkJK0RtoCbNN1i89Hli532o9d2P4ZcSggFVaI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766593661741602.0676629635544; Wed, 24 Dec 2025 08:27:41 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vYRhy-0007gH-Ni; Wed, 24 Dec 2025 11:27:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vYRhi-0007c2-Uh for qemu-devel@nongnu.org; Wed, 24 Dec 2025 11:27:18 -0500 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vYRhg-0003hj-Rx for qemu-devel@nongnu.org; Wed, 24 Dec 2025 11:27:14 -0500 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-4779aa4f928so59299765e9.1 for ; Wed, 24 Dec 2025 08:27:12 -0800 (PST) Received: from localhost.localdomain (188.171.88.92.rev.sfr.net. [92.88.171.188]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eab2c4fsm35443256f8f.42.2025.12.24.08.27.09 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Dec 2025 08:27:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766593631; x=1767198431; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2pPXI/RNd4YhskZ4GDGLaQPSNUsmTt2IQzm/8dEFuWw=; b=BWS+mlk5Hv7fXgcd5i5vtL7xJoJFzpjsocFYLt9BSetp7j53tyuCrbzZ0gvN0aKPOU NhHDfytr+MYrbmB3qj1Vr17ci4w619428xtInb7NMq6X7oTHSEFHSS1wdyWp06oewk28 o348ueu2bVat5kTAWlH+DIm7Ub4anWX1rZcR/jSOQSdnNlnMsZ4tfAj5xq+gyvb6/COz dG4AMUQ0CvEtEQdXVJEwl6Q57KdASJ34wu/x/M3KDRg7nMpDRjXM2jyfsFjN9kgJs5aS MHaV+ys/VcuyUsdxbBQGt96yK2KRUYNosvqR2njc1zymXWXm/bxwru/5zEL7zp6mceOQ eAdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766593631; x=1767198431; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2pPXI/RNd4YhskZ4GDGLaQPSNUsmTt2IQzm/8dEFuWw=; b=THTrBeTnYH5onWOQLF+02oDG4cs5p5evkEqhEV5AGfrh1ebohBWW4GYGXX7PehAoy2 O3jN34WVrozNO4lVlee3fy3bu06WDeTHjgk1XVB1itORVB/qQNVxYx9ZLRfHfpRE+ixo 9IMHXyJ7m2kq+4npF7X62x7vymJuy51+8lN+xPxjJGGXh2f56D8pXbGNdHUnbXdc6o6x uKODCWsoFdbIlhUpUIkTfcegCuK/vJ+rM7Zgwqfr3tzASYQYm9cQ4ed3g2zJzePlZ9jr pZ5xPCBDx6MHDWBnOB9f7UvZVRnBwU9uJ1zhVdDrJ2mjuPqOMb0zMngMsrhlCG4b9Yer xicA== X-Gm-Message-State: AOJu0Yw8iKP3tzdTtUhutjvj3rCi539sMi4SP7aHG48dHnYLCa9ceNVp XW+pxG/u3abQkbmpW0z3K7xlAqaQoipZHS2V+qF0cZqBlN9fOpyfyVCtac8g2vqjkc2qaJbn+pe LNSeai4Q= X-Gm-Gg: AY/fxX7qlLr5B8UiqzG91ReFP24sZ9nYzFWx1XN2jF8jwO8MyGWw/O4Lzl6m1+JVguD jmrokO4uWFPu3DCDmpj7hvVJScaAh3IYHA6RJaiKVB4llfzrst0q+QLk+KgEMOtda798X8+gUHg 9C5BK/6YRD2pKoX1JRE26n9bkeCm81ROwS01JZhKYIZFHA4vRuyt1gWZjSZy1Jq7HOk1JufkIvY jVRiuyEsLZ4Aix9VWsfUISvHJYT+TC5Xk+Vr7qEPfTGP+RBTcK/lykk5Ejs/JiQ3ytIk1V9wCG5 fUu7eGPeaJf0l125DU6Kh5XoMiUAuGT7Py6+n9evQVl/+EDCDo3/syJcTMnch+Co/ySXiD7ubjz hriKdlr0cBXko3y+I/9LmO5mbYcB9i4XyepQR+2Fp+03EKHK4sMTllT1LHqy7yPfl/1+WSereB9 FhsuqOWljjgxtXKgPOpo35Mg+LS7SissgmxSqq9Yx7yH2PxS1E+u2PyM0= X-Google-Smtp-Source: AGHT+IFnwlGS2129abSIWPoc79ckkJLCBd7dyngQyqsSK3gGAloQICKu95WSgRUb5PkAYYdCT5qs2w== X-Received: by 2002:a05:600c:310c:b0:476:4efc:8ed4 with SMTP id 5b1f17b1804b1-47d19549f9bmr162683145e9.11.1766593630914; Wed, 24 Dec 2025 08:27:10 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Gerd Hoffmann , =?UTF-8?q?Cl=C3=A9ment=20Chigot?= , Paolo Bonzini , Anton Johansson , Mark Cave-Ayland , Pierrick Bouvier , Artyom Tarasenko , Laurent Vivier , Manos Pitsidianakis , Frederic Konrad , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 3/9] target/sparc: Replace MO_TE -> MO_BE Date: Wed, 24 Dec 2025 17:26:35 +0100 Message-ID: <20251224162642.90857-4-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251224162642.90857-1-philmd@linaro.org> References: <20251224162642.90857-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766593663582158500 We only build the SPARC targets using big endianness order, therefore the MO_TE definitions expand to the big endian one. Use the latter which is more explicit. Mechanical change running: $ sed -i -e s/MO_TE/MO_BE/ \ $(git grep -wl MO_TE target/sparc/) Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Manos Pitsidianakis --- target/sparc/ldst_helper.c | 6 ++-- target/sparc/translate.c | 58 +++++++++++++++++++------------------- 2 files changed, 32 insertions(+), 32 deletions(-) diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c index 2c63eb9e036..a87a0b3eee0 100644 --- a/target/sparc/ldst_helper.c +++ b/target/sparc/ldst_helper.c @@ -1169,7 +1169,7 @@ uint64_t helper_ld_code(CPUSPARCState *env, target_ul= ong addr, uint32_t oi) break; case MO_16: ret =3D cpu_ldw_code_mmu(env, addr, oi, ra); - if ((mop & MO_BSWAP) !=3D MO_TE) { + if ((mop & MO_BSWAP) !=3D MO_BE) { ret =3D bswap16(ret); } if (mop & MO_SIGN) { @@ -1178,7 +1178,7 @@ uint64_t helper_ld_code(CPUSPARCState *env, target_ul= ong addr, uint32_t oi) break; case MO_32: ret =3D cpu_ldl_code_mmu(env, addr, oi, ra); - if ((mop & MO_BSWAP) !=3D MO_TE) { + if ((mop & MO_BSWAP) !=3D MO_BE) { ret =3D bswap32(ret); } if (mop & MO_SIGN) { @@ -1187,7 +1187,7 @@ uint64_t helper_ld_code(CPUSPARCState *env, target_ul= ong addr, uint32_t oi) break; case MO_64: ret =3D cpu_ldq_code_mmu(env, addr, oi, ra); - if ((mop & MO_BSWAP) !=3D MO_TE) { + if ((mop & MO_BSWAP) !=3D MO_BE) { ret =3D bswap64(ret); } break; diff --git a/target/sparc/translate.c b/target/sparc/translate.c index d6b599b71fe..23079697f52 100644 --- a/target/sparc/translate.c +++ b/target/sparc/translate.c @@ -1764,7 +1764,7 @@ static DisasASI resolve_asi(DisasContext *dc, int asi= , MemOp memop) case ASI_FL16_SL: case ASI_FL16_P: case ASI_FL16_PL: - memop =3D MO_TEUW; + memop =3D MO_BEUW; type =3D GET_ASI_SHORT; break; } @@ -2215,7 +2215,7 @@ static void gen_ldda_asi(DisasContext *dc, DisasASI *= da, TCGv addr, int rd) * byte swapped. We perform one 128-bit LE load, so must swap * the order of the writebacks. */ - if ((mop & MO_BSWAP) =3D=3D MO_TE) { + if ((mop & MO_BSWAP) =3D=3D MO_BE) { tcg_gen_extr_i128_i64(lo, hi, t); } else { tcg_gen_extr_i128_i64(hi, lo, t); @@ -2235,7 +2235,7 @@ static void gen_ldda_asi(DisasContext *dc, DisasASI *= da, TCGv addr, int rd) /* Note that LE ldda acts as if each 32-bit register result is byte swapped. Having just performed one 64-bit bswap, we need now to swap the writebacks. */ - if ((da->memop & MO_BSWAP) =3D=3D MO_TE) { + if ((da->memop & MO_BSWAP) =3D=3D MO_BE) { tcg_gen_extr_i64_tl(lo, hi, tmp); } else { tcg_gen_extr_i64_tl(hi, lo, tmp); @@ -2252,7 +2252,7 @@ static void gen_ldda_asi(DisasContext *dc, DisasASI *= da, TCGv addr, int rd) gen_helper_ld_code(tmp, tcg_env, addr, tcg_constant_i32(oi)); =20 /* See above. */ - if ((da->memop & MO_BSWAP) =3D=3D MO_TE) { + if ((da->memop & MO_BSWAP) =3D=3D MO_BE) { tcg_gen_extr_i64_tl(lo, hi, tmp); } else { tcg_gen_extr_i64_tl(hi, lo, tmp); @@ -2277,7 +2277,7 @@ static void gen_ldda_asi(DisasContext *dc, DisasASI *= da, TCGv addr, int rd) gen_helper_ld_asi(tmp, tcg_env, addr, r_asi, r_mop); =20 /* See above. */ - if ((da->memop & MO_BSWAP) =3D=3D MO_TE) { + if ((da->memop & MO_BSWAP) =3D=3D MO_BE) { tcg_gen_extr_i64_tl(lo, hi, tmp); } else { tcg_gen_extr_i64_tl(hi, lo, tmp); @@ -2310,7 +2310,7 @@ static void gen_stda_asi(DisasContext *dc, DisasASI *= da, TCGv addr, int rd) * byte swapped. We perform one 128-bit LE store, so must swap * the order of the construction. */ - if ((mop & MO_BSWAP) =3D=3D MO_TE) { + if ((mop & MO_BSWAP) =3D=3D MO_BE) { tcg_gen_concat_i64_i128(t, lo, hi); } else { tcg_gen_concat_i64_i128(t, hi, lo); @@ -2329,7 +2329,7 @@ static void gen_stda_asi(DisasContext *dc, DisasASI *= da, TCGv addr, int rd) /* Note that LE stda acts as if each 32-bit register result is byte swapped. We will perform one 64-bit LE store, so now we must swap the order of the construction. */ - if ((da->memop & MO_BSWAP) =3D=3D MO_TE) { + if ((da->memop & MO_BSWAP) =3D=3D MO_BE) { tcg_gen_concat_tl_i64(t64, lo, hi); } else { tcg_gen_concat_tl_i64(t64, hi, lo); @@ -2345,7 +2345,7 @@ static void gen_stda_asi(DisasContext *dc, DisasASI *= da, TCGv addr, int rd) * See comments for GET_ASI_COPY above. */ { - MemOp mop =3D MO_TE | MO_128 | MO_ATOM_IFALIGN_PAIR; + MemOp mop =3D MO_BE | MO_128 | MO_ATOM_IFALIGN_PAIR; TCGv_i64 t8 =3D tcg_temp_new_i64(); TCGv_i128 t16 =3D tcg_temp_new_i128(); TCGv daddr =3D tcg_temp_new(); @@ -2368,7 +2368,7 @@ static void gen_stda_asi(DisasContext *dc, DisasASI *= da, TCGv addr, int rd) TCGv_i64 t64 =3D tcg_temp_new_i64(); =20 /* See above. */ - if ((da->memop & MO_BSWAP) =3D=3D MO_TE) { + if ((da->memop & MO_BSWAP) =3D=3D MO_BE) { tcg_gen_concat_tl_i64(t64, lo, hi); } else { tcg_gen_concat_tl_i64(t64, hi, lo); @@ -4428,13 +4428,13 @@ static bool do_ld_gpr(DisasContext *dc, arg_r_r_ri_= asi *a, MemOp mop) return advance_pc(dc); } =20 -TRANS(LDUW, ALL, do_ld_gpr, a, MO_TEUL) +TRANS(LDUW, ALL, do_ld_gpr, a, MO_BEUL) TRANS(LDUB, ALL, do_ld_gpr, a, MO_UB) -TRANS(LDUH, ALL, do_ld_gpr, a, MO_TEUW) +TRANS(LDUH, ALL, do_ld_gpr, a, MO_BEUW) TRANS(LDSB, ALL, do_ld_gpr, a, MO_SB) -TRANS(LDSH, ALL, do_ld_gpr, a, MO_TESW) -TRANS(LDSW, 64, do_ld_gpr, a, MO_TESL) -TRANS(LDX, 64, do_ld_gpr, a, MO_TEUQ) +TRANS(LDSH, ALL, do_ld_gpr, a, MO_BESW) +TRANS(LDSW, 64, do_ld_gpr, a, MO_BESL) +TRANS(LDX, 64, do_ld_gpr, a, MO_BEUQ) =20 static bool do_st_gpr(DisasContext *dc, arg_r_r_ri_asi *a, MemOp mop) { @@ -4451,10 +4451,10 @@ static bool do_st_gpr(DisasContext *dc, arg_r_r_ri_= asi *a, MemOp mop) return advance_pc(dc); } =20 -TRANS(STW, ALL, do_st_gpr, a, MO_TEUL) +TRANS(STW, ALL, do_st_gpr, a, MO_BEUL) TRANS(STB, ALL, do_st_gpr, a, MO_UB) -TRANS(STH, ALL, do_st_gpr, a, MO_TEUW) -TRANS(STX, 64, do_st_gpr, a, MO_TEUQ) +TRANS(STH, ALL, do_st_gpr, a, MO_BEUW) +TRANS(STX, 64, do_st_gpr, a, MO_BEUQ) =20 static bool trans_LDD(DisasContext *dc, arg_r_r_ri_asi *a) { @@ -4468,7 +4468,7 @@ static bool trans_LDD(DisasContext *dc, arg_r_r_ri_as= i *a) if (addr =3D=3D NULL) { return false; } - da =3D resolve_asi(dc, a->asi, MO_TEUQ); + da =3D resolve_asi(dc, a->asi, MO_BEUQ); gen_ldda_asi(dc, &da, addr, a->rd); return advance_pc(dc); } @@ -4485,7 +4485,7 @@ static bool trans_STD(DisasContext *dc, arg_r_r_ri_as= i *a) if (addr =3D=3D NULL) { return false; } - da =3D resolve_asi(dc, a->asi, MO_TEUQ); + da =3D resolve_asi(dc, a->asi, MO_BEUQ); gen_stda_asi(dc, &da, addr, a->rd); return advance_pc(dc); } @@ -4516,7 +4516,7 @@ static bool trans_SWAP(DisasContext *dc, arg_r_r_ri_a= si *a) if (addr =3D=3D NULL) { return false; } - da =3D resolve_asi(dc, a->asi, MO_TEUL); + da =3D resolve_asi(dc, a->asi, MO_BEUL); =20 dst =3D gen_dest_gpr(dc, a->rd); src =3D gen_load_gpr(dc, a->rd); @@ -4544,8 +4544,8 @@ static bool do_casa(DisasContext *dc, arg_r_r_ri_asi = *a, MemOp mop) return advance_pc(dc); } =20 -TRANS(CASA, CASA, do_casa, a, MO_TEUL) -TRANS(CASXA, 64, do_casa, a, MO_TEUQ) +TRANS(CASA, CASA, do_casa, a, MO_BEUL) +TRANS(CASXA, 64, do_casa, a, MO_BEUQ) =20 static bool do_ld_fpr(DisasContext *dc, arg_r_r_ri_asi *a, MemOp sz) { @@ -4561,7 +4561,7 @@ static bool do_ld_fpr(DisasContext *dc, arg_r_r_ri_as= i *a, MemOp sz) if (sz =3D=3D MO_128 && gen_trap_float128(dc)) { return true; } - da =3D resolve_asi(dc, a->asi, MO_TE | sz); + da =3D resolve_asi(dc, a->asi, MO_BE | sz); gen_ldf_asi(dc, &da, sz, addr, a->rd); gen_update_fprs_dirty(dc, a->rd); return advance_pc(dc); @@ -4590,7 +4590,7 @@ static bool do_st_fpr(DisasContext *dc, arg_r_r_ri_as= i *a, MemOp sz) if (sz =3D=3D MO_128 && gen_trap_float128(dc)) { return true; } - da =3D resolve_asi(dc, a->asi, MO_TE | sz); + da =3D resolve_asi(dc, a->asi, MO_BE | sz); gen_stf_asi(dc, &da, sz, addr, a->rd); return advance_pc(dc); } @@ -4629,7 +4629,7 @@ static bool trans_STDFQ(DisasContext *dc, arg_STDFQ *= a) /* Store the single element from the queue. */ TCGv_i64 fq =3D tcg_temp_new_i64(); tcg_gen_ld_i64(fq, tcg_env, offsetof(CPUSPARCState, fq.d)); - tcg_gen_qemu_st_i64(fq, addr, dc->mem_idx, MO_TEUQ | MO_ALIGN_4); + tcg_gen_qemu_st_i64(fq, addr, dc->mem_idx, MO_BEUQ | MO_ALIGN_4); =20 /* Mark the queue empty, transitioning to fp_execute state. */ tcg_gen_st_i32(tcg_constant_i32(0), tcg_env, @@ -4655,7 +4655,7 @@ static bool trans_LDFSR(DisasContext *dc, arg_r_r_ri = *a) } =20 tmp =3D tcg_temp_new_i32(); - tcg_gen_qemu_ld_i32(tmp, addr, dc->mem_idx, MO_TEUL | MO_ALIGN); + tcg_gen_qemu_ld_i32(tmp, addr, dc->mem_idx, MO_BEUL | MO_ALIGN); =20 tcg_gen_extract_i32(cpu_fcc[0], tmp, FSR_FCC0_SHIFT, 2); /* LDFSR does not change FCC[1-3]. */ @@ -4679,7 +4679,7 @@ static bool do_ldxfsr(DisasContext *dc, arg_r_r_ri *a= , bool entire) } =20 t64 =3D tcg_temp_new_i64(); - tcg_gen_qemu_ld_i64(t64, addr, dc->mem_idx, MO_TEUQ | MO_ALIGN); + tcg_gen_qemu_ld_i64(t64, addr, dc->mem_idx, MO_BEUQ | MO_ALIGN); =20 lo =3D tcg_temp_new_i32(); hi =3D cpu_fcc[3]; @@ -4722,8 +4722,8 @@ static bool do_stfsr(DisasContext *dc, arg_r_r_ri *a,= MemOp mop) return advance_pc(dc); } =20 -TRANS(STFSR, ALL, do_stfsr, a, MO_TEUL) -TRANS(STXFSR, 64, do_stfsr, a, MO_TEUQ) +TRANS(STFSR, ALL, do_stfsr, a, MO_BEUL) +TRANS(STXFSR, 64, do_stfsr, a, MO_BEUQ) =20 static bool do_fc(DisasContext *dc, int rd, int32_t c) { --=20 2.52.0 From nobody Mon Feb 9 14:34:56 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766593688; cv=none; d=zohomail.com; s=zohoarc; b=ZAIpS5S5ZZUto3Vn1u+apez0FuZ6x4w05kX2SJjcj5lgJl8SbKaIGcPg2fC7s4aX12fR8jEB+U921YodicImCjKwA00eO8qKs6xBF+FqfYLfqPOiMdAlEC6J2iX4Hp5qXpuvUzOWBqlLVi4mDqS0qHUcS9rtxL9yg91Ah7rq7kQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766593688; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=0c/mySe6v1ckZ2Oupf+IHYume+MJC9Oj74k6isdDL0g=; b=YJq9FZKFZZxWDNr/TMH6XLExjvrtvOADbL+GIUxiXf2f0fP7L5ch/HaN8zcMEsvy8FhJrRRuxpdgtdyaTqkLE/NQ0sT3i+C+kFYNtEH2pD7BiVed8QV9hdZxq6aIaQQ6EPtXF4v+06Ra5YAV4I3EloNJfVlc1E7Hu69W5ghZZ4k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176659368879559.06285586516458; Wed, 24 Dec 2025 08:28:08 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vYRi5-0007iC-KN; Wed, 24 Dec 2025 11:27:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vYRhu-0007fg-KF for qemu-devel@nongnu.org; Wed, 24 Dec 2025 11:27:26 -0500 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vYRhs-0003mn-MS for qemu-devel@nongnu.org; Wed, 24 Dec 2025 11:27:26 -0500 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-42fb4eeb482so3109085f8f.0 for ; Wed, 24 Dec 2025 08:27:22 -0800 (PST) Received: from localhost.localdomain (188.171.88.92.rev.sfr.net. [92.88.171.188]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43264613923sm18740820f8f.26.2025.12.24.08.27.18 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Dec 2025 08:27:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766593641; x=1767198441; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0c/mySe6v1ckZ2Oupf+IHYume+MJC9Oj74k6isdDL0g=; b=FtvVNZ8vRu7Tf6NCdbnVI8tzE4ut+XEFD+slvrw+0W2FAReZJlq2s2MKsjQXajRQwe cKiJJdnbc1lR40ZJNfYqLLQS03mTlGlSWmVfHneFaQNrbYE3sJ428k0D4Qaww1RYOTdi VGJyylZzDV51T89gic7H6tXC8YLVN8XdxU5ppiadUTZdw50jBQtKxbEXIymBmfD6vAO1 W7o3ajap4Ps13nIcjFHQ9dz5zCvvug38wlv9F8zNw6+bYAmZs+mKe7OSJD5SwvdjeX8U Q1cHqQFIjlyCiEwCVKMrCzgqF+1euHaV16k5n/sBksNcukYT/xTGIDRIlIv+KUAUsS54 9z/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766593641; x=1767198441; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0c/mySe6v1ckZ2Oupf+IHYume+MJC9Oj74k6isdDL0g=; b=dmIaIQt/yHd8b4zsgtkTbfRlwf8I5I/ym+GTcnvzSMIbb597icH5B4NF6AK7wlsc05 tRh/GH1AQsd9TYHLUDm7lbLzFQ9D17nHeiSj/ctAKdjq1CynCrXbynGSXuAaQUaSq2UP J88E+d87HMGDYOnllS/QH4vJiirCBvRfpqA2EX12o01//2CMURcx9DJlf8HEO+Ndhpam eN0weeVdywhF5uuKEqCcao7LzRWfnzmazzYj6IHkCI22isYOq33kUWYyak6U/YNliAd/ opw7+nabGuezVRcRD5GpC3Zy5iPbEGrcQ6Hwsfsi4UcYi8TTsCCus2h80bvQeKXMf+eF UNtw== X-Gm-Message-State: AOJu0YzD8+FX9jn287PPsnXFEKhb43TRt34oJY1FQudkkHHZvA9NSVbu v40g+S5fSIdRjxito5sx/mB3Lou6HTQl+ohfT1l4Qaumg+DdRB8ktJOH0IYyCbokzEwmWgC/Ixh oMPcvKA0= X-Gm-Gg: AY/fxX53FpRz3Tt1bXGJL3/MTRYMk1R0MeNFl7DifDm3dC+Kcz0PhiCwEz2UdHteTwz M3I78eaTLrmZkowHNUPLe1U7wQWmax8wvFOoDt1irqd66MZqesiISJI6g2JTq4isesZqWiG2ZtG ljDzjP9RiPq6+27cGUjAHHxBMAVmHA7+giNzFPxpMy/5Z8Ce4qvStRBHvIiLWI4GAWFKQLh7MQ4 1mf50cNM8TS7Vdi89+Y7jueR+Exl+F9xCDgXmBqlE0HB9ixBlPHNtgJh4HXA0KlE31LpnMcQbYx vJ+BZW0/WMwApfUdI6doaao95gzHMBJPOESqkDVNzu+CNI2qpfEH7nb0wnsIkad+Ql0+WUpKB3p yxQOtJsLOam5rTaRw+Jxk7jAZzpIYtsHBuh1wo2wHFJvYSOQmc82e+euK54nmx4KX6IgcBNC3Bx vSVTm+Hu+P9YE6XTwF2j4wPpud4INPjH0JNcFOB9gDlo1HoAUxNtRVCcmvFddsPhaCFQ== X-Google-Smtp-Source: AGHT+IGiE4oKKUNR2ofAJgPK//pcRQI3YJTXXrCwOyrQcTxF7UH9qNND30a8fNJuP85/hOGEn5paag== X-Received: by 2002:a05:6000:220c:b0:430:fd60:940f with SMTP id ffacd0b85a97d-4324e4c9627mr21155343f8f.14.1766593641108; Wed, 24 Dec 2025 08:27:21 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Gerd Hoffmann , =?UTF-8?q?Cl=C3=A9ment=20Chigot?= , Paolo Bonzini , Anton Johansson , Mark Cave-Ayland , Pierrick Bouvier , Artyom Tarasenko , Laurent Vivier , Manos Pitsidianakis , Frederic Konrad , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 4/9] target/sparc: Use explicit big-endian LD/ST API Date: Wed, 24 Dec 2025 17:26:36 +0100 Message-ID: <20251224162642.90857-5-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251224162642.90857-1-philmd@linaro.org> References: <20251224162642.90857-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=philmd@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766593691282158500 The SPARC architecture uses big endianness. Directly use the big-endian LD/ST API. Mechanical change running: $ for a in uw w l q; do \ sed -i -e "s/ld${a}_p(/ld${a}_be_p(/" \ $(git grep -wlE '(ld|st)u?[wlq]_p' target/sparc/); done Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Manos Pitsidianakis Reviewed-by: Richard Henderson --- target/sparc/ldst_helper.c | 36 ++++++++++++++++++------------------ target/sparc/mmu_helper.c | 32 +++++++++++++++++--------------- 2 files changed, 35 insertions(+), 33 deletions(-) diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c index a87a0b3eee0..9892c8f61c6 100644 --- a/target/sparc/ldst_helper.c +++ b/target/sparc/ldst_helper.c @@ -707,17 +707,17 @@ uint64_t helper_ld_asi(CPUSPARCState *env, target_ulo= ng addr, MEMTXATTRS_UNSPECIFIED, &result); break; case 2: - ret =3D address_space_lduw(cs->as, access_addr, - MEMTXATTRS_UNSPECIFIED, &result); + ret =3D address_space_lduw_be(cs->as, access_addr, + MEMTXATTRS_UNSPECIFIED, &result); break; default: case 4: - ret =3D address_space_ldl(cs->as, access_addr, - MEMTXATTRS_UNSPECIFIED, &result); + ret =3D address_space_ldl_be(cs->as, access_addr, + MEMTXATTRS_UNSPECIFIED, &result); break; case 8: - ret =3D address_space_ldq(cs->as, access_addr, - MEMTXATTRS_UNSPECIFIED, &result); + ret =3D address_space_ldq_be(cs->as, access_addr, + MEMTXATTRS_UNSPECIFIED, &result); break; } =20 @@ -878,10 +878,10 @@ void helper_st_asi(CPUSPARCState *env, target_ulong a= ddr, uint64_t val, MemTxResult result; hwaddr access_addr =3D (env->mxccregs[0] & 0xffffffffULL) = + 8 * i; =20 - env->mxccdata[i] =3D address_space_ldq(cs->as, - access_addr, - MEMTXATTRS_UNSPECIFIE= D, - &result); + env->mxccdata[i] =3D address_space_ldq_be(cs->as, + access_addr, + MEMTXATTRS_UNSPECI= FIED, + &result); if (result !=3D MEMTX_OK) { /* TODO: investigate whether this is the right behavio= ur */ sparc_raise_mmu_fault(cs, access_addr, false, false, @@ -906,8 +906,8 @@ void helper_st_asi(CPUSPARCState *env, target_ulong add= r, uint64_t val, MemTxResult result; hwaddr access_addr =3D (env->mxccregs[1] & 0xffffffffULL) = + 8 * i; =20 - address_space_stq(cs->as, access_addr, env->mxccdata[i], - MEMTXATTRS_UNSPECIFIED, &result); + address_space_stq_be(cs->as, access_addr, env->mxccdata[i], + MEMTXATTRS_UNSPECIFIED, &result); =20 if (result !=3D MEMTX_OK) { /* TODO: investigate whether this is the right behavio= ur */ @@ -1072,17 +1072,17 @@ void helper_st_asi(CPUSPARCState *env, target_ulong= addr, uint64_t val, MEMTXATTRS_UNSPECIFIED, &result); break; case 2: - address_space_stw(cs->as, access_addr, val, - MEMTXATTRS_UNSPECIFIED, &result); + address_space_stw_be(cs->as, access_addr, val, + MEMTXATTRS_UNSPECIFIED, &result); break; case 4: default: - address_space_stl(cs->as, access_addr, val, - MEMTXATTRS_UNSPECIFIED, &result); + address_space_stl_be(cs->as, access_addr, val, + MEMTXATTRS_UNSPECIFIED, &result); break; case 8: - address_space_stq(cs->as, access_addr, val, - MEMTXATTRS_UNSPECIFIED, &result); + address_space_stq_be(cs->as, access_addr, val, + MEMTXATTRS_UNSPECIFIED, &result); break; } if (result !=3D MEMTX_OK) { diff --git a/target/sparc/mmu_helper.c b/target/sparc/mmu_helper.c index 46bf500ea83..5a58239d65e 100644 --- a/target/sparc/mmu_helper.c +++ b/target/sparc/mmu_helper.c @@ -102,7 +102,8 @@ static int get_physical_address(CPUSPARCState *env, CPU= TLBEntryFull *full, /* SPARC reference MMU table walk: Context table->L1->L2->PTE */ /* Context base + context number */ pde_ptr =3D (env->mmuregs[1] << 4) + (env->mmuregs[2] << 2); - pde =3D address_space_ldl(cs->as, pde_ptr, MEMTXATTRS_UNSPECIFIED, &re= sult); + pde =3D address_space_ldl_be(cs->as, pde_ptr, + MEMTXATTRS_UNSPECIFIED, &result); if (result !=3D MEMTX_OK) { return 4 << 2; /* Translation fault, L =3D 0 */ } @@ -117,8 +118,8 @@ static int get_physical_address(CPUSPARCState *env, CPU= TLBEntryFull *full, return 4 << 2; case 1: /* L0 PDE */ pde_ptr =3D ((address >> 22) & ~3) + ((pde & ~3) << 4); - pde =3D address_space_ldl(cs->as, pde_ptr, - MEMTXATTRS_UNSPECIFIED, &result); + pde =3D address_space_ldl_be(cs->as, pde_ptr, + MEMTXATTRS_UNSPECIFIED, &result); if (result !=3D MEMTX_OK) { return (1 << 8) | (4 << 2); /* Translation fault, L =3D 1 */ } @@ -131,8 +132,8 @@ static int get_physical_address(CPUSPARCState *env, CPU= TLBEntryFull *full, return (1 << 8) | (4 << 2); case 1: /* L1 PDE */ pde_ptr =3D ((address & 0xfc0000) >> 16) + ((pde & ~3) << 4); - pde =3D address_space_ldl(cs->as, pde_ptr, - MEMTXATTRS_UNSPECIFIED, &result); + pde =3D address_space_ldl_be(cs->as, pde_ptr, + MEMTXATTRS_UNSPECIFIED, &result); if (result !=3D MEMTX_OK) { return (2 << 8) | (4 << 2); /* Translation fault, L =3D 2 = */ } @@ -145,8 +146,8 @@ static int get_physical_address(CPUSPARCState *env, CPU= TLBEntryFull *full, return (2 << 8) | (4 << 2); case 1: /* L2 PDE */ pde_ptr =3D ((address & 0x3f000) >> 10) + ((pde & ~3) << 4= ); - pde =3D address_space_ldl(cs->as, pde_ptr, - MEMTXATTRS_UNSPECIFIED, &result); + pde =3D address_space_ldl_be(cs->as, pde_ptr, + MEMTXATTRS_UNSPECIFIED, &result= ); if (result !=3D MEMTX_OK) { return (3 << 8) | (4 << 2); /* Translation fault, L = =3D 3 */ } @@ -189,7 +190,7 @@ static int get_physical_address(CPUSPARCState *env, CPU= TLBEntryFull *full, if (is_dirty) { pde |=3D PG_MODIFIED_MASK; } - stl_phys(cs->as, pde_ptr, pde); + stl_be_phys(cs->as, pde_ptr, pde); } =20 /* the page can be put in the TLB */ @@ -276,7 +277,8 @@ target_ulong mmu_probe(CPUSPARCState *env, target_ulong= address, int mmulev) /* Context base + context number */ pde_ptr =3D (hwaddr)(env->mmuregs[1] << 4) + (env->mmuregs[2] << 2); - pde =3D address_space_ldl(cs->as, pde_ptr, MEMTXATTRS_UNSPECIFIED, &re= sult); + pde =3D address_space_ldl_be(cs->as, pde_ptr, + MEMTXATTRS_UNSPECIFIED, &result); if (result !=3D MEMTX_OK) { return 0; } @@ -292,8 +294,8 @@ target_ulong mmu_probe(CPUSPARCState *env, target_ulong= address, int mmulev) return pde; } pde_ptr =3D ((address >> 22) & ~3) + ((pde & ~3) << 4); - pde =3D address_space_ldl(cs->as, pde_ptr, - MEMTXATTRS_UNSPECIFIED, &result); + pde =3D address_space_ldl_be(cs->as, pde_ptr, + MEMTXATTRS_UNSPECIFIED, &result); if (result !=3D MEMTX_OK) { return 0; } @@ -310,8 +312,8 @@ target_ulong mmu_probe(CPUSPARCState *env, target_ulong= address, int mmulev) return pde; } pde_ptr =3D ((address & 0xfc0000) >> 16) + ((pde & ~3) << 4); - pde =3D address_space_ldl(cs->as, pde_ptr, - MEMTXATTRS_UNSPECIFIED, &result); + pde =3D address_space_ldl_be(cs->as, pde_ptr, + MEMTXATTRS_UNSPECIFIED, &result); if (result !=3D MEMTX_OK) { return 0; } @@ -328,8 +330,8 @@ target_ulong mmu_probe(CPUSPARCState *env, target_ulong= address, int mmulev) return pde; } pde_ptr =3D ((address & 0x3f000) >> 10) + ((pde & ~3) << 4= ); - pde =3D address_space_ldl(cs->as, pde_ptr, - MEMTXATTRS_UNSPECIFIED, &result); + pde =3D address_space_ldl_be(cs->as, pde_ptr, + MEMTXATTRS_UNSPECIFIED, &result= ); if (result !=3D MEMTX_OK) { return 0; } --=20 2.52.0 From nobody Mon Feb 9 14:34:56 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766593705; cv=none; d=zohomail.com; s=zohoarc; b=IcHkAyv5sq8GXMuO09LuIqiG0TaDZ2cFC16gFhkDlwNKinc/ow2Eb0xUSfzn/W5if38iSi9dunS2xagP3vEzDejdQbNwgcje8XDSZSuDB3Iu1dGSPEJ0K1EDwHirQG/zauRGsS9gHp6M1bs4xefOoWPps1Pbrulg6WnZoOOXaLs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766593705; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=iPj2s3kMb90wVd2exYaw2+LTGdQknCaaYvO5hBNEwcM=; b=M9blI6utH/El/bS3eETJRzzPkhLQL2r6ew3NbsY3z1mM1bM+33w2i/X3bPhPc+MjmqnnPtaWenTVjSv+b42Yfc/cxm7pJnhMJzgNQBRqzMoKMLFTyiUJ0e2rfsnW6sZbh29Xvm755jCC/aMi2vm0xprEwXAHunVXLi/2cgYyTYo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766593705333484.94164932593185; Wed, 24 Dec 2025 08:28:25 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vYRiH-0007s8-Ua; Wed, 24 Dec 2025 11:27:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vYRi0-0007h3-MQ for qemu-devel@nongnu.org; Wed, 24 Dec 2025 11:27:34 -0500 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vYRhz-0003pq-8F for qemu-devel@nongnu.org; Wed, 24 Dec 2025 11:27:32 -0500 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-47775fb6cb4so37538335e9.0 for ; Wed, 24 Dec 2025 08:27:30 -0800 (PST) Received: from localhost.localdomain (188.171.88.92.rev.sfr.net. [92.88.171.188]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eab257asm35673370f8f.38.2025.12.24.08.27.27 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Dec 2025 08:27:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766593649; x=1767198449; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iPj2s3kMb90wVd2exYaw2+LTGdQknCaaYvO5hBNEwcM=; b=rScK4t9piNwC5RrIiqISh/CuZZmTFFMF57spMxobMdaBn/rorDjXb57tdA0llMIlp1 g1B+ZWNOv10kUt53BXKmUMEkotNcmDTp0ZSzxljDr5CXcrzo4yPdimyNqW9zA/1Psvmu uLsOVkpi58736HTp/6NbB3ynX8PcBI8B1E+kwba+2j9t+JmgqH89TVl9tbj2T95MnmSH zXAxNiNX8zR5rnLgYdz/0+yc+QchK4F75wrTDifCR/nn5YvWALfEExt4GnTPzAt1klo+ 9oEv6bWg6j9RLK+BCh8gKCRQiKogje5uXjqByhANXVMeEAPnglBKhOG8TIlx093No8So 16Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766593649; x=1767198449; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=iPj2s3kMb90wVd2exYaw2+LTGdQknCaaYvO5hBNEwcM=; b=vVeIcdHVWNA7LOf81Zx4UI6WdCJ0pYlBVRM8h2z8DgjlrrZFKn55v2h+uJ9DAlpvLa kRQkWcALa2mkKfMG7uTVwLy9o4gpPUADr3Gs9R7yjyHeW+wp5DAXa76X4JzJXBeO9F/C suxD2kfFuvVTvOh8UkuwNXCxX5PyRURjs5azp+ytcpU7i60bU8eKvQs+kAf1xaMu2rAw Cm+jTr6zs5N3ggB1xw251G8aNcjfK3+Qhu7N5KZ4kOXou3i9KQ1ybHRJWRc9krjnSgzG LMtTGHDXA/TmCcTngQknDeZY1LVto+PdeMgXYjco6jfyIc9a/KfH00lzIaMqiGLoEy1W jLfw== X-Gm-Message-State: AOJu0Yycx2PO/jfkSiXWlL3AK90uBGvO3Q6xcCkbUE4FVkqhfUZgvQkT Z6SrVtrhRo7lz/GUJj9v6l3oT1vfy7iikd+usNUZhcNC41eslickt9QOGeTkxxE3eSyLN0Qs+H1 n4TXixts= X-Gm-Gg: AY/fxX7S2WIRdSGlyhWWJSwu/BK1XEakNI6NkOkuJh6zIxINw0CHXYprZXskremlefx dC/X+tCHR/Back83zdrWjLjtNq8XwrIQHz572TqyhDWm+BBxNno7BRBk2h1S+EqjveStS6KccNr VqItqUUkq3TuJ0kLFhBnWgz6qobPEMdR34VAe5FeaZ5rbem7bBLco1KJAPwXrkf30rNiEgKbfu/ FtP9hTpMB1SyEM54EDS+fRUnng3W0vXJXJ7czgQ/sau2nfjE0RPsUdXM7rpiDayh+JlGGxjtkaC YX+J2baWzhTcUZx80iuo2XQRNgsbU7H6WUpsBLV1yqh6YmJ6ny++H7hNQ3Y3bWXvS1ihpcz4sJJ nr0WodLSVSGLWoUYIdElEpxmEm2PWqEO+ly6NqBVUyHkvb5xz94uSZgDapZaiAGa6JKi4Z/fXFL 6gsdj9JFls+WD74sD9fwty7RVaIDeAkUb8zmkJfCYyaoGZttsLNF6lXM2GLcx4kENnZw== X-Google-Smtp-Source: AGHT+IGmfQiUYjiJ9L9J9YIezDnViBMZfijEHzi7rzLcO1TzWJnVwZAlfcUdVvVcJF7vAI5Cyi5viA== X-Received: by 2002:a05:600c:8183:b0:477:aed0:f401 with SMTP id 5b1f17b1804b1-47d1957afbamr177015475e9.23.1766593649463; Wed, 24 Dec 2025 08:27:29 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Gerd Hoffmann , =?UTF-8?q?Cl=C3=A9ment=20Chigot?= , Paolo Bonzini , Anton Johansson , Mark Cave-Ayland , Pierrick Bouvier , Artyom Tarasenko , Laurent Vivier , Manos Pitsidianakis , Frederic Konrad , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PATCH v3 5/9] target/sparc: Use big-endian variant of cpu_ld/st_data*() Date: Wed, 24 Dec 2025 17:26:37 +0100 Message-ID: <20251224162642.90857-6-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251224162642.90857-1-philmd@linaro.org> References: <20251224162642.90857-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766593706975158500 We only build the SPARC targets using big endianness order, therefore the cpu_ld/st_data*() definitions expand to the big endian declarations. Use the explicit big-endian variants. Mechanical change running: $ tgt=3Dsparc; \ end=3Dbe; \ for op in data mmuidx_ra; do \ for ac in uw sw l q; do \ sed -i -e "s/cpu_ld${ac}_${op}/cpu_ld${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; for ac in w l q; do \ sed -i -e "s/cpu_st${ac}_${op}/cpu_st${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; done Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Manos Pitsidianakis --- target/sparc/ldst_helper.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c index 9892c8f61c6..d39f7d72a7e 100644 --- a/target/sparc/ldst_helper.c +++ b/target/sparc/ldst_helper.c @@ -1228,13 +1228,13 @@ uint64_t helper_ld_asi(CPUSPARCState *env, target_u= long addr, ret =3D cpu_ldub_data(env, addr); break; case 2: - ret =3D cpu_lduw_data(env, addr); + ret =3D cpu_lduw_be_data(env, addr); break; case 4: - ret =3D cpu_ldl_data(env, addr); + ret =3D cpu_ldl_be_data(env, addr); break; case 8: - ret =3D cpu_ldq_data(env, addr); + ret =3D cpu_ldq_be_data(env, addr); break; default: g_assert_not_reached(); --=20 2.52.0 From nobody Mon Feb 9 14:34:56 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766593724; cv=none; d=zohomail.com; s=zohoarc; b=FyJrT+WQfofHBk7M7tUy/ufO1GYAjQiUe2omiLQEOEKvxln0KtJ+olXJFkU8RPLDBcnZ++7KYxILzd7ek71XrQaAubAjFWqIPavcRJDmMn26jpBJceYvBGv4qQ0ixbHgYK9hj8r5dSIG3kPAFTaz1HSjYX3YzcvoCMsL41ZgEjA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766593724; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=gvU8IjxyyWGbnt0TpIestxRQYownf9I7RuEDkGDxUZg=; b=R3Tj01HDRek17Sc/w8ofI0Y2Xh5c9nvIrniC7JvJq2eNobXpvrKY9bmyjd8vLWIo+sacjH9ofwj/2KMec5ePUvOTcf5of2plNFc24zr8zsz/flnvoFmiZOAasNK4XfD66ZCKRjN351a3uxy/bqXPKAAYY+w+whTvFiNSGzXrExw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17665937241911022.6302707316961; Wed, 24 Dec 2025 08:28:44 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vYRiU-00087f-VL; Wed, 24 Dec 2025 11:28:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vYRiA-0007rB-Ec for qemu-devel@nongnu.org; Wed, 24 Dec 2025 11:27:44 -0500 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vYRi8-0003rl-8l for qemu-devel@nongnu.org; Wed, 24 Dec 2025 11:27:41 -0500 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-4779a4fc95aso34083865e9.1 for ; Wed, 24 Dec 2025 08:27:39 -0800 (PST) Received: from localhost.localdomain (188.171.88.92.rev.sfr.net. [92.88.171.188]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d193d4e91sm294125295e9.13.2025.12.24.08.27.35 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Dec 2025 08:27:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766593658; x=1767198458; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gvU8IjxyyWGbnt0TpIestxRQYownf9I7RuEDkGDxUZg=; b=VWLTRGPF1F3IxoTQS/yTb/DaG23BpmN6rRpl40sywGh+pbTzVaiuYZU49I64EI2ZSt nXyMGo/MxEhmNW+7bptYEtXiv65Bi7RBN84g2CQErIxczxM0QlAy0xwR+F9f/sh/waMD GMg+bsUTn4kc44x0iTrqjV0UxYh+ZSyRFUKSgN0SNkUnRk+jeRmCUcMH9ilRvLXd6NSN far49RWoqRumM8UwroPR0fjGTg9wqdj2VAc4jdLN6kQx+O6jeayqtAMzM7oPSK2PUEyX KhqpmCMmBTYnuP1aGIpyTi1faG9epZ/r6RAmL4Ui7NZSczYGCU3rUc3IimiEy0mRhNaz E8fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766593658; x=1767198458; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gvU8IjxyyWGbnt0TpIestxRQYownf9I7RuEDkGDxUZg=; b=h69/TSpB9nja4J41uWMHfY+178QAfOsyyf5GI64TUd8H/G1r5fKwbmtHdaIcP25x7e dWNQq6XJqsxR0w2eqPwjEU/IxRF0jSXn1WmM3yBVwDrPVoVE49JMXyG+pUVSNG4m6+It ekzntml6Jo2a0f59RFt//6mvIMUGBbJ7YptVws5maOKq/q8KHDELcSQSp9G0PIkoR5qH 5G6Whq2vAjK4m7Qfpx/A5LquYkEYCrp4mwiK+D7QuCkm4wAyqBLNNIJ6ABCfsYD5hqlx sfsNUEEGSxbpFJtNqJwXEJ07aOz+U6nZv8Jdl06rPz3fh9ujRuEZJ20UbAq+rudaz9OW 48zQ== X-Gm-Message-State: AOJu0Yyi4wEUvr8ymA6P7QsE0xprXBTFXFS9/ESx0N254hAj2Kv84vcM RdVrVIe3CRryGmOkDnAXVV/ur9ICz7bXYN+nIUUrtj8KHheK8tw0TeoJS2qd+5PVf7+keJ9mw89 DTbIrCvs= X-Gm-Gg: AY/fxX5fk/XDershhVvweJym71WnBW4u/eGrrm7zzj1IEgc21utcf4dN88nVy8Si+jR h8faAUKgfpXifl/cdln/6KLbLWRa+5xD3J3E/7whWAZ1zbpHdWDio3FLvevBfA3sdpaWr5mPd2I AfGUdXjzPtwM2wmBXQFgiMktajfUgQRtTEpr288Rb4Tv/9vHNp7jdTCKLsysI99eC1ZSko+bOS8 PBqC4ERHl9DFpXWwWkjmb/wmAsUeR6JaJ3/rGTK57JSkVUWzCPLtP44rpERX7f3Eezhqy/zvvpx zhGOvYjDX6RZafaEHBjVsvLopFhRyxvaYmz263gGXS/r0i904u0oF2jNdVVMm2xjDLxvqioUbHu VXbomVIzOEzJQgok/p7fODMlSg4iybq54FvVmua2+kfLPHYEoPBvy5QZekOVShoOr4nvkdKEhdt Ig2G5laBDYM3zBx/bU6DSlYQo00rPV/ypG1l1hgIxPrPBn+ZZZ5KThaaCH0QswhRvpcQ== X-Google-Smtp-Source: AGHT+IECKB1ju5vRf8EIl9TPv74aO46F5xD1OsJDy/pGRLFl1q0bYl1GELU12gJA3D4CGaPDDxHUnA== X-Received: by 2002:a05:600c:5489:b0:46e:59bd:f7e2 with SMTP id 5b1f17b1804b1-47d18bd5651mr186427835e9.11.1766593658117; Wed, 24 Dec 2025 08:27:38 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Gerd Hoffmann , =?UTF-8?q?Cl=C3=A9ment=20Chigot?= , Paolo Bonzini , Anton Johansson , Mark Cave-Ayland , Pierrick Bouvier , Artyom Tarasenko , Laurent Vivier , Manos Pitsidianakis , Frederic Konrad , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 6/9] target/sparc: Inline translator_ldl() Date: Wed, 24 Dec 2025 17:26:38 +0100 Message-ID: <20251224162642.90857-7-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251224162642.90857-1-philmd@linaro.org> References: <20251224162642.90857-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766593725135158500 translator_ldl() is defined in "exec/translator.h" as: 198 static inline uint32_t 199 translator_ldl(CPUArchState *env, DisasContextBase *db, vaddr pc) 200 { 201 return translator_ldl_end(env, db, pc, MO_TE); 202 } Directly use the inlined form, expanding MO_TE -> MO_BE since we only build the SPARC targets as big-endian. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Manos Pitsidianakis Reviewed-by: Richard Henderson --- target/sparc/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index 23079697f52..57b50ff8b9a 100644 --- a/target/sparc/translate.c +++ b/target/sparc/translate.c @@ -5743,7 +5743,7 @@ static void sparc_tr_translate_insn(DisasContextBase = *dcbase, CPUState *cs) DisasContext *dc =3D container_of(dcbase, DisasContext, base); unsigned int insn; =20 - insn =3D translator_ldl(cpu_env(cs), &dc->base, dc->pc); + insn =3D translator_ldl_end(cpu_env(cs), &dc->base, dc->pc, MO_BE); dc->base.pc_next +=3D 4; =20 if (!decode(dc, insn)) { --=20 2.52.0 From nobody Mon Feb 9 14:34:56 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766593727; cv=none; d=zohomail.com; s=zohoarc; b=TNXRbVfZ/YY/K16CVCSVOhj7PTbAmrF/6gVgXVEZcy3F0rVClhe1hYNVE9acZINQ2oivLxh0pf3O/gRhmYYAUofD/IKaUVbZfeZ2e10q/a39YNsZhb1apVodc3fCWn++a+9zskIN3wbFi02vS3ZIw0Mswxv+yIOwCcWR7pw6Sfk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766593727; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=LTDf6gXgcB1jO6b/88BcaLI6db2PR4zQsgUSxotS1SE=; b=PSI48stMRbg5lkfCiytUutcC8cqrH2K220Y2CaFykRbe6ZVsUBtGRfEhoxrfK3vbJcG6I3WoGiFFX5zireP9Um01AeMwxAEnDNxJUR9m/UWfVR3trImFk3aUB4SlxTQO8bPnbgkQIdj3bF7cDH9AhJsiAUhG87/3UwBkqz44dyU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766593726954376.584067039988; Wed, 24 Dec 2025 08:28:46 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vYRiV-0008AH-5d; Wed, 24 Dec 2025 11:28:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vYRiI-0007yq-17 for qemu-devel@nongnu.org; Wed, 24 Dec 2025 11:27:52 -0500 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vYRiG-0003sE-Bm for qemu-devel@nongnu.org; Wed, 24 Dec 2025 11:27:49 -0500 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-4779cb0a33fso61596085e9.0 for ; Wed, 24 Dec 2025 08:27:47 -0800 (PST) Received: from localhost.localdomain (188.171.88.92.rev.sfr.net. [92.88.171.188]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea82f6asm35931384f8f.27.2025.12.24.08.27.44 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Dec 2025 08:27:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766593666; x=1767198466; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LTDf6gXgcB1jO6b/88BcaLI6db2PR4zQsgUSxotS1SE=; b=pICJk4fiRRWlL3jdHZmbDsLvuFO3SR4VI93CKBaWusOGePk6wpQGeRxv7v+wdoPTo8 4NOvmCeNzxgG5BED7C4eJtihmimP1rBe0zbaHQdkEIuQDxDmpFpBHWT56gmTcSSo+KTV InLhkK95XOQloKwtUsk8GaYQAtaYysW4RlhOqmlGtvmiTA1RR0ifYHynkUb7auphzONa 6TNrT5ssFnjPNl9aM2NXcg88SIJM1/3V5EBvF6K2hRv6S7/O/YyRGa/gkkCI6EDLabga LLk6X1unxmtgo6KSz7uemeLUEm1h5tD2GBeeM73GMBu3m1s8fHrwjoOzO4+mt1e/WutC O9aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766593666; x=1767198466; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=LTDf6gXgcB1jO6b/88BcaLI6db2PR4zQsgUSxotS1SE=; b=sBRP//JU/VRe8n/v4T0dt/UtlLXGbAhLIAiq+HMDMUTX5RuXX++15RwiO+ORvzJ0aj WRf5MFCyQl1kbf9x4jvpOcfpGFd6S25WLRF+gVK/WcV13BnFR/IQXSNZ6y0arwTByvDQ 2yLWAVQWaSvnqDIxb3QZDNfqLZNShzU3onNW9ufNycLnbztlT62NLYYTzEpUjw0Zm6+6 7hnN+9ui569vtMINSb02/fex4lv53n7MvaReaWVbLxxxgXSgWGBxB62CDhVkgllW2qIa y47A1GVCFyMnmB4fcls4WwGucAwzo5exNXJbmpjVsvtZjHS9iCXW39ZF6hocN6qmKzSx 6SWg== X-Gm-Message-State: AOJu0Yw0ESsc2Kj+b2xK2cSZrT8gNKP/qVYWMKzKBYWtYfOKnHLTqQBq 86/lV8DzaVqKeHJffWvXzX3VJ/CrR3y0LTR833BpCDq9Ysck4TyZ/q2mZBzet5KsZDyHoCKH9IH YCbNJN/4= X-Gm-Gg: AY/fxX7c9tfnzIlo1FICxxQrzAmawhPoOy5mBMdBb8VA/cIyBQ6dXGd+lVbgLobnFPk nSUrH3rjHD12e6KJPTT/XByNdYKhmf2a5SPVy0G+RZ9IUzZ7Blt7l9lETNRJQHP7tWsSy+F3Uju r3AWdxe4RUCfph1PMyGVfLtpZaIzZd0/QSr8j318Pys6zmyNY6uULcZtAaG4/x9hrk9OMjnSZ1j 9TDSFzCYn0pL0GHwDq7UwSamO0Yi1twXsfWqn+Z9DU2NV4NyDo6vIwkHt760OrQoITcM6aKqk/o U4aTHomBDNBLZNwcrRMGv2SAzw1cIQYOg2rVQFMXAB4c3wO60GSAIbaX0IgOyoa2vNH8aZ1BaNs O3WlFTPF+okEB1Ye1eF8g48LUfpZglntwr8iw72ULG3iIhdYJbdA38JA2hH8tFlrN5PsqNsAx6S hzrQL1uGCCPDPkfc+Wpt1l2W111qbJtb4GugAECIvRJym4RATm1np1NQwMrAfgB4V7IA== X-Google-Smtp-Source: AGHT+IGM4yy3qjYhYGpBjQgkWRJGO4Ed5v9u0Y/nYnfYihIxsR+2/oMa/4SiyS6Uwh9P8aTt2//6+A== X-Received: by 2002:a5d:5d08:0:b0:42b:55a1:2158 with SMTP id ffacd0b85a97d-4324e4c9e43mr16959078f8f.17.1766593666250; Wed, 24 Dec 2025 08:27:46 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Gerd Hoffmann , =?UTF-8?q?Cl=C3=A9ment=20Chigot?= , Paolo Bonzini , Anton Johansson , Mark Cave-Ayland , Pierrick Bouvier , Artyom Tarasenko , Laurent Vivier , Manos Pitsidianakis , Frederic Konrad , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 7/9] target/sparc: Inline cpu_ldl_code() call in cpu_do_interrupt() Date: Wed, 24 Dec 2025 17:26:39 +0100 Message-ID: <20251224162642.90857-8-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251224162642.90857-1-philmd@linaro.org> References: <20251224162642.90857-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=philmd@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766593729100158500 In preparation of removing the cpu_ldl_code wrapper, inline it. Since SPARC instructions are always stored in big-endian order, replace MO_TE -> MO_BE. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Manos Pitsidianakis Reviewed-by: Richard Henderson --- target/sparc/int32_helper.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/sparc/int32_helper.c b/target/sparc/int32_helper.c index b29f693a6bf..d6bb3fa1e54 100644 --- a/target/sparc/int32_helper.c +++ b/target/sparc/int32_helper.c @@ -149,9 +149,11 @@ void sparc_cpu_do_interrupt(CPUState *cs) * mimic delayed trap delivery as if by the subsequent insn. */ if (!env->fsr_qne) { + MemOpIdx oi =3D make_memop_idx(MO_BEUL, cpu_mmu_index(cs, true= )); + env->fsr_qne =3D FSR_QNE; env->fq.s.addr =3D env->pc; - env->fq.s.insn =3D cpu_ldl_code(env, env->pc); + env->fq.s.insn =3D cpu_ldl_code_mmu(env, env->pc, oi, 0); } env->pc =3D env->npc; env->npc =3D env->npc + 4; --=20 2.52.0 From nobody Mon Feb 9 14:34:56 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766593738; cv=none; d=zohomail.com; s=zohoarc; b=T8CGjdmQ39n5ktyrBl6zBeDWgApHi0M568GESK3QXoIwJgm8VvQ4mVQeKw6gu02BhfDuD6r3B5noW0Uczdbpb9JyzjoadTuDax1UxKzaHS+bLfVV35MxjHzMWqCpQX5ajZ+9uo9kw1k3u4pO1Is1oAVNngYFC97VmHt6E+7puDs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766593738; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=yCWaAKr9HKDQPOGDVeV4ELgBSGxrVu16jLOCiFl1Ing=; b=HuQWWlNVQCkfv9D6/G5iTSG33UIB9zuYuVGXWCOxwsHun3Y9+1ieIBBAeFvYfUDnc+CDr0RN6u/b8g4PA5gw4rHZu/HFgm7/R/wtCkwt8sMRcN0RI4pJKP39emC0jkCuNeZAUDalh/3pOG6v1hRHHlgUaFj0n9tYvM1J9c4KQC8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766593738086555.882718969184; Wed, 24 Dec 2025 08:28:58 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vYRiW-0008Ji-HN; Wed, 24 Dec 2025 11:28:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vYRiP-00083T-Rg for qemu-devel@nongnu.org; Wed, 24 Dec 2025 11:28:00 -0500 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vYRiO-0003ss-BW for qemu-devel@nongnu.org; Wed, 24 Dec 2025 11:27:57 -0500 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-4779adb38d3so40403295e9.2 for ; Wed, 24 Dec 2025 08:27:55 -0800 (PST) Received: from localhost.localdomain (188.171.88.92.rev.sfr.net. [92.88.171.188]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be27c2260sm344952085e9.15.2025.12.24.08.27.52 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Dec 2025 08:27:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766593674; x=1767198474; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yCWaAKr9HKDQPOGDVeV4ELgBSGxrVu16jLOCiFl1Ing=; b=Jy99smcdHIvvGn42gELTjl5hCN2ZXf63ODYW2/Z1eLKaoKF6tlj2IbtAKr2oqgFvMQ VjxBVBXbWoSB8U8jFQTe99Vi+jdQu0+Uwu0EZTqPnS2tbC1StMnPfIRMiC/Z8AAHEJVN 81DdTQJlg/5S7rK8cp/mrsvJZzkE5nu8VIGESJsdQZ6ppZjYRgUMDkwYxavs4TUHcLBt TEUDkss6R4kFosyfIo7c3FGeFY2K07+53XdaB6U9HUaA7G3ctoFiNJieU6KRfBy3TpFN 43Y0V0/DB8L9oyQkHYlt4auoocglk7XQiw6Nt+7LUsmkTybxdFU0xLwBZsPM0UQm5aSO 1P3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766593674; x=1767198474; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=yCWaAKr9HKDQPOGDVeV4ELgBSGxrVu16jLOCiFl1Ing=; b=ddFPxaW2ZCWuZCcPSuJD/AYknBkZ8QVV+ytfPISFez/SlNKUadC8G4dIzC162vSRFY krKx67/ihRDyhSe3Dd/p975bhwerijJfI8tVNLcUWqnsFCiQoSYEv8CL6s5C/NpTMBKp Yt7Cq2J0fNXUAaDt66lii/1AFWOcVKGxVSqHxgbUZt35s4D4AjmBRnolRnEMOAztuDip 7AZUnTPjrBjwlBbQL2WZI9KrvsolQ4hEjK2xw1phfaMhXrpZKYVB/jCWWQrtxGTodNhX ddYiGd7St7rEYxTQd+CATxpYIcvQe2AW/9f/P4DwrwPxIomgwOE7hL0hhhIbj0QmXACh LnIw== X-Gm-Message-State: AOJu0YyXwOk6f1kfmO7T96hqqa/lV7NOfk2pitsIDsxQrrJ74ZTKikP7 zavNwiO+E2y6MluX9cmIxdis4L8TmpMSDrcEiMaQgy1ENmSsWe49i54P0U5OVMJgHhhibJX4yyl eDjLvM0k= X-Gm-Gg: AY/fxX4PymZ+RxwGbQnrtLcBL9BbvBOkaTlQV4r/KH5vsKi8w6m/dqIrANjVnS3l4JM 4Cs6QbdM24pHm72GF/NTMjh18ih2eDpVmbf8yyz7tZ1qEWIimAHFft+5OKlMR4SNJ+91Cy3R+sk SIPrDDgJmCjh7DzuG+shKJOrUnWLdv8RolzSNdeEX2VWKXnEEMXf52DrIW8KQZWyruXfulnYIEb OVF0X71Q8xm3RUmk7iildo+Bk1DpExG7s1y2KGpLuF6HDUz3Oiqw6gquCFMdk52OQou3unG3/So CUV9gQNMAy9fnOp7Z2NTbdLm9H40UlkxtYVBqPJK96Jcs71A2TO3Ttu3iOV/8OjKF20pYZkjN57 3KvbrBpBHoGOqqm408LSbi0RhoVLzC0QrjyQfztdxKfz9FmonRXzffdcDjVNvIMiFP2Q7rye9jo P1YpljhmjwJ43hJg+cJE4m8Y45SDXA0dSOpWyR1dMR7Tm8anpuBK+/ozk= X-Google-Smtp-Source: AGHT+IE7D25jXMwQKrHimj1fqfQKSy/l1W2QPXDK0tVQ14Rir4y+jRlrS0l5TKUvJrvLTcUEv6R6gw== X-Received: by 2002:a05:600c:1d1d:b0:471:d2f:7987 with SMTP id 5b1f17b1804b1-47d1958f9c5mr176679325e9.26.1766593674111; Wed, 24 Dec 2025 08:27:54 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Gerd Hoffmann , =?UTF-8?q?Cl=C3=A9ment=20Chigot?= , Paolo Bonzini , Anton Johansson , Mark Cave-Ayland , Pierrick Bouvier , Artyom Tarasenko , Laurent Vivier , Manos Pitsidianakis , Frederic Konrad , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 8/9] target/sparc: Simplify gdbstub sparc_cpu_gdb_write_register() Date: Wed, 24 Dec 2025 17:26:40 +0100 Message-ID: <20251224162642.90857-9-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251224162642.90857-1-philmd@linaro.org> References: <20251224162642.90857-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=philmd@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766593739216158500 Rather than ldtul_p() which uses the underlying 'unsigned long' size, use the ldn() variant, passing the access size as argument (evaluating TARGET_LONG_BITS / 8). No need to use #ifdef'ry to check for TARGET_ABI32, since it is 64-bit: $ git grep -E '(ABI32|LONG_BITS)' configs/targets/sparc* configs/targets/sparc-linux-user.mak:5:TARGET_LONG_BITS=3D32 configs/targets/sparc-softmmu.mak:4:TARGET_LONG_BITS=3D32 configs/targets/sparc32plus-linux-user.mak:2:TARGET_ABI32=3Dy configs/targets/sparc32plus-linux-user.mak:8:TARGET_LONG_BITS=3D64 configs/targets/sparc64-linux-user.mak:8:TARGET_LONG_BITS=3D64 configs/targets/sparc64-softmmu.mak:6:TARGET_LONG_BITS=3D64 Directly expand to the big-endian variant (with the '_be' suffix) since we only build the SPARC targets as big-endian. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Manos Pitsidianakis --- target/sparc/gdbstub.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/target/sparc/gdbstub.c b/target/sparc/gdbstub.c index 134617fb232..d265681f6d2 100644 --- a/target/sparc/gdbstub.c +++ b/target/sparc/gdbstub.c @@ -112,15 +112,7 @@ int sparc_cpu_gdb_write_register(CPUState *cs, uint8_t= *mem_buf, int n) { SPARCCPU *cpu =3D SPARC_CPU(cs); CPUSPARCState *env =3D &cpu->env; -#if defined(TARGET_ABI32) - uint32_t tmp; - - tmp =3D ldl_p(mem_buf); -#else - target_ulong tmp; - - tmp =3D ldtul_p(mem_buf); -#endif + uint64_t tmp =3D ldn_be_p(mem_buf, TARGET_LONG_BITS / 8); =20 if (n < 8) { /* g0..g7 */ @@ -170,7 +162,7 @@ int sparc_cpu_gdb_write_register(CPUState *cs, uint8_t = *mem_buf, int n) #else else if (n < 64) { /* f0-f31 */ - tmp =3D ldl_p(mem_buf); + tmp =3D ldl_be_p(mem_buf); if (n & 1) { env->fpr[(n - 32) / 2].l.lower =3D tmp; } else { --=20 2.52.0 From nobody Mon Feb 9 14:34:56 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766593711; cv=none; d=zohomail.com; s=zohoarc; b=i/TeN5diVSJiiDvg7/ucpdy3SOsbHbkFITB7xRylHCEeU7+iqPMQ6LRxE7+ieAIID/aQOJfY3SN481+KWd8hkNDcl1H0ZgWsfTfSL9yQkZPz2byzM9CDEg70Q+t7qoBOg6aKWJsNRobdbbZPbE7eurWNyCe3t7blo+obqb2keyo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766593711; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=UC3Yrm7h9DtMfXVQz3f10GYZ8/dRUZPiSUf8qPFazoU=; b=LPNidk9ZnlI9ur9/aIyG7bJKzfd7ylxd7Uz/HSM/QC6rZePY5eR8fOtaVNbDApfP+BD+DFGRnEvPZGcQEFs6lVtlKW35vH5M32c2iICNTjjZQxUpI/1o6ehyvDKyuqwUhb7lmLky6ER/nclDORwVlRLCOE2R5khzkrn+30jJt9g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766593711889524.1497284246769; Wed, 24 Dec 2025 08:28:31 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vYRib-0000Fj-S6; Wed, 24 Dec 2025 11:28:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vYRiX-0008Tu-L7 for qemu-devel@nongnu.org; Wed, 24 Dec 2025 11:28:05 -0500 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vYRiW-0003tc-2J for qemu-devel@nongnu.org; Wed, 24 Dec 2025 11:28:05 -0500 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-47d1d8a49f5so28515965e9.3 for ; Wed, 24 Dec 2025 08:28:03 -0800 (PST) Received: from localhost.localdomain (188.171.88.92.rev.sfr.net. [92.88.171.188]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eab2ebfsm34660739f8f.40.2025.12.24.08.28.00 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Dec 2025 08:28:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766593682; x=1767198482; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UC3Yrm7h9DtMfXVQz3f10GYZ8/dRUZPiSUf8qPFazoU=; b=i+c5n79crW6BjtmSQG5QgWRsp5Ba+9XbFhLaAwpVAt8I2FPPwLsnrEYlVWphCfTXte UH8YQMSbQtd+ECeI8Kbw0iOxQtG7g9OEENJJ1GBvwsGDli9NmVwTLbMPPkUNMZikTuFM wcmi32Gmyrvh0FNXbwbU6t7UITSCefLyi8Yons2XRP514EQWvfnhPOn+LeRMBW2+zxgy IHNSmcnohTBuPubvj6P+nBX8MLA07ip7OApGljY1iqpHslYPGkA/5Ibs0huxJtCut+H/ I35DuaPCwn2DKrHTFM9V0oXVzz9WiZtfb9s2lLnqADs88mj9l75rJdNDT4WNvZ+Y34m5 m+4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766593682; x=1767198482; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=UC3Yrm7h9DtMfXVQz3f10GYZ8/dRUZPiSUf8qPFazoU=; b=DEpY7eLAPjPD+kcpFIef3liLRxeAOXXUjBnPN/hXEhLsvtxoJJKRZUqOwGyUYmpNfg fifz51t3341XxUpETmuY8LEDj0ZPeyOAqszJJzx4cb7AK2QdCuX9crf+RGclD0IsKvAG HsMVBTPReE2AD9hh05BLYUVp8sGIWO8ut+Wm8ISeTHLOkibumxWNxfUil4VwqC5vB6ua jkh37ZgtzBAD0DWackji5xENlZCwoJ8oI53umFutQebIp7lBfiClA0DRLZWMZFoMFwkY FRH8OoNaLtbJd8T4HcZfEEKSt2igXej2bS+LUwxsU/FKQXD9qjPSdHNYaDWqP7yEtr6G F7sQ== X-Gm-Message-State: AOJu0YwH1W61heuZm/NHxp7woBOFNHvKuBonb3rHEqzDa2xGA5aOiv5X Uok6w/jib2KlBkE39af/Gq/wK1n+YkiGWT5v15ct6/qeXBoNKd+RZ/mFHUh5kwt9S0+4zVaMz6P SP6qFS44= X-Gm-Gg: AY/fxX5WAy2GYrUBFkhTajKa+SlnjvaOVBmWxFJOlknSoX0Sx4zMr8IkwQe5F9XdATx YkAQxp14XaIszrM9y4qErBEiB7Rpl2TQINldJckc674Yo7kZERhVwLjDZuHv5DogB0cSbEgYnKk WOKhL6OFN8CpTCK4DyDazT2kmkX7MqRM4LtjhgizwqvPpapmax9E0hfPpuo2H7JfNp3Xzij0p7+ s83hjnNzFSKTvZhv9HTDTo39oSFJT/DJMEFJzwVn0ZcyOlb6gpkyIHnLNI4pZnUJwn6VUqdwxB+ B83zHNUteMsx3bFgtQeLXgerp0OLHgHcH1qlJOfyLAPbx65NJNL+DTUCXQOA4rbCDNTjXqGSKgy Ri4t3PBW5PKf77xvtu/dVv5K2aFDmZQhz6ySAKepe0sHHtztDc3CZ/0/JwKyzJgKgelYH0TkTSM g6Moztyw67lYpN6J8l3uMITfGrcsbb5prexMSoYgj8WOFl2Ln2srHfMIM= X-Google-Smtp-Source: AGHT+IE+wbNJkINQSGVCULVimC39Zrsy+4A+dCtemnDW9V1HyQBXZqQaxqlMqnWwj9wFnRFvGcGuJA== X-Received: by 2002:a05:600c:b99:b0:479:3a86:dc1c with SMTP id 5b1f17b1804b1-47d195a6369mr189503315e9.36.1766593682208; Wed, 24 Dec 2025 08:28:02 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Gerd Hoffmann , =?UTF-8?q?Cl=C3=A9ment=20Chigot?= , Paolo Bonzini , Anton Johansson , Mark Cave-Ayland , Pierrick Bouvier , Artyom Tarasenko , Laurent Vivier , Manos Pitsidianakis , Frederic Konrad , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 9/9] configs/targets: Forbid SPARC to use legacy native endianness APIs Date: Wed, 24 Dec 2025 17:26:41 +0100 Message-ID: <20251224162642.90857-10-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251224162642.90857-1-philmd@linaro.org> References: <20251224162642.90857-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=philmd@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766593713156158500 All SPARC-related binaries are buildable without a single use of the legacy "native endian" API. Unset the transitional TARGET_USE_LEGACY_NATIVE_ENDIAN_API definition to forbid further uses of the legacy API. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Manos Pitsidianakis Reviewed-by: Richard Henderson --- configs/targets/sparc-linux-user.mak | 1 + configs/targets/sparc-softmmu.mak | 1 + configs/targets/sparc32plus-linux-user.mak | 1 + configs/targets/sparc64-linux-user.mak | 1 + configs/targets/sparc64-softmmu.mak | 1 + 5 files changed, 5 insertions(+) diff --git a/configs/targets/sparc-linux-user.mak b/configs/targets/sparc-l= inux-user.mak index 4ff4b7287d2..d3f0716ca2d 100644 --- a/configs/targets/sparc-linux-user.mak +++ b/configs/targets/sparc-linux-user.mak @@ -3,3 +3,4 @@ TARGET_SYSTBL_ABI=3Dcommon,32 TARGET_SYSTBL=3Dsyscall.tbl TARGET_BIG_ENDIAN=3Dy TARGET_LONG_BITS=3D32 +TARGET_NOT_USING_LEGACY_NATIVE_ENDIAN_API=3Dy diff --git a/configs/targets/sparc-softmmu.mak b/configs/targets/sparc-soft= mmu.mak index 57801faf1fc..272fd46f6db 100644 --- a/configs/targets/sparc-softmmu.mak +++ b/configs/targets/sparc-softmmu.mak @@ -1,3 +1,4 @@ TARGET_ARCH=3Dsparc TARGET_BIG_ENDIAN=3Dy TARGET_LONG_BITS=3D32 +TARGET_NOT_USING_LEGACY_NATIVE_ENDIAN_API=3Dy diff --git a/configs/targets/sparc32plus-linux-user.mak b/configs/targets/s= parc32plus-linux-user.mak index 7a16934fd17..3e6c72e793e 100644 --- a/configs/targets/sparc32plus-linux-user.mak +++ b/configs/targets/sparc32plus-linux-user.mak @@ -6,3 +6,4 @@ TARGET_SYSTBL_ABI=3Dcommon,32 TARGET_SYSTBL=3Dsyscall.tbl TARGET_BIG_ENDIAN=3Dy TARGET_LONG_BITS=3D64 +TARGET_NOT_USING_LEGACY_NATIVE_ENDIAN_API=3Dy diff --git a/configs/targets/sparc64-linux-user.mak b/configs/targets/sparc= 64-linux-user.mak index 7c2ecb7be06..3bbd8495210 100644 --- a/configs/targets/sparc64-linux-user.mak +++ b/configs/targets/sparc64-linux-user.mak @@ -6,3 +6,4 @@ TARGET_SYSTBL=3Dsyscall.tbl TARGET_BIG_ENDIAN=3Dy TARGET_XML_FILES=3Dgdb-xml/sparc64-core.xml TARGET_LONG_BITS=3D64 +TARGET_NOT_USING_LEGACY_NATIVE_ENDIAN_API=3Dy diff --git a/configs/targets/sparc64-softmmu.mak b/configs/targets/sparc64-= softmmu.mak index 8ee6d057682..8a0290c2093 100644 --- a/configs/targets/sparc64-softmmu.mak +++ b/configs/targets/sparc64-softmmu.mak @@ -4,3 +4,4 @@ TARGET_BIG_ENDIAN=3Dy TARGET_XML_FILES=3Dgdb-xml/sparc64-core.xml TARGET_LONG_BITS=3D64 TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy +TARGET_NOT_USING_LEGACY_NATIVE_ENDIAN_API=3Dy --=20 2.52.0