From nobody Tue Feb 10 01:31:12 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766592611; cv=none; d=zohomail.com; s=zohoarc; b=R0zYpHuu7tc1MtapRn49vkXoD39a5ss1w6R32X+Vyzqq0s0+ME50nknUFbe2kVfKYuWgZPb/w7xHnEsCDgfI42fiplPH0EOQd74dkXbPmMMyiWHlR+IEaaFyF3/rBUcicmab+54+sDT9Je26dV1MEHUW9VErq75jSeYy2Wx4EJM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766592611; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=9Tgw+sYikt+iLprmV8aTKENGQCgYp02T9R5ti5jQ79o=; b=aanmSpcGqqLKxHtDSIiUZPI2/6MIlASaimYi2SQa3t6xfBPKK2k6n89zOF84wzE787kkosWBvq8o30iAPUE4qzX6bWUM784fTd1JNXUbqjOwZ2HFVS1mP6wx31yiaGcDfAzeB97GFoP7JCalcbYpXZtbs/eAFAAGbK/lXfNOHDI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766592611229787.2234463646466; Wed, 24 Dec 2025 08:10:11 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vYRR1-00074Y-32; Wed, 24 Dec 2025 11:09:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vYRR0-00074E-An for qemu-devel@nongnu.org; Wed, 24 Dec 2025 11:09:58 -0500 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vYRQy-0008Vn-II for qemu-devel@nongnu.org; Wed, 24 Dec 2025 11:09:58 -0500 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-4779adb38d3so40335315e9.2 for ; Wed, 24 Dec 2025 08:09:56 -0800 (PST) Received: from localhost.localdomain (188.171.88.92.rev.sfr.net. [92.88.171.188]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be2724fe8sm418007595e9.1.2025.12.24.08.09.52 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Dec 2025 08:09:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766592595; x=1767197395; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9Tgw+sYikt+iLprmV8aTKENGQCgYp02T9R5ti5jQ79o=; b=o4yucO01Lgn9x8oXZXLJSAUdZa5j+BWInL5w9ob2R3UsfE/KNp5Rn/TCgoSZLlAVay KYCayce4X7TGfoBWSjHIxt1OvSrs5iST6lU+WCiaLd7fhnsO1D/8JhboSW8rCqu6XKIK mGVuulwKK7JDetNq7qQij1O1EmQWPHBHFfif5c1lskf0o8LcqEdFXnVpSvvjfb1Ly60n TpiFDWHKT5Ubfy4T/5Gj52AGO7JsCsmnpv3naWFD67pJeKXBPkP5uLBv/tT8XCBW4QoB SMmYXK243DSrUxNShwAvyZl1/SC1Fs1AeseDAQdzEgGQ7MDULHEAwd4BTQTsLRRdwgOU ZgsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766592595; x=1767197395; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=9Tgw+sYikt+iLprmV8aTKENGQCgYp02T9R5ti5jQ79o=; b=Kd9Kv6Ty3bv7UdyjEJscEYkY0da78eTUO3K1I/Lik/GcV3IvMtjgR7pnNDkwKJM/wQ 0Ps+k5iGJ4xhv/+6lbnoJqJ04PIMUcCfWwYNBJSjrXdarMXB29N+J/D3ZuKic1zPnPkT acMgTcjKVYSRbXv5llCQMfx9l7XE1pBbOEeYAublpgmWLytFz1kEdUkSv7AR1UabU2gy FdbRg1hq2sweLtjVQ7ltuSztoCvII2tFwJkhOpFO/EGhdwG+3bUER37sVlBLSvdpiZAc csz9UNr35VaWDO87nxDUqLnp0mmOzf/GZ/p9taJaZU3ae7iMuyZR/uA/9bdThZu3YFOn Evsg== X-Gm-Message-State: AOJu0YwW2qkYLYBJxEmjeP2JMV6/9UUJQMfc4s+Sx8QjeZOoEoC8sUDz iGc+OkuhJQyOJ5zDcYZENXyXlvJaV3jDm1E06fxADTvSAZ9Yq45O2yRe9nEWgk1oh8xzOqFnB+a iSbAeWC8= X-Gm-Gg: AY/fxX6lGotj+KCsGaXWZa9Da9JCWczL+wtGuwnst68s7Li6eUsRWMgQNhQwaXG6Yhv 01FTBqVEfJaQrSLNfIq4BENYntnDojuiA3h+CwNkB58fVm4GqzSuUrGsHIfc3jXXy1rrCvaPyz/ eQo6w6hWgK7gn9ffjXlGYIwVq9SuvadgtG6Lu2rymiJpqY3uxPVcctyHbrTYCO1inL+HG+H9jHG O1ORT4ikrzjkGpjGv24ervN341mEUaAazKvNQCZPGuZb+VGVebUHTHEYhBJPgyAMe2BAkKR8DZ4 tKp+I285AnGFJ3hBMXO35ePgX9CktiZWMEBxn1sFBnbW4iVsqRfcsI60/jq+HmO4+NPU5enowjX ERjSFYor3TX7mZ6G2u+6WuxSpKKvrnK2noSIpm+iUSWqndXuTw4A2zXM9MfjTRXX1r+i8DEjyv2 82SodMf2xgV8TaphGOFCUl05N581hV+7rbl/bbRRSmQJGYCLqBog5hOKU= X-Google-Smtp-Source: AGHT+IE1AS9Gx23+HTiqpaGTDdx5/1uuI+Yt3fnvnV4UYmBV6IATQ6YrgP0NuoK0qQiIEAB1kVyZ7Q== X-Received: by 2002:a05:600c:870f:b0:45d:d97c:236c with SMTP id 5b1f17b1804b1-47d3477ba3cmr83491425e9.21.1766592594587; Wed, 24 Dec 2025 08:09:54 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Anton Johansson , Richard Henderson , Manos Pitsidianakis , Laurent Vivier , Pierrick Bouvier , Helge Deller , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 1/4] target/hppa: Use big-endian variant of cpu_ld/st_data*() Date: Wed, 24 Dec 2025 17:09:39 +0100 Message-ID: <20251224160942.89386-2-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251224160942.89386-1-philmd@linaro.org> References: <20251224160942.89386-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766592613628158500 We only build the HPPA target using big endianness order, therefore the cpu_ld/st_data*() definitions expand to the big endian declarations. Use the explicit big-endian variants. Mechanical change running: $ tgt=3Dhppa; \ end=3Dbe; \ for op in data mmuidx_ra; do \ for ac in uw sw l q; do \ sed -i -e "s/cpu_ld${ac}_${op}/cpu_ld${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; for ac in w l q; do \ sed -i -e "s/cpu_st${ac}_${op}/cpu_st${ac}_${end}_${op}/" \ $(git grep -l cpu_ target/${tgt}/); \ done; done Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/hppa/op_helper.c | 44 ++++++++++++++++++++--------------------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/target/hppa/op_helper.c b/target/hppa/op_helper.c index 0458378abb2..65faf03cd0a 100644 --- a/target/hppa/op_helper.c +++ b/target/hppa/op_helper.c @@ -107,7 +107,7 @@ static void do_stby_b(CPUHPPAState *env, target_ulong a= ddr, target_ulong val, cpu_stb_data_ra(env, addr, val, ra); break; case 2: - cpu_stw_data_ra(env, addr, val, ra); + cpu_stw_be_data_ra(env, addr, val, ra); break; case 1: /* The 3 byte store must appear atomic. */ @@ -115,11 +115,11 @@ static void do_stby_b(CPUHPPAState *env, target_ulong= addr, target_ulong val, atomic_store_mask32(env, addr, val, 0x00ffffffu, ra); } else { cpu_stb_data_ra(env, addr, val >> 16, ra); - cpu_stw_data_ra(env, addr + 1, val, ra); + cpu_stw_be_data_ra(env, addr + 1, val, ra); } break; default: - cpu_stl_data_ra(env, addr, val, ra); + cpu_stl_be_data_ra(env, addr, val, ra); break; } } @@ -132,7 +132,7 @@ static void do_stdby_b(CPUHPPAState *env, target_ulong = addr, uint64_t val, cpu_stb_data_ra(env, addr, val, ra); break; case 6: - cpu_stw_data_ra(env, addr, val, ra); + cpu_stw_be_data_ra(env, addr, val, ra); break; case 5: /* The 3 byte store must appear atomic. */ @@ -140,11 +140,11 @@ static void do_stdby_b(CPUHPPAState *env, target_ulon= g addr, uint64_t val, atomic_store_mask32(env, addr, val, 0x00ffffffu, ra); } else { cpu_stb_data_ra(env, addr, val >> 16, ra); - cpu_stw_data_ra(env, addr + 1, val, ra); + cpu_stw_be_data_ra(env, addr + 1, val, ra); } break; case 4: - cpu_stl_data_ra(env, addr, val, ra); + cpu_stl_be_data_ra(env, addr, val, ra); break; case 3: /* The 5 byte store must appear atomic. */ @@ -152,7 +152,7 @@ static void do_stdby_b(CPUHPPAState *env, target_ulong = addr, uint64_t val, atomic_store_mask64(env, addr, val, 0x000000ffffffffffull, 5, = ra); } else { cpu_stb_data_ra(env, addr, val >> 32, ra); - cpu_stl_data_ra(env, addr + 1, val, ra); + cpu_stl_be_data_ra(env, addr + 1, val, ra); } break; case 2: @@ -160,8 +160,8 @@ static void do_stdby_b(CPUHPPAState *env, target_ulong = addr, uint64_t val, if (parallel) { atomic_store_mask64(env, addr, val, 0x0000ffffffffffffull, 6, = ra); } else { - cpu_stw_data_ra(env, addr, val >> 32, ra); - cpu_stl_data_ra(env, addr + 2, val, ra); + cpu_stw_be_data_ra(env, addr, val >> 32, ra); + cpu_stl_be_data_ra(env, addr + 2, val, ra); } break; case 1: @@ -170,12 +170,12 @@ static void do_stdby_b(CPUHPPAState *env, target_ulon= g addr, uint64_t val, atomic_store_mask64(env, addr, val, 0x00ffffffffffffffull, 7, = ra); } else { cpu_stb_data_ra(env, addr, val >> 48, ra); - cpu_stw_data_ra(env, addr + 1, val >> 32, ra); - cpu_stl_data_ra(env, addr + 3, val, ra); + cpu_stw_be_data_ra(env, addr + 1, val >> 32, ra); + cpu_stl_be_data_ra(env, addr + 3, val, ra); } break; default: - cpu_stq_data_ra(env, addr, val, ra); + cpu_stq_be_data_ra(env, addr, val, ra); break; } } @@ -211,12 +211,12 @@ static void do_stby_e(CPUHPPAState *env, target_ulong= addr, target_ulong val, if (parallel) { atomic_store_mask32(env, addr - 3, val, 0xffffff00u, ra); } else { - cpu_stw_data_ra(env, addr - 3, val >> 16, ra); + cpu_stw_be_data_ra(env, addr - 3, val >> 16, ra); cpu_stb_data_ra(env, addr - 1, val >> 8, ra); } break; case 2: - cpu_stw_data_ra(env, addr - 2, val >> 16, ra); + cpu_stw_be_data_ra(env, addr - 2, val >> 16, ra); break; case 1: cpu_stb_data_ra(env, addr - 1, val >> 24, ra); @@ -239,8 +239,8 @@ static void do_stdby_e(CPUHPPAState *env, target_ulong = addr, uint64_t val, atomic_store_mask64(env, addr - 7, val, 0xffffffffffffff00ull, 7, ra); } else { - cpu_stl_data_ra(env, addr - 7, val >> 32, ra); - cpu_stw_data_ra(env, addr - 3, val >> 16, ra); + cpu_stl_be_data_ra(env, addr - 7, val >> 32, ra); + cpu_stw_be_data_ra(env, addr - 3, val >> 16, ra); cpu_stb_data_ra(env, addr - 1, val >> 8, ra); } break; @@ -250,8 +250,8 @@ static void do_stdby_e(CPUHPPAState *env, target_ulong = addr, uint64_t val, atomic_store_mask64(env, addr - 6, val, 0xffffffffffff0000ull, 6, ra); } else { - cpu_stl_data_ra(env, addr - 6, val >> 32, ra); - cpu_stw_data_ra(env, addr - 2, val >> 16, ra); + cpu_stl_be_data_ra(env, addr - 6, val >> 32, ra); + cpu_stw_be_data_ra(env, addr - 2, val >> 16, ra); } break; case 5: @@ -260,24 +260,24 @@ static void do_stdby_e(CPUHPPAState *env, target_ulon= g addr, uint64_t val, atomic_store_mask64(env, addr - 5, val, 0xffffffffff000000ull, 5, ra); } else { - cpu_stl_data_ra(env, addr - 5, val >> 32, ra); + cpu_stl_be_data_ra(env, addr - 5, val >> 32, ra); cpu_stb_data_ra(env, addr - 1, val >> 24, ra); } break; case 4: - cpu_stl_data_ra(env, addr - 4, val >> 32, ra); + cpu_stl_be_data_ra(env, addr - 4, val >> 32, ra); break; case 3: /* The 3 byte store must appear atomic. */ if (parallel) { atomic_store_mask32(env, addr - 3, val >> 32, 0xffffff00u, ra); } else { - cpu_stw_data_ra(env, addr - 3, val >> 48, ra); + cpu_stw_be_data_ra(env, addr - 3, val >> 48, ra); cpu_stb_data_ra(env, addr - 1, val >> 40, ra); } break; case 2: - cpu_stw_data_ra(env, addr - 2, val >> 48, ra); + cpu_stw_be_data_ra(env, addr - 2, val >> 48, ra); break; case 1: cpu_stb_data_ra(env, addr - 1, val >> 56, ra); --=20 2.52.0