From nobody Mon Feb 9 06:19:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766592142; cv=none; d=zohomail.com; s=zohoarc; b=SO0cX+EKd+rSj1kDOV46vAGGSWv81l3BsQZk9DtgqYVb4yVMr/ft7zOEnLntJWXLJ6mxIDprDzIPyRXkohF0eWZpIfv4gPQgExad9SSjrkO0YVN6G01ihjP9JBvJebM6E1cXGptMn5VT7Wd/vruHhDhE8jYYmo0NqWzoDNfb/Ys= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766592142; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Plt/JvxJf6wWBs1it886xzqgaHX7P6k6nrPi82rdVHc=; b=bMODVsoCkXrmiWxCZZ1VPhdt8DCf/XUfeyN0AsqoOuWvITCGYgjXL5mJ485GcJWVDy2PrtS2gCEwK5lUweNZ/lmf9rqebKLDDiCXZDj4yz0PsLvn+fxxVNHMdx65TvRKN1r+w4AO0q8OgFIdKV6hRyWEPI/v7MfzJ1bRHhC2vdI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766592142110688.4201186062827; Wed, 24 Dec 2025 08:02:22 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vYRJ3-0006hJ-SE; Wed, 24 Dec 2025 11:01:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vYRII-0006TW-Gz for qemu-devel@nongnu.org; Wed, 24 Dec 2025 11:01:08 -0500 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vYRIF-00060r-Ax for qemu-devel@nongnu.org; Wed, 24 Dec 2025 11:00:58 -0500 Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-64b9cb94ff5so6612950a12.2 for ; Wed, 24 Dec 2025 08:00:53 -0800 (PST) Received: from localhost.localdomain (188.171.88.92.rev.sfr.net. [92.88.171.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f09149sm1782035066b.47.2025.12.24.08.00.50 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Dec 2025 08:00:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766592052; x=1767196852; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Plt/JvxJf6wWBs1it886xzqgaHX7P6k6nrPi82rdVHc=; b=vRqRkarvUkZWt9tRN5uqZe8OQj9kTxixTHMRwwR+2Oi1N0FQIKDZYBJi5jUKBKTN/c 6IkuRNjk94ChQbArB52mKRukTV1GKYxW1ryKRHlAIBBqqnbULUjp8Aaqa1jbSM8dqJ8/ pZIXhq+H4OR0tOqzvbfcIXjXvCi9E/hWthFP8YWCzQTfQpO2rfWQbpe+rOLgVXGRAed6 oQJF7IXD/fDohAJOY8pHgeFrtGZFo7Uuf7zWEUpd1fB5nEmty6G6IVh2Kd/aVGgGTVCg XDzwF7TI1hxFD8i5CRinzaIgpT1T71+zdrCr0y9noMA5s4QpyynaB4xDt8OjHKqtLX6t Ykyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766592052; x=1767196852; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Plt/JvxJf6wWBs1it886xzqgaHX7P6k6nrPi82rdVHc=; b=JfSUAcplj2baA/mOSsVbQj5dQfq7Di7W+HtDTk+wQ6cfLuG/HekO+ufu7tQ7fyxZkl v5XUEbdURV8JigBpCSTTshZz2zoHiDs73SoI/kYd52UZCQ/In66DYgzSkeOTg1FInswB VcBA/8QdWD22sXnTnZD3FSSFONumjPRokPxt2vWiqTEAJPWu6cEI4RL/9wrEVYS4bYTH 26t5HSEncM6h/lYMvh7ZaTu7pkJz7Hurz8KZC5lY2Jv5iWJ1SwSy1irkuT5tf+Ld0Drp V87+GxHFQgwB+JzxNcy5d3p04P20v9jRvNoPa33IrHYcmmeqFNgYukdn5ddft4D7LWYY MsIQ== X-Gm-Message-State: AOJu0YwSXGq1dpgYJezwvnoeFvC0medD6IJRizWNNwvEBoQoupm5Zx9U 7JPFnD+Fadtl5gJ6Gj0X+3oK7Rhstzsjcuc0U5nED+pddQfpCPq/mJQZNlakfC8ON/DuinbX+Iu 3J0maZhw= X-Gm-Gg: AY/fxX49GMtCjDyozDVopL/vVkJXZ6dLDbSTBu/s6tcoRS7tAPu8wHre5YSAIHtlR5a v7i9BIuBLBzgiE4uGsvx1u3Fd5APrJhIygXxK7bJ6DifXtr4FrowzKJoqeI0Fz08jOY51noPSUz Zp4mjCPkGWLitaSrmf2IeV3QGRADlpXe7XGUrQgVJ01tYEoKjfoIk3GR1CVj1xWo7u7p6qbtltD GMAzEI8SYZPTbssyj7OrFsSCtx1xOZ0GJZClv627Oww5AOmHFYclG9kQ50H/eF+cSY9Aogf8bIH OUZn1a4ppJkrE8TBFvMyuPbGxXVxZfxLXs8bcUtQrmcFvx9efPshA3gi1rQzHc5k6XSJ1BUAhCr upU0up8aVVG/rvWmeNP74YDIR7khSArZuWUB2Q5oIBRk7qESGOhyXa07Smwd44+i8sExuvMAVz4 0R+CqlmKGoUeI5IYJ62toQkDTnPX2IO3vuyUr589yubxIZjxhBRnZ/az0= X-Google-Smtp-Source: AGHT+IFEJ4+x35x9K2CEd3lsRP5p6HV3dW8pbPoB34osBXc20jRI39JRBQruVydTKjSW4jLMfSLQjg== X-Received: by 2002:a17:906:4fd0:b0:b77:1b05:a081 with SMTP id a640c23a62f3a-b8036fade7bmr1960531066b.27.1766592051885; Wed, 24 Dec 2025 08:00:51 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Manos Pitsidianakis , Pierrick Bouvier , Laurent Vivier , Richard Henderson , Anton Johansson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 1/6] hw/alpha: Use explicit little-endian LD/ST API Date: Wed, 24 Dec 2025 17:00:34 +0100 Message-ID: <20251224160040.88612-2-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251224160040.88612-1-philmd@linaro.org> References: <20251224160040.88612-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::52c; envelope-from=philmd@linaro.org; helo=mail-ed1-x52c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766592144444158500 The Alpha architecture uses little endianness. Directly use the little-endian LD/ST API. Mechanical change running: $ for a in uw w l q; do \ sed -i -e "s/ld${a}_p(/ld${a}_le_p(/" \ $(git grep -wlE '(ld|st)u?[wlq]_p' hw/alpha/); done Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Manos Pitsidianakis Reviewed-by: Richard Henderson --- hw/alpha/dp264.c | 11 +++++------ hw/alpha/typhoon.c | 4 ++-- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/hw/alpha/dp264.c b/hw/alpha/dp264.c index b6155646ef7..203b9ce92d7 100644 --- a/hw/alpha/dp264.c +++ b/hw/alpha/dp264.c @@ -194,12 +194,11 @@ static void clipper_init(MachineState *machine) load_image_targphys(initrd_filename, initrd_base, ram_size - initrd_base, NULL); =20 - address_space_stq(&address_space_memory, param_offset + 0x100, - initrd_base + 0xfffffc0000000000ULL, - MEMTXATTRS_UNSPECIFIED, - NULL); - address_space_stq(&address_space_memory, param_offset + 0x108, - initrd_size, MEMTXATTRS_UNSPECIFIED, NULL); + address_space_stq_le(&address_space_memory, param_offset + 0x1= 00, + initrd_base + 0xfffffc0000000000ULL, + MEMTXATTRS_UNSPECIFIED, NULL); + address_space_stq_le(&address_space_memory, param_offset + 0x1= 08, + initrd_size, MEMTXATTRS_UNSPECIFIED, NULL= ); } } } diff --git a/hw/alpha/typhoon.c b/hw/alpha/typhoon.c index 4c56f981d71..0a039dc8a31 100644 --- a/hw/alpha/typhoon.c +++ b/hw/alpha/typhoon.c @@ -622,8 +622,8 @@ static bool make_iommu_tlbe(hwaddr taddr, hwaddr mask, = IOMMUTLBEntry *ret) translation, given the address of the PTE. */ static bool pte_translate(hwaddr pte_addr, IOMMUTLBEntry *ret) { - uint64_t pte =3D address_space_ldq(&address_space_memory, pte_addr, - MEMTXATTRS_UNSPECIFIED, NULL); + uint64_t pte =3D address_space_ldq_le(&address_space_memory, pte_addr, + MEMTXATTRS_UNSPECIFIED, NULL); =20 /* Check valid bit. */ if ((pte & 1) =3D=3D 0) { --=20 2.52.0 From nobody Mon Feb 9 06:19:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766592223; cv=none; d=zohomail.com; s=zohoarc; b=QvaiqHDSAh7nM53oKxl1JPQUNdqTMyarNcoAFL87+gOM5gCcN+UWIOrf39AY8krUpGYWD4zcEyQ77KOuPsXIrw8nFTTXcXN7H+Q+fJyy/gx56Lwk74dTQHM4+fOzj9Gr4K4nBb3w42Sc9ulwlmMMBIvVzP9dGZpSV79CQW041e4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766592223; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=XXKguHOd+ctmSd1zEyzRjZGeIuzMCy1ZsflVpDcJ4q8=; b=jquR32DE5bBKF3BJbUn9DvaK3W++FB0ibjFyYclxLSvhR2XnsUEb3qoaoNV5gctcFPRK5w/uccQkxQSJ8w7cW+xN6mTCIy+HnpFH+4+/hP3diXLEAxKa5IMtIfQBuFVJ5gOvfK6jAamE0o2AU96Wk+q2jwLSetY/+ipzfS1bKx4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766592223196528.6762505117292; Wed, 24 Dec 2025 08:03:43 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vYRJ3-0006h9-MZ; Wed, 24 Dec 2025 11:01:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vYRIP-0006Tt-F4 for qemu-devel@nongnu.org; Wed, 24 Dec 2025 11:01:17 -0500 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vYRIM-0006AM-Vl for qemu-devel@nongnu.org; Wed, 24 Dec 2025 11:01:04 -0500 Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-64b5ed53d0aso8683494a12.3 for ; Wed, 24 Dec 2025 08:01:02 -0800 (PST) Received: from localhost.localdomain (188.171.88.92.rev.sfr.net. [92.88.171.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037ad806asm1801266466b.23.2025.12.24.08.00.58 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Dec 2025 08:01:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766592061; x=1767196861; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XXKguHOd+ctmSd1zEyzRjZGeIuzMCy1ZsflVpDcJ4q8=; b=RJhF2VG3jqqkmFiQAuYMOrMQF5skP+CloAC14HW0/0qk3GnqvZ5/AeiRL58L0Lgxih f8Ot1rapdhaYQJITDO+tVWWIe5QGDHQyAYuBNCPTjDkAGzih/W5TbmkcJ+85Yo9MZNNJ Mz+NA4e/449S+jPm4SdbFuKroGSDfYN/wpxRc5AIHcIQ4mWEcpTz0rpqYk9o8+Zk9cBO q8M/a/ZxiHxlpVAmFLAdR/BywZyt3GYeEyKQrQP/ypIiH/5ciby8TA+2Iv3iWRWB6WBr 2nGyfX0Y7x1dp70RwF/kh1K7LYx4xQERrnOlXdG77YbLhhq7KGUF1wO/dZji25vDb+88 3y+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766592061; x=1767196861; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XXKguHOd+ctmSd1zEyzRjZGeIuzMCy1ZsflVpDcJ4q8=; b=Ssq7e78H47CGG4PKpZGZM1GcvXezfzFuSUpa1wkOSSMt/nOFqX5ApFaAiYdXYcrKQ9 /fGBq4Ffi5s6xc4JoaibUcXLMgXrb+pyPUpo1NdK/Y9J6aieFJ4gDglK7XpHJgvVO42m bnN8fGV9xnlQy7FQ5PXYF7dm39C59O74GLMAcB8lCXrkQLPmiwrRzO4cZ7BSp9nELthw 2Sai6GRRqFlHc/Jj4UCWjcx6N5MUjx0bQiQFsXQZYvcSPB4T+rVvHXaTMomb4vvCy1eZ HJBNXjyAc2wz2HHxV3snW5el2CC1UZB1sVz4m+tiNRqXnd7dR580xQ34v0ABJ6J2Mr8E XX7w== X-Gm-Message-State: AOJu0YxHuYT8WwGzY/pmwsXq3zkO3+h1WrJcxlAYFrnldp/S4hYSK+AJ EXZdpJ8CQNWREKR+2hGfifVUSVJQjalJLCPz3oD07TZVtdr/JzaJRx5OI4WPukEoWKJpnT1OH+R x6jocQk4= X-Gm-Gg: AY/fxX6Yvs/fgq23IhLt+VVsikE+WNuxfEMTM7uKMJqVrpMH4NS+qGsco1m9LC41goI FtNMPNZTdQk4eWCydRwAsx67kdHOHpfrlzxZoKU/bHthZSVOyBCw4UsKBiLq0Lp9ea822/q/J2L lUugRihWFfbmyY/3B4EMqUUPFiHYE6FAC02xiUffnNwH9Suy7Gp2tEIuQWn9fJ7v3UPlVnbPWhA 2qKlRVqvVTC7nmqjKavtE22iOh8knHzxUIxKa3s5bfVu2ud2Ba60VNmAuVrh6FRqk8FJNYZmfdX 4/cF+iFHRhCv2eTm12urAh9Jy2rEKCQmPi02e7HNHmSD+NJSWxJ9cufBMmUVKRlZeVc2q6DcDaD 6HKlhxLu/jl3EBtVKKPPDhgCZfnwjVBUXICdDLg9snTsL43j5JPVWFL2lM6mQXUjAPWt/jk6qJo yVD1jUWHSjZ89/Lmuk/vjupap9z+kvJCgZFOpXZWf9JBdD66KvEI3mq04= X-Google-Smtp-Source: AGHT+IEoNYQuJKch0T4HelQjnVNjp99xZFdzxgUUNfst+116Tm888TGCKRCRE422C1d9F31i7z5KRQ== X-Received: by 2002:a17:907:720f:b0:b73:8639:cd96 with SMTP id a640c23a62f3a-b8036f3a367mr1837345466b.24.1766592060522; Wed, 24 Dec 2025 08:01:00 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Manos Pitsidianakis , Pierrick Bouvier , Laurent Vivier , Richard Henderson , Anton Johansson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 2/6] target/alpha: Use explicit little-endian LD/ST API Date: Wed, 24 Dec 2025 17:00:35 +0100 Message-ID: <20251224160040.88612-3-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251224160040.88612-1-philmd@linaro.org> References: <20251224160040.88612-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::536; envelope-from=philmd@linaro.org; helo=mail-ed1-x536.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766592224821158500 The Alpha architecture uses little endianness. Directly use the little-endian LD/ST API. Mechanical change running: $ for a in uw w l q; do \ sed -i -e "s/ld${a}_p(/ld${a}_le_p(/" \ $(git grep -wlE '(ld|st)u?[wlq]_p' target/alpha/); done Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Manos Pitsidianakis Reviewed-by: Richard Henderson --- target/alpha/helper.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/target/alpha/helper.c b/target/alpha/helper.c index a9af52a928f..80542cb0665 100644 --- a/target/alpha/helper.c +++ b/target/alpha/helper.c @@ -214,17 +214,18 @@ static int get_physical_address(CPUAlphaState *env, t= arget_ulong addr, =20 pt =3D env->ptbr; =20 - /* TODO: rather than using ldq_phys() to read the page table we should + /* + * TODO: rather than using ldq_phys_le() to read the page table we sho= uld * use address_space_ldq() so that we can handle the case when * the page table read gives a bus fault, rather than ignoring it. - * For the existing code the zero data that ldq_phys will return for + * For the existing code the zero data that ldq_phys_le will return for * an access to invalid memory will result in our treating the page * table as invalid, which may even be the right behaviour. */ =20 /* L1 page table read. */ index =3D (addr >> (TARGET_PAGE_BITS + 20)) & 0x3ff; - L1pte =3D ldq_phys(cs->as, pt + index*8); + L1pte =3D ldq_phys_le(cs->as, pt + index * 8); =20 if (unlikely((L1pte & PTE_VALID) =3D=3D 0)) { ret =3D MM_K_TNV; @@ -237,7 +238,7 @@ static int get_physical_address(CPUAlphaState *env, tar= get_ulong addr, =20 /* L2 page table read. */ index =3D (addr >> (TARGET_PAGE_BITS + 10)) & 0x3ff; - L2pte =3D ldq_phys(cs->as, pt + index*8); + L2pte =3D ldq_phys_le(cs->as, pt + index * 8); =20 if (unlikely((L2pte & PTE_VALID) =3D=3D 0)) { ret =3D MM_K_TNV; @@ -250,7 +251,7 @@ static int get_physical_address(CPUAlphaState *env, tar= get_ulong addr, =20 /* L3 page table read. */ index =3D (addr >> TARGET_PAGE_BITS) & 0x3ff; - L3pte =3D ldq_phys(cs->as, pt + index*8); + L3pte =3D ldq_phys_le(cs->as, pt + index * 8); =20 phys =3D L3pte >> 32 << TARGET_PAGE_BITS; if (unlikely((L3pte & PTE_VALID) =3D=3D 0)) { --=20 2.52.0 From nobody Mon Feb 9 06:19:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766592186; cv=none; d=zohomail.com; s=zohoarc; b=R8VzSb8jLmjFsruhfsii+dIqvs0hInroJ+ittE5RhtYKI/ROnmd/qoVPawKLUPUNlG7F+c9sc+WUy6fIv02ryXudLec2Q6aNlt7K7x7iompfYSxI4n0nP4kUyzs0RfrlX45vWl8rWns2WC4Pi9fylTad67MWalIHHmP8UrW3wYo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766592186; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=y7LlkqUnSiDvgUOMZirWuDEM7gLUdON5nHRETaU0k+Y=; b=WGt8KC7+sOa1DR0zXOqMcvjJFD9xHkbDgkvlqiVCe8eu3rIw/6w3N4jtkaEgunUzVhjSQ+Dl5LbQ5BlGeosc5gONqHA5WM46vZOBEK3K7rvQtgxx2vN0wvzELe+kdYwGjmdIdCZ2hxqXcLj1nr6JldDKTcXKS/6DqPPk/DG44zA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176659218651479.51571720780896; Wed, 24 Dec 2025 08:03:06 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vYRJ5-0006ii-5C; Wed, 24 Dec 2025 11:01:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vYRIe-0006an-BB for qemu-devel@nongnu.org; Wed, 24 Dec 2025 11:01:38 -0500 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vYRIZ-0006Lw-BX for qemu-devel@nongnu.org; Wed, 24 Dec 2025 11:01:18 -0500 Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-b7cee045187so1079213766b.0 for ; Wed, 24 Dec 2025 08:01:11 -0800 (PST) Received: from localhost.localdomain (188.171.88.92.rev.sfr.net. [92.88.171.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037ad83dasm1857633966b.25.2025.12.24.08.01.07 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Dec 2025 08:01:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766592070; x=1767196870; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=y7LlkqUnSiDvgUOMZirWuDEM7gLUdON5nHRETaU0k+Y=; b=HLgqlOBmkLLhc6sppzY4+cvIkx8U2n2GILkaaUMCXs36JxSyngg1PZcY1p2s+NHgiO LRAEp5YA0nSTEeljrt6bA1RVf6hvzeOCwRU/Iv6grsWXbgZVPRawKAM2nUIOD72YlY58 mQc/Hh/G01pQBfcBsoJK6KYcj+r1/20sYNIac0mivALNj+fz5kKka+Pdas6ovh6SVrGl SzMbv6oHt//M9W/iluZsfPjlx+LjztLmdQiGkn1oYyCC985UoBqgfjc91LARgIdAIHVz ekc/AOsOejsnIaiEDQb1bfZ/w2X+xXGQF2Dm48hsF3H2Av3aeiycBLeYJBtBM6ozMY7b QUXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766592070; x=1767196870; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=y7LlkqUnSiDvgUOMZirWuDEM7gLUdON5nHRETaU0k+Y=; b=MvOVAGsgvayHFRrycM/upQ2/YsljQvdE2+HqYsWxwWD031BzhjX/xh9lF+03EOtR23 r596ABNSd1d3p6vhaO1+FI424GPLCRGBIDRDFUeWrcJWl5bega9TISjzxBM4u5RC/+YD wNctbWNpPowMA7SmWyp8exxmXVdpvW+4RF6vjRaYWtJH3x0lYqWHA3v4+tWJd0+/zhMr kPyEM42N9JQeYSz/k3zxWfD3Qz//rzQUbhxytxanWYgk5iZ/CiCHvyQiOel4BiDLLFfC 0GjRDg85Hn7Wn3dbnSyDZ8OaI7TZuD1pdwLIzkKKrJmGFPTn6d1cBx7vBmRgOFqkmXLW /9tg== X-Gm-Message-State: AOJu0YxM4ComnT1C7VxUyUfW1XLhh5HG2GKHu0k12D9yEeaXQiSISfCA Lqj347KnUa4WqwrbuSrAThY+L6DITQvXDcgKZYj2jVC2O+WQ8Y2PtDcvIniRB60AcSP7cflYRRs fDIJjSnU= X-Gm-Gg: AY/fxX7Yv/Amz+WQwmP6okme9qz1QivS9LYonYs+/b8Ezv8f3GFIUI4Ox1/itmh6F59 wuKSRusDs2NLjFu3b4dc1EANknXg9MWO6r6uPy5ERpnGdfFaWrtyOj7g/oMXGpIIKLQ8ovo6cDd sTgwSEaWNRiiXLT9ZRcc7ERqdiChQQj06uO6WSRUfS6QCcH1UKo7vc/2Pa51zeypZD4n1Ou6uaz HEBwok02fyhNApkE1sYfHvyfxLqDAwaJRijA24r5TLpz8OXrjVW6rkjqAcc5id6rIvzf7BJQ/K9 28I6a0Hj6dNzpO+TxrWwkSYnoE6t5KBqps61R1chk7M7dIZ0AkmGlFp3pygzz9HKxcTlVayT5rn bp/iG2Zaxzt4TX3tc+l5OHKSl6uOpWp+5SMyhWjBeFgZ5hybmO2OcZI9iqwN3APz8CL5cUIdsNT uy1eZF5krn5GNhPeAUgXPsXHdh0qNT0v0buIyXO/9nMLelJ9Jy4ny+5AQ= X-Google-Smtp-Source: AGHT+IHDW+02wxJfJV4idVw0Baj3VFK3rcdn1mUbF5kHj7M5lMaoXVEIqxKPeC/Ai8Q0o/88v1mnkw== X-Received: by 2002:a17:907:948a:b0:b79:ea1b:f13d with SMTP id a640c23a62f3a-b80355b7986mr2380994666b.2.1766592070246; Wed, 24 Dec 2025 08:01:10 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Manos Pitsidianakis , Pierrick Bouvier , Laurent Vivier , Richard Henderson , Anton Johansson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 3/6] target/alpha: Inline cpu_ldl_code() call in do_unaligned_access() Date: Wed, 24 Dec 2025 17:00:36 +0100 Message-ID: <20251224160040.88612-4-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251224160040.88612-1-philmd@linaro.org> References: <20251224160040.88612-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::62b; envelope-from=philmd@linaro.org; helo=mail-ej1-x62b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766592188678158500 In preparation of removing the cpu_ldl_code wrapper, inline it. Use the return address argument. Since Alpha instructions are always stored in little-endian order, replace MO_TE -> MO_LE. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/alpha/mem_helper.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/alpha/mem_helper.c b/target/alpha/mem_helper.c index 2113fe33ae2..572ea9cb418 100644 --- a/target/alpha/mem_helper.c +++ b/target/alpha/mem_helper.c @@ -24,13 +24,15 @@ =20 static void do_unaligned_access(CPUAlphaState *env, vaddr addr, uintptr_t = retaddr) { + CPUState *cs =3D env_cpu(env); + MemOpIdx oi =3D make_memop_idx(MO_LEUL, cpu_mmu_index(cs, true)); uint64_t pc; uint32_t insn; =20 cpu_restore_state(env_cpu(env), retaddr); =20 pc =3D env->pc; - insn =3D cpu_ldl_code(env, pc); + insn =3D cpu_ldl_code_mmu(env, pc, oi, retaddr); =20 env->trap_arg0 =3D addr; env->trap_arg1 =3D insn >> 26; /* opcode */ --=20 2.52.0 From nobody Mon Feb 9 06:19:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766592142; cv=none; d=zohomail.com; s=zohoarc; b=D2fQS0m+fN06SL+SHlicHLV6g/STSCR2/c9QTpKsVd+5W+VW4Z5p4VlGplt3FlvkGfxggQ9DDGIGuoKvVnUPb3LyKHt5799L03ZVYqG0xe+5jSM/jYGputpL9PbW7QH6iHa0Y6Et2xPv0hixUJ/weYx+NX8ZtIF49CVQn7Cpbjg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766592142; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1emzPSC3gusnZjhr/h3A8H4qzJRX881GxPIgVK4nvpA=; b=Z0EMYlCU7rjH3PyIXRP2oYu/HqTdUfabzWzuKpWJqfl6wo6yhDpfDo/hp2JCskWDgHNFi8zfDtPUoa/zA2W0qbj+VXvHo81Zbx0WYwETcxzbgnZg82cCqS/LrC9irbZEmmMnXD1+7DJ4eUEbFuBkC2OFdIyk1kw8h2xlsLgvwac= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766592142521306.090055015145; Wed, 24 Dec 2025 08:02:22 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vYRJ4-0006i0-CD; Wed, 24 Dec 2025 11:01:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vYRIi-0006b2-Jx for qemu-devel@nongnu.org; Wed, 24 Dec 2025 11:01:38 -0500 Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vYRIe-0006NB-3y for qemu-devel@nongnu.org; Wed, 24 Dec 2025 11:01:21 -0500 Received: by mail-ed1-x541.google.com with SMTP id 4fb4d7f45d1cf-64d0d41404cso5887434a12.0 for ; Wed, 24 Dec 2025 08:01:19 -0800 (PST) Received: from localhost.localdomain (188.171.88.92.rev.sfr.net. [92.88.171.188]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64b91056731sm17083232a12.8.2025.12.24.08.01.16 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Dec 2025 08:01:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766592078; x=1767196878; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1emzPSC3gusnZjhr/h3A8H4qzJRX881GxPIgVK4nvpA=; b=vy3+LJDzz1Sm6vazUeYigjV/fDgxJlMt7FE/zeWyTZbFDsuaWadrhEPZ608qIXxulH +c+8ij9MVka9YwXHTNdoFg8eTzTvAeXPWIksQ/7G1jxKIna8hZWPDTeYgEfZbR0tb4/0 KuDS360CxvOxkWYK3oAHkjCDziDelKRaE68ydsJE2OGmSJYWEqiNd2WbCbyhOFCcrpYM dX6+ldCRAZzUcQF0a0FOJxtnVxI8wCVNGJqEeJ0Z1Gfa8BHu0yvlEsHr6EmZjwLopSDr pighFvdEKU+MtUa9fXdk8qjvtO6mnfte0mPIElX1o/9pKvLMZ3HWowR9kq007QJkpk1f fWsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766592078; x=1767196878; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1emzPSC3gusnZjhr/h3A8H4qzJRX881GxPIgVK4nvpA=; b=caWi9thmTvykjJxMdf5V4YOQnd1nh9DuWgKLvD6hIC3vYTgprkSKwL4EezwfQSEjkP hxxHAVRezPCQiUIEPTXtWKOAn5OKqT3h1dH1oEKyhB18gGS1/FkklJCqFsHvnGA00ZrG WbmgqBUWfjCHiU6hZ1JWNaObapiDDov0G9HCYouAgz4gf0n+YMiRo8DQD3GmEuPGx3cb MDxHK+dPVLK0k+Cb/zrFS+k/GRaDYn+oRzglwi0JsJiZ0jFuGMTEYq9rqzBXcGcSyS56 meMLxRuCE5ZmOG2CxzYBvzscFdzdyRpqpSFbz7BokDtKuE7eK+vDaWzvX3glVcaFGVHr yLAQ== X-Gm-Message-State: AOJu0YxFVf+wWuLEXPnuE94Wte0D/Z5dIw9sqGd268d4p2uz++ss7zQi w59A58E63SUU1EMLDUW5gsR3OKn/cDKOVt5sqw2NPja1iOjwoI2fG8ZqUoWKUEW7fbnTAhEVfzU gUxTIw2Q= X-Gm-Gg: AY/fxX5k2v11XkQq39t9yTTNMEmB++I7U7w4HyKA9if0Z1XtMbo/LAiWOC/4+qduHyx lom7ZZfKK6hqLeNkIZIeQUW2jLu7DFpp8P0rVFrFZ/W+eKhDXmzWiraNjC+E5J69loTAGcVi+ao osmKAxW/YLie5/dweRogmQR5WTtoRQbk1a9KItJd8bD8F8oifT3qbYw4qnWjQyem+2ERXudwO1Y wBfwhG+Zv3mRyU3fmoHuSY2/a7rj18D5z+JiIvJKU0hsMuNRkSnYVrYinAwG1Lo6tHE1ZsJknLo 5HbCzvWvQTFyLPvZaKTPfVLB/1UpVVJVwJH7rQHE036m1aqSJLRL/ZOIJ03vSK0kQATzVwqGhH6 whAMFn6nEBGkCHYIhgKQQ0AepVkOXMKmS1VexvJI/hRZdOFI91Msr9aZxhEoAIEPL8wWcBDwthI KmAoKOcS9h+gK0EXsIFMiuXPt6qEvohhoCi/LOJkCkDZS1ci5IFvtf+a0= X-Google-Smtp-Source: AGHT+IGrmT47y0Tgu3x29eGCCLLf68kqVtHqncd25SuAU86IXXHvsZ2PvybVFWXBH7Rqa3Ry9PxR4Q== X-Received: by 2002:a05:6402:51cb:b0:64b:3eeb:80b1 with SMTP id 4fb4d7f45d1cf-64b8ec6cb05mr15828835a12.22.1766592077771; Wed, 24 Dec 2025 08:01:17 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Manos Pitsidianakis , Pierrick Bouvier , Laurent Vivier , Richard Henderson , Anton Johansson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 4/6] target/alpha: Inline translator_ldl() Date: Wed, 24 Dec 2025 17:00:37 +0100 Message-ID: <20251224160040.88612-5-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251224160040.88612-1-philmd@linaro.org> References: <20251224160040.88612-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::541; envelope-from=philmd@linaro.org; helo=mail-ed1-x541.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766592144435158500 translator_ldl() is defined in "exec/translator.h" as: 198 static inline uint32_t 199 translator_ldl(CPUArchState *env, DisasContextBase *db, vaddr pc) 200 { 201 return translator_ldl_end(env, db, pc, MO_TE); 202 } Directly use the inlined form, expanding MO_TE -> MO_LE since Alpha use little-endian order. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/alpha/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/alpha/translate.c b/target/alpha/translate.c index b1d8a4eb80a..48ac50a7cdf 100644 --- a/target/alpha/translate.c +++ b/target/alpha/translate.c @@ -2904,8 +2904,8 @@ static void alpha_tr_insn_start(DisasContextBase *dcb= ase, CPUState *cpu) static void alpha_tr_translate_insn(DisasContextBase *dcbase, CPUState *cp= u) { DisasContext *ctx =3D container_of(dcbase, DisasContext, base); - uint32_t insn =3D translator_ldl(cpu_env(cpu), &ctx->base, - ctx->base.pc_next); + uint32_t insn =3D translator_ldl_end(cpu_env(cpu), &ctx->base, + ctx->base.pc_next, MO_LE); =20 ctx->base.pc_next +=3D 4; ctx->base.is_jmp =3D translate_one(ctx, insn); --=20 2.52.0 From nobody Mon Feb 9 06:19:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766592221; cv=none; d=zohomail.com; s=zohoarc; b=clAo0l7UoCjK1zlGNDN2IBiItgu8Mdkg3L3qY2rNtjE/GO7JUOgWS/sZCiB7SplFtctjkLN8GotmZ4DKpUiBLQAwmi801OnqHE1JwUDbaBZXR7PfKyer84LmGuqggzl2uXSBc+n87KOwKpQeNd7ZIaDzR8PPvimP60Btyfvxuhw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766592221; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=TxI8NcLb0sSwsafe727o0TmJhll8M8GoPEr1FiUnEX8=; b=P031yOg/Lwwrl7XO1iHHcW/AA0k+qn5cYTynb/TLIlnyNbM2/sPYS/Cun6omAC7+dxMAmxfQ99sGdmdCYeTg1Pb3+YVEiXfhrTgM20ooQoMUHQAFfBDf/WKZ68rEuAqyHIgBzCRgnfuwMbSbn++srC/SeFVakbEY6wwWQjHVkR8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766592221121539.120181089013; Wed, 24 Dec 2025 08:03:41 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vYRJ6-0006kD-IB; Wed, 24 Dec 2025 11:01:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vYRIq-0006bo-CN for qemu-devel@nongnu.org; Wed, 24 Dec 2025 11:01:42 -0500 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vYRIm-0006PJ-54 for qemu-devel@nongnu.org; Wed, 24 Dec 2025 11:01:31 -0500 Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-64baaa754c6so6032683a12.3 for ; Wed, 24 Dec 2025 08:01:26 -0800 (PST) Received: from localhost.localdomain (188.171.88.92.rev.sfr.net. [92.88.171.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b80426fc164sm1657353466b.30.2025.12.24.08.01.24 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Dec 2025 08:01:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766592085; x=1767196885; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TxI8NcLb0sSwsafe727o0TmJhll8M8GoPEr1FiUnEX8=; b=LTS9QXKbrzGD/vrtQ9fSYr1vWvKck4NWjft9u/W4mRWaqH1DWAx5qMgTRHYaH0z5DT QUfQbMWVDeC27/TsSoFg8c+Q0Azi1yGOT3bwC3x/zBYreAlcrZlHOjmH8DZA9h/SLY2/ IpzMjLCujFYj9flG5bopsgZJTdspiDT9dHU29oZC5gTCNfvDGsJ7He4OrQNPjEFS7pgN SikaxPSLmzSam/SOOTOOy45QRZ9edLjQUDCkJGQIuf0bcmlL+m8EiIA7p+oXtIMRyLDS ImRmYQ/gsjdAzssoHUKZoKdC1kS3xXtY09moNgKPtB1Z9FPnntBgU3oFLdVsGTlb9GGE pY9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766592085; x=1767196885; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TxI8NcLb0sSwsafe727o0TmJhll8M8GoPEr1FiUnEX8=; b=hcj4Yi1cOU9MJaQCjz/UEJ7atg06WTakKZgVFy9rsWKDYlDoWu8is1jbJeWclqzspm Mz2qNPJmnhLI8WAC3UoL3nhNR8+hl8ItmAhbyIl6AcgPd/0dbB1bL566/6oSbVT2hGoo LQNx+Q8BwRg0uH/uxFoYrcWkghNTpFGqUHyVjSasz+kl7kC8dttmD+1keKmqmwt07CIQ cU3cgSXrhACC4GLZbCNGZGpmAsc0XemU63HWzl4ZbQ8vINRRh0JFYED9cgeMVr0CgrcY r4NybBuMTXno09o39vpD3ZC4PJqSH7NKnqS9kPTPVDImEzDQGsW/Knuw8THzI9Nx4YBq UqaA== X-Gm-Message-State: AOJu0YzcSCN4EBIrEUKEzOUJsHXQ0oSdHoQo5mnHSZ40O/dIyOeevSKJ 5U1H/OkBdEfbIFO6rpvoguyKv21apC4hrrkSo7GE9CHODqJJVxFoIWPaItVHp8FDi4daCkWUmcl RHE1t7XM= X-Gm-Gg: AY/fxX5inPLcarMkbZ7ToxuqonGGGCk+btQEPV2cBRaTXPiaYDlzUZJWqwFcc9rG+80 ZaN1J1ef4rvxxSvaKVHL+3yPvGC6TuNKzwub64Vk2gneVggR1wulhalrc6p9Z2GVwRcwEoyiK56 HJA41ndFzeESz92gyQeGDDme5+NBIh415pjCzdVIWSgK6mVSgsZxKU2ppz48ECqDuifOLouGjQ1 XT5DMePDs1W928+ag231/0hNec8jBD0AZNs4ElvkwF7T9tQIJyNT5Gv7nebW4B5xwrfLD6du2eZ 25lJ8wYoAMVylVhh62JP3eb0Hbq1n635B8tvUjKp9tt3BkTLH6WbyJwkUOPoOyiEVNddN2LlNq1 OePSTufEKqQMYxbPgqjBNsAU0Qz6EeASXJw7jvTDxUqrxy0ARQ/3F86MIG0XIMx7DbXidhV7p1H 8jbm1YiCQwRReMV3ARb/UtRQPBGME2jdLJQJGsHe6OARItCs9AkUVfrjY= X-Google-Smtp-Source: AGHT+IFDUL+mV85KvrDCMgc+KDm5xr1c3eDL2UvFVYkaapVLk1TTszgNj9lEoLkv/juu2Co4FpQg9Q== X-Received: by 2002:a17:907:970a:b0:b79:e887:e1b3 with SMTP id a640c23a62f3a-b803727bec3mr2082044066b.57.1766592085463; Wed, 24 Dec 2025 08:01:25 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Manos Pitsidianakis , Pierrick Bouvier , Laurent Vivier , Richard Henderson , Anton Johansson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 5/6] configs/targets: Forbid Alpha to use legacy native endianness APIs Date: Wed, 24 Dec 2025 17:00:38 +0100 Message-ID: <20251224160040.88612-6-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251224160040.88612-1-philmd@linaro.org> References: <20251224160040.88612-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::536; envelope-from=philmd@linaro.org; helo=mail-ed1-x536.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766592222912158500 All Alpha-related binaries are buildable without a single use of the legacy "native endian" API. Unset the transitional TARGET_USE_LEGACY_NATIVE_ENDIAN_API definition to forbid further uses of the legacy API. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- configs/targets/alpha-linux-user.mak | 1 + configs/targets/alpha-softmmu.mak | 1 + 2 files changed, 2 insertions(+) diff --git a/configs/targets/alpha-linux-user.mak b/configs/targets/alpha-l= inux-user.mak index aa25766236e..ee505e16ef4 100644 --- a/configs/targets/alpha-linux-user.mak +++ b/configs/targets/alpha-linux-user.mak @@ -3,3 +3,4 @@ TARGET_SYSTBL_ABI=3Dcommon TARGET_SYSTBL=3Dsyscall.tbl TARGET_LONG_BITS=3D64 TARGET_XML_FILES=3D gdb-xml/alpha-core.xml +TARGET_NOT_USING_LEGACY_NATIVE_ENDIAN_API=3Dy diff --git a/configs/targets/alpha-softmmu.mak b/configs/targets/alpha-soft= mmu.mak index e31f059a52d..22fbbf0cb08 100644 --- a/configs/targets/alpha-softmmu.mak +++ b/configs/targets/alpha-softmmu.mak @@ -1,3 +1,4 @@ TARGET_ARCH=3Dalpha TARGET_LONG_BITS=3D64 TARGET_XML_FILES=3D gdb-xml/alpha-core.xml +TARGET_NOT_USING_LEGACY_NATIVE_ENDIAN_API=3Dy --=20 2.52.0 From nobody Mon Feb 9 06:19:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1766592162; cv=none; d=zohomail.com; s=zohoarc; b=OXT12xPaqGMTELNxWm9iXXgS0HOjcMGI8lDMB1KKbHp+UtnCL8cS0v4JDIxb3PeIuvw5HPc/1MYLBnNmCp8BdUcyBmzYDa11PgEWIC6S7PZxtMvhwxxJkRg3iCmDNpgi/XXszaMadkaGiPZ6XyjXIRPdOPiAR6TKIWQlTlRLc6I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766592162; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=DTI6luMu/GoW8moMtBb4PmT7PmqiDrNPT7xR87KpTns=; b=cO6P4nD6JayFx8xRjHbzkW5JZ+sUiUvI0EUDKjST8ISQrcLCGCHWyfsy/QuwbJBonW13lgxHlM/lshtOYU+WjPkjfXtqwOSsPdYn7TYtsXVM1hLGHpqpoqmpx+WpJgEOmgCVbqq04s0tlqoBtqcxgmHge539FPK/tJi7+nCm0HY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1766592162479240.99757259248724; Wed, 24 Dec 2025 08:02:42 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vYRJ7-0006kS-3R; Wed, 24 Dec 2025 11:01:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vYRJ0-0006eY-EB for qemu-devel@nongnu.org; Wed, 24 Dec 2025 11:01:44 -0500 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vYRIu-0006Ru-9b for qemu-devel@nongnu.org; Wed, 24 Dec 2025 11:01:41 -0500 Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-b7277324054so978763766b.0 for ; Wed, 24 Dec 2025 08:01:34 -0800 (PST) Received: from localhost.localdomain (188.171.88.92.rev.sfr.net. [92.88.171.188]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8044f4acdbsm1651790466b.22.2025.12.24.08.01.31 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Dec 2025 08:01:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766592093; x=1767196893; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DTI6luMu/GoW8moMtBb4PmT7PmqiDrNPT7xR87KpTns=; b=rqoYZ7SlaETRQSof+G6LGyc4u7dUGhDAxOq0bl/IeUYCl8/Jdm1Ui33wWMO1PoZp6K FcBOWfbtexmmVsnp8FZuQOAQ0Gq31Fukb5trtcveuDTfPgeoAQFEi8RucJxWUdBmZsd/ r2Hx5EtG6waiVOS0VrdEL8dZVn6JnBcEWr+fj9WpPqqOdhOdGKEAeVgOKoburc+V962N m1MFRmXgryHgemD5eg6IA6JkP10VBv0NOOIa0bSi4P8Mpl5Fx4N9N4NTInroN+ZtDQEo 8/f4Jv+l8IbDI2I0EsGkq9aOLF2BgEJpAgnaBF4zdrsCrwFmk12wT57X5IhTSSZ1wYT1 56+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766592093; x=1767196893; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DTI6luMu/GoW8moMtBb4PmT7PmqiDrNPT7xR87KpTns=; b=H1tPqIuH7Tqsh8QobtopfZQim4cFD/jWXX90r4i3Z7fvZHVrQsU8aeBkQ7QGARunSq DhhZExwQIDGJE5Jpp8xAmKASAdApRiNEjYCExRy8phAwhd8Q/Dj0/j7TrcLuRTjbTbLs 2OHYjfuM1e+PMAg/46xKIi9h9RInhtNoT/X0IMfIODpOHk4MwF94KZ0/Klmf4ykNKt3c bMYP17epb8REtB6hsd13rHgq5SvtKs2j2QZq6bqm4teZC8jg4f94QlRCOw9FNWQXRPvb yv/x7LmR2pOhSZeoRyuvHBy4ayNOAuXOvjxoYBbBIUcNgeJruPYngF66mRTsqU/6FxwU xVEw== X-Gm-Message-State: AOJu0YyKW3sYPbQ+vcb3NAFso3lakHIGjR//nRb2Wj8X3HE7z6WQGaCe 3kmEYf4BELu5fc9EvvMUskrHEONbNPUlpoISm1mdFB2x1yWtAZA18seS8pc4jEyMeI54KM6SCev by7PC4W4= X-Gm-Gg: AY/fxX6GlsCOuJanGvUcPyPj/Gl2ot2ntUsk5dDUL5VpmYZdNl3tnVznX/KVwcSvPXl nI7oR/urcElW29ZdbRAGlZsWkdlzjj2E7v2Zgy7Lt61MZsPP/EYz5OBL1PqH3UHLZXbYWKcwpEY x4CdT35M9SDVsqLFdE42+/O3Fk+7nYOYsWWeDazsuwz6psqyMf94fqeAsbWwvieFK3g4Zczbv+T LcIjrIJu9pyPu/yLVBkkdBED7S4UbwsLG/21u49WPjhdQZ5mTIAT7WkHOgE0+l2hFS9ivmTjVb9 weIdulOkmA5LTUKKtKleNgOe7Czo/BSCddl95yMdqX8MZFmJ3HKrZf9OOSA5oNZ6tC9jV/iK1Sm BS7bb1SDS7bUaiEdmRf/0FvpHgRX4CDAjOy/hd1ZwxUi0eeUa5Ki6puGoKDFBagdUkfGWJJv04M 5ULDbHpKZhxYX0xfhknqOzcJoIEMMaBhAFK5PPTkK/BYMsSbnj0SLtWK0= X-Google-Smtp-Source: AGHT+IGSLzLhCvqEQm4B2ZOpM4WJ5t1Fze/9IEYqjvatj7Jtdr2wK6XAkqu6aRImnQ9U4d6Av+hsIw== X-Received: by 2002:a17:907:3fa8:b0:b7a:1b3:5e52 with SMTP id a640c23a62f3a-b8036f60918mr1802560866b.17.1766592093275; Wed, 24 Dec 2025 08:01:33 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Manos Pitsidianakis , Pierrick Bouvier , Laurent Vivier , Richard Henderson , Anton Johansson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 6/6] target/alpha: Replace legacy ld_phys() -> address_space_ld() Date: Wed, 24 Dec 2025 17:00:39 +0100 Message-ID: <20251224160040.88612-7-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251224160040.88612-1-philmd@linaro.org> References: <20251224160040.88612-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::62f; envelope-from=philmd@linaro.org; helo=mail-ej1-x62f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1766592164686158500 Prefer the address_space_ld/st API over the legacy ld_phys() because it allow checking for bus access fault. Since we removed the last legacy uses of the legacy ldst_phys() API, set the TARGET_NOT_USING_LEGACY_LDST_PHYS_API variable to hide the legacy API to alpha binaries, avoiding further API uses to creep in. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- configs/targets/alpha-linux-user.mak | 1 + configs/targets/alpha-softmmu.mak | 1 + target/alpha/helper.c | 29 ++++++++++++++++------------ 3 files changed, 19 insertions(+), 12 deletions(-) diff --git a/configs/targets/alpha-linux-user.mak b/configs/targets/alpha-l= inux-user.mak index ee505e16ef4..2f1312f0362 100644 --- a/configs/targets/alpha-linux-user.mak +++ b/configs/targets/alpha-linux-user.mak @@ -4,3 +4,4 @@ TARGET_SYSTBL=3Dsyscall.tbl TARGET_LONG_BITS=3D64 TARGET_XML_FILES=3D gdb-xml/alpha-core.xml TARGET_NOT_USING_LEGACY_NATIVE_ENDIAN_API=3Dy +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy diff --git a/configs/targets/alpha-softmmu.mak b/configs/targets/alpha-soft= mmu.mak index 22fbbf0cb08..5c6af0eafc1 100644 --- a/configs/targets/alpha-softmmu.mak +++ b/configs/targets/alpha-softmmu.mak @@ -2,3 +2,4 @@ TARGET_ARCH=3Dalpha TARGET_LONG_BITS=3D64 TARGET_XML_FILES=3D gdb-xml/alpha-core.xml TARGET_NOT_USING_LEGACY_NATIVE_ENDIAN_API=3Dy +TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy diff --git a/target/alpha/helper.c b/target/alpha/helper.c index 80542cb0665..126a53c829b 100644 --- a/target/alpha/helper.c +++ b/target/alpha/helper.c @@ -169,6 +169,7 @@ static int get_physical_address(CPUAlphaState *env, tar= get_ulong addr, int prot_need, int mmu_idx, target_ulong *pphys, int *pprot) { + const MemTxAttrs attrs =3D MEMTXATTRS_UNSPECIFIED; CPUState *cs =3D env_cpu(env); target_long saddr =3D addr; target_ulong phys =3D 0; @@ -176,6 +177,7 @@ static int get_physical_address(CPUAlphaState *env, tar= get_ulong addr, target_ulong pt, index; int prot =3D 0; int ret =3D MM_K_ACV; + MemTxResult txres; =20 /* Handle physical accesses. */ if (mmu_idx =3D=3D MMU_PHYS_IDX) { @@ -214,18 +216,13 @@ static int get_physical_address(CPUAlphaState *env, t= arget_ulong addr, =20 pt =3D env->ptbr; =20 - /* - * TODO: rather than using ldq_phys_le() to read the page table we sho= uld - * use address_space_ldq() so that we can handle the case when - * the page table read gives a bus fault, rather than ignoring it. - * For the existing code the zero data that ldq_phys_le will return for - * an access to invalid memory will result in our treating the page - * table as invalid, which may even be the right behaviour. - */ - /* L1 page table read. */ index =3D (addr >> (TARGET_PAGE_BITS + 20)) & 0x3ff; - L1pte =3D ldq_phys_le(cs->as, pt + index * 8); + L1pte =3D address_space_ldq_le(cs->as, pt + index * 8, attrs, &txres); + if (txres !=3D MEMTX_OK) { + /* bus fault */ + goto exit; + } =20 if (unlikely((L1pte & PTE_VALID) =3D=3D 0)) { ret =3D MM_K_TNV; @@ -238,7 +235,11 @@ static int get_physical_address(CPUAlphaState *env, ta= rget_ulong addr, =20 /* L2 page table read. */ index =3D (addr >> (TARGET_PAGE_BITS + 10)) & 0x3ff; - L2pte =3D ldq_phys_le(cs->as, pt + index * 8); + L2pte =3D address_space_ldq_le(cs->as, pt + index * 8, attrs, &txres); + if (txres !=3D MEMTX_OK) { + /* bus fault */ + goto exit; + } =20 if (unlikely((L2pte & PTE_VALID) =3D=3D 0)) { ret =3D MM_K_TNV; @@ -251,7 +252,11 @@ static int get_physical_address(CPUAlphaState *env, ta= rget_ulong addr, =20 /* L3 page table read. */ index =3D (addr >> TARGET_PAGE_BITS) & 0x3ff; - L3pte =3D ldq_phys_le(cs->as, pt + index * 8); + L3pte =3D address_space_ldq_le(cs->as, pt + index * 8, attrs, &txres); + if (txres !=3D MEMTX_OK) { + /* bus fault */ + goto exit; + } =20 phys =3D L3pte >> 32 << TARGET_PAGE_BITS; if (unlikely((L3pte & PTE_VALID) =3D=3D 0)) { --=20 2.52.0